Re: pr27650 - dllimport of virtual methods broken.

2006-09-20 Thread Carlos O'Donell
On Tue, Sep 19, 2006 at 10:09:49AM +1200, Danny Smith wrote: Revised patch. Thanks Danny! Tested on i686-pc-mingw32 Danny cp/ChangeLog PR target/27650 * class.c (check_for_override): Remove dllimport from virtual methods. testsuite/Changelog PR

Re: pr27650 - dllimport of virtual methods broken.

2006-09-20 Thread Mark Mitchell
Danny Smith wrote: cp/ChangeLog PR target/27650 * class.c (check_for_override): Remove dllimport from virtual methods. testsuite/Changelog PR target/27650 * g++.dg/ext/dllimport12.C: New file. OK, thanks. -- Mark Mitchell CodeSourcery [EMAIL

RE: pr27650 - dllimport of virtual methods broken.

2006-09-18 Thread Danny Smith
From: Mark Mitchell [mailto:[EMAIL PROTECTED] Sent: Thursday, September 14, 2006 3:38 PM Danny Smith wrote: The problem I had was with the second case below. We don't know if a method is implicitly virtual until search.c:look_for_overrides_r). Would t be better to unset

pr27650 - dllimport of virtual methods broken.

2006-09-13 Thread Carlos O'Donell
Is any of you able to give some comments on pr27650 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27650 In particular I am interested in an opinion of Danny's fix. http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01504.html I definately don't know enough about attributes and dllimport to comment.

Re: pr27650 - dllimport of virtual methods broken.

2006-09-13 Thread Mark Mitchell
Carlos O'Donell wrote: Is any of you able to give some comments on pr27650 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27650 In particular I am interested in an opinion of Danny's fix. http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01504.html I definately don't know enough about attributes and

RE: pr27650 - dllimport of virtual methods broken.

2006-09-13 Thread Danny Smith
From: Mark Mitchell Carlos O'Donell wrote: Is any of you able to give some comments on pr27650 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27650 In particular I am interested in an opinion of Danny's fix. http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01504.html The

Re: pr27650 - dllimport of virtual methods broken.

2006-09-13 Thread Mark Mitchell
Danny Smith wrote: The problem I had was with the second case below. We don't know if a method is implicitly virtual until search.c:look_for_overrides_r). Would t be better to unset DECL_DLLIMPORT_P (and remove the attribute as well) there? Ah, right, good point. I always forget that