Re: raising minimum version of Flex

2007-01-23 Thread Paolo Bonzini
I'm not at all impressed with the recent series of flex releases, since it started using m4 internally and passing user code through m4. (cf. bison, which unlike flex pays proper attention to assuring that arbitrary valid parsers are not mangled by m4). Fully agreed. The recent releases

Re: raising minimum version of Flex

2007-01-23 Thread Mark Kettenis
Vaclav Haisman wrote: Gerald Pfeifer wrote: [...] openSUSE 10.2 now comes with flex 2.5.33, but FreeBSD, for example, still is at flex 2.5.4. Just some additional data pointes... FreeBSD has version 2.5.33 as textproc/flex port. But that will not replace the system flex, so it will

Re: raising minimum version of Flex

2007-01-22 Thread Gerald Pfeifer
On Mon, 21 Jan 2007, Ian Lance Taylor wrote: That doesn't sound right. It see flex being run every time I create a new object directory, even though I don't modify the flex input files. We ship gengtype-lex.c with releases, so people building the compiler from releases shouldn't have to

Re: raising minimum version of Flex

2007-01-22 Thread Václav Haisman
Gerald Pfeifer wrote: [...] openSUSE 10.2 now comes with flex 2.5.33, but FreeBSD, for example, still is at flex 2.5.4. Just some additional data pointes... FreeBSD has version 2.5.33 as textproc/flex port. -- Vaclav Haisman signature.asc Description: OpenPGP digital signature

Re: raising minimum version of Flex

2007-01-22 Thread Marcin Dalecki
Wiadomość napisana w dniu 2007-01-22, o godz06:49, przez Ben Elliston: I think it's worth raising the minimum required version from 2.5.4 to 2.5.31. The latter version was released in March, 2003, so it is hardly bleeding edge. Your definition of bleeding edge doesn't fit mine: $ flex

Re: raising minimum version of Flex

2007-01-22 Thread Tom Tromey
Ian == Ian Lance Taylor [EMAIL PROTECTED] writes: Ben I think it's worth raising the minimum required version from 2.5.4 to Ben 2.5.31. Ian I want to point out that Fedora Core 5 appears to still ship flex Ian 2.5.4. At least, that is what flex --version reports. When this came up on irc, I

Re: raising minimum version of Flex

2007-01-22 Thread Joseph S. Myers
On Mon, 22 Jan 2007, Ben Elliston wrote: I submitted a patch to gengtype-lex.l last week to gcc-patches. The patch uses some flex %option directives. Ian Taylor asked me to check if the patch passed through flex 2.5.4, which is the current minimum required version. It didn't work.

Re: raising minimum version of Flex

2007-01-22 Thread Ben Elliston
Thanks all for the discussion. I think we can conclude that it's not safe to require a newer version of Flex. I withdraw my patch. Cheers, Ben

Re: raising minimum version of Flex

2007-01-22 Thread Mike Stump
On Jan 21, 2007, at 11:48 PM, Ian Lance Taylor wrote: That doesn't sound right. It see flex being run every time I create a new object directory, even though I don't modify the flex input files. Sounds like a bug. I did a quick check with a contrib/gcc_update -- touch and a c,treelang build

Re: raising minimum version of Flex

2007-01-22 Thread Ben Elliston
On Mon, 2007-01-22 at 15:39 -0800, Mike Stump wrote: On Jan 21, 2007, at 11:48 PM, Ian Lance Taylor wrote: That doesn't sound right. It see flex being run every time I create a new object directory, even though I don't modify the flex input files. Sounds like a bug. I did a quick check

raising minimum version of Flex

2007-01-21 Thread Ben Elliston
I submitted a patch to gengtype-lex.l last week to gcc-patches. The patch uses some flex %option directives. Ian Taylor asked me to check if the patch passed through flex 2.5.4, which is the current minimum required version. It didn't work. Through some experimentation, I learned that the

Re: raising minimum version of Flex

2007-01-21 Thread Ian Lance Taylor
Ben Elliston [EMAIL PROTECTED] writes: I think it's worth raising the minimum required version from 2.5.4 to 2.5.31. I want to point out that Fedora Core 5 appears to still ship flex 2.5.4. At least, that is what flex --version reports. (I didn't bother to check this before.) I think we

Re: raising minimum version of Flex

2007-01-21 Thread Steven Bosscher
On 21 Jan 2007 22:13:06 -0800, Ian Lance Taylor [EMAIL PROTECTED] wrote: Ben Elliston [EMAIL PROTECTED] writes: I think it's worth raising the minimum required version from 2.5.4 to 2.5.31. I want to point out that Fedora Core 5 appears to still ship flex 2.5.4. At least, that is what flex

Re: raising minimum version of Flex

2007-01-21 Thread David Fang
I think it's worth raising the minimum required version from 2.5.4 to 2.5.31. I want to point out that Fedora Core 5 appears to still ship flex 2.5.4. At least, that is what flex --version reports. (I didn't bother to check this before.) I think we need a very strong reason to

Re: raising minimum version of Flex

2007-01-21 Thread Ian Lance Taylor
Steven Bosscher [EMAIL PROTECTED] writes: On 21 Jan 2007 22:13:06 -0800, Ian Lance Taylor [EMAIL PROTECTED] wrote: Ben Elliston [EMAIL PROTECTED] writes: I think it's worth raising the minimum required version from 2.5.4 to 2.5.31. I want to point out that Fedora Core 5 appears to