Re: targetm.calls.promote_prototypes parameter

2017-12-06 Thread Jason Merrill
On Wed, Dec 6, 2017 at 2:31 PM, DJ Delorie wrote: > > Jason Merrill writes: >> I'm inclined to change the C++ FE to pass NULL_TREE instead until such >> time as someone cares. > > The sh backend will at least not choke on that ;-) Thus. commit

Re: targetm.calls.promote_prototypes parameter

2017-12-06 Thread DJ Delorie
Jason Merrill writes: > I'm inclined to change the C++ FE to pass NULL_TREE instead until such > time as someone cares. The sh backend will at least not choke on that ;-)

Re: targetm.calls.promote_prototypes parameter

2017-12-06 Thread Jakub Jelinek
On Wed, Dec 06, 2017 at 02:27:55PM -0500, Jason Merrill wrote: > On Wed, Dec 6, 2017 at 12:14 PM, Jakub Jelinek wrote: > > On Wed, Dec 06, 2017 at 11:47:41AM -0500, DJ Delorie wrote: > >> > >> In my original proposal, I said this: > >> > >> > It includes a bunch of macro->hook

Re: targetm.calls.promote_prototypes parameter

2017-12-06 Thread Jason Merrill
On Wed, Dec 6, 2017 at 12:14 PM, Jakub Jelinek wrote: > On Wed, Dec 06, 2017 at 11:47:41AM -0500, DJ Delorie wrote: >> >> In my original proposal, I said this: >> >> > It includes a bunch of macro->hook conversions, mostly because the >> > hooks need an additional parameter (the

Re: targetm.calls.promote_prototypes parameter

2017-12-06 Thread Jakub Jelinek
On Wed, Dec 06, 2017 at 11:47:41AM -0500, DJ Delorie wrote: > > In my original proposal, I said this: > > > It includes a bunch of macro->hook conversions, mostly because the > > hooks need an additional parameter (the function) to detect which ones > > are Renesas ABI and which are GCC ABI. >

Re: targetm.calls.promote_prototypes parameter

2017-12-06 Thread DJ Delorie
In my original proposal, I said this: > It includes a bunch of macro->hook conversions, mostly because the > hooks need an additional parameter (the function) to detect which ones > are Renesas ABI and which are GCC ABI. The original documentation at least hinted that the parameter was a

targetm.calls.promote_prototypes parameter

2017-12-06 Thread Jason Merrill
It seems that when DJ converted TARGET_PROMOTE_PROTOTYPES to a hook, he added a parameter type that was never documented; the name and its initial usage indicate that it was intended to get the type of a function. Later Kazu converted remaining uses of the macro to use the hook, but those calls