https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109256
James Hilliard changed:
What|Removed |Added
Resolution|--- |FIXED
Status|UNCONFIRMED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109256
--- Comment #2 from James Hilliard ---
(In reply to Andrew Pinski from comment #1)
> Even a bad input should cause an error reported rather than a double free.
> So you should at least report it to libbpf too
libbpf bug report:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109256
Bug ID: 109256
Summary: Error: failed to link 'linked_maps2.bpf.o': Cannot
allocate memory (12)
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109255
Bug ID: 109255
Summary: libbpf: global 'input_data1': section mismatch 4 vs 5
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109253
Bug ID: 109253
Summary: libbpf: failed to find BTF info for global/extern
symbol '__divdi3'
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108189
--- Comment #11 from James Hilliard ---
(In reply to Andrew Pinski from comment #1)
> The error is correct at least for C before C23.
Can you clarify where exactly in the C23 specification that this will be
allowed?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108189
--- Comment #9 from James Hilliard ---
(In reply to Andrew Pinski from comment #5)
> Also Clang does not implement this warning at all.
>
> It is a bug in bpf-next really.
What would be the correct way to fix these in bpf-next?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108189
--- Comment #8 from James Hilliard ---
(In reply to Andrew Pinski from comment #7)
> Yes the warning is really still correct even if a closer testcase would be:
> ```
> int f(struct {int t;} *b)
> {
> return b->t;
> }
>
> int f1(void *a)
> {
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108189
--- Comment #2 from James Hilliard ---
(In reply to Andrew Pinski from comment #1)
> The error is correct at least for C before C23.
Hmm, seeing it with -std=gnu2x passed still:
/home/buildroot/opt/cross/bin/bpf-gcc -g -Werror
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108189
Bug ID: 108189
Summary: anonymous struct declared inside parameter list will
not be visible outside of this definition or
declaration
Product: gcc
Version: 13.0
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107983
--- Comment #1 from James Hilliard ---
Working LLVM btf dump:
$ /home/buildroot/bpf-next/tools/testing/selftests/bpf/tools/sbin/bpftool
--debug btf dump file
/home/buildroot/bpf-next/tools/testing/selftests/bpf/task_kfunc_success.bpf.linked3.o
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107983
Bug ID: 107983
Summary: btf: bad call relo against
'test_task_acquire_release_current' in section
'tp_btf/task_newtask'
Product: gcc
Version: 13.0
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #16 from James Hilliard ---
(In reply to David Faust from comment #15)
> Created attachment 54021 [details]
> [v2] DATASEC entries for extern funcs
>
> v2 fixes an off-by-one bug introduced in the patch which was causing
> libbpf:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #14 from James Hilliard ---
(In reply to David Faust from comment #13)
> Created attachment 54017 [details]
> DATASEC entries for extern funcs
>
> Applies on top of 54002: updated patch
> Adds emission of DATASEC entries for extern
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #12 from James Hilliard ---
(In reply to James Hilliard from comment #10)
> (In reply to David Faust from comment #9)
> > Created attachment 54002 [details]
> > updated patch
> >
> > Update the 'extern' variable marking, and also
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #11 from James Hilliard ---
Also hitting this one in cgroup_hierarchical_stats.c:
$ /home/buildroot/bpf-next/tools/testing/selftests/bpf/tools/sbin/bpftool
--debug gen skeleton
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #10 from James Hilliard ---
(In reply to David Faust from comment #9)
> Created attachment 54002 [details]
> updated patch
>
> Update the 'extern' variable marking, and also mark 'extern' funcs.
That fixes the issue in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #7 from James Hilliard ---
There's also this error during skeleton generation for kfunc_call_test.c:
$ /home/buildroot/bpf-next/tools/testing/selftests/bpf/tools/sbin/bpftool
--debug gen skeleton
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #6 from James Hilliard ---
https://github.com/torvalds/linux/blob/v6.1-rc7/tools/testing/selftests/bpf/bpf_legacy.h
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #5 from James Hilliard ---
(In reply to David Faust from comment #4)
> Created attachment 53993 [details]
> proposed patch
>
> Should fix the remaining issues with 'extern' linkage and the missing
> 'const' modifier (and includes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107846
--- Comment #10 from James Hilliard ---
(In reply to Jakub Jelinek from comment #8)
> (In reply to James Hilliard from comment #7)
> > (In reply to Jakub Jelinek from comment #6)
> > > Created attachment 53984 [details]
> > >
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107846
--- Comment #7 from James Hilliard ---
(In reply to Jakub Jelinek from comment #6)
> Created attachment 53984 [details]
> gcc13-pr107846.patch
>
> Untested fix.
This appears to fix error, the warning is still present:
progs/test_tc_tunnel.c:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107848
--- Comment #1 from James Hilliard ---
Working LLVM BTF Dump:
$ /home/buildroot/bpf-next/tools/testing/selftests/bpf/tools/sbin/bpftool
--debug btf dump file
/home/buildroot/bpf-next/tools/testing/selftests/bpf/bpf_dctcp_release.bpf.o
format
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107848
Bug ID: 107848
Summary: libbpf: ELF relo #0 in section #7 has unexpected type
12
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107847
Bug ID: 107847
Summary: error: integer overflow in expression in bpf-next
test_xdp_vlan.c
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107846
Bug ID: 107846
Summary: error: result of '8000 << 8' requires 22 bits to
represent, but 'short int' only has 16 bits
Product: gcc
Version: 13.0
Status: UNCONFIRMED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107844
Bug ID: 107844
Summary: error: argument is not a field access for
__builtin_preserve_field_info
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107843
Bug ID: 107843
Summary: error: incompatible type for argument in
___bpf_ctx_cast2
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #2 from James Hilliard ---
Testing with this patch:
diff --git a/gcc/btfout.cc b/gcc/btfout.cc
index 37ec662c190..ff08d0c5024 100644
--- a/gcc/btfout.cc
+++ b/gcc/btfout.cc
@@ -345,6 +345,8 @@ btf_collect_datasec (ctf_container_ref
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
--- Comment #1 from James Hilliard ---
Getting a different error when running with:
https://patchwork.ozlabs.org/project/gcc/patch/20220901195340.10653-1-david.fa...@oracle.com/
GCC gen object failure:
$
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106773
Bug ID: 106773
Summary: libbpf: failed to find BTF info for global/extern
symbol 'bpf_link_fops'
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106745
Bug ID: 106745
Summary: segfault in bpf_core_get_sou_member_index
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106263
--- Comment #2 from James Hilliard ---
Should this be backported to the gcc 12 branch?
33 matches
Mail list logo
