[Bug c++/53206] overloaded virtual non const warning

2012-05-03 Thread redi at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 --- Comment #8 from Jonathan Wakely 2012-05-03 13:28:50 UTC --- This is slightly contrived: namespace library { struct Interface { virtual void handle(int) = 0; }; struct Implementation : Interface { void handle(int

[Bug c++/53206] overloaded virtual non const warning

2012-05-03 Thread manu at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 --- Comment #7 from Manuel López-Ibáñez 2012-05-03 13:15:11 UTC --- (In reply to comment #6) > In the large codebase I'm working on currently we use -Wall -Wextra but don't > use -Woverloaded-virtual (and we are aware of it, it's in a Makefile bu

[Bug c++/53206] overloaded virtual non const warning

2012-05-03 Thread redi at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 --- Comment #6 from Jonathan Wakely 2012-05-03 10:54:09 UTC --- I don't have a strong opinion. In the large codebase I'm working on currently we use -Wall -Wextra but don't use -Woverloaded-virtual (and we are aware of it, it's in a Makefile but

[Bug c++/53206] overloaded virtual non const warning

2012-05-03 Thread manu at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 --- Comment #5 from Manuel López-Ibáñez 2012-05-03 09:38:13 UTC --- So what is your opinion? Should it be enabled?

[Bug c++/53206] overloaded virtual non const warning

2012-05-03 Thread redi at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 --- Comment #4 from Jonathan Wakely 2012-05-03 08:08:53 UTC --- It depends what you consider a false positive. I imagine it's 100% accurate, but it doesn't always indicate a bug, sometimes it warns about code that behaves exactly as intended. I

[Bug c++/53206] overloaded virtual non const warning

2012-05-02 Thread manu at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 Manuel López-Ibáñez changed: What|Removed |Added CC||manu at gcc dot gnu.org --- Comment

[Bug c++/53206] overloaded virtual non const warning

2012-05-02 Thread paolo.carlini at oracle dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 Paolo Carlini changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|

[Bug c++/53206] overloaded virtual non const warning

2012-05-02 Thread pinskia at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53206 --- Comment #1 from Andrew Pinski 2012-05-03 01:38:14 UTC --- -Woverloaded-virtual is not enabled by either -Wextra or -Wall right now.