[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-03-09 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 Jakub Jelinek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-03-09 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 --- Comment #12 from Jakub Jelinek --- Author: jakub Date: Tue Mar 10 06:38:57 2015 New Revision: 221299 URL: https://gcc.gnu.org/viewcvs?rev=221299&root=gcc&view=rev Log: PR c/65120 * c-common.c (warn_logical_not_parentheses): Don't war

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-03-09 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 --- Comment #11 from Jakub Jelinek --- Author: jakub Date: Mon Mar 9 18:26:52 2015 New Revision: 221284 URL: https://gcc.gnu.org/viewcvs?rev=221284&root=gcc&view=rev Log: PR c/65120 * c-typeck.c (parser_build_binary_op): Don't warn for

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-03-06 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 --- Comment #10 from Richard Biener --- It was just noted that "But then again (!a == 0) is the same as !(a == 0), so the warning is pretty pointless when the right side is constant zero." so we should probably not warn for this case either.

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-03-04 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 --- Comment #9 from Richard Biener --- Btw, just saw > [ 2808s] ../drivers/xen/sfc_netfront/falcon_event.c:113:43: error: logical > not is only applied to the left hand side of comparison > [-Werror=logical-not-parentheses] > [ 2808s] BUG_ON(

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-26 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 Marek Polacek changed: What|Removed |Added CC||mpolacek at gcc dot gnu.org --- Comment

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-26 Thread aldyh at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 Aldy Hernandez changed: What|Removed |Added CC||aldyh at gcc dot gnu.org --- Comment #7

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-19 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 Jakub Jelinek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned a

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-19 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org --- Comment #5

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-19 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 --- Comment #4 from Richard Biener --- Oh, you can also workaround with if (b == !!a)

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-19 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 --- Comment #3 from Richard Biener --- And yes, the required if ((!!a) == b) is totally fugly.

[Bug c/65120] [5 Regression] Wlogical-not-parentheses should not warn about double exclamation !!

2015-02-19 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65120 Richard Biener changed: What|Removed |Added Keywords||diagnostic Status|UNCONFIRM