https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
anlauf at gcc dot gnu.org changed:
What|Removed |Added
CC||antoine.lemoine@bordeaux-in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
anlauf at gcc dot gnu.org changed:
What|Removed |Added
Target Milestone|13.2|13.3
--- Comment #23 from
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
anlauf at gcc dot gnu.org changed:
What|Removed |Added
CC||alexandre.poux at coria dot
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #21 from CVS Commits ---
The releases/gcc-13 branch has been updated by Paul Thomas :
https://gcc.gnu.org/g:d6997a5aab7aaa325946a6283bfee8ac2bd9f540
commit r13-7761-gd6997a5aab7aaa325946a6283bfee8ac2bd9f540
Author: Paul Thomas
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
Paul Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #19 from Paul Thomas ---
(In reply to anlauf from comment #16)
> (In reply to Paul Thomas from comment #15)
> > Created attachment 55225 [details]
> > Fix for this PR
> >
> > The attached patch substantially tidies up
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #18 from CVS Commits ---
The master branch has been updated by Paul Thomas :
https://gcc.gnu.org/g:3c2eba4b7a2355ed5099e35332388206c484744d
commit r14-1487-g3c2eba4b7a2355ed5099e35332388206c484744d
Author: Paul Thomas
Date: Fri
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #17 from Mikael Morin ---
(In reply to anlauf from comment #16)
> (In reply to Paul Thomas from comment #15)
> > Created attachment 55225 [details]
> > Fix for this PR
> >
> > The attached patch substantially tidies up
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #16 from anlauf at gcc dot gnu.org ---
(In reply to Paul Thomas from comment #15)
> Created attachment 55225 [details]
> Fix for this PR
>
> The attached patch substantially tidies up parse_associate and fixes:
LGTM!
I was close
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
Paul Thomas changed:
What|Removed |Added
Assignee|unassigned at gcc dot gnu.org |pault at gcc dot gnu.org
---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #14 from Paul Thomas ---
Hi Mikael,
> Mmh, in a sense it also "double breaks" it. For example, with
> associate(z=>array(1)%ar(2,3)%array(:,:,:)), I expect to get the wrong as in
> ref->u.ar.as for the last two array references.
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #13 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #12)
> + && e->symtree->n.sym->assoc->target->ref
> + && e->symtree->n.sym->assoc->target->ref->u.ar.type == AR_FULL
> + &&
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #12 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #11)
> I think it does not handle the following variation of the testcase from
> the blamed patch:
This one seems to be handled by the clumsy attempt:
diff
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #11 from anlauf at gcc dot gnu.org ---
(In reply to Paul Thomas from comment #9)
> By the way, the patch regtests OK
>
> Do you want to do the honours or shall I?
>
> I think that this rates as an 'obvious' fix.
I think it does
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
Mikael Morin changed:
What|Removed |Added
CC||mikael at gcc dot gnu.org
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #9 from Paul Thomas ---
By the way, the patch regtests OK
Do you want to do the honours or shall I?
I think that this rates as an 'obvious' fix.
Paul
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
Paul Thomas changed:
What|Removed |Added
Blocks||87477
--- Comment #8 from Paul Thomas
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #7 from anlauf at gcc dot gnu.org ---
Some more digging: in the case when ref->u.ar.as is NULL, it appears that
e->symtree->n.sym->assoc->target->ref->u.ar.as
is properly set.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
anlauf at gcc dot gnu.org changed:
What|Removed |Added
CC||pault at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
Richard Biener changed:
What|Removed |Added
Priority|P3 |P4
Target Milestone|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #5 from Rimvydas (RJ) ---
(In reply to anlauf from comment #4)
> Can you check if this works for you?
This patch allows to avoid issue on all other associate use cases (tried on
gcc-13 branch).
However it is a bit suspicious that
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #4 from anlauf at gcc dot gnu.org ---
The following patch fixes NULL pointer dereference with the reduced
testcases:
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 83e45f1b693..89c62b3eb1e 100644
---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to Rimvydas (RJ) from comment #1)
> More trivial testcase resulting in similar ICE.
Yep, even smaller:
subroutine foo(k_2d)
implicit none
integer :: k_2d(:)
integer :: i
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
anlauf at gcc dot gnu.org changed:
What|Removed |Added
Keywords||ice-on-valid-code
Ever
24 matches
Mail list logo
