https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Markus Trippelsdorf changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #13 from Jan Hubicka ---
Author: hubicka
Date: Tue Jan 20 20:03:23 2015
New Revision: 219910
URL: https://gcc.gnu.org/viewcvs?rev=219910&root=gcc&view=rev
Log:
PR ipa/63576
* ipa-utils.c (ipa_merge_profiles): Merge speculativ
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #12 from Markus Trippelsdorf ---
Martin pointed out that the assertion gets also hit in a pure LTO Firefox
build.
See PR64686.
When I comment out that assertion, Firefox LTO/PGO now builds fine with your
patch and the trivial fix fro
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #11 from Markus Trippelsdorf ---
And if I try the obvious fix:
637 else if (e2 && e2->speculative)
I hit the assert in ipa-inline.c later on:
lto1: internal compiler error: in edge_badness, at ipa-inline.c:912
0x100bf73 e
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #10 from Markus Trippelsdorf ---
Unfortunately your patch dosen't work:
lto1: internal compiler error: Segmentation fault
0xa12f6f crash_signal
../../gcc/gcc/toplev.c:381
0x88b190 ipa_merge_profiles(cgraph_node*, cgraph_node*
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #9 from Markus Trippelsdorf ---
I will give your patch a try.
In case it might help here's the script I use for LTO/PGO
(as you can see it starts the instrumented browser. I then
just visit a couple of webpages to train it):
markus@x
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #8 from Jan Hubicka ---
Markus,
I don't seem to be able to train firefox with current tree because of unrelated
issues. If you would have chance to test the patch on your setup, it would be
cool.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #7 from Jan Hubicka ---
Created attachment 34490
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34490&action=edit
Proposed fix
I am going to try build firefox with PDO myself with the attached patch. It is
bit tricky to merge t
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Jan Hubicka changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|unassigned at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #5 from Jan Hubicka ---
I don't seem to be able to make sense of Ilya's logic in the probability
calculation (incrementing the count with bb->count seem wrong).
Will try to update his patch today.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Markus Trippelsdorf changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Richard Biener changed:
What|Removed |Added
Priority|P3 |P1
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Ilya Palachev changed:
What|Removed |Added
CC||i.palachev at samsung dot com
--- Commen
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Richard Biener changed:
What|Removed |Added
Target Milestone|--- |5.0
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
Jan Hubicka changed:
What|Removed |Added
CC||hubicka at gcc dot gnu.org
--- Comment #2
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63576
--- Comment #1 from Martin Liška ---
Do you have Honza an idea how to handle correctly situation, where ipa_profile
is called before IPA ICF and we mark speculative an edge in:
#0 cgraph_edge::make_speculative (this=this@entry=0x769e8c98,
n
16 matches
Mail list logo
