[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-04 Thread jwakely dot gcc at gmail dot com
--- Comment #19 from jwakely dot gcc at gmail dot com 2008-09-04 22:40 --- fixed for 4.4 -- jwakely dot gcc at gmail dot com changed: What|Removed |Added Sta

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-04 Thread redi at gcc dot gnu dot org
--- Comment #18 from redi at gcc dot gnu dot org 2008-09-04 22:34 --- Subject: Bug 36962 Author: redi Date: Thu Sep 4 22:33:10 2008 New Revision: 140012 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140012 Log: PR libstdc++/36962 * include/Makefile.am: Update h

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-04 Thread jwakely dot gcc at gmail dot com
--- Comment #17 from jwakely dot gcc at gmail dot com 2008-09-04 21:39 --- Created an attachment (id=16226) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16226&action=view) new patch As requested, except I didn't split tr1_impl/boost_sp_counted_base.h My preference would be to l

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-04 Thread paolo dot carlini at oracle dot com
--- Comment #16 from paolo dot carlini at oracle dot com 2008-09-04 14:00 --- Great, thanks a lot again. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36962

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-04 Thread jwakely dot gcc at gmail dot com
--- Comment #15 from jwakely dot gcc at gmail dot com 2008-09-04 13:52 --- Sure, I can do that -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36962

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-04 Thread paolo dot carlini at oracle dot com
--- Comment #14 from paolo dot carlini at oracle dot com 2008-09-04 09:12 --- Jonathan, while we are at it, can we also unify tr1/boost_sp_shared_count.h and tr1/boost_shared_ptr.h, likewise for bits/boost_sp_shared_count.h and bits/boost_shared_ptr.h? Moreover, for the sake of clarity

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-03 Thread paolo dot carlini at oracle dot com
--- Comment #13 from paolo dot carlini at oracle dot com 2008-09-04 01:11 --- Great Jonathan. Tomorrow I'll regtest it again on machines and likely commit it. Well, consider also posting the patch to the mailing list... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36962

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-03 Thread jwakely dot gcc at gmail dot com
--- Comment #12 from jwakely dot gcc at gmail dot com 2008-09-03 23:43 --- Created an attachment (id=16216) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16216&action=view) updated patch this replaces tr1_impl/boost_shared_ptr.h with separate files in tr1/ and bits/ as well as im

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-03 Thread jwakely dot gcc at gmail dot com
--- Comment #11 from jwakely dot gcc at gmail dot com 2008-09-03 15:08 --- Yes, the problem is with result_of, not my changes to shared_ptr. It will work with unique_ptr if a type D::result_type exists, so I'll submit the new patch tonight. -- http://gcc.gnu.org/bugzilla/show_bug.

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-03 Thread paolo dot carlini at oracle dot com
--- Comment #10 from paolo dot carlini at oracle dot com 2008-09-03 15:04 --- Sure, no problem. Let's just do the split and implement as much as the unique_ptr changes as possible. If then updating result_of for C++0x is enough, everything is perfectly fine. -- http://gcc.gnu.org/b

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-09-03 Thread jwakely dot gcc at gmail dot com
--- Comment #9 from jwakely dot gcc at gmail dot com 2008-09-03 15:00 --- I have another patch ready for this, but it doesn't work with unique_ptr where D is a reference type, due to Bug 37351 e.g. constructing from unique_ptr&> fails to compile because std::reference_wrapper>::operat

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-08-05 Thread paolo dot carlini at oracle dot com
--- Comment #8 from paolo dot carlini at oracle dot com 2008-08-05 19:26 --- Excellent. Thanks a lot again, Jonathan. -- paolo dot carlini at oracle dot com changed: What|Removed |Added -

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-08-05 Thread jwakely dot gcc at gmail dot com
--- Comment #7 from jwakely dot gcc at gmail dot com 2008-08-05 19:06 --- (In reply to comment #5) > Hi again. I have essentially only one substantive comment: can you double > check > the implementation is correct vs 20.7.12.2.1/37 ? I believe the use of std::ref was to make the D pa

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-31 Thread paolo dot carlini at oracle dot com
--- Comment #6 from paolo dot carlini at oracle dot com 2008-07-31 11:03 --- By the way, I'm under the impression that the differences between the TR1 and the C++0x versions are by now too many, way too many macros. At some point we should byte the bullet and separate completely for a g

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-31 Thread paolo dot carlini at oracle dot com
--- Comment #5 from paolo dot carlini at oracle dot com 2008-07-31 08:59 --- Hi again. I have essentially only one substantive comment: can you double check the implementation is correct vs 20.7.12.2.1/37 ? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36962

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-30 Thread paolo dot carlini at oracle dot com
--- Comment #4 from paolo dot carlini at oracle dot com 2008-07-30 21:49 --- Many thanks Jonathan! By the time you will be back online, my comments will be ready and in any case will be able to commit the changes! Thanks again, Paolo. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-30 Thread jwakely dot gcc at gmail dot com
--- Comment #3 from jwakely dot gcc at gmail dot com 2008-07-30 21:27 --- Created an attachment (id=15979) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15979&action=view) unique_ptr and rvalue-reference updates from WP I'm going to be offline until next week so here's what I hav

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-29 Thread paolo dot carlini at oracle dot com
--- Comment #2 from paolo dot carlini at oracle dot com 2008-07-29 19:28 --- Ok, Jonathan. You are the share_ptr expert here, I'll wait for you until, say, middle of August, then will go ahead myself, it seems a small task. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36962

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-29 Thread jwakely dot gcc at gmail dot com
--- Comment #1 from jwakely dot gcc at gmail dot com 2008-07-29 19:24 --- I will try to look at it next week some time, but don't have much spare time in the near future, so don't hold your breath for me to do it. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36962

[Bug libstdc++/36962] [C++0x] Add constructors / assignment operators from unique_ptr to shared_ptr

2008-07-29 Thread paolo dot carlini at oracle dot com
-- paolo dot carlini at oracle dot com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Last re