https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
Jonathan Wakely changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Target Milestone|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #16 from GCC Commits ---
The master branch has been updated by Jonathan Wakely :
https://gcc.gnu.org/g:73ad57c244c283bf6da0c16630212f11b945eda5
commit r15-1693-g73ad57c244c283bf6da0c16630212f11b945eda5
Author: Jonathan Wakely
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #15 from Jonathan Wakely ---
Oops, that's definitely not intended! Good catch, thanks.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #14 from Kristian Spangsege
---
Is the underscore intended before `Guard` in `explicit _Guard(__c_locale) { }`
for the GLIBC <= 2.2 case?
Besides that, the full patch looks correct to me.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
Jonathan Wakely changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #12 from Kristian Spangsege
---
These changes look good to me.
A couple of points:
* Should the `else`s still be there now that the preceding branches terminate
with `break`?
* `do_out()` has the same problem as `do_in()`.
* If
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #11 from Jonathan Wakely ---
This changes the loop to always run if the input is non-empty, and so return
partial if the destination is empty.
--- a/libstdc++-v3/config/locale/gnu/codecvt_members.cc
+++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #10 from Jonathan Wakely ---
Whereas the GNU locale has that check inside a loop, which is never entered
when the destination buffer is zero sized, i.e. __to == __to_end
if (__from_next < __from_end && __ret == ok)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #9 from Jonathan Wakely ---
(In reply to Kristian Spangsege from comment #7)
> Curiously, this bug does not occur when using the Cygwin or MinGW versions
> of GCC. In these cases, the result is `partial` as it should be. I assume
>
--- Comment #1 from tsyvarev at ispras dot ru 2008-09-11 09:35 ---
Created an attachment (id=16291)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16291action=view)
test.cpp
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
--- Comment #2 from paolo dot carlini at oracle dot com 2008-09-11 10:31
---
http://gcc.gnu.org/ml/libstdc++/2008-09/msg00090.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37475
11 matches
Mail list logo
