http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40088
Jackie Rosen jackie.rosen at hushmail dot com changed:
What|Removed |Added
CC|
--- Comment #14 from paolo dot carlini at oracle dot com 2009-12-22 10:09
---
I think this PR can be closed: if the program doesn't change the global locale
the mutex is not used anymore, is only incremented a reference count. As an
enhancement we can do better, indeed, but the issues
--- Comment #11 from paolo at gcc dot gnu dot org 2009-12-18 09:41 ---
Subject: Bug 40088
Author: paolo
Date: Fri Dec 18 09:41:03 2009
New Revision: 155342
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=155342
Log:
2009-12-18 Jimmy Guo j...@yahoo-inc.com
PR
--- Comment #12 from paolo dot carlini at oracle dot com 2009-12-18 09:51
---
David, I committed a patch which should alleviate the problem, any chance you
can tell us whether you are seeing an improvement?
More tweaks (within the C++0x model still) are possible, but seems hard to
--- Comment #13 from paolo dot carlini at oracle dot com 2009-12-18 09:57
---
I meant C++03, sorry.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40088
--
paolo dot carlini at oracle dot com changed:
What|Removed |Added
AssignedTo|unassigned at gcc dot gnu |paolo dot carlini at oracle
|dot org
--- Comment #10 from paolo dot carlini at oracle dot com 2009-06-07 11:07
---
Benjamin, do you have a strong opinion about this issue? I don't, really, but
especially in the light of the C++0x drafts (thanks to Greg for pointing it
out), I would close for now the issue with a patch
--- Comment #9 from veloso at verylowsodium dot com 2009-05-22 21:03
---
(In reply to comment #4)
Hm. I wonder how the global locale is supposed to interact with multiple
threads anyway (in the face of C++ not knowing about threads). Would it be
a conforming implementation to put
--- Comment #1 from paolo dot carlini at oracle dot com 2009-05-10 09:40
---
System type? More generally, please provide all the informations detailed in:
http://gcc.gnu.org/bugs.html
Thanks.
--
paolo dot carlini at oracle dot com changed:
What|Removed
--- Comment #2 from paolo dot carlini at oracle dot com 2009-05-10 10:14
---
It's the default contructor of std::locale.
--
paolo dot carlini at oracle dot com changed:
What|Removed |Added
--- Comment #3 from paolo dot carlini at oracle dot com 2009-05-10 10:42
---
David, are you aware of implementations not affected by this problem while
providing thread-safe locale::locale() and locale::global, thus much smarter in
the way ios_base deals with locale or you have a
--- Comment #4 from rguenth at gcc dot gnu dot org 2009-05-10 11:52 ---
Hm. I wonder how the global locale is supposed to interact with multiple
threads anyway (in the face of C++ not knowing about threads). Would it be
a conforming implementation to put the global locale into
--- Comment #5 from rguenth at gcc dot gnu dot org 2009-05-10 12:12 ---
Btw, from a quick look the global mutex could be easily replaced with
atomic updates of the reference counts (it seems they already are
atomic) and atomic exchanges of the locale pointer.
Atomically fetching the
--- Comment #6 from rguenth at gcc dot gnu dot org 2009-05-10 12:14 ---
Thus, I was meaning to say that
Index: src/locale_init.cc
===
--- src/locale_init.cc (revision 147329)
+++ src/locale_init.cc (working copy)
@@
--- Comment #7 from rguenth at gcc dot gnu dot org 2009-05-10 12:21 ---
I should scroll down - ignore my comments.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40088
--- Comment #8 from paolo dot carlini at oracle dot com 2009-05-10 12:34
---
:) In any case, before attempting anything here, I recommend also re-analyzing
libstdc++/12658.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40088
16 matches
Mail list logo
