--- Comment #23 from jason at gcc dot gnu dot org 2010-05-27 18:40 ---
Subject: Bug 42832
Author: jason
Date: Thu May 27 18:39:46 2010
New Revision: 159940
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=159940
Log:
Revert:
PR libstdc++/42832
*
--- Comment #24 from paolo dot carlini at oracle dot com 2010-05-27 20:52
---
Can be closed.
--
paolo dot carlini at oracle dot com changed:
What|Removed |Added
--- Comment #22 from rguenther at suse dot de 2010-05-21 08:28 ---
Subject: Re: Revisit std::function for aliasing issues
and efficiency
On Thu, 20 May 2010, jason at gcc dot gnu dot org wrote:
--- Comment #21 from jason at gcc dot gnu dot org 2010-05-20 16:49
---
The
--- Comment #17 from jason at gcc dot gnu dot org 2010-05-20 15:13 ---
Hmm...I tried reverting the change to functional::swap, but all the libstdc++
tests still pass on x86_64-linux, and I haven't been able to write a failing
testcase either. Anyone else have a testcase that still
--- Comment #18 from rguenther at suse dot de 2010-05-20 15:17 ---
Subject: Re: Revisit std::function for aliasing issues
and efficiency
On Thu, 20 May 2010, jason at gcc dot gnu dot org wrote:
--- Comment #17 from jason at gcc dot gnu dot org 2010-05-20 15:13
---
--- Comment #19 from jason at gcc dot gnu dot org 2010-05-20 15:40 ---
Aha. That sounds good to me; I don't expect your testcase to work, because it
doesn't involve a char buffer. The copy does need to use the object
representation, but I think the new-expression should be undefined
--- Comment #20 from rguenther at suse dot de 2010-05-20 15:44 ---
Subject: Re: Revisit std::function for aliasing issues
and efficiency
On Thu, 20 May 2010, jason at gcc dot gnu dot org wrote:
--- Comment #19 from jason at gcc dot gnu dot org 2010-05-20 15:40
---
Aha.
--- Comment #21 from jason at gcc dot gnu dot org 2010-05-20 16:49 ---
The alias_set_subset_of change isn't in 4.5? Then that's not what's making the
libstdc++ function tests pass with the swap change reverted...:)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42832
--- Comment #14 from rguenth at gcc dot gnu dot org 2010-01-27 15:49
---
Subject: Bug 42832
Author: rguenth
Date: Wed Jan 27 15:49:00 2010
New Revision: 156290
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=156290
Log:
2010-01-27 Richard Guenther rguent...@suse.de
PR
--- Comment #15 from rguenth at gcc dot gnu dot org 2010-01-27 15:51
---
Doesn't depend on fixed memcpy, no longer blocks 42617. Depends on 42845
for enhancing the fix.
--
rguenth at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #16 from paolo dot carlini at oracle dot com 2010-01-27 15:57
---
Thanks!
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42832
--- Comment #8 from rguenth at gcc dot gnu dot org 2010-01-26 14:04 ---
Created an attachment (id=19711)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19711action=view)
patch
Candidate fix.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42832
--- Comment #9 from rguenth at gcc dot gnu dot org 2010-01-26 14:05 ---
Mine.
--
rguenth at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #10 from paolo dot carlini at oracle dot com 2010-01-26 14:25
---
I'm not completely sure that the tr1 version actually includes indirectly
std::swap. Please check that and in case just add bits/move.h, is enough and
works also in non-C++0x mode.
Otherwise, you are cleared
--- Comment #11 from rguenther at suse dot de 2010-01-26 14:34 ---
Subject: Re: Revisit std::function for aliasing
issues
On Tue, 26 Jan 2010, paolo dot carlini at oracle dot com wrote:
--- Comment #10 from paolo dot carlini at oracle dot com 2010-01-26
14:25 ---
I'm
--- Comment #12 from paolo dot carlini at oracle dot com 2010-01-26 14:37
---
Are you sure? The std version should be fine, via utility (remember the std
version is enabled *only* in C++0x mode).
I mean the depends on and blocks fields.
--
--- Comment #13 from rguenther at suse dot de 2010-01-26 14:57 ---
Subject: Re: Revisit std::function for aliasing
issues
On Tue, 26 Jan 2010, paolo dot carlini at oracle dot com wrote:
--- Comment #12 from paolo dot carlini at oracle dot com 2010-01-26
14:37 ---
Are
--- Comment #5 from paolo dot carlini at oracle dot com 2010-01-25 10:10
---
Ok, I see that asking was a good idea, the tangle of issues is quite complex.
Anyway, this is my current proposal: let' use for now your mildly optimized and
in any case correct solution using a loop of
--- Comment #6 from rguenther at suse dot de 2010-01-25 16:29 ---
Subject: Re: Revisit std::function for aliasing
issues
On Mon, 25 Jan 2010, paolo dot carlini at oracle dot com wrote:
--- Comment #5 from paolo dot carlini at oracle dot com 2010-01-25 10:10
---
Ok, I
--- Comment #7 from paolo dot carlini at oracle dot com 2010-01-25 17:36
---
Ageeed. Indeed, I see there is a discussion ongoing. In the present time frame
let's figure out something minimally invasive, decently (if not perfectly)
optimized, and minimally coupled one way or the other
--- Comment #2 from paolo dot carlini at oracle dot com 2010-01-24 18:42
---
Richard, I'm sorry, I realize now that I'm confused about an important point:
does your analysis of function::swap mean that we are *already* miscompiling
it? Or, are we going to commit patches which will lead
--- Comment #3 from rguenther at suse dot de 2010-01-24 20:50 ---
Subject: Re: Revisit std::function for aliasing
issues
On Sun, 24 Jan 2010, paolo dot carlini at oracle dot com wrote:
--- Comment #2 from paolo dot carlini at oracle dot com 2010-01-24 18:42
---
Richard,
--- Comment #4 from rguenth at gcc dot gnu dot org 2010-01-24 21:22 ---
Blocks improvement/regression fix for PR42617 (has patches attached to
reproduce
this bug).
--
rguenth at gcc dot gnu dot org changed:
What|Removed |Added
--
paolo dot carlini at oracle dot com changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last
--- Comment #1 from paolo dot carlini at oracle dot com 2010-01-21 16:58
---
Let's add Richard too.
--
paolo dot carlini at oracle dot com changed:
What|Removed |Added
25 matches
Mail list logo
