[Bug libstdc++/43525] Useless condition: if (__x-_M_right != __y)

2010-03-25 Thread paolo dot carlini at oracle dot com
--- Comment #1 from paolo dot carlini at oracle dot com 2010-03-25 20:44 --- Makes sense. I'm still a bit reluctant to change this for 4.5.0. The last time we improved a bit the RB tree implementation we compared it to the one used in the Linux kernel, can you do it and confirm? --

[Bug libstdc++/43525] Useless condition: if (__x-_M_right != __y)

2010-03-25 Thread paolo dot carlini at oracle dot com
--- Comment #2 from paolo dot carlini at oracle dot com 2010-03-25 21:04 --- Evidently, the condition isn't always true: if I replace it with a call to __builtin_abort() when __x-_M_right == __y then 21_strings/basic_string/requirements/exception/generation_prohibited.cc aborts. I

[Bug libstdc++/43525] Useless condition: if (__x-_M_right != __y)

2010-03-25 Thread ninive at gmx dot at
--- Comment #3 from ninive at gmx dot at 2010-03-25 21:30 --- Hi Paolo, Yes, you are right, I forgot the NULL value. Sorry for disturbing. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43525

[Bug libstdc++/43525] Useless condition: if (__x-_M_right != __y)

2010-03-25 Thread paolo dot carlini at oracle dot com
--- Comment #4 from paolo dot carlini at oracle dot com 2010-03-25 21:38 --- Ok. No problem. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43525