https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #19 from CVS Commits ---
The master branch has been updated by Jonathan Wakely :
https://gcc.gnu.org/g:5f070ba29803c99a5fe94ed7632d7b8c55593df3
commit r11-7867-g5f070ba29803c99a5fe94ed7632d7b8c55593df3
Author: Jonathan Wakely
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #18 from Michel Morin ---
Thanks, much appreciated!
(In reply to Jonathan Wakely from comment #17)
> That's how new features work. If you want to use them, you need the new
> version. The time for adding new features to GCC 9 was
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #17 from Jonathan Wakely ---
(In reply to Michel Morin from comment #15)
> I just felt that waiting for GCC-10 (i.e. about a year) is a bit too long.
That's how new features work. If you want to use them, you need the new
version.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #16 from Jonathan Wakely ---
Author: redi
Date: Thu Jun 27 11:31:02 2019
New Revision: 272748
URL: https://gcc.gnu.org/viewcvs?rev=272748=gcc=rev
Log:
PR libstdc++/85494 use rand_s in std::random_device
This is a minimal fix for
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #15 from Michel Morin ---
> Backporting to stable branches should not be done as a way to find bugs.
Makes sense. I stand corrected.
> The patch affects all targets, not just the ones currently using a PRNG, so
> it's not as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #14 from Jonathan Wakely ---
Backporting to stable branches should not be done as a way to find bugs. Quite
the opposite!
The patch affects all targets, not just the ones currently using a PRNG, so
it's not as simple as just saying
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #13 from Michel Morin ---
Pushing this into GCC-9 might help finding bugs (if there are some) and
I think having non-deterministic `random_device` _with possible small bugs_
would be more important than having deterministic one.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #12 from Jonathan Wakely ---
In theory it could, but it's a non-trivial change, and I don't know how much
testing it's had on mingw-w64 yet.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
Michel Morin changed:
What|Removed |Added
CC||mimomorin at gmail dot com
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #10 from Jonathan Wakely ---
Author: redi
Date: Wed May 29 22:00:57 2019
New Revision: 271756
URL: https://gcc.gnu.org/viewcvs?rev=271756=gcc=rev
Log:
PR libstdc++/85494 fix failing test
This test now fails on mingw-w64 because
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
Jonathan Wakely changed:
What|Removed |Added
Target|mingw |*-*-mingw*
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #8 from Jonathan Wakely ---
Author: redi
Date: Wed May 29 14:45:35 2019
New Revision: 271740
URL: https://gcc.gnu.org/viewcvs?rev=271740=gcc=rev
Log:
PR libstdc++/85494 use rdseed and rand_s in std::random_device
Add support for
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
Jonathan Wakely changed:
What|Removed |Added
Target Milestone|9.0 |10.0
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
Jonathan Wakely changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #6 from Dimitrij Mijoski ---
I read the patch couple of times and seems completely OK. Can you push it to
the repository (or to a fork)?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #5 from Jonathan Wakely ---
Proposed patch posted to https://gcc.gnu.org/ml/libstdc++/2018-10/msg00082.html
I would be grateful for any testing you can do on mingw targets.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #4 from Jonathan Wakely ---
Thanks, but please see https://gcc.gnu.org/contribute.html#legal
We can't use a patch without those steps being completed.
Also patches should be sent to the mailing lists, not attached to bugzilla, see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
--- Comment #3 from Dimitrij Mijoski ---
Created attachment 44358
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44358=edit
implements proper random_device for mingw-w64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
Dimitrij Mijoski changed:
What|Removed |Added
CC||dmjpp at hotmail dot com
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494
Jonathan Wakely changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
20 matches
Mail list logo