[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-07-27 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #16 from GCC Commits --- The master branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:e69456ff9a54ba3e9c93842b05757b7d8fff6d9d commit r15-2356-ge69456ff9a54ba3e9c93842b05757b7d8fff6d9d Author: Jonathan Wakely Date:

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-07-16 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #15 from Jonathan Wakely --- The wmemchr case is covered by PR 115040

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-07-15 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #14 from Andrew Pinski --- (In reply to GCC Commits from comment #13) > The master branch has been updated by Jonathan Wakely : > > https://gcc.gnu.org/g:de19b516edbf919d31e9d22fdbf6066342d904a2 > > commit r15-1857-gde19b516edbf919d

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-07-05 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #13 from GCC Commits --- The master branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:de19b516edbf919d31e9d22fdbf6066342d904a2 commit r15-1857-gde19b516edbf919d31e9d22fdbf6066342d904a2 Author: Jonathan Wakely Date:

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-07-01 Thread tnfchris at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #12 from Tamar Christina --- I had a bug in the benchmark, I forgot to set taskset, These are the correct ones: ++---+-+-+ | NEEDLE | scalar 1x | vect| memchr | ++---+-+--

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-07-01 Thread tnfchris at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #11 from Tamar Christina --- (In reply to Jonathan Wakely from comment #9) > Patch posted: https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653731.html > > Rerunning benchmarks with this patch would be very welcome. OK, I have te

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-06-27 Thread hiraditya at msn dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #10 from AK --- With this patch find of int8_t gets converted to memchr. Using testcase from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115040 as example. With the patch posted in https://gcc.gnu.org/pipermail/gcc-patches/2024-June/

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-06-05 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 Jonathan Wakely changed: What|Removed |Added URL||https://gcc.gnu.org/piperma

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-06-05 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #8 from Jonathan Wakely --- Yes, but it's only a missed-optimization bug so there are much higher priorities.

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-06-03 Thread hiraditya at msn dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #7 from AK --- Is there a plan to push a patch for this?

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-05-14 Thread hiraditya at msn dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #6 from AK --- > We can use memchr to find a char in a range of signed char, or even to find > an int in a range of signed char, as long as we're careful about values. +1, this approach should fix the bug i reported https://gcc.gnu.

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-05-14 Thread hiraditya at msn dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 AK changed: What|Removed |Added CC||hiraditya at msn dot com --- Comment #5 from AK --

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-05-14 Thread gcc at gms dot tf via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #4 from Georg Sauthoff --- Sam, thank you for the hint and surfacing it again. (In reply to Jonathan Wakely from comment #2) [..] > I would prefer to do simply: [..] Yes, please go ahead with your approach. > I think we're going t

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-05-13 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 --- Comment #3 from Jonathan Wakely --- (In reply to Jonathan Wakely from comment #2) > + using _ValT = typename iterator_traits<_InputIterator>::value_type; > + if constexpr (is_same_v<_ValT, _Tp>) > + if constexpr (__is_byte<_Va

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-05-13 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 Jonathan Wakely changed: What|Removed |Added Keywords||missed-optimization --- Comment #2 fro

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2024-05-10 Thread sjames at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 Sam James changed: What|Removed |Added CC||sjames at gcc dot gnu.org --- Comment #1 fro

[Bug libstdc++/88545] std::find compile to memchr in trivial random access cases (patch)

2019-01-07 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88545 Jonathan Wakely changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|