https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
Andi Kleen changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #1 from Andi Kleen ---
I investigated this a bit.
The problem is in get_chain_decl() in the nested function lowering because Cilk
creates nested functions.
info->outer is NULL
created_nesting_tree does this
for (cgn = cgn->neste
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
Igor Zamyatin changed:
What|Removed |Added
CC||izamyatin at gmail dot com
--- Comment #2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #3 from Andi Kleen ---
I've tried a couple of things to fix this:
- Fill in DECL_CONTEXT to current_fn_decl in cilk
- Fill in DECL_CONTEXT for VAR_DECLs when creating the nested wrapper
No banana so far. The first causes other errors
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #4 from Igor Zamyatin ---
Following works for me and shows no new errors in regtesting. Not sure it is a
good idea though...
diff --git a/gcc/c/c-array-notation.c b/gcc/c/c-array-notation.c
index 6a5631c..d7c6772 100644
--- a/gcc/c/c-
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #5 from Andi Kleen ---
You're right. It works in C++.
That's similar to my earlier patch, but I didn't comment out the other check
like you did. If commenting out the check work it would seem right to me.
Can you post it as a RFC?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #6 from Igor Zamyatin ---
Yes, I was going to post it after complete testing
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #7 from H.J. Lu ---
(In reply to Igor Zamyatin from comment #6)
> Yes, I was going to post it after complete testing
You should set DECL_SEEN_IN_BIND_EXPR_P when setting
DECL_CONTEXT, similar to gimple_add_tmp_var.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #8 from H.J. Lu ---
(In reply to H.J. Lu from comment #7)
> (In reply to Igor Zamyatin from comment #6)
> > Yes, I was going to post it after complete testing
>
> You should set DECL_SEEN_IN_BIND_EXPR_P when setting
> DECL_CONTEXT, si
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment #9 f
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #10 from Igor Zamyatin ---
(In reply to Jakub Jelinek from comment #9)
> (In reply to H.J. Lu from comment #8)
> > (In reply to H.J. Lu from comment #7)
> > > (In reply to Igor Zamyatin from comment #6)
> > > > Yes, I was going to post
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #11 from Jakub Jelinek ---
You need to include gimple-expr.h header for that. But, if you look e.g. at
c/c-typeck.c or c-family/cilk.c, it is already used in the FEs.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #12 from Igor Zamyatin ---
Thanks, will post a patch after the testing
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #13 from Kirill Yukhin ---
Author: kyukhin
Date: Sat Apr 12 17:57:15 2014
New Revision: 209336
URL: http://gcc.gnu.org/viewcvs?rev=209336&root=gcc&view=rev
Log:
gcc/c/
PR middle-end/60469
* c-array-notation.c (fix_builtin_arra
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #14 from Jakub Jelinek ---
Please don't forget to backport the Cilk+ bugfixes to 4.9 branch after 4.9.0 is
released, as long as they are small and non-risky.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60469
--- Comment #15 from Kirill Yukhin ---
Author: kyukhin
Date: Tue Apr 15 06:27:07 2014
New Revision: 209400
URL: http://gcc.gnu.org/viewcvs?rev=209400&root=gcc&view=rev
Log:
gcc/c/
PR middle-end/60469
* c-array-notation.c (fix_builtin_arra
16 matches
Mail list logo
