https://gcc.gnu.org/g:de6969fd311307e34904fc1f85603a9d92938974

commit r15-2085-gde6969fd311307e34904fc1f85603a9d92938974
Author: Kewen Lin <li...@linux.ibm.com>
Date:   Wed Jul 17 00:16:59 2024 -0500

    fortran: Teach get_real_kind_from_node for Power 128 fp modes [PR112993]
    
    Previously effective target fortran_real_c_float128 never
    passes on Power regardless of the default 128 long double
    is ibmlongdouble or ieeelongdouble.  It's due to that TF
    mode is always used for kind 16 real, which has precision
    127, while the node float128_type_node for c_float128 has
    128 type precision, get_real_kind_from_node can't find a
    matching as it only checks gfc_real_kinds[i].mode_precision
    and type precision.
    
    With changing TFmode/IFmode/KFmode to have the same mode
    precision 128, now fortran_real_c_float12 can pass with
    ieeelongdouble enabled by default and test cases guarded
    with it get tested accordingly.  But with ibmlongdouble
    enabled by default, since TFmode has precision 128 which
    is the same as type precision 128 of float128_type_node,
    get_real_kind_from_node considers kind for TFmode matches
    float128_type_node, but it's wrong as at this time point
    TFmode is with ibm extended format.  So this patch is to
    teach get_real_kind_from_node to check one more field which
    can be differentiable from the underlying real format, it
    can avoid the unexpected matching when there more than one
    modes have the same precisoin.
    
            PR target/112993
    
    gcc/fortran/ChangeLog:
    
            * trans-types.cc (get_real_kind_from_node): Consider the case where
            more than one modes have the same precision.

Diff:
---
 gcc/fortran/trans-types.cc | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/gcc/fortran/trans-types.cc b/gcc/fortran/trans-types.cc
index 0ef67723fcd3..f7b80a9761c4 100644
--- a/gcc/fortran/trans-types.cc
+++ b/gcc/fortran/trans-types.cc
@@ -183,7 +183,21 @@ get_real_kind_from_node (tree type)
 
   for (i = 0; gfc_real_kinds[i].kind != 0; i++)
     if (gfc_real_kinds[i].mode_precision == TYPE_PRECISION (type))
-      return gfc_real_kinds[i].kind;
+      {
+       /* On Power, we have three 128-bit scalar floating-point modes
+          and all of their types have 128 bit type precision, so we
+          should check underlying real format details further.  */
+#if defined(HAVE_TFmode) && defined(HAVE_IFmode) && defined(HAVE_KFmode)
+       if (gfc_real_kinds[i].kind == 16)
+         {
+           machine_mode mode = TYPE_MODE (type);
+           const struct real_format *fmt = REAL_MODE_FORMAT (mode);
+           if (fmt->p != gfc_real_kinds[i].digits)
+             continue;
+         }
+#endif
+       return gfc_real_kinds[i].kind;
+      }
 
   return -4;
 }

Reply via email to