Re: PATCH: PR target/49128: -mtune=native generates unsupported instructions

2011-05-24 Thread Tobias Burnus
This patch caused a boot-strap failure as it should be -mno-sse4.2 and not -mno-msse4.2, cf. http://gcc.gnu.org/ml/gcc/2011-05/msg00271.html H.J. Lu wrote: Here is the updated patch. It also handles FMA. OK for trunk and 4.6 if there are no regressions? [...] 2011-05-23 H.J. Lu

Re: [libgo] Use /usr/bin/pwd in os_test.TestStartProcess on Solaris (PR go/48502)

2011-05-24 Thread Ian Lance Taylor
Rainer Orth writes: > As described in the PR, the go libgo test fails on Solaris since /bin is > a symlink to /usr/bin. Since there is other OS-specific code in > os_test.go, I'm using the follwing patch to fix this. I committed this patch instead, to the upstream library and to gccgo. Let me k

Re: [ C++ 4.6 Patch] allow uninitialized const or reference members with -fpermissive

2011-05-24 Thread Fabien Chêne
2011/5/25 Jason Merrill : > On 05/24/2011 04:40 PM, Fabien Chêne wrote: >> >> Indeed. I have also added two testcases to check sfinae on 'new T', >> with and without -fpermissive, which leads to a different result. > > We don't want to do that; overload resolution should always produce the same > r

[pph] Regularize Streaming (issue4528096)

2011-05-24 Thread Lawrence Crowl
Add a new flag -fpph-untree. In pph_stream_read_tree and pph_stream_write_tree: Refactor from nested if statements to a switch statement. Remove handling of TREE_BINFO, as it is redundant. For TEMPLATE_DECL, also stream DECL_MEMBER_TEMPLATE_P. Report unhandled trees when -fpph-untree.

Re: [ C++ 4.6 Patch] allow uninitialized const or reference members with -fpermissive

2011-05-24 Thread Jason Merrill
On 05/24/2011 04:40 PM, Fabien Chêne wrote: Indeed. I have also added two testcases to check sfinae on 'new T', with and without -fpermissive, which leads to a different result. We don't want to do that; overload resolution should always produce the same result. We can only be permissive in n

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Mike Stump
On May 24, 2011, at 3:42 PM, Janis Johnson wrote: >>> Is this one OK for trunk and 4.6? The failure occurs for arm-none-eabi >>> and for arm-none-linux-gnueabi. >> >> You should repeat all the original options from the main dg-options line, >> with -Wno-abi added, in the ARM EABI dg-options line

Re: Fix for libobjc/48177. Can I apply it to 4.6 as well ?

2011-05-24 Thread Mike Stump
On May 24, 2011, at 2:41 PM, Nicola Pero wrote: > This patch fixes libobjc/48177. I applied it to trunk. > > I'd like to apply this patch to the 4.6 branch too. Do I need permission > from > a Release Manager ? They are always welcome to chime in, though, in this case the libobjc maintainer

Re: RFA: patch to fix PR48971

2011-05-24 Thread Vladimir Makarov
On 11-05-24 8:24 PM, Hans-Peter Nilsson wrote: On Fri, 13 May 2011, Vladimir Makarov wrote: The following patch solves the problem described on http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48971 The patch was successfully bootstrapped on x86-64 and checked for ppc64, ia64, i686-linux, i686-apple

Re: The TI C6X port

2011-05-24 Thread Vladimir Makarov
On 11-05-23 5:45 AM, Bernd Schmidt wrote: Ping: C6X scheduler changes. http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00747.html I think it is ok. I spent a lot of time looking at the change. It looks ok to me although it is hard to be sure because the code is too complicated. So it is good t

Re: RFA: patch to fix PR48971

2011-05-24 Thread Hans-Peter Nilsson
On Fri, 13 May 2011, Vladimir Makarov wrote: > The following patch solves the problem described on > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48971 > > The patch was successfully bootstrapped on x86-64 and checked for ppc64, ia64, > i686-linux, i686-apple-darwin, mips, arm, s390x, and sparc with

Re: [testsuite] remove XFAIL for all but ia64 for g++.dg/tree-ssa/pr43411.C

2011-05-24 Thread Mike Stump
On May 24, 2011, at 12:23 PM, Janis Johnson wrote: > Archived test results for 4.7.0 for most processors with C++ results have: > > XPASS: g++.dg/tree-ssa/pr43411.C scan-tree-dump-not optimized "OBJ_TYPE_REF" > > The only failures I could find were for ia64-linux and ia64-hpux. This > patch chan

Re: [testsuite] remove arm from xfail list for g++.dg/other/packed1.C

2011-05-24 Thread Mike Stump
On May 24, 2011, at 12:24 PM, Janis Johnson wrote: > All archived test results for ARM for 4.7.0 and 4.6.1 with g++ > results include: > > XPASS: g++.dg/other/packed1.C execution test > > This patch removes arm-*-* from the xfail list for this test. OK for > trunk and 4.6? Ok.

Re: [C++ PATCH] Fix -fdump-tree-all with C++

2011-05-24 Thread Jason Merrill
OK. Jason

C++ PATCH for c++/49042 (another acccess/templates issue)

2011-05-24 Thread Jason Merrill
...except we hit this one in mangling rather than deduction. There was already code here to suppress access control here, but it doesn't work anymore, since flag_access_control is now only checked at the beginning of compilation. The fix is to use push_deferring_access_checks instead. Tested

[v3] libstdc++/49151

2011-05-24 Thread Paolo Carlini
Hi, straightforward implementation of the resolution + some missing constexpr specifiers. Tested x86_64-linux, committed. Paolo. 2011-05-24 Paolo Carlini PR libstdc++/49151 * include/std/chrono (operator+, operator-, operator*, operator/, oper

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Janis Johnson
On 05/24/2011 03:33 PM, Joseph S. Myers wrote: > On Tue, 24 May 2011, Janis Johnson wrote: > >> On 05/24/2011 12:40 PM, Joseph S. Myers wrote: >>> On Tue, 24 May 2011, Janis Johnson wrote: >>> On ARM, two g++ tests trigger a warning about changed mangling. The warning is not relevant to

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Joseph S. Myers
On Tue, 24 May 2011, Janis Johnson wrote: > On 05/24/2011 12:40 PM, Joseph S. Myers wrote: > > On Tue, 24 May 2011, Janis Johnson wrote: > > > >> On ARM, two g++ tests trigger a warning about changed mangling. The > >> warning is not relevant to the purpose of the test, so this patch > >> causes

[C++ PATCH] Fix -fdump-tree-all with C++

2011-05-24 Thread Jakub Jelinek
Hi! The recent Nathan's change apparently broke -fdump-tree-all, in particular I see ICEs when running -fdump-tree-all on the PR49144 testcase. The problem is that CTOR_INITIALIZER is tcc_expression, and while it is built with build_min_nt, when dumping *.tu TREE_TYPE is used on all expr codes. t

[SPARC] Disable -fira-share-save-slots by default

2011-05-24 Thread Eric Botcazou
The new save slot sharing algorithm has a documented limitation: Future work: In the fallback case we should iterate backwards across all possible modes for the save, choosing the largest available one instead of falling back to the smallest mode immediately. (eg TF -> DF -> SF

Create common hooks structure shared between driver and cc1

2011-05-24 Thread Joseph S. Myers
This patch implements a target hooks structure for hooks shared between the driver and the core compilers. Such hooks go in libcommon-target.a which is then linked into the relevant binaries. ALWAYS_STRIP_DOTDOT is converted to a hook as the initial hook for the new structure. Bootstrapped with n

Re: Go patch committed: Update to current Go library

2011-05-24 Thread Ian Lance Taylor
Rainer Orth writes: > One needs to check for putenv vs. setenv and handle that in > go-setenv.c. I've hacked around the issue for the moment to at least > let bootstrap succeed. I fixed this problem like so. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline.

Re: [Patch, Fortran] -fcoarray=lib - add registering calls for nonallocatable coarrays

2011-05-24 Thread Tobias Burnus
Instead of a ping, an updated patch. This one additionally supports registering of nonallocatable coarrays also in MODULE and in BLOCK plus a test case. (Changes to gfc_generate_module_vars and gfc_process_block_locals and cgraph call in generate_coarray_init; some functions were moved up in

Re: Patch ping #2

2011-05-24 Thread Eric Botcazou
> Yes, I mean when -fstack-usage is enabled. Thus, make > -fstack-usage -Wframe-larger-than behave the same as > -fstack-usage -Wstack-usage. Or do you say that -Wstack-usage > doesn't require -fstack-usage? Yes, -Wstack-usage doesn't require -fstack-usage. > If it doesn't then I hope -Wstack-u

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-24 Thread Eric Botcazou
> So, would you like me to redo my patch on top of your patch, test it and > submit? I'll take care of that. > If you think it makes the code clearer, the extra comparison for at most > each stmt in the prologue_bb is probably noise compile time wise. No doubt about that. Plus this may save the

Re: Go patch committed: Update to current Go library

2011-05-24 Thread Ian Lance Taylor
Rainer Orth writes: > 2011-05-20 Rainer Orth > > libgo: > * syscalls/socket_irix.go (Addrinfo): Define. > Declare AI_*, EAI_* constants. Committed. Thanks. Ian

Re: Go patch committed: Update to current Go library

2011-05-24 Thread Ian Lance Taylor
Rainer Orth writes: > 2011-05-20 Rainer Orth > > libgo: > * Makefile.am (go_net_sock_file): Use go/net/cgo_linux.go if > LIBGO_IS_IRIX or LIBGO_IS_SOLARIS. > (go_net_sock_file): Use go/net/sock_linux.go if > LIBGO_IS_IRIX or LIBGO_IS_SOLARIS. > * Makefile.in

Fix for libobjc/48177. Can I apply it to 4.6 as well ?

2011-05-24 Thread Nicola Pero
This patch fixes libobjc/48177. I applied it to trunk. I'd like to apply this patch to the 4.6 branch too. Do I need permission from a Release Manager ? Can I get it ? :-) It is a fairly obvious fix as selector types should generally be compared using sel_types_match() and not strcmp(). But

Re: [pph] Various Tree Fields (issue4550064)

2011-05-24 Thread Lawrence Crowl
On 5/20/11, dnovi...@google.com wrote: > > http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c > File gcc/cp/pph-streamer-in.c (right): > > http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c#newcode251 > gcc/cp/pph-streamer-in.c:251: { > +static VEC(qualified_t

Re: [testsuite] ignore irrelevant warning in g++.dg/abi/packed1.C

2011-05-24 Thread Janis Johnson
On 05/24/2011 01:40 PM, Mike Stump wrote: > On May 24, 2011, at 10:41 AM, Janis Johnson wrote: >> Test g++.dg/abi/packed1.C triggers a warning for several targets. > >> OK for trunk and 4.6? > > Ok. If there is a portable -Wno-inefficient flag, that'd be a slightly > better way to do this. -Wn

Re: [Solaris] Fix profiling

2011-05-24 Thread Eric Botcazou
> this is PR gcov-profile/48845. Indeed, I totally missed it. > On the other hand, the patch is only necessary for tree profiling, > i.e. with -fprofile-generate, so I'm checking in the following. > > Bootstrapped without regressions on i386-pc-solaris2.{[89], 1[01]}, > installed on mainline. Th

Re: RFA: patch for PR48757

2011-05-24 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/24/11 14:26, Vladimir Makarov wrote: > The following patch solves PR48757. It is just a slight modification of > code for PR48633. > > 2011-05-24 Vladimir Makarov > > PR rtl-optimization/48757 > * ira-build.c (loop_with_eh_ed

Re: [patch, fortran] [4.6/4.7 Regression] Fix PR 48955

2011-05-24 Thread Paul Richard Thomas
Dear All, > > I have posted a simpler alternative on the PR that uses your > suggestion that forward and backward dependences need to to be > recorded to get this right. > > I believe that it's OK but have only now had the opportunity to put it > on to regtest. > Following some comments from Thoma

Re: Go patch committed: Update to current Go library

2011-05-24 Thread Ian Lance Taylor
Rainer Orth writes: > On recent Solaris 11, I also have: > > const __PATH_SYSVOL = "/system/volatile" > const __PATH_UTMPX = __PATH_SYSVOL "/utmpx" > const __PATH_VARRUN = __PATH_SYSVOL "/" > > For the moment, I'm just omitting the offending declarations in > mksysinfo.sh. This patch should fix

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Janis Johnson
On 05/24/2011 01:36 PM, Janis Johnson wrote: > On 05/24/2011 12:40 PM, Joseph S. Myers wrote: >> On Tue, 24 May 2011, Janis Johnson wrote: >> >>> On ARM, two g++ tests trigger a warning about changed mangling. The >>> warning is not relevant to the purpose of the test, so this patch >>> causes it

Re: [testsuite] ignore irrelevant warning in g++.dg/abi/packed1.C

2011-05-24 Thread Mike Stump
On May 24, 2011, at 10:41 AM, Janis Johnson wrote: > Test g++.dg/abi/packed1.C triggers a warning for several targets. > OK for trunk and 4.6? Ok. If there is a portable -Wno-inefficient flag, that'd be a slightly better way to do this.

Re: [ C++ 4.6 Patch] allow uninitialized const or reference members with -fpermissive

2011-05-24 Thread Fabien Chêne
2011/5/22 Jason Merrill : > I think you also need something to avoid returning error_mark_node from > build_new_1. Indeed. I have also added two testcases to check sfinae on 'new T', with and without -fpermissive, which leads to a different result. Tested x86_64-unknown-linux-gnu. OK for 4.6 ? I

[PATCH] Expand pow(x,n) into mulitplies in cse_sincos pass (PR46728, patch 2)

2011-05-24 Thread William J. Schmidt
Here's a small patch to expand pow(x,n) for integer n using the powi(x,n) logic in the cse_sincos pass. OK for trunk? For the next patch, I'll plan on expanding pow(x,n) for n in {0.5, 0.25, 0.75, 1./3., 1./6.}. This logic will be added to gimple_expand_builtin_pow. Bill 2011-05-24 Bill Schm

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Janis Johnson
On 05/24/2011 12:40 PM, Joseph S. Myers wrote: > On Tue, 24 May 2011, Janis Johnson wrote: > >> On ARM, two g++ tests trigger a warning about changed mangling. The >> warning is not relevant to the purpose of the test, so this patch >> causes it to be ignored. > > Various existing tests use -Wno

Re: Go patch committed: Update to current Go library

2011-05-24 Thread Ian Lance Taylor
Rainer Orth writes: > includes , which leads to > > // type ___FILE struct { _cnt int32; _ptr *uint8; _base *uint8; _flag uint8; > _magic uint8; __orientation INVALID-bit-field; __ionolock INVALID-bit-field; > __seekable INVALID-bit-field; __extendedfd INVALID-bit-field; __xf_nocheck > INVALI

Re: Patch fixing PR objc/48187

2011-05-24 Thread Mike Stump
On May 24, 2011, at 10:06 AM, Nicola Pero wrote: > This routine patch fixes PR objc/48187. > Ok to commit ? Ok.

RFA: patch for PR48757

2011-05-24 Thread Vladimir Makarov
The following patch solves PR48757. It is just a slight modification of code for PR48633. 2011-05-24 Vladimir Makarov PR rtl-optimization/48757 * ira-build.c (loop_with_eh_edge_p): Rename to loop_with_complex_edge_p, check edges on complexity, make function co

C++ PATCH for c++/48884 (access control and deduction)

2011-05-24 Thread Jason Merrill
In this PR, we had a problem with hitting access control violations during the substitution of template arguments in the context of template argument deduction. If we're going to be doing access checking at all during deduction substitution, we need to do it in the context of the function we'r

Re: [testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Joseph S. Myers
On Tue, 24 May 2011, Janis Johnson wrote: > On ARM, two g++ tests trigger a warning about changed mangling. The > warning is not relevant to the purpose of the test, so this patch > causes it to be ignored. Various existing tests use -Wno-abi or -Wno-psabi on particular targets for such cases.

Re: [patch][simplify-rtx] Fix 16-bit -> 64-bit multiply and accumulate

2011-05-24 Thread Joseph S. Myers
On Tue, 24 May 2011, Andrew Stubbs wrote: > I've created this new, simpler patch that converts > > (extend (mult a b)) > > into > > (mult (extend a) (extend b)) > > regardless of what 'a' and 'b' might be. (These are then simplified and > superfluous extends removed, of course.) Are there

[testsuite] remove arm from xfail list for g++.dg/other/packed1.C

2011-05-24 Thread Janis Johnson
All archived test results for ARM for 4.7.0 and 4.6.1 with g++ results include: XPASS: g++.dg/other/packed1.C execution test This patch removes arm-*-* from the xfail list for this test. OK for trunk and 4.6? 2011-05-24 Janis Johnson * g++.dg/other/packed1.C: Remove arm from xfail li

[testsuite] remove XFAIL for all but ia64 for g++.dg/tree-ssa/pr43411.C

2011-05-24 Thread Janis Johnson
Archived test results for 4.7.0 for most processors with C++ results have: XPASS: g++.dg/tree-ssa/pr43411.C scan-tree-dump-not optimized "OBJ_TYPE_REF" The only failures I could find were for ia64-linux and ia64-hpux. This patch changes the xfail so it only applies to ia64-*-*. OK for trunk? 20

[PATCH 4/5] Remove memory leaks, add one more assert.

2011-05-24 Thread Sebastian Pop
2011-05-24 Sebastian Pop * graphite-dependences.c (graphite_outer_subscript_bound): Remove memory leaks, add one more assert. --- gcc/ChangeLog.graphite |5 + gcc/graphite-dependences.c | 21 + 2 files changed, 18 insertions(+), 8 deletions(-)

[PATCH 0/5] Graphite branch cleanups

2011-05-24 Thread Sebastian Pop
Hi, I have committed the following patches to the graphite branch: Use zero_dim_array_p instead of graphite_artificial_array_p. Remove unused parameter. Remove continue from loop, add one more assert. Remove memory leaks, add one more assert. Fix typo. gcc/ChangeLog.graphite

[PATCH 1/5] Use zero_dim_array_p instead of graphite_artificial_array_p.

2011-05-24 Thread Sebastian Pop
2011-05-24 Alexey Kravets * graphite-opencl.c (opencl_private_var_name_p): Removed. (graphite_artificial_array_p): Removed. (opencl_data_create): Use zero_dim_array_p instead of graphite_artificial_array_p. --- gcc/ChangeLog.graphite |7 +++ gcc/graphite

[PATCH 2/5] Remove unused parameter.

2011-05-24 Thread Sebastian Pop
2011-05-24 Sebastian Pop * graphite-dependences.c (graphite_outer_subscript_bound): Remove unused parameter. * graphite-dependences.h (graphite_outer_subscript_bound): Same. * graphite-opencl-meta-clast.c (opencl_set_meta_rw_flags): Update call to graphit

[PATCH 5/5] Fix typo.

2011-05-24 Thread Sebastian Pop
2011-05-24 Sebastian Pop * graphite-opencl-codegen.c (opencl_print_local_vars): Fix typo. --- gcc/ChangeLog.graphite|4 gcc/graphite-opencl-codegen.c |6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gcc/ChangeLog.graphite b/gcc/ChangeLog.gr

[PATCH 3/5] Remove continue from loop, add one more assert.

2011-05-24 Thread Sebastian Pop
2011-05-24 Sebastian Pop * graphite-dependences.c (build_alias_set_powerset): Remove continue from loop, add one more assert. --- gcc/ChangeLog.graphite |5 + gcc/graphite-dependences.c | 15 ++- 2 files changed, 11 insertions(+), 9 deletions(-) diff

[google] Minor cleanups (issue4517103)

2011-05-24 Thread Diego Novillo
This patch is in preparation of an extension to the tree sharing code in the streamer to also support non-trees. The new code to stream struct lang_identifier runs into memory problems on some extreme cases. I have a C test case that generates thousands of bindings with 100,000 declarations in t

PATCH: Add pause intrinsic

2011-05-24 Thread H.J. Lu
Hi, This patch implements pause intrinsic suggested by Andi. OK for trunk? Thanks. -- H.J. --- gcc/ 2011-05-24 H.J. Lu * config/i386/i386.c (ix86_builtins): Add IX86_BUILTIN_PAUSE. (bdesc_special_args): Add pause intrinsic. * config/i386/i386.md (UNSPEC_PAUSE): N

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-24 Thread 關振德
Shouldn't we test ifndef __ANDROID__ instead? -Doug On Tue, May 24, 2011 at 2:39 AM, Guozhi Wei wrote: > Hi > > This patch is for google/main. > > In order to be compatible with current bionic and sysroot, we need to disable > getpagesize(). After getpagesize() in bionic is changed and ndk con

[build] Only build mips-tfile, mips-tdump native (PR target/3746)

2011-05-24 Thread Rainer Orth
There's a long-standing PR that mips-tfile and mips-tdump fail to compile in a cross. This happens because both refer to non-existant mips/a.out.h files in the cross-compilation case. Since the tools are now only used on Tru64 UNIX and gas/gld don't work for that target, there's no point in tryin

[testsuite] ignore irrelevant warning in two ARM tests

2011-05-24 Thread Janis Johnson
On ARM, two g++ tests trigger a warning about changed mangling. The warning is not relevant to the purpose of the test, so this patch causes it to be ignored. Tested on arm-none-linux-gnueabi. OK for trunk and 4.6? 2011-05-24 Janis Johnson * g++.dg/template/stdarg1.C: Ignore warning.

[testsuite] ignore irrelevant warning in g++.dg/abi/packed1.C

2011-05-24 Thread Janis Johnson
Test g++.dg/abi/packed1.C triggers a warning for several targets. That warning is not relevant to the purpose of the test, as shown by the fact that the dg-warning directive was added later and additional targets keep trickling in. Rather than continue to add to the list of targets for the warnin

[testsuite] update error message in arm test

2011-05-24 Thread Janis Johnson
The error message for unknown types changed a few months ago. Update a test that still looks for the old message. Tested on arm-none-linux-gnueabi. OK for trunk and 4.6? 2011-05-24 Janis Johnson * gcc.target/arm/fp16-compile-none-1.c: Update expected error. Index: gcc.target/arm/fp1

Re: [PING][PATCH 13/18] move TS_EXP to be a substructure of TS_TYPED

2011-05-24 Thread Nathan Froyd
`0On Mon, May 23, 2011 at 04:58:06PM +0200, Richard Guenther wrote: > On Mon, May 23, 2011 at 4:18 PM, Nathan Froyd > wrote: > > On 05/17/2011 11:31 AM, Nathan Froyd wrote: > >> On 05/10/2011 04:18 PM, Nathan Froyd wrote: > >>> On 03/10/2011 11:23 PM, Nathan Froyd wrote: > After all that, we

Re: RFA (libstdc++): C++/v3 PATCH for c++/24163 (lookup in dependent bases) and c++/29131

2011-05-24 Thread Jason Merrill
OK. Jason

Re: PATCH: PR target/49128: -mtune=native generates unsupported instructions

2011-05-24 Thread Uros Bizjak
On Mon, May 23, 2011 at 8:25 PM, H.J. Lu wrote: >>> +      const char *sse4_2 = has_sse4_2 ? " -msse4.2" : " -msse4.2"; >>> +      const char *sse4_1 = has_sse4_1 ? " -msse4.1" : " -msse4.1"; >> >> Missing "no-" here on both lines. >> > > Here is the updated patch.  It also handles FMA.  OK for t

Tiny documentation update in diagnostic.c

2011-05-24 Thread Nicola Pero
Ok to commit ? Thanks Index: ChangeLog === --- ChangeLog (revision 174112) +++ ChangeLog (working copy) @@ -1,3 +1,15 @@ +2011-05-24 Nicola Pero + + * diagnostic.c (pedwarn): Updated comment. + Index: diagnostic.c ==

Patch fixing PR objc/48187

2011-05-24 Thread Nicola Pero
This routine patch fixes PR objc/48187. The problem is that the following code @interface A { ] } @end would cause the ObjC parser to enter into an infinite loop. The parser fails to parse ] as an instance variable, but then when it tries to skip to the next semicolon to resume parsing from t

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Uros Bizjak
On Tue, May 24, 2011 at 6:42 PM, Rainer Orth wrote: > Uros Bizjak writes: > >>> Assembler: eh_globals.cc >>>        "/var/tmp//ccJ1MA8h.s", line 17 : Syntax error >>>        Near line: "    call    __tls_get_addr(%rip)@plt" >>>        "/var/tmp//ccJ1MA8h.s", line 38 : Syntax error >>>        Near

Re: [patch][simplify-rtx] Fix 16-bit -> 64-bit multiply and accumulate

2011-05-24 Thread Andrew Stubbs
On 03/05/11 10:07, Bernd Schmidt wrote: I tried to fix it with the patch below, which unfortunately doesn't work since during combine we don't see the SIGN_EXTEND operations inside the MULT, but two shift operations instead. Maybe you can complete it from here? I've tried to make this patch go

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Rainer Orth
Uros Bizjak writes: >> Assembler: eh_globals.cc >>        "/var/tmp//ccJ1MA8h.s", line 17 : Syntax error >>        Near line: "    call    __tls_get_addr(%rip)@plt" >>        "/var/tmp//ccJ1MA8h.s", line 38 : Syntax error >>        Near line: "    call    __tls_get_addr(%rip)@plt" >> make[9]: ***

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Uros Bizjak
On Tue, May 24, 2011 at 5:34 PM, Rainer Orth wrote: > Uros Bizjak writes: > >>> I think I tried something along these lines, but failed with duplicate >>> @plt@plt for PIC code. >> >> Hm, there is no %P1 present, so I don't think this should be an issue. > > Unfortunately, I do get assembler erro

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Joseph S. Myers
On Tue, 24 May 2011, Rainer Orth wrote: > Which makes me wonder if I should run the gcc.dg/torture/tls-*.c tests > with -fPIC, too. I think it makes sense to try to provide reasonable coverage of TLS tests with all of -fPIC, -fpic, -fPIE and -fpie. -- Joseph S. Myers jos...@codesourcery.com

PATCH: PR target/49142: Invalid 8bit register operand

2011-05-24 Thread H.J. Lu
Hi, We are working on a new optimization, which turns off TARGET_MOVX. GCC generates: movb %ah, %dil But %ah can only be used with %[abcd][hl]. This patch adds QIreg_operand and uses it in *movqi_extv_1_rex64/*movqi_extzv_2_rex64. OK for trunk if there is no regression? Thanks. H.J. --- 201

Re: [Fwd: Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass]

2011-05-24 Thread Richard Guenther
On Tue, May 24, 2011 at 5:28 PM, William J. Schmidt wrote: > > On Tue, 2011-05-24 at 16:44 +0200, Richard Guenther wrote: >> On Tue, May 24, 2011 at 3:38 PM, William J. Schmidt >> wrote: >> > >> > On Tue, 2011-05-24 at 15:11 +0200, Richard Guenther wrote: >> >> On Tue, May 24, 2011 at 2:26 PM, Wi

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Rainer Orth
Uros Bizjak writes: >> I think I tried something along these lines, but failed with duplicate >> @plt@plt for PIC code. > > Hm, there is no %P1 present, so I don't think this should be an issue. Unfortunately, I do get assembler errors (Sun as at the moment) with your updated patch: libtool: co

RFA PR 48770

2011-05-24 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This has gone latent on the trunk, but the underlying issue hasn't been resolved. ira.c::update_equiv_regs can create REG_EQUIV notes for equivalences which are local to a block rather than the traditional function-wide equivalences we typically work

Re: [Fwd: Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass]

2011-05-24 Thread William J. Schmidt
On Tue, 2011-05-24 at 16:44 +0200, Richard Guenther wrote: > On Tue, May 24, 2011 at 3:38 PM, William J. Schmidt > wrote: > > > > On Tue, 2011-05-24 at 15:11 +0200, Richard Guenther wrote: > >> On Tue, May 24, 2011 at 2:26 PM, William J. Schmidt > >> wrote: > >> > Sure, I'll give that a try this

[PATCH, i386]: Fix PR 49133

2011-05-24 Thread Uros Bizjak
Hello! shufpd can't be used to implement sse2_loadhpd pattern, since shufpd can move input, matched to output only to the lower half of the vector. 2011-05-24 Uros Bizjak PR target/49133 * config/i386/sse.md (sse2_loadhpd): Remove shufpd alternative. testsuite/ChangeLog: 201

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Uros Bizjak
On Tue, May 24, 2011 at 5:09 PM, Rainer Orth wrote: >> Since handling of "p" is not conditional (that is, controlled by some >> compile flag), it is IMO better to just output correct assembly from >> the insn pattern itself.  You will also output lower-case "@plt" which > > I think I tried someth

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-24 Thread Rainer Orth
Uros, > Since handling of "p" is not conditional (that is, controlled by some > compile flag), it is IMO better to just output correct assembly from > the insn pattern itself. You will also output lower-case "@plt" which I think I tried something along these lines, but failed with duplicate @plt

Re: [google/integration] Add placeholder -Wself-assign flag for compatibility with other branches

2011-05-24 Thread Diego Novillo
On Tue, May 24, 2011 at 11:59, Simon Baldwin wrote: > gcc/ChangeLog.google-integration: > 2011-05-24  Simon Baldwin   > >        * common.opt (-Wself-assign): New placeholder flag. OK. Diego.

[google/integration] Add placeholder -Wself-assign flag for compatibility with other branches

2011-05-24 Thread Simon Baldwin
Add placeholder -Wself-assign flag for compatibility with other branches. Add -Wself-assign to common.opts so that invocations of gcc with the flag do not cause compilation to fail. The flag is silently ignored. OK for google/integration? gcc/ChangeLog.google-integration: 2011-05-24 Simon Bald

Re: [Solaris] Fix profiling

2011-05-24 Thread Rainer Orth
Hi Eric, > after http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02139.html profiling uses > TLS support where available. This breaks on SPARC/Solaris 8 and 9 (at least) > because the associated libraries aren't linked in. this is PR gcov-profile/48845. > Tested on SPARC/Solaris 8 and SPARC64/So

[PATCH] LTO type canonical cleanup

2011-05-24 Thread Richard Guenther
This removes all remaining name related stuff from canonical type merging. It doesn't make sense and causes some merging not to happen. Where incomplete types are involved we will have no direct uses of those types and thus we don't care for TYPE_CANONICAL. Bootstrapped and tested on x86_64-unk

Don't use FORCE_CODE_SECTION_ALIGN on Solaris/x86

2011-05-24 Thread Rainer Orth
While working to move the Solaris libgcc configuration to the toplevel, I came across the definition of FORCE_CODE_SECTION_ALIGN in i386/sol2.h. It refers to a Solaris 2.0 ld bug, which is ancient history by now. The definition can simply be removed, as verified by bootstraps on i386-pc-solaris2.

[testsuite] Don't use dg-do run in gcc.dg/vect/pr48172.c

2011-05-24 Thread Rainer Orth
The new gcc.dg/vect/pr48172.c FAILs on Solaris 8/x86 since it cannot be assembled (Sun as) or executed (GNU as). The vect.exp driver checks for this and demotes execution tests to compile tests if necessary, but the explicit dg-do run defeats this. Removing the dg-do run fixes this. Tested with

Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass

2011-05-24 Thread William J. Schmidt
On Tue, 2011-05-24 at 14:26 +0200, Richard Guenther wrote: > > +/* Recursive subroutine of powi_as_mults. This function takes the > > + array, CACHE, of already calculated exponents and an exponent N and > > + returns a tree that corresponds to CACHE[1]**N, with type TYPE. */ > > + > > +s

[PATCH] Fix PR49078

2011-05-24 Thread Richard Guenther
This fixes PR49078 by restricting the assert in get_alias_set to the case where it matters. We know that how types generated during optimization have TYPE_CANONICAL computed differs from what the LTO machinery does, the patch documents that and reverts a previous attempt to fix parts of this inco

Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass

2011-05-24 Thread Richard Guenther
On Mon, May 23, 2011 at 8:06 PM, William J. Schmidt wrote: > Richard, thanks for the excellent comments.  I really appreciate your > help.  I've implemented them all, and bootstrap/regtest succeeds on > powerpc target.  Here's the revised patch for your consideration. > > Thanks, > Bill > > > 2011

Re: [Fwd: Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass]

2011-05-24 Thread Richard Guenther
On Mon, May 23, 2011 at 11:53 PM, William J. Schmidt wrote: > Richard, > > While working on the next patch, I ran into a scenario that will apply > to this one as well.  If the call statement that calls powi contains > vdef/vuse information, it is lost by this replacement.  For example, > > # .MEM

Re: [PATCH] split tree_type, a.k.a. "tuplifying types"

2011-05-24 Thread Tom de Vries
On 05/23/2011 05:04 PM, Nathan Froyd wrote: > On 05/22/2011 02:24 PM, Tom de Vries wrote: >> Now that struct tree_type does not exist anymore, 'sizeof (struct tree_type)' >> generates an error in the following assert in fold_checksum_tree: >> ... >> gcc_assert ((sizeof (struct tree_exp) + 5 * siz

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-24 Thread Jakub Jelinek
On Tue, May 24, 2011 at 01:42:11PM +0200, Eric Botcazou wrote: > > That is so that the argp (or framep) will be properly handled during > > CSELIB, as constant VALUE that is never changed through the function. And > > additionally to find out if we can do the replacement (we can't if argp > > resp

Re: [Solaris] Fix profiling

2011-05-24 Thread Eric Botcazou
> Tested on SPARC/Solaris 8 and SPARC64/Solaris 9 (the Solaris 10 machine > isn't in very good shape right now). Also tested on SPARC/Solaris 10 now. -- Eric Botcazou

Re: Put more common objects in libcommon-target.a

2011-05-24 Thread Paolo Bonzini
On 05/24/2011 01:42 PM, Joseph S. Myers wrote: This patch continues preparing for a target structure shared by the driver (including for this purpose collect2 and gnatbind) and the core compilers by creating a library libcommon-target.a to contain the shared code that may have such target depende

Put more common objects in libcommon-target.a

2011-05-24 Thread Joseph S. Myers
This patch continues preparing for a target structure shared by the driver (including for this purpose collect2 and gnatbind) and the core compilers by creating a library libcommon-target.a to contain the shared code that may have such target dependencies. Right now it contains opts-common.o (whic

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-24 Thread Eric Botcazou
> That is so that the argp (or framep) will be properly handled during > CSELIB, as constant VALUE that is never changed through the function. And > additionally to find out if we can do the replacement (we can't if argp > resp. framep isn't eliminated and could therefore occur in the real code).

Re: [Patch, libfortran] PR 48931 Async-signal-safety of backtrace signal handler

2011-05-24 Thread N.M. Maclaren
On May 24 2011, FX wrote: One solution could be to search the PATH for addr2line during library initialization (where we don't need to be async-signal-safe), and then store it somewhere and use it in show_backtrace(). That's one way. Another way is just to store a copy of the PATH during ini

Re: [google] Disable getpagesize() for Android toolchain (issue4515131)

2011-05-24 Thread Joseph S. Myers
On Tue, 24 May 2011, Guozhi Wei wrote: > Index: getpagesize.c > === > --- getpagesize.c (revision 174099) > +++ getpagesize.c (working copy) > @@ -60,11 +60,13 @@ BUGS > # endif /* PAGESIZE */ > #endif /* GNU_OUR_PAGESIZE */

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-24 Thread Jakub Jelinek
On Tue, May 24, 2011 at 12:59:57PM +0200, Eric Botcazou wrote: > Now on to a few questions: > > > 2011-05-23 Jakub Jelinek > > > > * var-tracking.c (vt_add_function_parameter): Remap incoming > > MEMs with crtl->args.internal_arg_pointer based address > > if stack_realign_drap to ar

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-24 Thread Eric Botcazou
> Here is an alternative, almost completely untested, patch, which > uses DW_OP_fbreg for the arguments of dynamically realigned functions. > draptest.c now works... Thanks for the tip. I completely overlooked this CFA-based machinery and now agree that it's the most sensible approach. For my

Re: RFA (libstdc++): C++/v3 PATCH for c++/24163 (lookup in dependent bases) and c++/29131

2011-05-24 Thread Paolo Carlini
On 05/24/2011 05:59 AM, Jason Merrill wrote: It occurred to me today that I could use current_class_name rather than TYPE_IDENTIFIER (current_class_type). Thus I suppose the below is also ok and obvious? To be safe, I'm testing it on x86_64-linux. Paolo. // 2011-05-24 Pao

[v3] Update _GLIBCXX_NOTHROW for noexcept

2011-05-24 Thread Paolo Carlini
Hi, straightforward update of the _GLIBCXX_NOTHROW macro. Without changing anything else, on x86_64-linux it provides the following small but measurable improvements to the size of the .so and the .a: .so: 6223484 -> 6223156 .a: 15183284 -> 15182676 Tested x86_64-linux, committed. T

Re: [patch ada]: Fix bootstrap for Ada

2011-05-24 Thread Arnaud Charlet
> > I'm confused. The above looks wrong to me: it does not return an empty > > string, > > it returns a pointer to an uninitialized string, which cannot be right > > (and > > should generate a warning :-) > > No, static vars are implicitly zero initialized when not explicitly > initialized. Hmm I

  1   2   >