Ping Re: [patch, ARM] Fix PR42017, LR not used in leaf functions

2011-06-01 Thread Chung-Lin Tang
Ping. On 2011/5/26 01:29 AM, Chung-Lin Tang wrote: > On 2011/5/20 07:46 PM, Chung-Lin Tang wrote: >> On 2011/5/20 下午 07:41, Ramana Radhakrishnan wrote: >>> On 17/05/11 14:10, Chung-Lin Tang wrote: On 2011/5/13 04:26 PM, Richard Sandiford wrote: > Richard Sandiford writes: >> Chung-Lin

Ping Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-06-01 Thread Chung-Lin Tang
Ping. On 2011/5/9 11:02 PM, Chung-Lin Tang wrote: > Ping. > > On 04/22/2011 11:21 PM, Chung-Lin Tang wrote: >> Hi Richard, this part's for you. >> >> The ARM backend changes needed are very little after the prior patches, >> basically just a case in arm_canonicalize_comparison() to detect >> (zero

[google]Backport r174549 Fix 3 test cases incorrectly run in Thumb/Xscale (issue4524090)

2011-06-01 Thread Jing Yu
http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00134.html Backport r174549 to fix three testcases that are specific to ARM mode and therefore should be skipped when compiling for thumb. Thanks, Jing 2011-06-01 Jing Yu Backport r174549 2011-06-01 Sofiane Naci * gcc.ta

[pph] Stream lang_decl_min in lang_decl_fn (issue4530095)

2011-06-01 Thread Lawrence Crowl
The struct lang_decl_fn contains a struct lang_decl_min as a field, but we were not streaming it. This patch streams that field. This patch doesn't make any new testcases work, but it makes them fail later. Tested on x86-64. Committed. Index: gcc/cp/ChangeLog.pph 2011-06-01 Lawrence Crowl

[google] Improve locus information during if-conversion (issue4526101)

2011-06-01 Thread Sharad Singhai
This patch improves locus information during the if-conversion. Okay for google/main? Thanks, Sharad 2011-06-01 Sharad Singhai Google Ref 39994 * ifcvt.c (noce_try_cmove_arith): Use the locus information from the if-statment rather than the then path. Index: ifcvt.c

Re: PING: PATCH: PR target/46770: Use .init_array/.fini_array sections

2011-06-01 Thread Carrot Wei
Hi H.J. This patch is also important to ChromeOS toolchain. Could you also try to update and test it for google/main? thanks Carrot On Wed, May 18, 2011 at 11:57 PM, H.J. Lu wrote: > On Tue, Apr 26, 2011 at 6:05 AM, H.J. Lu wrote: >> On Thu, Mar 31, 2011 at 7:57 AM, H.J. Lu wrote: >>> On Mon,

Re: [PR debug/47590] rework md option overriding to delay var-tracking

2011-06-01 Thread Bernd Schmidt
On 06/02/2011 12:47 AM, Alexandre Oliva wrote: > On Jun 1, 2011, Bernd Schmidt wrote: >> Looks ok, except I think you need to update tm.texi.in and tm.texi? > > Oh, I didn't realize updating tm.texi.in; AFAICT tm.texi is generated > the same regardless. I *think* what one is supposed to do is t

Re: [PR debug/47590] rework md option overriding to delay var-tracking

2011-06-01 Thread Alexandre Oliva
On Jun 1, 2011, Bernd Schmidt wrote: > On 06/01/2011 10:10 PM, Alexandre Oliva wrote: >> On May 4, 2011, Bernd Schmidt wrote: >> >>> This comment looks very weird when added to ia64_option_override >>> (likewise for other targets). Is there a reason it's not true anymore? >> >> Dunno, but th

[patch committed] Fix PR target/49238

2011-06-01 Thread Kaz Kojima
Hi, The attached patch is to fix PR 49238 which is an ice-on-valid-code with an unrecognizable insn like: (insn 61 60 62 3 (set (reg:SI 147 t) (geu:SI (reg:SI 3 r3) (const_int -1 [0x]))) (nil)) SH has GEU comparison only with register operands and we used a scratch r

Re: [PR48866] three alternative fixes

2011-06-01 Thread Alexandre Oliva
On May 30, 2011, Michael Matz wrote: > Hi, > On Mon, 30 May 2011, Alexandre Oliva wrote: >> > 3. expand dominators before dominated blocks, so that DEFs of >> >replaceable SSA names are expanded before their uses. Expand them >> >when they're encountered, but not requiring a REG as a

Re: introduce --param max-vartrack-expr-depth

2011-06-01 Thread Alexandre Oliva
On Jun 1, 2011, Alexandre Oliva wrote: > On May 31, 2011, Alexandre Oliva wrote: >> On May 30, 2011, Bernd Schmidt wrote: >>> On 05/30/2011 12:35 PM, Alexandre Oliva wrote: One of my patches for PR 48866 regressed guality/asm-1.c on x86_64-linux-gnu because what used to be a single c

Re: C++ PATCH for c++/44870 (wrong overload resolution error in template)

2011-06-01 Thread Jason Merrill
On 05/31/2011 02:05 PM, Jason Merrill wrote: So this patch makes us look through NON_DEPENDENT_EXPR at the actual underlying tree structure. It occurred to me that if we're going to do this, we don't need to keep reference INDIRECT_REFs outside NON_DEPENDENT_EXPR. Tested x86_64-pc-linux-gnu,

C++ PATCH for c++/44175 (segv with recursive decltype in template)

2011-06-01 Thread Jason Merrill
Two of the testcases in this PR were SEGVing for different reasons: one from excessive recursion exhausting the stack, and the other from dereferencing a null pointer. This patch fixes both issues. Tested x86_64-pc-linux-gnu, applied to trunk. commit 0d7f1941a19ce5133c30f8a917379afc6bb31b82 Au

[committed] Fix var-tracking ICE with ENTRY_VALUE (PR debug/49250)

2011-06-01 Thread Jakub Jelinek
Hi! This is something I've introduced through cselib_subst_to_values substing ENTRY_VALUE to corresponding VALUE and have been fixing already in the * var-tracking.c (replace_expr_with_values): Return NULL for ENTRY_VALUE too. hunk. Apparently there are other 3 places where it ne

Re: Dump before flag

2011-06-01 Thread Xinliang David Li
On Wed, Jun 1, 2011 at 2:12 PM, Basile Starynkevitch wrote: > On Wed, 1 Jun 2011 13:26:24 -0700 > Xinliang David Li wrote: > >> Hi, this is a simple patch that support dump_before flag. E.g, >> >> -fdump-tree-pre-before >> >> This is useful for diffing the the IR before and after a pass. > > Perh

Re: Dump before flag

2011-06-01 Thread Basile Starynkevitch
On Wed, 1 Jun 2011 13:26:24 -0700 Xinliang David Li wrote: > Hi, this is a simple patch that support dump_before flag. E.g, > > -fdump-tree-pre-before > > This is useful for diffing the the IR before and after a pass. Perhaps you forgot to actually attach the patch? > Gcc dumping needs more c

[lra] a patch to build ARM

2011-06-01 Thread Vladimir Makarov
Here is the patch to build arm-elf target with simulator. It has been committed to the branch. 2011-06-01 Vladimir Makarov * lra-eliminations.c (lra_eliminate_reg_if_possible): Fix a typo. (process_insn_for_elimination): Invalidate insn data if the insn code was changed

Re: Dump before flag

2011-06-01 Thread Xinliang David Li
Sorry about it. Here it is. David On Wed, Jun 1, 2011 at 1:36 PM, Richard Guenther wrote: > On Wed, Jun 1, 2011 at 10:26 PM, Xinliang David Li wrote: >> Hi, this is a simple patch that support dump_before flag. E.g, >> >> -fdump-tree-pre-before >> >> This is useful for diffing the the IR befor

Re: Dump before flag

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 10:26 PM, Xinliang David Li wrote: > Hi, this is a simple patch that support dump_before flag. E.g, > > -fdump-tree-pre-before > > This is useful for diffing the the IR before and after a pass. > > Gcc dumping needs more cleanups -- such as allowing IR only dump, > allowing

Re: [lto] Fix streaming of multi-byte enums (issue4526099)

2011-06-01 Thread Richard Guenther
On Wed, 1 Jun 2011, Diego Novillo wrote: > > This patch (split out of > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg4.html), fixes the > streaming of enum values when they are larger than a single byte. > > Tested with LTO profiledbootstrap on x86_64. > > OK for trunk? Ok. Thanks, Richar

Re: [patch, ARM] Fix PR48808, PR48792: More work on CANNOT_CHANGE_MODE_CLASS

2011-06-01 Thread Eric Botcazou
> I went for "op". "target" might have been misleading because the > parameter is sometimes the source (rather than destination) of the > reload. Thanks. > Here's what I installed after retesting on x86_64-linux-gnu. > Thanks again for the review. FWIW I also bootstrapped/regtested the first ve

Dump before flag

2011-06-01 Thread Xinliang David Li
Hi, this is a simple patch that support dump_before flag. E.g, -fdump-tree-pre-before This is useful for diffing the the IR before and after a pass. Gcc dumping needs more cleanups -- such as allowing IR only dump, allowing IR dumping for a particular function etc. The exposure of 'dumpfile' (in

Re: [PR debug/47590] rework md option overriding to delay var-tracking

2011-06-01 Thread Bernd Schmidt
On 06/01/2011 10:10 PM, Alexandre Oliva wrote: > On May 4, 2011, Bernd Schmidt wrote: > >> This comment looks very weird when added to ia64_option_override >> (likewise for other targets). Is there a reason it's not true anymore? > > Dunno, but the patch definitely didn't work any more when I r

Re: PR 49145: Another (zero_extend (const_int ...)) in combine

2011-06-01 Thread Eric Botcazou
> I've included the subreg handling as well as the zero_extend handling, > even though make_compound_operation already handles that case correctly. > However, I've cowardly not removed the known_cond subreg handling: > > else if (code == SUBREG) > { > enum machine_mode inner_mode = GET_

Re: [PR debug/47590] rework md option overriding to delay var-tracking

2011-06-01 Thread Alexandre Oliva
On May 4, 2011, Bernd Schmidt wrote: > This comment looks very weird when added to ia64_option_override > (likewise for other targets). Is there a reason it's not true anymore? Dunno, but the patch definitely didn't work any more when I retested it. Maybe it didin't work when I first tested it,

Re: introduce --param max-vartrack-expr-depth

2011-06-01 Thread Alexandre Oliva
On May 31, 2011, Alexandre Oliva wrote: > On May 30, 2011, Bernd Schmidt wrote: >> On 05/30/2011 12:35 PM, Alexandre Oliva wrote: >>> One of my patches for PR 48866 regressed guality/asm-1.c on >>> x86_64-linux-gnu because what used to be a single complex debug value >>> expression became a chai

[lto] Remove unnecessary assertion for DECL_SAVED_TREE (issue4530094)

2011-06-01 Thread Diego Novillo
This patchlet removes the assertion that DECL_SAVED_TREE should be NULL. As we discussed in http://gcc.gnu.org/ml/gcc-patches/2011-06/msg4.html, it is no longer necessary. Committed to trunk. Diego. * lto-streamer-out.c (lto_output_ts_decl_non_common_tree_pointers): Remov

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread IainS
On 1 Jun 2011, at 20:40, Mike Stump wrote: On Jun 1, 2011, at 10:51 AM, Rainer Orth wrote: I can certainly do it this way for now, but if we could do away with the tests completely, that would be cleaner. Agreed, though, I don't believe the test is superfluous. You still haven't answered

Allow alternatives for attr "predicable"

2011-06-01 Thread Bernd Schmidt
Currently, the predicable attribute can only be either "yes" or "no" for an instruction, without distinguishing between alternatives. This can be a problem - on C6X, there are move and add instructions where exactly one alternative isn't predicable. The comment in gensupport.c mentions that FRV als

Re: Ping^2: PR target/45074: Check targets of multi-word operations

2011-06-01 Thread Richard Sandiford
Bernd Schmidt writes: > On 05/31/2011 07:51 PM, Richard Sandiford wrote: >> Ping for: >> >> http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01327.html >> >> It fixes the expansion of multiword operations in cases where the >> suggested target is a hard register and where CANNOT_CHANGE_MODE_CLAS

Re: [patch, ARM] Fix PR48808, PR48792: More work on CANNOT_CHANGE_MODE_CLASS

2011-06-01 Thread Richard Sandiford
Eric Botcazou writes: >> * reload.c (push_reload): Check contains_reg_of_mode. >> * reload1.c (strip_paradoxical_subreg): New function. >> (gen_reload_chain_without_interm_reg_p): Use it to handle >> paradoxical subregs. >> (emit_output_reload_insns, gen_reload): Likewise.

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-01 Thread Xinliang David Li
On Wed, Jun 1, 2011 at 12:29 PM, Richard Guenther wrote: > On Wed, Jun 1, 2011 at 6:16 PM, Xinliang David Li wrote: >> On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther >> wrote: >>> On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li >>> wrote: The following patch implements the a new optio

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread Mike Stump
On Jun 1, 2011, at 10:51 AM, Rainer Orth wrote: >>> I can certainly do it this way for now, but if we could do away with the >>> tests completely, that would be cleaner. >> >> Agreed, though, I don't believe the test is superfluous. > > You still haven't answered my question wrt. Darwin 8 vs. 64-

[lto] Fix streaming of multi-byte enums (issue4526099)

2011-06-01 Thread Diego Novillo
This patch (split out of http://gcc.gnu.org/ml/gcc-patches/2011-06/msg4.html), fixes the streaming of enum values when they are larger than a single byte. Tested with LTO profiledbootstrap on x86_64. OK for trunk? Diego. * lto-streamer-out.c (lto_output_ts_decl_with_vis_tree_point

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 6:16 PM, Xinliang David Li wrote: > On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther > wrote: >> On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li wrote: >>> The following patch implements the a new option that dumps gcc PASS >>> configuration. The sample output is attache

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-01 Thread Xinliang David Li
The attached is patch-2 (-fdump-passes) and a sample output: Ok for trunk? David On Wed, Jun 1, 2011 at 9:16 AM, Xinliang David Li wrote: > On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther > wrote: >> On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li wrote: >>> The following patch implements

[PATCH] gimple_val_nonnegative_real_p (PR46728 patch 7 of 7)

2011-06-01 Thread William J. Schmidt
This patch cleans up the FIXME logic in gimple_expand_builtin_pow by introducing gimple_val_nonnegative_real_p for the same purpose that tree_expr_nonnegative_p served in the expand logic. This completes the work for PR46728. Bootstrapped/regtested on powerpc64-linux. 2011-06-01 Bill Schmidt

[Patch, Fortran] Fix -fcheck=pointer for F2008's NULL ptr to optional arguments

2011-06-01 Thread Tobias Burnus
The NULL pointer check (-fcheck=pointer) was wrong for Fortran 2008: It is now allowed to pass a null pointer (or not associated allocatables) to optional arguments to denote absent arguments. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2011-06-01 Tobias Burnus PR fortra

Re: [lto] Merge streamer hooks from pph branch. (issue4568043)

2011-06-01 Thread Richard Guenther
On Wed, 1 Jun 2011, Diego Novillo wrote: > On Wed, Jun 1, 2011 at 08:07, Richard Guenther wrote: > > >>  static void cgraph_expand_all_functions (void); > >>  static void cgraph_mark_functions_to_output (void); > >> @@ -1092,6 +1093,10 @@ cgraph_finalize_compilation_unit (void) > >>  { > >>    t

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-06-01 Thread H.J. Lu
On Mon, May 30, 2011 at 2:44 PM, Xinliang David Li wrote: > This is the complete patch for pass name fixes (with test case changes). > > David > > I think your change caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49261 H.J.

C++ PATCH for c++/49253 (v3 debug mode regression)

2011-06-01 Thread Jason Merrill
My changes to preserve reference semantics in templates broke the shenanigans build_x_arrow was using for non-dependent ARROW_EXPR; it called build_min_non_dep and then overwrote the TREE_TYPE, but that broke in the case of a reference to pointer because it ended up giving the ARROW_EXPR REFERE

Re: Use i386/crtfastmath.c on Solaris 2/x86

2011-06-01 Thread Richard Henderson
On 06/01/2011 10:29 AM, Rainer Orth wrote: > I still mean to fix > driver-i386.c to correcly handle -march=native on Solaris 8 and 9 which > cannot in general execute SSE insns. I wonder if there's a better place > to share this code? I can't think of a good place. :-( r~

Re: [PATCH] c-pragma: adding a data field to pragma_handler

2011-06-01 Thread Basile Starynkevitch
On Wed, 01 Jun 2011 18:54:38 +0200 Pierre wrote: > This patch is about the pragmas. > > In c-family/c-pragma.h, we declare a pragma_handler which is a function > accepting cpp_reader as parameter. > > I have changed this handler in order to accept a second parameter which > is a void *, allow

[pph] Add one failing C test (issue4524085)

2011-06-01 Thread Diego Novillo
This is the last of the large set of failing single-file C test cases I had collected. It still fails, but given that we are more people that may be hacking on the branch now, I wanted to put it out there so I don't have to keep testing my private set of files anymore. This fails on read with:

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread Rainer Orth
Mike Stump writes: > On Jun 1, 2011, at 9:01 AM, Rainer Orth wrote: >> Both TARGET_64BIT_DEFAULT and TARGET_BI_ARCH live in gcc only, so at >> least in the medium term, we need different tests here. > > Ah, ick. Oh well... The next more general rule would be something like: one > can set a fea

Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup

2011-06-01 Thread Ian Lance Taylor
Mike Stump writes: > On Jun 1, 2011, at 7:37 AM, Ian Lance Taylor wrote: >>> One problem remains in the libgo testsuite: certain tests have to be >>> compiled with -mieee, otherwise FPE is generated for unordered values. >>> Any suggestions, where -mieee should be placed? >> >> That's an interes

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread Kai Tietz
2011/6/1 Richard Henderson : > On 06/01/2011 09:01 AM, Rainer Orth wrote: >> The problem with this approach is that some of the macros tested only >> live in gcc, not libgcc once the libgcc sources no longer include tm.h >> etc.  E.g. look at i386/mingw32.h: >> >> #if !TARGET_64BIT_DEFAULT && !defi

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread Richard Henderson
On 06/01/2011 09:01 AM, Rainer Orth wrote: > The problem with this approach is that some of the macros tested only > live in gcc, not libgcc once the libgcc sources no longer include tm.h > etc. E.g. look at i386/mingw32.h: > > #if !TARGET_64BIT_DEFAULT && !defined (TARGET_BI_ARCH) > #define MD_U

Re: Use i386/crtfastmath.c on Solaris 2/x86

2011-06-01 Thread Rainer Orth
Richard Henderson writes: > On 06/01/2011 07:51 AM, Rainer Orth wrote: >> + /* Set PC to the instruction after the faulting one to skip over it, >> + otherwise we enter an infinite loop. 4 is the size of the stmxcsr >> + instruction. */ > ... >> + /* We need a single SSE instructi

[Patch ARM] Unbreak bootstrap for --with-fpu=neon.

2011-06-01 Thread Ramana Radhakrishnan
Hi, It turns out that my effort last week in canonicalizing the vbic and the vorn patterns in the neon bug exposed a latent bug while bootstrapping trunk with Neon which Michael's tester picked up.. The splitting is slightly tricky because in T2 state you've got the orn instruction but in ARM stat

Re: [PATCH][all-langs] Defer size_t and sizetype setting to the middle-end

2011-06-01 Thread Andrew Haley
On 06/01/2011 12:34 PM, Richard Guenther wrote: > > > > java/ > > * decl.c (java_init_decl_processing): Properly initialize > > size_type_node. > > > > Index: gcc/java/decl.c > > === > > --- gcc/java/decl.c (revision 174520

Re: [PATCH][all-langs] Defer size_t and sizetype setting to the middle-end

2011-06-01 Thread Andrew Haley
On 06/01/2011 05:45 PM, Bryce McKinlay wrote: > > Can I suggest that you cc such approvals to gcc-patches. Richard (and > others) may not be subscribed to the j...@gcc.gnu.org list. Sorry, I meant to do so. This idiot mailer has its "reply list" button replying to just the one list, not all the

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-01 Thread Xinliang David Li
The attached is the split #1 patch that enhances -fenable/disable. Ok after testing? Thanks, David On Wed, Jun 1, 2011 at 9:16 AM, Xinliang David Li wrote: > On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther > wrote: >> On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li wrote: >>> The following

Re: Use i386/crtfastmath.c on Solaris 2/x86

2011-06-01 Thread Richard Henderson
On 06/01/2011 07:51 AM, Rainer Orth wrote: > + /* Set PC to the instruction after the faulting one to skip over it, > + otherwise we enter an infinite loop. 4 is the size of the stmxcsr > + instruction. */ ... > + /* We need a single SSE instruction here so the handler can safely sk

Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup

2011-06-01 Thread Mike Stump
On Jun 1, 2011, at 7:37 AM, Ian Lance Taylor wrote: >> One problem remains in the libgo testsuite: certain tests have to be >> compiled with -mieee, otherwise FPE is generated for unordered values. >> Any suggestions, where -mieee should be placed? > > That's an interesting question. I think that

[PATCH] c-pragma: adding a data field to pragma_handler

2011-06-01 Thread Pierre
This patch is about the pragmas. In c-family/c-pragma.h, we declare a pragma_handler which is a function accepting cpp_reader as parameter. I have changed this handler in order to accept a second parameter which is a void *, allowing to give extra datas to the handler. I think this data fiel

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread Mike Stump
On Jun 1, 2011, at 9:01 AM, Rainer Orth wrote: > Both TARGET_64BIT_DEFAULT and TARGET_BI_ARCH live in gcc only, so at > least in the medium term, we need different tests here. Ah, ick. Oh well... The next more general rule would be something like: one can set a feature (implicit -D__GCC_DO_UNWI

Re: approved but not committed? - [PATCH, ARM] Testcases incorrectly run in Thumb/Xscale

2011-06-01 Thread Jing Yu
On Wed, Jun 1, 2011 at 1:51 AM, Richard Earnshaw wrote: > > On Tue, 2011-05-31 at 12:49 -0700, Jing Yu wrote: >> Since this patch has been properly approved, if there is no objection >> in 24 hours, I will commit this patch to trunk. >> > > Once a patch has been approved by an appropriate maintain

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-01 Thread Xinliang David Li
On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther wrote: > On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li wrote: >> The following patch implements the a new option that dumps gcc PASS >> configuration. The sample output is attached.  There is one >> limitation: some placeholder passes that are

Re: [lto] Merge streamer hooks from pph branch. (issue4568043)

2011-06-01 Thread Diego Novillo
On Wed, Jun 1, 2011 at 08:07, Richard Guenther wrote: >>  static void cgraph_expand_all_functions (void); >>  static void cgraph_mark_functions_to_output (void); >> @@ -1092,6 +1093,10 @@ cgraph_finalize_compilation_unit (void) >>  { >>    timevar_push (TV_CGRAPH); >> >> +  /* If LTO is enabled,

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

2011-06-01 Thread Rainer Orth
Mike Stump writes: > On May 30, 2011, at 8:43 AM, Rainer Orth wrote: >> * The three users of MD_UNWIND_SUPPORT are modified to unconditionally >> include a new md-unwind-support.h header which is created from the >> info in config.host: if md_unwind_header exists, it is included in >> md-unwin

Re: [PATCH, ARM] Cortex-A5 tuning [2/2] - tweak instruction conditionalisation

2011-06-01 Thread Richard Earnshaw
On Wed, 2011-06-01 at 16:49 +0100, Julian Brown wrote: > This patch tweaks the behaviour of arm_final_prescan_insn when tuning > for Cortex-A5 cores, since branches are cheaper than long sequences of > conditionalised instructions on those processors. As posted in the > previous patch, this provid

Re: [PATCH][all-langs] Defer size_t and sizetype setting to the middle-end

2011-06-01 Thread Eric Botcazou
> ada/ > * gcc-interface/misc.c (gnat_init): Do not set > size_type_node or call set_sizetype. OK, thanks. -- Eric Botcazou

Re: [PATCH, ARM] Cortex-A5 tuning [1/2] - branch costs

2011-06-01 Thread Richard Earnshaw
On Wed, 2011-06-01 at 16:49 +0100, Julian Brown wrote: > This patch overrides the branch cost for Cortex-A5 cores, building on > the previous patch: > > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00045.html > > (And also depending on: > > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00044

Re: [PATCH, ARM] Make branch cost a tunable parameter

2011-06-01 Thread Richard Earnshaw
On Wed, 2011-06-01 at 16:24 +0100, Julian Brown wrote: > This patch allows the BRANCH_COST macro to be altered for a given > target using the ARM backend's tuning infrastructure. It's not easy > to reduce the cost to e.g. a single integer or a set of integers (cores > may have different branch cos

Re: [PATCH, ARM] Make usage of MOVT/MOVW pairs (vs. constant pool) a tunable parameter

2011-06-01 Thread Richard Earnshaw
On Wed, 2011-06-01 at 16:24 +0100, Julian Brown wrote: > This patch allows the usage of MOVT/MOVW pairs (vs. constant-pool loads) > to be controlled based on the target CPU (-mtune= option), using the ARM > backend's tuning infrastructure. This is to enable constant-pool loads > to be used in pref

Re: [PATCH] Decrease size of mem_loc_descriptor

2011-06-01 Thread Richard Henderson
On 06/01/2011 07:29 AM, Jakub Jelinek wrote: > 2011-06-01 Jakub Jelinek > > * dwarf2out.c (compare_loc_descriptor, scompare_loc_descriptor, > ucompare_loc_descriptor, minmax_loc_descriptor, clz_loc_descriptor, > popcount_loc_descriptor, bswap_loc_descriptor, rotate_loc_descrip

Re: [PATCH] ENTRY_VALUE fixes (PR debug/48203)

2011-06-01 Thread Richard Henderson
On 06/01/2011 07:25 AM, Jakub Jelinek wrote: > 2011-06-01 Jakub Jelinek > > * var-tracking.c (create_entry_value): New function. > (vt_add_function_parameter): Use it. Ok. r~

[PATCH, ARM] Cortex-A5 tuning [2/2] - tweak instruction conditionalisation

2011-06-01 Thread Julian Brown
This patch tweaks the behaviour of arm_final_prescan_insn when tuning for Cortex-A5 cores, since branches are cheaper than long sequences of conditionalised instructions on those processors. As posted in the previous patch, this provides a measurable increase in performance on a popular embedded be

[PATCH, ARM] Cortex-A5 tuning [1/2] - branch costs

2011-06-01 Thread Julian Brown
This patch overrides the branch cost for Cortex-A5 cores, building on the previous patch: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00045.html (And also depending on: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00044.html to apply correctly.) The rationale is as follows: branches are p

Re: [PATCH][RFC] Init sizetypes based on target defs

2011-06-01 Thread Eric Botcazou
> This initializes sizetypes correctly from the start, using target > definitions available. All Frontends initialize sizetypes from > size_type_node for which there is a target macro SIZE_TYPE which > tells what type to use for this (C runtime ABI) type. And this is a prerequisite if you want to

[pph] Add new C test case (issue4559064)

2011-06-01 Thread Diego Novillo
This test case from the C testsuite started working after the last merge from trunk. Collin, this is the test I was referring to yesterday. I'm going to add some more C test cases to the testsuite that are currently not working. I think that's going to make our fixing job easier (otherwise, it's

Re: C6X port 5/11: Track predication conditions more accurately

2011-06-01 Thread Steve Ellcey
On Wed, 2011-06-01 at 12:18 +0400, Andrey Belevantsev wrote: > On 31.05.2011 23:59, Andrey Belevantsev wrote: > > > > On 31.05.2011 22:24, Steve Ellcey wrote: > >> Bernd, > >> > >> This patch (r174336) is causing me many testsuite failures on IA64. > >> Tests like gcc.c-torture/compile/20010408-1.c

Re: [rfa] Give thunks correct RESULT_DECL

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 5:36 PM, Michael Matz wrote: > Hi, > > I noticed this a while ago while working on early merging of decls.  When > we build thunk decls ourself we give RESULT_DECL of it integer_type, even > when the thunk decl itself says something else.  (In particular thunks can > very we

[rfa] Give thunks correct RESULT_DECL

2011-06-01 Thread Michael Matz
Hi, I noticed this a while ago while working on early merging of decls. When we build thunk decls ourself we give RESULT_DECL of it integer_type, even when the thunk decl itself says something else. (In particular thunks can very well return void or a pointer type). This fixes that glitch.

Re: better wpa [2/n]: merge some top-level trees

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 5:07 PM, Michael Matz wrote: > Hi, > > On Wed, 1 Jun 2011, Michael Matz wrote: > >> Hi, >> >> so here's something more of my patch queue.  It adds the facility to merge >> also other trees than types over compilation unit borders.  This specific >> patch only deals with STRI

Re: [PATCH][RFC] Init sizetypes based on target defs

2011-06-01 Thread Richard Guenther
On Tue, 31 May 2011, Richard Guenther wrote: > > This initializes sizetypes correctly from the start, using target > definitions available. All Frontends initialize sizetypes from > size_type_node for which there is a target macro SIZE_TYPE which > tells what type to use for this (C runtime ABI)

[PATCH, ARM] Make branch cost a tunable parameter

2011-06-01 Thread Julian Brown
This patch allows the BRANCH_COST macro to be altered for a given target using the ARM backend's tuning infrastructure. It's not easy to reduce the cost to e.g. a single integer or a set of integers (cores may have different branch costing characteristics for ARM vs. Thumb-2 mode for instance, as i

[PATCH, ARM] Make usage of MOVT/MOVW pairs (vs. constant pool) a tunable parameter

2011-06-01 Thread Julian Brown
This patch allows the usage of MOVT/MOVW pairs (vs. constant-pool loads) to be controlled based on the target CPU (-mtune= option), using the ARM backend's tuning infrastructure. This is to enable constant-pool loads to be used in preference to MOVW/MOVT instruction pairs, when the former are faste

Re: better wpa [2/n]: merge some top-level trees

2011-06-01 Thread Michael Matz
Hi, On Wed, 1 Jun 2011, Michael Matz wrote: > Hi, > > so here's something more of my patch queue. It adds the facility to merge > also other trees than types over compilation unit borders. This specific > patch only deals with STRING_CST and INTEGER_CST nodes. Originally I used > that plac

better wpa [2/n]: merge some top-level trees

2011-06-01 Thread Michael Matz
Hi, so here's something more of my patch queue. It adds the facility to merge also other trees than types over compilation unit borders. This specific patch only deals with STRING_CST and INTEGER_CST nodes. Originally I used that place for merging declarations, hence the naming of some varia

Re: Use i386/crtfastmath.c on Solaris 2/x86

2011-06-01 Thread Rainer Orth
Uros Bizjak writes: > Please just put "if (edx & bit_SSE)" part inside existing check. You > will need to split assignment of mxcsr from the declaration, though. > > OK with this change. Here's the patch I've actually comitted after a quick bootstrap on i386-pc-solaris2.10. Thanks. Rain

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-01 Thread Jan Hubicka
> >> > >> whenever you take the address of an always_inline function > >> (because then you can confuse GCC by indirectly calling > >> such function which we might inline dependent on optimization > >> setting and which we might discover we didn't inline only > >> dependent on optimization setting)

Re: [pph] Renaming output/write and input/read to out/in + standardizing pph_stream_* to pph_* (issue4532102)

2011-06-01 Thread dnovillo
On 2011/06/01 13:06:15, Diego Novillo wrote: Looks OK. One minor formatting comment that I will fix myself when I commit the patch. Committed as rev 174530. Diego. http://codereview.appspot.com/4532102/

Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup

2011-06-01 Thread Ian Lance Taylor
Uros Bizjak writes: > On Tue, May 31, 2011 at 8:08 PM, Ian Lance Taylor wrote: >> Uros Bizjak writes: >> >>> (BTW: Original calculation of Ctime_ns has a cut'n'paste error, >>> stat.Ctime.Nsec should be used instead of stat.Atime.Nsec). >> >> Thanks.  Fixed like so.  Bootstrapped and ran Go tes

Add missing ChangeLog entry

2011-06-01 Thread Ian Lance Taylor
I noticed that we have a --with-specs option in gcc/configure.ac, added in revision 155208 with this e-mail message: http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00132.html Nathan forgot to commit the ChangeLog entry, so I have committed this patch to ChangeLog-2009. (Patches to ChangeLog files d

[committed] Fix a typed DWARF stack unsigned comparison thinko

2011-06-01 Thread Jakub Jelinek
Hi! While working on patches I'm going to post momentarily, I've noticed a buglet in ucompare handling, mode is the mode of the comparison, while obviously I meant op_mode which is the mode of the comparison operands. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed a

[PATCH] Decrease size of mem_loc_descriptor

2011-06-01 Thread Jakub Jelinek
On Tue, May 31, 2011 at 09:26:23AM -0700, Richard Henderson wrote: > On 05/31/2011 02:19 AM, Jakub Jelinek wrote: > > Hi! > > > > - http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01182.html > > > > various d

Re: [PATCH] ENTRY_VALUE fixes (PR debug/48203)

2011-06-01 Thread Jakub Jelinek
On Mon, Mar 28, 2011 at 10:50:14AM -0700, Richard Henderson wrote: > > I will look into creating helper inlines to reduce code duplication. > > Please. You can do this as a follow-up if you prefer. Sorry it took so long, here it is. Bootstrapped/regtested on x86_64-linux and i686-linux, makes z

ARM Cortex-R5 support

2011-06-01 Thread Paul Brook
The attached patch adds support from the ARM Cortex-R5 cpu core. For compiler purposes this is basically the same as the Cortex-R4, except it supports the integer division instructions in both ARM and Thumb mode. The Cortex-A15 also supports this, so I've enabled it there at the same time. Tes

Re: C++ PATCH for c++/44870 (wrong overload resolution error in template)

2011-06-01 Thread H.J. Lu
On Tue, May 31, 2011 at 11:05 AM, Jason Merrill wrote: > lvalue_kind has tried to give an approximate answer for value category in > templates; in the past, it was OK to say that an arbitrary expression was an > lvalue, as the only effect would be that errors we could have given at > template defi

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 3:01 PM, Christian Bruel wrote: > > > On 06/01/2011 12:02 PM, Richard Guenther wrote: >> >> On Tue, May 31, 2011 at 6:03 PM, Christian Bruel >>  wrote: >>> >>> >>> On 05/31/2011 11:18 AM, Richard Guenther wrote: On Tue, May 31, 2011 at 9:54 AM, Christian Bruel

Re: [pph] Renaming output/write and input/read to out/in + standardizing pph_stream_* to pph_* (issue4532102)

2011-06-01 Thread dnovillo
Looks OK. One minor formatting comment that I will fix myself when I commit the patch. Diego. http://codereview.appspot.com/4532102/diff/1/pph-streamer-in.c File pph-streamer-in.c (right): http://codereview.appspot.com/4532102/diff/1/pph-streamer-in.c#newcode42 pph-streamer-in.c:42: pph_regi

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-01 Thread Christian Bruel
On 06/01/2011 12:02 PM, Richard Guenther wrote: On Tue, May 31, 2011 at 6:03 PM, Christian Bruel wrote: On 05/31/2011 11:18 AM, Richard Guenther wrote: On Tue, May 31, 2011 at 9:54 AM, Christian Bruel wrote: Hello, The attached patch fixes a few diagnostic discrepancies for always_in

Re: [patch] Improve detection of widening multiplication in the vectorizer

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 1:37 PM, Ira Rosen wrote: > On 1 June 2011 12:42, Richard Guenther wrote: > >> Did you think about moving pass_optimize_widening_mul before >> loop optimizations?  Does that pass catch the cases you are >> teaching the pattern recognizer?  I think we should try to expose >>

Re: [lto] Merge streamer hooks from pph branch. (issue4568043)

2011-06-01 Thread Richard Guenther
On Tue, 31 May 2011, Diego Novillo wrote: > > This patch merges the LTO streamer hooks from the pph branch. > > These hooks are meant to separate streaming work that is specific to > GIMPLE from other modules that may want to stream their own data > structures. In the PPH branch, we are using t

Re: [patch] Improve detection of widening multiplication in the vectorizer

2011-06-01 Thread Ira Rosen
On 1 June 2011 12:42, Richard Guenther wrote: > Did you think about moving pass_optimize_widening_mul before > loop optimizations?  Does that pass catch the cases you are > teaching the pattern recognizer?  I think we should try to expose > these more complicated instructions to loop optimizers.

[PATCH][all-langs] Defer size_t and sizetype setting to the middle-end

2011-06-01 Thread Richard Guenther
This patch defers the control over size_t and sizetype to the middle-end which in turn consults the target. This removes various inconsistencies for frontends that do not seem to care about size_t and will allow simplifying the global tree initialization. Bootstrapped on x86_64-unknown-linux-gnu

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-01 Thread Richard Guenther
On Tue, May 31, 2011 at 6:03 PM, Christian Bruel wrote: > > > On 05/31/2011 11:18 AM, Richard Guenther wrote: >> >> On Tue, May 31, 2011 at 9:54 AM, Christian Bruel >>  wrote: >>> >>> Hello, >>> >>> The attached patch fixes a few diagnostic discrepancies for always_inline >>> failures. >>> >>> Ill

Re: RFC: explicitely mark out-of-scope deaths

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 11:25 AM, Richard Sandiford wrote: > Michael Matz writes: >> Stores are better than builtin functions here, so as to not artificially >> take addresses of the decls in question. > > For the record, you wouldn't need to take the address if you had an > internal function (int

  1   2   >