Re: [Patch, AVR]: Fix PR33049 (implement extzv)

2011-06-21 Thread Denis Chertykov
2011/6/20 Georg-Johann Lay a...@gjlay.de: This is an optimization patch that implements extzv for 1-bit extracts. +(define_insn_and_split *extzv + [(set (match_operand:QI 0 register_operand =*d,*d,*d,r) +(zero_extract:QI (match_operand:QI 1 register_operand

Re: [RFC] Fix unwind info for sparc -mflat

2011-06-21 Thread Eric Botcazou
I tried to figure out why things had been done in this slightly convoluted manner and failed. It seems to me that this is easily represented with the individual instructions. I wanted to avoid the back-and-forth game on the CFA offset and emit the same CFIs as in the normal case. Your

Re: [Patch, Fortran, OOP] PR 49112: [4.6/4.7 Regression] Missing type-bound procedure, duplicate save warnings and internal compiler error

2011-06-21 Thread Jakub Jelinek
On Tue, Jun 21, 2011 at 12:29:01AM +0200, Janus Weil wrote: However, I would also like to apply it to the 4.6 branch (which was frozen a few hours ago). Is there any chance to get approval by the RM's for this? Yeah, it looks small and safe enough for 4.6.1 to me. 2011-06-21 Janus Weil

Re: Patch: speed up compiler a little bit by optimizing lookup_attribute() and is_attribute_p()

2011-06-21 Thread Dimitrios Apostolou
Hi Nicola, my patch is too simple compared to yours, feel free to work on it as much as you wish, no need to credit me since you posted it independantly. I just posted it to note that the inlining part is the one providing most performance benefit. richi: I used always_inline because it is

Rename across basic block boundaries

2011-06-21 Thread Bernd Schmidt
This patch requires http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02193.html as a prerequisite, and supersedes http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02194.html The idea here is to allow regrename to operate across basic block boundaries. This helps for targets that use sched_ebb (such

Re: Unreviewed libgcc build patch

2011-06-21 Thread Paolo Bonzini
Ok without the commented info evaluation, and with the per-target macro renamed to c_flags-$. Thanks, Paolo 2011/6/20, Rainer Orth r...@cebitec.uni-bielefeld.de: The following patch [build, libgcc] Correctly apply c_flags in shared-object.mk

Re: Unreviewed libgcc build patch

2011-06-21 Thread Rainer Orth
Paolo Bonzini bonz...@gnu.org writes: Ok without the commented info evaluation, and with the per-target macro renamed to c_flags-$. Here's what I've installed after rebuilding libgcc and verifying that -fexceptions still isn't applied to enable-execute-stack.c. Thanks. Rainer

Re: [PATCH] Middle-end arrays, forward-ported to trunk (again)

2011-06-21 Thread Richard Guenther
On Tue, 21 Jun 2011, Richard Guenther wrote: This forward-ports the middle-end array patch. Patch status is the same as with the last forward-port from 2009 - the scalarizer cannot deal with control flow and it cannot insert temporaries when required (so it operates in a mode that requires

[PATCH] middle-end only piece of middle-end array expressions

2011-06-21 Thread Richard Guenther
This is the middle-end pieces, without the C/C++ frontend changes. Enough to work on the Fortran parts. Doesn't even break bootstrap. Richard. 2008-04-11 Richard Guenther rguent...@suse.de * builtin-attrs.def (ATTR_COVARIANTRETURN): Add. (ATTR_NOTHROW_TYPEGENERIC): Likewise.

Re: Patch: speed up compiler a little bit by optimizing lookup_attribute() and is_attribute_p()

2011-06-21 Thread Richard Guenther
On Tue, Jun 21, 2011 at 3:39 PM, Dimitrios Apostolou ji...@gmx.net wrote: Hi Nicola, my patch is too simple compared to yours, feel free to work on it as much as you wish, no need to credit me since you posted it independantly. I just posted it to note that the inlining part is the one

Re: [PATCH] middle-end only piece of middle-end array expressions

2011-06-21 Thread Richard Guenther
On Tue, 21 Jun 2011, Richard Guenther wrote: This is the middle-end pieces, without the C/C++ frontend changes. Enough to work on the Fortran parts. Doesn't even break bootstrap. And here is a variant that doesn't need the tree-cfg.c hunk for the Fortran patch (thus all type problems

Re: SRA generates uninitialized var use

2011-06-21 Thread Xinliang David Li
On Tue, Jun 21, 2011 at 1:42 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jun 21, 2011 at 1:28 AM, Xinliang David Li davi...@google.com wrote: Good point -- but why does SRA have to be so complicated? If it just do structure expansion and let subsequent phases to clean it up,

Re: SRA generates uninitialized var use

2011-06-21 Thread Richard Guenther
On Tue, Jun 21, 2011 at 5:51 PM, Xinliang David Li davi...@google.com wrote: On Tue, Jun 21, 2011 at 1:42 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jun 21, 2011 at 1:28 AM, Xinliang David Li davi...@google.com wrote: Good point -- but why does SRA have to be so

[PATCH, MELT] fix minor issue with meltgc_new_split_string

2011-06-21 Thread Pierre Vittet
Hello, I got a bug when using meltgc_new_split_string (in melt-runtime.c) with a string (argument str) like this one sepmystringsepanotherString with sep the separator. The function is not working on a string that start with the separator. I guess this case can happen in real case, for

[PATCH] Fix __bultin_clrsb* (PR middle-end/49489)

2011-06-21 Thread Jakub Jelinek
On Mon, Jun 20, 2011 at 09:38:22PM +0200, Bernd Schmidt wrote: On 06/16/2011 06:25 PM, Richard Henderson wrote: On 06/16/2011 05:44 AM, Bernd Schmidt wrote: +@deftypefn {Built-in Function} int __builtin_clrsb (unsigned int x) +Returns the number of leading redundant sign bits in @var{x},

Re: [PATCH] Fix __bultin_clrsb* (PR middle-end/49489)

2011-06-21 Thread Bernd Schmidt
On 06/21/2011 06:10 PM, Jakub Jelinek wrote: gcc.c-torture/execute/builtin-bitops-1.c fails on x86_64-linux, because there is no SImode libcall, only DImode, and it was zero-extending instead of sign-extending the argument, and not subtracting the mode difference afterwards. So int foo (int

Re: [Patch, AVR]: Fix PR33049 (implement extzv)

2011-06-21 Thread Georg-Johann Lay
Denis Chertykov schrieb: I'm vote for 'C'. Denis. So it's C :-) Johann PR target/33049 * config/avr/avr.md (extzv): New expander. (*extzv): New insn. (*extzv.qihi1, *extzv.qihi2): New insn-and-split. * config/avr/constraints.md (C04): New constraint.

Re: [PATCH, ARM] iWMMXT maintenance

2011-06-21 Thread Ramana Radhakrishnan
Joseph S. Myers wrote: On Mon, 20 Jun 2011, Xinyu Qi wrote: *gcc/config/arm/elf.h: Add option -mwmmxt. *gcc/config/arm/arm.opt: Same. Why? And where are the documentation updates? How does this relate to the existing iWMMXt options? I thought the plan (Ramana?) was to move to having a

Re: [libjava] Fix md5test, shatest on Tru64 UNIX with native libiconv (PR libgcj/49314)

2011-06-21 Thread Andrew Haley
On 06/21/2011 02:55 PM, Rainer Orth wrote: As described in the PR, unless the UTF-8 encoding of \ufeff is padded with a NUL byte, the iconv_init test fails for the native Tru64 UNIX libiconv, iconv_byte_swap isn't set correctly and later iconv calls fail. This patch fixes this, allowing the

Re: [Patch, AVR]: Fix PR33049 (implement extzv)

2011-06-21 Thread Denis Chertykov
2011/6/21 Georg-Johann Lay a...@gjlay.de: Denis Chertykov schrieb: I'm vote for 'C'. Denis. So it's C :-) Johann        PR target/33049        * config/avr/avr.md (extzv): New expander.        (*extzv): New insn.        (*extzv.qihi1, *extzv.qihi2): New insn-and-split.        *

Re: [ARM] TLS Descriptor support

2011-06-21 Thread Ramana Radhakrishnan
revalidated with defaults to both gnu and gnu2 style. ok? This is OK . Ramana nathan -- Nathan Sidwell

Re: [PATCH, MELT] fix minor issue with meltgc_new_split_string

2011-06-21 Thread Basile Starynkevitch
Thanks. I applied both patches: % svn log --limit 2 gcc/melt-runtime.c r175268 | bstarynk | 2011-06-21 19:29:34 +0200 (Tue, 21 Jun 2011) | 6 lines 2011-06-21 Pierre Vittet pier...@pvittet.com * melt-runtime.c

Re: [PATCH] Middle-end arrays, forward-ported to trunk (again)

2011-06-21 Thread Paul Richard Thomas
Dear Richi, The point of entry for assignments is in trans-expr.c 06038 tree 06039 gfc_trans_assignment (gfc_expr * expr1, gfc_expr * expr2, bool init_flag, 06040 bool dealloc) 06041 { a bunch of special cases 06088 06089 /* Fallback to the scalarizer to generate

Re: [pph contrib] Add support for multiple spawn patterns in repro_fail (issue4571061)

2011-06-21 Thread Alexandre Oliva
On Jun 10, 2011, dnovi...@google.com (Diego Novillo) wrote: I'm thinking that this script is better written in python, but that may make it less generic and I don't know whether we accept python in gcc/contrib. Alex? I guess anything goes in gcc/contrib, so it could be rewritten in Python,

Re: __sync_swap* [ rename sync builtins ]

2011-06-21 Thread Richard Henderson
On 06/21/2011 11:46 AM, Andrew MacLeod wrote: * c-family/c-common.c: Add sync_ or SYNC__ to builtin names. * c-family/c-omp.c: Add sync_ or SYNC__ to builtin names. * java/builtins.c: Add sync_ or SYNC__ to builtin names. * java/expr.c: Add sync_ or SYNC__ to builtin

[pph] Reorganize pph read/write file into their respective streamers (issue4657042)

2011-06-21 Thread Gabriel Charette
Avoid exposing more and more streamer functions in the headers by moving all the read logic to pph-streamer-in.c and the write logic to pph-streamer-out.c This is a pure copy/paste of the functions, no new functionality was added in this patch Tested with bootstrap build and pph regression

C++ PATCH for c++/49418 (lost cv-quals on template parameter type)

2011-06-21 Thread Jason Merrill
cv-qualifiers are dropped from a function parameter type in order to produce the parameter-type-list, but the parameter itself still has the qualified type within the function body. When I added cv-qualification stripping to type_decays_to, it started affecting instantiation of template

Re: [PATCH] Middle-end arrays, forward-ported to trunk (again)

2011-06-21 Thread Mikael Morin
On Tuesday 21 June 2011 17:08:17 Richard Guenther wrote: The following is a patch^Whack that should handle almost all array exprs. Well, tried on the following testcase: subroutine foo (dst, bar, ni, nj) integer, intent(in) :: ni, nj double precision, intent(in) :: bar(ni, nj)

Re: [pph] Reorganize pph read/write file into their respective streamers (issue4657042)

2011-06-21 Thread gchare
Note: There might now be unused headers in pph.c (although I didn't need to add any headers to the streamers, so it would have to be one of the headers they all use). http://codereview.appspot.com/4657042/

Fix ACATS c94007a on 4.6 branch for SPARC64/Solaris

2011-06-21 Thread Eric Botcazou
This is the failure of ACATS c94007a at -O2 on SPARC64/Solaris: the compiler generates wrong code because of a delay slot scheduling (reorg.c) bug. This is a regression on the 4.6 branch (4.5 branch and mainline are clean). fill_simple_delay_slots decides to fill the delay slot of a call insn

[testsuite] dg-require-effective-target: skip unneeded checks

2011-06-21 Thread Janis Johnson
This patch causes dg-require-effective-target to return early if the test is already being skipped, saving some work. There's already similar code in dg-skip-if. OK for trunk, and later for 4.6? 2011-06-21 Janis Johnson jani...@codesourcery.com * lib/target-supports-dg.exp

[testsuite] ARM: adjust skips for Xscale test

2011-06-21 Thread Janis Johnson
This patch allows an Xscale-specific test to run if multilib flags include -march=xscale and to be skipped if -mcpu= is used with anything besides xscale. OK for trunk, and later for 4.6? 2011-06-21 Janis Johnson jani...@codesourcery.com * gcc.target/arm/scd42-3.c: Allow -march-xscale;

[testsuite] ARM: remove -march from tests that don't need it

2011-06-21 Thread Janis Johnson
This patch removes -march=armv7-a from four tests that pass with all -march values from armv4t on. OK for trunk? 2011-06-21 Janis Johnson jani...@codesourcery.com * gcc.target/arm/smlaltb-1.c: Don't specify -march. * gcc.target/arm/smlaltt-1.c: Likewise. *

[testsuite] ARM: require arm_thumb1_ok, drop -march

2011-06-21 Thread Janis Johnson
This test requires thumb1, so skip it for targets that don't support that instead of specifying an arch value that might be overridden by multilib flags. OK for trunk, and later for 4.6? 2011-06-21 Janis Johnson jani...@codesourcery.com * gcc.target/arm/thumb-bitfld1.c: Don't specify

[testsuite] ARM: require arm_thumb2_ok, drop -march

2011-06-21 Thread Janis Johnson
Modify three tests that require thumb2 support to check for that rather than specifying an arch value that might be overridden by multilib flags. OK for trunk, and later for 4.6? 2011-06-21 Janis Johnson jani...@codesourcery.com * gcc.target/arm/ctz.c: Don't specify -march,

Re: [testsuite] ARM: remove -march from tests that don't need it

2011-06-21 Thread Ramana Radhakrishnan
On 21 June 2011 22:04, Janis Johnson jani...@codesourcery.com wrote: This patch removes -march=armv7-a from four tests that pass with all -march values from armv4t on. OK for trunk? No, that sounds like a bug - if we are generating smlaltb and friends for v4t then the compiler is broken.

Re: [testsuite] ARM: require arm_thumb2_ok, drop -march

2011-06-21 Thread Ramana Radhakrishnan
On 21 June 2011 22:06, Janis Johnson jani...@codesourcery.com wrote: Modify three tests that require thumb2 support to check for that rather than specifying an arch value that might be overridden by multilib flags. OK for trunk, and later for 4.6? OK - this is a nice cleanup. Ramana

[testsuite] ARM: don't specify unneeded -march

2011-06-21 Thread Janis Johnson
I modified these tests last week to check for thumb support and to ignore messages about conflicting options, but -march isn't needed and so there shouldn't be any conflicting options. OK? 2011-06-21 Janis Johnson jani...@codesourcery.com * gcc.target/arm/pr45701-1.c: Don't specify

Re: __sync_swap* [ rename sync builtins ]

2011-06-21 Thread Graham Stott
All --- On Tue, 21/6/11, Richard Henderson r...@redhat.com wrote: From: Richard Henderson r...@redhat.com Subject: Re: __sync_swap* [ rename sync builtins ] To: Andrew MacLeod amacl...@redhat.com Cc: Aldy Hernandez al...@redhat.com, Jakub Jelinek ja...@redhat.com, Joseph S. Myers

[cxx-mem-model] sync_mem_exchange implementation with memory model parameters

2011-06-21 Thread Andrew MacLeod
OK, I've brought the cxx-mem-model branch up to mainline as of this afternoon. (After I applied the patch which renamed all the mis-named _sync expanders) So this is the marginally reworked patch we had before which I think satisfies all the requests I've seen. Bootstraps and no

[v3] Use noexcept in array swap

2011-06-21 Thread Paolo Carlini
Hi, tested x86_64-linux, committed. Paolo. /// 2011-06-22 Daniel Krugler daniel.krueg...@googlemail.com Paolo Carlini paolo.carl...@oracle.com * include/bits/move.h (__is_nothrow_swappable): Add. (swap(_Tp()[_Nm], _Tp()[_Nm])): Use noexcept.

Re: __sync_swap* [ rename sync builtins ]

2011-06-21 Thread Andrew MacLeod
On 06/21/2011 06:26 PM, Graham Stott wrote: All --- On Tue, 21/6/11, Richard Hendersonr...@redhat.com wrote: This looks to have broken the go frontend gcc/gcc/go/gofrontend/gogo-tree.cc: In member function ‘void Gogo::define_builtin_function_trees()’:

Clean up TARGET_ASM_NAMED_SECTION defaults

2011-06-21 Thread Joseph S. Myers
I noted in http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02172.html the fragile nature of the default of TARGET_HAVE_NAMED_SECTIONS based on TARGET_ASM_NAMED_SECTION (relying on (a) TARGET_ASM_NAMED_SECTION being defined in tm.h not a .c file and (b) the order in which headers are included). This

Re: [PATCH, ARM] VSHL, VSHR, VLSHR immediate values support

2011-06-21 Thread Ramana Radhakrishnan
Please get approval for the target independent parts (changes to optabs.c) separately from a middle-end maintainer.  I cannot approve those bits. Can a global reviewer take a look at the non-target specific changes http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00191.html cheers Ramana

Re: __sync_swap* [ rename sync builtins ]

2011-06-21 Thread Andrew MacLeod
On 06/21/2011 07:03 PM, Andrew MacLeod wrote: On 06/21/2011 06:26 PM, Graham Stott wrote: All --- On Tue, 21/6/11, Richard Hendersonr...@redhat.com wrote: This looks to have broken the go frontend Graham ah, missed it's .cc file, and I guess it doesn't build by default :-P This ought to

Re: Patch: speed up compiler a little bit by optimizing lookup_attribute() and is_attribute_p()

2011-06-21 Thread Nicola Pero
Ok, here's a revised patch (contextual diff, as requested). The inline code is now minimized to the hot stuff, as discussed. In benchmarks this arrangement performs a tiny bit slightly better than the previous patch, so that's great news. :-) Bootstrapped on GNU/Linux i686, regression tested.

Re: [Patch, AVR]: Fix PR46779

2011-06-21 Thread Hans-Peter Nilsson
On Mon, 13 Jun 2011, Georg-Johann Lay wrote: [In CCing Richard Henderson] Denis Chertykov schrieb: 2011/6/10 Georg-Johann Lay a...@gjlay.de: Then I observed trouble with DI patterns during libgcc build and had to remove * zero_extendqidi2 * zero_extendhidi2 *

Re: Improve jump threading #5 of N

2011-06-21 Thread Hans-Peter Nilsson
On Wed, 15 Jun 2011, Jeff Law wrote: So as I've mentioned previously, I've been working on a relatively small change to the jump threading code which would allow it to duplicate a join block when doing so allows us to thread through a successor of the join block. This is expected to be the

Regression with varpool alias reorg

2011-06-21 Thread Hans-Peter Nilsson
On Sat, 18 Jun 2011, Jan Hubicka wrote: * lto-symtab.c (lto_varpool_replace_node): Remove code handling extra name aliases. (lto_symtab_resolve_can_prevail_p): Likewise. (lto_symtab_merge_cgraph_nodes): Update alias_of pointers. * cgraphbuild.c

C++ PATCH for c++/49172 (allow constexpr reference variables)

2011-06-21 Thread Jason Merrill
We decided at the Madrid meeting to allow constexpr reference variables, and this patch adds that support to GCC. Tested x86_64-pc-linux-gnu, applying to trunk. commit 02d12daad9a5d1b265a328e43d758d9eedd9bb04 Author: Jason Merrill ja...@redhat.com Date: Tue Jun 21 22:24:29 2011 -0400 PR