Re: [PATCH 1/2] Add missing page rounding of a page_entry

2011-10-19 Thread Jakub Jelinek
On Wed, Oct 19, 2011 at 08:40:07AM +0200, Andi Kleen wrote: > diff --git a/gcc/ggc-page.c b/gcc/ggc-page.c > index 2da99db..ba88e3f 100644 > --- a/gcc/ggc-page.c > +++ b/gcc/ggc-page.c > @@ -736,6 +736,7 @@ alloc_page (unsigned order) >entry_size = num_objects * OBJECT_SIZE (order); >if (en

[PATCH, PR50769] Fix ICE in phi_alternatives_equal.

2011-10-19 Thread Tom de Vries
Richard, For the example from the PR, -ftree-tail-merge discovers that blocks 6 and 7 are equal, removes block 7 and redirects the outgoing edge of it's predecessor block 11 to block 6. Block 6 contains a phi, which after redirecting the edge from block 11 looks like this: ... .MEM_54 = PHI <.MEM

Re: [4.6] Fix type of SRAed enum accesses

2011-10-19 Thread Richard Guenther
On Tue, Oct 18, 2011 at 2:21 PM, Jakub Jelinek wrote: > On Tue, Sep 27, 2011 at 03:26:03PM +0100, Richard Sandiford wrote: >> This patch fixes a miscompilation of stage1 c-parser.o in an ARM bootstrap. >> When an access to an enum field was SRAed, a component ref used the type >> of the integer te

Re: [patch testsuite]: Adjust tree-ssa/builtin-expect-*.c tests for high cost-branching optimization

2011-10-19 Thread Richard Guenther
On Tue, Oct 18, 2011 at 1:33 PM, Kai Tietz wrote: > Hello, > > this patch adjusts __builtin_expect tests in tree-ssa so, that short-circuit > branch optimization don't lead to fallout.  I've used here a multiplication, > as simple substraction/addition might get optimized away. > > ChangeLog > >

Re: [PATCH] Fix gcc.dg/guality/asm-1.c regressions on 4.6 branch

2011-10-19 Thread Richard Guenther
On Tue, Oct 18, 2011 at 5:37 PM, Jakub Jelinek wrote: > Hi! > > Apparently a recent change (2011-10-1[23] or so) regressed > gcc.dg/guality/asm-1.c test on x86_64-linux on the 4.6 branch. > This turned out to be a bug in loc_descriptor which has been passing wrong > mode on the recursive call, so

Re: [PATCH 2/2] Free large chunks in ggc

2011-10-19 Thread Jakub Jelinek
On Wed, Oct 19, 2011 at 08:40:08AM +0200, Andi Kleen wrote: > From: Andi Kleen > > This implements the freeing back of large chunks in the ggc madvise path > Richard Guenther asked for. This way on systems with limited > address space malloc() and other allocators still have > a chance to get ba

Re: [PATCH, PR43814] Assume function arguments of pointer type are aligned.

2011-10-19 Thread Richard Guenther
On Wed, Oct 19, 2011 at 1:58 AM, Maxim Kuvyrkov wrote: > On 29/09/2011, at 10:23 PM, Richard Guenther wrote: > >> On Thu, Sep 29, 2011 at 10:27 AM, Tom de Vries >> wrote: > >> +              && SSA_NAME_IS_DEFAULT_DEF (expr) >> +              && TREE_CODE (var) == PARM_DECL >> +              &&

Weakref and cgraph part 1

2011-10-19 Thread Jan Hubicka
Hi, this patch makes cgraph code to also handle wekrefs as long as their destination declaration is known. The cases where it is not still needs updating at lto-symtab I plan to do incrementally. The basic idea is to handle weakrefs as external declaration (so they are subject of unrechable code

Re: patch ping: Dump the "degree of overlap" to compare static profile with instrumentation profile

2011-10-19 Thread Jan Hubicka
> http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01293.html Hi, this seems fine for mainline. I am not 100% sure it is best choice of metric (i.e. mostly one is interested if hot blocks identified by static profile cover hot blocks of real profile), but we could get some experience with it. Thanks

Re: [PATCH] Add an intermediate coverage format for gcov

2011-10-19 Thread Jan Hubicka
> On Oct 18, 2011, at 4:19 PM, Sharad Singhai wrote: > > Okay, I liked the idea of self-descriptive tags. I have updated the > > patch based on your suggestions. I have simplified the format > > somewhat. Instead of repeating function name, I use a 'function' tag > > with the format > > > > funct

Re: [Patch,AVR]: PR50447: Tweak addhi3

2011-10-19 Thread Denis Chertykov
2011/10/19 Georg-Johann Lay : > Georg-Johann Lay schrieb: >> >> Denis Chertykov schrieb: >> >>> What difference in size of avr-libc ? >> >> I have no tool for smart size analysis, so here is just a diff: >> >> After rebuilding avr-libc with respective compiler version, did >> respectively: >> >> $

Re: [PATCH][ARM] -m{cpu,tune,arch}=native

2011-10-19 Thread Andrew Stubbs
On 18/10/11 15:42, Andrew Stubbs wrote: Which still jumps to not_found without closing f. Hmmm, I know I fixed that, I know I did! But I appear to have lost the change somewhere when I updated my checkout? I'll fix it now. Fixed and committed as attached. Apologies for the cock-up. :( And

[PATCH] Fix PR50768, rewrite gimplify_and_update_call_from_tree

2011-10-19 Thread Richard Guenther
So my previous patch has caused some bugs - not unreasonable given the complexity of that function. Thus the following patch makes it readable and understandable again, by exchanging the intricate one-stage processing with a two-stage one, first assigning VDEFs and then assigning VUSEs in a secon

Re: [trans-mem] Rename/split __transaction into __transaction_atomic and __transaction_relaxed.

2011-10-19 Thread Torvald Riegel
On Tue, 2011-10-18 at 14:29 -0500, Aldy Hernandez wrote: > > Several ICEs in the TM tests on C++, but I think they are old. C TM > > tests work except some missing optimizations (old failures too). > > c-c++-common/tm/wrap-[12].c fail on C++, but not on C: > > wrap-1.c:5:57: error: 'transaction_wra

Re: [C++ Patch] __builtin_choose_expr

2011-10-19 Thread Andy Gibbs
Andy Gibbs wrote on 18th October 2011 at 1:36 PM: > Paolo Carlini wrote on 18th October 2011 at 12:00 PM: >> I'm under the impression that some tests are written in C, wouldn't better >> fit in c-c++-common? > > Ok, I can do this but I think only 2 out of the 8 tests can be moved > across. I will

[C++ Patch] PR 38761, 40872

2011-10-19 Thread Paolo Carlini
Hi, these simple PRs are both about conditional expressions in error calls which apparently make the life very hard to gettext: today I double checked and current 0.18.1 is still unable to cope correctly with those, it just doesn't extract the second message. Thus the below, which simply uses

[PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread Sergey Ostanevich
Hi! Here is a patch to address PR50572. Successfully bootstrapped and passed make check on x86_64-linux. regards, Sergos 2011-10-19 Sergey Ostanevich * gcc/config/i386/i386.c (ix86_option_override_internal): use loop align by 16 bytes for Atom platform diff --git a/gcc/config/i386

Re: [PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread Uros Bizjak
Hello! > 2011-10-19 Sergey Ostanevich > > * gcc/config/i386/i386.c (ix86_option_override_internal): use loop > align by 16 bytes for Atom platform > > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > index 2c53423..7a93144 100644 > --- a/gcc/config/i386/i386.c > +++ b/gcc/co

[commit, spu] Fix PR target/50310 (unordered vector compares)

2011-10-19 Thread Ulrich Weigand
Hello, the pr50310 test cases are failing on SPU with internal compiler errors. It seems that if the back-end provides a vcond pattern, it must support all comparison operations, including unordered ones which are missing in the SPU implementation. Since we don't actually have any specific instru

Re: [PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread Sergey Ostanevich
On Wed, Oct 19, 2011 at 4:14 PM, Uros Bizjak wrote: > > You can just change the default in processor_target_table. > > Uros. > Will it be applicable during optimizations for size? It will hurt, although not much (see PR). New patch is below. Ok for trunk as obvious? Sergos 2011-10-19 Sergey Os

Re: [C++ Patch] PR 38761, 40872

2011-10-19 Thread Jason Merrill
OK. Jason

Re: [PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread Uros Bizjak
On Wed, Oct 19, 2011 at 2:26 PM, Sergey Ostanevich wrote: >> You can just change the default in processor_target_table. >> >> Uros. >> > > Will it be applicable during optimizations for size? It will hurt, > although not much (see PR). Looking at the code, I'd say that we don't handle -Os in dif

[PATCH, i386, PR50766] Fix incorrect mem/reg operands order

2011-10-19 Thread Kirill Yukhin
Hi, Here is (almost obvous) patch, which fixes PR50766. ChangeLog entry: 2011-10-19 Kirill Yukhin * config/i386/i386.md (bmi_bextr_): Update register/ memory operand order. (bmi2_bzhi_3): Ditto. (bmi2_pdep_3): Ditto. (bmi2_pext_3): Ditto. Bootstrapped,

Re: [PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread Sergey Ostanevich
On Wed, Oct 19, 2011 at 4:46 PM, Uros Bizjak wrote: > On Wed, Oct 19, 2011 at 2:26 PM, Sergey Ostanevich > wrote: > >>> You can just change the default in processor_target_table. >>> >>> Uros. >>> >> >> Will it be applicable during optimizations for size? It will hurt, >> although not much (see

[translation patch] Bunch of trivial PRs: 48638, 49517, 49704

2011-10-19 Thread Paolo Carlini
Hi, a bunch of trivial fixes from Roland. The only one I deem *slightly* more controversial is "AST" uppercase instead of "ast" in cp/semantics.c, I'm gonna wait a bit in case Jason has a different opinion... Thanks, Paolo. 2011-10-19 Roland Stigge PR tran

Re: [translation patch] Bunch of trivial PRs: 48638, 49517, 49704

2011-10-19 Thread Jason Merrill
OK. Jason

Re: [PATCH, i386, PR50766] Fix incorrect mem/reg operands order

2011-10-19 Thread Uros Bizjak
On Wed, Oct 19, 2011 at 3:07 PM, Kirill Yukhin wrote: > Here is (almost obvous) patch, which fixes PR50766. > > ChangeLog  entry: > 2011-10-19  Kirill Yukhin   > >        * config/i386/i386.md (bmi_bextr_): Update register/ >        memory operand order. >        (bmi2_bzhi_3): Ditto. >        (b

[PATCH] Fix PR50780, make comparisons able to throw again ...

2011-10-19 Thread Richard Guenther
This fixes PR50780 by validating a condition is gimple before substituting it into a COND_EXPR during forwprop. When looking at this I noticed that comparisons no longer are marked as possibly throwing - because of an old tuplification bug :/ Thus, fixed as well, hopefully without fallout. Boots

Re: [PATCH 2/6] Generate virtual locations for tokens

2011-10-19 Thread Ulrich Weigand
Dodji Seketeli wrote: > libcpp/ChangeLog > 2011-10-15 Tom Tromey > Dodji Seketeli > > (cpp_get_token_1): New static function. Split and extended from > cpp_get_token. Use reached_end_of_context and > consume_next_token_from_context. Unify its return point. Move

[build] Properly test for madvise on Solaris 10 (PR bootstrap/50777)

2011-10-19 Thread Rainer Orth
As described in the PR, Solaris 10 bootstrap is currently broken compiling ggc-page.c in stage2 due to no declaration for madvise(). This happens because g++ defines _XOPEN_SOURCE=600, which hides the declaration, and configure doesn't check for a declaration at all. The following patch fixes both

Re: [build] Properly test for madvise on Solaris 10 (PR bootstrap/50777)

2011-10-19 Thread Paolo Bonzini
On 10/19/2011 04:17 PM, Rainer Orth wrote: As described in the PR, Solaris 10 bootstrap is currently broken compiling ggc-page.c in stage2 due to no declaration for madvise(). This happens because g++ defines _XOPEN_SOURCE=600, which hides the declaration, and configure doesn't check for a declar

Re: [PATCH 2/2] Free large chunks in ggc

2011-10-19 Thread Andi Kleen
> If the size to free is smaller than the quirk size, then it has the very > undesirable effect that with using GC only you might run unnecessarily out > of virtual address space, because it allocates pages in 2MB chunks, but > if they are released in 1MB chunks, those released chunks will never be

Re: [trans-mem] Rename/split __transaction into __transaction_atomic and __transaction_relaxed.

2011-10-19 Thread Richard Henderson
On 10/19/2011 03:16 AM, Torvald Riegel wrote: > On Tue, 2011-10-18 at 14:29 -0500, Aldy Hernandez wrote: >>> Several ICEs in the TM tests on C++, but I think they are old. C TM >>> tests work except some missing optimizations (old failures too). >>> c-c++-common/tm/wrap-[12].c fail on C++, but not

Re: [PATCH 2/2] Free large chunks in ggc

2011-10-19 Thread Jakub Jelinek
On Wed, Oct 19, 2011 at 04:37:45PM +0200, Andi Kleen wrote: > > If the size to free is smaller than the quirk size, then it has the very > > undesirable effect that with using GC only you might run unnecessarily out > > of virtual address space, because it allocates pages in 2MB chunks, but > > if

Re: [PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread H.J. Lu
On Wed, Oct 19, 2011 at 6:09 AM, Sergey Ostanevich wrote: > On Wed, Oct 19, 2011 at 4:46 PM, Uros Bizjak wrote: >> On Wed, Oct 19, 2011 at 2:26 PM, Sergey Ostanevich >> wrote: >> You can just change the default in processor_target_table. Uros. >>> >>> Will it be applicable d

Re: [Patch,AVR]: PR50447: Tweak addhi3

2011-10-19 Thread Georg-Johann Lay
Denis Chertykov schrieb: >> Georg-Johann Lay schrieb: >>> Denis Chertykov schrieb: >>> What difference in size of avr-libc ? >>> I have no tool for smart size analysis, so here is just a diff: >>> >>> After rebuilding avr-libc with respective compiler version, did >>> respectively: >>> >>> $ f

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Andrew MacLeod
On 10/18/2011 06:25 PM, Andrew MacLeod wrote: Its impossible to implement a weak compare and swap unless you return both parameters in one operation. the compare_exchange matches the atomic interface for c++, and if we can't resolve it with a lock free instruction sequence, we have to leave

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Richard Henderson
On 10/18/2011 03:07 PM, Jakub Jelinek wrote: > On Tue, Oct 18, 2011 at 06:03:16PM -0400, Andrew MacLeod wrote: >> >> Here's the last of the missing intrinsics. compare_exchange is >> slightly different than the others since it doesn't map directly to >> an rtl pattern. Its format is : >> >> boo

[cxx-mem-model] fix some trivial renaming fallout

2011-10-19 Thread Andrew MacLeod
As was pointed out, __get_builtin_sync_mem was renamed to __get_builtin_atomic which isn't really right, so this patch renames it back. It also includes some formatting fixes which resulted from __sync_mem having a different number of letters than __atomic. Andrew * optabs.c (add_

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Jakub Jelinek
On Wed, Oct 19, 2011 at 08:05:26AM -0700, Richard Henderson wrote: > In one of Andrew's previous ideas he split _ace into two separate builtins: > > T __atomic_compare_exchange (T* mem, T oldval, T newval, ...); > bool __atomic_compare_exchange_success (T); > > where the input to __ace_succes

Re: [Patch, Fortran ] PR 50016: Slow Fortran I/O on Windows and flushing/_commit

2011-10-19 Thread Janne Blomqvist
On Mon, Oct 17, 2011 at 23:52, Janne Blomqvist wrote: > On Mon, Oct 17, 2011 at 19:03, Tobias Burnus wrote: >> Hi Janne, >> >> On 10/17/2011 05:30 PM, Janne Blomqvist wrote: >>> >>> On Mon, Oct 17, 2011 at 15:49, Tobias Burnus  wrote: This patch adds a call to _commit() on _WIN32 for th

Re: [PATCH, PR50769] Fix ICE in phi_alternatives_equal.

2011-10-19 Thread Richard Guenther
On Wed, Oct 19, 2011 at 10:23 AM, Tom de Vries wrote: > Richard, > > For the example from the PR, -ftree-tail-merge discovers that blocks 6 and 7 > are > equal, removes block 7 and redirects the outgoing edge of it's predecessor > block > 11 to block 6. > > Block 6 contains a phi, which after re

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Richard Henderson
> ! weak = expand_expr (CALL_EXPR_ARG (exp, 3), NULL_RTX, ptr_mode, > ! EXPAND_NORMAL); > ! > ! if (weak != const0_rtx && weak != const1_rtx) > ! { > ! error ("strong/weak parameter must be 0 or 1 for > %<__atomic_compare_exchange%>"); > ! return NULL_RTX; >

Re: [PATCH, i386, PR50766] Fix incorrect mem/reg operands order

2011-10-19 Thread H.J. Lu
On Wed, Oct 19, 2011 at 6:21 AM, Uros Bizjak wrote: > On Wed, Oct 19, 2011 at 3:07 PM, Kirill Yukhin > wrote: > >> Here is (almost obvous) patch, which fixes PR50766. >> >> ChangeLog  entry: >> 2011-10-19  Kirill Yukhin   >> >>        * config/i386/i386.md (bmi_bextr_): Update register/ >>      

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Andrew MacLeod
On 10/19/2011 11:16 AM, Jakub Jelinek wrote: On Wed, Oct 19, 2011 at 08:05:26AM -0700, Richard Henderson wrote: In one of Andrew's previous ideas he split _ace into two separate builtins: T __atomic_compare_exchange (T* mem, T oldval, T newval, ...); bool __atomic_compare_exchange_success

Re: [translation patch] Bunch of trivial PRs: 48638, 49517, 49704

2011-10-19 Thread H.J. Lu
On Wed, Oct 19, 2011 at 6:11 AM, Paolo Carlini wrote: > Hi, > > a bunch of trivial fixes from Roland. The only one I deem *slightly* more > controversial is "AST" uppercase instead of "ast" in cp/semantics.c, I'm > gonna wait a bit in case Jason has a different opinion... > > Thanks, > Paolo. > W

Re: [PATCH 2/2] Free large chunks in ggc

2011-10-19 Thread Jan Hubicka
> Why? For one, such allocations are very rare (you only get them when > a single GC allocation requests > page of memory, like perhaps a string > literal over 4KB or similar or function call with over 1000 arguments etc.). > And if they are unlikely to be reused, not munmapping them means wasting

Re: [PATCH, m68k] Enable building for ColdFire Linux

2011-10-19 Thread Andreas Schwab
Julian Brown writes: > Maxim Kuvyrkov > > gcc/ > * config/m68k/t-linux (M68K_MLIB_CPU): Add ColdFire CPUs. Ok. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely d

Re: [PATCH 2/6] Generate virtual locations for tokens

2011-10-19 Thread Dodji Seketeli
"Ulrich Weigand" writes: > The problem seems to be that the preprocessor somehow stripped > off the "unsigned" keyword. A reduced test case is: > > #define isinf(__x) > > #define vec_uint4 __vector unsigned int > > vec_uint4 isinf; > > (Using the name of a function-like macro as identifer is may

PR bootstrap/50709 (bootstrap miscompare)

2011-10-19 Thread Jan Hubicka
Hi, the ENABLE_CHECKING code verifying consistency of inliner cache has effect on changing order of querries to the fibheap that consequentely makes entries with same key come in different orders. Fixed by enabling the checking aways. I also added extra check that the keys are conservatively c

Re: [PATCH PR50572] Tune loop alignment for Atom

2011-10-19 Thread H.J. Lu
On Wed, Oct 19, 2011 at 9:30 AM, Sergey Ostanevich wrote: > 2011-10-18  Sergey Ostanevich > >    * config/i386/i386.c (processor_target_table): Change Atom >    align_loops_max_skip to 15. Please add PR # in ChangeLog. > > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > index 2c

Fwd: Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Andrew MacLeod
grr, reposting due to thunderbird apparently sneaking some HTML in and it being rejected... sigh. On 10/19/2011 11:34 AM, Richard Henderson wrote: ! weak = expand_expr (CALL_EXPR_ARG (exp, 3), NULL_RTX, ptr_mode, ! EXPAND_NORMAL); ! ! if (weak != const0_rtx&& weak !=

[4.6,patch,libgfortran/io] Fix build issue with _commit [PR5016]

2011-10-19 Thread Tobias Burnus
I intent to commit this patch - created mostly by Janne - soon to gcc-4_6-branch; it should solve a build issue. The patch was build and regtested on x86-64-linux and build and tested on MinGW and Cygwin by Kai. It is a follow up to http://gcc.gnu.org/ml/fortran/2011-10/msg00132.html / http:

[PATCH] Handle VEC_PERM_EXPR and WIDEN_LSHIFT_EXPR in expand_debug_expr (PR middle-end/50754)

2011-10-19 Thread Jakub Jelinek
Hi! These two tree codes have been added recently, but not to expand_debug_expr. The following patch adds them there, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2011-10-19 Jakub Jelinek PR middle-end/50754 * cfgexpand.c (expand_debug_expr): Handle WID

[PATCH] Extend vect_recog_bool_pattern also to stores into bool memory (PR tree-optimization/50596)

2011-10-19 Thread Jakub Jelinek
Hi! Similarly to casts of bool to integer, even stores into bool arrays can be handled similarly. Just we need to ensure tree-vect-data-refs.c doesn't reject vectorization before tree-vect-patterns.c has a chance to optimize it. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk

Re: [VTA, PR49310] O(n+m)-ish emit_notes

2011-10-19 Thread H.J. Lu
On Tue, Oct 18, 2011 at 7:50 AM, Alexandre Oliva wrote: > On Oct 17, 2011, Jakub Jelinek wrote: > >> On Tue, Oct 11, 2011 at 04:19:52PM -0300, Alexandre Oliva wrote: >>> Here's what I've got so far.  Regstrapped on x86_64-linux-gnu and >>> i686-linux-gnu.  Ok to install? > >> I see >> +FAIL: gcc.

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Richard Henderson
On 10/19/2011 09:26 AM, Andrew MacLeod wrote: > well, they are explicitly'compare_exchange_strong' and > 'compare_exchange_weak' calls... so yes, they have 'hardcoded' one or the > other :-) > we could alternatively do 2 separate builtins, but I didn't see the point. > But Im ambivalent.

Re: [PATCH] Handle VEC_PERM_EXPR and WIDEN_LSHIFT_EXPR in expand_debug_expr (PR middle-end/50754)

2011-10-19 Thread Richard Henderson
On 10/19/2011 10:11 AM, Jakub Jelinek wrote: > Hi! > > These two tree codes have been added recently, but not to expand_debug_expr. > The following patch adds them there, bootstrapped/regtested on x86_64-linux > and i686-linux, ok for trunk? > > 2011-10-19 Jakub Jelinek > > PR middle-en

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Andrew MacLeod
On 10/19/2011 01:55 PM, Richard Henderson wrote: On 10/19/2011 09:26 AM, Andrew MacLeod wrote: well, they are explicitly'compare_exchange_strong' and 'compare_exchange_weak' calls... so yes, they have 'hardcoded' one or the other :-) we could alternatively do 2 separate builtins, but I

Re: [4.6,patch,libgfortran/io] Fix build issue with _commit [PR5016]

2011-10-19 Thread Steve Kargl
On Wed, Oct 19, 2011 at 07:11:02PM +0200, Tobias Burnus wrote: > I intent to commit this patch - created mostly by Janne - soon to > gcc-4_6-branch; it should solve a build issue. > > The patch was build and regtested on x86-64-linux and build and tested > on MinGW and Cygwin by Kai. > > It is

Fix g++.dg/compat/struct-layout-1_generate.c options for Windows targets

2011-10-19 Thread Joseph S. Myers
g++.dg/compat/struct-layout-1_generate.c generates a dg-options line using -mno-mmx -Wno-abi for i?86-*-* x86_64-*-* - and one using -fno-common, which takes precedence, for alpha*-dec-osf* hppa*-*-hpux* powerpc*-*-darwin* *-*-mingw32* *-*-cygwin*. But at least i686-mingw32 still needs the -Wno-ab

Re: [PATCH] Add an intermediate coverage format for gcov

2011-10-19 Thread Sharad Singhai
Since the updated patch already uses unmangled function names, is it good to commit then? Sharad On Wed, Oct 19, 2011 at 1:48 AM, Jan Hubicka wrote: >> On Oct 18, 2011, at 4:19 PM, Sharad Singhai wrote: >> > Okay, I liked the idea of self-descriptive tags. I have updated the >> > patch based on

Re: [PATCH] Add an intermediate coverage format for gcov

2011-10-19 Thread Sharad Singhai
Sorry, I misunderstood your comment. I see that you are asking for unmangled function names whereas the current patch supports only mangled names. I can print unmangled names under another option. Would that work? Thanks, Sharad On Wed, Oct 19, 2011 at 12:06 PM, Sharad Singhai wrote: > Since the

Re: [google] AddressSanitizer for gcc, first attempt. (issue 5272048)

2011-10-19 Thread Xinliang David Li
On Wed, Oct 19, 2011 at 12:02 PM, wrote: > Minimized the crash to this: > > struct Foo { >  unsigned bf1:1; >  unsigned bf2:1; >  unsigned bf3:1; > }; > > void foo (struct Foo *ob) { >  ob->bf2 = 1; > } > > > > D.2731_4 = &ob_1(D)->bf2; > __asan_base_addr.2 = (long unsigned int) D.2731_4; > D.273

Re: [trans-mem] Add gl_wt TM method.

2011-10-19 Thread Richard Henderson
> Add support for TM-method-specific begin code. > > * libitm_i.h (GTM::gtm_restart_reason): Re-arrange and clean up > declarations. > * dispatch.h (GTM::abi_dispatch::begin_or_restart): New. > * method-serial.cc: Implement begin_or_restart(). > * beginend.cc

Re: [cxx-mem-model] compare_exchange implementation

2011-10-19 Thread Richard Henderson
On 10/19/2011 11:31 AM, Andrew MacLeod wrote: > If, which is more likely as I think about it, thats not the case and > the fences can look like they do in the second example (closer to the > CAS than the copies) , then the CAS can take care of both fences, > which would be much more preferable and

[PATCH] Further i?86 vector permutation fixes

2011-10-19 Thread Jakub Jelinek
Hi! This patch adds two new permutations to the vshuf* tests (VEC_PACK_TRUNC style) and fixes problems related to them. The first two fix issues with AVX2, the rest of the patch deals with the problem that if the shuffle mask suggests two operands, testing whether there is a permutation supported

[Patch ARM] Fix PR target/50106

2011-10-19 Thread Ramana Radhakrishnan
Hi, This fixes PR target/50106 which was missing handling return register size from 1-3 for Thumb1. Fixed thusly. Final testing on-going with arm-linux-gnueabi with thumb1. Ok to backport to 4.6 branch given it is branch freeze time ? I'll be able to commit this to the branch latest by tomorrow A

Re: [Patch ARM] Fix PR target/50106

2011-10-19 Thread Nathan Froyd
On 10/19/2011 3:27 PM, Ramana Radhakrishnan wrote: Index: gcc/config/arm/arm.c - live_regs_mask |= extra_mask<< (size / UNITS_PER_WORD); + live_regs_mask |= extra_mask<< ((size + 3) / UNITS_PER_WORD); IIUC, wouldn't ((size + UNITS_PER_WORD - 1) / UNITS_PER_WORD) be clearer? -Nathan

[PATCH, testsuite]: Require non_strict_align effective target for gcc.dg/ipa/ipa-sra-[26].c

2011-10-19 Thread Uros Bizjak
Hello! These two tests require non_strict_aligned effective target, since IPA fails in tree_non_mode_aligned_mem_p () for "cow" and "calf" candidates for STRICT_ALIGNMENT targets. Mode alignment requires 32 bytes, while data is aligned to 8 bytes. 2011-10-19 Uros Bizjak * gcc.dg/ipa/i

Re: [PATCH, testsuite]: Require non_strict_align effective target for gcc.dg/ipa/ipa-sra-[26].c

2011-10-19 Thread David Miller
From: Uros Bizjak Date: Wed, 19 Oct 2011 21:50:14 +0200 > Hello! > > These two tests require non_strict_aligned effective target, since IPA > fails in tree_non_mode_aligned_mem_p () for "cow" and "calf" > candidates for STRICT_ALIGNMENT targets. Mode alignment requires 32 > bytes, while data is

Re: [PATCH 2/6] Generate virtual locations for tokens

2011-10-19 Thread Dodji Seketeli
This is probably going to take some back and forth as I don't have any SPU target at hand to debug, so I have filed http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50801 to track this issue, along with a candidate fix. Could you please test it and reply to the bug with your results? Thank you for you

Re: Fix g++.dg/compat/struct-layout-1_generate.c options for Windows targets

2011-10-19 Thread Mike Stump
On Oct 19, 2011, at 11:58 AM, "Joseph S. Myers" wrote: > g++.dg/compat/struct-layout-1_generate.c generates a dg-options line > using -mno-mmx -Wno-abi for i?86-*-* x86_64-*-* - and one using > -fno-common, which takes precedence, for alpha*-dec-osf* hppa*-*-hpux* > powerpc*-*-darwin* *-*-mingw32*

Re: [PATCH] Further i?86 vector permutation fixes

2011-10-19 Thread Richard Henderson
On 10/19/2011 12:25 PM, Jakub Jelinek wrote: > 2011-10-19 Jakub Jelinek > > * config/i386/i386.c (expand_vec_perm_vpshufb2_vpermq_even_odd): Use > d->op1 instead of d->op0 for the second vpshufb. > (expand_vec_perm_even_odd_1): For V8SImode fix vpshufd immediates. > (ix8

Re: C++ PATCH for c++/49172 (allow constexpr reference variables)

2011-10-19 Thread Jason Merrill
On 06/22/2011 12:19 AM, Jason Merrill wrote: We decided at the Madrid meeting to allow constexpr reference variables, and this patch adds that support to GCC. The cp_parser_initializer_clause hunk also fixes 50787, a bug with direct binding of references in 4.6, so I'm applying that one there.

Re: [4.6,patch,libgfortran/io] Fix build issue with _commit [PR5016]

2011-10-19 Thread Tobias Burnus
Pre-remark: Jakub (4.6.2 RM) had no objects - and thus I have committed it to the branch. Steve Kargl wrote: I don't have an objection, just a question. Does this issue appear on trunk? Yes and no. The MinGW build issue this patch fixes was unique to the branch. However, the actual issue - t

Re: [PATCH] Add an intermediate coverage format for gcov

2011-10-19 Thread Mike Stump
On Oct 19, 2011, at 12:12 PM, Sharad Singhai wrote: > Sorry, I misunderstood your comment. I see that you are asking for > unmangled function names whereas the current patch supports only > mangled names. I can print unmangled names under another option. Would > that work? I defer to the person t

Re: [PATCH] Further i?86 vector permutation fixes

2011-10-19 Thread Jakub Jelinek
On Wed, Oct 19, 2011 at 01:36:25PM -0700, Richard Henderson wrote: > Although I think a good followup would be to fix > this so that we don't need a copy to another register. > That could be done by adding a d.one_operand field, and > using that test instead of explicit equality everywhere. Perhap

[PATCH, testsuite]: Fix PR 50796, FAIL: gcc.dg/plugin/plugindir[1234].c

2011-10-19 Thread Uros Bizjak
Hello! Update dg-prune-output due to inacessible -> inaccessible change. 2011-10-19 Uros Bizjak PR testsuite/50796 * gcc.dg/plugin/plugindir?.c Update dg-prune-output. Tested on x86_64-pc-linux-gnu, committed to mainline SVN. Uros. Index: gcc.dg/plugin/plugindir1.c =

Re: [PATCH, testsuite]: Fix PR 50796, FAIL: gcc.dg/plugin/plugindir[1234].c

2011-10-19 Thread Andreas Schwab
Uros Bizjak writes: > Index: gcc.dg/plugin/plugindir1.c > === > --- gcc.dg/plugin/plugindir1.c(revision 180206) > +++ gcc.dg/plugin/plugindir1.c(working copy) > @@ -1,4 +1,4 @@ > /* { dg-do compile } */ > /* { dg-op

regcprop.c bug fix

2011-10-19 Thread Mike Stump
So while tracking down a hairy address reload for an output reload bug, copyprop_hardreg_forward_1 was faulting because it was trying to extract move patterns that didn't work out, and when it came back to the code, it then tries to access recog_data, but the problem is, the exploration of other

[PATCH, m68k] Fix floating-point comparisons with zero

2011-10-19 Thread Julian Brown
Hi, It appears that m68k floating-point comparisons may have been subtly broken since 2007 when the following patch was applied: http://gcc.gnu.org/ml/gcc-patches/2007-09/msg01570.html The bug shows with our internal 4.6-based branch, but appears to be latent on mainline (generated code is per

[C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Paolo Carlini
Hi, in these two twin PRs filed by Ian and Gerald, it is pointed out that cases like: struct C { int f() { return 1; } }; int f(C&c) { return ( 1 == c.f ); } where the user actually forgot the open-closed round braces are much more likely than cases where an ampersand

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Gabriel Dos Reis
On Wed, Oct 19, 2011 at 4:34 PM, Paolo Carlini wrote: > Hi, > > in these two twin PRs filed by Ian and Gerald, it is pointed out that cases > like: > >   struct C { >     int f() { return 1; } >   }; > >   int f(C&c) { >     return ( 1 == c.f ); >   } > > where the user actually forgot the open-cl

Re: [google] AddressSanitizer for gcc, first attempt. (issue 5272048)

2011-10-19 Thread Xinliang David Li
what kind of failures? David On Wed, Oct 19, 2011 at 2:04 PM, wrote: > On 2011/10/19 20:38:35, kcc wrote: >> >> Added code to avoid bitfields. > > Is there anything I should know about splitting basic blocks in the > presence of EH? > Currently, asan fails on 483.xalancbmk, 453.povray and 450.s

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-10-19 Thread Maxim Kuvyrkov
On 28/09/2011, at 4:56 PM, Maxim Kuvyrkov wrote: > Jan, > > The following patch starts a series of patches which improve devirtualization > optimizations in GCC. > > This patch builds on ipa-cp.c and ipa-prop.c infrastructure for analyzing > parameters and jump functions and adds basic estimat

Re: [Patch, Fortran] PR 47023: C_Sizeof: Rejects valid code

2011-10-19 Thread Janus Weil
>> If I saw it correctly, one still needs to fix the vendor-extension SIZEOF >> for procedure pointers (it currently returns one byte!) > > Right. Actually I don't quite understand where that 1 byte comes from. I have just committed the patch from comment #23 of the PR (which has been approved by

Re: [patch] Fix PR tree-optimization/49960 ,Fix self data dependence

2011-10-19 Thread Razya Ladelsky
gcc-patches-ow...@gcc.gnu.org wrote on 17/10/2011 09:03:59 AM: > From: Richard Guenther > To: Razya Ladelsky/Haifa/IBM@IBMIL > Cc: gcc-patches@gcc.gnu.org, Sebastian Pop > Date: 17/10/2011 09:04 AM > Subject: Re: [patch] Fix PR tree-optimization/49960 ,Fix self data dependence > Sent by: gcc-pa

Re: [trans-mem] Add gl_wt TM method.

2011-10-19 Thread Torvald Riegel
Committed with the changes below. On Wed, 2011-10-19 at 12:17 -0700, Richard Henderson wrote: > > Add support for TM-method-specific begin code. > > > > * libitm_i.h (GTM::gtm_restart_reason): Re-arrange and clean up > > declarations. > > * dispatch.h (

Re: [PATCH] Don't assume that constants can clobber vtbl

2011-10-19 Thread Maxim Kuvyrkov
On 11/10/2011, at 4:05 AM, Martin Jambor wrote: > > Just before this, there is the following test (guarded by > flag_strict_aliasing per explicit Richi's request). > > if (flag_strict_aliasing > && !POINTER_TYPE_P (TREE_TYPE (lhs))) > return false; > > Why is it n

C++ PATCH for c++/50793 (incomplete value-initialization with default argument)

2011-10-19 Thread Jason Merrill
When bot_manip regenerates TARGET_EXPR/AGGR_INIT_EXPR, it needs to preserve the AGGR_INIT_ZERO_FIRST flag. Tested x86_64-pc-linux-gnu, applying to trunk and release branches. commit f56f4ec3e3620b4ae4e07986a17338d607952c65 Author: Jason Merrill Date: Wed Oct 19 17:21:34 2011 -0400 PR c+

Re: Intrinsics for N2965: Type traits and base classes

2011-10-19 Thread Benjamin Kosnik
> Please post a ChangeLog entry with a patch. Someone added one for > you: > > 2011-10-17 Michael Spertus > > * gcc/c-family/c-common.c (c_common_reswords): Add __bases, > __direct_bases. > * gcc/c-family/c-common.h: Add RID_BASES and RID_DIRECT_BASES. > > but it is in the

[C++ Patch] PR 13657

2011-10-19 Thread Paolo Carlini
Hi, this tries to implement what Jason suggested in the audit trail: do not refer to an argument and use instead 'cannot convert...", like, eg, in cvt.c. Tested x86_64-linux. Thanks, Paolo. // /cp 2011-10-19 Paolo Carlini PR c++/13657 * class.c (insta

[SH] PR 50694 - SH2A little endian does not actually work

2011-10-19 Thread Oleg Endo
Hello, the attached patch addresses PR 50694 and also does some cleanups in sh.md. I haven't run the testsuite with this one since it's basically just text replacements, except for the changed cmpgeusi_t insn. However, CSiBE didn't show any code size changes with the changed insn. As far as I c

Re: [C++ Patch] PR 13657

2011-10-19 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Jason Merrill
Surely we should only make this change for function members. Jason

[v3] tr2: bool_set, dynamic_bitset, ratio

2011-10-19 Thread Benjamin Kosnik
jamin 20111019-1.patch.bz2 Description: application/bzip

Avoid gcc.dg/tree-prof/val-prof-7.c dependence on

2011-10-19 Thread Joseph S. Myers
The testcase gcc.dg/tree-prof/val-prof-7.c includes to get a declaration of bzero. This causes it to fail on targets where bzero (a legacy function removed in the latest version of POSIX) is not declared in that header; declaring it explicitly in the testcase is more reliable. This patch changes

new patches using -fopt-info (issue5294043)

2011-10-19 Thread Rong Xu
After some off-line discussion, we decided to use a more general approach to control the printing of optimization messages/warnings. We will introduce a new option -fopt-info: * fopt-info=0 or fno-opt-info: no message will be emitted. * fopt-info or fopt-info=1: emit important warnings and optimi

Re: new patches using -fopt-info (issue5294043)

2011-10-19 Thread Andi Kleen
x...@google.com (Rong Xu) writes: > After some off-line discussion, we decided to use a more general approach > to control the printing of optimization messages/warnings. We will > introduce a new option -fopt-info: > * fopt-info=0 or fno-opt-info: no message will be emitted. > * fopt-info or fo

  1   2   >