Re: [google] Backport r171347 and r181549 from trunk (strict volatile bitfield) (issue5434084)

2011-12-09 Thread Mike Stump
On Dec 7, 2011, at 5:32 AM, Richard Earnshaw wrote: > So this, to some extent seems to conflict with your rules for only fixing > regressions. This code has always been broken in one way or another, > so technically this doesn't qualify for the 4.6 branch. My take, does this fix improve the qual

Re: [PATCH] Sink clobbers if EH block contains just clobbers (PR tree-optimization/51117)

2011-12-09 Thread Richard Henderson
On 12/09/2011 11:49 AM, Jakub Jelinek wrote: > PR tree-optimization/51117 > * tree-eh.c (sink_clobbers): New function. > (execute_lower_eh_dispatch): Call it for BBs ending with > internally throwing RESX. > * cfgexpand.c (add_scope_conflicts_1): Add SCRATCH argument.

Re: [RFC, PATCH] ARM related deprecations

2011-12-09 Thread John Tytgat
In message <4ee2285b.3060...@arm.com> Richard Earnshaw wrote: > I think we've reached the point where the following target > configurations should be End-of-Life'd. As such, I'd like to mark them > as deprecated in gcc-4.7, prior to removal after the branch. > > I'd also like to remov

Re: [Patch] Remove flag_objc-sjlj_exceptions as a User control, move ObjC exception mechanism choices to gcc/objc/

2011-12-09 Thread Gerald Pfeifer
On Wed, 30 Nov 2011, Iain Sandoe wrote: There is really no point in having a flag to control the Objective C (or Objective C++) exceptions [@throw, as opposed to throw] scheme, since we actually only support one scheme for each permutation of runtime and ABI. This removes the flag_objc_sjlj_e

Re: [libgo] PATCH: Handle system call numbers "(0x40000000 | (234))"

2011-12-09 Thread H.J. Lu
On Fri, Dec 9, 2011 at 3:02 PM, Ian Lance Taylor wrote: > "H.J. Lu" writes: > >> On Fri, Dec 9, 2011 at 2:47 PM, Ian Lance Taylor wrote: >>> "H.J. Lu" writes: >>> Some my Linux system, system call numbers are defined as #define __NR_x32_rt_sigaction                 __NR_X32_SYSCA

Re: [libgo] PATCH: Handle system call numbers "(0x40000000 | (234))"

2011-12-09 Thread Ian Lance Taylor
"H.J. Lu" writes: > On Fri, Dec 9, 2011 at 2:47 PM, Ian Lance Taylor wrote: >> "H.J. Lu" writes: >> >>> Some my Linux system, system call numbers are defined as >>> >>> #define __NR_x32_rt_sigaction                 __NR_X32_SYSCALL(0) >>> >>> and >>> >>> __NR_X32_SYSCALL(0) is expanded to (0x40

Re: [libgo] PATCH: Handle system call numbers "(0x40000000 | (234))"

2011-12-09 Thread H.J. Lu
On Fri, Dec 9, 2011 at 2:47 PM, Ian Lance Taylor wrote: > "H.J. Lu" writes: > >> Some my Linux system, system call numbers are defined as >> >> #define __NR_x32_rt_sigaction                 __NR_X32_SYSCALL(0) >> >> and >> >> __NR_X32_SYSCALL(0) is expanded to (0x4000 | (512 + 0)).  This patc

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-09 Thread Xinliang David Li
The patch is good for google branches for now while waiting for upstream review. David On Sun, Dec 4, 2011 at 10:26 PM, Teresa Johnson wrote: > Latest patch which improves the efficiency as described below is > included here. Boostrapped and checked again with > x86_64-unknown-linux-gnu. Could s

Re: [libgo] PATCH: Handle system call numbers "(0x40000000 | (234))"

2011-12-09 Thread Ian Lance Taylor
"H.J. Lu" writes: > Some my Linux system, system call numbers are defined as > > #define __NR_x32_rt_sigaction __NR_X32_SYSCALL(0) > > and > > __NR_X32_SYSCALL(0) is expanded to (0x4000 | (512 + 0)). This patch > tries to deal with by checking '^// unknowndefine SYS_[a-z]' an

Re: PR/51291: fix -fgnu-tm ICEs on fortran

2011-12-09 Thread Richard Henderson
On 12/09/2011 01:44 PM, Aldy Hernandez wrote: > PR/51291 > * tree.c (build_common_builtin_nodes): Do not use TM_PURE > attribute unless language has support for TM. > * config/i386/i386.c (ix86_init_tm_builtins): Exit gracefully in > the absence of TM builtins. Ok.

PR/51291: fix -fgnu-tm ICEs on fortran

2011-12-09 Thread Aldy Hernandez
Compiling any fortran program with -fgnu-tm currently ICEs because the TM builtins are defined in gtm-builtins.def which are not included (via builtins.def) in the Fotran front-end. Presently, there are no TM extensions for the Fortran language, but it shouldn't ICE. We could error out early

[libgo] PATCH: Handle system call numbers "(0x40000000 | (234))"

2011-12-09 Thread H.J. Lu
Hi Ian, Some my Linux system, system call numbers are defined as #define __NR_x32_rt_sigaction __NR_X32_SYSCALL(0) and __NR_X32_SYSCALL(0) is expanded to (0x4000 | (512 + 0)). This patch tries to deal with by checking '^// unknowndefine SYS_[a-z]' and uses "${CC} -E" to e

Fix oversight in change to gimple_fold_stmt_to_constant_1

2011-12-09 Thread Eric Botcazou
ple-fold.c (gimple_fold_stmt_to_constant_1) : Also check the TYPE_MODE to recognize useless pointer conversions. 2011-12-09 Eric Botcazou * gcc.c-torture/compile/20111209-1.c: New test. -- Eric Botcazou Index: gim

Re: unordered containers emplace

2011-12-09 Thread François Dumont
Attached patch applied. 2011-12-09 François Dumont * include/bits/hashtable.h (_Hashtable<>::emplace, _Hashtable<>::emplace_hint): Add. * include/debug/unordered_set (unordered_set<>::emplace, unordered_set<>::emplace_hint, unordered_multiset<>::emplace,

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Iain Sandoe
On 9 Dec 2011, at 19:45, Aldy Hernandez wrote: On 12/09/11 13:19, Jakub Jelinek wrote: On Fri, Dec 09, 2011 at 08:17:04PM +0100, Dominique Dhumieres wrote: +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" } } */ It works for me too. Except that when matching just , (% it doesn't tes

Re: [PATCH] Fix up optimize_clobbers (PR tree-optimization/51117)

2011-12-09 Thread Richard Henderson
On 12/09/2011 09:11 AM, Jakub Jelinek wrote: > PR tree-optimization/51117 > * tree-eh.c (optimize_clobbers): Don't remove just one > clobber, but all consecutive clobbers before RESX. > Use gimple_clobber_p predicate. Ok. r~

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Jack Howarth
On Fri, Dec 09, 2011 at 01:45:48PM -0600, Aldy Hernandez wrote: > On 12/09/11 13:19, Jakub Jelinek wrote: >> On Fri, Dec 09, 2011 at 08:17:04PM +0100, Dominique Dhumieres wrote: +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" } } */ >>> >>> It works for me too. >> >> Except that when ma

[PATCH 2/2] PR c++/51239, c++/51180 - Better support for unbound alias templates

2011-12-09 Thread Dodji Seketeli
With the infrastructure of the previous patch in place, this patch easily uses TEMPLATE_ID_TYPE to represent unbound specializations of alias templates, thus fixing PR c++/51239. A new function introduced to fix that bug is also used to address PR c++/51180 by fixing the representation of template

[PATCH 1/2] Use TEMPLATE_ID_TYPE in lieu of BOUND_TEMPLATE_TEMPLATE_PARM

2011-12-09 Thread Dodji Seketeli
As presented in the cover message, this patch replaces the BOUND_TEMPLATE_TEMPLATE_PARM tree with a TEMPLATE_ID_TYPE tree that represents a template-id whose arguments haven't yet been applied to its template. The template itself might have not been resolved to a TEMPLATE_DECL yet, in which case i

[PATCH 0/2] Better represent unbound template specializations (PR c++/51239, c++/51180)

2011-12-09 Thread Dodji Seketeli
Hello, The little patch set of this thread addresses PRs c++/51239 and PRs c++/51180 in a generic way, as you suggested. It replaces the BOUND_TEMPLATE_TEMPLATE_PARM tree with a TEMPLATE_ID_TYPE tree and makes bound template template parameters and typename types use that new tree. With this inf

C++ PATCH for c++/51151 (bogus -Woverflow)

2011-12-09 Thread Jason Merrill
This was caused by my earlier kludge to build normal conversions between scalar types in templates; the instantiation code isn't prepared to deal with all the various tree forms that can occur that way. So now I've limited it to the identity conversion, which shouldn't require any added trees

Re: [PATCH][C++] Fix PR51262

2011-12-09 Thread Jason Merrill
OK. Jason

[PATCH] Sink clobbers if EH block contains just clobbers (PR tree-optimization/51117)

2011-12-09 Thread Jakub Jelinek
Hi! Even with the optimize_clobbers changes, for e.g. struct A { char buf[64]; }; void bar (A *); void foo () { A c; bar (&c); try { { A a; bar (&a); if (a.buf[13]) throw 1; else if (a.buf[52]) throw 3; } { A b; bar (&b);

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Aldy Hernandez
On 12/09/11 13:19, Jakub Jelinek wrote: On Fri, Dec 09, 2011 at 08:17:04PM +0100, Dominique Dhumieres wrote: +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" } } */ It works for me too. Except that when matching just , (% it doesn't test almost anything. IMNSHO you should instead just

Re: [PATCH 6/6] arm: Implement vec_perm and vec_perm_const for NEON.

2011-12-09 Thread Richard Henderson
On 12/09/2011 10:02 AM, Ramana Radhakrishnan wrote: > For Neon a further optimization to consider might be to use the vext > instruction which could achieve permute masks that are monotonically > increasing constants ? While I expect the latency for a vext or vtbl > instruction to be about the same

Re: [PATCH 0/6] Implement vec_perm_const consistently

2011-12-09 Thread David Edelsohn
On Thu, Dec 8, 2011 at 4:06 PM, Richard Henderson wrote: >  rs6000: Implement vec_perm_constv16qi for altivec. >  rs6000: Cleanup interleave/even_odd/vec_perm. The rs6000 patches are okay with the changes that you, Mike and I discussed on IRC. Thanks, David

[pph] Fix test failure in my last patch (issue5476051)

2011-12-09 Thread Diego Novillo
Bah, I ran make check in a different build directory. This fixes the two failures I introduced with my warning patch. Now tested on the proper build dir. Diego. cp/ChangeLog.pph * pph-core.c (pph_include_handler): Use LOC instead of INPUT_LOCATION. testsuite/ChangeLog.pph

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Jakub Jelinek
On Fri, Dec 09, 2011 at 08:17:04PM +0100, Dominique Dhumieres wrote: > > +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" } } */ > > It works for me too. Except that when matching just , (% it doesn't test almost anything. IMNSHO you should instead just test it { target !fpic } or similar.

[pph] Tolerate missing and invalid PPH files (issue5475055)

2011-12-09 Thread Diego Novillo
We currently emit hard errors when a PPH image is missing or invalid. This is not ideal, because in these cases, what the compiler could do is to simply use the original text header file. After all, they are interchangeable. Additionally, this helps the current implementation into finding other

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Dominique Dhumieres
> +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" } } */ It works for me too. Thanks, Dominique

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Iain Sandoe
On 9 Dec 2011, at 18:52, Aldy Hernandez wrote: there are 4 cases: {c,c++} {m32,m64} with 4 different asm outputs if that is a 'reasonable' situation - then might need to include ilp64/ip32 in the target spec ... Both the 32 and 64 bit versions of the Darwin output are correct, so perhaps

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Aldy Hernandez
there are 4 cases: {c,c++} {m32,m64} with 4 different asm outputs if that is a 'reasonable' situation - then might need to include ilp64/ip32 in the target spec ... Both the 32 and 64 bit versions of the Darwin output are correct, so perhaps something like I had originally proposed, but taki

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Iain Sandoe
On 9 Dec 2011, at 17:50, Aldy Hernandez wrote: scan-assembler can be target-dependent if that would (as I read the above) help. Well, whadayaknow... In that case we can have an x86 variant for Darwin, and one for everything else x86. in principle, it should be OK ... with *-*-darwin*

Re: [PATCH 6/6] arm: Implement vec_perm and vec_perm_const for NEON.

2011-12-09 Thread Michael Meissner
On Fri, Dec 09, 2011 at 06:02:21PM +, Ramana Radhakrishnan wrote: > On 8 December 2011 21:06, Richard Henderson wrote: > > --- > >  gcc/config/arm/arm-protos.h           |    3 + > >  gcc/config/arm/arm.c                  |  527 > > - > >  gcc/config/arm/neon.m

Re: [PATCH 6/6] arm: Implement vec_perm and vec_perm_const for NEON.

2011-12-09 Thread Ramana Radhakrishnan
On 8 December 2011 21:06, Richard Henderson wrote: > --- >  gcc/config/arm/arm-protos.h           |    3 + >  gcc/config/arm/arm.c                  |  527 > - >  gcc/config/arm/neon.md                |   59 >  gcc/config/arm/vec-common.md          |   26 ++ >

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Aldy Hernandez
scan-assembler can be target-dependent if that would (as I read the above) help. Well, whadayaknow... In that case we can have an x86 variant for Darwin, and one for everything else x86. OK? testsuite/ * c-c++-common/cxxbitfields-3.c: Adjust regexp. Index: testsuite/c-c++-common/c

Re: -finstrument-functions leads to unsats to _mm instrinsic wrappers

2011-12-09 Thread Xinliang David Li
Ping .. On Wed, Dec 7, 2011 at 4:01 PM, Xinliang David Li wrote: > Build the test case in the patch file with -finstrument-functions, the > link will fail with unsat. The problem is gcc instruments the > artificial wrappers that will won't be emitted. The patch fixes the > problem. Bootstrap and

Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Iain Sandoe
On 9 Dec 2011, at 17:35, Aldy Hernandez wrote: This test is somewhat problematic in that it's entirely dependent on the assembler output. It's not reproducible on non-x86, so I couldn't make it part of the simulate-thread framework. What we're really testing is that the last move into "va

PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

2011-12-09 Thread Aldy Hernandez
This test is somewhat problematic in that it's entirely dependent on the assembler output. It's not reproducible on non-x86, so I couldn't make it part of the simulate-thread framework. What we're really testing is that the last move into "var" happens as a 32/64 bit quantity: movl

[PATCH] Fix up optimize_clobbers (PR tree-optimization/51117)

2011-12-09 Thread Jakub Jelinek
Hi! When working on clobber sinking, I've noticed that optimize_clobbers would mistakenly remove just one clobber instead of all consecutive ones, because gsi_remove moves the iterator to the next rather than previous stmt (i.e. GIMPLE_RESX if no debug stmts) and we return in the next iteration.

[PATCH] Fix vectorizer ICEs with calls with MEM_REF arguments (PR tree-optimization/51485)

2011-12-09 Thread Jakub Jelinek
Hi! As mentioned in the PR, we ICE on the following testcase, because there are DRs in a GIMPLE_CALL stmt and when there is just one, we compute vectype for the call as if it were a load or store, but during computation of vectorization factor we only consider the return value of the call. As suc

Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]

2011-12-09 Thread Eric Botcazou
> Windows doesn't have any concept of an rpath in executables, nor of > LD_LIBRARY_PATH; all required DLLs must be found on the PATH when an exe is > invoked. The Ada shared libraries are currently installed into adaobj/ in > the gcc private dir, which is not (and should not be) on users' PATHs,

Re: [PATCH] use -fno-pie on darwin in boehm-gc.exp

2011-12-09 Thread Jack Howarth
On Fri, Dec 09, 2011 at 10:03:47AM -0500, Jack Howarth wrote: > On Fri, Dec 09, 2011 at 02:09:54PM +, Iain Sandoe wrote: > > > > On 8 Dec 2011, at 20:55, Iain Sandoe wrote: > >> ... but, I'll bow out at this juncture - > > > > OK, I lied :-) > > > > The boehm-gc tests pass for m32 and m64 with

Re: [PATCH] use -fno-pie on darwin in boehm-gc.exp

2011-12-09 Thread Jack Howarth
On Fri, Dec 09, 2011 at 05:26:47PM +0100, Rainer Orth wrote: > Hi Jack, > > > The same argument could be made for PIC itself regarding the testsuite. > > Aren't we still the only target that defaults to PIC objects? I would think > > that > > certainly not: e.g. both Tru64 UNIX and IRIX are

Re: libgo patch committed: Update to weekly.2011-11-09

2011-12-09 Thread Ian Lance Taylor
Rainer Orth writes: > This patch led to many (all?) execution tests to fail on Solaris: > > Undefined first referenced > symbol in file > libgo_log.syslog.syslog_c > /var/gcc/regression/trunk/11-gcc-gas/build/i386-pc-solaris2.11/./libg

PR 50873: create_fixed_operand and virtual regs

2011-12-09 Thread Richard Sandiford
ARM's neon_vector_mem_operand does not allow eliminable or virtual registers to be used as addresses. create_*_operand was supposed to cope with that by replacing the address with a (non-virtual) pseudo register. The problem is that I used the wrong function: force_reg rather than copy_to_mode_re

libgo patch committed: Print to stderr

2011-12-09 Thread Ian Lance Taylor
The predeclared print function in Go should print to stderr, not stdout. This patch from Rémy Oudompheng fixes libgo to do that. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r e73cfc80d5d7 libgo/runtime/go-print.c --- a/libgo/runtime/go-print.c

[ARM] PR 48941: poor code generated for vzip*() and vunzp*()

2011-12-09 Thread Richard Sandiford
The buit-in functions that underlie ARM's vzip*() and vunzp*() functions pass the result by reference rather than value. This leads to very poor output, as demonstrated in PR 48941. This patch makes them return the vectors by value instead, using the structure modes TImode and OImode. Tested on

Re: Fix ThreadSanitizer pass required properties (issue5477053)

2011-12-09 Thread Diego Novillo
On 11-12-09 09:36 , Dmitriy Vyukov wrote: This is for google-main branch. Fix ThreadSanitizer pass required properties. Turned out that PROP_gimple_lomp is not always present. Index: gcc/tree-tsan.c === --- gcc/tree-tsan.c (revi

Re: [PATCH 5/6] mips: Implement vec_perm_const.

2011-12-09 Thread Richard Henderson
On 12/08/2011 10:08 PM, Hans-Peter Nilsson wrote: > On Thu, 8 Dec 2011, Richard Henderson wrote: >> diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c >> index d3fd709..f1c3665 100644 >> --- a/gcc/config/mips/mips.c >> +++ b/gcc/config/mips/mips.c > >> @@ -13021,8 +13015,8 @@ static cons

Re: [PATCH] use -fno-pie on darwin in boehm-gc.exp

2011-12-09 Thread Rainer Orth
Hi Jack, > The same argument could be made for PIC itself regarding the testsuite. > Aren't we still the only target that defaults to PIC objects? I would think > that certainly not: e.g. both Tru64 UNIX and IRIX are PIC by default. Rainer -- -

Re: libgo patch committed: Update to weekly.2011-11-09

2011-12-09 Thread Rainer Orth
Ian Lance Taylor writes: > Rémy Oudompheng contributed a patch to upgrade the gccgo version of Go > library to the weekly.2011-11-09 release. This patch commits the change > to mainline. As usual with Go library updates, the patch is too large > to include here, and simply repeats changes made

Re: [RFC, PATCH] ARM related deprecations

2011-12-09 Thread Rainer Orth
Richard Earnshaw writes: > --- config.gcc(revision 182097) > +++ config.gcc(local) > @@ -242,7 +242,14 @@ md_file= > > # Obsolete configurations. > case ${target} in > + # Avoid special cases that are not obsolete > + arm*-*-linux-gnueabi* \ > + | arm*-*-ecos-elf

Re: [PING][PR testsuite/47013] Fix SMS testsuite faliures

2011-12-09 Thread Ayal Zaks
These fixes to individual sms testcases are OK. Thanks, Ayal. On Mon, Dec 5, 2011 at 3:07 PM, Revital Eres wrote: > Hello, > > Ping:  http://gcc.gnu.org/ml/gcc-patches/2011-11/msg02444.html > > Thanks, > Revital

[RFC, PATCH] ARM related deprecations

2011-12-09 Thread Richard Earnshaw
I think we've reached the point where the following target configurations should be End-of-Life'd. As such, I'd like to mark them as deprecated in gcc-4.7, prior to removal after the branch. I'd also like to remove at that time support for some now obsolete co-processor units, namely the FPA and

[PATCH][Cilkplus] 1D Array Notation Triplet Implementation

2011-12-09 Thread Iyer, Balaji V
Hello Everyone, This patch is for the Cilkplus branch affecting only the C compiler. This patch will implement the 1D array notation triplets. Array notations are indented to allow users directly express high-level parallel vector operations in the code. More information about array notatio

Re: [PATCH] PR c++/51289 - ICE with alias template for bound template

2011-12-09 Thread Jason Merrill
OK. Jason

Re: [PATCH] use -fno-pie on darwin in boehm-gc.exp

2011-12-09 Thread Jack Howarth
On Fri, Dec 09, 2011 at 02:09:54PM +, Iain Sandoe wrote: > > On 8 Dec 2011, at 20:55, Iain Sandoe wrote: >> ... but, I'll bow out at this juncture - > > OK, I lied :-) > > The boehm-gc tests pass for m32 and m64 with "-fpie/-fPIE" on both x86 > Darwin9 (XC3.1.4) and x86_64 Darwin10 (XC3.2.5);

Fix ThreadSanitizer pass required properties (issue5477053)

2011-12-09 Thread Dmitriy Vyukov
This is for google-main branch. Fix ThreadSanitizer pass required properties. Turned out that PROP_gimple_lomp is not always present. Index: gcc/tree-tsan.c === --- gcc/tree-tsan.c (revision 182099) +++ gcc/tree-tsan.c (workin

Re: RFA: Fix PR middle-end/40154

2011-12-09 Thread Joern Rennecke
Quoting Richard Henderson : +GEN_INT + (trunc_int_for_mode While you're at it, or as a followup, this is combination is gen_int_mode. I mis-read the patch the first time and thought

Re: [PATCH] use -fno-pie on darwin in boehm-gc.exp

2011-12-09 Thread Iain Sandoe
On 8 Dec 2011, at 20:55, Iain Sandoe wrote: ... but, I'll bow out at this juncture - OK, I lied :-) The boehm-gc tests pass for m32 and m64 with "-fpie/-fPIE" on both x86 Darwin9 (XC3.1.4) and x86_64 Darwin10 (XC3.2.5); I'm building with XC3.2.6 to check that too. So I think you need to d

Re: [PATCH] Fix PR middle-end/45416, missing opt for (a&(1<

2011-12-09 Thread Georg-Johann Lay
Jakub Jelinek wrote: > On Fri, Dec 09, 2011 at 01:50:37PM +0100, Georg-Johann Lay wrote: >> No, not OK. >> >> This leads to unacceptable code for devices that cannot shift easily like, >> e.g. >> AVR. This target can only shift by 1 and shifts with big offsets have to be >> performed by means of a

Re: [PATCH] Remove dead labels to increase superblock scope

2011-12-09 Thread Eric Botcazou
> 2011-12-07 Tom de Vries > > * cfgcleanup.c (try_optimize_cfg): Replace call to delete_isns_chain by delete_insn_chain > call to delete_insn. Remove code to reorder BASIC_BLOCK note and > DELETED_LABEL note, and move it to ... > * cfg_rtl.c (delete_insn): Change retu

Re: [PATCH] Fix PR middle-end/45416, missing opt for (a&(1<

2011-12-09 Thread Jakub Jelinek
On Fri, Dec 09, 2011 at 01:50:37PM +0100, Georg-Johann Lay wrote: > No, not OK. > > This leads to unacceptable code for devices that cannot shift easily like, > e.g. > AVR. This target can only shift by 1 and shifts with big offsets have to be > performed by means of a loop at runtime. Andrew's

Re: [PATCH] Fix PR middle-end/45416, missing opt for (a&(1<

2011-12-09 Thread Georg-Johann Lay
Andrew Pinski wrote: > Hi, > After SSA-expand, the code which did the optimization for > (a&(1<>C)&1 became not working because BIT_AND_EXPR > would no longer be in there. This patch fixes the problem by using > get_def_for_expr to get the BIT_AND_EXPR. > > OK? Bootstrapped and tested on x86_6

Re: [Ping] RE: CR16 Port addition

2011-12-09 Thread Jayant R. Sonar
PING: For reviewing the modified CR16 port. Hello, Can some one please review the updated patch and let me know if any more changes are required to be done in it? The modified patch was posted at following URL: http://gcc.gnu.org/ml/gcc-patches/2011-11/msg02625.html Thanks and Regards, Jayant

[PATCH] Fix PR46796

2011-12-09 Thread Richard Guenther
This fixes PR46796 by making sure the types in the type variant chain can be looked up again using get_qualified_type. LTO bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2011-12-09 Richard Guenther PR lto/46796 * lto.c (uniquify_nodes): Merge TYPE_DECLs

[PATCH] Fix PR48042

2011-12-09 Thread Richard Guenther
I'm testing the following to avoid ICEing when using LTO and mismatched -g vs. -g0 during compile/link phase by not conditionally clearing things in free_lang_data_in_decl. (Similar code is in free_lang_data_in_type, but without a testcase I don't want to remove it) LTO bootstrap and regtest runn

Re: [RFA/ARM][Patch 02/02]: ARM epilogue in RTL

2011-12-09 Thread Ramana Radhakrishnan
> > Bootstrap and gcc-check are passing without regression. Sorry, it's taken me a while to get to this but I looked at this for sometime last night and think this needs a bit of work . 1. Can the code for TARGET_APCS_FRAME be factored out into a separate function from arm_expand_epilogue ? E

Re: [Patch] Increase array sizes in vect-tests to enable 256-bit vectorization

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 12:44 PM, Michael Zolotukhin wrote: > Hi, Richard, > Accidentally, the first version of the patch (which contained changes > in the original files without duplicating them, and which was approved > by Ira Rosen) has already been checked-in to trunk - could you also > approve

Re: [PATCH] Optimize away unnecessary clobbers (PR tree-optimization/51117)

2011-12-09 Thread Jakub Jelinek
On Fri, Dec 09, 2011 at 10:35:57AM +0100, Richard Guenther wrote: > > *shrug* Maybe just a new pass immediately before ehcleanup2? > > It's just a quick pass over the basic blocks... > > I'd just not care for the ones preceeding a return. Not at this point > at least. After IRC discussion with r

Re: [Patch] Increase array sizes in vect-tests to enable 256-bit vectorization

2011-12-09 Thread Michael Zolotukhin
Hi, Richard, Accidentally, the first version of the patch (which contained changes in the original files without duplicating them, and which was approved by Ira Rosen) has already been checked-in to trunk - could you also approve reverting the original tests back? With this revert I'll also commit

Re: PATCH: PR bootstrap/51479: Missing dependency on errors.o causes bootstrap failure

2011-12-09 Thread Iain Sandoe
On 9 Dec 2011, at 11:27, Joseph S. Myers wrote: On Fri, 9 Dec 2011, Richard Guenther wrote: On Fri, Dec 9, 2011 at 7:17 AM, H.J. Lu wrote: gcc/Makefile.in has gengtype$(exeext) : gengtype.o gengtype-lex.o gengtype-parse.o \ gengtype-state.o version.o errors.o $(LIBDEPS)

[committed] Another 4.6 backport (PR tree-optimization/50078)

2011-12-09 Thread Jakub Jelinek
Hi! Bootstrapped/regtested on x86_64-linux and i686-linux, committed to 4.6 branch. 2011-12-09 Jakub Jelinek Backport from mainline 2011-12-08 Jakub Jelinek PR tree-optimization/51466 * tree-ssa-forwprop.c (forward_propagate_addr_expr_1): Also copy

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 12:00 PM, Kai Tietz wrote: > So this patch replace use of 'long long' in ira-color.c and in > ira-conflict.c by HOST_WIDEST_INT. Ok. Thanks, Richard. > Kai > > ChangeLog > > 2011-12-09  Kai Tietz   > >        * ira-color.c (print_hard_regs_subforest): Use >        HOST_WI

Re: PATCH: PR bootstrap/51479: Missing dependency on errors.o causes bootstrap failure

2011-12-09 Thread Joseph S. Myers
On Fri, 9 Dec 2011, Richard Guenther wrote: > On Fri, Dec 9, 2011 at 7:17 AM, H.J. Lu wrote: > > gcc/Makefile.in has > > > > gengtype$(exeext) : gengtype.o gengtype-lex.o gengtype-parse.o \ > >              gengtype-state.o version.o errors.o $(LIBDEPS) > >        +$(LINKER) $(ALL_LINKERFLAGS) $(

[PATCH] Fix PR51482

2011-12-09 Thread Richard Guenther
This makes sure to not have ENUM/BOOL component type vectors. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-12-09 Richard Guenther PR tree-optimization/51482 * tree-vect-stmts.c (get_vectype_for_scalar_type_and_size): Make sure to only c

Re: [RFA/ARM][Patch 01/02]: Thumb2 epilogue in RTL

2011-12-09 Thread Ramana Radhakrishnan
On Thu, Dec 01, 2011 at 11:49:55AM +, Sameera Deshpande wrote: > > -- > -;; Note: this is not predicable, to avoid issues with linker-generated > -;; interworking stubs. > -(define_insn "*thumb2_return" > +(define_insn "*thumb2_rtl_epilogue_return" Rename to *thumb2_return >[(return)]

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
So this patch replace use of 'long long' in ira-color.c and in ira-conflict.c by HOST_WIDEST_INT. Kai ChangeLog 2011-12-09 Kai Tietz * ira-color.c (print_hard_regs_subforest): Use HOST_WIDEST_INT_PRINT_DEC instead of %lld. (allocno_hard_regs): Change type of cost memb

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 11:32 AM, Kai Tietz wrote: > 2011/12/9 Richard Guenther : >> On Fri, Dec 9, 2011 at 11:10 AM, Kai Tietz wrote: >>> 2011/12/9 Richard Guenther : On Fri, Dec 9, 2011 at 10:58 AM, Kai Tietz wrote: > 2011/12/9 Richard Guenther : >> On Fri, Dec 9, 2011 at 9:51 AM,

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
2011/12/9 Richard Guenther : > On Fri, Dec 9, 2011 at 11:10 AM, Kai Tietz wrote: >> 2011/12/9 Richard Guenther : >>> On Fri, Dec 9, 2011 at 10:58 AM, Kai Tietz wrote: 2011/12/9 Richard Guenther : > On Fri, Dec 9, 2011 at 9:51 AM, Kai Tietz wrote: >> Hi, >> >> this patch fixe

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 11:10 AM, Kai Tietz wrote: > 2011/12/9 Richard Guenther : >> On Fri, Dec 9, 2011 at 10:58 AM, Kai Tietz wrote: >>> 2011/12/9 Richard Guenther : On Fri, Dec 9, 2011 at 9:51 AM, Kai Tietz wrote: > Hi, > > this patch fixes for windows native target print-form

Re: {patch implicit-zee.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 11:05 AM, Kai Tietz wrote: > Fine, here is updated patch for it. Ok. Thanks, Richard. > Index: implicit-zee.c > === > --- implicit-zee.c      (revision 182092) > +++ implicit-zee.c      (working copy) > @@ -8

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
2011/12/9 Richard Guenther : > On Fri, Dec 9, 2011 at 10:58 AM, Kai Tietz wrote: >> 2011/12/9 Richard Guenther : >>> On Fri, Dec 9, 2011 at 9:51 AM, Kai Tietz wrote: Hi, this patch fixes for windows native target print-formatter used about long-long type. ChangeLog >

Re: {patch implicit-zee.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
Fine, here is updated patch for it. Index: implicit-zee.c === --- implicit-zee.c (revision 182092) +++ implicit-zee.c (working copy) @@ -889,8 +889,8 @@ rtx curr_insn = NULL_RTX; int i; int ix; - long long num_real

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 10:58 AM, Kai Tietz wrote: > 2011/12/9 Richard Guenther : >> On Fri, Dec 9, 2011 at 9:51 AM, Kai Tietz wrote: >>> Hi, >>> >>> this patch fixes for windows native target print-formatter used about >>> long-long type. >>> >>> ChangeLog >>> >>> 2011-12-09  Kai Tietz   >>> >>>

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
2011/12/9 Richard Guenther : > On Fri, Dec 9, 2011 at 9:51 AM, Kai Tietz wrote: >> Hi, >> >> this patch fixes for windows native target print-formatter used about >> long-long type. >> >> ChangeLog >> >> 2011-12-09  Kai Tietz   >> >>        * ira-color.c (print_hard_regs_subforest): Use >>        

Re: {patch implicit-zee.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 9:52 AM, Kai Tietz wrote: > Hi, > > this patch fixes for windows native target print-formatter used about > long-long type. > > ChangeLog > > 2011-12-09  Kai Tietz   > >        * implicit-zee.c (find_and_remove_ze): Use >        HOST_WIDEST_INT_PRINT_DEC instead of %lld. > >

Re: {patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 9:51 AM, Kai Tietz wrote: > Hi, > > this patch fixes for windows native target print-formatter used about > long-long type. > > ChangeLog > > 2011-12-09  Kai Tietz   > >        * ira-color.c (print_hard_regs_subforest): Use >        HOST_WIDEST_INT_PRINT_DEC instead of %lld.

Re: [PATCH] Prevent 'control reaches end of non-void function' warning for DO_WHILE

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 9:38 AM, Tom de Vries wrote: > Jakub, > > This patch fixes the problem reported in > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973#c4 . > > The test-case listed there is: > ... > struct Block > { >  public: >    Block(); >    ~Block(); > }; > > bool func( bool bar ) > {

Re: PATCH: PR bootstrap/51479: Missing dependency on errors.o causes bootstrap failure

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 7:17 AM, H.J. Lu wrote: > gcc/Makefile.in has > > gengtype$(exeext) : gengtype.o gengtype-lex.o gengtype-parse.o \ >              gengtype-state.o version.o errors.o $(LIBDEPS) >        +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ \ >            $(filter-out ($LIBDEPS), $^

Re: [PATCH] Optimize away unnecessary clobbers (PR tree-optimization/51117)

2011-12-09 Thread Richard Guenther
On Fri, Dec 9, 2011 at 1:24 AM, Richard Henderson wrote: > On 12/08/2011 04:00 PM, Jakub Jelinek wrote: >> On Thu, Dec 08, 2011 at 03:53:40PM -0800, Richard Henderson wrote: >>> On 12/08/2011 11:57 AM, Jakub Jelinek wrote: +      else if (gimple_code (last) == GIMPLE_RETURN +          ||

Re: [PATCH 1/6] Delete VEC_INTERLEAVE_*_EXPR.

2011-12-09 Thread Richard Guenther
On Thu, Dec 8, 2011 at 10:06 PM, Richard Henderson wrote: > Slightly modified version of a patch Jakub posted earlier. Ok (given the target specific patches are approved). Thanks for this cleanup, Richard. > >        * tree.def (VEC_INTERLEAVE_HIGH_EXPR, VEC_INTERLEAVE_LOW_EXPR): Remove. >    

[PATCH][C++] Fix PR51262

2011-12-09 Thread Richard Guenther
The following fixes PR51262, the new type alias code does else if (CLASS_TYPE_P (t) && !TYPE_DECL_ALIAS_P (TYPE_NAME (t))) which ICEs when t is a type with an anonymous name with -flto because we clear such TYPE_NAMEs during cp_free_lang_data. It turns out that doing so is no longer necessary be

Re: RFA: Avoid unnecessary clearing in union initialisers

2011-12-09 Thread Richard Sandiford
Carrot Wei writes: > Since it also affects 4.6 branch, can this and r176270 also be ported > to gcc4.6? Always worth asking, but in this case, I'm not sure it's appropriate. The patch is pretty invasive, and I don't think the bug is a regression. Also, 4.6 generates really lousy code for these i

{patch implicit-zee.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
Hi, this patch fixes for windows native target print-formatter used about long-long type. ChangeLog 2011-12-09 Kai Tietz * implicit-zee.c (find_and_remove_ze): Use HOST_WIDEST_INT_PRINT_DEC instead of %lld. Tested for i686-w64-mingw32, x86_64-w64-mingw32, and x86_64-unknown-

{patch ira-color.c]: Fix printf-formatter use for long-long type for windows native targets.

2011-12-09 Thread Kai Tietz
Hi, this patch fixes for windows native target print-formatter used about long-long type. ChangeLog 2011-12-09 Kai Tietz * ira-color.c (print_hard_regs_subforest): Use HOST_WIDEST_INT_PRINT_DEC instead of %lld. Tested for i686-w64-mingw32, x86_64-w64-mingw32, and x86_64-unkn

[PATCH] Prevent 'control reaches end of non-void function' warning for DO_WHILE

2011-12-09 Thread Tom de Vries
Jakub, This patch fixes the problem reported in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973#c4 . The test-case listed there is: ... struct Block { public: Block(); ~Block(); }; bool func( bool bar ) { Block block; bool foo = false; if( !foo || bar ) do { return true; }