Re: [Patch, fortran] PR48946 - Deferred Overloaded Assignment

2012-01-04 Thread Thomas Koenig
Hi Paul, Dear All, This is a straightforward patch that adds a last ditch attempt to find a specific typebound procedure when all that has been found for a derived type base object is 'deferred'. typebound_operator_7.f03 has been extended to test derived type as well as class base objects.

Re: [committed] copy-edit -flto documentation

2012-01-04 Thread Eric Botcazou
Done. Great, thanks. -- Eric Botcazou

Re: [Patch, fortran] PR48946 - Deferred Overloaded Assignment

2012-01-04 Thread Paul Richard Thomas
Dear Thomas, Happy New Year! Wouldn't it be better to make a new test case?  If there turns out to be a regression later, changing test cases makes it harder to find. You could just commit the test case 'as is' as typebound_operator_8.f03 and leave the old one. Regards        Thomas

Re: [patch, Fortran] Fix PR 49693, unused variable warnings in common blocks

2012-01-04 Thread Tobias Burnus
Thomas Koenig wrote: the attached patch fixes the PR by unconditionally disabling warnings about unused variables in common blocks. I was wondering whether it disables intended diagnostic. However, I think setting TREE_USED () is OK. Common-related diagnostic is better done by the front end

[google] Dump inline decisions more wisely

2012-01-04 Thread Dehao Chen
Hi, This patch: * dump inline decisions with profile info whenever available. * disable dump of einline decisions at OPT_INFO_MIN. Is it ok for google branches? thanks, Dehao 2012-01-04 Dehao Chen de...@google.com * ipa-inline.c (cgraph_node_opt_info): Print profile info if

Re: [Patch, fortran] PR48946 - Deferred Overloaded Assignment [fwd: tobias.bur...@physik.fu-berlin.de]

2012-01-04 Thread Tobias Burnus
Dear Paul, On Tue, Jan 03, 2012 at 09:30:28PM +0100, Paul Richard Thomas wrote: Bootstrapped and regtested on x86_64/FC9 - OK for trunk? OK. Thanks for the patch. + /* If we find a deferred typebound procedure, check for derived types + that an over-riding typebound procedure has not

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-04 Thread Richard Guenther
On Tue, 3 Jan 2012, Jakub Jelinek wrote: Hi! My previous patch apparently wasn't enough. If at add_mem_* time mem_elt is still its own canonical cselib_val, but only afterwards new_elt_loc_list adds a new canonical cselib_val to it (and moves Hm, shouldn't an existing cselib_val be always

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-04 Thread Jakub Jelinek
On Wed, Jan 04, 2012 at 10:33:50AM +0100, Richard Guenther wrote: My previous patch apparently wasn't enough. If at add_mem_* time mem_elt is still its own canonical cselib_val, but only afterwards new_elt_loc_list adds a new canonical cselib_val to it (and moves Hm, shouldn't an

Re: [SH] PR 31640 - cache block alignment is too aggressive on sh-elf

2012-01-04 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: The attached patch addresses PR 31640. It reduces the the default function alignment when not optimizing for size from cache line size (32 bytes) to 4 bytes and sets the loop alignment to 4 bytes when not optimizing for size. Moreover, it brings back

[Committed] S/390: PR51734 Default to -fPIC for s390 and s390x in picflag.m4

2012-01-04 Thread Andreas Krebbel
Hi, I've applied the attached patch to mainline in order to fix the Ada bootstrap failure reported by Jakub in PR51734 and the libiberty build failure reported here: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00465.html Bye, -Andreas- config/ 2012-01-04 Andreas Krebbel

Re: [patch, Fortran] Fix PR 49693, unused variable warnings in common blocks

2012-01-04 Thread Thomas Koenig
Hi Tobias, Regression-tested. OK for trunk? OK. Thanks for the patch. Committed (rev. 182869). Thanks for the review! (I also updated the copyright years, as requested in private E-Mail.) Thomas

Unreviewed libffi, libgfortran, libitm patches

2012-01-04 Thread Rainer Orth
The following patches have remained unreviewed for two or three weeks: [libffi] Build 64-bit multilib for i?86-linux http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01011.html In the absence of a listed libffi maintainer, it probably needs a global reviewer. [libgfortran,

PR rtl-optimization/49710 (segfault in loop peeling)

2012-01-04 Thread Jan Hubicka
Hi, in the testcase bellow the loop peeling simplifies exit condition in a way that the outer loop is destroyed. After some discussion with Zdenek I learnt that remove_path is then supposed to destroy the outer loop by calling unloop on it, but there is thinko in the function assuming that just

Re: PR rtl-optimization/49710 (segfault in loop peeling)

2012-01-04 Thread Richard Guenther
On Wed, Jan 4, 2012 at 2:01 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, in the testcase bellow the loop peeling simplifies exit condition in a way that the outer loop is destroyed.  After some discussion with Zdenek I learnt that remove_path is then supposed to destroy the outer loop by calling

Re: PR rtl-optimization/49710 (segfault in loop peeling)

2012-01-04 Thread Jan Hubicka
+   l = e-src-loop_father; +   while (l loop_outer (l)) +     { +       while (loop_outer (loop_outer (l)) +             dominated_by_p (CDI_DOMINATORS, +                               loop_outer (l)-latch, e-dest)) +         unloop (loop_outer (l), irred_invalidated); +       l =

Re: PR rtl-optimization/49710 (segfault in loop peeling)

2012-01-04 Thread Richard Guenther
2012/1/4 Jan Hubicka hubi...@ucw.cz: +   l = e-src-loop_father; +   while (l loop_outer (l)) +     { +       while (loop_outer (loop_outer (l)) +             dominated_by_p (CDI_DOMINATORS, +                               loop_outer (l)-latch, e-dest)) +         unloop (loop_outer

[PATCH] Fix PR51750

2012-01-04 Thread Richard Guenther
Another manifestation about the issue we have wrt sizetypes implicitly sign-extending but types-compatible types not. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-01-04 Richard Guenther rguent...@suse.de PR middle-end/51750 * tree.c

Re: PR rtl-optimization/49710 (segfault in loop peeling)

2012-01-04 Thread Zdenek Dvorak
Hi, --- 316,333 normally. We may assume that e-dest is not a header of any loop, as it now has exactly one predecessor. */ while (loop_outer (e-src-loop_father) ! dominated_by_p (CDI_DOMINATORS, !e-src-loop_father-latch,

Re: PR rtl-optimization/49710 (segfault in loop peeling)

2012-01-04 Thread Jan Hubicka
Hi, --- 316,333 normally. We may assume that e-dest is not a header of any loop, as it now has exactly one predecessor. */ while (loop_outer (e-src-loop_father) ! dominated_by_p (CDI_DOMINATORS, !e-src-loop_father-latch,

[C++ Patch] PR 51064

2012-01-04 Thread Paolo Carlini
Hi, we emit spurious -Wparentheses warnings for template arguments, evidently because we are not propagating TREE_NO_WARNING during tsubstitution. I'm fixing the problem in a straightforward way, by using the same idiom already used elsewhere: call build_x_binary_op and then propagate

[PATCH] Add missed adjustment to label_nuses in reload.

2012-01-04 Thread Marcus Shawcroft
Reload (find_reloads) has code that can replace a register with a label_ref when presented with RTL of the form: (set (reg) (reg) (notes (rtx_equal (label_ref))) Label references are initially counted in jump.c:mark_all_labels() and friends. This code traverses the RTL and counts each

Re: [C++ Patch] PR 51064

2012-01-04 Thread Jason Merrill
I'm a bit nervous about the instantiated tree being a different kind of tree from the template one, such that TREE_NO_WARNING doesn't make sense on the new one. Maybe just check EXPR_P (r) as well. Jason

Re: [C++ Patch] PR 51064

2012-01-04 Thread Paolo Carlini
Hi, I'm a bit nervous about the instantiated tree being a different kind of tree from the template one, such that TREE_NO_WARNING doesn't make sense on the new one. Maybe just check EXPR_P (r) as well. I see, better be safe. The below still passes testing. Ok? Thanks, Paolo.

[vms]: factorize vms entries in config.build

2012-01-04 Thread Tristan Gingold
Hi, little clean-up for the VMS entries in config.build. Tested on both ia64-hp-openvms and alpha64-dec-openvms. Committed on trunk. Tristan. 2012-01-04 Tristan Gingold ging...@adacore.com * config/vms/xm-vms.h (HOST_LONG_FORMAT, HOST_PTR_PRINTF): Define when long pointers

Re: [RFC][patch] trans-mem: mark transaction begins as returns-twice

2012-01-04 Thread Patrick Marlier
On 01/02/2012 01:10 PM, Torvald Riegel wrote: This was motivated by the miscompilation of one of the STAMP applications (Genome), where a stack slot was used as temp storage for a CPU register but not restored when the transaction got aborted and restarted (then, after restart, the program

Re: [C++ Patch] PR 51064

2012-01-04 Thread Jason Merrill
OK. Jason

Re: [PATCH] Fix PR tree-optimization/51315

2012-01-04 Thread Eric Botcazou
variant)? TIA. PR tree-optimization/51315 * tree-sra.c (tree_non_aligned_mem_for_access_p): New predicate. (build_accesses_from_assign): Use it instead of tree_non_aligned_mem_p. * gcc.c-torture/execute/20120104-1.c: New test. -- Eric Botcazou struct

Re: [RFC][patch] trans-mem: mark transaction begins as returns-twice

2012-01-04 Thread Aldy Hernandez
On 01/04/12 09:53, Patrick Marlier wrote: On 01/02/2012 01:10 PM, Torvald Riegel wrote: This was motivated by the miscompilation of one of the STAMP applications (Genome), where a stack slot was used as temp storage for a CPU register but not restored when the transaction got aborted and

Re: [PATCH 9/9] [ARM] Remove artificial doloop_end pattern

2012-01-04 Thread Richard Earnshaw
On 21/07/11 17:30, zhr...@ispras.ru wrote: This patch eliminates fake doloop_end pattern for ARM platform. The problem with such a pattern is that it slows down the loop when SMS doesn't create good schedule. So, i suppose fake pattern is no longer needed with new loop forms supported.

[trans-mem] remove xfail for tm alias testcases

2012-01-04 Thread Patrick Marlier
(From a old email in sent after the merge) The output for ealias was changed in revision 158374. * tree-ssa-structalias.c (dump_solution_for_var): Always dump the solution. Example before: pp = same as mystruct after: pp = { ESCAPED NONLOCAL } same as mystruct So the patch

Re: [trans-mem] remove xfail for tm alias testcases

2012-01-04 Thread Aldy Hernandez
On 01/04/12 10:51, Patrick Marlier wrote: (From a old email in sent after the merge) The output for ealias was changed in revision 158374. * tree-ssa-structalias.c (dump_solution_for_var): Always dump the solution. Example before: pp = same as mystruct after: pp = { ESCAPED NONLOCAL } same as

Re: [trans-mem] remove xfail for tm alias testcases

2012-01-04 Thread Patrick Marlier
I have just realized that there are bugreports for them. So here the ChangeLog adjusted. Patrick. On 01/04/2012 11:51 AM, Patrick Marlier wrote: (From a old email in sent after the merge) The output for ealias was changed in revision 158374. * tree-ssa-structalias.c (dump_solution_for_var):

Re: [trans-mem] remove xfail for tm alias testcases

2012-01-04 Thread Aldy Hernandez
On 01/04/12 10:59, Patrick Marlier wrote: I have just realized that there are bugreports for them. So here the ChangeLog adjusted. Adjusted, committed, and closed both PRs. Thanks.

Re: [RFC][patch] trans-mem: mark transaction begins as returns-twice

2012-01-04 Thread Patrick Marlier
On 01/04/2012 11:40 AM, Aldy Hernandez wrote: On 01/04/12 09:53, Patrick Marlier wrote: On 01/02/2012 01:10 PM, Torvald Riegel wrote: This was motivated by the miscompilation of one of the STAMP applications (Genome), where a stack slot was used as temp storage for a CPU register but not

[PATCH] Prevent cselib substitution of FP, SP, SFP

2012-01-04 Thread Marcus Shawcroft
Alias analysis by DSE based on CSELIB expansion assumes that references to the stack frame from different base registers (ie FP, SP) never alias. The comment block in cselib explains that cselib does not allow substitution of FP, SP or SFP specifically in order not to break DSE. However, the

[PATCH] Fix arm var-tracking ICE (PR debug/51746)

2012-01-04 Thread Jakub Jelinek
Hi! In this case the problem is that during cselib_process_insn the cselib hashtab is expanded. Before the htab expansion cselib_lookup on r1 - 1 gave value 18:18 which contains the right value, but doesn't have the hash value for r1 - 1 (8169), thus is found only by accident. Unfortunately

[PATCH] Don't ICE on = 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Jakub Jelinek
Hi! .debug_loc section format only uses 2 byte long size field for expressions, therefore we can't emit = 64KB expressions. Unfortunately from time to time we do generate them, I hope Alex will look at how to prevent that from happening at var-tracking time, but still this isn't something we

PR middle-end/51472: handle TM memmove with non-addressable destinations

2012-01-04 Thread Aldy Hernandez
I fixed this PR, and then it got reopened because the testcase triggered a different problem on Alpha, Mips, and other architectures. The problem is actually totally different than the previous fix for 51472, and has nothing to do with --param tm-max-aggregate-size. This problem here is that

Re: [PATCH] Don't ICE on = 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Jason Merrill
OK. Jason

Re: [Patch, fortran] PR fortran/50981 segmentation fault when trying to access absent elemental actual arg

2012-01-04 Thread Mikael Morin
On Monday 02 January 2012 12:20:36 Tobias Burnus wrote: Hello Mikael, Mikael Morin wrote: Regression tested on x86_64-unknown-linux-gnu. OK for 4.7/4.6/4.5[/4.4] ? OK - thanks for the comprehensive patch explanation and for the patch itself. + else + { + /*

Re: [PATCH] Add Octeon2 indexed load instruction support (and also DSP64 LDX support)

2012-01-04 Thread Andrew Pinski
On Sat, Dec 17, 2011 at 3:11 AM, Richard Sandiford rdsandif...@googlemail.com wrote: Andrew Pinski andrew.pin...@caviumnetworks.com writes: Index: testsuite/gcc.target/mips/octeon2-lx-1.c === ---

Re: [RFC][patch] trans-mem: mark transaction begins as returns-twice

2012-01-04 Thread Torvald Riegel
On Wed, 2012-01-04 at 12:13 -0500, Patrick Marlier wrote: On 01/04/2012 11:40 AM, Aldy Hernandez wrote: On 01/04/12 09:53, Patrick Marlier wrote: On 01/02/2012 01:10 PM, Torvald Riegel wrote: This was motivated by the miscompilation of one of the STAMP applications (Genome), where a stack

Re: [RFC][patch] trans-mem: mark transaction begins as returns-twice

2012-01-04 Thread Torvald Riegel
On Wed, 2012-01-04 at 10:53 -0500, Patrick Marlier wrote: On 01/02/2012 01:10 PM, Torvald Riegel wrote: This was motivated by the miscompilation of one of the STAMP applications (Genome), where a stack slot was used as temp storage for a CPU register but not restored when the transaction

Re: PR middle-end/51472: handle TM memmove with non-addressable destinations

2012-01-04 Thread Patrick Marlier
On 01/04/2012 01:20 PM, Aldy Hernandez wrote: The attached patch fixes the ICE on alpha-linux-gnu as tested with a cross-cc1 build. Note that it was also failing with i686/linux and the patch fixes the ICE. Patrick.

Re: [PATCH] Don't ICE on = 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Tom Tromey
Jakub == Jakub Jelinek ja...@redhat.com writes: Jakub another alternative would be to create DW_TAG_dwarf_procedure for Jakub them or for portions thereof (for subexpressions it would be even Jakub a potential nice debug info shrinking method, but would mean a Jakub lot of work and gdb support

Re: [PATCH] Don't ICE on = 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Jakub Jelinek
On Wed, Jan 04, 2012 at 12:11:29PM -0700, Tom Tromey wrote: Jakub == Jakub Jelinek ja...@redhat.com writes: Jakub another alternative would be to create DW_TAG_dwarf_procedure for Jakub them or for portions thereof (for subexpressions it would be even Jakub a potential nice debug info

Re: [PATCH] Don't ICE on = 64KB expressions in dwarf2out (PR debug/51695)

2012-01-04 Thread Tom Tromey
Jakub == Jakub Jelinek ja...@redhat.com writes: Jakub Honza said that GDB doesn't support DW_TAG_dwarf_procedure though. Jakub We'd need to represent it as nameless artificial DW_TAG_variable Jakub or something similar. I think gdb will issue a complaint if it sees one. I'm not sure, I don't

[Google/main Patch] Cleanup pubnames/pubtypes and test-suite (issue5514045)

2012-01-04 Thread Sterling Augustine
The enclosed patch to google/main contains certain small fixes for pubnames and pubtypes, which are now emitted completely and canonically. It also fixes the expected output of various tests to match the canonical names of functions. OK for google/main? Tested: With full make-check and

Re: [PATCH] [MIPS] Add Octeon2 cpu support to GCC

2012-01-04 Thread Andrew Pinski
On Fri, Dec 16, 2011 at 2:22 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Mon, 12 Dec 2011, Andrew Pinski wrote: * config/mips/mips-cpus.def: Add Octeon2. You need to update the documentation for MIPS -march= in invoke.texi, which lists the supported CPUs. Woops, I had missed that.

Re: [Google/main Patch] Cleanup pubnames/pubtypes and test-suite (issue5514045)

2012-01-04 Thread Cary Coutant
LGTM for google/main. Before submitting for trunk, we'll want to take care of this FIXME: +      /* FIXME: Should use add_AT_pubnamesptr.  This works because most targets +         don't care what the base section is.  */ -cary

Re: [Patch,AVR]: Cleanup avr_replace_prefix

2012-01-04 Thread Denis Chertykov
2012/1/4 Georg-Johann Lay a...@gjlay.de: This removes avr_replace_prefix and rewrites the callers to use ACONCAT. Passes without regressions. Ok for trunk? Johann        * config/avr/avr.c (avr_replace_prefix): Remove.        (avr_asm_named_section): Use ACONCAT instead of

Re: PR middle-end/51472: handle TM memmove with non-addressable destinations

2012-01-04 Thread Richard Henderson
On 01/05/2012 05:20 AM, Aldy Hernandez wrote: PR middle-end/51472 * trans-mem.c (expand_assign_tm): Handle TM_MEMMOVE loads correctly. testsuite/ PR middle-end/51472 * gcc.dg/tm/memopt-6.c: Adjust regexp. Ok. r~

Re: [PATCH] Fix PR tree-optimization/51315

2012-01-04 Thread Richard Sandiford
Eric Botcazou ebotca...@adacore.com writes: Regtested on SPARC/Solaris. Can you confirm that this fixes the pessimization in all cases (and run the C testsuite for your favorite ABI variant)? TIA. It does, and there were no regression on a C-only build test for mips64-linux-gnu

Re: [PATCH] Fix arm var-tracking ICE (PR debug/51746)

2012-01-04 Thread Richard Henderson
On 01/05/2012 04:45 AM, Jakub Jelinek wrote: PR debug/51746 * var-tracking.c (add_stores): For COND_EXEC allow oval to be NULL. Ok. r~

Re: PR middle-end/51472: handle TM memmove with non-addressable destinations

2012-01-04 Thread Patrick Marlier
On 01/04/2012 01:20 PM, Aldy Hernandez wrote: I fixed this PR, and then it got reopened because the testcase triggered a different problem on Alpha, Mips, and other architectures. The problem is actually totally different than the previous fix for 51472, and has nothing to do with --param

[PATCH] Fix fake edge handling in branch_prob (PR middle-end/44777)

2012-01-04 Thread Jakub Jelinek
Hi! This testcase fails with corrupted profile info error. The problem is that we have a basic block which starts with a computed goto target label (thus has an EDGE_ABNORMAL predecessor and wants an EDGE_FAKE predecessor from entry) and ends with a non-const/pure call (which incidentally doesn't

[PATCH] Fix profiledbootstrap with -fexceptions (PR bootstrap/51648)

2012-01-04 Thread Jakub Jelinek
Hi! profiledbootstrap with --disable-poststage-build-with-cxx and -fexceptions currently fails on x86_64-linux. The problem is that no EDGE_FAKE edge is added from noreturn fatal_error call to the exit block, eventhough fatal_error calls exit. The problem is that we have several places which add

[libitm] fix reentrant.c testcase

2012-01-04 Thread Patrick Marlier
In the reentrant.c testcase, the first transaction has no transactional access and thus removed. In order to keep this transaction, I added a shared access inside. Tested on i686. OK to commit? (I don't have an account, so thanks in advance to committer) -- Patrick Marlier. 2012-01-04 Patrick

Fix bootstrap/51072 -- libitm not disabled without c++

2012-01-04 Thread Richard Henderson
Second try. Unlike adjusting the gcc/cp fragment, I can't imagine this has any other side effects. Tested on x86_64-linux. Committed. r~ diff --git a/ChangeLog b/ChangeLog index b9d08f3..a8019b3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2012-01-05 Richard Henderson

Re: Fix bootstrap/51072 -- libitm not disabled without c++

2012-01-04 Thread Jakub Jelinek
On Thu, Jan 05, 2012 at 12:38:17PM +1100, Richard Henderson wrote: +# Disable libitm if we're not building C++ +case ,${enable_languages}, in + *,c++) ;; Shouldn't that be *,c++,* ? C++ might not be the last in the list... Jakub

[trans-mem] fix problem with TM clone aliases

2012-01-04 Thread Patrick Marlier
Hi, (Initially from http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00225.html) PR51516 shows up a problem due to the TM IPA rework. Indeed, an alias can get called but tm cg data is in the parent of the alias. The fix consists to set and use information from the parent and not the alias itself.

Re: Fix bootstrap/51072 -- libitm not disabled without c++

2012-01-04 Thread Richard Henderson
On 01/05/2012 12:53 PM, Jakub Jelinek wrote: On Thu, Jan 05, 2012 at 12:38:17PM +1100, Richard Henderson wrote: +# Disable libitm if we're not building C++ +case ,${enable_languages}, in + *,c++) ;; Shouldn't that be *,c++,* ? C++ might not be the last in the list... Gah, of course it

Re: Unreviewed libffi, libgfortran, libitm patches

2012-01-04 Thread Richard Henderson
On 01/04/2012 11:27 PM, Rainer Orth wrote: [libgfortran, libitm] Link with -shared-libgcc http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html This will need a fortran resp. libitm maintainer. Does the following alleviate the need for -shared-libgcc for libitm? r~ diff --git