Re: [patch c++]: Fix for PR c++/51344 - cc1plus hangs when compiling

2012-01-18 Thread Kai Tietz
2012/1/17 Jason Merrill : > On 01/17/2012 02:41 PM, Kai Tietz wrote: >> >> Right, but in second call we get for cplus_decl_attributes's >> late_attrs (as result of splice_template_attributes) the same value as >> already stored in decl_p's attributes. > > > Right, but why is it already stored there

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-18 Thread Richard Guenther
On Tue, 17 Jan 2012, Aldy Hernandez wrote: > > > > What I have in mind is to abstract out the initialization of TM builtins > > > from > > > gtm-builtins.def (through its inclusion in builtins.def) into a separate > > > function that we can call either in c_define_builtins() from the C-ish > > >

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-18 Thread Tobias Burnus
Dear Janne, > the attached patch changes the binding labels that are needed for > bind(C) symbols to be heap allocated rather than, as currently, being > fixed size arrays of size 127 (or 64 in module.c!?). wonder whether it would have been smarter to use string matching rather than the manual m

Re: PR other/51165: add new adress_escapes predicate

2012-01-18 Thread Richard Guenther
On Tue, Jan 17, 2012 at 5:41 PM, Patrick Marlier wrote: > On 01/17/2012 08:20 AM, Aldy Hernandez wrote: >> >> On 01/17/12 03:09, Richard Guenther wrote: >>> >>> On Mon, Jan 16, 2012 at 4:58 PM, Aldy Hernandez wrote: > Not really - you handle both ptr and *ptr in the same predicate an

Re: [PATCH] Improve SCEV for array element

2012-01-18 Thread Richard Guenther
On Wed, Jan 18, 2012 at 8:41 AM, Jiangning Liu wrote: > This code change intends to improve scev for array element and reduce the > common sub-expressions in loop, which may be introduced by multiple > reference of expression like &a[i]. With this optimization the register > pressure can be reduce

Re: libgo patch committed: Update to weekly.2011-12-22

2012-01-18 Thread Rainer Orth
Ian Lance Taylor writes: >> The patch introduced a couple of other problems: >> >> * There's a warning during libgo configure: >> >> * Bootstrap on Solaris < 11 is broken: >> >> * The IRIX libgo build is broken like this: > > Thanks a lot. All committed. I hadn't bootstrapped with the fixes bef

Re: [patch c++]: Fix for PR c++/51344 - cc1plus hangs when compiling

2012-01-18 Thread Kai Tietz
I noticed that the previous patch still had issues about more then one attribute added. The underlying issue seems here that we shouldn't chain attributes simply, but we should merge them. I did full bootstrap for it and ran regression tests for x86_64-unknown-linux-gnu. Ok for apply? Regards, Ka

Bug store_bit_field_1 + patch

2012-01-18 Thread Aurelien Buhrig
Hi, I've found a bug in store_bit_field_1 for BIG_ENDIAN targets whose words are HI. The testcase is execute.exp=bitfld-3.c for my target (which is not public). It occurs on 4.6.1 release, but seem to be present in trunk (looking at the code, not executed). The problem occurs when value is a REG

Re: Fix checks for !TARGET_MACHO

2012-01-18 Thread Gerald Pfeifer
On Tue, 17 Jan 2012, Tijl Coosemans wrote: > TARGET_MACHO is always defined (either 0 or 1) so using #ifndef to test > for !TARGET_MACHO is incorrect. Introduced here: > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00623.html > > The i386 case has been tested on i386-freebsd. The compiler now emit

Re: [Patch, fortran] PR 51808 Heap allocate binding labels

2012-01-18 Thread Mikael Morin
On 18.01.2012 10:12, Tobias Burnus wrote: Dear Janne, the attached patch changes the binding labels that are needed for bind(C) symbols to be heap allocated rather than, as currently, being fixed size arrays of size 127 (or 64 in module.c!?). wonder whether it would have been smarter to us

Re: Fix checks for !TARGET_MACHO

2012-01-18 Thread Iain Sandoe
On 18 Jan 2012, at 12:26, Gerald Pfeifer wrote: On Tue, 17 Jan 2012, Tijl Coosemans wrote: TARGET_MACHO is always defined (either 0 or 1) so using #ifndef to test for !TARGET_MACHO is incorrect. Introduced here: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00623.html The i386 case has been

Re: Fix checks for !TARGET_MACHO

2012-01-18 Thread Jakub Jelinek
On Wed, Jan 18, 2012 at 01:26:29PM +0100, Gerald Pfeifer wrote: > On Tue, 17 Jan 2012, Tijl Coosemans wrote: > > TARGET_MACHO is always defined (either 0 or 1) so using #ifndef to test > > for !TARGET_MACHO is incorrect. Introduced here: > > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00623.html >

[PATCH] Fix different-pointer-size issue

2012-01-18 Thread Richard Guenther
This left-over reportedly breaks casts between different pointer sizes. Removed thus, it has become obsolete. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-01-18 Richard Guenther * tree-ssa.c (useless_type_conversion_p): Remove special-casing of

Re: C++ PATCH for c++/51827 (mangling error with PCH and LTO)

2012-01-18 Thread Richard Guenther
On Tue, Jan 17, 2012 at 5:22 PM, Jason Merrill wrote: > On 01/17/2012 09:51 AM, Richard Guenther wrote: >> >> Sure it works.  PCH is just a stage where LTO is not active yet. > > > That makes sense to me. Applied then. Richard. > Jason >

Re: PR other/51165: add new adress_escapes predicate

2012-01-18 Thread Aldy Hernandez
So you can do probably the following: Index: trans-mem.c === --- trans-mem.c (revision 183253) +++ trans-mem.c (working copy) @@ -1497,8 +1497,6 @@ requires_barrier (basic_block entry_block, tree x, to needs_to_live_in

Re: PR other/51165: add new adress_escapes predicate

2012-01-18 Thread Richard Guenther
On Wed, Jan 18, 2012 at 3:00 PM, Aldy Hernandez wrote: > >>> So you can do probably the following: >>> >>> Index: trans-mem.c >>> === >>> --- trans-mem.c (revision 183253) >>> +++ trans-mem.c (working copy) >>> @@ -1497,8 +1497,6 @@ r

Re: Go patch committed: Recognize more test lines

2012-01-18 Thread Ian Lance Taylor
Uros Bizjak writes: >> This patch to the Go testsuite driver recognizes a few more test lines >> in Go tests. I somehow failed to notice these the last time I updated >> the Go testsuite. This patch includes a couple of changes to make the >> newly recognized tests pass. Ran Go testsuite on >>

[PATCH] Fix PR49484, gthr requirements update (target maintainers have a looksee)

2012-01-18 Thread Richard Guenther
This fixes PR49484 by protecting __gcov_flush against concurrent execution. To be able to use the gthread facility I have to introduce the requirement that __GTHREAD_MUTEX_INIT_FUNCTION is always available, even if __GTHREAD_MUTEX_INIT is available as otherwise no dynamic initialization of a mute

Re: Cross-build breakage with libstdc++-v3 doc changes

2012-01-18 Thread Ulrich Weigand
Hans-Peter Nilsson wrote: > > From: Benjamin Kosnik > > Date: Wed, 18 Jan 2012 00:41:59 +0100 > > > This updates the support for generating epub docs to EPUB3. Using the > > EPUB3 stylesheets allows the removal of ruby and other tool checks from > > configure, and generates a much better documen

Re: [build] Disable dl_iterate_phdr on Solaris 10

2012-01-18 Thread Paolo Bonzini
On 01/17/2012 10:43 AM, Rainer Orth wrote: Rainer Orth writes: 2012-01-15 Rainer Orth * configure.ac (gcc_cv_target_dl_iterate_phdr): Only check on Solaris 11+. * configure: Regenerate. It helps to actually attach the patch. Ok. Paolo

[Patch ARM] Fix PR50313 and handle PIC addresses properly.

2012-01-18 Thread Ramana Radhakrishnan
Hi , PR50313 is a case where having the 2 patterns "pic_load_addr_*" and "pic_add_dot_plus_eight/four" from expand time becomes a problem as discussed by Jakub in his comment in the audit trail for PR48308. There is a separate problem in combine as explained by my comment in the audit trail for PR

Re: [Patch ARM] Fix PR50313 and handle PIC addresses properly.

2012-01-18 Thread Jakub Jelinek
On Wed, Jan 18, 2012 at 03:03:47PM +, Ramana Radhakrishnan wrote: > +;; operand1 is the memory address to go into pic_load_addr_32bit. > +;; operand2 is the PIC label to be emitted from pic_add_dot_plus_*. > +;; We do this to allow hoisting of the entire c > +(define_insn_and_split "pic_load_ad

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

2012-01-18 Thread Dominique Dhumieres
> * g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable. It fails on powerpc-apple-darwin9 with FAIL: g++.dg/cpp0x/constexpr-rom.C (test for excess errors) Excess errors: g++: error: unrecognized option '-G' TIA Dominique

Re: [C++ Patch] PR 51225

2012-01-18 Thread Paolo Carlini
Hi, So, the issue here is that fold_non_dependent_expr_sfinae checks potential_constant_expression, and doesn't fold anything which isn't one. One approach would be to only guard cxx_constant_value with require_potential_constant_expression within a template. Thanks. Thus I tried to implement

Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins

2012-01-18 Thread Aldy Hernandez
On 01/18/12 03:09, Richard Guenther wrote: On Tue, 17 Jan 2012, Aldy Hernandez wrote: What I have in mind is to abstract out the initialization of TM builtins from gtm-builtins.def (through its inclusion in builtins.def) into a separate function that we can call either in c_define_builtins()

Re: [PATCH] Fix g++.dg/cpp0x/constexpr-rom.C failure

2012-01-18 Thread Andreas Schwab
domi...@lps.ens.fr (Dominique Dhumieres) writes: >> * g++.dg/cpp0x/constexpr-rom.C: Add -G0 where applicable. > > It fails on powerpc-apple-darwin9 with > > FAIL: g++.dg/cpp0x/constexpr-rom.C (test for excess errors) > Excess errors: > g++: error: unrecognized option '-G' That is strange, g.opt i

[PATCH] Fix PR 51505

2012-01-18 Thread Andrey Belevantsev
Hello, As discussed in Bugzilla, this is the patch implementing Paolo's suggestion of killing REG_EQUAL/REG_EQUIV notes from df_kill_notes. The code assumes there is at most one such note per insn. Bootstrapped and tested on x86-64, ok for trunk? Andrey gcc: 2012-01-18 Andrey Belevantsev

Re: [Patch ARM] Fix PR50313 and handle PIC addresses properly.

2012-01-18 Thread Ramana Radhakrishnan
On 18 January 2012 15:26, Jakub Jelinek wrote: > On Wed, Jan 18, 2012 at 03:03:47PM +, Ramana Radhakrishnan wrote: >> +;; operand1 is the memory address to go into pic_load_addr_32bit. >> +;; operand2 is the PIC label to be emitted from pic_add_dot_plus_*. >> +;; We do this to allow hoisting o

Re: libgo patch committed: Update to weekly.2011-12-22

2012-01-18 Thread Rainer Orth
Ian Lance Taylor writes: >> This also broke bootstrap on x86_64-unknown-linux-gnu (CentOS 5.5): >> >> /vol/gcc/src/hg/trunk/local/libgo/go/net/fd_linux.go:40:46: error: reference >> to undefined identifier 'syscall.EPOLL_CLOEXEC' > > Thanks. Fixed like so. Bootstrapped on x86_64-unknown-linux-

Re: Go patch committed: Multiplex goroutines onto OS threads

2012-01-18 Thread Ian Lance Taylor
Rainer Orth writes: > All tests hang with the default -test.timeout=240. Thanks for providing access to a Solaris system. Right now it looks like there is a bug, or at least an incompatibility, in the 64-bit versions of getcontext and setcontext. It looks like calling setcontext on the 32-bi

Re: [PATCH] Fix PR 51505

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 05:41 PM, Andrey Belevantsev wrote: Hello, As discussed in Bugzilla, this is the patch implementing Paolo's suggestion of killing REG_EQUAL/REG_EQUIV notes from df_kill_notes. The code assumes there is at most one such note per insn. Bootstrapped and tested on x86-64, ok for trunk?

[wwwdocs] List new Fortran options under Fortran section

2012-01-18 Thread Steve Kargl
The attached patch documents the new Fortran options -freal-N-real-M and -finteger-4-integer-8. These options are used for promoting all entities of the first type to entities of the second type. OK to commit? PS: Is there a ChangeLog file for the wwwdoc repository? -- Steve Index: changes.ht

Re: Go patch committed: Multiplex goroutines onto OS threads

2012-01-18 Thread Rainer Orth
Ian Lance Taylor writes: > Rainer Orth writes: > >> All tests hang with the default -test.timeout=240. > > Thanks for providing access to a Solaris system. > > Right now it looks like there is a bug, or at least an incompatibility, > in the 64-bit versions of getcontext and setcontext. It loo

Re: [C++ Patch] PR 51225

2012-01-18 Thread Jason Merrill
OK. Jason

[PATCH, 4.6, committed] Fix typo in rs6000.md call pattern for AIX

2012-01-18 Thread David Edelsohn
A backport of another patch introduced a cut-and-paste typo in one of the AIX call patterns, generating a DImode memory operand in 32 bit mode. Fixed with the following patch. - David * config/rs6000/rs6000.md (call_value_indirect_aix32): Fix typo in mode of operand[4]. Index: r

[PATCH, trans-mem]: Fix PR51830, FAIL: libitm.c/mem(cpy|set)-1.c execution test on x86_32

2012-01-18 Thread Uros Bizjak
Hello! Attached three-liner patch fixes the declaration of BUILT_IN_TM_START (AKA _ITM_beginTransaction) to match its declaration from the libitm.h ABI. This mismatch was the core problem for FAILed libitm.c/mem(cpy|set)-1.c execution tests on x86_32. Following that change, we need to teach _ITM_

Re: [PATCH, trans-mem]: Fix PR51830, FAIL: libitm.c/mem(cpy|set)-1.c execution test on x86_32

2012-01-18 Thread Patrick Marlier
On 01/18/2012 02:26 PM, Uros Bizjak wrote: Hello! Attached three-liner patch fixes the declaration of BUILT_IN_TM_START (AKA _ITM_beginTransaction) to match its declaration from the libitm.h ABI. This mismatch was the core problem for FAILed libitm.c/mem(cpy|set)-1.c execution tests on x86_32.

Re: [patch c++]: Fix for PR c++/51344 - cc1plus hangs when compiling

2012-01-18 Thread Jason Merrill
I still think the problem is that we're applying the attributes more than once, and we should only apply them once. If we fix that, we don't need to merge them. Jason

Re: libstdc++/51866 too, sorry

2012-01-18 Thread François Dumont
Attached patch applied. 2012-01-18 François Dumont Roman Kononov PR libstdc++/51866 * include/bits/hashtable.h (_Hashtable<>::_M_insert(_Arg, false_type)): Do not keep a reference to a potentially moved instance. * testsuite/23_containers/unordere

Re: libstdc++/51866 too, sorry

2012-01-18 Thread Paolo Carlini
On 01/18/2012 09:27 PM, François Dumont wrote: Attached patch applied. Thanks. Apparently 51845 is an unrelated issue, Jakub has an analysis and a candidate fix. Can you please look into that? Thanks again, Paolo.

Re: [PATCH, trans-mem]: Fix PR51830, FAIL: libitm.c/mem(cpy|set)-1.c execution test on x86_32

2012-01-18 Thread Uros Bizjak
On Wed, Jan 18, 2012 at 8:44 PM, Patrick Marlier wrote: >> There was some discussion on where to pass arguments to regparm >> decorated vararg functions. Well, as the ABI is pretty clear - regparm >> should be ignored in this case, so all function arguments have to be >> passed in memory, even if

Re: [Patch, fortran] PR51634 - [OOP] ICE with polymorphic operators

2012-01-18 Thread Paul Richard Thomas
Dear Tobias, Committed as r183287. Thanks for the review. Paul >> 2012-01-17  Paul Thomas >> >>        PR fortran/51634 >>        * trans-expr.c (gfc_conv_procedure_call): Deallocate allocatable >>        components of temporary class arguments. >> >> 2012-01-17  Paul Thomas >> >>        PR for

Re: [PATCH, trans-mem]: Fix PR51830, FAIL: libitm.c/mem(cpy|set)-1.c execution test on x86_32

2012-01-18 Thread Patrick Marlier
On 01/18/2012 03:35 PM, Uros Bizjak wrote: Please note that all recent x86 processors implement store forwarding, so passing arguments through memory is mostly a non-issue nowadays. Ok. Thanks :) IMO, whatever the future decision would be, we shouldn't leave one part of the compiler out-of-sy

Re: Cross-build breakage with libstdc++-v3 doc changes

2012-01-18 Thread Benjamin Kosnik
> > ...or for cross-targets, breakage. Something went wrong with > > this or subsequent changes; somewhere in the r183262:183268 I've > > started getting: > [snip] > > checking > > for /usr/share/xml/docbook/stylesheet/docbook-xsl-ns/epub3/chunk.xsl... > > configure: error: cannot check for file

Re: [PATCH, trans-mem]: Fix PR51830, FAIL: libitm.c/mem(cpy|set)-1.c execution test on x86_32

2012-01-18 Thread Uros Bizjak
On Wed, Jan 18, 2012 at 10:16 PM, Patrick Marlier wrote: >> IMO, whatever the future decision would be, we shouldn't leave one >> part of the compiler out-of-sync from the other. Proposed patch fixes >> _current_ situation, where in the future, it is expected that compiler >> and library changes

Re: [wwwdocs] List new Fortran options under Fortran section

2012-01-18 Thread Tobias Burnus
Steve Kargl wrote: The attached patch documents the new Fortran options -freal-N-real-M and -finteger-4-integer-8. These options are used for promoting all entities of the first type to entities of the second type. OK to commit? Looks OK to me. Though, I had made the N and M italic at: +-fre

[pph] Refuse to generate PPH with #include_next (issue5558045)

2012-01-18 Thread Diego Novillo
This patch adds a check for #include_next and refuses to generate a PPH image for files that use it. Since the discovery of #include_next comes well into the pre-processing stage (after we've initialized PPH data), we need to undo what we did and disable PPH. To do that, there is a new function p

[PATCH] Fix _Hashtable::erase(iterator, iterator) (PR libstdc++/51845)

2012-01-18 Thread Jakub Jelinek
Hi! As described in the PR, if two argument erase is removing the last element of one bucket (i.e. the one referenced in _M_buckets array for the next bucket) and then at least one element from the following bucket, but not all elements from that next bucket, __is_bucket_begin is initially false a

[PATCH] Fix up --enable-initfini-array autodetection in configure (PR bootstrap/50237)

2012-01-18 Thread Jakub Jelinek
Hi! As discussed in the PR, compiling the initfini testcase with the host compiler and running it is problematic for bootstrap, as in stage1 we use the host compiler which might use one version of as/ld, but stage2 is using stage1 compiler as host compiler and might use a different as/ld. If one

[PATCH ARM] Fix PR51835, ARM EABI violation

2012-01-18 Thread Bin Cheng
Hi, Currently gcc generates code violating ARM EABI when passing arguments to some floating point helper functions, which are __aeabi_d2iz/__aeabi_d2uiz. As reported in bug PR51835. This patch fixes the issue, with test cases. It is for trunk and 4.6 branch, and I have checked the output codes ma

Re: [PATCH] Fix PR 51505

2012-01-18 Thread Andrey Belevantsev
On 18.01.2012 21:28, Paolo Bonzini wrote: On 01/18/2012 05:41 PM, Andrey Belevantsev wrote: Ok, thanks for working on this. Installed, do you want this for 4.6/4.5? Andrey

Re: [PATCH] Fix PR 51505

2012-01-18 Thread Jakub Jelinek
On Thu, Jan 19, 2012 at 11:32:41AM +0400, Andrey Belevantsev wrote: > On 18.01.2012 21:28, Paolo Bonzini wrote: > >On 01/18/2012 05:41 PM, Andrey Belevantsev wrote: > >Ok, thanks for working on this. > Installed, do you want this for 4.6/4.5? If yes, please give it at least a couple of weeks on th