Re: [PATCH] x86: use 'rep bsf' syntax when assembler supports it

2012-07-03 Thread Uros Bizjak
On Mon, Jul 2, 2012 at 8:39 PM, Roland McGrath wrote: > On Sun, Jul 1, 2012 at 1:08 AM, Uros Bizjak wrote: >> Based on the observation above, the patch is OK for mainline, but >> please also handle "rep nop" case. > > Here's the new version of the patch that does that. Note that someone > needs

Re: [PATCH, i386]: Use __builtin_ia32_pause some more

2012-07-03 Thread Uros Bizjak
On Sun, Jul 1, 2012 at 3:10 PM, Uros Bizjak wrote: > gcc/ > > 2012-07-01 Uros Bizjak > > * config/i386/xmmintrin.h (_mm_sfence): Use __builtin_ia32_pause. > > libgomp/ > > 2012-07-01 Uros Bizjak > > * config/linux/x86/futex.h (cpu_relax): Use __builtin_ia32_pause. >

[SH] Improve extu.b, extu.w utilization for andsi3

2012-07-03 Thread Oleg Endo
Hello, On SH a logical and with constants 0x or 0xFF can be done with the respective zero-extension operations. The attached patch improves the utilization of the zero-extension operations a little bit, resulting in slightly better code. Tested against rev 189081 with make -k check RUNTESTFL

[Ada] Adjust to change in handling of local types with -g

2012-07-03 Thread Eric Botcazou
The fix for PR c++/52637 slightly broke the handling of local types in Ada. The attached patch restores correct generation of debug info for them. Tested on i586-suse-linux, applied on mainline and 4.7 branch. 2012-07-03 Eric Botcazou * gcc-interface/utils.c (gnat_pushdecl): Set TYPE

[C++ PATCH] Fix ICE with computed goto (PR c++/53812)

2012-07-03 Thread Jakub Jelinek
Hi! We ICE on this testcase since forever, because the computed goto's operand needs cleanups and doesn't have corresponding CLEANUP_POINT_EXPR emitted anywhere. Given that the operand is void * and only valid values for it are && LABEL_DECLs, I think it is ok to perform the cleanups before the a

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Richard Guenther
On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > On 6/27/2012 8:06 AM, Richard Guenther wrote: > > This merges from the graphite branch the move of PPL to ISL, > > and completes it where it was lacking - thanks to Micha. > > It leaves unmerged the addition of a pluto-like ISL optimizer > > as well as

RE: [PATCH] Disable loop2_invariant for -Os

2012-07-03 Thread Zhenqiang Chen
>-Original Message- >From: Richard Guenther [mailto:richard.guent...@gmail.com] >Sent: 2012年6月28日 17:24 >To: Zhenqiang Chen >Cc: gcc-patches@gcc.gnu.org >Subject: Re: [PATCH] Disable loop2_invariant for -Os > >On Thu, Jun 28, 2012 at 10:33 AM, Zhenqiang Chen >wrote: diff --git a/gcc/l

Re: [build] Fix ISL check with static libisl

2012-07-03 Thread Richard Guenther
On Mon, 2 Jul 2012, Rainer Orth wrote: > After the move to CLooG 0.17.0/ISL 0.10, mainline fails to configure > with a static libisl: > > configure:5697: checking for version 0.10 of ISL > configure:5722: gcc -o conftest -g -O2 -I/vol/gcc/include -I/vol/gcc/include > -I/ > vol/gcc/include -I/vol

Re: [Ada] Use C++-compatible calling convention on x86/Windows

2012-07-03 Thread Eric Botcazou
> Now reverted, including on the 4.7 branch (this is only for x86/Windows). > We have decided to use another approach to deal with the problem as the > above one introduces backwards compatibily issues. This is the new approach, which doesn't require modifications to the source code and essentia

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Richard Guenther
On Tue, 3 Jul 2012, Richard Guenther wrote: > On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > > > On 6/27/2012 8:06 AM, Richard Guenther wrote: > > > This merges from the graphite branch the move of PPL to ISL, > > > and completes it where it was lacking - thanks to Micha. > > > It leaves unmerged t

[Ada] Fix ICE on renaming with discriminated tagged type

2012-07-03 Thread Eric Botcazou
This is a regression present on the mainline and 4.7 branch. The compiler aborts on the renaming of an object with a derived discriminated tagged type converted to the parent type, if the parent type is itself derived from a root discriminated tagged type and the renaming is later used as a pre

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Richard Guenther
On Tue, 3 Jul 2012, Richard Guenther wrote: > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > > > > > On 6/27/2012 8:06 AM, Richard Guenther wrote: > > > > This merges from the graphite branch the move of PPL to ISL, > > > > and completes it where i

[Ada] Fix crash on recursive call to function with Out parameter

2012-07-03 Thread Eric Botcazou
The compiler crashes on the recursive call to a function with an In-Out or Out parameter passed by copy, in Ada 2012 mode. Tested on i586-suse-linux, applied on mainline and 4.7 branch. 2012-07-03 Eric Botcazou * gcc-interface/trans.c (Call_to_gnu): Robustify test for function case

fix thinko in tree-emutls, breaking tls support on vxworks

2012-07-03 Thread Olivier Hainque
Hello, With the current mainline configured for powerpc-wrs-vxworks, compiling the source below exposes a problem with tls support (emulated) on this target: /* t.c */ __thread int y = 2; ./cc1 t.c -o - t.c:1:14: error: __tls__y causes a section type conflict with y __thread int y = 2;

Re: [PATCH] Disable loop2_invariant for -Os

2012-07-03 Thread Richard Guenther
On Tue, Jul 3, 2012 at 10:29 AM, Zhenqiang Chen wrote: >>-Original Message- >>From: Richard Guenther [mailto:richard.guent...@gmail.com] >>Sent: 2012年6月28日 17:24 >>To: Zhenqiang Chen >>Cc: gcc-patches@gcc.gnu.org >>Subject: Re: [PATCH] Disable loop2_invariant for -Os >> >>On Thu, Jun 28, 2

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Richard Guenther
On Tue, 3 Jul 2012, Richard Guenther wrote: > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > > > On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > > > > > > > On 6/27/2012 8:06 AM, Richard Guenther wrote: > > > > > This merges from the graphite br

m68k: ignore -fstack-limit- if not supported

2012-07-03 Thread Andreas Schwab
Since the prologue rewrite in RTL the invalid assembler output has turned into an ICE. Ignore the option on non-68020+. Committed. Andreas. PR target/28896 * config/m68k/m68k.c (m68k_option_override): Reset stack_limit_rtx if !TARGET_68020. testsuite/ * gcc.targ

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Richard Guenther
On Tue, 3 Jul 2012, Richard Guenther wrote: > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > > > On Tue, 3 Jul 2012, Richard Guenther wrote: > > > > > > > On Mon, 2 Jul 2012, Nenad Vukicevic wrote: > > > > > > > > > On 6/27/2012 8:06 AM, Ric

Re: [PATCH] x86: use 'rep bsf' syntax when assembler supports it

2012-07-03 Thread Richard Guenther
On Tue, Jul 3, 2012 at 9:16 AM, Uros Bizjak wrote: > On Mon, Jul 2, 2012 at 8:39 PM, Roland McGrath wrote: >> On Sun, Jul 1, 2012 at 1:08 AM, Uros Bizjak wrote: >>> Based on the observation above, the patch is OK for mainline, but >>> please also handle "rep nop" case. >> >> Here's the new versi

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Tobias Grosser
On 07/03/2012 12:12 PM, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Mon, 2 Jul 2012, Nenad Vukicevic wrote: On 6/27/2012 8:06 AM

Re: [PATCH] x86: use 'rep bsf' syntax when assembler supports it

2012-07-03 Thread Uros Bizjak
On Tue, Jul 3, 2012 at 12:37 PM, Richard Guenther wrote: Based on the observation above, the patch is OK for mainline, but please also handle "rep nop" case. >>> >>> Here's the new version of the patch that does that. Note that someone >>> needs to commit this for me, since I am not em

[PATCH, i386]: Fix PR 53811, ICE: in insn_default_length, at config/i386/i386.md:529 (unrecognizable insn) with -mcmodel=large

2012-07-03 Thread Uros Bizjak
Hello! Attached patch fixes PR 53811. gcc failed to check if symbol_ref operands fits sibcall_insn_operand predicate. In case of -mcmodel=large, we must emit indirect jump for a sibcall. 2012-07-03 Uros Bizjak PR target/53811 * config/i386/i386.c (x86_output_mi_thunk): Check i

Re: [PATCH] x86: use 'rep bsf' syntax when assembler supports it

2012-07-03 Thread Richard Guenther
On Tue, Jul 3, 2012 at 12:48 PM, Uros Bizjak wrote: > On Tue, Jul 3, 2012 at 12:37 PM, Richard Guenther > wrote: > > Based on the observation above, the patch is OK for mainline, but > please also handle "rep nop" case. Here's the new version of the patch that does that. Note t

[PATCH] Merge the "ISL optimizer" from the graphite branch

2012-07-03 Thread Richard Guenther
This merges the last bit from the graphite ISL branch - an integrated optimizer based on ISL. To quote Tobias: "The isl scheduling optimizer implements the scheduling algorithm first developed in Pluto [1]. Pluto has shown significant speedups and is nowadays even implemented in the IBM XL-C c

Re: [ARM Patch 1/3]PR53189: optimizations of 64bit logic operation with constant

2012-07-03 Thread Carrot Wei
On Thu, Jun 28, 2012 at 12:14 AM, Ramana Radhakrishnan wrote: > On 28 May 2012 11:08, Carrot Wei wrote: >> Hi >> >> This is the second part of the patches that deals with 64bit and. It directly >> extends the patterns anddi3, anddi3_insn and anddi3_neon to handle 64bit >> constant operands. >> >

Re: [PATCH] Merge the "ISL optimizer" from the graphite branch

2012-07-03 Thread Tobias Grosser
On 07/03/2012 01:15 PM, Richard Guenther wrote: This merges the last bit from the graphite ISL branch - an integrated optimizer based on ISL. To quote Tobias: "The isl scheduling optimizer implements the scheduling algorithm first developed in Pluto [1]. Pluto has shown significant speedups an

Re: RFA: Speedup expand_used_vars by 30 times (PR38474)

2012-07-03 Thread Michael Matz
Hi, On Mon, 2 Jul 2012, Mike Stump wrote: > On May 26, 2012, at 8:03 PM, Michael Matz wrote: > > --- > > PR middle-end/38474 > > * cfgexpand.c (struct stack_var): Add slot_type member. > > (add_stack_var): Initialize it. > > (add_alias_set_conflicts): Remove. >

Re: [PATCH] Merge the "ISL optimizer" from the graphite branch

2012-07-03 Thread Richard Guenther
On Tue, 3 Jul 2012, Tobias Grosser wrote: > On 07/03/2012 01:15 PM, Richard Guenther wrote: > > > > This merges the last bit from the graphite ISL branch - an > > integrated optimizer based on ISL. To quote Tobias: > > > > "The isl scheduling optimizer implements the scheduling algorithm first

[PATCH, i386]: Fix wrong code model string in the error message

2012-07-03 Thread Uros Bizjak
Hello! 2012-07-03 Uros Bizjak * config/i386/i386.c (ix86_option_override_internal): Fix wrong code model string in the error message. Committed. Uros. Index: config/i386/i386.c === --- config/i386/i386.c (revis

Re: [PATCH] Merge the "ISL optimizer" from the graphite branch

2012-07-03 Thread Tobias Grosser
On 07/03/2012 01:56 PM, Richard Guenther wrote: On Tue, 3 Jul 2012, Tobias Grosser wrote: On 07/03/2012 01:15 PM, Richard Guenther wrote: This merges the last bit from the graphite ISL branch - an integrated optimizer based on ISL. To quote Tobias: "The isl scheduling optimizer implements t

Re: [PATCH] Merge the "ISL optimizer" from the graphite branch

2012-07-03 Thread Richard Guenther
On Tue, 3 Jul 2012, Tobias Grosser wrote: > On 07/03/2012 01:56 PM, Richard Guenther wrote: > > On Tue, 3 Jul 2012, Tobias Grosser wrote: > > > > > On 07/03/2012 01:15 PM, Richard Guenther wrote: > > > > > > > > This merges the last bit from the graphite ISL branch - an > > > > integrated optimi

Re: [C++ PATCH] Fix ICE with computed goto (PR c++/53812)

2012-07-03 Thread Jason Merrill
OK. Jason

Re: [PATCH] Merge the "ISL optimizer" from the graphite branch

2012-07-03 Thread Tobias Grosser
On 07/03/2012 02:24 PM, Richard Guenther wrote: On Tue, 3 Jul 2012, Tobias Grosser wrote: On 07/03/2012 01:56 PM, Richard Guenther wrote: On Tue, 3 Jul 2012, Tobias Grosser wrote: On 07/03/2012 01:15 PM, Richard Guenther wrote: This merges the last bit from the graphite ISL branch - an int

[PATCH] Clarify cloog install docs

2012-07-03 Thread Richard Guenther
People are running into issues when mixing cloog built against isl 0.08 and gcc building against isl 0.10 (which is expected I guess). Thus, clarified and committed. Richard. 2012-07-03 Richard Guenther * doc/install.texi (CLooG): Clarify how CLooG needs to be configured and

Re: [graphite] RFC: Add ISL variants of remaining PPL things

2012-07-03 Thread Michael Matz
Hi, On Mon, 2 Jul 2012, Tobias Grosser wrote: > > Yeah. If my above understanding is correct the path is clear. > > I believe it is. It somewhat works. It has problems in those cases where there are dependencies between different input dimensions in the scattering, which happens for strip-m

Re: RFA: MEP: Fix use of delete_insn.

2012-07-03 Thread nick clifton
Hi DJ, My concern is more about calling NEXT_INSN on a deleted insn. If that's guaranteed to be "reliable", I'm OK with it. So pick whichever solution is more future-proof and go for it :-) OK, I have gone with the following. I have replaced NEXT_INSN with next_nonnote_nondebug_insn, so

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Nenad Vukicevic
I'll try again. On the other hand I am pretty sure that I have ISL unpacked in my source tree. lrwxrwxrwx 1 nenad users 8 Jul 2 10:58 isl -> isl-0.10 drwxrwsr-x 7 nenad users4096 Jun 4 09:40 isl-0.10 Thank you. On 7/3/2012 3:12 AM, Richard Guenther wrote: The following fixes th

[lra] patch to fix ia64 testsuite regressions

2012-07-03 Thread Vladimir Makarov
The following patch fixes all testsuite regressions on ia64 in comparison with reload. The patch was successfully bootstrapped on ia64 and x86/x86-64. Committed as rev. 189235. 2012-07-03 Vladimir Makarov * lra-eliminations.c (lra_eliminate_regs_1): Use Pmode for plus_consta

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Nenad Vukicevic
I updated my trunk and was able to build. No problems at all. Thank you. Nenad On 7/3/2012 3:12 AM, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guenther wrote: On Tue, 3 Jul 2012, Richard Guent

PATCH to build_zero_cst for c++/53826 (ICE in libstdc++ on alpha)

2012-07-03 Thread Jason Merrill
The back end needs to know how to build up a zero in NULLPTR_TYPE for writing out an empty CONSTRUCTOR. Applying to trunk as obvious. commit 458655a61c4e175b120c68093db923010d013eba Author: Jason Merrill Date: Tue Jul 3 13:23:10 2012 -0400 PR c++/53826 * tree.c (build_zero_cst): Ha

[v3] libstdc++/53840

2012-07-03 Thread Paolo Carlini
Hi, straightforward indeed. Tested x86_64-linux. Thanks, Paolo. / 2012-07-03 Paolo Carlini PR libstdc++/53840 * include/std/ratio (ratio_multiply, ratio_divide, ratio_add, ratio_subtract): Use template aliases. * include/std/chrono (du

[Patch, fortran] PR fortran/53732

2012-07-03 Thread Mikael Morin
Hello, Revision 180898: http://gcc.gnu.org/viewcvs?view=revision&revision=180898 introduced at the end of gfc_add_loop_ss_code some self recursive calls to handle reductions' loops (like in sum for example). However, as gfc_add_loop_ss_code already calls itself to handle scalar and vector subsc

Re: PR53818 - Allow -finit-local-zero with -fno-automatic for result variables

2012-07-03 Thread Mikael Morin
On 02.07.2012 09:10, Tobias Burnus wrote: For some reasons, result variables are walked twice. With -finit-local-zero their value gets set to 0, either via an inserted assignment or by adding a initialization (sym->value). With -fno-automatic sym->value is also set for result variables, which la

Re: [wwwdocs] Update coding conventions for C++

2012-07-03 Thread Lawrence Crowl
On 7/1/12, Gabriel Dos Reis wrote: > On Fri, Jun 29, 2012 at 1:17 PM, Lawrence Crowl wrote: >> Resend, as I replied to a message that didn't have the usual suspects >> on the cc line. >> >> On 6/27/12, Lawrence Crowl wrote: >>> ..., does anyone object to removing the permission to use C++ >>> st

Re: [wwwdocs] Update coding conventions for C++

2012-07-03 Thread Lawrence Crowl
On 7/1/12, Jason Merrill wrote: > On 06/29/2012 02:17 PM, Lawrence Crowl wrote: > > +RTTI anddynamic_cast > > + > > + > > +Run-time type information (RTTI) is permitted > > +when certain non-default--enable-checking options are > > enabled, > > +so as to allow checkers to report dynamic types. >

Re: [PATCH, RFC] New target interface for vectorizer cost model

2012-07-03 Thread William J. Schmidt
On Tue, 2012-07-03 at 10:00 -0500, William J. Schmidt wrote: > On Tue, 2012-07-03 at 15:59 +0200, Richard Guenther wrote: > > On Tue, 3 Jul 2012, William J. Schmidt wrote: > > > > +@deftypefn {Target Hook} int TARGET_VECTORIZE_FINISH_COST (void > > > > *@var{}) > > > +This hook should complet

Re: [wwwdocs] Update coding conventions for C++

2012-07-03 Thread Gabriel Dos Reis
Lawrence Crowl writes: | On 7/1/12, Gabriel Dos Reis wrote: | > On Fri, Jun 29, 2012 at 1:17 PM, Lawrence Crowl wrote: | >> Resend, as I replied to a message that didn't have the usual suspects | >> on the cc line. | >> | >> On 6/27/12, Lawrence Crowl wrote: | >>> ..., does anyone object to re

Re: [SH] Improve extu.b, extu.w utilization for andsi3

2012-07-03 Thread Kaz Kojima
Oleg Endo wrote: > On SH a logical and with constants 0x or 0xFF can be done with the > respective zero-extension operations. The attached patch improves the > utilization of the zero-extension operations a little bit, resulting in > slightly better code. This patch is OK. Regards,

[PATCH][Cilkplus] Fix a small cilk_for bug

2012-07-03 Thread Iyer, Balaji V
Hello Everyone, This patch is for the Cilk Plus branch affecting both C and C++ compilers. This patch will fix a small cilk for bug and a small bug in pragma simd. Thanks, Balaji V. Iyer. Index: gcc/cgraphunit.c === --- gcc

[patch] Split up expand_case

2012-07-03 Thread Steven Bosscher
Hello, The attached patch splits out the code generation bits from expand_case to two new functions, emit_case_decision_tree and emit_case_dispatch_table. I also added some bits of new code to help me better understand how the code generation for decision trees works (I took dump_case_nodes taken

RE: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Terry Guo
Hi Richard, What's the plan for 4.7 branch? Will you back port this patch to 4.7 and make it use ISL too? I am going to create a upstream GCC SVN branch from 4.7 for development on ARM embedded processors. If there will be some big changes for 4.7 in near future in terms of replacing PPL with ISL,

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Tobias Grosser
On 07/04/2012 08:51 AM, Terry Guo wrote: Hi Richard, What's the plan for 4.7 branch? Will you back port this patch to 4.7 and make it use ISL too? I am going to create a upstream GCC SVN branch from 4.7 for development on ARM embedded processors. If there will be some big changes for 4.7 in near

Re: [PATCH] Move Graphite from using PPL over to ISL

2012-07-03 Thread Andrew Pinski
On Tue, Jul 3, 2012 at 11:51 PM, Terry Guo wrote: > Hi Richard, > > What's the plan for 4.7 branch? Will you back port this patch to 4.7 and > make it use ISL too? I am going to create a upstream GCC SVN branch from 4.7 > for development on ARM embedded processors. If there will be some big > chan