Re: patch to fix

2012-10-05 Thread Marc Glisse
On Thu, 4 Oct 2012, Kenneth Zadeck wrote: There are a bunch of ways to skin the cat. 1) we can define the extra mode. 2) if we get rid of the mode inside the wide int and replace it with an explicit precision and bitsize, then we can just make the size of the buffer twice as big as the analys

RE: [RFA 1/5] New port: CR16: Remove "gdb" from noconfigdirs in configure.ac

2012-10-05 Thread Kaushik Phatak
Hi, Thanks for the feedback. > I can't see how adding target-libgloss is relevant to a gdb port. This was actually a part of some simulator fixes to update nltvals.def as it was not emulating the correct system calls. The Newlib changes have been already checked in and nltvals.def has been regen

Re: r192002 breaks mingw-w64 cross compiler

2012-10-05 Thread Jonathan Wakely
On 4 October 2012 11:10, Christer Solskogen wrote: > Here's the error: > > /home/solskogen/obj/_build/gcc.cross.x86_64-w64-mingw32/./gcc/xgcc > -B/home/solskogen/obj/_build/gcc.cross.x86_64-w64-mingw32/./gcc/ > -L/home/solskogen/obj/cross-mingw-w64/x86_64-w64-mingw32/lib > -L/home/solskogen/obj/cro

[Patch, Fortran] Fix OPTIONAL, esp. with polymorphism

2012-10-05 Thread Tobias Burnus
gfortran supports OPTIONAL since quite some time - also some more complicated cases involving ELEMENTAL or the new F2008 addition, but as testing showed, the support is still incomplete; especially with polymorphic arguments there were several bugs. Besides a simple absent argument, passing an

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Richard Guenther
On Thu, 4 Oct 2012, Lawrence Crowl wrote: > On 10/4/12, Richard Guenther wrote: > > On Tue, 2 Oct 2012, Lawrence Crowl wrote: > >> On 10/2/12, Richard Guenther wrote: > >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: > >> > > Change more non-GTY hash tables to use the new type-safe > >> > > templ

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 05:26:11PM -0700, Cary Coutant wrote: > > Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C > > === > > --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048) > > +++ gcc/testsuite/g++.dg

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-05 Thread Richard Guenther
On Thu, Oct 4, 2012 at 7:38 PM, Jason Merrill wrote: > Both C++11 and OpenMP specify that thread_local/threadprivate variables can > have dynamic initialization and destruction semantics. This sequence of > patches implements that. > > The first patch adds the C++11 thread_local keyword and imple

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-05 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 01:38:38PM -0400, Jason Merrill wrote: > commit 18c01be0ec8b7a3cda6a16e86356e8e434c12f89 > Author: Jason Merrill > Date: Thu Sep 20 16:00:08 2012 -0400 > > Support C++11 thread_local destructors. > libstdc++-v3/ > * libsupc++/cxxabi.h: Declare __cxa_threa

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 10:29:54AM +0200, Richard Guenther wrote: > I wonder if an implementation is conforming that performs non-local TLS > variable inits at thread creation time instead (probably also would require > glibc support)? I think it is conforming, but not really doable, because of dl

Re: Use conditional casting with symtab_node

2012-10-05 Thread Richard Guenther
On Thu, Oct 4, 2012 at 8:16 PM, Diego Novillo wrote: > On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl wrote: > >> So, Jan Hubicka requested and approved the current spelling. >> What now? > > I don't think we should hold this up. The names Jan requested seem > reasonable enough. We seem to be r

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Thu, Oct 4, 2012 at 9:27 PM, Richard Sandiford wrote: > Kenneth Zadeck writes: >> On 10/04/2012 12:58 PM, Richard Guenther wrote: >>> On Thu, Oct 4, 2012 at 3:55 PM, Kenneth Zadeck >>> wrote: Let me talk about the mode here first. What this interface/patch provides is a facili

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 11:26 AM, Richard Guenther wrote: > Look at RTL users of the double-int routines and provide wrappers > that take RTXen as inputs. Enforce that all CONSTs have a mode. Which would, btw, allow to "merge" CONST_INT, CONST_DOUBLE and CONST_WIDE by making the storage size vari

Re: Use conditional casting with symtab_node

2012-10-05 Thread Jan Hubicka
> On Thu, Oct 4, 2012 at 8:16 PM, Diego Novillo wrote: > > On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl wrote: > > > >> So, Jan Hubicka requested and approved the current spelling. > >> What now? > > > > I don't think we should hold this up. The names Jan requested seem > > reasonable enough.

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Richard Guenther writes: >> As far as the wide_ints recording a mode or precision goes: we're in >> the "lucky" position of having tried both options. Trees record the >> type (and thus precision) of all compile-time integer constants. >> RTL doesn't. And the RTL way is a right pain. It leads t

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-05 Thread Iain Buclaw
On 5 October 2012 01:06, Joseph S. Myers wrote: > On Thu, 4 Oct 2012, Iain Buclaw wrote: > >> The only patches to gcc proper are documentation-related and adding >> the D frontend / libphobos to configure and make files. I would have >> thought that these would typically only be included with the

[libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Rainer Orth
With the strnlen-related Go failures now gone on Solaris, another issue crept up: several tests were failing like this: throw: /proc/self/exe goroutine 4 [running]: panic during panic FAIL: log This is due to the hardcoded use of /proc/self/exe in libbacktrace, which doesn't exist on Solaris, an

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 11:55 AM, Richard Sandiford wrote: > Richard Guenther writes: >>> As far as the wide_ints recording a mode or precision goes: we're in >>> the "lucky" position of having tried both options. Trees record the >>> type (and thus precision) of all compile-time integer constant

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 12:07 PM, Iain Buclaw wrote: > On 5 October 2012 01:06, Joseph S. Myers wrote: >> On Thu, 4 Oct 2012, Iain Buclaw wrote: >> >>> The only patches to gcc proper are documentation-related and adding >>> the D frontend / libphobos to configure and make files. I would have >>>

Re: Use conditional casting with symtab_node

2012-10-05 Thread Nathan Froyd
- Original Message - > I see all these patches with mixed feeling - it puts breaks on all > developers > because they need to learn the new interface which does not bring any > immediate benefit. So I think _your_ development time would be > better > spent by fixing open bugs or by tacklin

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Gerald Pfeifer
On Fri, 5 Oct 2012, Rainer Orth wrote: > This is due to the hardcoded use of /proc/self/exe in libbacktrace, > which doesn't exist on Solaris, and probably is also missing on other > non-Linux OSes. Solaris (since 2.6, it seems) provides getexecname() > instead, which this patch uses. : > I haven'

Re: Use conditional casting with symtab_node

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 12:50 PM, Nathan Froyd wrote: > - Original Message - >> I see all these patches with mixed feeling - it puts breaks on all >> developers >> because they need to learn the new interface which does not bring any >> immediate benefit. So I think _your_ development time

Re:[libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Uros Bizjak
Hello! > With the strnlen-related Go failures now gone on Solaris, another issue > crept up: several tests were failing like this: > > throw: /proc/self/exe > > goroutine 4 [running]: > panic during panic > FAIL: log > > This is due to the hardcoded use of /proc/self/exe in libbacktrace, > which d

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Rainer Orth
Gerald Pfeifer writes: > Your patch is better in that it checks for getexecname (which does > not exist in FreeBSD). Mine seems better in that it removes the > duplication between fileline.c and print.c and also addresses the > latter case. > > Could you just merge mine into yours or am I missi

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Rainer Orth
Uros Bizjak writes: > +# Check for getexecname function. > +if test -n "${with_target_subdir}"; then > + case "${host}" in > + *-*-solaris2*) have_getexecname=yes ;; > + *) have_getexecname=no ;; > + esac > +else > + AC_CHECK_FUNC(getexecname, [have_getexecname=yes], [have_getexename=no]

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Richard Guenther writes: > On Fri, Oct 5, 2012 at 11:55 AM, Richard Sandiford > wrote: >> Richard Guenther writes: As far as the wide_ints recording a mode or precision goes: we're in the "lucky" position of having tried both options. Trees record the type (and thus precision) of

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 1:24 PM, Richard Sandiford wrote: > Richard Guenther writes: >> On Fri, Oct 5, 2012 at 11:55 AM, Richard Sandiford >> wrote: >>> Richard Guenther writes: > As far as the wide_ints recording a mode or precision goes: we're in > the "lucky" position of having tried

[PATCH] Fix PR54811

2012-10-05 Thread Richard Guenther
This fixes PR54811 for me - still Ada LTO bootstrap fails for me with cgraph verification ICEs. LTO bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-10-05 Richard Guenther PR middle-end/54811 * tree-ssa-live.c (clear_unused_block_pointer_1): Look a

[committed] Don't error on failure to inline redefined gnu extern inline always_inline function (PR tree-optimization/33763)

2012-10-05 Thread Jakub Jelinek
Hi! This is something various Linux distributions have been carrying around for 5 years, and glibc headers rely on this. The comment says what the intended ideal state is, but during those 5 years that hasn't been implemented. Pre-approved by Richard on IRC, committed to trunk. --- gcc/ChangeLo

Re: [PATCH] Fix up DW_TAG_formal_parameter placement

2012-10-05 Thread Richard Guenther
On Thu, 4 Oct 2012, Jakub Jelinek wrote: > On Thu, Oct 04, 2012 at 09:42:59AM +0200, Richard Guenther wrote: > > This looks like the wrong place to fix things to me ... either we can > > fix this at the point we create the VAR_DECLs for the optimized away > > PARM_DECLs (or we should delay that un

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Richard Guenther
On Wed, 3 Oct 2012, Jakub Jelinek wrote: > On Tue, Sep 11, 2012 at 03:59:56PM +0200, Jakub Jelinek wrote: > > As discussed in the PR, right now we do a very bad job for debug info > > of partially inlined functions (both when they are kept only partially > > inlined, or when partial inlining is pe

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Richard Guenther writes: > On Fri, Oct 5, 2012 at 1:24 PM, Richard Sandiford > wrote: >> Richard Guenther writes: >>> The issue is that unlike RTL where we "construct" double-ints from >>> CONST_INT/CONST_DOUBLE right now, tree has the double-int >>> _embedded_. That's why I say that the thing

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Gerald Pfeifer
On Fri, 5 Oct 2012, Rainer Orth wrote: > Do the FreeBSD headers already provide a define for /proc/curproc/file? None that I could find. Gerald

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 2:26 PM, Richard Sandiford wrote: > Richard Guenther writes: >> On Fri, Oct 5, 2012 at 1:24 PM, Richard Sandiford >> wrote: >>> Richard Guenther writes: The issue is that unlike RTL where we "construct" double-ints from CONST_INT/CONST_DOUBLE right now, tree has

Re: Use conditional casting with symtab_node

2012-10-05 Thread Diego Novillo
On Fri, Oct 5, 2012 at 7:05 AM, Richard Guenther wrote: > Sorry, that wasn't intended. I question these numbers because > unless you bootstrap say 100 times the noise in bootstrap speed > is way too high to make such claims. Of course critical information > is missing: I agree with Nathan. Yo

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 02:20:13PM +0200, Richard Guenther wrote: > The following could use a comment on what you are doing ... Will add something. > > + if (args_to_skip) > > +for (parm = DECL_ARGUMENTS (current_function_decl), num = 0; > > +parm; parm = DECL_CHAIN (parm), num++) > > +

Re: [wwwdocs] SH 4.8 changes update

2012-10-05 Thread Kaz Kojima
Oleg Endo wrote: > The atomic options of SH have been changed recently. The attached patch > updates the 4.8 changes.html accordingly, plus some minor wording fixes. > > OK? OK. Regards, kaz

Re: [SH] PR 54760 - Add thread pointer built-ins and GBR displacement addressing

2012-10-05 Thread Kaz Kojima
Oleg Endo wrote: > Do you mean something like the attached patch as a preparation step? > (checked with 'make all') Yes. The patch is OK with removing the first line of the ChangeLog entry for PR number. Regards, kaz

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Richard Guenther writes: > On Fri, Oct 5, 2012 at 2:26 PM, Richard Sandiford > wrote: >> Richard Guenther writes: >>> On Fri, Oct 5, 2012 at 1:24 PM, Richard Sandiford >>> wrote: Richard Guenther writes: > The issue is that unlike RTL where we "construct" double-ints from > CONST_

Re: patch to fix constant math

2012-10-05 Thread Kenneth Zadeck
richi, let me address a bunch of issues that are randomly spread thru the thread. 1) unlike the double int's current relationship to int cst, we do not currently wrap a wide-int into an CONST_WIDE_INT nor (in the patch that you have not seen) do we wrap a wide-int into the int cst.wide-int

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Richard Sandiford writes: How is CONST_WIDE_INT variable size? >>> >>> It's just the usual trailing variable-length array thing. >> >> Good. Do you get rid of CONST_DOUBLE (for integers) at the same time? > > Yeah. I initially thought it might be OK to keep them and have > CONST_INT, intege

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 02:49:07PM +0200, Jakub Jelinek wrote: > I believe that gsi_insert_before in another function > isn't going to work well. > E.g. update_modified_stmt starts with > if (!ssa_operands_active (cfun)) > return; > > Or is it ok to use gsi_insert_before_without_update and e

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Ian Lance Taylor
On Fri, Oct 5, 2012 at 3:21 AM, Rainer Orth wrote: > With the strnlen-related Go failures now gone on Solaris, another issue > crept up: several tests were failing like this: > > throw: /proc/self/exe > > goroutine 4 [running]: > panic during panic > FAIL: log > > This is due to the hardcoded use

Re: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2)

2012-10-05 Thread Jason Merrill
On 10/02/2012 08:56 AM, Jakub Jelinek wrote: Perhaps maybe_constant_value already does all that integral_constant_value does, but I'm not sure about it. It does, you can remove that call. OK with that change. Jason

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 2:39 PM, Richard Guenther wrote: > > Ok, I see where you are going. Let me look at the patch again. * The introduction and use of CONST_SCALAR_INT_P could be split out (obvious and good) * DEF_RTL_EXPR(CONST_WIDE_INT, "const_wide_int", "", RTX_CONST_OBJ) defining that

Re: [libbacktrace] Use getexecname() on Solaris

2012-10-05 Thread Ian Lance Taylor
On Fri, Oct 5, 2012 at 4:21 AM, Rainer Orth wrote: > > I think this should work. The only complication might be that users of > DEFAULT_PROCESS_FILENAME need to include on Solaris to get > the declaration of getexecname(). Given that this header is already > used unconditionally, its inclusion

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-05 Thread Jan Hubicka
Hi, this is the udpated patch I comitted after testing. I suppose we will need to find way to make SOC smaller for simple loops - it is way too overestimated currently. * tree-vectorizer.h (vect_estimate_min_profitable_iters): Remove. * tree-vect-loop.c (vect_estimate_min_profita

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 3:18 PM, Richard Sandiford wrote: > Richard Sandiford writes: > How is CONST_WIDE_INT variable size? It's just the usual trailing variable-length array thing. >>> >>> Good. Do you get rid of CONST_DOUBLE (for integers) at the same time? >> >> Yeah. I initial

Re: Use conditional casting with symtab_node

2012-10-05 Thread Steven Bosscher
On Fri, Oct 5, 2012 at 2:43 PM, Diego Novillo wrote: > Because (...) there has been so much > negative pressure on our work, that we sometimes try to find some > benefit when reality may provide neutral results. When people say "your work sucks", they probably don't mean to apply negative pressure

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 2:49 PM, Jakub Jelinek wrote: > On Fri, Oct 05, 2012 at 02:20:13PM +0200, Richard Guenther wrote: >> The following could use a comment on what you are doing ... > > Will add something. > >> > + if (args_to_skip) >> > +for (parm = DECL_ARGUMENTS (current_function_decl),

Re: Use conditional casting with symtab_node

2012-10-05 Thread Steven Bosscher
On Fri, Oct 5, 2012 at 2:43 PM, Diego Novillo wrote: > Because (...) there has been so much > negative pressure on our work, that we sometimes try to find some > benefit when reality may provide neutral results. When people say "your work sucks", they probably don't mean to apply negative pressure

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Richard Guenther writes: > On Fri, Oct 5, 2012 at 3:18 PM, Richard Sandiford > wrote: >> Richard Sandiford writes: >> How is CONST_WIDE_INT variable size? > > It's just the usual trailing variable-length array thing. Good. Do you get rid of CONST_DOUBLE (for integers) at t

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 03:59:55PM +0200, Richard Guenther wrote: > I don't think we want to rely on that ... so just keep the push/pop_cfun. Ok, so this is what I'm retesting (basically just comments added and the two lines (subcode and set) swapped: 2012-10-05 Jakub Jelinek PR debug

[Ada] Missing deallocation of subpool

2012-10-05 Thread Arnaud Charlet
This patch ensures that Deallocate_Subpool is invoked on each subpool when the owner pool_with_subpools is finalized. -- Source -- -- gc_spool.ads with System.Storage_Pools.Subpools; private with System.Storage_Elements; package GC_SPool is use System; use Syste

[Ada] Fix race condition in freeing tasks

2012-10-05 Thread Arnaud Charlet
This patch fixes a subtle race condition where the master task and the child task may free the child task concurrently. Found by code reading. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-10-05 Arnaud Charlet * s-tassta.adb: Update comments. (Vulnerable_Complete_Mas

[Ada] Fix static computation of bounds using -gnato2 or -gnato3

2012-10-05 Thread Arnaud Charlet
The code for statically computing bounds for division and exponent was incorrect in some cases, possibly leading to wrong results when -gnato2 or -gnato3 was used. The code for mod and rem was not using optimal bounds, with possible minor consequences on efficiency of the generated code with -gnato

[Patch,avr]: Fix PR54815

2012-10-05 Thread Georg-Johann Lay
avr-gcc compiles code like void f (int, int); void f_or (int x) { f (x, x | 42); } to f_or: ldi r22,lo8(42) ; 15*movhi/5[length = 2] ldi r23,0 or r22,r24 ; 6iorhi3/1[length = 2] or r23,r25 rjmp f but this is more efficient: f_or: movw

[Ada] Internal cleanup of overflow defaults

2012-10-05 Thread Arnaud Charlet
This patch changes the default overflow checking mode to suppressed in the case of targets that support backend divide and overflow checking as indicated by the appropriate flags in Targparm being set. There are no such targets currently, so this change has no effect and no test is needed. Tested

[Ada] Handling of Invariant aspect on type completions

2012-10-05 Thread Arnaud Charlet
This patch fixes the handling of type invariants when they are specified on the completion of a private type, and when public expression functions return a type with invariants. Running the following: gnatmake -q -gnat12a main main must yield: OK --- with Ada.Assertions; use Ada.Asser

[PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Pavel Chupin
I can't configure libstdc++ separately. To reproduce: mkdir BUILD cd BUILD ../libstdc++-v3/configure Error: make: *** No rule to make target `/users/pvchupin/android/toolchain/gcc/gcc-4.8/BUILD/../libgcc/gthr-default.h', needed by `bits/gthr-default.h'. Stop. See fix attached. Ok for trunk and

Re: patch to fix constant math

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 4:14 PM, Richard Sandiford wrote: > Richard Guenther writes: >> On Fri, Oct 5, 2012 at 3:18 PM, Richard Sandiford >> wrote: >>> Richard Sandiford writes: >>> How is CONST_WIDE_INT variable size? >> >> It's just the usual trailing variable-length array thing. >

Re: patch to fix constant math

2012-10-05 Thread Kenneth Zadeck
On 10/05/2012 10:36 AM, Richard Guenther wrote: On Fri, Oct 5, 2012 at 4:14 PM, Richard Sandiford wrote: Richard Guenther writes: On Fri, Oct 5, 2012 at 3:18 PM, Richard Sandiford wrote: Richard Sandiford writes: How is CONST_WIDE_INT variable size? It's just the usual trailing variable

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Kenneth Zadeck writes: > i will convert ppc if that is what it takes. david's office is 4 isles > away and mike has a lot of experience on ppc also. (this is unless > richard is willing to do mips one afternoon.) 'Fraid MIPS is very boring as far as this is concerned. MIPS sets need_64bit_h

Re: vec_cond_expr adjustments

2012-10-05 Thread Marc Glisse
[I am still a little confused, sorry for the long email...] On Tue, 2 Oct 2012, Richard Guenther wrote: + if (TREE_CODE (op0) == VECTOR_CST && TREE_CODE (op1) == VECTOR_CST) +{ + int count = VECTOR_CST_NELTS (op0); + tree *elts = XALLOCAVEC (tree, count); + gcc_assert (TREE

[C++ testcase] PR 50893

2012-10-05 Thread Paolo Carlini
Hi, I'm adding the testcase and closing the PR. Tested x86_64-linux. Thanks, Paolo. / 2012-10-05 Paolo Carlini PR c++/50893 * g++.dg/cpp0x/defaulted38.C: New. Index: g++.dg/cpp0x/defaulted38.C ==

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Paul_Koning
On Oct 5, 2012, at 4:16 AM, Jakub Jelinek wrote: > On Thu, Oct 04, 2012 at 05:26:11PM -0700, Cary Coutant wrote: >>> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C >>> === >>> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1

[PATCH] [AArch64] Refactor Advanced SIMD builtin initialisation.

2012-10-05 Thread James Greenhalgh
Hi, This patch refactors the initialisation code for the Advanced SIMD builtins under the AArch64 target. The patch has been regression tested on aarch64-none-elf. OK for aarch64-branch? (If yes, someone will have to commit this for me as I do not have commit rights) Thanks, James Greenhalgh

[Patch,avr]: Remove -mshort-calls option

2012-10-05 Thread Georg-Johann Lay
As already discussed, this patch removes the -mshort-calls command option from avr-gcc. Ok to apply? If the change is on order, changes to wwwdocs will follow, i.e. deprecate the option in 4.7 and tell it is removed in the 4.8 caveats. Johann * doc/invoke.texi (AVR Options): Remove -ms

Re: patch to fix constant math

2012-10-05 Thread Kenneth Zadeck
richard s, there are two comments that i deferred to you. that have the word richard in them, richi, thank, i will start doing this now. kenny On 10/05/2012 09:49 AM, Richard Guenther wrote: On Fri, Oct 5, 2012 at 2:39 PM, Richard Guenther wrote: Ok, I see where you are going. Let me loo

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-05 Thread Joseph S. Myers
On Fri, 5 Oct 2012, Iain Buclaw wrote: > Would the best approach be to move all handle_* functions and any > helper functions into a new source file that can be shared between > frontends, and define two new frontend hooks, > LANG_HOOK_ATTRIBUTE_TABLE and LANG_HOOK_FORMAT_ATTRIBUTE_TABLE ? I don'

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-05 Thread Xinliang David Li
Hi Jason, Sri has addressed the comments you had on FE part. Can you take a look if it is ok? Stage-1 is going to be closed soon, and we hope to get this major feature in 4.8. thanks, David On Tue, Sep 18, 2012 at 9:29 AM, Sriraman Tallam wrote: > Ping. > > On Fri, Aug 24, 2012 at 5:34 PM,

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Paul_Koning
On Oct 5, 2012, at 11:34 AM, wrote: > > On Oct 5, 2012, at 4:16 AM, Jakub Jelinek wrote: > >> On Thu, Oct 04, 2012 at 05:26:11PM -0700, Cary Coutant wrote: Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C === >>>

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-05 Thread Jason Merrill
On 10/05/2012 04:41 AM, Jakub Jelinek wrote: Unfortunately, that penalty is not only for thread_local vars with ctors/dtors. There is some penalty even for using extern thread_local int i; int foo (void) { return i; } (as compared to extern __thread int i;), because we have to at least check

Re: patch to fix constant math

2012-10-05 Thread Richard Sandiford
Kenneth Zadeck writes: >> Or do you want to optimize encoding like for CONST_INT (and unlike >> CONST_DOUBLE)? I doubt the above packs nicely into rtx_def? >> A general issue of it though - we waste 32bits on 64bit hosts in >> rtx_def between the bits and the union. Perfect place for num_elem >>

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-05 Thread Jason Merrill
On 10/05/2012 04:29 AM, Richard Guenther wrote: Or if we have the extra indirection via a reference anyway, we could have a pointer TLS variable (NULL initialized) that on the first access will trap where in a trap handler we could then perform initialization and setup of that pointer. Interest

[v3] Remove cruft ;)

2012-10-05 Thread Paolo Carlini
Hi, remove some cruft noticed by Marc (and myself). Sanity checked x86_64-linux, committed to mainline. Thanks, Paolo. // 2012-10-05 Paolo Carlini * include/c_global/cstdlib: Remove redundant pasto code protected by __GXX_EXPERIMENTAL_CXX0X__. * inc

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-05 Thread Jason Merrill
On 08/24/2012 08:34 PM, Sriraman Tallam wrote: + /* If the address of a multiversioned function dispatcher is taken, + generate the body to dispatch the right function at run-time. This + is needed as the address can be used to do an indirect call. */ It seems to me that you don't ne

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Cary Coutant
> So given the comments, is this patch now ok to commit? Yes, this is OK. Thanks for doing the extra testing! (I also ran a quick test with -fdebug-types-section, just to make sure.) -cary

Re: patch to fix constant math

2012-10-05 Thread Kenneth Zadeck
On 10/05/2012 01:29 PM, Richard Sandiford wrote: +/* This is the maximal size of the buffer needed for dump. */ >>+const int MAX = (MAX_BITSIZE_MODE_ANY_INT / 4 >>++ MAX_BITSIZE_MODE_ANY_INT / HOST_BITS_PER_WIDE_INT + 32); >> >>I'd prefer a target macro for this, not anything ba

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-05 Thread Jason Merrill
On 10/05/2012 01:43 PM, Jason Merrill wrote: On 08/24/2012 08:34 PM, Sriraman Tallam wrote: + /* If the address of a multiversioned function dispatcher is taken, + generate the body to dispatch the right function at run-time. This + is needed as the address can be used to do an indirec

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2c

2012-10-05 Thread Michael Meissner
On Thu, Oct 04, 2012 at 06:33:33PM +0200, Gunther Nikl wrote: > Michael Meissner schrieb: > > On Tue, Oct 02, 2012 at 10:13:25AM +0200, Gunther Nikl wrote: > >> Michael Meissner wrote: > >>> Segher Boessenkool asked me on IRC to break out the fix in the last > >>> change. > >>> This patch is just

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2b

2012-10-05 Thread Michael Meissner
On Wed, Oct 03, 2012 at 09:42:05PM -0400, David Edelsohn wrote: > @@ -1115,7 +1118,8 @@ static const struct attribute_spec rs600 >{ NULL,0, 0, false, false, false, NULL, false } > }; > > -#ifndef MASK_STRICT_ALIGN > +#ifndef OPTION_MASK_STRICT_ALIGN > +#define OPTION_MASK_STRICT_ALI

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-05 Thread Jason Merrill
On 08/24/2012 08:34 PM, Sriraman Tallam wrote: + /* For function versions, their parms and types match +but they are not duplicates. Record function versions +as and when they are found. */ + if (TREE_CODE (fn) == FUNCTION_DECL + && TREE_CODE

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Jason Merrill
On 10/04/2012 08:26 PM, Cary Coutant wrote: It seems to me that there are cases where we just want to emit the class for the context info (like a namespace, which doesn't have to be complete everywhere). Is there a way to tell the debugger that this class declaration is incomplete and that it sho

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Cary Coutant
>> It seems to me that there are cases where we just want to emit the >> class for the context info (like a namespace, which doesn't have to be >> complete everywhere). Is there a way to tell the debugger that this >> class declaration is incomplete and that it should look elsewhere for >> a full d

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #3

2012-10-05 Thread Michael Meissner
I've rewritten my rs6000 infrastructure patch to allow more target switches, so that it does not change the flags currently in the target_flags. This should reduce the number of changes due to TARGET_ being called OPTION_, and MASK_ being called OPTION_MASK_. In addition, since it might be possib

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Paul_Koning
On Oct 5, 2012, at 2:43 PM, Cary Coutant wrote: >>> It seems to me that there are cases where we just want to emit the >>> class for the context info (like a namespace, which doesn't have to be >>> complete everywhere). Is there a way to tell the debugger that this >>> class declaration is incomp

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Andrew Pinski
On Fri, Oct 5, 2012 at 7:32 AM, Pavel Chupin wrote: > I can't configure libstdc++ separately. To reproduce: > > mkdir BUILD > cd BUILD > ../libstdc++-v3/configure > > Error: > make: *** No rule to make target > `/users/pvchupin/android/toolchain/gcc/gcc-4.8/BUILD/../libgcc/gthr-default.h', > neede

Re: [wwwdocs] SH 4.8 changes update

2012-10-05 Thread Oleg Endo
After commiting the last SH changes updates for 4.8 I was kindly informed that the br tags were left open. I've committed the attached fix as obvious. Cheers, Oleg ? www_4_8_sh_changes_2_close_br.patch Index: htdocs/gcc-4.8/changes.html

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2b

2012-10-05 Thread Michael Meissner
On Wed, Oct 03, 2012 at 09:42:05PM -0400, David Edelsohn wrote: > @@ -1115,7 +1118,8 @@ static const struct attribute_spec rs600 >{ NULL,0, 0, false, false, false, NULL, false } > }; > > -#ifndef MASK_STRICT_ALIGN > +#ifndef OPTION_MASK_STRICT_ALIGN > +#define OPTION_MASK_STRICT_ALI

Re: [C++] Mixed scalar-vector operations

2012-10-05 Thread Marc Glisse
Ping http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01557.html On Fri, 21 Sep 2012, Marc Glisse wrote: Hello, this patch adds mixed scalar-vector operations to the C++ front-end. It also adds a few operators to the C front-end (comparisons in particular). This patch is mostly an import from t

Re: [PATCH] Fix PR54489 - FRE needing AVAIL_OUT

2012-10-05 Thread Steven Bosscher
On Fri, Sep 14, 2012 at 2:26 PM, Richard Guenther wrote: > If you can figure out a better name for the function we should > probably move it to cfganal.c It looks like my previous e-mail about this appears to have gone got somehow, so retry: Your my_rev_post_order_compute is simply inverted_post

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
On 10/5/12, Richard Guenther wrote: > On Thu, 4 Oct 2012, Lawrence Crowl wrote: >> On 10/4/12, Richard Guenther wrote: >> > On Tue, 2 Oct 2012, Lawrence Crowl wrote: >> >> On 10/2/12, Richard Guenther wrote: >> >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: >> >> > > Change more non-GTY hash tab

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
Could you please review the patch at http://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg40961.html? On 10/3/12, Lawrence Crowl wrote: > Sorry, one more time with the right file contents. > > On 10/2/12, Richard Guenther wrote: >> You are changing a hashtable used by fold checking, did you te

Re: [google] AutoFDO implementation

2012-10-05 Thread Xinliang David Li
thanks. That will be helpful. David On Fri, Oct 5, 2012 at 2:09 PM, Dehao Chen wrote: > Sure, I'll add a detailed documentation in a gcc wiki page. > > Dehao > > On Fri, Oct 5, 2012 at 2:01 PM, Xinliang David Li wrote: >> Dehao, the file auto-profile.c has some high level description of >> aFD

[committed] Fix HImode add pattern on PA

2012-10-05 Thread John David Anglin
The attached change fixes a reload failure encountered testing another change. It occurred for a constant that didn't match the "J" constraint. The change makes the HImode pattern the same as the corresponding SImode pattern. Tested on hppa-unknown-linux-gn, hppa2.0w-hp-hpux11.11 and hppa64-hp-hp

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 01:59:18PM -0700, Lawrence Crowl wrote: > With the constructor, you don't have to remember and you don't > have to type more. If you have a variable, you know that it is > properly initialized. But we really don't want hundreds or thousands of dynamic constructors for glob

[v3] testsuite renames

2012-10-05 Thread Benjamin De Kosnik
More testsuite changes, tracking GSOC work. tested x86/linux -benjamin2012-10-05 Benjamin Kosnik * testsuite/28_regex/algorithms/match: Rename to... * testsuite/28_regex/algorithms/regex_match: ...this. * testsuite/28_regex/basic_regex/regex.cc: Rename to... * testsuite/28_regex/basic_re

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-05 Thread Paul_Koning
On Oct 5, 2012, at 2:43 PM, Cary Coutant wrote: >>> It seems to me that there are cases where we just want to emit the >>> class for the context info (like a namespace, which doesn't have to be >>> complete everywhere). Is there a way to tell the debugger that this >>> class declaration is incomp

Re: [PATCH] Fix PR54811

2012-10-05 Thread Eric Botcazou
> This fixes PR54811 for me - still Ada LTO bootstrap fails for me > with cgraph verification ICEs. Thanks for the fix! Yes, I also get the cgraph verification ICEs now, but that's kind of a progress if you ask me. :-) I'll look into them once the dust has settled on Jan's recent changes in th

Re: [PATCH] Use __cxa_atexit on OpenBSD

2012-10-05 Thread Gerald Pfeifer
On Sat, 15 Sep 2012, Mark Kettenis wrote: > Index: config.gcc > === > --- config.gcc(revision 191120) > +++ config.gcc(working copy) > @@ -708,6 +708,11 @@ > *-*-openbsd2.*|*-*-openbsd3.[012]) >tm_defines="

  1   2   >