Re: [asan] change libasan to libsanitizer

2012-11-04 Thread Dodji Seketeli
Jakub Jelinek writes: > On Thu, Nov 01, 2012 at 02:52:52PM -0700, Xinliang David Li wrote: >> I think it is better to apply this patch to asan first to avoid extra >> thread. You probably just need to retrieve your runtime part of the >> trunk patch and resend it. Make sense? > > Yeah, for trun

Re: RFA: Add a SLIM_RTX_STRING macro

2012-11-04 Thread Richard Sandiford
Steven Bosscher writes: > On Sat, Nov 3, 2012 at 8:52 PM, Richard Sandiford wrote: >> This patch rewrites sched-vis.c to use obstacks rather than fixed-length >> buffers. > > Hmm, nice but... > > I have some patches for GCC 4.9 to use the pretty-print infrastructure > instead (and also some half-f

[RFH] subreg of a vector without going through memory

2012-11-04 Thread Marc Glisse
Hello, trying to make some progress on PR 53101, I wrote the attached patch (it might be completely wrong for big endian, I don't know) (it is also missing a check that it isn't a paradoxical subreg) * simplify-rtx.c (simplify_subreg): For vectors, create a VEC_SELECT. However, when I c

Re: [patch] move GIMPLE_TRANSACTION expansion to tmmark pass

2012-11-04 Thread Aldy Hernandez
[Be not afraid, these are not new problems. This is what we've been working on off-line, reiterated here for the record.] And now that you mention it... - if (subcode & GTMA_DOES_GO_IRREVOCABLE) -flags = PR_DOESGOIRREVOCABLE | PR_UNINSTRUMENTEDCODE; - else -flags = PR_INSTRUMENTED

Re: [RFH] subreg of a vector without going through memory

2012-11-04 Thread Marc Glisse
On Sun, 4 Nov 2012, Marc Glisse wrote: Hello, trying to make some progress on PR 53101, I wrote the attached patch (it might be completely wrong for big endian, I don't know) (it is also missing a check that it isn't a paradoxical subreg) * simplify-rtx.c (simplify_subreg): For vectors

Re: [PATCH] Vzeroupper placement/47440

2012-11-04 Thread Uros Bizjak
Hello! 2012-11-04 Vladimir Yakovlev * mode-switching.c (create_pre_exit): Added code for maybe_builtin_apply case. * config/i386/i386-protos.h (emit_i387_cw_initialization): Deleted. (emit_vzero): Added prototype. (ix86_mode_entry): Likewise. (ix86_mode

[PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-04 Thread Uros Bizjak
Hello! Vzeroupper placement patch uses MODE_EXIT to determine if vzeroupper has to be placed before function exit. However, when compiling following test --cut here-- typedef struct objc_class *Class; typedef struct objc_object { Class class_pointer; } *id; typedef const struct objc_selector *

Re: [patch] Remove -fconserve-space

2012-11-04 Thread Gerald Pfeifer
Hi there, any comments on my proposed release notes entry below? Gerald On Sun, 26 Aug 2012, Gerald Pfeifer wrote: >> The attached patch removes the -fconserve-space flag, as discussed last >> week. Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? > > How about the following f

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-04 Thread Oleg Endo
On Sun, 2012-11-04 at 14:52 +0100, Uros Bizjak wrote: > Hello! > > Vzeroupper placement patch uses MODE_EXIT to determine if vzeroupper > has to be placed before function exit. However, when compiling > following test > > --cut here-- > typedef struct objc_class *Class; > typedef struct objc_obje

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2012 at 3:58 PM, Oleg Endo wrote: >> Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu, >> with vzeroupper patch [1] applied. >> >> I have added SH4 maintainer for possible comments. > > BTW, there are at least two mode-switching SH PRs: 41933 and 49220. > I've tr

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2012 at 4:02 PM, Uros Bizjak wrote: > On Sun, Nov 4, 2012 at 3:58 PM, Oleg Endo wrote: > >>> Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu, >>> with vzeroupper patch [1] applied. >>> >>> I have added SH4 maintainer for possible comments. >> >> BTW, there are a

Re: [ping] Re: [patch v2] support for multiarch systems

2012-11-04 Thread Matthias Klose
Am 02.11.2012 18:37, schrieb Ian Lance Taylor: On Fri, Nov 2, 2012 at 6:26 AM, Matthias Klose wrote: +ifeq ($(enable_multiarch),yes) + if_multiarch = $(1) +else ifeq ($(enable_multiarch),auto-detect) + if_multiarch = $(if $(wildcard $(shell echo $(SYSTEM_HEADER_DIR))/../../usr/lib/*/crti.o)

Re: exception safety validation

2012-11-04 Thread Jonathan Wakely
On 3 November 2012 19:05, Paolo Carlini wrote: > > On 11/03/2012 03:43 PM, François Dumont wrote: >> >> Note that I run exception tests to validate it and the recently introduced >> 23_containers/forward_list/allocator/noexcept.cc test doesn't work in debug >> mode. I think it needs a dg-require-no

Re: exception safety validation

2012-11-04 Thread Jonathan Wakely
Ooh, I almost forgot, please remember to update the copyright years in the changed files. For trunk you can change them to ranges like 2005-2012 On 4 November 2012 16:01, Jonathan Wakely wrote: > On 3 November 2012 19:05, Paolo Carlini wrote: >> >> On 11/03/2012 03:43 PM, François Dumont wrote:

Re: [PATCH] Update source location for PRE inserted stmt

2012-11-04 Thread Richard Biener
On Wed, Oct 31, 2012 at 8:02 PM, Xinliang David Li wrote: > Dehao's patch will make the debugging of the following code (-g -O2) > less jumpy. After the testing of x > 0, it should go to line 'a++'. > Without the fix, when stepping through 'abc', the lines covered are > 6, 4, 11, 13. With the f

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-04 Thread Richard Biener
On Thu, Nov 1, 2012 at 2:10 PM, Richard Sandiford wrote: > Kenneth Zadeck writes: >> I would like you to respond to at least point 1 of this email. In it >> there is code from the rtl level that was written twice, once for the >> case when the size of the mode is less than the size of a HWI and

Re: [PATCH] Poison loc_t in system.h

2012-11-04 Thread Richard Biener
On Thu, Nov 1, 2012 at 8:54 PM, David Edelsohn wrote: > The name loc_t is too enticing for developers to avoid, but it > unfortunately conflicts with a visible symbol in an AIX header file, > which repeatedly causes conflicts. This patch poisons the symbols in > GCC system.h to prevent developers

Re: Tighten checking of vector comparisons

2012-11-04 Thread Richard Biener
On Thu, Nov 1, 2012 at 10:10 PM, Marc Glisse wrote: > Hello, > > this patch makes gimple checking of vector comparisons more strict by > ensuring that it doesn't return a boolean. It also fixes a bug that this > check detected in fold-const.c: for (void)(x<0), the C front-end was calling > fold_un

Re: [PATCH] Fix an error in r193053

2012-11-04 Thread Richard Biener
On Thu, Nov 1, 2012 at 11:25 PM, Dehao Chen wrote: > Hi, > > In r193053, input_location was mistakenly used. This patch changed to > use curr_insn_location instead. This looks like an obvious patch, can > I check it in to trunk? > > Bootstrapped and passed gcc/gdb regression test. Ok. Thanks, Ri

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-04 Thread Jonathan Wakely
On 2 November 2012 01:01, Gerald Pfeifer wrote: > On Fri, 2 Nov 2012, Jonathan Wakely wrote: >>> There is a _lot_ left to do, especially around the imported lwg >>> pages; those are in a vary bade state. Any volunteer for that >>> one? >> They're imported, do we really want to tweak them? And then

Re: Minimize downward code motion during reassociation

2012-11-04 Thread Richard Biener
On Wed, Oct 31, 2012 at 8:16 PM, Easwaran Raman wrote: > On Wed, Oct 31, 2012 at 4:36 AM, Richard Biener > wrote: >> On Wed, Oct 24, 2012 at 4:02 AM, Easwaran Raman wrote: >>> On Tue, Oct 23, 2012 at 2:52 AM, Richard Biener >>> wrote: On Mon, Oct 22, 2012 at 8:31 PM, Easwaran Raman wrote:

Re: [PATCH] Add extra location information - PR43486

2012-11-04 Thread Arnaud Charlet
> I think, in the long-term, your proposed approach is less useful than > fixing early folding and adding locations (via a wrapper or an > on-the-side index) to the tree nodes that don't have one. But, since > nobody is working on the latter, the "long term" may be longer than > the time until som

Re: [PATCH] Update source location for PRE inserted stmt

2012-11-04 Thread Dehao Chen
2. __attribute__((noinline)) int abc (int *a) 3. { 4. int ret = 0; 5. 6. if (x > 0) 7.ret += *a; 8. else 9.a++; 10. 11. ret += *a; 12. return ret; 13 } In terms of jumpiness, without the patch, the jump sequence is: 2 -> 13 -> 4 -> 11 -> 13 With the patch, the jump sequence is: 2-> 9

Re: [PATCH] Vzeroupper placement/47440

2012-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2012 at 2:29 PM, Uros Bizjak wrote: > -/* { dg-final { scan-assembler-not "avx_vzeroupper" } } */ > +/* { dg-final { scan-assembler-times "avx_vzeroupper" 3 } } */ > > (... and a couple of similar testsuite changes ...) > > These asm scans were put there for a reason. I assume you

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2012 at 4:23 PM, Uros Bizjak wrote: Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu, with vzeroupper patch [1] applied. I have added SH4 maintainer for possible comments. >>> >>> BTW, there are at least two mode-switching SH PRs: 41933 and 49

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-04 Thread Joern Rennecke
Quoting Richard Sandiford : OK with those changes for the rtl bits. Can't approve the generator stuff though. It appears we are momentarily short of reviewers for the generator files. Till someone who feels he is competent to review the generator file patches finds the time to review them, c

Re: [wwwdocs,avr]: Deprecate/remove -mshort-calls, --with-avrlibc is default

2012-11-04 Thread Gerald Pfeifer
On Mon, 8 Oct 2012, Georg-Johann Lay wrote: > Applied the following changes to 4.7/4.8 release notes caveats. Thanks, Georg-Johann. I applied the following editorial change on top of this now. Gerald Index: gcc-4.7/changes.html ==

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-04 Thread Gerald Pfeifer
On Sun, 4 Nov 2012, Jonathan Wakely wrote: >> http://gcc.gnu.org/onlinedocs/libstdc++/ext/pb_ds/acks.html >> - http://starship.python.net/crew/aaron_watters/kjbuckets/ >>broken links >> >> http://gcc.gnu.org/onlinedocs/libstdc++/ext/pb_ds/references.html >> - http://anubis.dkuug.dk/jtc1/sc22/

Re: RFA: hookize ADJUST_INSN_LENGTH

2012-11-04 Thread amylaar
Quoting Joern Rennecke : The return value is a pointer to a function, to be used for adjusting instruction length in the place of ADJUST_INSN_LENGTHS - and where it is missing, or zero if no such functionis required. (I first thought of having separate target hooks for everything, but then I re

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-11-04 Thread Alexandre Oliva
On Nov 3, 2012, Jakub Jelinek wrote: > On Sat, Nov 03, 2012 at 02:11:22PM -0200, Alexandre Oliva wrote: >> I didn't try delaying the creation of the pointer set as you did, but >> I'm now thinking using a linear on-stack vector for searches up to some >> size might be even faster than creating t

Re: [RFC] VEC interface overhaul

2012-11-04 Thread Diego Novillo
I have added a wiki page to help with transitioning old VEC code to the new API. http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec I am doing the final tests (only a handful of testsuite failures to fix) and expect to commit the patch in the coming days. I've included in this message everyone who s

Re: [PATCH] Update source location for PRE inserted stmt

2012-11-04 Thread Xinliang David Li
On Sun, Nov 4, 2012 at 8:07 AM, Richard Biener wrote: > On Wed, Oct 31, 2012 at 8:02 PM, Xinliang David Li wrote: >> Dehao's patch will make the debugging of the following code (-g -O2) >> less jumpy. After the testing of x > 0, it should go to line 'a++'. >> Without the fix, when stepping thr

Re: [PATCH] Reset source location for instructions moved out of its original residing basic block

2012-11-04 Thread Alexandre Oliva
On Nov 1, 2012, Dehao Chen wrote: > I see your point. How about we guard these changes with a flag, say > -gless-jumpy The right (DWARF-expected) approach to avoid this sortof jumpiness is to teach GCC to emit .locs with is_stmt=1, along the lines (and limitations) described in my GCC Summit pa

[PATCH] Minor ipa-prop.c internal interface tweak

2012-11-04 Thread Martin Jambor
Hi, in order to use a few functions in the transformation phase of IPA-CP without computing the whole struct ipa_node_params for the current function, the following patch makes those functions (or their _1 versions) use just the vector they need. Bootstrapped and tested on x86_64-linux, needed fo

[PATCH] Disable aggregate jump functions for bit-field stores

2012-11-04 Thread Martin Jambor
Hi, the patch below disables generation of aggregate jump functions from bit-field stores because currently we depend on type size of the value to determine the size of the stored value and that does not work with bit-fields, making it impossible for IPA-CP to organize them in their lattices. If

[PATCH] Stream cgraph_node.ipa_transforms_to_apply

2012-11-04 Thread Martin Jambor
Hi, the following patch adds streaming ofcgraph_node.ipa_transforms_to_apply so that transformation phases of IPA passes are run in LTO too. It is done by simple streaming of pass.static_pass_number and then looking it up among all_regular_ipa_passes. Bootstrapped and tested on x86_64-linux, req

Re: Fwd/Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-04 Thread Alexandre Oliva
On Nov 1, 2012, Joern Rennecke wrote: > Quoting Richard Sandiford : >> OK with those changes for the rtl bits. Can't approve the generator >> stuff though. > Can you build machinery maintainers also review gen* and *.def patches, > of this patch ( http://gcc.gnu.org/ml/gcc-patches/2012-10/msg0

Re: [PATCH] boehm-gc configuration support for GNU/Hurd

2012-11-04 Thread Thomas Schwinge
Hi! On Mon, 18 Jun 2012 12:49:12 -0600, Tom Tromey wrote: > > "Thomas" == Thomas Schwinge writes: > > Thomas> This is a backport of upstream boehm-gc configuration support for > Thomas> GNU/Hurd. The equivalent thing has been used in Debian's GCC packages > Thomas> since GCC 4.2 already, a

RE: [PATCH] Decimal Floating-Point (libbid) for GNU/Hurd

2012-11-04 Thread Thomas Schwinge
Hi! On Mon, 23 Jul 2012 16:45:37 +, decimalfp wrote: > Just a follow-up - have those changes been made? I now pushed these in r193143. libgcc/config/libbid/ * bid_functions.h: Check for __GLIBC__ additionally to LINUX when defining format specifiers. config/ * dfp.m

Re: [PATCH] Perform frame_pointer_needed hfp -> cfa replacements even if fp setter is not in the first bb (PR debug/54402)

2012-11-04 Thread Alexandre Oliva
On Oct 29, 2012, Jakub Jelinek wrote: > PR debug/54402 > * var-tracking.c (fp_setter): Return false if there is REG_CFA_RESTORE > hfp note. > (vt_initialize): Look for fp_setter in any bb, not just successor of > entry bb. This looks reasonable, except that... > --

Re: s%funcs%ifuncs typo in libatomic/acinclude.m4

2012-11-04 Thread Thomas Schwinge
Hi! On Tue, 29 May 2012 17:23:45 +0200, I wrote: > Actually, I'm getting additional/unrelated changes in configure -- > probably someone forgot to regenerated this earlier on, or used a version > different from 2.64? Anyway, OK to commit all this? I now committed this, as obvious, in r193144. l

[C++ Patch PING] PR 54526 (again)

2012-11-04 Thread Paolo Carlini
Hi, I'd like to ping this recent patch of mine: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02509.html Thanks! Paolo.

Re: s%funcs%ifuncs typo in libatomic/acinclude.m4

2012-11-04 Thread Thomas Schwinge
Hi! On Tue, 29 May 2012 16:35:31 +0200, I wrote: > The subject already says it all. It got me confused what »funcs« that > might be. I now committed the following, as obvious, in r193145: * acinclude.m4 (LIBAT_CHECK_IFUNC): Clarify message. * configure: Regenerate. diff --git l

Re: Remove obsolete Solaris 8 support

2012-11-04 Thread Thomas Schwinge
Hi! Low priority, but still ;-) -- ping. On Sat, 30 Jun 2012 01:30:42 +0200, I wrote: > On Mon, 12 Mar 2012 18:44:24 +0100, Rainer Orth > wrote: > > 2012-03-11 Rainer Orth > > > gcc: > > * config.gcc (enable_obsolete): Remove *-*-solaris2.8*. > > (*-*-solaris2.[0-8], *-*-solaris

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-04 Thread Gabriel Dos Reis
On Sun, Nov 4, 2012 at 2:36 PM, Gerald Pfeifer wrote: > On Sun, 4 Nov 2012, Jonathan Wakely wrote: >>> http://gcc.gnu.org/onlinedocs/libstdc++/ext/pb_ds/acks.html >>> - http://starship.python.net/crew/aaron_watters/kjbuckets/ >>>broken links >>> >>> http://gcc.gnu.org/onlinedocs/libstdc++/ext

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-04 Thread Jonathan Wakely
On 4 November 2012 20:36, Gerald Pfeifer wrote: > On Sun, 4 Nov 2012, Jonathan Wakely wrote: >>> http://gcc.gnu.org/onlinedocs/libstdc++/ext/pb_ds/acks.html >>> - http://starship.python.net/crew/aaron_watters/kjbuckets/ >>>broken links >>> >>> http://gcc.gnu.org/onlinedocs/libstdc++/ext/pb_ds

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-04 Thread Jonathan Wakely
On 5 November 2012 00:33, Jonathan Wakely wrote: > > Are you sure the other links haven't already been fixed in the > libstdc++ sources? > > The copies on the website are usually fairly out of date. Yes, looking at doc/xml/manual/policy_data_structures.xml it seems that the dinkumware reference is

Re: [SH] Treat SH2A as superscalar

2012-11-04 Thread Kaz Kojima
Oleg Endo wrote: > The SH2A is actually superscalar and thus it might be better to treat it > as such for scheduling. It also is a harvard arch, but after adding it > to the TARGET_HARVARD arch, I've noticed that the macro is only used as > a parameter for instruction cache invalidation. Maybe i

Re: [patch] Remove -fconserve-space

2012-11-04 Thread Jason Merrill
That looks good to me. Jason

Using -ffunction-sections and -p

2012-11-04 Thread Sriraman Tallam
Hi, Currently, using -ffunction-sections and -p together results in a warning. I ran into this problem when compiling the kernel. This is discussed in this thread: http://gcc.gnu.org/ml/gcc-help/2008-11/msg00128.html Ian's reply suggests this warning is no longer necessary and can be removed.

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-04 Thread Hans-Peter Nilsson
On Sun, 4 Nov 2012, Kirill Yukhin wrote: > Hi, > > >> But... I don't really understand it, so here's some feedback on > >> the documentation: Regarding the language, a definite article is > > Patch with fixed doc is attached. Changelog is the same > > Is it OK? The structure is much improved and q

[C++11] PR54413 Option for turning off compiler extensions for numeric literals.

2012-11-04 Thread Ed Smith-Rowland
There is a request to be able to turn off interpretation of several suffixes for gcc extension numeric literals to make way for C++-1Y or various std libraries to claim several suffixes currently used for gnu extensions. This patch interprets the suffixes according to the current extension ru

Re: Using -ffunction-sections and -p

2012-11-04 Thread Ian Lance Taylor
On Sun, Nov 4, 2012 at 8:04 PM, Sriraman Tallam wrote: > >Currently, using -ffunction-sections and -p together results in a > warning. I ran into this problem when compiling the kernel. This is > discussed in this thread: > > http://gcc.gnu.org/ml/gcc-help/2008-11/msg00128.html > > Ian's reply

Re: [PATCH] Vtable pointer verification (corruption/attach detection -- new feature

2012-11-04 Thread Xinliang David Li
Can you split the patch into two parts? One for runtime and and one for GCC ? Please also use -up option in the diff command to generate the patch file. thanks, David On Thu, Nov 1, 2012 at 1:07 PM, Caroline Tice wrote: > We have been developing a new security hardening feature for GCC that > i

GCC for GNU Hurd: MACH built-in preprocessor macro (was: gdb: FTBFS on hurd-i386 (for review))

2012-11-04 Thread Thomas Schwinge
Hi! On Fri, 28 Sep 2012 09:56:41 +0200, Samuel Thibault wrote: > Thomas Schwinge, le Thu 27 Sep 2012 09:15:23 +0200, a écrit : > > On Wed, 26 Sep 2012 16:02:29 +0200, Svante Signell > > wrote: > > > gdb does not build from source any longer since gdb-multiarch packages > > > was enabled in 7.4