Re: libsanitizer mege from upstream r171973

2013-01-09 Thread Dmitry Vyukov
On Thu, Jan 10, 2013 at 11:01 AM, Konstantin Serebryany wrote: > Hi, > > The attached patch is the libsanitizer merge from upstream r171973. > > Lots of changes. Among other things: > - slow CFI-based unwinder (off by default for now) > - more interceptors in asan (read, pread, etc) > - prec

[Patch] FYI: Update my e-mail address in MAINTAINERS

2013-01-09 Thread Hurugalawadi, Naveen
Hi, Update my e-mail address in MAINTAINERS file. Committed: 2013-01-10 Naveen H.S * MAINTAINERS (Write After Approval): Update e-mail address.--- gcc/MAINTAINERS 2013-01-10 11:46:59.886102413 +0530 +++ gcc/MAINTAINERS 2013-01-10 11:34:31.554115235 +0530 @@ -402,7 +402,7 @@ Manfred

Minor testsuite improvement

2013-01-09 Thread Jeff Law
Gary Funck noted that vrp06.c has two tests with the same output. After further investigation it was clear that expected output strings were too lenient and were in fact masking a missed optimization. This patch tightens the expected output from the vrp dump which has the side effect of mak

C++ PATCH for c++/55878 (wrong error with --enable-checking)

2013-01-09 Thread Jason Merrill
I still think a bogus error only with --enable-checking doesn't merit P1, but it's still worth fixing. The problem was that the typeid code hadn't been SFINAEd yet. Tested x86_64-pc-linux-gnu, applying to trunk. commit 0b605fda3f97fd69b8106f096109535881413c83 Author: Jason Merrill Date: Wed

Re: unnecessary assert

2013-01-09 Thread Jakub Jelinek
On Wed, Jan 09, 2013 at 02:57:00PM -0800, Mike Stump wrote: > Ok for 2.8? Not to 2.8, but to 4.8 it is ok. > http://gcc.gnu.org/PR31150 is the PR when the assert was added, if you want > to see it. svn+ssh://gcc.gnu.org/svn/gcc/trunk@142892 is the change itself. That actually didn't add the as

[PATCH] Fix complex lowering with inline asm (PR tree-optimization/55921)

2013-01-09 Thread Jakub Jelinek
Hi! We weren't processing GIMPLE_ASMs that set complex SSA_NAMEs, which lead to SSA_NAMEs with NULL SSA_NAME_DEF_STMT, either leading to crashes or silent wrong code, depending on --enable-checking. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2013-01-09 Ja

unnecessary assert

2013-01-09 Thread Mike Stump
I found an assert that trips on my port for trivial constructs, often. I'd like to remove it, so that my port works better. The assert was added because the case analysis he did was for when BLKmode MEM stores appeared in back when he wrote the patch (Hi Jakub). He didn't analyze when dealing

Fix undefined symbols in LTO Mozilla build

2013-01-09 Thread Jan Hubicka
Hi, currently Mozilla does not build with undefined symbol on error: /tmp/cc0oq4BG.ltrans1.ltrans.o: requires dynamic R_X86_64_PC32 reloc against '_ZN12SkAnnotationC1ER23SkFlattenableReadBuffer' which may overflow at runtime; recompile with -fPIC This is actually bug in Mozilla (the module is cal

Re: [PATCH] Fix PR55882

2013-01-09 Thread Eric Botcazou
> This fixes PR55882 - set_mem_attributes_minus_bitpos misses to > account for the to-be applied bitpos when computing MEM_ALIGN. > It extracts alignment from 't' instead of &t - bitpos. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, bootstrap > and regtest running on mips. > > Does thi

Re: Control dependence vs. builtin_unreachable

2013-01-09 Thread Jeff Law
On 01/07/2013 01:42 PM, Steven Bosscher wrote: For optimizations it's a bit more difficult. Somewhat. For what I'm suggesting, the way we'd miss an optimization would be if by removing the unreachable block and simplifying the CFG we ultimately remove a conditional which produced a result whic

Re: Control dependence vs. builtin_unreachable

2013-01-09 Thread Jeff Law
On 01/07/2013 01:42 PM, Steven Bosscher wrote: typedef enum fruits { banana = 0, apple = 1, pear = 2, orange = 3 } fruit; extern void price_fruit_of_the_day (int); void discount_of_the_day (fruit f) { int p, c = (int) f; switch (f) { case banana: UNREACHABLE (); case a

Re: [PATCH, testsuite]: Fix scan string of gfortran.dg/intrinsic_size_3.f90

2013-01-09 Thread Tobias Burnus
The patch is OK. Thanks! Tobias Uros Bizjak wrote: The regexp in the scan string assumes that dumped temporaries have exactly 4 numbers. Sometimes, this is not the case. Attached patch fixes scan string to match a number with arbitrary number of places instead. 2012-01-09 Uros Bizjak

[PATCH, testsuite]: Fix scan string of gfortran.dg/intrinsic_size_3.f90

2013-01-09 Thread Uros Bizjak
Hello! The regexp in the scan string assumes that dumped temporaries have exactly 4 numbers. Sometimes, this is not the case. Attached patch fixes scan string to match a number with arbitrary number of places instead. 2012-01-09 Uros Bizjak * gfortran.dg/intrinsic_size_3.f90: Make sc

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-09 Thread Richard Sandiford
Richard Biener writes: > On Fri, Jan 4, 2013 at 7:57 PM, Eric Botcazou wrote: >>> Eric, any comments? >> >> Richard's patch seems fine to me, modulo the name of the routine; I'd rather >> use maybe_emit_group_store or something along these lines. > > Ok, fine with me - you're clearly more experie

C++ PATCH for c++/55893 (segfault running destructor on rodata)

2013-01-09 Thread Jason Merrill
My fix for PR 49673 made it so that objects with constant initialization semantics through constexpr can go into rodata now. But objects with non-trivial destruction semantics still need to go into writable data so that the destructor can modify the object. Tested x86_64-pc-linux-gnu, applyin

Re: [PATCH] Allow x <- x, 1 in *vec_concatv2df (PR rtl-optimization/55829)

2013-01-09 Thread Uros Bizjak
On Wed, Jan 9, 2013 at 10:23 AM, Uros Bizjak wrote: >> No matter whether LRA (if it is a bug in there) is fixed or not, >> *vec_concatv2df could handle for !avx sse3 x <- x, 1 alternative the same >> as it handles x <- m, 1 alternative (using movddup). >> >> Bootstrapped/regtested on x86_64-linux

Re: [Patch, Fortran] PR55758 - Non-C_Bool handling with BIND(C)

2013-01-09 Thread Mikael Morin
Le 09/01/2013 17:22, Tobias Burnus a écrit : However, I still believe that we should do something -std=gnu. Hm, reject? One can't declare a procedure with one type on one side, and another different type on the other side and expect things to work. We don't support passing integer as real, or

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

2013-01-09 Thread Andrew Pinski
On Wed, Jan 9, 2013 at 7:14 AM, Alexander Ivchenko wrote: > Hi, > > We have test fail for gcc.dg/cpp/trad/include.c on Android. The > reason for that is that > -ftraditional-cpp is not expected to work on Android due to variadic > macro (like #define __builtin_warning(x, y...)) > in standard hea

patch to fix PR55829

2013-01-09 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55829 The patch was successfully bootstrapped on x86-64. Committed as rev. 195057. 2013-01-09 Vladimir Makarov PR rtl-optimization/pr55829 * lra-constraints.c (match_reload): Add code for absent output

[PATCH, i386]: Change mode attribute of movddup insn to DF.

2013-01-09 Thread Uros Bizjak
Hello! Jakub noticed that we declare the mode of movddup insn inconistently as V2DF or DF. Calculation of various prefixes for certain non-AVX sse insns depends on correct definition of insn mode; for V2DFmode prefix_data16 is added and for DFmode, prefix_rep is added. In case of movddup, the late

[Patch, AArch64] Implement support for LD1R.

2013-01-09 Thread Tejas Belagod
Hi, Attached is a patch that implements support for AdvSIMD instruction LD1R. Tested on aarch64-none-elf. OK for trunk? Thanks, Tejas Belagod ARM. 2013-01-09 Tejas Belagod gcc/ * config/aarch64/aarch64-simd.md (*aarch64_simd_ld1r): New. * config/aarch64/iterators.md (VALLDI

[Patch, AArch64-4.7] Implement support for LD1R.

2013-01-09 Thread Tejas Belagod
Hi, Attached is a patch that implements support for AdvSIMD instruction LD1R. Tested on aarch64-none-elf. OK to commit on aarch64-4.7-branch? Thanks, Tejas Belagod ARM. 2013-01-09 Tejas Belagod gcc/ * config/aarch64/aarch64-simd.md (*aarch64_simd_ld1r): New. * config/aarch

Re: [Patch, Fortran] PR55758 - Non-C_Bool handling with BIND(C)

2013-01-09 Thread Tobias Burnus
Am 08.01.2013 21:07, schrieb Janne Blomqvist: As written before, I believe that the patch avoids some pitfalls with C interoperability of logical variables: On one hand, it improves cross-compiler portability by rejecting non C_BOOL ones with -std=f2003/f2008/f2008ts; This part is certainly ok.

Re: [PATCH] PR c++/55663 - constexpr function templ instantiation considered non-const as alias templ arg

2013-01-09 Thread Jason Merrill
On 01/09/2013 10:02 AM, Dodji Seketeli wrote: As the argument 'the_truth()' we care about is type dependant, uses_template_parms returns true and so convert_nontype_argument is never called. Right, but we should call it for the instantiated argument, too. We do that for class templates by cal

Re: [PATCH] PR c++/55663 - constexpr function templ instantiation considered non-const as alias templ arg

2013-01-09 Thread Gabriel Dos Reis
On Wed, Jan 9, 2013 at 9:30 AM, Dodji Seketeli wrote: > Gabriel Dos Reis writes: > >> We already have various predicates to test for constant >> expressions so I am uneasy to add yet another one. > > I understand. I got lost in the number of existing predicates to test > for constant expression

Re: [PATCH] PR c++/55663 - constexpr function templ instantiation considered non-const as alias templ arg

2013-01-09 Thread Dodji Seketeli
Gabriel Dos Reis writes: > We already have various predicates to test for constant > expressions so I am uneasy to add yet another one. I understand. I got lost in the number of existing predicates to test for constant expressions, to the point that I thought (wrongly) the one I wanted wasn't

[testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

2013-01-09 Thread Alexander Ivchenko
Hi, We have test fail for gcc.dg/cpp/trad/include.c on Android. The reason for that is that -ftraditional-cpp is not expected to work on Android due to variadic macro (like #define __builtin_warning(x, y...)) in standard headers and traditional preprocessor cannot handle them. The attached pat

Commit: V850: Fix floating point comparisons, branches and conditional stores

2013-01-09 Thread Nick Clifton
Hi Guys, I am checking in the patch below to fix the V850's floating point comparison patterns, which was inverted in many places. The also includes a contribution from Nguyen Duy Dat at Renesas which adds floating point conditional store patterns and floating point conditional branch p

PR tree-optimization/55569 (profile updating ICE)

2013-01-09 Thread Jan Hubicka
Hi, this patch fixes problem with negative probabilities that result in overflow on ITERATION_BOUND parameter that is taken from niter code returning wider values than int. I went for gcov_type instead of HOST_WIDE_INT because it makes sense to derive the bounds from profile, too. Will commit it

Re: [PATCH] PR c++/55663 - constexpr function templ instantiation considered non-const as alias templ arg

2013-01-09 Thread Dodji Seketeli
Jason Merrill writes: > On 01/08/2013 08:58 AM, Dodji Seketeli wrote: >> There, when we check the argument 'the_truth()' to see if it >> actually is a constant expression, in check_instantiated_arg, we fail >> to recognize its constexpr-ness b/c we just look at its TREE_CONSTANT. > > The problem

Re: [C/C++ PATCH] shift with negative or too big count warning (PR c/48418)

2013-01-09 Thread Jason Merrill
The C++ change is OK. Jason

Re: [C++ Patch] PR 55801

2013-01-09 Thread Jason Merrill
OK. Jason

Re: PR 55875 (IV wrapping issue)

2013-01-09 Thread Jan Hubicka
> > Ugh. Both to stmt_dominates_stmt_p and to this (both use loops). > For stmt_dominates_stmt_p you'd simply use GIMPLE uids as other > passes do (and compute them, of course), for the above you'd > alongside of the UID store a sequence number that increments > at each stmt with side-effect. UI

Re: [committed] Update extract and insert patterns on PA

2013-01-09 Thread John David Anglin
Forgot this hunk in last change. Dave -- J. David Anglin dave.ang...@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) 2013-01-09 John David Anglin * config/pa/pa.c (pa_emit_move_sequence): Replace calls to

Re: [Patch, AArch64-4.7] Remove %r from asm_printf

2013-01-09 Thread Marcus Shawcroft
On 09/01/13 10:12, Hurugalawadi, Naveen wrote: Hi, It would be much appreciated if you would handle the back port to ARM/aarch64-4.7-branch Thanks for reviewing the patch and your comments. Please find attached the backported patch to ARM/aarch64-4.7-branch. Regressed for aarch64-elf on aarc

[PATCH] Fix PR55882

2013-01-09 Thread Richard Biener
This fixes PR55882 - set_mem_attributes_minus_bitpos misses to account for the to-be applied bitpos when computing MEM_ALIGN. It extracts alignment from 't' instead of &t - bitpos. Bootstrapped and tested on x86_64-unknown-linux-gnu, bootstrap and regtest running on mips. Does this look sensible

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2013-01-09 Thread Andreas Schwab
Alexandre Oliva writes: > +int > +main () > +{ > + int i; > + char c; > + char arr[11]; > + > + for (i = 0; i < 10; i++) > +{ > + c = 0x30 + i; > + foo (&arr[i], c); /* { dg-final { gdb-test 24 "i" "c - 48" } } */ > +} > + > + __builtin_printf ("arr = %s\n", arr); The stri

Re: [RFC PATCH] Implementing ifunc target hook

2013-01-09 Thread Alexander Ivchenko
Hello Maxim, >> --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -29146,7 +29146,7 @@ make_name (tree decl, const char *suffix, bool make_unique) return global_var_name; } -#if defined (ASM_OUTPUT_TYPE_DIRECTIVE) && HAVE_GNU_INDIRECT_FUNCTION

Re: PR tree-optimization/55823 (ipa-inline-transform ICE)

2013-01-09 Thread Martin Jambor
Hi, On Tue, Jan 08, 2013 at 02:32:24PM +0100, Richard Biener wrote: > On Tue, Jan 8, 2013 at 2:29 PM, Martin Jambor wrote: > > Hi, > > > > On Mon, Jan 07, 2013 at 01:26:23AM +0100, Jan Hubicka wrote: > >> Hi, > >> as discused in the PR log there seems to be ordering issue in > >> update_indirect_

Re: [PATCH] Yet another non-prototype builtin issue (PR middle-end/55890)

2013-01-09 Thread Jakub Jelinek
On Wed, Jan 09, 2013 at 11:11:13AM +0100, Tom de Vries wrote: > OK for trunk after I've tested this on mips64? Yes, thanks. > 2013-01-09 Tom de Vries > > PR middle-end/55890 > * calls.c (expand_call): Check if arg_nr is valid. > > Index: gcc/calls.c >

[Patch, AArch64-4.7] Remove %r from asm_printf

2013-01-09 Thread Hurugalawadi, Naveen
Hi, >> It would be much appreciated if you would >> handle the back port to ARM/aarch64-4.7-branch Thanks for reviewing the patch and your comments. Please find attached the backported patch to ARM/aarch64-4.7-branch. Regressed for aarch64-elf on aarch64-4.7-branch. Thanks, Naveen.H.S 2013-01

[PATCH] Yet another non-prototype builtin issue (PR middle-end/55890)

2013-01-09 Thread Tom de Vries
Richard, I've build r195008 for target mips64-linux-gnu with low optimization level ({CFLAGS,CXXFLAGS,BOOT_CFLAGS}='-g -O0'), and noticed failures for gcc.dg/torture/pr55890-{1,2,3}.c at -O0 and -O1 (which are not there without the low optimization level). The -O1 pr55890-1.c failure looks like t

Re: [PATCH] Allow x <- x, 1 in *vec_concatv2df (PR rtl-optimization/55829)

2013-01-09 Thread Uros Bizjak
On Tue, Jan 8, 2013 at 9:00 PM, Jakub Jelinek wrote: > No matter whether LRA (if it is a bug in there) is fixed or not, > *vec_concatv2df could handle for !avx sse3 x <- x, 1 alternative the same > as it handles x <- m, 1 alternative (using movddup). > > Bootstrapped/regtested on x86_64-linux and

Re: PR 55875 (IV wrapping issue)

2013-01-09 Thread Richard Biener
On Tue, 8 Jan 2013, Jan Hubicka wrote: > Hi, > here is even more updated patch, this time really fixing the testcase, I hope > ;) > It turns out there is one extra problem in tree-ssa-loop-niter.c triggered by > that code. Some bounds, like one based on inequality test or with wrapping > IVs are

Re: [PATCH] predict_loop fix (PR tree-optimization/48189)

2013-01-09 Thread Richard Biener
On Tue, 8 Jan 2013, Jakub Jelinek wrote: > Hi! > > This is Steven's patch from the PR plus mine hunk, bootstrapped/regtested on > x86_64-linux and i686-linux, ok for trunk? Ok. Thanks, Richard. > 2013-01-08 Steven Bosscher > Jakub Jelinek > > PR tree-optimization/48189 >

Re: Control dependence vs. builtin_unreachable

2013-01-09 Thread Richard Biener
On Tue, Jan 8, 2013 at 5:16 PM, Jeff Law wrote: > On 01/08/2013 04:26 AM, Richard Biener wrote: > >> >> The issue is VRP - when you remove unreachable blocks you lose the >> conditional statement as it is no longer necessary and thus the predicate >> you can derive value-ranges from. > > Understoo

Re: [PATCH] Adding target rdos to GCC

2013-01-09 Thread Richard Biener
On Wed, 9 Jan 2013, Uros Bizjak wrote: > On Tue, Jan 8, 2013 at 9:32 PM, Leif Ekblad wrote: > > After some new suggestions from Uros, I've made a new diff. > > > > > > Change log: > > * config/gthr.m4: Added rdos thread header. > > * gcc/config/i386/i386.c: Provided a way to define a default sett

Re: [PATCH] Fix PR54659, include gmp.h from system.h

2013-01-09 Thread Richard Biener
On Tue, 8 Jan 2013, H.J. Lu wrote: > On Fri, Dec 21, 2012 at 5:14 AM, Richard Biener wrote: > > > > After the Ada fix including gmp.h from system.h is trivial > > (by means of double-int.h it was included from almost everywhere > > already) > > > > Bootstrapped on x86_64-unknown-linux-gnu, testin