Re: PR 56524: TREE_OPTIMIZATION_OPTABS vs. mips16

2013-03-08 Thread Richard Sandiford
Jakub Jelinek writes: > So I think the > > if (TREE_OPTIMIZATION_OPTABS (optnode)) > ggc_free (TREE_OPTIMIZATION_OPTABS (optnode)); > > has to be removed (of course the second ggc_free, if memcmp returned 0, is > desirable). *blush*. Thanks for catching that. > Otherwise looks goo

Re: [PATCH] MIPS: MIPS32r2 FP MADD instruction set support

2013-03-08 Thread Maciej W. Rozycki
On Thu, 21 Feb 2013, Mike Stump wrote: > > BTW, do you happen to know a way to reliable force all our testsuites NOT > > to delete executables after run? Personally I think it's missing the > > point to have them deleted -- how can one debug any regressions then? > > So, I go into the source a

[C++ testcase, committed] PR 56565

2013-03-08 Thread Paolo Carlini
Hi, I'm adding the testcase and closing the PR as fixed. Thanks, Paolo. // 2013-03-08 Paolo Carlini PR c++/56565 * g++.dg/cpp0x/lambda/lambda-nsdmi2.C: New. Index: g++.dg/cpp0x/lambda/lambda-nsdmi2.C ===

[v3] bits/memoryfwd.h

2013-03-08 Thread Benjamin De Kosnik
Hey y'all. I noticed the repeated, repeated, repeated use of std::allocator forward decls as I was trying to debug some doxygen output. Clearly, it's past time for a memory forward header, like bits/stringfwd.h. The following patch implements this. Perhaps some of the other headers can now be o

Re: Fix vector C++11 allocator bug

2013-03-08 Thread Jonathan Wakely
On 8 March 2013 20:16, François Dumont wrote: > On 03/07/2013 11:46 PM, Jonathan Wakely wrote: >> >> As expected it works for vector/swap.cc too. So we definitely need the bug >> fix to std::vector::operator= and the testsuite changes to add elements, but >> I think I'd prefer to just re-swap the c

[lra] Merged with trunk

2013-03-08 Thread Vladimir Makarov
LRA branch has been merged with trunk @ 196555. The branch was successfully bootstrapped on x86/x86-64. Committed as rev. 196556.

Re: Fix vector C++11 allocator bug

2013-03-08 Thread François Dumont
On 03/07/2013 11:46 PM, Jonathan Wakely wrote: As expected it works for vector/swap.cc too. So we definitely need the bug fix to std::vector::operator= and the testsuite changes to add elements, but I think I'd prefer to just re-swap the containers in the non-propagating case. This is indeed

Re: do not pass PR_INSTRUMENTEDCODE if there is no instrumentation

2013-03-08 Thread Richard Henderson
On 02/27/2013 08:43 AM, Aldy Hernandez wrote: > + * trans-mem.c (expand_transaction): Do not set PR_INSTRUMENTEDCODE > + if GTMA_HAS_NO_INSTRUMENTATION. > + (generate_tm_state): Keep GTMA_HAS_NO_INSTRUMENTATION bit. > + (ipa_tm_transform_transaction): Set GTMA_HAS_NO_INSTRUMENTATION

Re: [google/gcc-4_7-mobile] Cherry-pick 196555 - fix broken dependency

2013-03-08 Thread Dehao Chen
Looks good. Dehao On Fri, Mar 8, 2013 at 11:07 AM, Han Shen(沈涵) wrote: > Hi Ahmad and Dehao, gcc-4_7-mobile branch needs 196555 patch to fix > broken dependency when bootstrapping host compiler for chromeos. > > Could you take a look, thanks! > > -Han > > Patch here >> > diff --git a/gcc/Makefil

[google/gcc-4_7-mobile] Cherry-pick 196555 - fix broken dependency

2013-03-08 Thread 沈涵
Hi Ahmad and Dehao, gcc-4_7-mobile branch needs 196555 patch to fix broken dependency when bootstrapping host compiler for chromeos. Could you take a look, thanks! -Han Patch here >> diff --git a/gcc/Makefile.in b/gcc/Makefile.in index c180f31..82b 100644 --- a/gcc/Makefile.in +++ b/gcc/Make

Re: [GOOGLE] Fix incorrect dependency in Makefile.in

2013-03-08 Thread Xinliang David Li
ok. David On Thu, Mar 7, 2013 at 5:36 PM, Dehao Chen wrote: > This patch fixes the incorrect dependency in Makefile.in. > > Bootstrapped and passed regression test. > > Okay for google-4_7 branch? > > Thanks, > DehaoIndex: > > gcc/Makefile.in > ===

[lra] patch to fix s390 building

2013-03-08 Thread Vladimir Makarov
It was about 9 months since I checked LRA for s390 last time. No wonder, that it is completely broken. The following patch at least permits to build s390 GCC with LRA. The patch was successfully bootstrapped on x864/x86-64, ppc64, and ia64. Committed as rev. 196553. 2013-03-08 Vladimir Maka

Re: [PATCH] Fix install-plugin with vxworks-dummy.h (PR plugins/45078)

2013-03-08 Thread Jakub Jelinek
On Wed, Mar 06, 2013 at 01:44:28PM +0100, Jakub Jelinek wrote: > On Wed, Mar 06, 2013 at 06:57:03PM +0800, Matthias Klose wrote: > > There is still vxworks-dummy.h, which is not installed, see PR45078. Would > > the > > same approach work? > > Like this? Untested though, and no access to most of

Re: r196201 - in /trunk: gcc/ChangeLog gcc/config/i...

2013-03-08 Thread Jakub Jelinek
On Fri, Feb 22, 2013 at 01:58:09PM +0100, Jakub Jelinek wrote: > 2013-02-22 Jakub Jelinek > > PR sanitizer/56393 > * config/gnu-user.h (LIBASAN_EARLY_SPEC): Link in libasan_preinit.o > if not linking a shared library. > > --- gcc/config/gnu-user.h.jj 2013-02-05 16:55:01.

C++ PATCH for various lambda bugs (51494, 51884, 56222, 51884)

2013-03-08 Thread Jason Merrill
The first two patches deal with issues with 'this' capture; we were inappropriately capturing 'this' for uses of static members and forming pointers to members, and for uses in unevaluated context. The last patch avoids a crash from recursive use of dfs_walk when instantiating a class with vir

C++ PATCH for c++/56567 (ICE with lambda returning init-list)

2013-03-08 Thread Jason Merrill
My initial proposal for allowing general return type deduction allowed deduction of std::initializer_list, which is not permitted by C++11. But this doesn't make sense, because the underlying array will immediately leak, so we should just give an error even in C++1y. Tested x86_64-pc-linux-gnu

Re: [PATCH] track heap usage with -fmem-report

2013-03-08 Thread Richard Biener
On Fri, 8 Mar 2013, Andi Kleen wrote: > Richard Biener writes: > > > This hacky patch tracks per-pass heap usage with -fmem-report > > using glibc malloc hooks (which are deprecated!? eh ... I can > > see no replacement?) > > > > Still somewhat broken accounting for the overall numbers > > (an

Re: [C++ Patch] PR 51412

2013-03-08 Thread Jason Merrill
OK. Jason

Re: [PATCH] track heap usage with -fmem-report

2013-03-08 Thread Andi Kleen
Richard Biener writes: > This hacky patch tracks per-pass heap usage with -fmem-report > using glibc malloc hooks (which are deprecated!? eh ... I can > see no replacement?) > > Still somewhat broken accounting for the overall numbers > (and peak memory use, that is). > > But it's a start. And

Re: [PATCH] Fix PR56478

2013-03-08 Thread Marek Polacek
Here's a final version. I've used !compare_step.is_negative (). Moreover, sanity checked by printing out old and new probability and comparing them after check-gcc. So this should be prety safe now. I will apply the patch shortly. 2013-03-08 Marek Polacek Jakub Jelinek

Re: [patch testsuite]: Fix gcc.target/i386 cases for mingw-targets

2013-03-08 Thread Rainer Orth
Hi Kai, >>> Index: gcc.target/i386/pr20020-1.c >>> === >>> --- gcc.target/i386/pr20020-1.c (Revision 196507) >>> +++ gcc.target/i386/pr20020-1.c (Arbeitskopie) >>> @@ -1,5 +1,6 @@ >>> /* Check that 128-bit struct's are re

Re: [patch testsuite]: Fix gcc.target/i386 cases for mingw-targets

2013-03-08 Thread Kai Tietz
2013/3/8 Rainer Orth : > Hi Kai, > > some comments; I'll leave approval to a target maintainer. > >> Index: gcc.target/i386/movti.c >> === >> --- gcc.target/i386/movti.c (Revision 196507) >> +++ gcc.target/i386/movti.c (Arbeitskopi

Re: [PATCH] Another BLOCK issue - PR56570

2013-03-08 Thread Richard Biener
On Fri, 8 Mar 2013, Jakub Jelinek wrote: > On Fri, Mar 08, 2013 at 01:59:23PM +0100, Richard Biener wrote: > > This PR shows that when SRA creates DECL_DEBUG_EXPRs with locations > > (and blocks) this does not work with inlining. The reason is that > > the inliner does not bother to copy vars use

Re: [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets

2013-03-08 Thread Kai Tietz
2013/3/8 Rainer Orth : > Hi Kai, > >> Index: builtins.exp >> === >> --- builtins.exp(Revision 196543) >> +++ builtins.exp(Arbeitskopie) >> @@ -42,6 +42,7 @@ if [istarget "powerpc-*-darwin*"] { >> lappend additional_

Re: [PATCH] Fix PR56478

2013-03-08 Thread Richard Biener
On Fri, Mar 8, 2013 at 1:30 PM, Jakub Jelinek wrote: > On Fri, Mar 08, 2013 at 01:16:37PM +0100, Marek Polacek wrote: >> --- gcc/predict.c.mp 2013-03-07 20:01:01.078417558 +0100 >> +++ gcc/predict.c 2013-03-08 11:35:05.227603993 +0100 >> @@ -1028,13 +1028,13 @@ static bool >> is_comparison_w

Re: [PATCH] Another BLOCK issue - PR56570

2013-03-08 Thread Jakub Jelinek
On Fri, Mar 08, 2013 at 01:59:23PM +0100, Richard Biener wrote: > This PR shows that when SRA creates DECL_DEBUG_EXPRs with locations > (and blocks) this does not work with inlining. The reason is that > the inliner does not bother to copy vars used only in lhs of > debug-stmts (eek) and thus ends

[PATCH] Another BLOCK issue - PR56570

2013-03-08 Thread Richard Biener
This PR shows that when SRA creates DECL_DEBUG_EXPRs with locations (and blocks) this does not work with inlining. The reason is that the inliner does not bother to copy vars used only in lhs of debug-stmts (eek) and thus ends up sharing DECL_DEBUG_EXPRs (and not re-mapping them and their locatio

Re: [PATCH] Fix PR56478

2013-03-08 Thread Jakub Jelinek
On Fri, Mar 08, 2013 at 01:16:37PM +0100, Marek Polacek wrote: > --- gcc/predict.c.mp 2013-03-07 20:01:01.078417558 +0100 > +++ gcc/predict.c 2013-03-08 11:35:05.227603993 +0100 > @@ -1028,13 +1028,13 @@ static bool > is_comparison_with_loop_invariant_p (gimple stmt, struct loop *loop, >

Re: [patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets

2013-03-08 Thread Rainer Orth
Hi Kai, > Index: builtins.exp > === > --- builtins.exp(Revision 196543) > +++ builtins.exp(Arbeitskopie) > @@ -42,6 +42,7 @@ if [istarget "powerpc-*-darwin*"] { > lappend additional_flags "-Wl,-multiply_defined,sup

[patch testsuite]: Fix regressions in gcc-c-torture's builtin-tests using LTO on mingw-targets

2013-03-08 Thread Kai Tietz
Hello, this patch fixes 23 regressions about LTO and double-defined symbols for memcpy/memset. Issue is that for mingw-targets the C-runtime functions aren't weak and not necessarily overridable. ChangeLog 2013-03-08 Kai Tietz * gcc.c-torture/execute/builtins/builtins.exp: Add for m

Re: [PATCH] Fix PR56478

2013-03-08 Thread Marek Polacek
On Thu, Mar 07, 2013 at 03:25:35PM +0100, Jakub Jelinek wrote: > On Tue, Mar 05, 2013 at 10:07:50AM +0100, Marek Polacek wrote: > > + if (compare_count.scmp (double_int_zero) == -1) > > +compare_count = double_int_zero; > > + if (loop_count.scmp (double_int_zero) == -1) > > +

[C++ Patch] PR 51412

2013-03-08 Thread Paolo Carlini
Hi, today I noticed that I still have assigned this rather simple diagnostic issue, where LAMBDA_EXPR is unhandled by our pretty printing code. I suppose we can make at least some progress for 4.8.0. Is the below goo enough for now? Tested x86_64-linux. Thanks, Paolo. /

Re: [PATCH] Fix another BLOCK issue

2013-03-08 Thread Jakub Jelinek
On Fri, Mar 08, 2013 at 11:24:40AM +0100, Richard Biener wrote: > > This fixes the fact that the inliner now associates a BLOCK > with BLOCK_SOURCE_LOCATION but we don't dare to keep that BLOCK > live when removing unused block scopes. Adding location verification > for BLOCK_SOURCE_LOCATION show

[PATCH] Fix another BLOCK issue

2013-03-08 Thread Richard Biener
This fixes the fact that the inliner now associates a BLOCK with BLOCK_SOURCE_LOCATION but we don't dare to keep that BLOCK live when removing unused block scopes. Adding location verification for BLOCK_SOURCE_LOCATION shows this immediately during bootstrap. The obvious fix for this is the tree

Re: [patch testsuite]: Fixes in gcc.dg for mingw-targets

2013-03-08 Thread Rainer Orth
Hi Kai, > Index: gcc.dg/torture/pr53922.c > === > --- gcc.dg/torture/pr53922.c (Revision 196507) > +++ gcc.dg/torture/pr53922.c (Arbeitskopie) > @@ -1,5 +1,6 @@ > /* { dg-do run } */ > /* { dg-require-weak "" } */ > +/* { dg-skip-

Re: [patch testsuite]: Fix gcc.target/i386 cases for mingw-targets

2013-03-08 Thread Rainer Orth
Hi Kai, some comments; I'll leave approval to a target maintainer. > Index: gcc.target/i386/movti.c > === > --- gcc.target/i386/movti.c (Revision 196507) > +++ gcc.target/i386/movti.c (Arbeitskopie) > @@ -7,4 +7,4 @@ _Decimal128

Re: [PATCH] Fix -print-multi-os-directory for aarch64

2013-03-08 Thread Jakub Jelinek
On Fri, Mar 08, 2013 at 09:04:19AM +, Marcus Shawcroft wrote: > On 07/03/13 16:45, Jakub Jelinek wrote: > >On Thu, Mar 07, 2013 at 08:29:06AM -0800, Andrew Pinski wrote: > >>On Thu, Mar 7, 2013 at 3:15 AM, Jakub Jelinek wrote: > >>>AFAIK aarch64 libraries are supposed to go into /usr/lib64 etc

Re: [PATCH] Fix -print-multi-os-directory for aarch64

2013-03-08 Thread Marcus Shawcroft
On 07/03/13 16:45, Jakub Jelinek wrote: On Thu, Mar 07, 2013 at 08:29:06AM -0800, Andrew Pinski wrote: On Thu, Mar 7, 2013 at 3:15 AM, Jakub Jelinek wrote: AFAIK aarch64 libraries are supposed to go into /usr/lib64 etc. directories similarly to x86-64 etc., but as aarch64 isn't a true multilib

[arm/embedded-4_7-branch] Merge with gcc-4_7-branch r196534

2013-03-08 Thread Joey Ye
Committed as r196535.

Re: [PATCH, updated] Vtable pointer verification, runtime library changes (patch 3 of 3)

2013-03-08 Thread Dave Korn
On 08/03/2013 00:11, Jonathan Wakely wrote: > On 7 March 2013 23:53, Caroline Tice wrote: >> I believe this patch addresses all of your comments; I modified the >> configure.ac files to generate the configures, and I fixed the >> spelling mistakes in the comments. I still get the warnings when >>

[Ada] Further tweak for PR ada/52123

2013-03-08 Thread Eric Botcazou
Tested by Cesar on i686-pc-mingw32, applied on mainline and 4.7 branch. 2013-03-08 Cesar Strauss PR ada/52123 * seh_init.c (Raise_From_Signal_Handler): Declare as no-return. (__gnat_SEH_error_handler): Likewise. Remove final return. -- Eric BotcazouIndex: seh_init.