Re: [Patch, ARM] Enable libsanitizer

2013-03-28 Thread Konstantin Serebryany
+euge...@google.com Hi Christophe, On Thu, Mar 28, 2013 at 2:09 AM, Christophe Lyon christophe.l...@linaro.org wrote: Hi, This small patch enables libsanitizer on ARM. It has been tested successfully on cortex-a9 hardware (via the GCC testsuite). I have chosen to bundle -funwind-table with

Re: [Patch, ARM] Enable libsanitizer

2013-03-28 Thread Evgeniy Stepanov
On Thu, Mar 28, 2013 at 11:36 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: +euge...@google.com Hi Christophe, On Thu, Mar 28, 2013 at 2:09 AM, Christophe Lyon christophe.l...@linaro.org wrote: Hi, This small patch enables libsanitizer on ARM. It has been tested

Re: [Patch, ARM] Enable libsanitizer

2013-03-28 Thread Jakub Jelinek
On Thu, Mar 28, 2013 at 12:00:23PM +0400, Evgeniy Stepanov wrote: We do it because newer versions of Android use PIE binaries, and, combined with other specifics of address space on Linux/ARM, there is no space for ASan shadow anywhere else. And it's faster. Zero-based shadow requires PIE.

Re: [PATCH] Fix PR56695 + adjust verify_gimple_comparison

2013-03-28 Thread Richard Biener
On Wed, 27 Mar 2013, Marek Polacek wrote: This fixes PR56695 where we ICEd because expand_vec_cond_expr doesn't expect that the result of a vector comparison is of TYPE_UNSIGNED type. So we unconditionally build a signed type now. We know that the result of vec comparison is e.g. { -1, 0,

Re: [patch] Unified debug dump function names.

2013-03-28 Thread Richard Biener
On Wed, Mar 27, 2013 at 5:15 PM, Lawrence Crowl cr...@googlers.com wrote: On 3/27/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 27, 2013, Lawrence Crowl cr...@googlers.com wrote: Patch with rename to debug attached. Tested on x86_64. Add uniform debug dump function names.

Re: [patch] Fix node weight updates during ipa-cp (issue7812053)

2013-03-28 Thread Richard Biener
On Wed, Mar 27, 2013 at 6:22 PM, Teresa Johnson tejohn...@google.com wrote: I found that the node weight updates on cloned nodes during ipa-cp were leading to incorrect/insane weights. Both the original and new node weight computations used truncating divides, leading to a loss of total node

Re: [patch] Use JUMP_TABLE_DATA_P instead of JUMP_P and GET_CODE tests

2013-03-28 Thread Richard Biener
On Thu, Mar 28, 2013 at 12:16 AM, Steven Bosscher stevenb@gmail.com wrote: *Ping* Ok. Thanks, Richard. On Sat, Mar 23, 2013 at 5:15 PM, Steven Bosscher wrote: Hello, This patch replaces all tests I could find, where the code is looking for jump table data with GET_CODE(..)=ADDR_VEC

Re: [patch] Hash table changes from cxx-conversion branch

2013-03-28 Thread Richard Biener
On Wed, Mar 27, 2013 at 5:44 PM, Lawrence Crowl cr...@googlers.com wrote: On 3/27/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 23, 2013 Lawrence Crowl cr...@googlers.com wrote: This patch is a consolodation of the hash_table patches to the cxx-conversion branch. Update

[Patch, Fortran] PR56737 - Fixing a bug in the I/O format cache handling

2013-03-28 Thread Tobias Burnus
libgfortran parses the format string for formatted I/O and saves it in an internal representation. To speed up the I/O - for instance in a loop -, caching is used. However, a pointer to format string is used for the processing of strings (normal string constants and Hollerith). That works

Re: [Patch, Fortran] PR56737 - Fixing a bug in the I/O format cache handling

2013-03-28 Thread Tobias Burnus
Tobias Burnus wrote: b) To copy the format string The attached patch does the latter. The current hashing algorithm avoids hash collisions by checking whether the value is exactly the same - and the value is given by the format string. Thus, instead of copying the string when storing the

Re: [PATCH] Fix PR56694

2013-03-28 Thread Tejas Belagod
Richard Biener wrote: This fixes PR56694 - the code keeping BLOCKs live is not looking at the EH tree for references. In the must-not-throw failure_loc such references can now appear. Fixed by reverting that to 4.7 behavior. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to

Re: [PATCH] Fix PR56694

2013-03-28 Thread Richard Biener
On Thu, 28 Mar 2013, Tejas Belagod wrote: Richard Biener wrote: This fixes PR56694 - the code keeping BLOCKs live is not looking at the EH tree for references. In the must-not-throw failure_loc such references can now appear. Fixed by reverting that to 4.7 behavior. Bootstrapped

Re: [patch i386 windows]: Fix PR/52790 also required for workig upcoming cygwin x64 target

2013-03-28 Thread Kai Tietz
Ping

C++ PATCH: use C++ semantics for inline functions (defined in headers)

2013-03-28 Thread Gabriel Dos Reis
C++ has a much more predictable semantics for inline functions, so we no longer need to define them (especially in header files) with the 'static' specifier. The upshot is that when the compiler fails to inline a call in a given translation unit, it keeps only one copy in the entire program,

[Patch, Fortran] PR56735 - Fix namelist read regression with ?

2013-03-28 Thread Tobias Burnus
gfortran supports ? and =? as input with namelists (a somewhat common vendor extension). Either of those can be used with stdin to print the available fields of the namelist. With non-stdin input, the ? and =? lines are simply ignored. However, two patches, one in 2008 and one in 2011 broke

[C++ Patch] PR 56725

2013-03-28 Thread Paolo Carlini
Hi, in this PR Tom noticed that we are producing weird extra initial spaces in some error messages and Manuel replied that in fact those messages should rather be inform. Per Manuel suggestion, I therefore adjusted call.c in that sense but then noticed that eg, across rv1n.C, we were

Re: patch to fix constant math - third patch - what is left for next stage 1

2013-03-28 Thread Kenneth Zadeck
committed as revision 197198 kenny On 03/27/2013 10:19 AM, Richard Biener wrote: On Wed, Feb 27, 2013 at 1:37 AM, Kenneth Zadeck zad...@naturalbridge.com wrote: the original patch 3 was accepted and committed. These were subsequent comments. This could likely be just checked in the next

[wwwdocs] Adjust power.org reference in readings.html

2013-03-28 Thread Gerald Pfeifer
Applied. Gerald Index: readings.html === RCS file: /cvs/gcc/wwwdocs/htdocs/readings.html,v retrieving revision 1.222 diff -u -3 -p -r1.222 readings.html --- readings.html 27 Mar 2013 22:10:04 - 1.222 +++ readings.html

Re: [Patch, ARM] Enable libsanitizer

2013-03-28 Thread Christophe Lyon
Note that the testsuite currently fails when executing under qemu: - support of /proc/self/maps does not conform to the kernel format. One extra space is missing from some lines, which confuses libsanitizer. Patch proposed to upstream qemu:

Re: patch to fix constant math - second small patch -patch ping for next stage 1

2013-03-28 Thread Kenneth Zadeck
committed as revision 197200. kenny On 03/27/2013 11:07 AM, Richard Biener wrote: On Wed, Mar 27, 2013 at 3:23 PM, Kenneth Zadeck zad...@naturalbridge.com wrote: On 03/27/2013 10:18 AM, Richard Biener wrote: On Wed, Feb 27, 2013 at 1:27 AM, Kenneth Zadeck zad...@naturalbridge.com wrote:

Re: [C++ Patch] PR 56725

2013-03-28 Thread Paolo Carlini
.. oops, the patch I attached has a typo. This is the right one. Paolo. // Index: cp/call.c === --- cp/call.c (revision 197198) +++ cp/call.c (working copy) @@ -5836,11 +5836,11 @@ convert_like_real

Re: [PATCH, AArch64] Make MOVK output operand 2 in hex

2013-03-28 Thread Marcus Shawcroft
On 20/03/13 17:21, Ian Bolton wrote: MOVK should not be generated with a negative immediate, which the assembler rightfully rejects. This patch makes MOVK output its 2nd operand in hex instead. Tested on bare-metal and linux. OK for trunk? Cheers, Ian 2013-03-20 Ian Bolton

Re: patch to fix constant math - first small patch - patch ping for the next stage 1

2013-03-28 Thread Kenneth Zadeck
richard, adding the gcc_checking_assert is going to require that i include system.h in hwint.h which seems to cause a loop. while in principle, i agree with the assert, this is going to be a mess. kenny On 03/27/2013 10:13 AM, Richard Biener wrote: On Wed, Feb 27, 2013 at 1:22 AM,

Re: [C++ Patch] PR 56725

2013-03-28 Thread Jason Merrill
Ok. Jason

[PATCH] Fix PR56756

2013-03-28 Thread Richard Biener
The domwalker fix to order dom children after inverted postorder exposed the latent issue that LIM relies on domwalk to walk all blocks defining SSA names before all blocks using them ... which is what the following patch tries to fix using the dependency information it already tracks (but

Stream stmt histograms for LTO

2013-03-28 Thread Jan Hubicka
Hi, this patch adds streaming of histograms that did not make it into LTO previously. This restores some optimizations, such as specialization of memcpy/memset inline code for expected sizealignment of the block. I also added specialzed streaming functions for gcov counters. They may be wider

Re: extend fwprop optimization

2013-03-28 Thread Uros Bizjak
On Thu, Mar 28, 2013 at 5:34 AM, Wei Mi w...@google.com wrote: I am not familiar how to use define_subst, so I write a patch that changes define_insn_and_split to define_insn. bootstrapped and regression tested on x86_64-unknown-linux-gnu. A question is: after that change, Is there anyway I

Re: *ping* [patch, fortran, 4.9] Dependency and string length calculation improvements

2013-03-28 Thread Thomas Koenig
I wrote: Ping**2? I'd like to get these patches committed, if possible, to clear up my trees a little bit :-) Thomas *ping* Slightly updated patch below, with a better test case as suggested by Dominique. OK for trunk? 2013-03-16 Thomas Koenig tkoe...@gcc.gnu.org PR

Re: [patch, fortran, 4.9] Improve efficiency of array constructor operators

2013-03-28 Thread Thomas Koenig
Am 26.03.2013 18:17, schrieb Thomas Koenig: Hi Tobias, I have not yet looked at the patch, but I wonder whether that causes invalid code for if (any([a,b,c] f())) by evaluating f() multiple times. This is avoided by this part of the patch: + if (op2-expr_type == EXPR_CONSTANT) +

[patch] cilkplus: Array notation for C patch

2013-03-28 Thread Iyer, Balaji V
Hello Joseph, Aldy et al., Attached, please find a fixed patch (bzipped) that implements array notation for C. To my best knowledge, I have fixed all the changes Joseph and Aldy have mentioned in the previous email threads (http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01182.html,

[AARCH64] Add SHORT scalar move

2013-03-28 Thread Sofiane Naci
Hi, This patch adds support in AArch64 for scalar moves to and from vector registers in SHORT modes. This has been tested with a full regression run on aarch64-elf. OK for trunk and 4.8? Thanks Sofiane - 2013-03-28 Sofiane Naci sofiane.n...@arm.com * config/aarch64/aarch64.md

[AARCH64] Add SHORT scalar load/store using B/H registers

2013-03-28 Thread Sofiane Naci
Hi, This patch adds support in AArch64 for scalar loads and stores to and from B/H registers. This has been tested with a full regression run on aarch64-elf. OK for trunk and 4.8? Thanks Sofiane - 2013-03-28 Sofiane Naci sofiane.n...@arm.com * config/aarch64/aarch64.md

Re: [PING^1] [AArch64] Implement Bitwise AND and Set Flags

2013-03-28 Thread Marcus Shawcroft
On 26/03/13 11:35, Hurugalawadi, Naveen wrote: Hi, Can we split them into two different patches. Just and in one Thanks for reviewing the patch. I have split the patches for and separately as per your suggestion. Thanks, I've adjusted the patch to use the SHIFT iterator instead of ASHIFT

Re: [AARCH64] Add SHORT scalar move

2013-03-28 Thread Marcus Shawcroft
On 28/03/13 17:15, Sofiane Naci wrote: Hi, This patch adds support in AArch64 for scalar moves to and from vector registers in SHORT modes. This has been tested with a full regression run on aarch64-elf. OK for trunk and 4.8? OK for trunk. /Marcus

Re: [AARCH64] Add SHORT scalar load/store using B/H registers

2013-03-28 Thread Marcus Shawcroft
On 28/03/13 17:15, Sofiane Naci wrote: Hi, This patch adds support in AArch64 for scalar loads and stores to and from B/H registers. This has been tested with a full regression run on aarch64-elf. OK for trunk and 4.8? OK for trunk. /Marcus

Re: *ping* [patch, fortran, 4.9] Dependency and string length calculation improvements

2013-03-28 Thread Tobias Burnus
Thomas Koenig wrote: below is a patch which improves dependency checking for array assignments and calculation of string lengths. Talking about dependencies, I wonder whether you would be interested implementing the function bool gfc_simply_noncontiguous (gfc_expr *); or something

[PATCH AArch64] Make omit-frame-pointer work correctly

2013-03-28 Thread Ian Bolton
Currently, if you compile with -fomit-frame-pointer, the frame record and frame pointer are still maintained (i.e. There is no way to get the behaviour you are asking for!). This patch fixes that. It also makes sure that if you ask for no frame pointers in leaf functions then they are not

C++ PATCH for c++/56728 (ICE with bogus constexpr function)

2013-03-28 Thread Jason Merrill
In this testcase we were crashing because after function argument substitution in the initialization for crashnkill we couldn't figure out how to simplify *(Inner*)4, so we went back to bridge2. It certainly doesn't make sense for the initializer to refer to a parameter for a function called

C++ PATCH for c++/56710 (ICE with local variable __t in lambda)

2013-03-28 Thread Jason Merrill
The compiler was getting confused when an implicit capture added a __t class binding and then tried to pop the __t local variable. But we don't need to push the closure members as bindings at all, since we now use capture proxies for name resolution. The second patch fixes a -Wshadow issue I

C++ PATCH for c++/56701 (treating 'this' as an rvalue)

2013-03-28 Thread Jason Merrill
When 'this' appears in an expression, it should be an rvalue rather than a const lvalue; in C++11, the distinction matters. The cp_build_indirect_ref change is to avoid building extra copies of *this due to this change. Tested x86_64-pc-linux-gnu, applying to trunk. commit

C++ PATCH for c++/56679 (sizeof... of template template parameter pack)

2013-03-28 Thread Jason Merrill
The only valid operand for sizeof... is a single identifier, so it doesn't really make sense to share code with other forms of sizeof. Tested x86_64-pc-linux-gnu, applying to trunk. commit 8a4393fa57437072d140065b5949e3aa9c4674d6 Author: Jason Merrill ja...@redhat.com Date: Wed Mar 27

Re: C++ PATCH for c++/52748 (N3276 change to decltype of function call)

2013-03-28 Thread Jason Merrill
The change to force instantiation to check for abstract return types broke this change; until the core SG has a chance to discuss the language inconsistency, I'm going to disable that instantiation in decltype context. Tested x86_64-pc-linux-gnu, applying to trunk. commit

[PATCH 9/n, i386]: Merge *vec_extractv2di_1_rex64 with base pattern using x64 isa attribute

2013-03-28 Thread Uros Bizjak
Hello! 2013-03-28 Uros Bizjak ubiz...@gmail.com * config/i386/i386.md (*vec_extract2vdi_1): Merge with *vec_extractv2di_1_rex64. Use x64 isa attribute. Tested on x86_64-pc-linux-gnu {,-m32} and committed to mainline SVN. Uros. Index: sse.md

Re: [patch, fortran, 4.9] Improve efficiency of array constructor operators

2013-03-28 Thread Tobias Burnus
On 28.03.2013 17:11, Thomas Koenig wrote: Am 26.03.2013 18:17, schrieb Thomas Koenig: Hi Tobias, I have not yet looked at the patch, but I wonder whether that causes invalid code for if (any([a,b,c] f())) by evaluating f() multiple times. This is avoided by this part of the patch: [...]

Re: [AArch64] Bitwise adds and subs instructions with shift

2013-03-28 Thread Marcus Shawcroft
Hi, I'm not sure how good the coverage is from these test cases On 26/03/13 11:42, Hurugalawadi, Naveen wrote: (define_insn *addmode3_compare0 [(set (reg:CC_NZ CC_REGNUM) (compare:CC_NZ -(plus:GPI (match_operand:GPI 1 register_operand %r,r) +(plus:GPI

Re: [PATCH AArch64] Make omit-frame-pointer work correctly

2013-03-28 Thread Marcus Shawcroft
On 28/03/13 17:55, Ian Bolton wrote: Currently, if you compile with -fomit-frame-pointer, the frame record and frame pointer are still maintained (i.e. There is no way to get the behaviour you are asking for!). This patch fixes that. It also makes sure that if you ask for no frame pointers in

Re: *ping* [patch, fortran, 4.9] Dependency and string length calculation improvements

2013-03-28 Thread Mikael Morin
Le 28/03/2013 18:48, Tobias Burnus a écrit : Talking about dependencies, I wonder whether you would be interested implementing the function bool gfc_simply_noncontiguous (gfc_expr *); or something similarly named. It should return true, if the expression is known to be noncontiguous. I

Re: [patch, fortran, 4.9] Improve efficiency of array constructor operators

2013-03-28 Thread Thomas Koenig
Hi Tobias, I have committed the two approved patches, with the issues that you have noted fixed. Thanks a lot for the reviews! PS: Regarding the string comparison patch: As Janne, think it should be fine with also supporting kind=4 (don't forget to multiply the length by the kind, e.g.

Re: *ping* [patch, fortran, 4.9] Dependency and string length calculation improvements

2013-03-28 Thread Thomas Koenig
Hi Tobias, Talking about dependencies, I wonder whether you would be interested implementing the function bool gfc_simply_noncontiguous (gfc_expr *); or something similarly named. If you will work on it, please tell me - Sounds interesting. I'll give it a shot. Thomas

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

2013-03-28 Thread Segher Boessenkool
I'd suggest rewriting this expression in some easier way: p += (*p == '%' *(p + 1)) ? 2 : 1; I'd prefer if (*p == '%') p++; p++; That's not the same thing though. Maksim's code is correct, although it could certainly be written more

Re: [Patch, Fortran] PR56737 - Fixing a bug in the I/O format cache handling

2013-03-28 Thread Jerry DeLisle
On 03/28/2013 03:21 AM, Tobias Burnus wrote: Tobias Burnus wrote: b) To copy the format string The attached patch does the latter. The current hashing algorithm avoids hash collisions by checking whether the value is exactly the same - and the value is given by the format string. Thus,

Re: [Patch, Fortran] PR56735 - Fix namelist read regression with ?

2013-03-28 Thread Jerry DeLisle
On 03/28/2013 06:48 AM, Tobias Burnus wrote: gfortran supports ? and =? as input with namelists (a somewhat common vendor extension). Either of those can be used with stdin to print the available fields of the namelist. With non-stdin input, the ? and =? lines are simply ignored.

[c++-concepts] Merge from trunk

2013-03-28 Thread Gabriel Dos Reis
The trunk was merged into the c++-concepts branch as of revision 197225. -- Gaby

Re: [patch] Unified debug dump function names.

2013-03-28 Thread Lawrence Crowl
On 3/28/13, Richard Biener richard.guent...@gmail.com wrote: The patch is ok as-is. Committed. -- Lawrence Crowl