Re: [patch, mips] Fix for PR target/56942

Steve Ellcey writes: > OK, here is patch to next_real_insn to keep the ordering property intact > and fix the bug. OK for checkin? Thanks, looks good to me, but an rtl/middle-end/global maintainer would need to approve it. Richard

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

2013/4/29 Mike Stump : > On Jan 9, 2013, at 7:14 AM, Alexander Ivchenko wrote: >> We have test fail for gcc.dg/cpp/trad/include.c on Android. The >> reason for that is that >> -ftraditional-cpp is not expected to work on Android due to variadic >> macro (like #define __builtin_warning(x, y...)) >

RE: [patch] cilkplus: Array notation for C patch

Here's a review of the changes to the compiler proper in this patch. I don't think much more will come up from reviews of the compiler changes - but I still need to review the testsuite changes against the language specification to make sure that everything is properly covered in the testsuite (whi

[Fortran-Dev] Some ubounds -> extent changes

This patch changes some ubounds to extent. The patch is relative to my type patch - but it also applies without. It also fixes a bunch fo testsuite failures. Build and regtested on x86-64-gnu-linux. I intent to commit the patch soon. Comments and suggestions are welcome. Tobias 2013-04-29 Tob

MEM_REF representation problem, and folding fix

Currently, MEM_REF contains two pointer arguments, one which is supposed to be a base object and another which is supposed to be a constant offset. This representation is somewhat problematic, as not all machines treat pointer values as essentially integers. On machines where size_t is smaller than

Fwd: [PATCH] Fix PR56915

This patch is for the ICE of PR56915 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56915), specific to gcc 4.9. Because this patch only touches the C++ frontend, I only ran the g++ and libstdc++ testsuits with the newly added testcase. And the test results on Ubuntu x86_64 indicate no regression reg

[PATCH, i386]: Fix PR44578, GCC generates MMX instructions but fails to generate "emms"

Hello! Attached patch fixes PR44578, where MMX register was allocated for zero_extendsidi2 RTX. The patch adds "!" to the interfering alternative, so RA won't choose alternative involving MMX register unless absolute necessary. 2013-04-29 Uros Bizjak PR target/44578 * config/i386/i386

Re: [patch, mips] Fix for PR target/56942

On Sat, 2013-04-27 at 08:56 +0100, Richard Sandiford wrote: > >> But using next_real_insn was at least as correct (IMO, more correct) > >> as next_active_insn before r197266. It seems counterintuitive that > >> something can be "active" but not "real". > >> > >> Richard > > > > So should we put

patch to fix PR57097

The following patch fixes: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57097 The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 198432. 2013-04-29 Vladimir Makarov PR target/57097 * lra-constraints.c (process_alt_operands): Discourage a bit more

Re: [patch] Fix node weight updates during ipa-cp (issue7812053)

On Mon, Apr 29, 2013 at 10:31 AM, Teresa Johnson wrote: > FYI, Fixed in r198416. > > Thanks, > Teresa > I noticed that sometimes GCC generates: _8 = memcpy (ret_6, s_2(D), len_4); _8 = memcpy (ret_6, s_2(D), len_4); memcpy (_17, buffer_12(D), add_16); memcpy (_17, buffer_12(D), add_16); memcpy (

[PATCH] Don't instrument with -fsanitize=thread accesses to DECL_HARD_REGISTER vars (PR tree-optimization/57104)

Hi! DECL_HARD_REGISTER vars don't live in memory, thus they can't be addressable. The following patch fixes the ICE, ok for trunk/4.8? 2013-04-29 Jakub Jelinek PR tree-optimization/57104 * tsan.c (instrument_expr): Don't instrument accesses to DECL_HARD_REGISTER VAR_D

Re: Make m32c build, fix PSImode truncation

> Sorry for missing the truncation patterns, I should have grepped > more than m32c.md. They look a lot like normal moves though. Is > truncation really not a noop, or are the patterns there to work > around something (probably this :-))? Not sure which pattern you're talking about, but in gene

[WIP RFH] #pragma omp declare simd (aka OpenMP elemental functions) parsing

Hi! The following patch are some WIP steps towards #pragma omp declare simd parsing. The spec is a little bit vague, talks just that (a sequence of) #pragma omp declare simd pragmas have to immediately precede a function declaration or definition and that the arguments referred in its clauses are

[PATCH, i386]: Fix PR57098, ICE with -mcmodel=large -msse4 and __builtin_shuffle()

Hello! 2013-04-29 Uros Bizjak PR target/57098 * config/i386/i386.c (ix86_expand_vec_perm): Validize constant memory. 2013-04-29 Uros Bizjak PR target/57098 * gcc.target/i386/pr57098.c: New test. Tested on x86_64-pc-linux-gnu {,-m32} and committed to mainline SVN. The pat

[Patch, Fortran, committed] PR57114 correct intrinsic.texi (RANK) bug.

Committed as obvious as Rev. 198429 Tobias Index: gcc/fortran/ChangeLog === --- gcc/fortran/ChangeLog (Revision 198428) +++ gcc/fortran/ChangeLog (Arbeitskopie) @@ -1,5 +1,11 @@ 2013-04-28 Tobias Burnus + PR fortran/57114 + * i

Re: GCC does not support *mmintrin.h with function specific opts

On Thu, Apr 25, 2013 at 12:41 PM, Joseph S. Myers wrote: > On Tue, 16 Apr 2013, Sriraman Tallam wrote: > >> Ok, it is on by default now. There is a way to turn it off, with >> -mno-generate-builtins. > > Any new option needs documenting in invoke.texi. Added and new patch attached. Thanks Sri

Re: [patch] Fix node weight updates during ipa-cp (issue7812053)

FYI, Fixed in r198416. Thanks, Teresa On Thu, Apr 25, 2013 at 10:19 PM, Teresa Johnson wrote: > Reproduced. This looks like another instance of a case I found testing > my follow-on patch: the helper routines have some assertion checking > that is too strict for the broader usage where we may be

Re: Trivial testsuite fix

Jeff Law writes: > commit 07373396d21b65f975c2354e7c6ab454200b40af > Author: Jeff Law You should set the author accordingly. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different.

Re: [PATCH, i386]: Enable SSE -> GPR moves for generic x86 targets (PR target/54349)

Hi Uros, I was just updating an old bug (GCC generates MMX instructions but fails to generate "emms" http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44578) with a case where I am now hitting this same issue. But as I was including reproducer info I found that the problem went away with a compiler I ju

Trivial testsuite fix

A private message from Kai to myself include this patch to fix an out of bounds array access in the testsuite. Installed on the trunk for Kai. commit 07373396d21b65f975c2354e7c6ab454200b40af Author: Jeff Law Date: Mon Apr 29 10:22:11 2013 -0600 * gcc.c-torture/execute/pr55875

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

On Jan 9, 2013, at 7:14 AM, Alexander Ivchenko wrote: > We have test fail for gcc.dg/cpp/trad/include.c on Android. The > reason for that is that > -ftraditional-cpp is not expected to work on Android due to variadic > macro (like #define __builtin_warning(x, y...)) > in standard headers and trad

Re: [C++ Patch/RFC] PR 57092

On 04/29/2013 05:05 AM, Paolo Carlini wrote: in this 4.8/4.9 Regression, finish_decltype_type doesn't handle ADDR_EXPR. Hmm...we're seeing the regression because previously finish_decltype_type would have just returned the type of the template parameter so it wouldn't ever see the ADDR_EXPR a

[PING] SLSR for conditional candidates

Half-hearted ping for http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01291.html ... I promise this is the last major code dump for SLSR. ;) Thanks, Bill

Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

*ping* thank you, Alexander 2013/4/15 Pavel Chupin : > On Tue, Apr 2, 2013 at 1:59 PM, Pavel Chupin wrote: >> On Mon, Apr 1, 2013 at 7:07 PM, Pavel Chupin >> wrote: >>> On Android pthread is integrated into libc. >>> Attached patch fixes configures for this case by trying to build test >>> wit

[Patch, testsuite] Add -gdwarf to debug/dwarf2 testcases (Take 2)

This patch adds -gdwarf to the flags passed to all tests run by dwarf2.exp. In the first attempt, I'd added the flag to dg-options in individual testcases. Jakub then suggested adding it to the exp file instead. Does this look ok? If yes, could someone commit please, I don't have commit access. R

[PATCH] Fix PR57075

When fixing PR57036 made the inliner not add abnormal edges from calls to non-local labels or setjmps I made it not split the blocks after the possible source of abnormal control flow. That turns out to upset the CFG verifier so the following re-instantiates splitting of blocks. Bootstrap & regte

Re: [Patch] Emit error for negative _Alignas alignment values

On Thu, 25 Apr 2013, Senthil Kumar Selvaraj wrote: > On Wed, Apr 24, 2013 at 03:18:51PM +, Joseph S. Myers wrote: > > On Wed, 3 Apr 2013, Senthil Kumar Selvaraj wrote: > > > > > 2013-04-03Senthil Kumar Selvaraj > > > > > > > > > * c-common.c (check_user_alignment): Emit error fo

Re: Make m32c build, fix PSImode truncation

Richard Sandiford writes: > Bernd Schmidt writes: >> On 04/27/2013 10:39 AM, Richard Sandiford wrote: >>> Argh, that's unfortunate. The point of that change was to make >>> simplify_gen_unary (TRUNCATE, ...) no worse than using a subreg. >>> Would the equivalent lowpart simplify_gen_subreg call

Re: [Patch, Ping] Emit error for negative _Alignas alignment values

Ping - could you commit it for me please, I don't have commit access. Regards Senthil On Thu, Apr 25, 2013 at 12:10:06PM +0530, Senthil Kumar Selvaraj wrote: > On Wed, Apr 24, 2013 at 03:18:51PM +, Joseph S. Myers wrote: > > On Wed, 3 Apr 2013, Senthil Kumar Selvaraj wrote: > > > > > 2013-04

Re: Make m32c build, fix PSImode truncation

Bernd Schmidt writes: > On 04/27/2013 10:39 AM, Richard Sandiford wrote: >> Argh, that's unfortunate. The point of that change was to make >> simplify_gen_unary (TRUNCATE, ...) no worse than using a subreg. >> Would the equivalent lowpart simplify_gen_subreg call succeed >> (return nonnull)? If

Re: [PATCH][ARM] Restrict store_minmaxsi

On 29/04/13 12:33, Kyrylo Tkachov wrote: Hi all, With this patch, we now only use the store_minmaxsi pattern when we're not in a hot path. We have found that this pattern can cause memory access bottlenecks in some cases (one benchmark was 45% slower when this pattern was enabled). Tested arm-

[PATCH] Update tail-merge header comment.

Steven, I answered your question in tree-ssa-tail-merge.c about why tail-merge is not a stand-alone gimple pass. Committed to trunk. Thanks, - Tom 2013-04-29 Tom de Vries * tree-ssa-tail-merge.c: Update header comment.

[PATCH] Fix PR57103

The following fixes a thinko in move_stmt_op regarding to block updates. It also makes the two copies look the same and removes redundant checking. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2013-04-29 Richard Biener PR middle-end/57103 * tree-cfg.c

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

On Mon, Apr 29, 2013 at 03:39:58PM +0400, Maksim Kuznetsov wrote: > 2013/4/29 Jakub Jelinek : > > Also, why are you handling just %{ and %}, and > > not also %| ? I mean, if you want to print say {|} into assembly for both > > dialects, don't you need: > > asm ("{dialect1%{%|%}|%{%|%}dialect2}");

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

2013/4/29 Jakub Jelinek : > Also, why are you handling just %{ and %}, and > not also %| ? I mean, if you want to print say {|} into assembly for both > dialects, don't you need: > asm ("{dialect1%{%|%}|%{%|%}dialect2}"); > or similar? If you use just | instead of %|, it would be handled as > sep

[PATCH][ARM] Restrict store_minmaxsi

Hi all, With this patch, we now only use the store_minmaxsi pattern when we're not in a hot path. We have found that this pattern can cause memory access bottlenecks in some cases (one benchmark was 45% slower when this pattern was enabled). Tested arm-none-eabi on qemu. Ok for trunk? Thanks,

[PATCH][committed]: Fix typo in predict.c

Hi all, I've committed this typo fix in predict.c as r198408. Thanks, Kyrill 2013-04-29 Kyrylo Tkachov * predict.c: Fix typo in comment above #define PROB_VERY_UNLIKELY. predict-spelling.patch Description: Binary data

Re: [testsuite] Disabling gcc.dg/cpp/trad/include.c for Android

*ping* thanks, Alexander 2013/3/26 Alexander Ivchenko : > Hi, > > Could you please take a look at the attached fixinclude patch > that addresses the problem: > > " We have test fail for gcc.dg/cpp/trad/include.c on Android. The > reason for that is that > -ftraditional-cpp is not expected to wor

[PATCH, i386]: Enable SSE -> GPR moves for generic x86 targets (PR target/54349)

Hello! Attached patch enables SSE -> general register moves for generic x86 targets. The patch splits TARGET_INTER_UNIT_MOVES to TARGET_INTER_UNIT_MOVES_TO_VEC and TARGET_INTER_UNIT_MOVES_FROM_VEC tuning flags and updates gcc sources accordingly. According to AMD optimization manuals, direct move

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

On Mon, Apr 29, 2013 at 02:31:40PM +0400, Maksim Kuznetsov wrote: > Jakub, Richard, thank you for your feedback! > > > I wonder if it %{ and %} shouldn't be better handled in final.c > > for all #ifdef ASSEMBLER_DIALECT targets, rather than just for one specific. > > I moved %{ and %} cases to ou

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

Jakub, Richard, thank you for your feedback! > I wonder if it %{ and %} shouldn't be better handled in final.c > for all #ifdef ASSEMBLER_DIALECT targets, rather than just for one specific. I moved %{ and %} cases to output_asm_insn in final.c > Also: > *(p + 1) > should be better written as p[1

Re: [PATCH SH] Fix PR57108

Christian Bruel wrote: > This patches set the correct operand mode for tstsi_t_zero_extract_eq, > to avoid reload generating a move between a constant and a void register. > > Reg tested for sh-elf. No performance impact > > OK for 4.7, 4.8 and trunk ? OK. Regards, kaz

Re: [PATCH v2] gcc: arm: linux-eabi: fix handling of armv4 bx fixups when linking

On 28/04/13 04:52, Mike Frysinger wrote: The bpabi.h header already sets up defines to automatically use the --fix-v4bx flag with the assembler & linker as needed, and creates a default assembly & linker spec which uses those. Unfortunately, the linux-eabi.h header clobbers the LINK_SPEC define

Re: [PATCH] Fix PR57089

On Mon, 29 Apr 2013, Richard Biener wrote: > > I've tried to follow where the scalar loop appears in > expand_omp_for_static_nochunk but got lost quickly. So the following > papers over the lack of OMP expansion populating the loop tree > as I've done in the original patch introducing loops to i

Re: [PATCH, AArch64] Support LDR/STR to/from S and D registers

On 26 April 2013 14:38, Ian Bolton wrote: > This patch allows us to load to and store from the S and D registers, > which helps with doing scalar operations in those registers. > > This has been regression tested on bare-metal and linux. > > OK for trunk? > > Cheers, > Ian > > > 2013-04-26 Ian Bo

Re: [AArch64] Vectorize over more math.h functions.

On 26 April 2013 14:28, James Greenhalgh wrote: > > Hi, > > This patch adds float -> int builtins to the set > of builtins we can try to vectorize in aarch64_builtin_vectorized_function. > > In particular, we add BUILT_IN_IFLOORF, BUILT_IN_ICEILF, BUILT_IN_LROUND, > BUILT_IN_IROUNDF. > > The BUILT

Re: [AArch64] Implement vector float->double widening and double->float narrowing.

On 26 April 2013 14:25, James Greenhalgh wrote: > > Hi, > > gcc.dg/vect/vect-float-truncate-1.c and > gcc.dg/vect/vect-float-extend-1.c > > Were failing because widening and narrowing of floats to doubles was > not wired up. > > This patch fixes that by implementing the standard names: > > vec_pac

Re: [AArch64] Add vector int to float conversions.

On 26 April 2013 14:22, James Greenhalgh wrote: > > Hi, > > This patch wires up builtins for int to float conversions in > Tree, and uint to float conversions in RTL. > > Regression tested for aarch64-none-elf with no regressions. > > Thanks, > James > > --- > gcc/ > > 2013-04-26 James Greenhalgh

Re: Make m32c build, fix PSImode truncation

On 04/27/2013 10:39 AM, Richard Sandiford wrote: > Argh, that's unfortunate. The point of that change was to make > simplify_gen_unary (TRUNCATE, ...) no worse than using a subreg. > Would the equivalent lowpart simplify_gen_subreg call succeed > (return nonnull)? If so, I think we want truncate

Re: [AArch64] Map fcvt intrinsics to builtin name directly.

On 26 April 2013 14:12, James Greenhalgh wrote: > > Hi, > > This patch uses the new builtin-mapping infrastructure > to map the fcvt family of builtins directly to their > GCC standard pattern name. > > Regression tested on aarch64-none-elf with no regressions. > > Thanks, > James > > --- > gcc/ >

[PATCH SH] Fix PR57108

Hello, This patches set the correct operand mode for tstsi_t_zero_extract_eq, to avoid reload generating a move between a constant and a void register. Reg tested for sh-elf. No performance impact OK for 4.7, 4.8 and trunk ? Thanks 2013-04-26 Christian Bruel PR target/57108 * sh.md (tst

Re: [AArch64][Testsuite] Enable vect_uintfloat_cvt for AArch64.

On 26 April 2013 14:36, James Greenhalgh wrote: > > Hi, > > While modifying all the vcvt builtins we've fixed enough bugs > that we can now enable vect_uintfloat_cvt for AArch64. Do that. > > Patch tested to ensure all newly enabled tests succeed. > > James > --- > gcc/testsuite/ > > 2013-04-26 J

Re: [AArch64] fcvt instructions - arm_neon.h changes.

On 26 April 2013 14:34, James Greenhalgh wrote: > > This patch updates the implimentation in arm_neon.h of the vcvt > intrinsics. Where appropriate we use C statements, and where not > possible we fall back to builtins. > > There were a number of errors with names and types in the current > revisi

Re: [AArch64] Add vector fix, fixuns, fix_trunc, fixuns_trunc standard patterns

OK /Marcus On 26 April 2013 14:30, James Greenhalgh wrote: > > Hi, > > This patch enables vectorization over conversions by implimenting the > fix, fixuns, fix_trunc, fixuns_trunc, and ftrunc standard pattern names. > > Each of these is implimented by the frintz instruction. > (Round towards 0) >

Re: [Patch, fortran] PR 56981 Improve unbuffered unformatted performance

On Mon, Apr 29, 2013 at 1:46 AM, Jerry DeLisle wrote: > OK Janne and thanks for the patch. Thanks for the review, committed (as well as the system_clock patch). > What are your thoughts about special casing nul devices/ Hmm, I'm not that eager. It starts to smell of "benchmarketing".. One thin

[C++ Patch/RFC] PR 57092

Hi, in this 4.8/4.9 Regression, finish_decltype_type doesn't handle ADDR_EXPR. In 4.7, finish_decltype_type deals with a TEMPLATE_PARM_INDEX and the testcase compiles fine, but it's quite easy - see c++/52282 - to trigger the same ICE there too (it would be nice to make progress on the latter

[DWARF] Fix multiple register spanning location.

Hello, We noticed a few failures with the gdb testsuite due to incorrect mapping of floating point, noticed on SH that defines both TARGET_DWARF_REGISTER_SPAN and DBX_REGISTER_NUMBER. The problem was that the converted pseudo reg was never converted to the dbx format when fed from 'multiple_reg_l

[PATCH] Fix PR57089

I've tried to follow where the scalar loop appears in expand_omp_for_static_nochunk but got lost quickly. So the following papers over the lack of OMP expansion populating the loop tree as I've done in the original patch introducing loops to it. If the OMP expansion code knows at some point "her

Re: mips SNaN/QNaN is swapped

Hi! Ping. On Mon, 22 Apr 2013 11:52:23 +0200, I wrote: > On Fri, 5 Apr 2013 23:55:37 +0100, "Maciej W. Rozycki" > wrote: > > On Fri, 5 Apr 2013, Thomas Schwinge wrote: > > > > Index: gcc/config/fp-bit.c > > > > === > > > > RCS file

Re: [RFA][PATCH] Eliminate more unnecessary type conversions

On Fri, Apr 26, 2013 at 8:53 PM, Jeff Law wrote: > > So looking at more dumps made it pretty obvious that my previous patch to > tree-vrp.c to eliminate useless casts to boolean types which fed into > comparisons could and should be generalized. > > Given: > > x1 = (T1) x0; > if (x1 COND CONST

Re: [PATCH] Fix PR57077 (issue8840045)

On Fri, Apr 26, 2013 at 8:52 PM, Teresa Johnson wrote: > This patch fixes PR57077. Certain new uses of apply_probability > are actually scaling the counts up, and the scale factor should not > be treated as a probability as the value may exceed REG_BR_PROB_BASE. > One example (from the PR) is when

Re: [PATCH] Preserve loops from CFG build until after RTL loop opts

On Sun, 28 Apr 2013, Tom de Vries wrote: > On 26/04/13 16:27, Tom de Vries wrote: > > On 25/04/13 16:19, Richard Biener wrote: > > > >> and compared to the previous patch changed the tree-ssa-tailmerge.c > >> part to deal with merging of loop latch and loop preheader (even > >> if that's a really

Re: [PATCH] Fix VRP LSHIFT_EXPR non-singleton shift count handling (PR tree-optimization/57083)

On Sat, 27 Apr 2013, Jakub Jelinek wrote: > Hi! > > If shift count range is [0, 1], then for unsigned LSHIFT_EXPR > bound is the topmost bit, but as llshift method always sign-extends > the result into double_int, the test don't properly find out that > deriving the value range is unsafe. In thi