Re: [PATCH] fix for pr 57474

2013-05-31 Thread Dominique Dhumieres
> ... This patch pasted below should fix that issue. ... A quick test on darwin (no bootstrap, no full regtest) with make -k check-gcc RUNTESTFLAGS="cilk-plus.exp --target_board=unix'{-m32,-m64}'" gives === gcc Summary for unix/-m64 === # of expected passes2904

Re: Fix PR57268

2013-05-31 Thread Dinar Temirbulatov
Hi, oh, This is my mistake I should have bootstrap the compiler. I am investigating the problem. thanks, Dinar. On Sat, Jun 1, 2013 at 7:50 AM, H.J. Lu wrote: > On Wed, May 29, 2013 at 9:36 AM, Dinar Temirbulatov > wrote: >> Here is the corrected version of change. Also, I think, I nee

Re: Fix PR57268

2013-05-31 Thread H.J. Lu
On Wed, May 29, 2013 at 9:36 AM, Dinar Temirbulatov wrote: > Here is the corrected version of change. Also, I think, I need > write-after-approval access to commit the change. > thanks, Dinar, > > PR rtl-optimization/57268 > * sched-deps.c (sched_analyze_2): Flush d

RS6000 PATCH for c++/57415 (ICE on altivec tests)

2013-05-31 Thread Jason Merrill
The issue here was that rs6000-c.c was creating COMPOUND_LITERAL_EXPR, which the C++ front end doesn't understand. For C++ let's create TARGET_EXPRs instead. Tested powerpc64-unknown-linux-gnu. OK for trunk? commit a640247e7cdf04126e8a9278394ed99c6a3d5d50 Author: Jason Merrill Date: Thu Ma

Updated MAINTAINERS

2013-05-31 Thread Dinar Temirbulatov
Hi, I updated MAINTAINERS list with following change(patch attached). thanks, Dinar. MAINTAINERS.patch Description: Binary data

[PATCH] fix for pr 57474

2013-05-31 Thread Iyer, Balaji V
Hello Everyone, PR reports that sec_implicit2 and sec_implicit regression tests were failing in darwin. I looked into it and it is due to an uninitialized variable (rhs_length). This patch pasted below should fix that issue. Is this OK for trunk? Here are the ChangeLog entries: 2013-05

Re: [Patch] Fix PR56780: --disable-install-libiberty still installs libiberty.a

2013-05-31 Thread Ian Lance Taylor
On Thu, May 30, 2013 at 2:45 PM, Matt Burgess wrote: > > Thanks, Ian. Another step in the contributing guidelines I seem to have > missed is to inform you that I don't have write access to the GCC repo. > If you could commit this for me please, I'd appreciate it. Committed. Ian

[wwwdocs] correct GFDL spelling

2013-05-31 Thread Benjamin De Kosnik
Noticed this typo when doing the 4.8.1 docs. I'd removed this in the top-level file before, and that's fine, but these release-versioned files were wrong. -benjamin2013-05-31 Benjamin Kosnik * htdocs/onlinedocs/4.8.0/index.html: Correct to GFDL. * htdocs/onlinedocs/4.8.1/index

Re: default_no_named_section bad default

2013-05-31 Thread Mike Stump
On May 31, 2013, at 2:56 PM, Andrew Pinski wrote: > This will only fix the GCC source but not other sources which does: > void f(void) > { > __builtin_unreachable(); > } Yes. Speaking of which, so how should this be handled? Imagine we have asm("# no bytes") before the unreachable. The compi

RE: [PATCH] pr57457

2013-05-31 Thread Iyer, Balaji V
HI Jeff et al., Forgot to ask in my previous email... Is this Ok for trunk? -Balaji V. Iyer. > -Original Message- > From: Iyer, Balaji V > Sent: Friday, May 31, 2013 2:02 PM > To: 'Jeff Law' > Cc: gcc-patches@gcc.gnu.org; Steve Ellcey > Subject: RE: [PATCH] pr57457 > > > > > --

Re: default_no_named_section bad default

2013-05-31 Thread Andrew Pinski
On Fri, May 31, 2013 at 11:13 AM, Mike Stump wrote: > So, on darwin, the new tools don't like FDE information when you have: > > __Z24default_no_named_sectionPKcjP9tree_node: > LFB588: > LFE588: > > in the object file. > > $ dwarfdump --eh-frame --verify varasm.o >

Re: default_no_named_section bad default

2013-05-31 Thread Mike Stump
On May 31, 2013, at 11:13 AM, Mike Stump wrote: > I think really, we either need to have a default of 0 (to crash in a nice way) The previous patch does not fix it. I think we need to use 0 instead: Ok? New idea: Index: target.def ==

[PATCH 6/6] rs6000: dot for ashiftrt

2013-05-31 Thread Segher Boessenkool
Last for now: move ashiftrt to integer.mdm. Also allow the dot of lshrsi3_imm in 64-bit mode, if the shift amount is more than 0. 2013-05-31 Segher Boessenkool gcc/ * config/rs6000/rs6000.md (ashrsi3, ashrdi3_no_power, ashrdisi3_noppc64be, ashrdi3, ashrdi3_internal1, ashrdi3_

[PATCH 5/6] rs6000: dot for shift/delayed_compare

2013-05-31 Thread Segher Boessenkool
Similar, but now for shift and delayed_compare. 2013-05-31 Segher Boessenkool gcc/ * config/rs6000/integer.mdm (ashl3_imm, lshr3_imm): Delete comment. * config/rs6000/integer.md: Regenerate. * config/rs6000/40x.md: Require dot=no for type=shift; where t

[PATCH 4/6] rs6000: dot for var_shift_rotate/var_delayed_compare

2013-05-31 Thread Segher Boessenkool
This changes all scheduling descriptions to treat insn type var_shift_rotate with dot=yes the same as var_delayed_compare is treated, and to require dot=no for var_shift_rotate that already was handled. 2013-05-31 Segher Boessenkool gcc/ * config/rs6000/integer.mdm (ashl3, lshr3): Del

[PATCH 3/6] rs6000: dot for ashl3

2013-05-31 Thread Segher Boessenkool
Similar to lshr, for ashl. Okay? 2013-05-31 Segher Boessenkool gcc/ * config/rs6000/rs6000.md (ashlsi3, ashldi3_internal1, ashldi3_internal2, ashldi3_internal3): Delete. * config/rs6000/integer.mdm (ashl3, ashl3_imm): New. * config/rs6000/integer.md: Regenerat

[PATCH 2/6] rs6000: dot for lshrsi3

2013-05-31 Thread Segher Boessenkool
This moves lshrsi3 over and merges it with lshrdi3. The immediate version is split off since it needs a different condition (and is a separate instruction anyway). Tested as per usual; okay? 2013-05-31 Segher Boessenkool gcc/ * config/rs6000/rs6000.md (lshrsi3): Delete. * co

[PATCH 1/6] rs6000: Introducing define_dot_insn

2013-05-31 Thread Segher Boessenkool
This adds a program (mdm.pl) that does some processing on machine description files. It is careful to keep formatting and comments intact as much as possible, so that its output is well readable. The only transform it does so far is convert a "define_dot_insn" construct to three "define_insn"s an

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Mikael Morin
Le 31/05/2013 14:28, Janus Weil a écrit : >> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports >> that we're outputting to a terminal? > > Good point. Updated patch attached, which imposes no limit if we're > not outputting to a terminal (as suggested by Mikael). > > Ok for tr

Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-05-31 Thread Tobias Burnus
Tobias Burnus wrote: This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Attached is an additional test case, which checks that the finalization wrapper handles strides correctly. The stride handling occurs trice: - For elemental finalization procedures in

Re: [ada, build] host/target configuration

2013-05-31 Thread Thomas Schwinge
Hi! On Fri, 31 May 2013 21:54:55 +0200, Eric Botcazou wrote: > > In my reading, the code supported both these before your recent change, > > and now supports neither, as I reported this morning. > > Did you test it? I didn't; now I have, and... > > With which configurations exactly have you te

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Janus Weil
>>> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports >>> that we're outputting to a terminal? >> >> >> Good point. Updated patch attached, which imposes no limit if we're >> not outputting to a terminal (as suggested by Mikael). >> >> Ok for trunk, or am I missing anything else

[PATCH] Improve folding of bitwise ops on booleans

2013-05-31 Thread Jeff Law
This is an implementation to fix a missed optimization pointed out to me by Kai. In all these examples, assume a & b are single bit types. ~a && b --> a < b a && ~b --> b < a ~a || b --> a <= b a && ~b --> b <= a This happens with some regularity in GCC itself, though it's not as pervasive

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Bernhard Reutner-Fischer
On 31 May 2013 15:57:25 Manfred Schwarb wrote: Am 31.05.2013 14:28, schrieb Janus Weil: >> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports >> that we're outputting to a terminal? > > Good point. Updated patch attached, which imposes no limit if we're > not outputting to a t

Re: [ada, build] host/target configuration

2013-05-31 Thread Eric Botcazou
> In my reading, the code supported both these before your recent change, > and now supports neither, as I reported this morning. Did you test it? > With which configurations exactly have you tested your change? arm-linux-androideabi -- Eric Botcazou

Re: [Solaris] Catch FP exceptions

2013-05-31 Thread Eric Botcazou
> i386 only, might be related > > ,.,. CXG2021 ACATS 2.5 13-05-27 17:47:57 > CXG2021 Check the accuracy of the complex SIN and COS functions. >* CXG2021 Identity_2_Test 3 0: Cos(( 1.60300E+01, 1.6E+01)) > imaginary part actual: 1.40623E+06 expected: >

[patch] Fix parsing bug in validate_patches.py

2013-05-31 Thread Brooks Moses
The validate_failures.py script in contrib/testsuite-management expects the first "|" character in a test summary line to be a delineator allowing the line to be prefixed by attributes such as "flaky". This causes problems when a test line itself contains "|" in the message. We can get around

Re: [GOOGLE] More strict checking for call args

2013-05-31 Thread Xinliang David Li
Those cases you mentioned may lead to problems in inlining, indirect target promotion transformations etc too, so it is better to use the new guard against them. David On Fri, May 31, 2013 at 1:15 AM, Duncan Sands wrote: > Hi Dehao, > > > On 31/05/13 00:47, Dehao Chen wrote: >> >> This patch mak

default_no_named_section bad default

2013-05-31 Thread Mike Stump
So, on darwin, the new tools don't like FDE information when you have: __Z24default_no_named_sectionPKcjP9tree_node: LFB588: LFE588: in the object file. $ dwarfdump --eh-frame --verify varasm.o -- File: varasm.o (x86_64) --

RFA: Switching LRA on for s390

2013-05-31 Thread Vladimir Makarov
The following patch switches LRA on for s390. The patch introduces a new option -mlra to use LRA instead of reload. I did not document the option as I'd like to delete it for gcc4.9. By default, LRA will be used for s390 instead of reload for better testing LRA for s390. Changes in s390.md

RE: [PATCH] pr57457

2013-05-31 Thread Iyer, Balaji V
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Jeff Law > Sent: Friday, May 31, 2013 11:50 AM > To: Iyer, Balaji V > Cc: gcc-patches@gcc.gnu.org; Steve Ellcey > Subject: Re: [PATCH] pr57457 > > On 05/31/2013 07:54 AM, Iye

[ARM] Avoid spilling ip for nested APCS frames

2013-05-31 Thread Eric Botcazou
The ARM/VxWorks port uses APCS frames and therefore ip to establish frames with a frame pointer. Now, for nested functions, ip is also the static chain register so it needs to be preserved when the frame is being established. There is code to that effect trying to save ip into r3 if the latter

[ARM] Resurrect VxWorks port

2013-05-31 Thread Eric Botcazou
Hi, as diagnosed by Doug, the VxWorks port cannot be built since: 2011-05-18 Joseph Myers which reorganized the ARM options and turned arm_fp16_format from a global variable defined in arm.c into an option variable, leading to: In file included from ../../.././gcc/tm.h:20:0,

Re: [PATCH 1/2] handwritten part of patch

2013-05-31 Thread Mike Stump
I like the idea that someone reviews the end destination you want to get to, and the general path you want to use to get there, and then just pre-approve the entire concept. :-) I think I like the end destination; the path you have chosen is slightly different from the one I might have chosen,

Re: Implement N3642 - User-defined Literals for Standard Library Types

2013-05-31 Thread Jonathan Wakely
On 31 May 2013 15:15, Ed Smith-Rowland wrote: > Greetings, > > This patch implements N3642 - User-defined literals for > std::chrono::duration and std::basic_string > and N3660 - User-defined literals for std::complex. Great, thanks! > User-defined literals were separated into two papers because

Re: [PATCH] Fix pr54684.C regression for arm*-*-*

2013-05-31 Thread Mike Stump
On May 31, 2013, at 4:02 AM, Marcus Shawcroft wrote: > Since http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01475.html introduced a > warning for bit field types with width greater than the contained enum width > pr54684.C has failed for arm*-*-* due to the extra diagnostic emitted. This > patc

Re: [PATCH] Fix failing pr56184.C

2013-05-31 Thread Mike Stump
On May 31, 2013, at 4:01 AM, Marcus Shawcroft wrote: > Since http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01475.html introduced a > warning for bit field types with width greater than the contained enum width > pr56184.C has failed for arm*-*-* due to the extra diagnostic emitted. This > patc

Re: [PATCH] Fix eb76.C regression for arm*-*-*

2013-05-31 Thread Mike Stump
On May 31, 2013, at 4:01 AM, Marcus Shawcroft wrote: > Since http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01475.html introduced a > warning for bit field types with width greater than the contained enum width > eb76.C has failed for arm*-*-* due to the extra diagnostic emitted. This > patch d

Re: Re: Implement N3642 - User-defined Literals for Standard Library Types

2013-05-31 Thread 3dw4rd
On 05/31/13, Ed Smith-Rowland<3dw...@verizon.net> wrote: > ... > 1. Put the precision first in upper case. As a matter of style I > prefer 123456L to 123456l for normal literals anyway. Also, the > precision snuggles next to the number - then you modify it. That seems > logical to me.

[Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-05-31 Thread Tobias Burnus
This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Additionally, it addresses a missed optimization: The previous code tried to deallocate allocatable components even if the dummy argument was already an allocatable. That's a missed optimization as gfortra

Re: [Patch, Fortran] Enable FINALization/poly dealloc for allocatables

2013-05-31 Thread Tobias Burnus
And another one: I just realized that the following dead code can be removed (twice): + if (TREE_CODE (array) == ADDR_EXPR + && POINTER_TYPE_P (TREE_TYPE (TREE_OPERAND (array, 0 +tmp = TREE_OPERAND (array, 0); As "tmp" is not used. That's part of gfc_build_final_call,t

Re: [google gcc-4_8 commited] Adjust testsuite line numbers for r199468.

2013-05-31 Thread Paul Pluzhnikov
On Thu, May 30, 2013 at 10:00 PM, Paul Pluzhnikov wrote: > I've committed attached patch on google/gcc-4_8 branch to fix testsuite > failures broken by r199468. Also applied to google/integration branch. -- Paul Pluzhnikov

Re: [PING]RE: [patch] cilkplus: Array notation for C patch

2013-05-31 Thread David Edelsohn
On Thu, May 30, 2013 at 6:10 PM, Iyer, Balaji V wrote: > I think David is getting the correct output but just that dg-error is not > catching it correctly. Is there an updated Tcl or runtest pre-req? - David

Re: [PATCH] pr57457

2013-05-31 Thread Jeff Law
On 05/31/2013 07:54 AM, Iyer, Balaji V wrote: Hello Everyone, This patch will fix a bug reported in PR57457. One of the array notation function was not checking for NULL_TREE before accessing its fields. This patch should fix that issue. A test case is also added. Is this OK for trunk?

[PATCH] Reduce -fopt-info verbosity

2013-05-31 Thread Teresa Johnson
This patch changes the -fopt-info default to optimized instead of all, since the latter is extremely verbose. This reduced the -fopt-info output by over 75% in at least one case, since the vectorizer has many messages under MSG_NOTE (and that should grow as more passes are converted to the new dump

[PATCH, AArch64] Remove excessive braces..

2013-05-31 Thread Marcus Shawcroft
Remove un-necessary braces. Applied. /Marcus 2013-05-31 Marcus Shawcroft * config/aarch64/aarch64.c (aarch64_load_symref_appropriately): Remove un-necessary braces.diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 9c77888..f554550 100644 --- a/gcc

[PATCH, AArch64] -mcmodel=tiny -fPIC use tiny absolute for non binds local.

2013-05-31 Thread Marcus Shawcroft
This change allows -mcmodel=tiny -fPIC to use tiny addressing instead of small for none GOT accesses. Regressed for aarch64-none-elf with -mcmodel=tiny and -mcmodel=tiny -fPIC Applied. /Marcus 2013-05-31 Marcus Shawcroft * config/aarch64/aarch64.c (aarch64_classify_symbol):

Re: [PATCH] Fix incorrect discriminator assignment.

2013-05-31 Thread Andreas Schwab
Rainer Orth writes: > Indeed, and I see -ansi -pedantic-errors -gdwarf-2 -O0 used for the test > on both x86_64-unknown-linux-gnu and i386-pc-solaris2.10 (if I augment > the target clause). DEFAULT_CFLAGS is set by many *.exp files. dwarf2.exp will not overwrite an existing definition, so using

Re: [PATCH] rs6000: Group processor types

2013-05-31 Thread David Edelsohn
On Fri, May 31, 2013 at 3:34 AM, Segher Boessenkool wrote: > Long lines like this define_attr are hard to read, and patches to > them are hard to read and apply. > > Bootstrapped and tested on powerpc64-linux --enable-languages=c,c++,fortran > --disable-libsanitizer, -m64,-m32,-m32/-mpowerpc64, no

Re: [PATCH, rs6000] power8 patches, patch #4, new power8 builtins

2013-05-31 Thread Michael Meissner
On Fri, May 31, 2013 at 11:10:54AM +0200, Segher Boessenkool wrote: > >Ok, I tracked down what the problem is. We never implemented the > >EQV, ORC, or > >NAND insns in the GPRs. When I added the power8 vector versions, > >the split > >wide types pass tried to do its thing in the GPRs, it creates

Re: [PATCH 1/2] handwritten part of patch

2013-05-31 Thread David Malcolm
On Wed, 2013-05-29 at 10:06 +0200, Richard Biener wrote: > On Tue, May 28, 2013 at 8:04 PM, David Malcolm wrote: > > On Mon, 2013-05-27 at 15:38 +0200, Richard Biener wrote: > >> On Sat, May 25, 2013 at 3:02 PM, David Malcolm wrote: > >> > Eliminate all direct references to "cfun" from ma

Re: Implement N3642 - User-defined Literals for Standard Library Types

2013-05-31 Thread Ed Smith-Rowland
On 05/31/2013 10:41 AM, Daniel Krügler wrote: 2013/5/31 Ed Smith-Rowland <3dw...@verizon.net>: Greetings, This patch implements N3642 - User-defined literals for std::chrono::duration and std::basic_string and N3660 - User-defined literals for std::complex. N3660 was rejected during the Bris

Re: [rs6000] Improve FP comparisons with -fno-trapping-math

2013-05-31 Thread David Edelsohn
On Fri, May 31, 2013 at 7:04 AM, Eric Botcazou wrote: >> I'm okay with most of the change, but I have a question: What happened >> to the unsigned comparisons and LTGT? > > Unsigned comparisons aren't used for FP (the whole block of code is dominated > by a FLOAT_MODE_P (mode) test). LTGT and UNE

Re: PR57073 - Optimize __builtin_powif (-1.0, k) to k & 1 ? -1.0 : 1.0

2013-05-31 Thread Tobias Burnus
Am 31.05.2013 10:24, schrieb Richard Biener: On Thu, May 30, 2013 at 10:54 PM, Jeff Law wrote: Don't worry about it. The patch is good as-is. Why sink the !host_integerp check? Please keep it where it is now. Answer: Because it doesn't work. And if I had a cup of coffee and didn't mess up

Re: [Patch libsanitizer] merge rev 182922 (helps running under qemu)

2013-05-31 Thread Konstantin Serebryany
On Fri, May 31, 2013 at 6:49 PM, Jack Howarth wrote: > On Fri, May 31, 2013 at 04:42:21PM +0200, Christophe Lyon wrote: >> Hi, >> >> I'd like to backport libsanitizer commit #182922: >> Index: sanitizer_common/sanitizer_linux.cc >> ==

Re: [Patch libsanitizer] merge rev 182922 (helps running under qemu)

2013-05-31 Thread Jack Howarth
On Fri, May 31, 2013 at 04:42:21PM +0200, Christophe Lyon wrote: > Hi, > > I'd like to backport libsanitizer commit #182922: > Index: sanitizer_common/sanitizer_linux.cc > === > --- sanitizer_common/sanitizer_linux.cc(revision 199

[Patch libsanitizer] merge rev 182922 (helps running under qemu)

2013-05-31 Thread Christophe Lyon
Hi, I'd like to backport libsanitizer commit #182922: Index: sanitizer_common/sanitizer_linux.cc === --- sanitizer_common/sanitizer_linux.cc(revision 199453) +++ sanitizer_common/sanitizer_linux.cc(working copy) @@ -410,7 +410

Re: Implement N3642 - User-defined Literals for Standard Library Types

2013-05-31 Thread Daniel Krügler
2013/5/31 Ed Smith-Rowland <3dw...@verizon.net>: > Greetings, > > This patch implements N3642 - User-defined literals for > std::chrono::duration and std::basic_string > and N3660 - User-defined literals for std::complex. N3660 was rejected during the Bristol meeting, the main reason being the ug

Implement N3642 - User-defined Literals for Standard Library Types

2013-05-31 Thread Ed Smith-Rowland
Greetings, This patch implements N3642 - User-defined literals for std::chrono::duration and std::basic_string and N3660 - User-defined literals for std::complex. User-defined literals were separated into two papers because of some controversy about noexcept for complex literals. If desired,

RE: [x86, PATCH 1/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Zamyatin, Igor
Yes, I was planning to do it after second patch is in the trunk. Thanks for pointing out exact places! Igor -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Tobias Burnus Sent: Friday, May 31, 2013 5:24 PM To: Zamyatin, Igor Cc:

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Manfred Schwarb
Am 31.05.2013 14:28, schrieb Janus Weil: Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports that we're outputting to a terminal? Good point. Updated patch attached, which imposes no limit if we're not outputting to a terminal (as suggested by Mikael). Ok for trunk, or am I m

[PATCH] pr57457

2013-05-31 Thread Iyer, Balaji V
Hello Everyone, This patch will fix a bug reported in PR57457. One of the array notation function was not checking for NULL_TREE before accessing its fields. This patch should fix that issue. A test case is also added. Is this OK for trunk? Here are the ChangeLog Entries: gcc/c/ChangeL

Re: [ada, build] host/target configuration

2013-05-31 Thread Olivier Hainque
On May 30, 2013, at 23:08 , Olivier Hainque wrote: > The idea of the "target->target_alias" change in gcc-interface/Makefile.in > for Ada was to let us still distinguish for the purpose of the Ada RTSes in > particular. > > This happens to be significant in a limited amount of cases only. A v

Re: C++ PATCH for c++/52377 (NSDMI and unions)

2013-05-31 Thread Jason Merrill
On 05/31/2013 07:13 AM, Rainer Orth wrote: Is this really intended to be a run test? Oops, no, thanks. Also, both testcases are missing from gcc/testsuite/ChangeLog. I prefer not to mess with logging testcase changes. http://gcc.gnu.org/codingconventions.html#ChangeLogs Jason

Re: [x86, PATCH 1/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Tobias Burnus
Zamyatin, Igor wrote: Several weeks ago Intel announced new microarchitecture named Silvermont (see for example http://newsroom.intel.com/community/intel_newsroom/blog/2013/05/06/intel-launches-low-power-high-performance-silvermont-microarchitecture ). This patch is the first and it enables Si

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Uros Bizjak
On Fri, May 31, 2013 at 2:56 PM, Igor Zamyatin wrote: > Like this? Yes, but put the comment above the peephole2 pattern. The patch is OK for mainline with the above change. Thanks, Uros. > > On Fri, May 31, 2013 at 3:45 PM, Uros Bizjak wrote: >> On Fri, May 31, 2013 at 1:38 PM, Igor Zamyatin

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Igor Zamyatin
Like this? On Fri, May 31, 2013 at 3:45 PM, Uros Bizjak wrote: > On Fri, May 31, 2013 at 1:38 PM, Igor Zamyatin wrote: >> We do want to use the same register for float_extend. > > OK then. Please add a comment for this fact and also, please put > single-line preparation statements inside double-

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Janus Weil
> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports > that we're outputting to a terminal? Good point. Updated patch attached, which imposes no limit if we're not outputting to a terminal (as suggested by Mikael). Ok for trunk, or am I missing anything else? (Testing welcome .

Re: [PATCH] Fix incorrect discriminator assignment.

2013-05-31 Thread Rainer Orth
Andreas Schwab writes: > Rainer Orth writes: > >> And why do you add -gdwarf-2 in dg-options? AFAICS all tests in >> gcc.dg/debug/dwarf2 are built with -gdwarf-2 anyway. > > Do they? Not here. > > Executing on host: /daten/aranym/gcc/gcc-20130530/Build/gcc/xgcc > -B/daten/aranym/gcc/gcc-201305

Re: [PATCH] Fix incorrect discriminator assignment.

2013-05-31 Thread Rainer Orth
Dehao Chen writes: > On Thu, May 30, 2013 at 10:41 AM, Cary Coutant wrote: >>> That's weird cause in dwarf2.exp: >>> >>> # If a testcase doesn't have special options, use these. >>> global DEFAULT_CFLAGS >>> if ![info exists DEFAULT_CFLAGS] then { >>> set DEFAULT_CFLAGS " -ansi -pedantic-err

[PATCH] Disable no-section-anchors-vect-68.C for aarch64 tiny memory model.

2013-05-31 Thread Marcus Shawcroft
The vect/no-section-anchors-vect-68.C test case results in a binary that is tool large for the aarch64 tiny memory model. This patch disables the test case for that memory model. /Marcus 2013-05-31 Marcus Shawcroft * gcc.dg/vect/no-section-anchors-vect-68.c: Add dg-skip-if

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Uros Bizjak
On Fri, May 31, 2013 at 1:38 PM, Igor Zamyatin wrote: > We do want to use the same register for float_extend. OK then. Please add a comment for this fact and also, please put single-line preparation statements inside double-quotes instead of curved braces. Uros. > On Thu, May 30, 2013 at 9:22 P

Re: [fixincludes] solaris_pow_int_overload should use __cplusplus

2013-05-31 Thread Jakub Jelinek
On Fri, May 31, 2013 at 01:35:14PM +0200, Rainer Orth wrote: > Jakub, with the release of 4.8.1, is the patch ok for the 4.8 branch > now? Ok. Jakub

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-05-31 Thread Igor Zamyatin
We do want to use the same register for float_extend. On Thu, May 30, 2013 at 9:22 PM, Uros Bizjak wrote: > On Thu, May 30, 2013 at 4:25 PM, Yuri Rumyantsev wrote: >> Hi All >> >> Second patch enables several Silvermont uarch features which improve >> performance of the new processor (based on e

Re: [fixincludes] solaris_pow_int_overload should use __cplusplus

2013-05-31 Thread Rainer Orth
Rainer Orth writes: > Bruce Korb writes: > >> On 05/16/13 06:41, Rainer Orth wrote: >>> Work is going on to incorporate all applicable fixincludes fixes into >>> the Solaris headers proper. One fix is currently problematic since it >>> uses an G++-internal macro (__GXX_EXPERIMENTAL_CXX0X__) whe

Re: [ada, build] host/target configuration

2013-05-31 Thread Thomas Schwinge
Hi! On Fri, 31 May 2013 13:14:39 +0200, Eric Botcazou wrote: > > Do you mean arm-linux-androideabi, or arm-none-linux-androideabi? > > Thr former, but I guess that we want to support the latter as well. In my reading, the code supported both these before your recent change, and now supports nei

Fix gcc.dg/shrink-wrap-alloca.c

2013-05-31 Thread Rainer Orth
The new gcc.dg/shrink-wrap-alloca.c FAILs on 64-bit Solaris 10/x86: Excess errors: /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/shrink-wrap-alloca.c:4:14: warning: conflicting types for built-in function 'alloca' [enabled by default] The following patch fixes it by using __builtin_alloca, as

Re: [ada, build] host/target configuration

2013-05-31 Thread Eric Botcazou
> Do you mean arm-linux-androideabi, or arm-none-linux-androideabi? Thr former, but I guess that we want to support the latter as well. -- Eric Botcazou

Re: C++ PATCH for c++/52377 (NSDMI and unions)

2013-05-31 Thread Rainer Orth
Jason Merrill writes: > sort_mem_initializers was skipping over all fields without a > mem-initializer, even ones with an NSDMI. One of the testcases doesn't compile on Solaris 10/x86: output is: /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/cpp0x/nsdmi-union2.C:4:7: error: multiple fields

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Janne Blomqvist
On Fri, May 31, 2013 at 1:21 PM, Janus Weil wrote: > Hi Manfred, > >>> Attached is a small patch with an alternative implementation (borrowed >>> from ada/terminals.c). It is not portable to all systems, but at least >>> it does actually work on my openSUSE box. Is this something we want to >>> ha

Re: [rs6000] Improve FP comparisons with -fno-trapping-math

2013-05-31 Thread Eric Botcazou
> I'm okay with most of the change, but I have a question: What happened > to the unsigned comparisons and LTGT? Unsigned comparisons aren't used for FP (the whole block of code is dominated by a FLOAT_MODE_P (mode) test). LTGT and UNEQ were wrong (but unused) since they were implemented as NE

[PATCH] Fix pr54684.C regression for arm*-*-*

2013-05-31 Thread Marcus Shawcroft
Since http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01475.html introduced a warning for bit field types with width greater than the contained enum width pr54684.C has failed for arm*-*-* due to the extra diagnostic emitted. This patch disables short-enums in the test case. OK? /M 2013-05-31

[PATCH] Fix eb76.C regression for arm*-*-*

2013-05-31 Thread Marcus Shawcroft
Since http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01475.html introduced a warning for bit field types with width greater than the contained enum width eb76.C has failed for arm*-*-* due to the extra diagnostic emitted. This patch disables short-enums in the test case. OK? /M 2013-05-31 M

[PATCH] Fix failing pr56184.C

2013-05-31 Thread Marcus Shawcroft
Since http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01475.html introduced a warning for bit field types with width greater than the contained enum width pr56184.C has failed for arm*-*-* due to the extra diagnostic emitted. This patch disables short-enums in the test case. OK? /M 2013-05-31

Re: [PATCH] Add testcase for PR57478

2013-05-31 Thread Richard Biener
On Fri, 31 May 2013, Marek Polacek wrote: > This adds a reduced testcase for PR57478. > Regtested on x86_64-linux. Ok for trunk? Ok. Thanks, Richard. > 2013-05-31 Marek Polacek > > PR tree-optimization/57478 > PR tree-optimization/57453 > * gcc.dg/torture/pr57478.c: New t

[PATCH] Add testcase for PR57478

2013-05-31 Thread Marek Polacek
This adds a reduced testcase for PR57478. Regtested on x86_64-linux. Ok for trunk? 2013-05-31 Marek Polacek PR tree-optimization/57478 PR tree-optimization/57453 * gcc.dg/torture/pr57478.c: New test. --- gcc/testsuite/gcc.dg/torture/pr57478.c.mp2 2013-05-31 11:31:27.

Re: [ada, build] host/target configuration

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 10:03, Eric Botcazou ha scritto: >> I don't understand this change. This used to match configurations >> arm*-[vendor]-linux-androideabi; now it only matches >> arm*-[vendor]-androideabi, which isn't in use (for a Android system is >> always based on the Linux kernel, in my understan

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Manfred Schwarb
Am 31.05.2013 12:21, schrieb Janus Weil: Hi Manfred, Attached is a small patch with an alternative implementation (borrowed from ada/terminals.c). It is not portable to all systems, but at least it does actually work on my openSUSE box. Is this something we want to have for gfortran? # cat >

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Janus Weil
Hi Manfred, >> Attached is a small patch with an alternative implementation (borrowed >> from ada/terminals.c). It is not portable to all systems, but at least >> it does actually work on my openSUSE box. Is this something we want to >> have for gfortran? >> > > # cat >term.c < #include > #includ

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Manfred Schwarb
Am 31.05.2013 10:47, schrieb Janus Weil: Attached is a small patch with an alternative implementation (borrowed from ada/terminals.c). It is not portable to all systems, but at least it does actually work on my openSUSE box. Is this something we want to have for gfortran? # cat >term.c < #in

Re: [PATCH, rs6000] power8 patches, patch #4, new power8 builtins

2013-05-31 Thread Segher Boessenkool
Ok, I tracked down what the problem is. We never implemented the EQV, ORC, or NAND insns in the GPRs. When I added the power8 vector versions, the split wide types pass tried to do its thing in the GPRs, it creates a bad insn. I originally saw it in the atomic ops, because I was testing al

Re: [Patch, Fortran] PR57456 - Handle ALLOCATE with typespec for CLASS

2013-05-31 Thread Janus Weil
>> Currently, ALLOCATE ignores the typespec for arrays. Such that: >>ALLOCATE (t2 :: var(5)) >> will allocate as much memory as the base type requires instead of using as >> much as "t2" does. >> >> >> I explicitly exclude characters as it otherwise will fail for >> allocate_with_typespec_1.f90

Re: [PATCH][ARM] PR56315 Improve code generation for DImode IOR

2013-05-31 Thread Richard Earnshaw
On 31/05/13 09:46, Kyrylo Tkachov wrote: Hi all, This patch improves code generation for DImode bitwise IOR operations for arm. The expander can now handle immediate values and the define_insn is changed to an insn_and_split. The NEON version is merged with the scalar version. For code: unsi

Re: PR57073 - Optimize __builtin_powif (-1.0, k) to k & 1 ? -1.0 : 1.0

2013-05-31 Thread Richard Biener
On Fri, May 31, 2013 at 10:57 AM, Tobias Burnus wrote: > Richard Biener wrote: >> >> Why sink the !host_integerp check? Please keep it where it is now. >> Then >> >> + if (real_minus_onep (arg0) >> + && TREE_CODE (TREE_TYPE (arg1)) == INTEGER_TYPE >> >> this ch

Re: PR57073 - Optimize __builtin_powif (-1.0, k) to k & 1 ? -1.0 : 1.0

2013-05-31 Thread Tobias Burnus
Richard Biener wrote: Why sink the !host_integerp check? Please keep it where it is now. Then + if (real_minus_onep (arg0) + && TREE_CODE (TREE_TYPE (arg1)) == INTEGER_TYPE this check is redundant, too. Good point - I will commit the patch below after anot

[PATCH] Fix PRs 57478 / 57453

2013-05-31 Thread Richard Biener
The following fixes the bug I already fixed more thoroughly. Tested on x86_64-unknown-linux-gnu, committed as obvious. Richard. 2013-05-31 Richard Biener PR tree-optimization/57478 PR tree-optimization/57453 * tree-vect-slp.c (vect_bb_slp_scalar_cost): Uses in PHI no

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Janus Weil
Hi, >> In addition to this, the patch contains a part which concerns the >> function 'gfc_terminal_width': Currently this returns a fixed value of >> 80, which means that all source lines are trimmed to 80 characters in >> the error messages. I increased this default value to 132 (in order to >> a

[PATCH][ARM] PR56315 Improve code generation for DImode IOR

2013-05-31 Thread Kyrylo Tkachov
Hi all, This patch improves code generation for DImode bitwise IOR operations for arm. The expander can now handle immediate values and the define_insn is changed to an insn_and_split. The NEON version is merged with the scalar version. For code: unsigned long long or64 (unsigned long long inpu

Re: PR 57452

2013-05-31 Thread Richard Biener
On Thu, May 30, 2013 at 11:51 PM, Iyer, Balaji V wrote: > Hello Everyone, > One of the test in Cilk Plus array notation execution test for C was > wrong. Here is a fixed one: > > Here is the Change log entry for it: > > 2013-05-30 Balaji V. Iyer > > PR c/57452 > * c-c++

Re: PR57073 - Optimize __builtin_powif (-1.0, k) to k & 1 ? -1.0 : 1.0

2013-05-31 Thread Richard Biener
On Thu, May 30, 2013 at 10:54 PM, Jeff Law wrote: > On 05/30/2013 02:38 PM, Tobias Burnus wrote: >> >> >> I am a bit lost. The code quoted above is the old code - just moved down >> a bit. It is supposed to handle powi(x,n) for unknown x with known n - >> while the new code handles x == -1.0 for u

  1   2   >