Re: [PATCH] fix for pr 57474

2013-06-01 Thread Dominique Dhumieres
... This patch pasted below should fix that issue. ... A quick test on darwin (no bootstrap, no full regtest) with make -k check-gcc RUNTESTFLAGS=cilk-plus.exp --target_board=unix'{-m32,-m64}' gives === gcc Summary for unix/-m64 === # of expected passes2904

Re: Fix PR57268

2013-06-01 Thread Jakub Jelinek
On Sat, Jun 01, 2013 at 08:39:58AM +0400, Dinar Temirbulatov wrote: oh, This is my mistake I should have bootstrap the compiler. That is a requirement for most of commits, see http://gcc.gnu.org/contribute.html for the exact rules. I am investigating the problem. I'd guess you don't want to

Re: [Patch, Fortran] PR57456 - Handle ALLOCATE with typespec for CLASS

2013-06-01 Thread Tobias Burnus
Dominique Dhumieres wrote: As written the test in gfortran.dg/class_array_17.f90 is a no-op Well spotted! Thanks for the report. I have committed the attached patch as obvious, Rev. 199573. Tobias PS: I realized that I should have put your name in the ChangeLog as you found and patched

[Patch, Fortran] Detecting the terminal width

2013-06-01 Thread Janus Weil
Index: gcc/fortran/error.c === --- gcc/fortran/error.c (revision 199530) +++ gcc/fortran/error.c (working copy) @@ -30,6 +30,13 @@ along with GCC; see the file COPYING3. If not see #include flags.h #include

[Patch, Fortran] PR57496 use finiteq etc. for __float in write_float.def

2013-06-01 Thread Tobias Burnus
Found when looking at the issue of the PR, but unrelated. For __float128, we have to use the libquadmath functions - not the long double ones. The patch is rather obvious, though I wonder whether it could clash with some #defines of the system headers on some systems. Build and regtested

Re: [c++-concepts]

2013-06-01 Thread Andrew Sutton
* Check against cxx11 dialect, not cxx0x. This check is actually all over parser.c, the reason it shows up in the patch is that I reverted a previous change that affected some code that included it. I'd feel better leaving it in, since its a change that could affect some other part of the

[Patch, Fortran] Show better error location

2013-06-01 Thread Tobias Burnus
I am still not happy with changing the length of the displayed source-code in error messages to infinity if not terminal is available. One reason is that for long lines (e.g. generated code or long trailing comment lines) - the output is not very readable. And that the terminal is not

Re: Fix PR57268

2013-06-01 Thread Jakub Jelinek
On Sat, Jun 01, 2013 at 10:11:24AM +0200, Jakub Jelinek wrote: On Sat, Jun 01, 2013 at 08:39:58AM +0400, Dinar Temirbulatov wrote: I am investigating the problem. I'd guess you don't want to flush on DEBUG_INSN_Ps, because then you'd flush differently between -g and -g0. So perhaps

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Jakub Jelinek
On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote: Like this? Sorry for nitpicking, but there are various formatting issues. + if (ix86_tune == PROCESSOR_SLM) +{ + if (has_scale) +return true; + if (split_cost 1) +return false; + if (regno0 ==

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Robert Dewar
On 6/1/2013 9:52 AM, Jakub Jelinek wrote: Sorry for nitpicking, but there are various formatting issues. A number of these formatting issues could be easily detected by the compiler. It might be really useful to add a switch to do such detection. For Ada, the GNAT compiler has -gnatyg which

RE: [PATCH] fix for pr 57474

2013-06-01 Thread Iyer, Balaji V
-Original Message- From: Dominique Dhumieres [mailto:domi...@lps.ens.fr] Sent: Saturday, June 01, 2013 2:35 AM To: gcc-patches@gcc.gnu.org; Iyer, Balaji V Cc: domi...@lps.ens.fr Subject: Re: [PATCH] fix for pr 57474 ... This patch pasted below should fix that issue. ... A

Re: [Patch, Fortran] Show better error location

2013-06-01 Thread Mikael Morin
On 01.06.2013 14:51, Tobias Burnus wrote: I am still not happy with changing the length of the displayed source-code in error messages to infinity if not terminal is available. One reason is that for long lines (e.g. generated code or long trailing comment lines) - the output is not very

Re: [x86, PATCH 2/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Jakub Jelinek
On Sat, Jun 01, 2013 at 03:52:55PM +0200, Jakub Jelinek wrote: On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote: Like this? Sorry for nitpicking, but there are various formatting issues. Also: if (clock1 == clock2) { /* Determine winner - load must win. */

Re: [Patch, Fortran] Show better error location

2013-06-01 Thread Tobias Burnus
Am 01.06.2013 16:06, schrieb Mikael Morin: For the redirection to less, one can use less -S. Still, that does not help if the output is excessively long. Try some C (or C++) long code (e.g. 30,000 lines long), do a minor mistake there and run it through topformflat 0 x in.c out.c and

[PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-01 Thread Dehao Chen
This patch fixes the bug that when include a header file, if the header file is already included (with #define _HEADER_H_), libcpp should not decrease its highest_location, otherwise it'll cause incorrect source location when source location numbers are large enough to omit columns. Passed

Re: [c++-concepts]

2013-06-01 Thread Gabriel Dos Reis
On Sat, Jun 1, 2013 at 6:56 AM, Andrew Sutton andrew.n.sut...@gmail.com wrote: * Check against cxx11 dialect, not cxx0x. This check is actually all over parser.c, the reason it shows up in the patch is that I reverted a previous change that affected some code that included it. I'd feel

Re: [Patch, Fortran] Detecting the terminal width

2013-06-01 Thread Mikael Morin
Le 01/06/2013 10:42, Janus Weil a écrit : Ok. Unfortunately I'm not much of a autoconf hero (better to say: not at all). Any person using autoconf is some of a hero. ;-) I can not test it on my system with --enable-maintainer-mode because I get: configure.ac:2: error: Please use exactly

PR middle-end/57467

2013-06-01 Thread Jan Hubicka
Hi, local passes are allowed to create new functions. The main iterator should however only deal with those that was already there before. This broke with my part 1 symtab cleanup patch, since I changed FOR_EACH_DEFINED_FUNCTION to test node-definition instead of node-analyzed. Hopefully there

[c++-concepts] constraints

2013-06-01 Thread Andrew Sutton
This patch adds constraint checking and overloading for function templates, class templates, and alias templates. This patch isn't as big as it seems, it just touches the compiler in a lot of different places. 2013-06-01 Andrew Sutton andrew.n.sut...@gmail.com * gcc/cp/call.c

PR middle-end/57366

2013-06-01 Thread Jan Hubicka
Hi, this patch fixes problems with weakref and LTO on non-weakref configurations. Here the weakrefs are transparently removed by GCC via somewhat weird machinery. DECL_ASSEMLBLER name gets flag IDENTIFIER_TRANSPARENT_ALIAS and the TREE_CHAIN makes assembler output routies to output instead of

[PATCH, alpha]: Fix ICE with conditional moves using DFmode compare with zero.

2013-06-01 Thread Uros Bizjak
Hello! Attached patch fixes FAIL: c-c++-common/cilk-plus/AN/builtin_fn_mutating.c -O3 cilkplus failure on alpha [1]. The problem was triggered only with -O3, due to direct expansion of conditional move. The attached patch swaps all compares, modulo DImode compares with zero, in the same way as

Re: Implement N3642 - User-defined Literals for Standard Library Types

2013-06-01 Thread Ed Smith-Rowland
Committed the following... 2013-05-30 Ed Smith-Rowland 3dw...@verizon.net Implement N3642 - User-defined Literals for Standard Library Types * include/bits/parse_numbers.h: New. * include/std/chrono: Add duration literal operators. *

Re: [Patch, Fortran] PR57496 use finiteq etc. for __float in write_float.def

2013-06-01 Thread Tobias Burnus
Regarding REAL(10): I tried to find out what goes wrong in that case, but I failed. I would really appreciate some help. See PR57496. My feeling is that the error is related to x87 FPU vs. CPU handling, but I failed to understand why and when it happens. Regarding REAL(16): Tobias Burnus

Re: [Patch, Fortran] Detecting the terminal width

2013-06-01 Thread Janus Weil
Ok. Unfortunately I'm not much of a autoconf hero (better to say: not at all). Any person using autoconf is some of a hero. ;-) Totally ... I can not test it on my system with --enable-maintainer-mode because I get: configure.ac:2: error: Please use exactly Autoconf 2.64 instead of 2.69.

Re: Implement N3642 - User-defined Literals for Standard Library Types

2013-06-01 Thread Paolo Carlini
Hi, Ed Smith-Rowland 3dw...@verizon.net ha scritto: Committed the following... Looks like great work, thanks! I'm still in vacations, and barely reading email on a small screen, just wanted to point out that apparently the patch has a few redundant inline preceding constexpr. Could you

Re: RS6000 PATCH for c++/57415 (ICE on altivec tests)

2013-06-01 Thread David Edelsohn
On Fri, May 31, 2013 at 10:45 PM, Jason Merrill ja...@redhat.com wrote: The issue here was that rs6000-c.c was creating COMPOUND_LITERAL_EXPR, which the C++ front end doesn't understand. For C++ let's create TARGET_EXPRs instead. Tested powerpc64-unknown-linux-gnu. OK for trunk? The patch

Re: [x86, PATCH 1/2] Enabling of the new Intel microarchitecture Silvermont

2013-06-01 Thread Jakub Jelinek
On Wed, May 29, 2013 at 11:35:29AM +0200, Uros Bizjak wrote: 2013-05-27 Yuri Rumyantsev yuri.s.rumyant...@intel.com Igor Zamyatin igor.zamya...@intel.com Much more importantly, (fold_builtin_cpu): Add slm. the above: * libgcc/config/i386/cpuinfo.c

Re: Symtab cleanups 2/17 - merge alias code

2013-06-01 Thread David Edelsohn
Honza, This patch introduces 45 new libstdc++ testsuite failure for AIX. Program received signal SIGSEGV, Segmentation fault. _Z20ipa_record_referenceP15symtab_node_defS0_11ipa_ref_useP18gimple_statement_d (referring_node=0x70d3ad58, referred_node=0x0, use_type=IPA_REF_ALIAS, stmt=0x0)

[libstdc++-v3] Collapse redundant 'inline' from 'inline constexpr'.

2013-06-01 Thread Ed Smith-Rowland
All, Paolo Carlini pointed out that I introduced a number of 'inline constexpr' in my last std literals patch. Section 7.1.5/2: constexpr functions and constexpr constructors are implicitly inline (7.1.2). I noticed that there are two other headers that have this. Does anyone mind if i just

Re: [libstdc++-v3] Collapse redundant 'inline' from 'inline constexpr'.

2013-06-01 Thread Gabriel Dos Reis
please go ahead. -- Gaby

Re: [libstdc++-v3] Collapse redundant 'inline' from 'inline constexpr'.

2013-06-01 Thread Ed Smith-Rowland
On 06/01/2013 05:29 PM, Gabriel Dos Reis wrote: please go ahead. -- Gaby Done.

PING^2 [libitm,PATCH] Fix bootstrap due to __always_inline in libitm

2013-06-01 Thread Gerald Pfeifer
[ I could not identify who approved the original patch, but believe it was one of Richi, Jakub or RTH, so I hope one of you can approve this. Andi acked the previous submission, but cannot approve. ] The following patch broke bootstrap on all FreeBSD platforms, which took me a bit to

[GOOGLE] Fix uninitialized memory in AutoFDO implementation

2013-06-01 Thread Dehao Chen
This patch fixes an uninitialized memory error and a hashtable comparison bug in AutoFDO. Bootstrapped and passed regression test. OK for google branches? Thanks, Dehao Index: gcc/auto-profile.c === --- gcc/auto-profile.c

Re: [GOOGLE] Fix uninitialized memory in AutoFDO implementation

2013-06-01 Thread Xinliang David Li
ok. David On Sat, Jun 1, 2013 at 9:05 PM, Dehao Chen de...@google.com wrote: This patch fixes an uninitialized memory error and a hashtable comparison bug in AutoFDO. Bootstrapped and passed regression test. OK for google branches? Thanks, Dehao Index: gcc/auto-profile.c