Re: [PATCH, AArch64] Remove unused types and variables for abi types

2013-07-03 Thread Marcus Shawcroft
On 02/07/13 15:14, Yufeng Zhang wrote: gcc/ * config/aarch64/aarch64.h (enum arm_abi_type): Remove. (ARM_ABI_AAPCS64): Ditto. (arm_abi): Ditto. (ARM_DEFAULT_ABI): Ditto. OK /Marcus

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-07-03 Thread Phil Muldoon
On 13/06/13 14:49, Tom Tromey wrote: >> "Phil" == Phil Muldoon writes: > > Phil> Attached is an updated patch correcting the issues that you pointed > Phil> out. > > The patch itself looks fine to me, but I don't think I can approve it. > > Tom This new patch replaces and obsoletes the pre

Re: [PATCH] Fix for PR c/57490

2013-07-03 Thread Rainer Orth
"Iyer, Balaji V" writes: >> -Original Message- >> From: Jakub Jelinek [mailto:ja...@redhat.com] >> Sent: Monday, July 01, 2013 1:09 PM >> To: Iyer, Balaji V >> Cc: gcc-patches@gcc.gnu.org; Rainer Orth >> Subject: Re: [PATCH] Fix for PR c/57490 >> >> On Mon, Jul 01, 2013 at 05:02:57PM +00

Re: [AArch64] Convert ld1, st1 arm_neon.h intrinsics to RTL builtins.

2013-07-03 Thread Marcus Shawcroft
On 02/07/13 10:01, James Greenhalgh wrote: 2013-07-02 James Greenhalgh * config/aarch64/aarch64-builtins.c (aarch64_simd_expand_builtin): Handle AARCH64_SIMD_STORE1. * config/aarch64/aarch64-simd-builtins.def (ld1): New. (st1): Likewise. * config/aarch

[gomp4] Compiler side of the cancellation support

2013-07-03 Thread Jakub Jelinek
Hi! This is the compiler side of the #pragma omp cancel and #pragma omp cancellation point support. On the library side what is needed is: 1) GOMP_cancellation_point now returns a bool (whether the relevant cancellation was observed) 2) GOMP_cancel now has two arguments instead of just one, an

[linaro/gcc-4_8-branch] Backports from trunk

2013-07-03 Thread Christophe Lyon
Hi, I have just committed backports of the following revisions from trunk to linaro/gcc-4_8-branch: r199640, 199705, 199733, 199734, 199739 grouped as r200640. Thanks, Christophe.

[Patch, Fortran] PR57785 - Fix folding of dot_product for complex vars

2013-07-03 Thread Tobias Burnus
Pending patches:http://gcc.gnu.org/ml/fortran/2013-07/msg2.html Thanks goes to Dominique for debugging the issue! Build and regtested on x86-64-gnu-linux. OK for the trunk? I think one should also backport it to 4.7/4.8. (Folding - and hence the bug - exist since GCC 4.5.) Tobias 2013-07

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-07-03 Thread Kugan
On 17/06/13 18:33, Richard Biener wrote: On Mon, 17 Jun 2013, Kugan wrote: +/* Extract the value range of assigned exprassion for GIMPLE_ASSIGN stmt. + If the extracted value range is valid, return true else return + false. */ +static bool +extract_exp_value_range (gimple stmt, value_range_t

Re: [Patch, Fortran] PR57785 - Fix folding of dot_product for complex vars

2013-07-03 Thread Dominique Dhumieres
Dear Tobias, The patch is OK, but you may consider the following remarks: (1) a comment before + c = gfc_simplify_conjg (a); reminding the definition of the complex dot product. (2) I don't like the scan-tree-dump: they are fragile and have a limited coverage. I'ld prefer a test su

MIPS elimate trap-if-zero instruction if possible for divisions

2013-07-03 Thread Graham Stott
Hi Richard,   This patch attemps to elimate the TEQ instruction div DIV/MOD instructions if possible (i.e the numerator is known to be non-zero)   I have introduced and seperated UNSPEC UNSPEC_SET_HILO_NOTRAP which is generation by a peephole2 when the trap is known not to be required.   The peepho

RFC DIVMOD expansion in expand_divmod:expmed.c

2013-07-03 Thread Graham Stott
All,   The DIV/MOD expansion performed in expmed is basically driven by RTX costs/-Os that are provided by the backend.In a few instances these costs and or _os appear to be ignored.   One senerio  is divsion by a constant in a mode whose size <= HOST_BITS_PER_WIDE_INT it will always expand the D

MIPS don't gererate MUL when muliplying by constant of for 2^N +/- 1 optimizing for size

2013-07-03 Thread Graham Stott
Hi Richard,   When -Os is used  and the multiplier is of the for 2^N +- 1 we generate a MUL instruction rather that a  shift-left   N and add-sub 1.   The problem is that rtx cost for the MUL is too cheap causing the shift-left and add-sub sequence to be  more expensive.   This patch makes the MU

[C++ PATCH] Fix up static_cast/reinterpret_cast parsing in template argument (PR c++/57771)

2013-07-03 Thread Jakub Jelinek
Hi! When parsing static_cast (expression) part inside of template argument, greater_than_is_operator_p isn't temporarily set and thus the parser considers >> in C++11 there as end of the the template argument, despite this appearing before terminating ). Fixed thusly, bootstrapped/regtested on x8

[PATCH] Fix up gather addressing in -m64 -fpic code (PR target/57777)

2013-07-03 Thread Jakub Jelinek
Hi! In 64-bit PIC mode, we allow SYMBOL_REF/LABEL_REF or that + constant offset as disp, because we can use %rip addressing in that case, but as VSIB addressing doesn't allow %rip addressing, we have to disallow even those. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok f

Fix missing use of -Werror when compiling files in c-familty directory

2013-07-03 Thread Graham Stott
All,     Files in the c-family directory are being compiled during stage3 without -Werror and other warningb flags that are part of WARN_STRICT flags.   Fixing this shows that array_notation_common.c  generates unused variable warnings and will break the build after the apcth is applied.     Chan

Committed: fix for frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2013-07-03 Thread Hans-Peter Nilsson
Eric Botcazou asked that I re-apply this previously reverted patch, so here goes. Bootstrapped+regression-test x86_64-unknown-linux-gnu at r200585 with and without -m32. The 32-bit i686-* aka. -m32 previously exposed PR55030. Though that PR was originally about the regression causing the revert,

Re: Fix missing use of -Werror when compiling files in c-familty directory

2013-07-03 Thread Joseph S. Myers
On Wed, 3 Jul 2013, Graham Stott wrote: > Files in the c-family directory are being compiled during stage3 without > -Werror and other warningb flags that are part of WARN_STRICT flags. > Fixing this shows that array_notation_common.c? generates unused > variable warnings and will break the buil

[libobjc]: Allow SjLj for x64 windows target

2013-07-03 Thread Kai Tietz
Hi, this patch fixes Obj-C's exception handling code for SEH x64. For it the guard for forcing SjLj was missing and therefore leads to issues, if OP wants to force SjLj. ChangeLog 2013-07-03 Kai Tietz * exception.c: Add check for SjLj to SEH blocks. Tested for x86_64-w64-mingw32, and i

Fix ununsed variables before my patch adding missing -Werror

2013-07-03 Thread Graham Stott
  This patch fixes the warnings from array-notation_common.c so that I can then apply my Makefile missing -Werror patch.   Graham   ChangeLog 03-07-2013  graham.stott  graham.st...@btinternet.com * c-familly/array_notation_comon.c (length_mismatch_expr_p): Delete unused     var

Re: Fix missing use of -Werror when compiling files in c-familty directory

2013-07-03 Thread Chung-Ju Wu
Hi, Graham, 2013/7/3 Graham Stott : > All, > > Files in the c-family directory are being compiled during stage3 without > -Werror and > other warningb flags that are part of WARN_STRICT flags. > > Fixing this shows that array_notation_common.c generates unused variable > warnings > and will bre

Re: Fix missing use of -Werror when compiling files in c-familty directory

2013-07-03 Thread Chung-Ju Wu
2013/7/3 Joseph S. Myers : > On Wed, 3 Jul 2013, Graham Stott wrote: > >> Files in the c-family directory are being compiled during stage3 without >> -Werror and other warningb flags that are part of WARN_STRICT flags. >> Fixing this shows that array_notation_common.c generates unused >> variable

Re: [PATCH, rs6000] PR target/57150, do not use VSX instructions for long double caller saves

2013-07-03 Thread Joseph S. Myers
On Fri, 3 May 2013, Michael Meissner wrote: > 2013-05-03 Michael Meissner > > PR target/57150 > * config/rs6000/rs6000.h (HARD_REGNO_CALLER_SAVE_MODE): Use DFmode > to save TFmode registers and DImode to save TImode registers for > caller save operations. > (HARD_

Re: Fix missing use of -Werror when compiling files in c-familty directory

2013-07-03 Thread Chung-Ju Wu
2013/7/4 Chung-Ju Wu : >> On Wed, 3 Jul 2013, Graham Stott wrote: >> >>> Files in the c-family directory are being compiled during stage3 without >>> -Werror and other warningb flags that are part of WARN_STRICT flags. >>> Fixing this shows that array_notation_common.c generates unused >>> variabl

Re: [c++-concepts] requires expression semantics

2013-07-03 Thread Jason Merrill
On 07/01/2013 01:27 PM, Andrew Sutton wrote: Unfortunately, the behavior differs from the test suite for std::is_convertible. In particular, this fails: static_assert(__is_convertible_to(int(int), int(&)(int)), ""); whereas this succeeds ) static_assert(is_convertible::value, ""); Hmm, tha

Re: [C++ PATCH] Fix up static_cast/reinterpret_cast parsing in template argument (PR c++/57771)

2013-07-03 Thread Jason Merrill
OK. Jason

[gomp4] 3 minor OpenMP parsing tweaks

2013-07-03 Thread Jakub Jelinek
Hi! I've noticed today or recently 3 separate issues that this patch attempts to address. 1) the sections syntax is (and has been that way already back in OpenMP 2.5): #pragma omp sections [clause[[,] clause] ...] new-line { [#pragma omp section new-line] structured-block [#pragma omp sectio

Re: MIPS don't gererate MUL when muliplying by constant of for 2^N +/- 1 optimizing for size

2013-07-03 Thread Richard Sandiford
Graham Stott writes: > When -Os is used and the multiplier is of the for 2^N +- 1 we generate > a MUL instruction rather that a shift-left N and add-sub 1. > > The problem is that rtx cost for the MUL is too cheap causing the > shift-left and add-sub sequence to be more expensive. > > This patch

Re: [libobjc]: Allow SjLj for x64 windows target

2013-07-03 Thread Andrew Pinski
On Wed, Jul 3, 2013 at 8:11 AM, Kai Tietz wrote: > Hi, > > this patch fixes Obj-C's exception handling code for SEH x64. For it > the guard for forcing SjLj was missing and therefore leads to issues, > if OP wants to force SjLj. > > ChangeLog > > 2013-07-03 Kai Tietz > > * exception.c: Add

Re: MIPS elimate trap-if-zero instruction if possible for divisions

2013-07-03 Thread Richard Sandiford
Graham Stott writes: > Hi Richard, > > This patch attemps to elimate the TEQ instruction div DIV/MOD instructions > if possible (i.e the numerator is known to be non-zero) > > I have introduced and seperated UNSPEC UNSPEC_SET_HILO_NOTRAP > which is generation by a peephole2 when the trap is kn

Re: MIPS elimate trap-if-zero instruction if possible for divisions

2013-07-03 Thread Jeff Law
On 07/03/13 11:42, Richard Sandiford wrote: Graham Stott writes: Hi Richard, This patch attemps to elimate the TEQ instruction div DIV/MOD instructions if possible (i.e the numerator is known to be non-zero) I have introduced and seperated UNSPEC UNSPEC_SET_HILO_NOTRAP which is generation by

Re: [gomp4] 3 minor OpenMP parsing tweaks

2013-07-03 Thread Richard Henderson
On 07/03/2013 10:30 AM, Jakub Jelinek wrote: > 2013-07-03 Jakub Jelinek > > * omp-low.c (expand_omp_single): Don't force barrier for > copyprivate. > gcc/c/ > * c-parser.c (c_parser_omp_atomic): Disallow seq_cst before > atomic-clause, disallow comma in between atomic-cl

Re: [Google] Fix discriminator assignment for stmts

2013-07-03 Thread Cary Coutant
> - locus = location_with_discriminator ( > - locus, next_discriminator_for_locus (locus)); > + discriminator = next_discriminator_for_locus (locus); > > - if (block != NULL) > -locus = COMBINE_LOCATION_DATA (line_table, locus, block); > - >for (gsi = gsi_start_bb (bb); !gsi_end_p (

RE: [patch] ICE with combination of -openmp and -femit-struct-debug-reduced/baseonly

2013-07-03 Thread Evgeny Gavrin
> Do you have a copyright assignment on file with FSF? Signed form was already received by the copyright clerk. So I hope I'll be able to commit by myself soon. /* With optimism, Evgeny Gavrin email : evgeny.gav...@hotmail.com */ > Date: Tue, 2 Jul 2013 1

Re: [patch] ICE with combination of -openmp and -femit-struct-debug-reduced/baseonly

2013-07-03 Thread Cary Coutant
>> Do you have a copyright assignment on file with FSF? > Signed form was already received by the copyright clerk. So I hope I'll be > able to commit by myself soon. Great! Before you commit, please prepare a ChangeLog entry and post it for review. -cary

Re: [Google] Fix discriminator assignment for stmts

2013-07-03 Thread Dehao Chen
On Wed, Jul 3, 2013 at 11:25 AM, Cary Coutant wrote: > > > - locus = location_with_discriminator ( > > - locus, next_discriminator_for_locus (locus)); > > + discriminator = next_discriminator_for_locus (locus); > > > > - if (block != NULL) > > -locus = COMBINE_LOCATION_DATA (line_table

Re: [PATCH] Fix up gather addressing in -m64 -fpic code (PR target/57777)

2013-07-03 Thread Richard Henderson
On 07/03/2013 07:20 AM, Jakub Jelinek wrote: > 2013-07-02 Jakub Jelinek > > PR target/5 > * config/i386/predicates.md (vsib_address_operand): Disallow > SYMBOL_REF or LABEL_REF in parts.disp if TARGET_64BIT && flag_pic. > > * gcc.target/i386/pr5.c: New test. Ok

Re: [Google] Fix discriminator assignment for stmts

2013-07-03 Thread Dehao Chen
Please ignore the original patch, which is wrong. New patch updated, passed regression test. Dehao On Wed, Jul 3, 2013 at 1:00 PM, Dehao Chen wrote: > On Wed, Jul 3, 2013 at 11:25 AM, Cary Coutant wrote: >> >> > - locus = location_with_discriminator ( >> > - locus, next_discriminator_for_

[PING] Re: C++ 2014 status page for libstdc++

2013-07-03 Thread Ed Smith-Rowland
On 06/27/2013 11:24 PM, Ed Smith-Rowland wrote: On 06/27/2013 07:01 AM, Jonathan Wakely wrote: On 26 June 2013 02:28, Ed Smith-Rowland wrote: On 06/25/2013 11:59 AM, Jonathan Wakely wrote: On 25 June 2013 16:45, <3dw...@verizon.net> wrote: Here is a C++2014 status page for fun and profit. Ex

Re: [Google] Fix discriminator assignment for stmts

2013-07-03 Thread Cary Coutant
> Please ignore the original patch, which is wrong. New patch updated, > passed regression test. + for (i = next_discriminator_location - min_discriminator_location - 1; + i >= 0 && LOCATION_LINE (discriminator_location_locations[i]) == + LOCATION_LINE (locus) && + discriminator_locat

[C++ Patch] PR 38634 (Take 2)

2013-07-03 Thread Paolo Carlini
Hi, today I was going through some pending issues, and decided to rework my first try at fixing this very old ICE on invalid: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00480.html In the first try, bailing out early in case of error without undoing the committed changes to decl1 made m