Re: [PATCH] Fix illegal cast to rtx (*insn_gen_fn) (rtx, ...)

2013-07-10 Thread Stefan Kristiansson
On Wed, Jul 10, 2013 at 09:18:53AM +0200, Andreas Schwab wrote: > > I don't think there is a need to conditionalize this on > HAVE_DESIGNATED_UNION_INITIALIZERS. All function pointers are alike, so > it should be good enough to cast on assignment and use the right > alternative on call. You mean

Patch to switch optional reloads off

2013-07-10 Thread Vladimir Makarov
I got three PRs about optional reloads patch which I committed to the trunk on Friday. Sorry, I can not work on these PRs this week. So I decided to switch optional reloads off temporarily. I'll return to the PRs next week. The patch was successfully bootstrapped on x86-64. Committed as re

Re: [PATCH] PR57792: Bootstrap darwin13 or later with --with-sysroot to find SDK

2013-07-10 Thread Jack Howarth
On Wed, Jul 10, 2013 at 02:24:48PM -0700, Mike Stump wrote: > On Jul 4, 2013, at 7:27 PM, Jack Howarth wrote: > > The attached patch eliminates the problem of the SDK being removed from / > > in darwin13 > > and later by appending --with-sysroot=\"`xcrun --show-sdk-path`\" to > > host_configarg

Re: [GOOGLE] record compiler options before any compilation

2013-07-10 Thread Xinliang David Li
Ok after testing. David On Wed, Jul 10, 2013 at 4:59 PM, Dehao Chen wrote: > This fix is need if you want to collect AutoFDO profile on > AutoFDO+LIPO optimized binary. > > Testing on going. > > OK for google branches? > > Thanks, > Dehao > > Index: gcc/toplev.c > ===

[GOOGLE] record compiler options before any compilation

2013-07-10 Thread Dehao Chen
This fix is need if you want to collect AutoFDO profile on AutoFDO+LIPO optimized binary. Testing on going. OK for google branches? Thanks, Dehao Index: gcc/toplev.c === --- gcc/toplev.c (revision 200855) +++ gcc/toplev.c (working

Re: [PATCH] Fix raw-string handling (PR preprocessor/57620)

2013-07-10 Thread Jakub Jelinek
On Wed, Jul 10, 2013 at 02:22:56AM -0400, Jason Merrill wrote: > It seems undesirable to go from one to four separate copies of the > note-handling code. Could we instead handle the different states of > prefix, body and suffix parsing in local variables and just have one > loop over the character

[C++ testcase, committed] PR 57827

2013-07-10 Thread Paolo Carlini
Hi, committed to mainline. Thanks, Paolo. / 2013-07-10 Paolo Carlini PR c++/57827 * g++.dg/cpp0x/constexpr-ice7.C: New. Index: g++.dg/cpp0x/constexpr-ice7.C === --- g++.dg/cpp0x/constexpr

Remove stray text on @hook TARGET_CANONICALIZE_COMPARISON in tm.texi.in

2013-07-10 Thread Joseph S. Myers
I noticed that the documentation of TARGET_CANONICALIZE_COMPARISON in tm.texi.in had stray text after the hook name on the @hook line, which became stray text after the prototype in the @deftypefn line in tm.texi. I've committed this patch to fix this. Index: doc/tm.texi ==

Re: [PATCH] PR57792: Bootstrap darwin13 or later with --with-sysroot to find SDK

2013-07-10 Thread Mike Stump
On Jul 4, 2013, at 7:27 PM, Jack Howarth wrote: > The attached patch eliminates the problem of the SDK being removed from / in > darwin13 > and later by appending --with-sysroot=\"`xcrun --show-sdk-path`\" to > host_configargs > in the top-level configure for those cases . Bootstrap tested on

Re: [PATCH, rs6000] Keep TOC register live in TLS lo_sum patterns

2013-07-10 Thread David Edelsohn
On Wed, Jul 10, 2013 at 7:08 AM, Ulrich Weigand wrote: > Hello, > > the ppc64 linker performs an optimization to avoid multi-instruction > TOC accesses in some cases: > > /* Multi-instruction sequences that access the TOC can be > optimized, eg. addis ra,r2,0; addi rb,ra,x; >

Re: [gomp4] Compiler side of the cancellation support

2013-07-10 Thread Jakub Jelinek
On Tue, Jul 09, 2013 at 10:12:30AM -0700, Richard Henderson wrote: > > Queuing this patch until we have a library implementation. > > I've committed the patch, so that I can more easily work on the library > implementation. Ok, thanks. > There was one minor patch conflict that needed resolving.

[C++ testcase, committed] PR 57874

2013-07-10 Thread Paolo Carlini
Hi, committed to mainline. Thanks, Paolo. /// 2013-07-10 Paolo Carlini PR c++/57874 * g++.dg/cpp0x/sfinae48.C: New. Index: g++.dg/cpp0x/sfinae48.C === --- g++.dg/cpp0x/sfinae48.C (revisio

Re: [patch,avr] Fix PR57631: Check ISR's asm name rather than C name

2013-07-10 Thread Denis Chertykov
2013/7/10 Georg-Johann Lay : > This change has been proposed so that the sanity checking of ISR > (signal,interrupt) functions tests the asm function name if available, not the > C name. > > Okay to apply? > > Johann > > gcc/ > PR target/57631 > * config/avr/avr.c (avr_set_current_f

Re: PING Fix ununsed variables before my patch adding missing -Werror

2013-07-10 Thread Graham Stott
Erric, Thanks I'll these errors Graham - Original Message - From: Eric Botcazou To: Graham Stott Cc: gcc-patches@gcc.gnu.org Sent: Wednesday, 10 July 2013, 17:26 Subject: Re: PING Fix ununsed variables before my patch adding missing -Werror > ChangeLog >        03-07-2013  graham.s

Re: List of dead links.

2013-07-10 Thread Jonathan Wakely
On 10 July 2013 16:22, Ondřej Bílka wrote: >> Thanks. Ondřej, as stated a few times now, anything in zlib, >> boehm-gc, etc. is maintained outside the GCC project. Do you have any >> way to filter out certain directories from being checked by your >> scripts? > > I have (place .indent.off file to

Re: PING Fix ununsed variables before my patch adding missing -Werror

2013-07-10 Thread Eric Botcazou
> ChangeLog > 03-07-2013 graham.stott graham.st...@btinternet.com > * c-familly/array_notation_comon.c (length_mismatch_expr_p): Delete > unused varables l_length and l_node Missing blank line in all your ChangeLog entries, and the above one is in the wrong ChangeLog file, it sh

Re: [PATCH] Define _REENTRANT with -pthread on aarch64-linux

2013-07-10 Thread Marcus Shawcroft
On 10 July 2013 16:06, Andreas Schwab wrote: > This is expected by some software (SWI Prolog checks for it). > > Andreas. OK, Thank you. ... this time copying in gcc-patches from an account that won't get bounced... /Marcus

Re: [C++ Patch] PR 57869

2013-07-10 Thread Jason Merrill
OK, thanks. Jason

[ping] [PATCH] Fix pr57637

2013-07-10 Thread Zhenqiang Chen
Ping? Thanks! -Zhenqiang On 5 July 2013 17:37, Zhenqiang Chen wrote: > On 5 July 2013 16:18, Jakub Jelinek wrote: >> On Fri, Jul 05, 2013 at 04:11:00PM +0800, Zhenqiang Chen wrote: >>> + FOR_BB_INSNS(bb, x) >> >> Just style nits: >> Missing space between (. Also, please don't use upperca

Re: [PATCH] Allow raw-string literals in macro arguments and deferred pragmas (PR preprocessor/57824)

2013-07-10 Thread Jakub Jelinek
On Wed, Jul 10, 2013 at 02:32:07AM -0400, Jason Merrill wrote: > On 07/05/2013 11:19 AM, Jakub Jelinek wrote: > >Seems for deferred_pragmas it just works > > Can we encounter a newline in a deferred pragma? Yes, that is the OpenMP testcase in the patch. > >and for parsing of arguments > >also if

Re: MIPS elimate trap-if-zero instruction if possible for divisions

2013-07-10 Thread Graham Stott
Hi Jeff, Richard, Not sure if that working. I created some rtl using TRAP_IF to represent the TEQ and emiited via an expander  The TRAP_IF rtl make ait all the way though the rtl optimizers which are run after expand even though it should be possible to determine is false. (insn 7 3 20 2 (se

Re: [c++-concepts] requires expression semantics

2013-07-10 Thread Andrew Sutton
>> I ran through every test in the is_convertible unit test with >> __is_convertible. There are 2 cases it doesn't address. The conversion >> of a function type (int()) to its reference type (int(&)()), > > > I looked into this a bit more; it seemed odd to consider any conversion from > int() since

Re: List of dead links.

2013-07-10 Thread Ondřej Bílka
On Wed, Jul 10, 2013 at 04:01:54PM +0100, Jonathan Wakely wrote: > On 10 July 2013 15:47, David Malcolm wrote: > > On Wed, 2013-07-10 at 16:00 +0200, Ondřej Bílka wrote: > > > >> Dead link: http://fedora.linux.duke.edu/fc1_x86_64 > > > > FWIW, this link occurs in historical notes at the top of thes

[PATCH] Define _REENTRANT with -pthread on aarch64-linux

2013-07-10 Thread Andreas Schwab
This is expected by some software (SWI Prolog checks for it). Andreas. * config/aarch64/aarch64-linux.h (CPP_SPEC): Define. diff --git a/gcc/config/aarch64/aarch64-linux.h b/gcc/config/aarch64/aarch64-linux.h index e914ed2..83efad4 100644 --- a/gcc/config/aarch64/aarch64-linux.h +++ b/g

Re: List of dead links.

2013-07-10 Thread Jonathan Wakely
On 10 July 2013 15:47, David Malcolm wrote: > On Wed, 2013-07-10 at 16:00 +0200, Ondřej Bílka wrote: > >> Dead link: http://fedora.linux.duke.edu/fc1_x86_64 > > FWIW, this link occurs in historical notes at the top of these files: > zlib/contrib/inflate86/inffas86.c > zlib/contrib/masmx64/inffa

Re: List of dead links.

2013-07-10 Thread David Malcolm
On Wed, 2013-07-10 at 16:00 +0200, Ondřej Bílka wrote: > Dead link: http://fedora.linux.duke.edu/fc1_x86_64 FWIW, this link occurs in historical notes at the top of these files: zlib/contrib/inflate86/inffas86.c zlib/contrib/masmx64/inffas8664.c dated Dec-29-2003 describing specific testing d

[PING][PING][PATCH] for for c/PR57541

2013-07-10 Thread Iyer, Balaji V
Did anyone get a chance to look at this? If so, is this OK for trunk? It is a relatively minor change... Thanks, -Balaji V. Iyer. > -Original Message- > From: Iyer, Balaji V > Sent: Tuesday, July 02, 2013 1:07 PM > To: gcc-patches@gcc.gnu.org > Cc: r...@redhat.com > Subject: FW: [PING]

[PING^2] Re: [PATCH] Caller instrumentation with -finstrument-calls

2013-07-10 Thread Paul_Woegerer
Ping, The updated patch that I have sent here: http://gcc.gnu.org/ml/gcc-patches/2013-07/msg7.html is still pending review/acceptance. Could someone please have a look. Many Thanks, Paul On Monday 01 July 2013 10:22:02 Woegerer, Paul wrote: > Hi Andrew, > > On Friday 28 June 2013 09:50:31

Re: List of dead links.

2013-07-10 Thread Jonathan Wakely
On 10 July 2013 15:00, Ondřej Bílka wrote: >> > I prefer fix issues one class at time. I added script that checks dead > links by extracting http addresses from sources and checking them by curl -f. > It found: > > $ ./stylepp/script/stylepp_warn_dead_link > > Dead link: http://anubis.dkuug.dk/jtc1

List of dead links.

2013-07-10 Thread Ondřej Bílka
On Mon, Jul 08, 2013 at 09:42:14PM +0200, Oleg Endo wrote: > On Mon, 2013-07-08 at 16:12 +0200, Ondřej Bílka wrote: > > On Sun, Jul 07, 2013 at 09:57:05PM +0200, Oleg Endo wrote: > > > On Sun, 2013-07-07 at 19:54 +0200, Georg-Johann Lay wrote: > > > > > > - http://www.ddj.com/articles/1997/9701/

[patch,avr] Fix PR57631: Check ISR's asm name rather than C name

2013-07-10 Thread Georg-Johann Lay
This change has been proposed so that the sanity checking of ISR (signal,interrupt) functions tests the asm function name if available, not the C name. Okay to apply? Johann gcc/ PR target/57631 * config/avr/avr.c (avr_set_current_function): Sanity-check signal name seen

Minor Cygwin patches

2013-07-10 Thread JonY
Hi, Attached are some minor patches, comments? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35536 --- origsrc/gcc-4.5.1/libjava/gnu/java/nio/channels/natFileChannelPosix.cc 2007-04-02 20:05:50.0 -0500 +++ src/gcc-4.5.1/libjava/gnu/java/nio/channels/natFileChannelPosix.cc 2010-10-27

Re: [patch,avr] Fix PR57844

2013-07-10 Thread Denis Chertykov
2013/7/10 Georg-Johann Lay : > The problem with this PR is that -size is used as addend in > avr_prologue_setup_frame instead of truncating it to the mode of the > operation. > > Fix as obvious. > > Ok for trunk and backport? > > Johann > > > PR target/57844 > * config/avr/avr.c (a

Re: [patch,avr] Fix PR57506: Remove duplicate devices from avr-mcus.def

2013-07-10 Thread Denis Chertykov
2013/7/10 Georg-Johann Lay : > Several devices are duplicate in avr-mcus.def. > > This patch removes the duplicate versions and adds a sanity check to > gen-avr-mmcu-texi.c. > > Ok to apply? > > Johann > > PR target/57506 > * config/avr/avr-mcus.def (atmega16hva, atmega16hva2, atmeg

[patch,avr] Fix PR57506: Remove duplicate devices from avr-mcus.def

2013-07-10 Thread Georg-Johann Lay
Several devices are duplicate in avr-mcus.def. This patch removes the duplicate versions and adds a sanity check to gen-avr-mmcu-texi.c. Ok to apply? Johann PR target/57506 * config/avr/avr-mcus.def (atmega16hva, atmega16hva2, atmega16hvb) (atmega16m1, atmega16u4, atmega

[PATCH, rs6000] Keep TOC register live in TLS lo_sum patterns

2013-07-10 Thread Ulrich Weigand
Hello, the ppc64 linker performs an optimization to avoid multi-instruction TOC accesses in some cases: /* Multi-instruction sequences that access the TOC can be optimized, eg. addis ra,r2,0; addi rb,ra,x; to nop; addi rb,r2,x; */ For this optimizat

Re: [C++ Patch] PR 57869

2013-07-10 Thread Paolo Carlini
Hi, On 07/10/2013 02:40 AM, Jason Merrill wrote: On 07/09/2013 07:46 PM, Paolo Carlini wrote: Daniel noticed that, per to the resolution of DR195, we shouldn't warn in c++11 mode, not even with -pedantic, for this kind of reinterpret_cast (*). Straightforward change tested x86_64-linux, not sur

Preserve label alignment info through dbr

2013-07-10 Thread Eric Botcazou
Hi, I was a little surprised to find out that dbr can silently drop the alignment information for labels computed when the CFG is valid (in compute_alignments). The pessimization can be significant for loops when the top label needs to be overaligned, as seen on a private port. Hence the attac

[patch,avr] Fix PR57844

2013-07-10 Thread Georg-Johann Lay
The problem with this PR is that -size is used as addend in avr_prologue_setup_frame instead of truncating it to the mode of the operation. Fix as obvious. Ok for trunk and backport? Johann PR target/57844 * config/avr/avr.c (avr_prologue_setup_frame): Trunk -size to mode

Re: FW: [PATCH GCC]Relax the probability condition in CE pass when optimizing for code size

2013-07-10 Thread Eric Botcazou
> 2013-03-25 Bin Cheng > > * ifcvt.c (ifcvt_after_combine): New static variable. > (cheap_bb_rtx_cost_p): Set scale to REG_BR_PROB_BASE when optimizing > for size. > (rest_of_handle_if_conversion, rest_of_handle_if_after_combine): > Clear/set the variable ifcvt_aft

Re: RFA: PATCH to get_inner_reference for c++/57793

2013-07-10 Thread Eric Botcazou
> This PR isn't really a C++ issue; it affects C as well, and presumably > all other languages. A comment a few lines down says > > /* Avoid returning a negative bitpos as this may wreak havoc later. */ > > but we were failing to avoid that in this case. > > Tested x86_64-pc-linux-gnu. OK for

Re: [PATCH] Fix illegal cast to rtx (*insn_gen_fn) (rtx, ...)

2013-07-10 Thread Andreas Schwab
Stefan Kristiansson writes: > @@ -291,14 +290,41 @@ > const char *const *multi; > insn_output_fn function; >} output; > + union { > +rtx (*argc0) (void); > +rtx (*argc1) (rtx); > +rtx (*argc2) (rtx, rtx); > +rtx (*argc3) (rtx, rtx, rtx); > +rtx (