Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-23 Thread Jason Merrill
OK. Jason

[PATCH, PowerPC] Fix unaligned Altivec load/stores in LE mode

2013-07-23 Thread Bill Schmidt
In order to use vperm for aligning loads and stores in little endian mode, we need to reverse the order of the input operands and use lvsl instead of lvsr. This corrects 32 regressions in the test suite when run in LE mode. Bootstrapped and tested on powerpc64-unknown-linux-gnu in BE mode with no

[PATCH, ARM/Thumb1] Adjust rtx cost to prevent expanding MULT into shift/add instructions

2013-07-23 Thread Terry Guo
Hi there, This patch intends to update thumb1_size_rtx_costs function to correctly handle those RTXs defined by RTL expansion pass. Thus the GIMPLE multiplication will be expanded to single mul instruction instead of a bunch of shift/add/sub instructions which are in fact more expensive. Tested w

Re: [C, C++] Implement -Wstatic-local

2013-07-23 Thread Gabriel Dos Reis
On Tue, Jul 23, 2013 at 3:02 PM, Florian Weimer wrote: > On 07/23/2013 09:51 PM, Andrew Pinski wrote: >> >> On Tue, Jul 23, 2013 at 12:48 PM, Florian Weimer >> wrote: >>> >>> We sometimes deal with code bases which use static local variables to cut >>> down frame size, for compatibility with lega

Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to support varargs thunk

2013-07-23 Thread David Holsgrove
On 24 July 2013 10:22, Michael Eager wrote: > On 07/23/13 16:23, David Holsgrove wrote: >> >> On 24 July 2013 07:10, Michael Eager wrote: >>> >> Thanks Michael. >> >> I think the content of your commit doesnt line up with this Changelog >> entry or mail though, >> >> http://gcc.gnu.org/git/?p=gcc

Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to support varargs thunk

2013-07-23 Thread Michael Eager
On 07/23/13 16:23, David Holsgrove wrote: On 24 July 2013 07:10, Michael Eager wrote: On 07/14/13 21:37, David Holsgrove wrote: Hi Michael, -Original Message- From: Michael Eager [mailto:ea...@eagerm.com] Sent: Saturday, 13 July 2013 9:33 am To: David Holsgrove Cc: gcc-patches@gcc.g

Re: [Patch, microblaze]: Add atomic builtin implementation

2013-07-23 Thread Michael Eager
On 07/14/13 21:43, David Holsgrove wrote: Hi Michael, On 21 March 2013 03:00, Richard Henderson wrote: On 03/18/2013 05:48 AM, David Holsgrove wrote: * gcc/config/microblaze/sync.md: New file. * gcc/config/microblaze/microblaze.md: Add UNSPEC_SYNC_CAS, UNSPEC_SYNC_XCHG and include syn

Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to support varargs thunk

2013-07-23 Thread David Holsgrove
On 24 July 2013 07:10, Michael Eager wrote: > On 07/14/13 21:37, David Holsgrove wrote: >> >> Hi Michael, >> >>> -Original Message- >>> From: Michael Eager [mailto:ea...@eagerm.com] >>> Sent: Saturday, 13 July 2013 9:33 am >>> To: David Holsgrove >>> Cc: gcc-patches@gcc.gnu.org; Edgar Igle

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-23 Thread Bill Schmidt
On Tue, 2013-07-23 at 14:02 -0400, David Edelsohn wrote: > On Mon, Jul 22, 2013 at 9:09 PM, Bill Schmidt > wrote: > > > OK, currently testing the following. OK if it passes? > > > > Index: gcc/config/rs6000/rs6000.c > > === > > --

Re: Go patch committed: Update libgo to 1.1.1

2013-07-23 Thread Ian Lance Taylor
On Mon, Jul 22, 2013 at 6:38 AM, Uros Bizjak wrote: > >> I have committed a large patch to update libgo to the library that was >> part of the Go 1.1.1 release. As usual, I'm not including the entire >> patch in this e-mail message, because it is too large. I'm only >> including

[Patch, PR 57804] Wasted work in gfc_trans_transfer()

2013-07-23 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57804 Bootstrap and regression-tested on x86_64-linux. In method "gfc_trans_transfer()" in gcc/fortran/trans-io.c, th

[Patch, PR 57802] Wasted work in set_loop_bounds()

2013-07-23 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57802 Bootstrap and regression-tested on x86_64-linux. In method "set_loop_bounds()" in gcc/fortran/trans-array.c, th

[Patch, PR 57791] Waste work in gfc_check_pointer_assign()

2013-07-23 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57791 Bootstrap and regression-tested on x86_64-linux. In method "gfc_check_pointer_assign()" in expr.c, the loop on

[Patch, PR 57801] Waste work in resolve_variable()

2013-07-23 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57801 Bootstrap and regression-tested on x86_64-linux. In method "resolve_variable()" in gcc/fortran/resolve.c, the l

[Patch, PR 57800] Waste work in gfc_match_call()

2013-07-23 Thread pchang9
Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57800 Bootstrap and regression-tested on x86_64-linux. In method "gfc_match_call()" in gcc/fortran/match.c, the loop

Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-23 Thread Paolo Carlini
Hi, On 07/23/2013 05:27 PM, Jason Merrill wrote: Hmm, I suppose this could still end up doing unnecessary completions if both types are incomplete. What happens if X is also incomplete? Indeed, it fails and shouldn't. I thought I had tested this case but didn't. Thus I extended a bit the testc

Re: Go patch committed: Update libgo to 1.1.1

2013-07-23 Thread Ian Lance Taylor
On Thu, Jul 18, 2013 at 6:59 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> I have committed a large patch to update libgo to the library that was >> part of the Go 1.1.1 release. As usual, I'm not including the entire >> patch in this e-mail message, because it is too large. I'm only >

Re: [Patch, microblaze]: Add -fstack-usage support

2013-07-23 Thread Michael Eager
On 07/22/13 22:50, David Holsgrove wrote: Hi Eric / Chung-Ju, On 21 July 2013 01:33, Chung-Ju Wu wrote: On 7/20/13 4:14 PM, Eric Botcazou wrote: 2013-03-18 David Holsgrove * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue): Add check for flag_stack_usage to handle -

Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to support varargs thunk

2013-07-23 Thread Michael Eager
On 07/14/13 21:37, David Holsgrove wrote: Hi Michael, -Original Message- From: Michael Eager [mailto:ea...@eagerm.com] Sent: Saturday, 13 July 2013 9:33 am To: David Holsgrove Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekal

Re: Go patch committed: Update libgo to 1.1.1

2013-07-23 Thread Ian Lance Taylor
On Thu, Jul 18, 2013 at 6:59 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> I have committed a large patch to update libgo to the library that was >> part of the Go 1.1.1 release. As usual, I'm not including the entire >> patch in this e-mail message, because it is too large. I'm only >

RE: [ping] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-07-23 Thread Hans-Peter Nilsson
On Tue, 23 Jul 2013, Bernd Edlinger wrote: > H-P: I hope you can approve my little patch for trunk now, > although it turned out to be less trivial than I'd have expected. Sorry, I'm not an approver. (People who are not approvers are welcome to review any gcc patch where they might say something

libgo patch committed: Fix cgo callbacks from non-Go threads

2013-07-23 Thread Ian Lance Taylor
This patch to libgo fixes cgo callbacks from non-Go threads. Those threads will not have an M or G structure. This basically adjusts the support in the master Go library to work with gccgo. There are also some cgo patches required. They are in https://codereview.appspot.com/11406047/ and will b

Re: Go patch committed: Update libgo to 1.1.1

2013-07-23 Thread Ian Lance Taylor
On Tue, Jul 23, 2013 at 6:50 AM, Uros Bizjak wrote: >> >> Another problem was triggered on CentOS 5.9, where compile fails with: >> >> ../../../gcc-svn/trunk/libgo/runtime/netpoll_epoll.c: In function >> ‘runtime_epollcreate1’: >> ../../../gcc-svn/trunk/libgo/runtime/netpoll_epoll.c:41:2: error: >

Re: RFA: implement C11 _Generic

2013-07-23 Thread Joseph S. Myers
On Tue, 23 Jul 2013, Tom Tromey wrote: > Joseph> + /* The association's type, or NULL_TREE for 'default'.. */ > > It's trivial, but I happened to notice that this ".." should be just > ".". The extra "." was in the original patch too. Thanks, I've applied this patch to fix this typo. Index:

Re: [C, C++] Implement -Wstatic-local

2013-07-23 Thread Florian Weimer
On 07/23/2013 09:51 PM, Andrew Pinski wrote: On Tue, Jul 23, 2013 at 12:48 PM, Florian Weimer wrote: We sometimes deal with code bases which use static local variables to cut down frame size, for compatibility with legacy targets. Obviously, this is bad for thread safety. This new warning can

Re: [C, C++] Implement -Wstatic-local

2013-07-23 Thread Andrew Pinski
On Tue, Jul 23, 2013 at 12:48 PM, Florian Weimer wrote: > We sometimes deal with code bases which use static local variables to cut > down frame size, for compatibility with legacy targets. Obviously, this is > bad for thread safety. This new warning can be used to track down such > cases once y

[C, C++] Implement -Wstatic-local

2013-07-23 Thread Florian Weimer
We sometimes deal with code bases which use static local variables to cut down frame size, for compatibility with legacy targets. Obviously, this is bad for thread safety. This new warning can be used to track down such cases once you suspect they exist. Bootstrapped and regression-tested on

Re: [patch, mips] Size savings for MIPS16 switch statements

2013-07-23 Thread Richard Sandiford
"Steve Ellcey " writes: > While doing some space optimization work with mips16 I found that using a > larger case threshold value could shrink the code. I did testing on some > libraries like libpng and libjpeg as well as some test cases I wrote and > came up with 10 as the best value for space s

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const reverses pack pattern arguments in little endian mode

2013-07-23 Thread David Edelsohn
On Mon, Jul 22, 2013 at 9:09 PM, Bill Schmidt wrote: > OK, currently testing the following. OK if it passes? > > Index: gcc/config/rs6000/rs6000.c > === > --- gcc/config/rs6000/rs6000.c (revision 201149) > +++ gcc/config/rs6000/rs6

Re: [PATCH, PowerPC] altivec_expand_vec_perm_const selects wrong field for splat in LE mode

2013-07-23 Thread David Edelsohn
On Tue, Jul 23, 2013 at 1:10 PM, Bill Schmidt wrote: > This patch fixes another small little-endian problem with vectors on > PowerPC. Element numbering is reversed when selecting a field for a > vector splat operation. Fixing this removes a regression from the test > suite when run in LE mode (

[patch, mips] Size savings for MIPS16 switch statements

2013-07-23 Thread Steve Ellcey
While doing some space optimization work with mips16 I found that using a larger case threshold value could shrink the code. I did testing on some libraries like libpng and libjpeg as well as some test cases I wrote and came up with 10 as the best value for space savings in mips16 mode. I did som

[PATCH, PowerPC] altivec_expand_vec_perm_const selects wrong field for splat in LE mode

2013-07-23 Thread Bill Schmidt
This patch fixes another small little-endian problem with vectors on PowerPC. Element numbering is reversed when selecting a field for a vector splat operation. Fixing this removes a regression from the test suite when run in LE mode (gcc.dg/vect/slp-perm-3.c). Patch by Anton Blanchard. Bootstr

Re: [Patch, PR 57780] Waste work in subst_dup()

2013-07-23 Thread Jeff Law
On 07/22/2013 07:39 PM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57780 Bootstrap and regression-tested on x86_64-linux. In metho

Go patch committed: Don't call init_varasm_once again

2013-07-23 Thread Ian Lance Taylor
In http://gcc.gnu.org/ml/gcc-patches/2010-08/msg02019.html I added code to call init_varasm_once again if a package imports unsafe. As that message explains, this is to avoid an assert in mems_in_disjoint_alias_sets_p if it sees a non-zero alias set when flag_strict_aliasing is false. However, I

Re: [Patch, PR 57782] Wasted work in remove_path()

2013-07-23 Thread Jeff Law
On 07/22/2013 03:59 PM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 200945 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57782 In method "remove_path()" in cfgloopmanip.c, the loop on l

Re: [Patch, PR 57787] Wasted work in ix86_pad_returns()

2013-07-23 Thread Jeff Law
On 07/22/2013 12:01 PM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 201034 in version 4.9. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57787. Bootstrap and regression-tested on x86_64-linux. In method "ix86_pad_returns()" in i386.c, the loop o

Re: [Patch, PR 57811] Wasted work in find_reloads()

2013-07-23 Thread Jeff Law
On 07/22/2013 10:39 AM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 201034 in version 4.9. I attached one-line patches that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57811 Bootstrap and regression-tested on x86_64-linux. In metho

Re: Typo in GCC Internals documentation.

2013-07-23 Thread Jeff Law
On 07/23/2013 04:01 AM, Marek Polacek wrote: On Tue, Jul 23, 2013 at 11:32:39AM +0200, Nicklas Bo Jensen wrote: Hi, Found a typo in the GCC Internals documentation in one of the code examples in 16.18.2 RTL to RTL Peephole Optimizers. Thanks, looks good, though the ChangeLog entry is missing,

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-23 Thread David Malcolm
On Tue, 2013-07-23 at 16:46 +0200, Martin Jambor wrote: > Hi, > > On Mon, Jul 22, 2013 at 03:22:33PM -0400, David Malcolm wrote: > > On Mon, 2013-07-22 at 20:25 +0200, Martin Jambor wrote: > > > On Wed, Jul 17, 2013 at 09:18:22PM -0400, David Malcolm wrote: > > > > gcc/ > > > > > > > > Ex

Re: [Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Tim Shen
Revised version, with _M_dfs_* moved to the class definition, PR testcases, and some comments on _M_dfs(). Thanks. -- Tim Shen dfs-matcher.patch Description: Binary data

Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-23 Thread Jason Merrill
Hmm, I suppose this could still end up doing unnecessary completions if both types are incomplete. What happens if X is also incomplete? The version that returns false if either is incomplete would give the wrong answer if the types are the same. I think a better way would be to use COMPARE_

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-23 Thread Martin Jambor
Hi, On Mon, Jul 22, 2013 at 03:22:33PM -0400, David Malcolm wrote: > On Mon, 2013-07-22 at 20:25 +0200, Martin Jambor wrote: > > On Wed, Jul 17, 2013 at 09:18:22PM -0400, David Malcolm wrote: > > > gcc/ > > > > > > Explicitly number the instances of passes within passes.def. > > > > > > This

Re: [Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Paolo Carlini
Hi, >Is this naive or not? I don't know. For sure we don't want inline code in *.tcc headers. Paolo

Re: [PATCH] [ARM] Fix PR57909 : ICE with internal memcpy and -mno-unaligned-access

2013-07-23 Thread Yvan Roux
Hi, I forgot to add the test case with the PR fix, the attached patch add it. Thanks, Yvan ChangeLog gcc/testsuite 2013-07-23 Yvan Roux PR target/57909 * gcc.target/arm/pr57909.c: New test. On 17 July 2013 10:58, Ramana Radhakrishnan wrote: > On 07/17/13 09:53, Yvan Roux

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-07-23 Thread Tom Tromey
> "Phil" == Phil Muldoon writes: Phil> On 03/07/13 08:33, Phil Muldoon wrote: >> This new patch replaces and obsoletes the previous. On further >> inspection of some other pretty printer related bugs, it seems that >> all of the printers need to fetch the referenced value where the value >>

Re: [Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Tim Shen
On Tue, Jul 23, 2013 at 9:42 PM, Paolo Carlini wrote: > This doesn't make much sense to me: if the functions are inside a *.tcc file > why are marked inline? First blush seem indeed good candidates for inline, > but then should be in the *.h My view is like this : When I put something into the cl

Re: Go patch committed: Update libgo to 1.1.1

2013-07-23 Thread Uros Bizjak
Hello! I have committed a large patch to update libgo to the library that was part of the Go 1.1.1 release. As usual, I'm not including the entire patch in this e-mail message, because it is too large. I'm only including the changes to the files that are partially gccgo-speci

Go patch committed: Don't include "except.h" in go-lang.c

2013-07-23 Thread Ian Lance Taylor
This patch removes the #include of "except.h" from go-lang.c. I added it in order to call build_personality_function, but that declaration is now in tree.h. except.h is considered to be a backend header that should not be included in frontend code. Bootstrapped and ran Go testsuite on x86_64-unk

Re: [Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Paolo Carlini
.. not that, in general, *all* the testcases coming from a bug report in Bugzilla, should either be named after the bug # or have the information in a comment inside (or both, as I said already) Paolo.

Re: [Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Paolo Carlini
On 07/23/2013 03:07 PM, Tim Shen wrote: + inline + bool _Grep_matcher:: + _M_dfs_match() + { return _M_dfs(_M_nfa->_M_start()); } + + inline + bool _Grep_matcher:: + _M_dfs_search_from_first() + { return _M_dfs(_M_nfa->_M_start()); } This doesn't make much sense to me: if the functions ar

Re: Add more info to google/gcc-4_8 powerpc64 xfails file.

2013-07-23 Thread Diego Novillo
On Tue, Jul 23, 2013 at 1:50 AM, Brooks Moses wrote: > Diego - > > The attached patch adds a little more analysis info to the powerpc64 > xfails file. Ok to commit? OK. Diego.

Re: [Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Paolo Carlini
Hi, On 07/23/2013 03:07 PM, Tim Shen wrote: At last, two bug reports(libstdc++/53622 and libstdc++/57173) said that there're regex grouping problems. It's relatively simple fix it in the DFS approach, and I added them to the testsuite. Shall I write PR in the ChangeLog? What does PR stand for? P

Re: Minor Cygwin patches

2013-07-23 Thread JonY
On 7/19/2013 15:23, Yaakov (Cygwin/X) wrote: > On 2013-07-14 20:15, JonY wrote: >> 2013-03-08 Dave Korn >> >> * (gcc/config.gcc): Include Cygwin specific file. >> * (gcc/config/i386/cygwin.h): Link shared libgcc by default. >> * (gcc/config/i386/cygwin.h): Add --large-address-awar

Re: Minor Cygwin patches

2013-07-23 Thread JonY
On 7/19/2013 15:21, Yaakov (Cygwin/X) wrote: > On 2013-07-14 20:15, JonY wrote: >> 2013-03-08 Yaakov Selkowitz >> >> * (gcc/testsuite/gcc.target/i386/pr25993.c): Skip unsupported test. > > This patch was Dave Korn's. > > OK. Changelog 2013-03-08 Dave Korn * (gcc/testsuite/gcc.t

[Patch] Reimplment regex matcher using DFS

2013-07-23 Thread Tim Shen
This is the most exciting patch from me so far! XD Here I temporarily shadow the Thompson NFA matcher[1](original _Grep_matcher), and use the Depth-First Search(DFS, or backtracking) approach instead. Yes, DFS is *exponentially slow* :( However we need it, because when encountering the feature "b

[PATCH, AArch64] Support NEG in vector registers for DI and SI mode

2013-07-23 Thread Ian Bolton
Support added for scalar NEG instruction in vector registers. Execution testcase included. Tested on usual GCC Linux regressions. OK for trunk? Cheers, Ian 2013-07-23 Ian Bolton gcc/ * config/aarch64/aarch64-simd.md (neg2): Offer alternative that uses vector registers. te

Re: [PATCH 4/5] Fix typos in libstdc++.

2013-07-23 Thread Ondřej Bílka
On Tue, Jul 23, 2013 at 12:26:23PM +0100, Jonathan Wakely wrote: > I agree with all Paolo's comments. > > Also libstdc++-v3/doc/html/ext/lwg-active.html is imported from > elsewhre so it's pointless fixing it, the upstream version comes from > https://github.com/cplusplus/LWG > ok, I have one red

Re: [PATCH 1/5] Fix typos in fortran.

2013-07-23 Thread Tobias Burnus
Ondřej Bílka wrote: Hi, this is next in series of typo fixing patches. I committed the this Fortran as Rev. 201162, skipping only the "parameterized"-to-"parametrized" change. That change was disputed at other parts of this patch series and Merriam-Webster lists the former as default entry a

Re: [PATCH 1/5] Fix typos in fortran.

2013-07-23 Thread Tobias Burnus
Ondřej Bílka wrote: Hi, this is next in series of typo fixing patches. I committed the this Fortran as Rev. 201162, skipping only the "parameterized"-to-"parametrized" change. That change was disputed at other parts of this patch series and Merriam-Webster lists the former as default entry a

Re: [Patch] regex_iterator and regex_token_iterator implementation

2013-07-23 Thread Jonathan Wakely
On 23 July 2013 10:18, Tim Shen wrote: > > Are other parts ok? Could you please look at them? In regex_token_iterator::_M_init the for loop could be replaced with either for (auto __i : subs) or a call to std::find, which wouldn't need the cast to int, but that's just stylistic and a matter of tas

Re: [PATCH, AArch64] Add support for "wsp" register

2013-07-23 Thread Marcus Shawcroft
On 4 July 2013 08:07, Yufeng Zhang wrote: > Hi, > > This patch adds support for the register "wsp"; in ILP32, this is necessary > in order to support the global register variable associated the stack > pointer with the syntax asm ("wsp"); it is used in libgloss to get the stack > pointer. > > OK f

Re: [Patch, AArch64, ILP32] Pad pointer-typed stack argument downward in ILP32

2013-07-23 Thread Marcus Shawcroft
On 27 June 2013 17:00, Yufeng Zhang wrote: > This patch fixes the bug that pointer-typed argument passed on stack is not > padded properly in ILP32. > > OK for the trunk? OK /Marcus

Re: [PATCH, AArch64] Change to pass -mabi=* directly to the assembler

2013-07-23 Thread Marcus Shawcroft
On 19 July 2013 11:45, Yufeng Zhang wrote: > Hi, > > Following the work in AArch64 GAS to unify the ABI command line interface, > this patch updates the compiler driver to pass -mabi=* directly to the > assembler. > > The related GAS patch is here: > http://www.sourceware.org/ml/binutils/2013-07/m

Re: [PATCH 4/5] Fix typos in libstdc++.

2013-07-23 Thread Jonathan Wakely
I agree with all Paolo's comments. Also libstdc++-v3/doc/html/ext/lwg-active.html is imported from elsewhre so it's pointless fixing it, the upstream version comes from https://github.com/cplusplus/LWG Most of the changes are replacing British English with American English, so low priority. I'll

Re: [PATCH 4/5] Fix typos in libstdc++.

2013-07-23 Thread Paolo Carlini
Hi, spotted a few debatable items. On 07/23/2013 12:45 PM, Ondřej Bílka wrote: -Ammend D.12.1 [auto.ptr]p2: +Amend D.12.1 [auto.ptr]p2: ^^

Re: [PATCH 1/5] Fix typos in ada.

2013-07-23 Thread Arnaud Charlet
> > I'm not thrilled by changing all refs to Parameterized by Parametrized. > > > > Is Parameterized UK only, or is this an OK spelling for > > American/International > > english as well? > > > From http://gcc.gnu.org/codingconventions.html#Spelling > > Use...

Re: [PATCH 1/5] Fix typos in ada.

2013-07-23 Thread Arnaud Charlet
I'm not thrilled by changing all refs to Parameterized by Parametrized. Is Parameterized UK only, or is this an OK spelling for American/International english as well? If the latter, I wouldn't change these references. Other changes are OK. Arno

Re: [v3] libstdc++/57920

2013-07-23 Thread Chung-Ju Wu
2013/7/23 Paolo Carlini : > ... in the future, when we manage to actually avoid including from > I think we can avoid including it from if we play a bit > with void*. Should be safe aliasing-wise. Something like the below, > completely untested. I tested it on my target. At least the elf toolc

[PATCH 3/5] Fix typos in java.

2013-07-23 Thread Ondřej Bílka
Hi, this is next in series of typo fixing patches. I cleaned up http://kam.mff.cuni.cz/~ondra/gcc_misspells and fixed misspells for letters a-d. I combined this list with what I done previously and here is result. I according to Joseph suggestion split it by directory. This is done with followi

[PATCH 1/5] Fix typos in ada.

2013-07-23 Thread Ondřej Bílka
Hi, this is next in series of typo fixing patches. I cleaned up http://kam.mff.cuni.cz/~ondra/gcc_misspells and fixed misspells for letters a-d. I combined this list with what I done previously and here is result. I according to Joseph suggestion split it by directory. This is done with followi

[PATCH 1/5] Fix typos in fortran.

2013-07-23 Thread Ondřej Bílka
Hi, this is next in series of typo fixing patches. I cleaned up http://kam.mff.cuni.cz/~ondra/gcc_misspells and fixed misspells for letters a-d. I combined this list with what I done previously and here is result. I according to Joseph suggestion split it by directory. This is done with followi

Re: [v3] libstdc++/57920

2013-07-23 Thread Paolo Carlini
On 07/23/2013 11:56 AM, Paolo Carlini wrote: ... in the future, when we manage to actually avoid including from The C++11 string conversions could be exported by the *.so, aren't templates. Paolo.

Re: Typo in GCC Internals documentation.

2013-07-23 Thread Marek Polacek
On Tue, Jul 23, 2013 at 11:32:39AM +0200, Nicklas Bo Jensen wrote: > Hi, > > Found a typo in the GCC Internals documentation in one of the code > examples in 16.18.2 RTL to RTL Peephole Optimizers. Thanks, looks good, though the ChangeLog entry is missing, so something like: 2013-07-23 Nicklas

Re: [v3] libstdc++/57920

2013-07-23 Thread Paolo Carlini
... in the future, when we manage to actually avoid including from I think we can avoid including it from if we play a bit with void*. Should be safe aliasing-wise. Something like the below, completely untested. Paolo. Index: include/bits/random.h ===

[PATCH, libfortran]: Committed: Read rounding mode from SSE mxcsr register on x86_64.

2013-07-23 Thread Uros Bizjak
Hello! On x86_64, we can look into SSE mxcsr register to determine rounding mode. 2013-07-23 Uros Bizjak * config/fpu-387.h (get_fpu_rounding_mode): Read rounding mode from SSE mxcsr register on x86_64. Tested on x86_64-pc-linux-gnu {,-m32} and committed to mainline svn. BTW. gfor

Re: [v3] libstdc++/57920

2013-07-23 Thread Chung-Ju Wu
2013/7/23 Paolo Carlini : > On 07/23/2013 11:26 AM, Paolo Carlini wrote: >> >> Currently you can't really get the error above. > > Ah Ok, now I see when it can happen, not on Linux, it can happen when > string_conversions.h aren't available. Ok, I'll add back the include > momentarily. > > Paolo.

Re: [v3] libstdc++/57920

2013-07-23 Thread Paolo Carlini
On 07/23/2013 11:26 AM, Paolo Carlini wrote: Currently you can't really get the error above. Ah Ok, now I see when it can happen, not on Linux, it can happen when string_conversions.h aren't available. Ok, I'll add back the include momentarily. Paolo.

Typo in GCC Internals documentation.

2013-07-23 Thread Nicklas Bo Jensen
Hi, Found a typo in the GCC Internals documentation in one of the code examples in 16.18.2 RTL to RTL Peephole Optimizers. Best, Nicklas Index: gcc/doc/md.texi === --- gcc/doc/md.texi (revision 201156) +++ gcc/doc/md.texi (working c

Re: [v3] libstdc++/57920

2013-07-23 Thread Paolo Carlini
Hi, On 07/23/2013 11:17 AM, Chung-Ju Wu wrote: 2013/7/22 Paolo Carlini : Hi, see audit trail for details. I tested on x86_64-linux (with/without _GLIBCXX_X86_RDRAND artificially undefined) the below straightforward patch and checked by hand the strace. I'm going to apply it soon. Thanks, Paol

[Patch] Fix selector for vect-iv-5.c

2013-07-23 Thread Vidya Praveen
Hello gcc.dg/vect/vect-iv-5.c XPASSes for arm-*-* since gcc.dg/vect/*.c tests are always run with -ffast-math for arm-*-*. This patch makes xfail conditional for this test by adding effective target keyword !arm_neon_ok. OK for trunk? Regards VP -- gcc/testsuite/ChangeLog: 2013-07-22 Vidya P

Re: [Patch] regex_iterator and regex_token_iterator implementation

2013-07-23 Thread Tim Shen
On Mon, Jul 22, 2013 at 6:10 PM, Jonathan Wakely wrote: > They're not specified by the standard, it says > > // these members are shown for exposition only: > > Which means the names are used only for the purposes of describing the > semantics of the class, they are not normative requirements. See

Re: [v3] libstdc++/57920

2013-07-23 Thread Chung-Ju Wu
2013/7/22 Paolo Carlini : > Hi, > > see audit trail for details. I tested on x86_64-linux (with/without > _GLIBCXX_X86_RDRAND artificially undefined) the below straightforward patch > and checked by hand the strace. I'm going to apply it soon. > > Thanks, > Paolo. > > /// Hi, Paolo

RE: [PATCH][4.8 backport] Fix PR57735

2013-07-23 Thread Kyrylo Tkachov
Hi Richard, > Richard Sandiford writes: > > "Kyrylo Tkachov" writes: > >> Hi all, > >> > >> The fix for PR57735 is in current trunk (for a different issue I > think), just > >> needs a backport to 4.8. > >> It is r198462 by Richard Sandiford: > >> > >> 2013-04-30 Richard Sandiford > >> > >>

Re: [PATCH] Fix for PR c/57490

2013-07-23 Thread Rainer Orth
Rainer Orth writes: > "Iyer, Balaji V" writes: > >>> -Original Message- >>> From: Jakub Jelinek [mailto:ja...@redhat.com] >>> Sent: Monday, July 01, 2013 1:09 PM >>> To: Iyer, Balaji V >>> Cc: gcc-patches@gcc.gnu.org; Rainer Orth >>> Subject: Re: [PATCH] Fix for PR c/57490 >>> >>> On Mo

Re: [C++ Patch / RFC] Change DERIVED_FROM_P to use tf_none?!?

2013-07-23 Thread Paolo Carlini
Hi, On 07/22/2013 11:38 PM, Jason Merrill wrote: I guess ptr_reasonably_similar should return false if one of the target types is incomplete. Thanks. The below passes testing on x86_64-linux. I'm also taking the chance to change the return type to bool, consistently with comptypes, error_typ

[PING] 3 patches waiting for approval/review

2013-07-23 Thread Andreas Krebbel
[RFC] Allow functions calling mcount before prologue to be leaf functions http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00993.html [PATCH] PR57377: Fix mnemonic attribute http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01364.html [PATCH] Doc: Add documentation for the mnemonic attribute http://gcc.gn

[Committed] S/390: Fix fpr numbering when creating fallback frame state

2013-07-23 Thread Andreas Krebbel
Hi, when creating the fallback framestate for unwinding through a signal frame we currently use a linear mapping from the hard regs to dwarf regs also for FPRs. This is wrong. In order to deal with FPR register pairs as required by the hardware there is a specific mapping defined in the ABI whic

Re: RFA: implement C11 _Generic

2013-07-23 Thread Tom Tromey
> "Joseph" == Joseph S Myers writes: Joseph> I have now revised this patch from a year ago in line with my Joseph> understanding of how _Generic ought to handle the various special Joseph> cases Thanks for doing this. Joseph> + /* The association's type, or NULL_TREE for 'default'.. */ I