RE: Cilk Library

2013-11-08 Thread Thomas Schwinge
Hi! On Thu, 7 Nov 2013 22:10:12 +, Iyer, Balaji V balaji.v.i...@intel.com wrote: * Makefile.def: Add libcilkrts to target_modules. Make libcilkrts depend on libstdc++ and libgcc. [...] * Makefile.in: Added libcilkrts related fields to support

[PATCH] Fix PR59038

2013-11-08 Thread Richard Biener
This fixes PR59038 by reverting the wrong fix for PR58955 and instead installing the correct fix (fingers crossing). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-11-07 Richard Biener rguent...@suse.de PR tree-optimization/59038 PR

Re: [wide-int] Remove SHIFT_COUNT_TRUNCATED uses at tree/gimple level

2013-11-08 Thread Richard Biener
On Thu, 7 Nov 2013, Kenneth Zadeck wrote: On 11/07/2013 01:07 PM, Richard Sandiford wrote: Kenneth Zadeck zad...@naturalbridge.com writes: I very strongly disagree with this. The standard needs to be high than does it pass the test suite. What we are introducing is a case where

Re: [PATCH, MPX, 2/X] Pointers Checker [8/25] Languages support

2013-11-08 Thread Ilya Enkovich
Hi, Here is an updated patch version with no langhook. Regarding TLS objects issue - I do not think compiler should compensate the absence of instrumentation in libraries. Compiler should be responsible for initialization of Bounds Tables for .tdata section. Correct data copy is a

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mike Stump
On Nov 7, 2013, at 5:13 PM, Mingjie Xing mingjie.x...@gmail.com wrote: Well, it is my understanding that the warning should be emitted for a volatile variable only if it is not accessed. Initialization means accessing, even though it is not used anywhere. Let me try. A warning is useful, if

Re: [PATCH, i386]: Fix PR 59021, new vzeroupper instructions generated with -mavx

2013-11-08 Thread Uros Bizjak
On Fri, Nov 8, 2013 at 1:07 AM, Joern Rennecke joern.renne...@embecosm.com wrote: On 7 November 2013 20:01, Uros Bizjak ubiz...@gmail.com wrote: OTOH, looking a bit deeper, it looks that there is a problem in mode-switching infrastructure. If we have a BB without any mode requirements, but an

Re: [c++] Fix pr58525

2013-11-08 Thread Alexander Ivchenko
ups, I did ping in the wrong thread about this issue. Sorry. Anyway, I noticed that after r204334 my patch cannot be applied without conflicts. Here is the updated one attached. Bootstrapped and regtested on x86_64-unknown-linux-gnu. 2013-11-08 Alexander Ivchenko alexander.ivche...@intel.com

Re: [patch] [arm] ARM Cortex-M3/M4 tuning

2013-11-08 Thread Ramana Radhakrishnan
ChangeLog: 2013-11-01 Julian Brown jul...@codesourcery.com Joey Ye joey...@arm.com * config/arm/arm.c (arm_cortex_m_branch_cost): New. (arm_v7m_tune): New. (arm_*_tune): Add comments for Sched adj cost. List all names here please rather than a regexp. *

Re: Recent Go patch broke Alpha bootstrap

2013-11-08 Thread Uros Bizjak
On Fri, Nov 8, 2013 at 12:39 AM, Ian Lance Taylor i...@google.com wrote: Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: Thanks for the patch and report. This patch should fix them. Bootstrapped and tested on x86_64-unknown-linux-gnu, not that that proves much.

[PATCH, rtl]: Mode-switching: Mark block as nontransparent if its exiting mode != no_mode

2013-11-08 Thread Uros Bizjak
Hello! Attached patch fixes an oversight in mode-switching. For blocks without ANY mode requirements, we have to consider instructions with MODE_AFTER mode changes. If the exiting mode from the block is different that no_mode (the mode we start), we have to mark the block as nontransparent.

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Bin.Cheng
On Fri, Nov 8, 2013 at 5:03 PM, Mike Stump mikest...@comcast.net wrote: On Nov 7, 2013, at 5:13 PM, Mingjie Xing mingjie.x...@gmail.com wrote: Well, it is my understanding that the warning should be emitted for a volatile variable only if it is not accessed. Initialization means accessing,

[patch libgcc]: Solve issue about too early released libgcc's DLL

2013-11-08 Thread Kai Tietz
Hello, this issue was discussed on cygwin's ML some time ago. For shared libgcc-DLL use it might happen that the DLL is released too early, so we need to perform an explicit load of it for increasing the load-count. By this we make sure that the DLL is still loaded on destruction. I will

Re: [PATCH] make has_gate and has_execute useless

2013-11-08 Thread Richard Biener
On Thu, Nov 7, 2013 at 5:00 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This is the result of seeing what it would take to get rid of the has_gate and has_execute flags on pass_data. It turns out not much, but I wanted confirmation this part is ok

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 1:32 AM, Bin.Cheng amker.ch...@gmail.com wrote: On Fri, Nov 8, 2013 at 5:03 PM, Mike Stump mikest...@comcast.net wrote: On Nov 7, 2013, at 5:13 PM, Mingjie Xing mingjie.x...@gmail.com wrote: Well, it is my understanding that the warning should be emitted for a volatile

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-08 Thread Richard Biener
On Thu, Nov 7, 2013 at 7:55 PM, Jeff Law l...@redhat.com wrote: On 11/07/13 04:50, Ilya Enkovich wrote: Hi, Here is an updated patch version. I think this needs to hold until we have a consensus on what the parameter passing looks like for bounded pointers. I still think the best thing to

Re: Implement C11 _Atomic

2013-11-08 Thread Uros Bizjak
On Thu, Nov 7, 2013 at 7:26 PM, Joseph S. Myers jos...@codesourcery.com wrote: Please note that following code form fenv.c won't generate overflow exception on x87: if (excepts FP_EX_OVERFLOW) { volatile float max = __FLT_MAX__; r = max * max; } r being volatile

Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

2013-11-08 Thread Richard Biener
On Fri, Nov 8, 2013 at 3:24 AM, Cong Hou co...@google.com wrote: Ping. OK for the trunk? Ok. Thanks, Richard. thanks, Cong On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou co...@google.com wrote: It seems that on some platforms the loops in testsuite/gcc.dg/vect/pr58508.c may be unable to

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-08 Thread Ilya Enkovich
2013/11/8 Richard Biener richard.guent...@gmail.com: On Thu, Nov 7, 2013 at 7:55 PM, Jeff Law l...@redhat.com wrote: On 11/07/13 04:50, Ilya Enkovich wrote: Hi, Here is an updated patch version. I think this needs to hold until we have a consensus on what the parameter passing looks like

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-08 Thread Jakub Jelinek
On Fri, Nov 08, 2013 at 10:43:26AM +0100, Richard Biener wrote: Here is an updated patch version. I think this needs to hold until we have a consensus on what the parameter passing looks like for bounded pointers. I still think the best thing to do on GIMPLE is arg_2 =

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Richard Biener
On Fri, Nov 8, 2013 at 10:39 AM, Mike Stump mikest...@comcast.net wrote: On Nov 8, 2013, at 1:32 AM, Bin.Cheng amker.ch...@gmail.com wrote: On Fri, Nov 8, 2013 at 5:03 PM, Mike Stump mikest...@comcast.net wrote: On Nov 7, 2013, at 5:13 PM, Mingjie Xing mingjie.x...@gmail.com wrote: Well, it

Re: [PATCH 1/3] libgcc: check for fenv.h in dfp configure check

2013-11-08 Thread Bernhard Reutner-Fischer
On 4 April 2013 23:01, Ian Lance Taylor i...@google.com wrote: On Thu, Apr 4, 2013 at 12:53 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: 2013-03-24 Bernhard Reutner-Fischer al...@gcc.gnu.org * configure.ac (libgcc_cv_dfp): Extend check to probe fenv.h

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Bin.Cheng
On Fri, Nov 8, 2013 at 5:39 PM, Mike Stump mikest...@comcast.net wrote: On Nov 8, 2013, at 1:32 AM, Bin.Cheng amker.ch...@gmail.com wrote: On Fri, Nov 8, 2013 at 5:03 PM, Mike Stump mikest...@comcast.net wrote: On Nov 7, 2013, at 5:13 PM, Mingjie Xing mingjie.x...@gmail.com wrote: Well, it

Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY

2013-11-08 Thread Bernhard Reutner-Fischer
On 11 April 2013 14:18, Paolo Carlini paolo.carl...@oracle.com wrote: Hi, On 04/11/2013 02:04 PM, Bernhard Reutner-Fischer wrote: I would have expected that somebody would tell me that omitting ::tmpnam violates 27.9.2 cstdio from the spec but noone yelled at me yet? Frankly, I didn't

Some wide-int review comments

2013-11-08 Thread Richard Sandiford
Some comments from looking through the diff with the merge point, ignoring wide-int.h and wide-int.cc. A few more to follow in the form of patchses. dwarf2out.c has: +case CONST_WIDE_INT: + if (mode == VOIDmode) + mode = GET_MODE (rtl); + + if (mode !=

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mingjie Xing
Oops, if it is not a bug, please close the report http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57258 Thanks, Mingjie 2013/11/8 Richard Biener richard.guent...@gmail.com: On Fri, Nov 8, 2013 at 10:39 AM, Mike Stump mikest...@comcast.net wrote: On Nov 8, 2013, at 1:32 AM, Bin.Cheng

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:25 AM, Bin.Cheng amker.ch...@gmail.com wrote: Thanks for elaborating. The warning message is actually for no-use of variable, and it has few things to do with whether it's accessed or not. I disagree. If you examine why the warning was put in, you realize it was put in

Re: [ARM, AArch64] Make aarch-common.c files more robust.

2013-11-08 Thread Ramana Radhakrishnan
On 11/06/13 09:45, James Greenhalgh wrote: Hi, This patch is a respin of the aarch-common improvements to use a generic search to find SETs and the variety of shifts, rather than relying on the hope that we will find something well formed. I've bootstrapped the patch on a chromebook with

Re: Some wide-int review comments

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:30 AM, Richard Sandiford rdsandif...@googlemail.com wrote: From gcse.c: --- wide-int-base/gcc/gcc/gcse.c 2013-11-05 13:09:32.148376180 + +++ wide-int/gcc/gcc/gcse.c 2013-11-05 13:07:28.431495118 + @@ -1997,6 +1997,13 @@ prune_insertions_deletions (int

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-11-08 Thread James Greenhalgh
On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou co...@google.com wrote: Thank you for your detailed explanation. Once GCC detects a reduction operation, it will automatically accumulate all elements in the vector after the loop. In the loop the reduction variable is always a vector whose

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-11-08 Thread Bernhard Reutner-Fischer
On 4 April 2013 22:20, Bruce Korb bk...@gnu.org wrote: Except as noted below, fine by me. On 04/04/13 12:56, Bernhard Reutner-Fischer wrote: Bootstrapped and regtested on x86_64-unknown-linux-gnu and x86_64-mine-linux-uclibc without regressions, ok for trunk? fixincludes/ChangeLog:

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:35 AM, Mingjie Xing mingjie.x...@gmail.com wrote: Oops, if it is not a bug, please close the report http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57258 Well, I've stated my position. I can be swayed by a good argument, if someone has one. I'd give people a chance to weigh

Re: [patch] safe iterator simplification

2013-11-08 Thread Jonathan Wakely
On 7 November 2013 21:00, François Dumont wrote: * include/debug/safe_iterator.h (_BeforeBeginHelper::_S_Is): Take only a const safe iterator reference. (_BeforeBeingHelper::_S_Is_beginnest): Likewise. There's a typo here, Being not Begin Ok to commit ? Yes, with the tiny fix

Recent Go patch broke Solaris bootstrap

2013-11-08 Thread Rainer Orth
The recent Go patch (couldn't find the submission on gcc-patches) broke Solaris bootstrap: on Solaris 10/x86 I get /vol/gcc/src/hg/trunk/local/libgo/go/net/fd_unix.go:414:72: error: reference to undefined identifier 'syscall.F_DUPFD_CLOEXEC' r0, _, e1 := syscall.Syscall(syscall.SYS_FCNTL,

Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Bernhard Reutner-Fischer
On 6 November 2013 08:04, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: Fixed patch is attached. The responses to your question are given below. Is this patch OK? Here is the ChangeLog entry: +2013-11-05 Balaji V. Iyer

Re: [PATCH] Add a new option -ftree-bitfield-merge (patch / doc inside)

2013-11-08 Thread Richard Biener
Hello, This is new patch version. Comments from Bernhard Reutner-Fischer review applied. Also, test case bitfildmrg2.c modified - it is now execute test. Example: Original code: unnamed-unsigned:3 D.1351; unnamed-unsigned:9 D.1350; unnamed-unsigned:7 D.1349; D.1349_2 =

Re: [patch libgcc]: Solve issue about too early released libgcc's DLL

2013-11-08 Thread Corinna Vinschen
Hi, On Nov 8 04:36, Kai Tietz wrote: Hello, this issue was discussed on cygwin's ML some time ago. For shared libgcc-DLL use it might happen that the DLL is released too early, so we need to perform an explicit load of it for increasing the load-count. By this we make sure that the DLL

[PATCH] Fix PR59047

2013-11-08 Thread Richard Biener
The following fixes PR59047 - data-ref and bitfields. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. Index: gcc/tree-predcom.c === *** gcc/tree-predcom.c (revision 204561) --- gcc/tree-predcom.c

Re: Implement C11 _Atomic

2013-11-08 Thread Dominique Dhumieres
The tests introduced in revision 204544 fail with -m32 (see http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00213.html or http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg00526.html ). This revision may also causes the failures of gfortran.dg/typebound_operator_9.f03 and FAIL:

Re: Implement C11 _Atomic

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Uros Bizjak wrote: Can we introduce a target-dependant source here, in the same way as Sure, that seems a reasonable thing to do. I think putting a file fenv.c in an appropriate subdirectory of libatomic/config will result in it being found automatically by the existing

Re: Implement C11 _Atomic

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Dominique Dhumieres wrote: This revision may also causes the failures of gfortran.dg/typebound_operator_9.f03 and FAIL: gfortran.fortran-torture/execute/forall_1.f90. I doubt the patch affects Fortran (there are language-independent changes, but they are fairly small and

Re: [PATCH] Reducing number of alias checks in vectorization.

2013-11-08 Thread Dominique Dhumieres
According to http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00197.html revision 204538 is breaking several tests. On x86_64-apple-darwin* the failures I have looked at are of the kind /opt/gcc/work/gcc/testsuite/gfortran.dg/typebound_operator_9.f03: In function 'nabla2_cart2d':

Re: Implement C11 _Atomic

2013-11-08 Thread Dominique Dhumieres
I doubt the patch affects Fortran (there are language-independent changes, but they are fairly small and shouldn't affect code not using _Atomic qualifiers). The Fortran failures seem related to revision 204538. Dominique

[PATCH][ARM] Add break in handling of comparisons in rtx costs function

2013-11-08 Thread Kyrill Tkachov
Hi all, In arm_new_rtx_costs we need a break; statement after handling the comparisons cases. Otherwise we fall through and compute garbage. This small patch adds that. Tested arm-none-eabi on qemu. Ok for trunk? Thanks, Kyrill 2013-11-08 Kyrylo Tkachov kyrylo.tkac...@arm.com *

[PATCH GCC]Refactor force_expr_to_var_cost and handle type conversion

2013-11-08 Thread bin.cheng
Hi, This patch refactors force_expr_to_var_cost and handles type conversion along with other tree nodes. It is split from the patch posted at http://gcc.gnu.org/ml/gcc-patches/2013-11/msg00546.html Bootstrap and test with the patch lowering address expressions on x86/x86_64/arm. Is it OK?

Re: [PATCH GCC]Refactor force_expr_to_var_cost and handle type conversion

2013-11-08 Thread Richard Biener
On Fri, Nov 8, 2013 at 2:41 PM, bin.cheng bin.ch...@arm.com wrote: Hi, This patch refactors force_expr_to_var_cost and handles type conversion along with other tree nodes. It is split from the patch posted at http://gcc.gnu.org/ml/gcc-patches/2013-11/msg00546.html Bootstrap and test with the

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-08 Thread Michael Matz
Hi, On Thu, 7 Nov 2013, Alec Teal wrote: subclass, by adding empty subclasses derived from the GSS_-based subclasses as appropriate (I don't bother for gimple codes that already have their own subclass due to having their own GSS layout). I also copied the comments from gimple.def

Re: [PATCH] Vectorization using elemental functions

2013-11-08 Thread Aldy Hernandez
On 11/08/13 07:10, Jakub Jelinek wrote: Hi! Here is an updated version of the patch I've posted yesterday. The changes since then are that the expander can now handle the CONSTRUCTORs this patch creates (although we probably want to add some vec_concat optab and at least improve handling of

[GOOGLE] tune loop scale factor for AutoFDO

2013-11-08 Thread Dehao Chen
AutoFDO sometimes has 0 profile in the loop's entry block because the debug info are lost and unrecoverable. E.g. if (a) if (b) for () {} This patch checks if the scale factor is 0, then use the normal scale. Bootstrapped and passed regression test and performance test. OK for

[patch 1/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
This creates new base classes for the parts of _State and _NFA which are not dependent on template parameters, and replaces some copies with moves. 2013-11-08 Jonathan Wakely jwakely@gmail.com * include/bits/regex_automaton.h (__detail::_State): Split non-dependent parts

[patch 3/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
This removes some more redundant _CharT template parameters. 2013-11-08 Jonathan Wakely jwakely@gmail.com * include/bits/regex_compiler.h (__detail::_AnyMatcher, __detail::_CharMatcher, __detail::_BracketMatcher): Remove redundant _CharT template parameters.

[patch 2/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
This removes the redundant _CharT template parameters that can be obtained from the _Traits parameters. It also adds the __compile_nfa function to create a _Compiler (deducing its template arguments) and get the _NFA from it. 2013-11-08 Jonathan Wakely jwakely@gmail.com *

RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
bootstrapped / regtested on i686-pc-linux-gnu. 2013-11-08 Joern Rennecke joern.renne...@embecosm.com PR middle-end/59049 * expmed.c (emit_cstore): Avoid generating a comparison of two VOIDmode constants. Index: gcc/expmed.c

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Daniel Krügler
2013/11/8 Jonathan Wakely jwakely@gmail.com: As I suggested yesterday on the libstdc++ list, this adds an overload for string and vector iterators to extract a raw pointer and re-use the _Compilerconst C*,... specialization, so that std::regex(.) and std::regex(std::string(.)) and

[patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
As I suggested yesterday on the libstdc++ list, this adds an overload for string and vector iterators to extract a raw pointer and re-use the _Compilerconst C*,... specialization, so that std::regex(.) and std::regex(std::string(.)) and std::regex(std::vectorchar(1, '.')) only instantiate

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 3:40 PM, Joern Rennecke joern.renne...@embecosm.com wrote: bootstrapped / regtested on i686-pc-linux-gnu. Not a very elaborate description of the patch, eh? :-) This is IMHO not OK without at least an explanation of why the comparison of two const_ints is not folded.

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
On 8 November 2013 14:45, Steven Bosscher stevenb@gmail.com wrote: Also would need a test case. As is mentioned in the PR, we already have a test case, which shows a regression.

some prep work to make JUMP_TABLE_DATA a non-active_insn_p object

2013-11-08 Thread Steven Bosscher
Hello, I'd like to make JUMP_TABLE_DATA a non-active insn before the end of stage1. Most of the work required for this is pretty simple. It involves finding and fixing the few places where insns are walked across basic block boundaries and ignoring barriers. Ah, the madness of that! :-)

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
On 8 November 2013 14:45, Steven Bosscher stevenb@gmail.com wrote: This is IMHO not OK without at least an explanation of why the comparison of two const_ints is not folded. Better yet would be to fix that underlying problem. We should not present such non-sense to the RTL parts of the

Re: [PATCH] make has_gate and has_execute useless

2013-11-08 Thread Trevor Saunders
On Fri, Nov 08, 2013 at 10:37:00AM +0100, Richard Biener wrote: On Thu, Nov 7, 2013 at 5:00 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This is the result of seeing what it would take to get rid of the has_gate and has_execute flags on

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:18 PM, Joern Rennecke wrote: On 8 November 2013 14:45, Steven Bosscher wrote: This is IMHO not OK without at least an explanation of why the comparison of two const_ints is not folded. Better yet would be to fix that underlying problem. We should not present such

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Jakub Jelinek
On Fri, Nov 08, 2013 at 04:32:09PM +0100, Steven Bosscher wrote: On Fri, Nov 8, 2013 at 4:18 PM, Joern Rennecke wrote: On 8 November 2013 14:45, Steven Bosscher wrote: This is IMHO not OK without at least an explanation of why the comparison of two const_ints is not folded. Better yet would

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 14:51, Daniel Krügler wrote: I have fully not grasped for which T the specializations of __has_contiguous_iter are intended to be used, Currently, only std::container iterators passed to a basic_regex constructor, but in theory the trait could get moved to another header and

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Teresa Johnson
On Tue, May 14, 2013 at 3:47 PM, Steven Bosscher stevenb@gmail.com wrote: On Wed, Apr 24, 2013 at 12:58 AM, Sriraman Tallam wrote: Hi, This patch generates labels for cold function parts that are split when using the option -freorder-blocks-and-partition. The cold label name is

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:41 PM, Jakub Jelinek wrote: On Fri, Nov 08, 2013 at 04:32:09PM +0100, Steven Bosscher wrote: On Fri, Nov 8, 2013 at 4:18 PM, Joern Rennecke wrote: On 8 November 2013 14:45, Steven Bosscher wrote: This is IMHO not OK without at least an explanation of why the

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Jeff Law
On 11/08/13 07:45, Steven Bosscher wrote: On Fri, Nov 8, 2013 at 3:40 PM, Joern Rennecke joern.renne...@embecosm.com wrote: bootstrapped / regtested on i686-pc-linux-gnu. Not a very elaborate description of the patch, eh? :-) This is IMHO not OK without at least an explanation of why the

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 15:41, Jonathan Wakely wrote: On 8 November 2013 14:51, Daniel Krügler wrote: I have fully not grasped for which T the specializations of __has_contiguous_iter are intended to be used, Currently, only std::container iterators passed to a basic_regex constructor, but in

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:45 PM, Teresa Johnson wrote: On Tue, May 14, 2013 at 3:47 PM, Steven Bosscher wrote: I'd like to revisit this old patch from Sri to generate a label for the split out cold section, now that all the patches to fix the failures and insanities from

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Teresa Johnson
On Fri, Nov 8, 2013 at 8:14 AM, Steven Bosscher stevenb@gmail.com wrote: On Fri, Nov 8, 2013 at 4:45 PM, Teresa Johnson wrote: On Tue, May 14, 2013 at 3:47 PM, Steven Bosscher wrote: I'd like to revisit this old patch from Sri to generate a label for the split out cold section, now that

[PATCH] Commonize repeated code into function

2013-11-08 Thread Jeff Law
This has been on my todo list for a little while now. Over time I've written the loop to delete a jump threading path several times. It's just 3 lines of code, but I hate repeating it all over the place. This pulls those trivial 3 lines into a function and calls it from the appropriate

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:45 PM, Teresa Johnson wrote: For example, from mcf with -freorder-blocks-and-partition: main: .LFB40: .cfi_startproc ... jne .L27 jump to main's text.unlikely ... .cfi_endproc .section

Re: Update soft-fp from glibc

2013-11-08 Thread Uros Bizjak
Hello! I've applied this patch to update libgcc's copy of soft-fp from glibc. There are lots of coding standards fixes, but also various bug fixes; I've added testcases for various of the fixed bugs illustrating them for __float128. Is there really no way to get those missing prototypes

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-11-08 Thread Bruce Korb
Sure. Looks good to me. Thanks On Fri, Nov 8, 2013 at 2:57 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 4 April 2013 22:20, Bruce Korb bk...@gnu.org wrote: Except as noted below, fine by me. On 04/04/13 12:56, Bernhard Reutner-Fischer wrote: Bootstrapped and regtested on

Fix for PR 59039

2013-11-08 Thread Iyer, Balaji V
Hello Everyone, Attached, please find a patch that will fix a crash in a function in libcilkrts when optimization was turned on. The issue was that the longjump and setjmp were called in the same function. This patch should fix that issue. The change is not in the compiler side but

Re: [PATCH][ARM] Add break in handling of comparisons in rtx costs function

2013-11-08 Thread Ramana Radhakrishnan
On 11/08/13 13:34, Kyrill Tkachov wrote: Hi all, In arm_new_rtx_costs we need a break; statement after handling the comparisons cases. Otherwise we fall through and compute garbage. This small patch adds that. Tested arm-none-eabi on qemu. Ok for trunk? Ok - thanks. Ramana

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
On 8 November 2013 15:50, Steven Bosscher stevenb@gmail.com wrote: Even with the gimple opts disabled, a const-const comparison would normally be folded by the RTL expanders. Well, in this spirit, attached is another way to address the RTL side of the problem. As mention in the PR, the tree

[PATCH, libatomic]: Add config/x86/fenv.c

2013-11-08 Thread Uros Bizjak
On Fri, Nov 8, 2013 at 2:13 PM, Joseph S. Myers jos...@codesourcery.com wrote: Can we introduce a target-dependant source here, in the same way as Sure, that seems a reasonable thing to do. I think putting a file fenv.c in an appropriate subdirectory of libatomic/config will result in it

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread Steven Bosscher
On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: Here is what I applied in the end; Jeff told me just to remove the testcase. I added the comment trying to explain why it was the opposite order of PHI-opt. Thanks, Andrew Pinski ChangeLog: * tree-ssa-ifcombine.c: Include rtl.h and

Re: [GOOGLE] tune loop scale factor for AutoFDO

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 6:23 AM, Dehao Chen de...@google.com wrote: AutoFDO sometimes has 0 profile in the loop's entry block because the debug info are lost and unrecoverable. Is that a separate problem to track and fix? Also is it better to do a round of loop profiling smoothing after auto

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 16:03, Jonathan Wakely wrote: On 8 November 2013 15:41, Jonathan Wakely wrote: On 8 November 2013 14:51, Daniel Krügler wrote: I have fully not grasped for which T the specializations of __has_contiguous_iter are intended to be used, Currently, only std::container

Go patch committed: Avoid bogus init loop error

2013-11-08 Thread Ian Lance Taylor
Code like this type S struct { F int } var V = S{F: 1} var F = V.F could trigger an incorrect variable initializer refers to itself error because the Go frontend would confuse itself into thinking that the F in the composite literal was the same as the global variable F, rather than

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 6:20 PM, Steven Bosscher wrote: On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: Here is what I applied in the end; Jeff told me just to remove the testcase. I added the comment trying to explain why it was the opposite order of PHI-opt. Thanks, Andrew Pinski

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread pinskia
On Nov 8, 2013, at 9:20 AM, Steven Bosscher stevenb@gmail.com wrote: On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: Here is what I applied in the end; Jeff told me just to remove the testcase. I added the comment trying to explain why it was the opposite order of PHI-opt.

Re: RFC: simd enabled functions (omp declare simd / elementals)

2013-11-08 Thread Aldy Hernandez
On 11/07/13 09:09, Martin Jambor wrote: I am glad this is becoming a useful infrastructure rather than just a part of IPA-SRA. Note that while ipa_combine_adjustments is not used from anywhere and thus probably buggy anyway, it should in theory be able to process new_param adjustments too.

Merge from GCC mainline to gccgo branch

2013-11-08 Thread Ian Lance Taylor
I merged GCC mainline revision 204583 to the gcgo branch. Ian

Re: [PATCH] Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 4:09 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 6 November 2013 08:04, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: Fixed patch is attached. The responses to your question are given below. Is

Re: Fix for PR 59039

2013-11-08 Thread H.J. Lu
On Fri, Nov 8, 2013 at 8:48 AM, Iyer, Balaji V balaji.v.i...@intel.com wrote: Hello Everyone, Attached, please find a patch that will fix a crash in a function in libcilkrts when optimization was turned on. The issue was that the longjump and setjmp were called in the same function.

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
in libgcov-driver.c /* Flag when the profile has already been dumped via __gcov_dump(). */ static int gcov_dump_complete; inline void set_gcov_dump_complete (void) { gcov_dump_complete = 1; } inline void reset_gcov_dump_complete (void) { gcov_dump_complete = 0; } These should be

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li davi...@google.com wrote: in libgcov-driver.c /* Flag when the profile has already been dumped via __gcov_dump(). */ static int gcov_dump_complete; inline void set_gcov_dump_complete (void) { gcov_dump_complete = 1; } inline void

[PATCH] Bug fix for PR59050

2013-11-08 Thread Cong Hou
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 This is my bad. I forget to check the test result for gfortran. With this patch the bug should be fixed (tested on x86-64). thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 90b01f2..e62c672 100644 --- a/gcc/ChangeLog +++

Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.

2013-11-08 Thread Jason Merrill
On 10/31/2013 05:47 AM, Adam Butcher wrote: + become_template = true; + push_deferring_access_checks (dk_deferred); Why is this call here? I don't see anything in the rest of the function that would trigger an access check, or a matching pop. + /* Create a distinct

Re: [PATCH] Reducing number of alias checks in vectorization.

2013-11-08 Thread Cong Hou
Thank you for the report. I have submitted a bug fix patch waiting to be reviewed. thanks, Cong On Fri, Nov 8, 2013 at 5:26 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: According to http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00197.html revision 204538 is breaking several tests. On

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
1) I don't think you need in_mem flag. For in memory merge, the source != NULL. discard this comment. David On Thu, Nov 7, 2013 at 3:34 PM, Rong Xu x...@google.com wrote: On Thu, Nov 7, 2013 at 9:40 AM, Joseph S. Myers jos...@codesourcery.com wrote: On Thu, 7 Nov 2013, Rong Xu

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
A question about inhibit_libc. When inhibit_libc is defined, we provide dummy functions for all the __gcov_* methods. Is it purposely to minimize the footprint? I'm thinking to allow some codes that are independent of libc (and its headers) under this. Is it OK? -Rong On Fri, Nov 8, 2013 at

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu x...@google.com wrote: On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li davi...@google.com wrote: in libgcov-driver.c /* Flag when the profile has already been dumped via __gcov_dump(). */ static int gcov_dump_complete; inline void

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-08 Thread David Malcolm
On Wed, 2013-11-06 at 22:32 -0700, Jeff Law wrote: [ Just a note, of this reply is meant for Michael and other parts for David, hopefully the audience is clear from the context. ] On 11/06/13 21:56, David Malcolm wrote: On Wed, 2013-11-06 at 16:32 +0100, Michael Matz wrote: Hi, On

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 10:56 AM, Rong Xu x...@google.com wrote: A question about inhibit_libc. When inhibit_libc is defined, we provide dummy functions for all the __gcov_* methods. Is it purposely to minimize the footprint? I'm thinking to allow some codes that are independent of libc (and

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
On Fri, Nov 8, 2013 at 11:02 AM, Xinliang David Li davi...@google.com wrote: On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu x...@google.com wrote: On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li davi...@google.com wrote: in libgcov-driver.c /* Flag when the profile has already been dumped via

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 11:21 AM, Rong Xu x...@google.com wrote: On Fri, Nov 8, 2013 at 11:02 AM, Xinliang David Li davi...@google.com wrote: On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu x...@google.com wrote: On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li davi...@google.com wrote: in

Re: [rl78] Use canonical const_int for one_cmplqi2

2013-11-08 Thread DJ Delorie
This patch just changes a QImode (const_int 255) to (const_int -1), since the canonical form is to sign-extend. As things stand the pattern trips a new assert added on the wide-int branch. Ok. Thanks!

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
On Fri, Nov 8, 2013 at 11:30 AM, Xinliang David Li davi...@google.com wrote: On Fri, Nov 8, 2013 at 11:21 AM, Rong Xu x...@google.com wrote: On Fri, Nov 8, 2013 at 11:02 AM, Xinliang David Li davi...@google.com wrote: On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu x...@google.com wrote: On Fri,

  1   2   >