Re: [PATCH, testsuite] Fix some testcases for nds32 target and provide new nds32 target specific tests

2013-11-29 Thread Mike Stump
On Nov 28, 2013, at 2:03 AM, Chung-Ju Wu wrote: > There is a pending testsuite patch for nds32 target: >http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01584.html > > Is it OK for trunk? :) Ok, but please remove: { target nds32*-*-* } from the gcc.target test cases, it is not redundant with

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Kenneth Zadeck
Richi, this is the first of either 2 or 3 patches to fix this.There are two places that need be fixed for us to do 1X + 1 and this patch fixes the first one. There was an unnecessary call to mul_full and this was the only call to mul_full. So this patch removes the call and also the f

[PATCH] Fix up cmove expansion (PR target/58864)

2013-11-29 Thread Jakub Jelinek
Hi! The following testcase ICEs because expand_cond_expr_using_cmove calls emit_conditional_move (which calls do_pending_stack_adjust under some circumstances), but when that fails, just removes all the insns generated by emit_conditional_move (and perhaps some earlier ones too), thus it removes a

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 12:02 PM, Marek Polacek wrote: > On Fri, Nov 29, 2013 at 08:57:23PM +0100, Jakub Jelinek wrote: >> On Fri, Nov 29, 2013 at 08:55:26PM +0100, Marek Polacek wrote: >> > 2013-11-29 Marek Polacek >> > >> > * bootstrap-ubsan.mk (POSTSTAGE1_LDFLAGS): Remove -lpthread -ldl.

Fix C handling of invalid designated initializers with string constants (PR 51458, PR c/42262)

2013-11-29 Thread Joseph S. Myers
PR 51458, a C++ bug report, mentioned in passing that the C front end accepted the invalid code char g[] = { [7] = "abcd" }; and I noted this on my list of known C conformance issues (unfortunately no C PR was filed for this, as far as I can tell, when the C++ bug was closed). This patch fixes t

Re: [PATCH] Fix up bogus warning (PR sanitizer/59331)

2013-11-29 Thread Jason Merrill
OK. Jason

Re: [golang-dev] Re: [patch] introduce aarch64 as a Go architecture

2013-11-29 Thread Rob Pike
aarch64 is arguably correct but not very evocative (to speak politely). the arm marketing people must be uninterested in distinguishing their design from other systems. arm64 is clearer and in line with amd64, but possibly confusing therefore. aarch64 is perhaps the better choice but arm64 would

patch to fix PR59340

2013-11-29 Thread Vladimir Makarov
The following patch is for PR59340. The rationale for the patch can be found in my comment on: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59340 The patch also fixes PPC bootstrap (with LRA switched on). The patch was committed as rev. 205541. 2013-11-29 Vladimir Makarov PR rtl-o

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread Marek Polacek
On Fri, Nov 29, 2013 at 08:57:23PM +0100, Jakub Jelinek wrote: > On Fri, Nov 29, 2013 at 08:55:26PM +0100, Marek Polacek wrote: > > 2013-11-29 Marek Polacek > > > > * bootstrap-ubsan.mk (POSTSTAGE1_LDFLAGS): Remove -lpthread -ldl. > > > > --- gcc/bootstrap-ubsan.mk.mp3 2013-11-29 20:5

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 08:55:26PM +0100, Marek Polacek wrote: > 2013-11-29 Marek Polacek > > * bootstrap-ubsan.mk (POSTSTAGE1_LDFLAGS): Remove -lpthread -ldl. > > --- gcc/bootstrap-ubsan.mk.mp32013-11-29 20:50:04.788238860 +0100 > +++ gcc/bootstrap-ubsan.mk2013-11-29 20:50:2

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread Marek Polacek
On Fri, Nov 29, 2013 at 08:32:34PM +0100, Jakub Jelinek wrote: > On Fri, Nov 29, 2013 at 11:22:00AM -0800, H.J. Lu wrote: > > On Mon, Nov 18, 2013 at 6:44 AM, Marek Polacek wrote: > > > On Mon, Nov 18, 2013 at 02:51:41PM +0100, Jakub Jelinek wrote: > > >> On Wed, Nov 13, 2013 at 12:13:48AM +0100,

Re: [patch] introduce aarch64 as a Go architecture

2013-11-29 Thread Andrew Pinski
On Fri, Nov 29, 2013 at 11:34 AM, Matthias Klose wrote: > Please let's pick aarch64. Everybody names it this way, except of course > Debian And the linux kernel. > :-/ If I understand ARM developers correctly, there will be something like > aarch32 in the future (x32 for ARM), and I think you

Re: [patch] Remove empty directories

2013-11-29 Thread Ian Lance Taylor
On Fri, Nov 29, 2013 at 5:38 AM, Matthias Klose wrote: > trunk has some empty directories. ok to remove? > > gcc/testsuite/go.test/test/fixedbugs/bug478.dir Removed. Sorry, not sure how that happened. Ian

Re: [patch] introduce aarch64 as a Go architecture

2013-11-29 Thread Matthias Klose
Please let's pick aarch64. Everybody names it this way, except of course Debian :-/ If I understand ARM developers correctly, there will be something like aarch32 in the future (x32 for ARM), and I think you don't want to call it arm32. Matthias Am 29.11.2013 20:22, schrieb Ian Lance Taylor:

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 11:22:00AM -0800, H.J. Lu wrote: > On Mon, Nov 18, 2013 at 6:44 AM, Marek Polacek wrote: > > On Mon, Nov 18, 2013 at 02:51:41PM +0100, Jakub Jelinek wrote: > >> On Wed, Nov 13, 2013 at 12:13:48AM +0100, Marek Polacek wrote: > >> > --- gcc/config/bootstrap-ubsan.mk.mp

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 11:22 AM, H.J. Lu wrote: > On Mon, Nov 18, 2013 at 6:44 AM, Marek Polacek wrote: >> On Mon, Nov 18, 2013 at 02:51:41PM +0100, Jakub Jelinek wrote: >>> On Wed, Nov 13, 2013 at 12:13:48AM +0100, Marek Polacek wrote: >>> > --- gcc/config/bootstrap-ubsan.mk.mp2013-11-1

Re: [patch] introduce aarch64 as a Go architecture

2013-11-29 Thread Ian Lance Taylor
I've gotten a patch from Michael Hudson-Doyle to set GOARCH to arm64 on an Aarch64 system (https://codereview.appspot.com/34830045/). I've gotten a patch from Matthias Klose to set GOARCH to aarch64 on such a system (http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03765.html). I don't care one way o

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-29 Thread H.J. Lu
On Mon, Nov 18, 2013 at 6:44 AM, Marek Polacek wrote: > On Mon, Nov 18, 2013 at 02:51:41PM +0100, Jakub Jelinek wrote: >> On Wed, Nov 13, 2013 at 12:13:48AM +0100, Marek Polacek wrote: >> > --- gcc/config/bootstrap-ubsan.mk.mp2013-11-12 13:46:13.345182065 >> > +0100 >> > +++ gcc/config/bo

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 9:48 AM, H.J. Lu wrote: > On Fri, Nov 29, 2013 at 9:06 AM, H.J. Lu wrote: >> On Fri, Nov 29, 2013 at 9:02 AM, H.J. Lu wrote: >>> On Fri, Nov 29, 2013 at 8:47 AM, H.J. Lu wrote: On Fri, Nov 29, 2013 at 4:31 AM, Yury Gribov wrote: >> Please fix up formatting

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Bin.Cheng
On Sat, Nov 30, 2013 at 12:34 AM, Richard Earnshaw wrote: > On 29/11/13 11:46, Yufeng Zhang wrote: >> On 11/29/13 07:52, Bin.Cheng wrote: >>> After thinking twice, I some kind of think we should not re-associate >>> addresses during expanding, because of lacking of context information. >>> Take

PATCH: Move config ChangeLog entries to config/ChangeLog

2013-11-29 Thread H.J. Lu
Hi, I checked in this patch to move config ChangeLog entries to config/ChangeLog. H.J. --- Index: ChangeLog === --- ChangeLog (revision 205537) +++ ChangeLog (working copy) @@ -2,10 +2,6 @@ * MAINTAINERS: Update my emai

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 9:06 AM, H.J. Lu wrote: > On Fri, Nov 29, 2013 at 9:02 AM, H.J. Lu wrote: >> On Fri, Nov 29, 2013 at 8:47 AM, H.J. Lu wrote: >>> On Fri, Nov 29, 2013 at 4:31 AM, Yury Gribov wrote: > Please fix up formatting > Also, isn't libsanitizer/libsanitizer.spec.in mi

Re: [PATCH] Put a breakpoint on __asan_report_error for ASAN

2013-11-29 Thread H.J. Lu
On Thu, Nov 29, 2012 at 9:42 AM, H.J. Lu wrote: > Hi, > > This patch puts a breakpoint on __asan_report_error if CFLAGS contains > -fsanitize=address, similar to fancy_abort and internal_error. OK to > install? > > > H.J. > -- > 2012-11-24 H.J. Lu > > * configure.ac: Append gdbasan.in

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 06:07:38PM +0100, Bernd Schmidt wrote: > By what mechanism do you choose? This is unclear to me from what I've > seen. Does this involve user action, and what's the advantage of doing > it this way? See the 3 threads I've mentioned. The compiler would know the list of avai

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Bernd Schmidt
On 11/29/2013 06:03 PM, Jakub Jelinek wrote: > On Fri, Nov 29, 2013 at 05:57:25PM +0100, Bernd Schmidt wrote: >> On 11/29/2013 04:16 PM, Jakub Jelinek wrote: >>> As you want to dump the GIMPLE IL right out of ~ IPA stage, it should in >>> theory be target independent, so it is undesirable to emit i

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 9:02 AM, H.J. Lu wrote: > On Fri, Nov 29, 2013 at 8:47 AM, H.J. Lu wrote: >> On Fri, Nov 29, 2013 at 4:31 AM, Yury Gribov wrote: Please fix up formatting >>> Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch? Ok with that fixed. >>>

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 05:57:25PM +0100, Bernd Schmidt wrote: > On 11/29/2013 04:16 PM, Jakub Jelinek wrote: > > As you want to dump the GIMPLE IL right out of ~ IPA stage, it should in > > theory be target independent, so it is undesirable to emit it several times > > for each offloading target.

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 8:47 AM, H.J. Lu wrote: > On Fri, Nov 29, 2013 at 4:31 AM, Yury Gribov wrote: >>> Please fix up formatting >> >>> Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch? >>> >>> Ok with that fixed. >> >> Thanks, r205524 >> > > On Linux/x86, I got > > FAIL: c

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Bernd Schmidt
On 11/29/2013 04:16 PM, Jakub Jelinek wrote: > As you want to dump the GIMPLE IL right out of ~ IPA stage, it should in > theory be target independent, so it is undesirable to emit it several times > for each offloading target. That's not what happens. It's just partitioned into disjoint sets, one

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 4:31 AM, Yury Gribov wrote: >> Please fix up formatting > >> Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch? >> >> Ok with that fixed. > > Thanks, r205524 > On Linux/x86, I got FAIL: c-c++-common/asan/pr59063-2.c -O0 (test for excess errors) FAIL:

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Richard Earnshaw
On 29/11/13 11:46, Yufeng Zhang wrote: > On 11/29/13 07:52, Bin.Cheng wrote: >> After thinking twice, I some kind of think we should not re-associate >> addresses during expanding, because of lacking of context information. >> Take base + scaled_index + offset as an example in PR57540, we just >>

Fix PR ada/59346

2013-11-29 Thread Eric Botcazou
It's a fallout of the changes made for PR ada/54040. Hopefully I didn't miss one the affected specifications. Applied on the mainline. 2013-11-29 Eric Botcazou PR ada/54040 PR ada/59346 * s-osinte-hpux.ads (timespec): Change type of tv_nsec field to time_t.

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Yufeng Zhang
On 11/29/13 10:44, Richard Biener wrote: On Fri, Nov 29, 2013 at 8:52 AM, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: On 18/09/13 10:15, bin.cheng wrote: -Original Message- From: gcc-patches-ow...@gc

[PATCH] fix combine.c:reg_nonzero_bits_for_combine where last_set_mode is narrower than mode

2013-11-29 Thread Paulo Matos
Please find patch for bug discussed in: http://gcc.gnu.org/ml/gcc/2013-11/msg00571.html Bootstrapped successfully in x86_64. 2013-11-29 Paulo Matos Eric Botcazou * combine.c (reg_nonzero_bits_for_combine): Apply mask transformation as applied to nonzero_sign_valid

Re: [PING][PATCH] LRA: check_rtl modifies RTL instruction stream

2013-11-29 Thread Vladimir Makarov
On 11/28/2013, 6:50 PM, Alan Modra wrote: On Wed, Nov 20, 2013 at 11:18:49AM -0700, Jeff Law wrote: 2013-11-13 Robert Suchanek * lra.c (lra): Set lra_in_progress before check_rtl call. * recog.c (insn_invalid_p): Add !lra_in_progress to prevent adding clobber regs whe

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Kenneth Zadeck
could be. On 11/29/2013 06:57 AM, Richard Sandiford wrote: Looks good to me FWIW, except: Kenneth Zadeck writes: @@ -112,11 +114,11 @@ along with GCC; see the file COPYING3. two, the default is the prefered representation. All three flavors of wide_int are represented as a vector

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 01:17:56PM +0100, Bernd Schmidt wrote: > We've been working on similar patches for our OpenACC project. The goal > is to have functions generated during omp-low that will ultimately > execute on a ptx target, write them out using LTO infrastructure and > read them back in us

Re: [PATCH][ARM] Improve Cortex A15 rtx costs, fix PR 59289

2013-11-29 Thread Richard Earnshaw
On 29/11/13 10:16, Kyrill Tkachov wrote: > Hi all, > > When the Cortex A15 rtx costs table was first written, it didn't take into > account that it was supposed to show the costs _above_ COSTS_N_INSNS (1). > This > patch adjusts that. Also, I've updated the accumulate costs and the > floating-

Re: [patch] Remove empty directories

2013-11-29 Thread Jonathan Wakely
On 29 November 2013 14:20, Ed Smith-Rowland wrote: > On 11/29/2013 08:38 AM, Matthias Klose wrote: >> >> trunk has some empty directories. ok to remove? >> >> gcc/testsuite/go.test/test/fixedbugs/bug478.dir >> libstdc++-v3/testsuite/experimental/string_view/requirements/exception >> libstdc++-v3/te

Re: [wide-int] Add a fast path for multiplication by 0

2013-11-29 Thread Richard Sandiford
Richard Biener writes: > On Fri, Nov 29, 2013 at 12:14 PM, Richard Sandiford > wrote: >> In the fold-const.ii testcase, well over half of the mul_internal calls >> were for multiplication by 0 (106038 out of 169355). This patch adds >> an early-out for that. >> >> Tested on x86_64-linux-gnu. OK

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 01:36:48PM +0100, Richard Biener wrote: > > Thoughts, comments? Does anyone have a good name for these accelerator > > targets or output targets, something that avoids the overloaded word > > "target" (I was thinking "destination machine" maybe)? I think offload is best wor

Re: wide-int, tree-ssa

2013-11-29 Thread Richard Sandiford
Only a partial reply. I'll leave Kenny and Mike to answer the VARYING question. Richard Biener writes: > On Sat, Nov 23, 2013 at 8:23 PM, Mike Stump wrote: >> Richi has asked the we break the wide-int patch so that the individual >> port and front end maintainers can review their parts without

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Yufeng Zhang
On 11/29/13 12:02, Richard Biener wrote: On Fri, Nov 29, 2013 at 12:46 PM, Yufeng Zhang wrote: On 11/29/13 07:52, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: On 18/09/13 10:15, bin.cheng wrote: -Ori

Re: [PATCH] Fix PR59208

2013-11-29 Thread Richard Biener
On Fri, 29 Nov 2013, Richard Biener wrote: > > The following re-org allows a cheaper fix to PR59208 than > a push/pop_cfun pair around a single update_stmt call. > > It's simple to make the SSA operand machinery cfun-agnostic > as it has few direct uses and does not use any APIs that > implicite

Re: RFC: PR bootstrap/59199: [4.9 Regression] r205032 caused LTO bootstrap to fail with bootstrap-profile

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 1:47 PM, Richard Biener wrote: > On Fri, Nov 29, 2013 at 1:27 PM, H.J. Lu wrote: >> On Fri, Nov 29, 2013 at 2:26 AM, Richard Biener >> wrote: >>> On Thu, Nov 28, 2013 at 6:22 PM, H.J. Lu wrote: There is a bad interaction between inlined C++ member functions and

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Kenneth Zadeck
On Nov 29, 2013, at 4:24 AM, Richard Biener wrote: > On Thu, Nov 28, 2013 at 6:11 PM, Kenneth Zadeck > wrote: >> This patch does three things in wide-int: >> >> 1) it cleans up some comments. >> 2) removes a small amount of trash. >> 3) it changes the max size of the wide int from being 4x

Re: [patch] Remove empty directories

2013-11-29 Thread Ed Smith-Rowland
On 11/29/2013 08:38 AM, Matthias Klose wrote: trunk has some empty directories. ok to remove? gcc/testsuite/go.test/test/fixedbugs/bug478.dir libstdc++-v3/testsuite/experimental/string_view/requirements/exception libstdc++-v3/testsuite/experimental/string_view/capacity/wchar_t libstdc++-v3/tests

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-29 Thread Jan Hubicka
> There is a comment: > >FIXME: the flags is incorrectly enabled for amdfam10, Bulldozer, >Bobcat and Generic. This is because disabling it causes large >regression on mgrid due to IRA limitation leading to unecessary >use of the frame pointer in 32bit mode. */ > DEF_TUNE (X86_TU

[patch] Remove empty directories

2013-11-29 Thread Matthias Klose
trunk has some empty directories. ok to remove? gcc/testsuite/go.test/test/fixedbugs/bug478.dir libstdc++-v3/testsuite/experimental/string_view/requirements/exception libstdc++-v3/testsuite/experimental/string_view/capacity/wchar_t libstdc++-v3/testsuite/experimental/string_view/capacity/char

[patch] Pass -fuse-ld=gold to gccgo on targets supporting -fsplit-stack

2013-11-29 Thread Matthias Klose
to get full advantage of the -fsplit-stack option, gccgo binaries have to be linked with gold, not the bfd linker. When the system linker defaults to the bfd linker, then gccgo should explicitly use the gold linker, passing fuse-ld=gold, unless another -fuse-ld option is present. Tested with and

[patch] introduce aarch64 as a Go architecture

2013-11-29 Thread Matthias Klose
This patch introduces aarch64 as a Go architecture. Matthias # DP: Introduce aarch64 goarch. --- a/src/libgo/go/go/build/syslist.go +++ a/src/libgo/go/go/build/syslist.go @@ -5,4 +5,4 @@ package build const goosList = "darwin dragonfly freebsd linux netbsd openbsd plan9 windows solaris " -

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-29 Thread H.J. Lu
On Thu, Nov 28, 2013 at 9:18 PM, Vladimir Makarov wrote: > On 11/28/2013, 7:51 PM, H.J. Lu wrote: >> >> On Thu, Nov 28, 2013 at 2:11 PM, Vladimir Makarov >> wrote: >>> >>>The following patch fixes PR57293 >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 >>> >>>It is actually an i

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Bernd Schmidt
On 11/29/2013 02:05 PM, Kirill Yukhin wrote: > On 29 Nov 13:17, Bernd Schmidt wrote: >> 5. There's a new DECL_TARGET which refers to this list of target >> machines. It's set when creating a child function from e.g. "#pragma acc >> parallel" > Actually, I do not understand, what term `target machin

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Kirill Yukhin
Hello Bernd, On 29 Nov 13:17, Bernd Schmidt wrote: > 5. There's a new DECL_TARGET which refers to this list of target > machines. It's set when creating a child function from e.g. "#pragma acc > parallel" Actually, I do not understand, what term `target machine' means here. Are you talking about

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 1:50 PM, Bernd Schmidt wrote: > On 11/29/2013 01:36 PM, Richard Biener wrote: >> Note that we (SUSE/AMD) sofar think we can go an easier route, not >> adding a real backend that targets HSAIL/BRIG but instead use a >> custom GIMPLE SSA -> HSAIL/BRIG translator (including a

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Bernd Schmidt
On 11/29/2013 01:36 PM, Richard Biener wrote: > Note that we (SUSE/AMD) sofar think we can go an easier route, not > adding a real backend that targets HSAIL/BRIG but instead use a > custom GIMPLE SSA -> HSAIL/BRIG translator (including a SSA > based register allocator). Which if course simplifies

Re: RFC: PR bootstrap/59199: [4.9 Regression] r205032 caused LTO bootstrap to fail with bootstrap-profile

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 1:27 PM, H.J. Lu wrote: > On Fri, Nov 29, 2013 at 2:26 AM, Richard Biener > wrote: >> On Thu, Nov 28, 2013 at 6:22 PM, H.J. Lu wrote: >>> There is a bad interaction between inlined C++ member functions >>> and LTO + profiledbootstrap, which leads to >>> >>> LTO bootstrap

[4/4] Minimal draft lto-wrapper changes

2013-11-29 Thread Bernd Schmidt
This doesn't get very far yet, but it's the start of what I imagine the lto-wrapper changes will look like. Bernd Index: gomp-4_0-branch/gcc/lto-wrapper.c === --- gomp-4_0-branch.orig/gcc/lto-wrapper.c +++ gomp-4_0-branch/gcc/lto-wr

[3/4] "Output targets", DECL_TARGET, and lto output

2013-11-29 Thread Bernd Schmidt
This is the largest patch (can be split up more, but I wanted to get this out the door). It adds the list of "output targets" which I hope someone will find a better name for, the corresponding DECL_TARGET, and mechanisms to write out lto for multiple targets. Also moves LTO section names into a s

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 1:17 PM, Bernd Schmidt wrote: > On 11/20/2013 10:36 AM, Jakub Jelinek wrote: >> On Wed, Nov 20, 2013 at 10:34:30AM +0100, Richard Biener wrote: >>> On Tue, Nov 19, 2013 at 10:58 AM, Ilya Tocar >>> wrote: On 14 Nov 11:27, Richard Biener wrote: >> + /* Set when sy

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread Yury Gribov
> Please fix up formatting > Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch? > > Ok with that fixed. Thanks, r205524 -Y

[2/4] Building in accel-gcc

2013-11-29 Thread Bernd Schmidt
This adds Makefile and configure goop to enable building an accelerator gcc in its own subdirectory along with the host compiler. Bernd * Makefile.def (host_modules, dependencies): Add accel-gcc entries. (flags_to_pass): Add accel_target_alias). * Makefile.tpl (accel_target_alias, accel_targ

[1/4] Add --enable-accelerator option

2013-11-29 Thread Bernd Schmidt
This one is small and pretty self-explanatory. Bernd 2013-09-05 Nathan Sidwell * configure.ac: Add --enable-accelerator. * configure: Rebuilt. Index: gomp-4_0-branch/configure.ac === --- gomp-4_0-branch.orig/configure.ac +++

Re: RFC: PR bootstrap/59199: [4.9 Regression] r205032 caused LTO bootstrap to fail with bootstrap-profile

2013-11-29 Thread H.J. Lu
On Fri, Nov 29, 2013 at 2:26 AM, Richard Biener wrote: > On Thu, Nov 28, 2013 at 6:22 PM, H.J. Lu wrote: >> There is a bad interaction between inlined C++ member functions >> and LTO + profiledbootstrap, which leads to >> >> LTO bootstrap to fail with bootstrap-profile: >> >> Existing SSA name fo

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-11-29 Thread Bernd Schmidt
On 11/20/2013 10:36 AM, Jakub Jelinek wrote: > On Wed, Nov 20, 2013 at 10:34:30AM +0100, Richard Biener wrote: >> On Tue, Nov 19, 2013 at 10:58 AM, Ilya Tocar wrote: >>> On 14 Nov 11:27, Richard Biener wrote: > + /* Set when symbol needs to be dumped for lto/offloading. */ > + unsigned

Re: [PATCH] Fix PR59338

2013-11-29 Thread Eric Botcazou
> This restricts BIT_FIELD_REF bound verification to non-aggegate > typed bases - otherwise we have to look for trailing arrays and > such (see the testcase), and Ada may even have more interesting > cases. Very likely not, they are equivalent in the end. I have installed the attached testcase,

Re: [PATCH, ia64] [PR target/52731] internal compiler error: in ia64_st_address_bypass_p, at config/ia64/ia64.c:9357

2013-11-29 Thread Kirill Yukhin
Hello, On 20 Nov 18:37, Kirill Yukhin wrote: > Hello, > Patch in the bottom fixes PR52731. > Is it ok for trunk? Ping? -- Thanks, K

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 12:46 PM, Yufeng Zhang wrote: > On 11/29/13 07:52, Bin.Cheng wrote: >> >> On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: >>> >>> On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw >>> wrote: On 18/09/13 10:15, bin.cheng wrote: > > > >> -Orig

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Richard Sandiford
Looks good to me FWIW, except: Kenneth Zadeck writes: > @@ -112,11 +114,11 @@ along with GCC; see the file COPYING3. > two, the default is the prefered representation. > > All three flavors of wide_int are represented as a vector of > - HOST_WIDE_INTs. The default and widest_int vect

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Yufeng Zhang
On 11/29/13 07:52, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: On 18/09/13 10:15, bin.cheng wrote: -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Beha

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 12:26 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Thu, Nov 28, 2013 at 6:11 PM, Kenneth Zadeck >> wrote: >>> This patch does three things in wide-int: >>> >>> 1) it cleans up some comments. >>> 2) removes a small amount of trash. >>> 3) it changes the max

Re: [wide-int] Add a fast path for multiplication by 0

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 12:14 PM, Richard Sandiford wrote: > In the fold-const.ii testcase, well over half of the mul_internal calls > were for multiplication by 0 (106038 out of 169355). This patch adds > an early-out for that. > > Tested on x86_64-linux-gnu. OK to install? Ok. Did you check

Re: [PATCH] Fix up bogus warning (PR sanitizer/59331)

2013-11-29 Thread Marek Polacek
On Thu, Nov 28, 2013 at 07:04:43PM -0500, Jason Merrill wrote: > On 11/28/2013 12:14 PM, Marek Polacek wrote: > > t = fold_build2 (COMPOUND_EXPR, TREE_TYPE (t), > >- ubsan_instrument_vla (input_location, t), t); > >+ ubsan_instrument_vla

Re: [patch] Fix PR middle-end/59138

2013-11-29 Thread Eric Botcazou
> I think I see a small flaw in that patch: > + /* Make sure not to write past the end of the struct. */ > + store_bit_field (dest, > + adj_bytelen * BITS_PER_UNIT, bytepos * BITS_PER_UNIT, > + bytepos * BITS_PER_UNIT, ssize * BITS_PER_UNIT, > + VOIDmode, tmps[i]); > the paramet

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 12:03 PM, Bin.Cheng wrote: > On Fri, Nov 29, 2013 at 6:44 PM, Richard Biener > wrote: >> On Fri, Nov 29, 2013 at 8:52 AM, Bin.Cheng wrote: >>> On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: > On 18/09/

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Richard Sandiford
Richard Biener writes: > On Thu, Nov 28, 2013 at 6:11 PM, Kenneth Zadeck > wrote: >> This patch does three things in wide-int: >> >> 1) it cleans up some comments. >> 2) removes a small amount of trash. >> 3) it changes the max size of the wide int from being 4x of >> MAX_BITSIZE_MODE_ANY_INT to

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread Jakub Jelinek
On Fri, Nov 29, 2013 at 02:58:47PM +0400, Yury Gribov wrote: > --- a/gcc/testsuite/lib/asan-dg.exp > +++ b/gcc/testsuite/lib/asan-dg.exp > @@ -39,9 +39,9 @@ proc asan_link_flags { paths } { > set shlib_ext [get_shlib_extension] > > if { $gccpath != "" } { > + append flags " -B${gc

Re: [wide-int] Handle more ltu_p cases inline

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 11:08 AM, Richard Sandiford wrote: > Richard Earnshaw writes: >> On 28/11/13 17:29, Richard Sandiford wrote: >>> The existing ltu_p fast path can handle any pairs of single-HWI inputs, >>> even for precision > HOST_BITS_PER_WIDE_INT. In that case both xl and >>> yl are im

[wide-int] Add a fast path for multiplication by 0

2013-11-29 Thread Richard Sandiford
In the fold-const.ii testcase, well over half of the mul_internal calls were for multiplication by 0 (106038 out of 169355). This patch adds an early-out for that. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard Index: gcc/wide-int.cc ===

[wide-int] Handle more shift cases inline

2013-11-29 Thread Richard Sandiford
This patch adds fast paths to lshift and lrshift for offset_int and widest_int. In the fold-const.ii testcase it reduces the number of lshift_large calls from 369121 to 284 and the number lrshift_large calls from 93646 to 6. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard Index: gc

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Bin.Cheng
On Fri, Nov 29, 2013 at 6:44 PM, Richard Biener wrote: > On Fri, Nov 29, 2013 at 8:52 AM, Bin.Cheng wrote: >> On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: >>> On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: On 18/09/13 10:15, bin.cheng wrote: > > >> -Original

Re: [PING^2] [PATCH] PR59063

2013-11-29 Thread Yury Gribov
>>> Perhaps it is time for libsanitizer.spec filled in during >> configure of libsanitizer >> Draft patch is attached, let's see if I understood your > ... > my preference perhaps would be not to put > link_sanitizer into the Makefile*/libsanitizer.spec/gcc.c at all, > instead use it solely as con

[PATCH] Fix PR59208

2013-11-29 Thread Richard Biener
The following re-org allows a cheaper fix to PR59208 than a push/pop_cfun pair around a single update_stmt call. It's simple to make the SSA operand machinery cfun-agnostic as it has few direct uses and does not use any APIs that implicitely use cfun. Thus the patch adds and uses a new update_st

[PATCH] Fix PR59338

2013-11-29 Thread Richard Biener
This restricts BIT_FIELD_REF bound verification to non-aggegate typed bases - otherwise we have to look for trailing arrays and such (see the testcase), and Ada may even have more interesting cases. Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2013-11-29 Richard Biener

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-29 Thread Richard Biener
On Fri, Nov 29, 2013 at 8:52 AM, Bin.Cheng wrote: > On Thu, Nov 28, 2013 at 8:06 PM, Bin.Cheng wrote: >> On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: >>> On 18/09/13 10:15, bin.cheng wrote: > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:g

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-29 Thread Eric Botcazou
> PR59338, I have a fix in testing (restrict checking to non-aggregates). This will be sufficient for Ada I think, this occurs only when downcasting because of the infamous VIEW_CONVERT_EXPRs used to implement it (yes, the ones which carry the TYPE_ALIGN_OK flag). -- Eric Botcazou

Re: [wide-int] Handle more add and sub cases inline

2013-11-29 Thread Richard Sandiford
Kenneth Zadeck writes: > I would like to see some comment to the effect that this to allow > inlining for the common case for widest int and offset int without > inlining the uncommon case for regular wide-int. OK, how about: /* If the precision is known at compile time to be greater than

Re: RFC: PR bootstrap/59199: [4.9 Regression] r205032 caused LTO bootstrap to fail with bootstrap-profile

2013-11-29 Thread Richard Biener
On Thu, Nov 28, 2013 at 6:22 PM, H.J. Lu wrote: > There is a bad interaction between inlined C++ member functions > and LTO + profiledbootstrap, which leads to > > LTO bootstrap to fail with bootstrap-profile: > > Existing SSA name for symbol marked for renaming: aloop_37 > In member function \u20

Re: [wide-int] small cleanup in wide-int.*

2013-11-29 Thread Richard Biener
On Thu, Nov 28, 2013 at 6:11 PM, Kenneth Zadeck wrote: > This patch does three things in wide-int: > > 1) it cleans up some comments. > 2) removes a small amount of trash. > 3) it changes the max size of the wide int from being 4x of > MAX_BITSIZE_MODE_ANY_INT to 2x +1. This should improve large

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-29 Thread Richard Biener
On Thu, Nov 28, 2013 at 4:39 PM, Eric Botcazou wrote: >> Ok if testing succeeds there but please leave out the checking bits. > > Yes, they (perhaps unsurprisingly) trigger in Ada, I'll investigate. PR59338, I have a fix in testing (restrict checking to non-aggregates). Richard. > -- > Eric Bot

Re: [wide-int] Handle more cmps and cmpu cases inline

2013-11-29 Thread Richard Sandiford
Kenneth Zadeck writes: > like the add/sub patch, enhance the comment so that it says that it is > designed to hit the widestint and offset int common cases. These cases are designed for all types, not just offset_int and widest_int. We're using length-based tests because that catches more cases

[PATCH][ARM] Improve Cortex A15 rtx costs, fix PR 59289

2013-11-29 Thread Kyrill Tkachov
Hi all, When the Cortex A15 rtx costs table was first written, it didn't take into account that it was supposed to show the costs _above_ COSTS_N_INSNS (1). This patch adjusts that. Also, I've updated the accumulate costs and the floating-point convert costs. Before that they showed the cost o

Re: [wide-int] Handle more ltu_p cases inline

2013-11-29 Thread Richard Sandiford
Richard Earnshaw writes: > On 28/11/13 17:29, Richard Sandiford wrote: >> The existing ltu_p fast path can handle any pairs of single-HWI inputs, >> even for precision > HOST_BITS_PER_WIDE_INT. In that case both xl and >> yl are implicitly sign-extended to the larger precision, but with the >> ex

Re: [PATCH] SIMD clones LTO fixes part 2 (PR lto/59326)

2013-11-29 Thread Richard Biener
On Fri, 29 Nov 2013, Jakub Jelinek wrote: > Hi! > > And here is second part of the fixes. Still, the vect-simd-clone-12.c > testcase fails with -flto -flto-partition=1to1, so there is further work to > do, but at least all current test succeed and actually use SIMD elementals > when they should.

Re: [PATCH] SIMD clones LTO fixes part 1 (PR lto/59326)

2013-11-29 Thread Richard Biener
On Thu, 28 Nov 2013, Jakub Jelinek wrote: > Hi! > > Here is the first part of LTO fixes for #pragma omp declare simd, > in partuclar support for streaming OMP_CLAUSEs. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok. Thanks, Richard. > 2013-11-28 Jakub Jelinek >

Re: [PATCH] Fix PR59330

2013-11-29 Thread Richard Biener
On Thu, 28 Nov 2013, Jakub Jelinek wrote: > On Thu, Nov 28, 2013 at 11:14:45AM -0800, H.J. Lu wrote: > > On Thu, Nov 28, 2013 at 6:49 AM, Richard Biener wrote: > > > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > > > > > Richard. > > > > > > 2013-11-28 Richard Biener >