Re: [PATCH, testsuite] Fix alignment in movapd tests

2013-12-12 Thread Uros Bizjak
On Wed, Dec 11, 2013 at 3:37 PM, Ryan Mansfield rmansfi...@qnx.com wrote: 2013-12-10 Ryan Mansfield rmansfi...@qnx.com PR testsuite/59442 * gcc.target/i386/sse2-movapd-1.c: Fix alignment attributes. * gcc.target/i386/sse2-movapd-2.c: Likewise. * gcc.target/i386/avx-vmovapd-256-1.c:

Re: C++ edge_iterator (was: Re: [SH] PR 53976 - Add RTL pass to eliminate clrt, sett insns)

2013-12-12 Thread Trevor Saunders
On Wed, Dec 11, 2013 at 06:47:37PM +0100, Oleg Endo wrote: On Thu, 2013-11-21 at 00:04 +0100, Steven Bosscher wrote: Declaring the edge_iterator inside the for() is not a good argument against FOR_EACH_EDGE. Of course, brownie points are up for grabs for the brave soul daring enough to make

Re: [gofrontend-dev] Go patch committed: Implement method values in reflect package

2013-12-12 Thread Michael Hudson-Doyle
Ian Lance Taylor i...@google.com writes: This patch to the Go frontend and libgo implements method values in the reflect package. Working with method values and reflect now works correctly, at least on x86. Can you give me a test case? I can try it on a few other architectures tomorrow.

[committed] Diagnose invalid OpenMP copyprivate clause arguments (PR libgomp/59467)

2013-12-12 Thread Jakub Jelinek
Hi! Copyprivate clause has following restriction (in 2.5, 3.0, 3.1 and 4.0): All list items that appear in the copyprivate clause must be either threadprivate or private in the enclosing context. but we weren't diagnosing it and even in crayptr2.f90 testcase violated it. Fixed thusly, regtested

Re: _Cilk_spawn and _Cilk_sync for C++

2013-12-12 Thread Andreas Schwab
Iyer, Balaji V balaji.v.i...@intel.com writes: diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp index 707d17e..36c8111 100644 --- a/gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp +++ b/gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp @@

GOMP_target: alignment (was: [gomp4] #pragma omp target* fixes)

2013-12-12 Thread Thomas Schwinge
Hi! On Thu, 5 Sep 2013 18:11:05 +0200, Jakub Jelinek ja...@redhat.com wrote: 3) I figured out we need to tell the runtime library not just address, size and kind, but also alignment (we won't need that for the #pragma omp declare target global vars though), so that the runtime library can

Re: GOMP_target: alignment (was: [gomp4] #pragma omp target* fixes)

2013-12-12 Thread Jakub Jelinek
On Thu, Dec 12, 2013 at 10:53:02AM +0100, Thomas Schwinge wrote: On Thu, 5 Sep 2013 18:11:05 +0200, Jakub Jelinek ja...@redhat.com wrote: 3) I figured out we need to tell the runtime library not just address, size and kind, but also alignment (we won't need that for the #pragma omp declare

Re: GOMP_target: alignment (was: [gomp4] #pragma omp target* fixes)

2013-12-12 Thread Thomas Schwinge
Hi! On Thu, 12 Dec 2013 11:02:30 +0100, Jakub Jelinek ja...@redhat.com wrote: On Thu, Dec 12, 2013 at 10:53:02AM +0100, Thomas Schwinge wrote: On Thu, 5 Sep 2013 18:11:05 +0200, Jakub Jelinek ja...@redhat.com wrote: 3) I figured out we need to tell the runtime library not just address,

Re: New tsan tests.

2013-12-12 Thread Maxim Ostapenko
Anyway, let's keep the current tests as is, the patch is ok for trunk. Commited in 205925.

RE: Two build != host fixes

2013-12-12 Thread Bernd Edlinger
I have some more fixes for Ada cross-builds that Eric commented on but need a little more work - will try to re-test this evening and re-post tomorrow. It's also PR ada/55946. Would mind trying the attached patch? -- Eric Botcazou Hi Eric, your patch looks quite nice, (maybe

Re: Two build != host fixes

2013-12-12 Thread Eric Botcazou
your patch looks quite nice, (maybe s/host_alias= @host_alias@/host_alias = @host_alias@/) Thanks for spotting it, now fixed. but I have to make a few more patches, to get it working: error: system.ads has restriction No_Implicit_Dynamic_Code error: but the following files violate this

Re: Two build != host fixes

2013-12-12 Thread Iain Sandoe
Hi Eric, On 12 Dec 2013, at 12:11, Bernd Edlinger wrote: I have some more fixes for Ada cross-builds that Eric commented on but need a little more work - will try to re-test this evening and re-post tomorrow. It's also PR ada/55946. Would mind trying the attached patch? -- Eric

Re: Two build != host fixes

2013-12-12 Thread Eric Botcazou
using your patch + the mod I made for LDFLAGS. In gcc-interface/Makefile.in? I wasn't sure if it was really needed. Out of curiosity, what do you set LDFLAGS to exactly? I built x86_64-darwin12 X powerpc-darwin9 [build = x86_64-darwin12] and then a native X powerpc-darwin9 [build =

Re: Two build != host fixes

2013-12-12 Thread Iain Sandoe
Hi Eric, On 12 Dec 2013, at 12:34, Eric Botcazou wrote: using your patch + the mod I made for LDFLAGS. In gcc-interface/Makefile.in? I wasn't sure if it was really needed. Out of curiosity, what do you set LDFLAGS to exactly? Darwin doesn't have gettext in libSystem, I build it as a

RE: Two build != host fixes

2013-12-12 Thread Bernd Edlinger
your patch looks quite nice, (maybe s/host_alias= @host_alias@/host_alias = @host_alias@/) Thanks for spotting it, now fixed. but I have to make a few more patches, to get it working: error: system.ads has restriction No_Implicit_Dynamic_Code error: but the following files violate this

Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-12 Thread Jakub Jelinek
On Wed, Dec 11, 2013 at 11:51:55AM -0500, Jason Merrill wrote: It's only safe to free the targs if they weren't used to instantiate any templates, so I lean toward option #1. Did you test this with strict gc? Ok, after IRC discussion and another bootstrap/regtest I've installed this variant

Re: [C++ Patch] Fix __is_base_of vs incomplete types

2013-12-12 Thread Jason Merrill
I wouldn't expect it to cause problems. Jason

Re: Two build != host fixes

2013-12-12 Thread Eric Botcazou
arm-linux-gnueabihf-gcc -c -I./ -I/home/ed/gnu/x/arm-linux-gnueabihf-linux64/lib/gcc/arm-linux-gnueabihf/4. 9.0/adalib/../adainclude -I/home/ed/gnu/x/arm-linux-gnueabihf-linux64/lib/gcc/arm-linux-gnueabihf/4. 9.0/adalib/ -I. -I/home/ed/gnu/x/gcc-4.9-20131208/gcc/ada -g -O2 -W -Wall -gnatpg

Re: Two build != host fixes

2013-12-12 Thread Eric Botcazou
Darwin doesn't have gettext in libSystem, I build it as a convenience library, but it still needs to refer to a system framework. For this to link the gnattools I need: LDFLAGS=-L/path/to/my/convenience/lib -framework CoreFoundation OK, I'll add $(LDFLAGS). It was actually already passed

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-12 Thread Eric Botcazou
OK, so we want the attached patch? FWIW it passed make -k check-c check-c++ RUNTESTFLAGS=compat.exp struct-layout-1.exp on x86/Linux, x86-64/Linux, PowerPC/Linux [*], IA-64/Linux, SPARC/Solaris and SPARC64/Solaris with ALT_CC_UNDER_TEST set to the unpatched compiler. As well as on

Re: [PATCH] Enable Cilk keywords in Cilk Runtime

2013-12-12 Thread Aldy Hernandez
Iyer, Balaji V balaji.v.i...@intel.com writes: # Compiler and linker flags. GENERAL_FLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/runtime -I$(top_srcdir)/runtime/config/$(config_dir) -DIN_CILK_RUNTIME=1 -GENERAL_FLAGS += -D_Cilk_spawn= -D_Cilk_sync= -D_Cilk_for=for +# GENERAL_FLAGS +=

RE: [PING]: [GOMP4] [PATCH] SIMD-Enabled Functions (formerly Elemental functions) for C

2013-12-12 Thread Iyer, Balaji V
-Original Message- From: Aldy Hernandez [mailto:al...@redhat.com] Sent: Thursday, December 12, 2013 10:26 AM To: Iyer, Balaji V Cc: Jakub Jelinek; 'gcc-patches@gcc.gnu.org' Subject: Re: [PING]: [GOMP4] [PATCH] SIMD-Enabled Functions (formerly Elemental functions) for C On

patch to fix PR59470

2013-12-12 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59470 Committed as rev. 205930 for trunk and 205929 for gcc-4.8 branch. Jakub is doing reg testing but I am sure the results will be not worse as the patch is quite safe IMO. 2013-12-12 Vladimir Makarov

Re: [trunk]: Patch to move BITS_PER_UNIT to be available for genmodes.c

2013-12-12 Thread Michael Eager
On 12/11/13 17:35, Kenneth Zadeck wrote: This patch is for the trunk, but it solves a problem that comes up for wide-int. For wide-int we need to have the BITS_PER_UNIT available earlier.So this patch sets the default value (8) in genmodes.c so that it is available by anyone who

Re: Two build != host fixes

2013-12-12 Thread Iain Sandoe
On 12 Dec 2013, at 15:23, Eric Botcazou wrote: Darwin doesn't have gettext in libSystem, I build it as a convenience library, but it still needs to refer to a system framework. For this to link the gnattools I need: LDFLAGS=-L/path/to/my/convenience/lib -framework CoreFoundation OK,

Re: Two build != host fixes

2013-12-12 Thread Eric Botcazou
With your blanket change to gnattools/Makefile, isn't it also reasonable to apply the following? diff --git a/gcc/ada/gcc-interface/Make-lang.in b/gcc/ada/gcc-interface/Make-lang.in index cd3676f..241571d 100644 --- a/gcc/ada/gcc-interface/Make-lang.in +++

Re: Two build != host fixes

2013-12-12 Thread Iain Sandoe
On 12 Dec 2013, at 17:21, Eric Botcazou wrote: With your blanket change to gnattools/Makefile, isn't it also reasonable to apply the following? diff --git a/gcc/ada/gcc-interface/Make-lang.in b/gcc/ada/gcc-interface/Make-lang.in index cd3676f..241571d 100644 ---

libgo patch committed: Fix MakeFunc returning float on 32 bit x86

2013-12-12 Thread Ian Lance Taylor
This patch to libgo fixes using reflect.MakeFunc with functions that return a single floating point value on 32-bit x86. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. Ian diff -r 454895d0147d libgo/go/reflect/makefunc_386.S ---

Re: [gofrontend-dev] Go patch committed: Implement method values in reflect package

2013-12-12 Thread Ian Lance Taylor
On Thu, Dec 12, 2013 at 12:21 AM, Michael Hudson-Doyle michael.hud...@linaro.org wrote: Ian Lance Taylor i...@google.com writes: This patch to the Go frontend and libgo implements method values in the reflect package. Working with method values and reflect now works correctly, at least on

Go patch committed: Don't compare structs with blank non-comp fields

2013-12-12 Thread Ian Lance Taylor
The Go language spec was clarified to say that a struct with a blank field of non-comparable type may not be compared. This patch implements that restriction in the Go frontend, by removing the code that permitted it. This change requires a couple of test cases to be updated; I've simply copied

RE: [PATCH] Enable Cilk keywords in Cilk Runtime

2013-12-12 Thread Iyer, Balaji V
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Aldy Hernandez Sent: Thursday, December 12, 2013 10:47 AM To: Iyer, Balaji V Cc: gcc-patches@gcc.gnu.org; Jeff Law Subject: Re: [PATCH] Enable Cilk keywords in Cilk Runtime

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-12 Thread Vladimir Makarov
On 12/11/2013, 1:59 PM, Yvan Roux wrote: On 11 December 2013 19:25, Vladimir Makarov vmaka...@redhat.com wrote: On 12/11/2013, 5:35 AM, Yvan Roux wrote: Hi Vladimir, I've some regressions on ARM after this SP elimination patch, and they are execution failures. Here is the list:

Go patch committed: Don't permit importing a package as init

2013-12-12 Thread Ian Lance Taylor
In Go the top-level name init is special, as it names a function that is run when the program starts. The language therefore does not permit other uses of init at top level. This change to the Go frontend detects and bans one of those cases: importing a package under the local name init.

Re: Two build != host fixes

2013-12-12 Thread Eric Botcazou
.. then does the second block need hoisting to bracket the two cases with host!=build? This code works fine so I don't think that we really need to do anything. -- Eric Botcazou

Re: RFA (cgraph): C++ 'structor decloning patch, Mark III

2013-12-12 Thread Jan Hubicka
Hi, diff --git a/gcc/c-family/c-opts.c b/gcc/c-family/c-opts.c index f368cab..3576f7d 100644 --- a/gcc/c-family/c-opts.c +++ b/gcc/c-family/c-opts.c @@ -899,6 +899,10 @@ c_common_post_options (const char **pfilename) if (warn_implicit_function_declaration == -1)

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-12-12 Thread Teresa Johnson
On Wed, Dec 11, 2013 at 10:05 PM, Teresa Johnson tejohn...@google.com wrote: On Fri, Dec 6, 2013 at 6:23 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, all This is the new patch for gcov-tool (previously profile-tool). Honza: can you comment on the new merge interface? David posted some comments

Re: [PING]: [GOMP4] [PATCH] SIMD-Enabled Functions (formerly Elemental functions) for C

2013-12-12 Thread Aldy Hernandez
On 12/12/13 07:56, Iyer, Balaji V wrote: Will it be Ok if I don’t mark them as cilk simd function but just keep it as omp declare simd from the start? That should get around this issue. No, because then we won't be able to distinguish between OMP and Cilk Plus clones. This is something we

libgo patch committed: Fix defer of unlock thread at startup

2013-12-12 Thread Ian Lance Taylor
This patch to libgo fixes the handling of the deferring of the unlock thread at program startup. The code was incorrectly freeing a stack object. This patch also cleans up some cases of freeing a defer block to avoid doing it when there is no Go context available. Bootstrapped and ran Go

Go patch committed: Tweak untyped nil error messages

2013-12-12 Thread Ian Lance Taylor
This patch to the Go frontend tweaks the existing error messages about use of untyped nil to do a better job when nil appears as the first argument to the builtin append function. This avoids an error about nil not being a slice type--it's more useful to say that the problem is an untyped nil.

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2013-12-12 Thread Jan Hubicka
On Wed, Dec 11, 2013 at 1:21 AM, Martin Liška marxin.li...@gmail.com wrote: Hello, I prepared a collection of systemtap graphs for GIMP. 1) just my profile-based function reordering: 550 pages 2) just -freorder-blocks-and-partitions: 646 pages 3) just

Go patch committed: Check for nil pointer when slicing pointer to array

2013-12-12 Thread Ian Lance Taylor
When Go code takes a slice of a pointer to an array, the compiler was failing to check whether that point is nil, as is required by the Go 1.2 addition of reliable nil checks. This patch fixes that oversight. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline.

[PATCH] Obvious bugfix to x86 machine description

2013-12-12 Thread Jeff Law
I stumbled over this while trying to fix one of the regressions for 4.9. This peep2 pattern in the x86 backend is obviously broken as it does not have a mode on the zero_extend in the resulting insn. As a result, if/when this peep2 matches we get an unrecognized insn. (define_peephole2

[PATCH] Don't reject TER unnecessarily (PRs middle-end/58956, middle-end/59470)

2013-12-12 Thread Jakub Jelinek
Hi! Before the PR58956 fix find_replaceable_in_bb only gave up TER if stmt was gimple_assign_single_p that was storing something that could alias with TERed load, but now it also punts on calls (a lot of them apparently) and inline asm (all of them, because stmt_may_clobber_ref_p always returns

Go patch committed: Better error messages for { on next line

2013-12-12 Thread Ian Lance Taylor
The Go language requires that the { starting a block for an if, for, or switch statement be on the same line as the if/for/switch. This patch gives better error messages when a program does it wrong. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian

[PR tree-optimization/59149] fail on invalid arguments to flags_from_decl_or_type

2013-12-12 Thread Aldy Hernandez
flags_from_decl_or_type() only handles a TYPE or DECL. Make this explicit instead. I also added a check in the use in trans-mem.c, just in case. The subsequent conditionals should take care of the TM case. It would be nice if Marc Glisse could provide the testcase he mentioned was

Re: [gofrontend-dev] Go patch committed: Implement method values in reflect package

2013-12-12 Thread Michael Hudson-Doyle
Ian Lance Taylor i...@google.com writes: On Thu, Dec 12, 2013 at 12:21 AM, Michael Hudson-Doyle michael.hud...@linaro.org wrote: Ian Lance Taylor i...@google.com writes: This patch to the Go frontend and libgo implements method values in the reflect package. Working with method values and

C++ PATCH for c++/58954 (wrong access error with member templates)

2013-12-12 Thread Jason Merrill
Recently I've improved fn_type_unification's handling of access checks, but resolve_overloaded_unification didn't get the same attention. Fortunately, it's a simple matter of switching it over to using instantiate_template so that we have a function to check the accesses against. Tested

PATCH to add input_line macro to gdbinit.in

2013-12-12 Thread Jason Merrill
I often use input_line in breakpoint conditions when debugging the compiler, and losing the macro complicates that. Any objection to adding it to gdbinit.in? commit 5bee3eed904bb31ffcca5330f2c36e5aa1c35cb0 Author: Jason Merrill ja...@redhat.com Date: Wed Dec 11 11:29:37 2013 -0500 *

Go testsuite patch committed: Update to current testsuite

2013-12-12 Thread Ian Lance Taylor
This patch updates the Go testsuite to a copy of the current master testsuite. This brings the testsuite, and thus the compiler, up to the final Go 1.2 release. Tested by, of course, running the testsuite, on x86_64-unknown-linux-gnu. Committed to mainline. Ian foo.patch.bz2 Description:

Re: PATCH to add input_line macro to gdbinit.in

2013-12-12 Thread Mike Stump
On Dec 12, 2013, at 7:51 PM, Jason Merrill ja...@redhat.com wrote: I often use input_line in breakpoint conditions when debugging the compiler, and losing the macro complicates that. Any objection to adding it to gdbinit.in? That'd be wonderful.

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-12 Thread Jeff Law
On 12/11/13 12:19, Eric Botcazou wrote: Yes we do, even for struct { struct { int a; char a[1] } }; (note the not really trailing as there is padding after the trailing array). We do take size limitations from a DECL (if we see one) into account to limit the effect of this

Re: [PR tree-optimization/59149] fail on invalid arguments to flags_from_decl_or_type

2013-12-12 Thread Jeff Law
On 12/12/13 16:09, Aldy Hernandez wrote: flags_from_decl_or_type() only handles a TYPE or DECL. Make this explicit instead. I also added a check in the use in trans-mem.c, just in case. The subsequent conditionals should take care of the TM case. It would be nice if Marc Glisse could provide

Re: [PATCH] Don't reject TER unnecessarily (PRs middle-end/58956, middle-end/59470)

2013-12-12 Thread Richard Biener
Jakub Jelinek ja...@redhat.com wrote: Hi! Before the PR58956 fix find_replaceable_in_bb only gave up TER if stmt was gimple_assign_single_p that was storing something that could alias with TERed load, but now it also punts on calls (a lot of them apparently) and inline asm (all of them, because

Re: [PR tree-optimization/59149] fail on invalid arguments to flags_from_decl_or_type

2013-12-12 Thread Marc Glisse
On Thu, 12 Dec 2013, Aldy Hernandez wrote: flags_from_decl_or_type() only handles a TYPE or DECL. Make this explicit instead. I also added a check in the use in trans-mem.c, just in case. The subsequent conditionals should take care of the TM case. It would be nice if Marc Glisse could

Re: [PATCH] Don't reject TER unnecessarily (PRs middle-end/58956, middle-end/59470)

2013-12-12 Thread Jakub Jelinek
On Fri, Dec 13, 2013 at 07:30:12AM +0100, Richard Biener wrote: Jakub Jelinek ja...@redhat.com wrote: lhs of a call for calls or somewhere in output arguments of inline asm. Can you please simply use walk_stmt_load_store_ops to get at the stmt outputs? No, unfortunately. The problem is that

Re: [PATCH, nds32] Missing target_cpu_default in TARGET_DEFAULT_TARGET_FLAGS.

2013-12-12 Thread Chung-Ju Wu
2013/12/11 Monk Chiang sh.chian...@gmail.com: Hi, Recently I used --target=nds32be-elf to configure nds32 gcc, it seems that the big endian is not set as default. [...] The following is the patch to fix this issue. Tested on nds32be-elf. OK to apply? Index: