Re: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant

2014-05-30 Thread Paolo Bonzini
Il 29/05/2014 19:20, pins...@gmail.com ha scritto: What is your Pmode? Pmode is dimode while ptr_mode is simode. Pointers are zero extended when converting between si and di modes. As you noted, the fundamental difference between x32 and aarch64 is that aarch64 will still use 64-bit access

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Uros Bizjak
Hello! > This error is because _mm_pause is defined in the scope of #pragma GCC > target("sse"). But _mm_pause, which simply generates the pause > instruction, does not require SSE support. The pause instruction has > nothing really to do with SSE, and it works on all x86 processors (on > proces

Re: ipa-visibility TLC 2/n

2014-05-30 Thread Richard Sandiford
Jan Hubicka writes: >> Jan Hubicka writes: >> >> Richard Sandiford wrote the original section anchors implementation, >> >> so he would be a good person to comment about the interaction between >> >> aliases and section anchors. >> > >> > Thanks! Richard, does this patch seem sane? >> >> Looks g

[PATCH] Dumping Fields of A Class When -fdump-class-hierarchy

2014-05-30 Thread lin zuojian
* class.c (dump_class_hierarchy_1): dump fields after hierarchy information. --- gcc/cp/class.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/gcc/cp/class.c b/gcc/cp/class.c index 14780e7..13579ac 100644 --- a/gcc/cp/class.c +++ b/gcc/cp/class.c @

[PATCH] Fix up GCC_EXEC_PREFIX handling with ALT_*_UNDER_TEST

2014-05-30 Thread Jakub Jelinek
Hi! I've noticed that when running make check ALT_CC_UNDER_TEST=gcc ALT_CXX_UNDER_TEST=g++ when the newly built compiler is built into a different prefix than the system compiler (4.8.x or 4.4.x) lots of tests fail with errors where the system compiler either couldn't find headers or even can't ex

Re: [patch ping] libstdc++ testsuite cxxflags

2014-05-30 Thread Ramana Radhakrishnan
On Sat, May 24, 2014 at 5:54 PM, Jonathan Wakely wrote: > On 24 May 2014 17:07, David Edelsohn wrote: >> This patch broke the ability to run the libstdc++ testsuite on AIX. >> >> I now see the following errors: >> >> bad switch "-O": must be -all, -about, -indices, -inline, -expanded, -line, >> -

[PATCH, Fortran] PR61234: -Wuse-no-only

2014-05-30 Thread VandeVondele Joost
Hi, the attached patch fixes PR61234 by introducing a warning for modules used without an only qualifier, triggered by a flag '-Wuse-no-only'. It is a two line addition to module.c, plus mechanical changes to initialize the flag and keep the tests up-to-date. I currently have no copyright ass

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread Kai Tietz
So, completed bootstrap and regression-test for x86_64-unknown-linux-gnu (multilib) by using following predicate for sibcall-patch. (define_predicate "sibcall_memory_operand" (match_operand 0 "memory_operand") { return CONSTANT_P (op); }) Worked fine, no regressions. Is sibcall-patch ok wi

[AARCH64, PATCH] Fix ICE in aarch64_float_const_representable_p

2014-05-30 Thread Tom de Vries
Marcus, when building for aarch64-linux-gnu with --enable-checking=yes,rtl, I run into the following error: ... In file included from src/libgcc/libgcc2.c:56:0: src/libgcc/libgcc2.c: In function ‘__floattisf’: src/libgcc/libgcc2.h:200:20: internal compiler error: RTL check: expected code 'cons

Re: [AARCH64, PATCH] Fix ICE in aarch64_float_const_representable_p

2014-05-30 Thread Ramana Radhakrishnan
On Fri, May 30, 2014 at 9:14 AM, Tom de Vries wrote: > Marcus, > > when building for aarch64-linux-gnu with --enable-checking=yes,rtl, I run > into the following error: > ... > In file included from src/libgcc/libgcc2.c:56:0: > src/libgcc/libgcc2.c: In function ‘__floattisf’: > src/libgcc/libgcc2.

Re: [PATCH][ARM] Use mov_imm type for movw operations consistently

2014-05-30 Thread Ramana Radhakrishnan
On 05/29/14 16:25, Kyrill Tkachov wrote: Hi all, I noticed that in some of our move patterns the movw instruction is given the mov_reg type rather than the mov_imm type that all other uses of movw have. This patch fixes that. Scanning through our pipeline descriptions I see that mov_imm is tre

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-30 Thread Ramana Radhakrishnan
>+ if (!TARGET_VFP) >+return; >+ >+ /* Generate the equivalence of : s/equivalence/equivalent. Ok with that change and if no regressions. Ramana On Mon, May 26, 2014 at 9:01 AM, Kugan wrote: > Ping^2 ? > > Thanks, > Kugan > > On 12/05/14 09:47, Kugan wrote: >> Ping ? >> >> Thanks, >> Kug

Re: [RFC] optimize x - y cmp 0 with undefined overflow

2014-05-30 Thread Eric Botcazou
> I'd say we still handle "basic" symbolic range ops in > extract_range_from_binary_1 > but in extract_range_from_binary_expr for a symbolic op0 we try to simplify > it with both [op1, op1] and with the value-range of op1 until we get a > non-varying range as result. Not sure if it's worth restric

Re: [PATCH, Fortran] PR61234: -Wuse-no-only

2014-05-30 Thread Jakub Jelinek
On Fri, May 30, 2014 at 08:03:45AM +, VandeVondele Joost wrote: > +@item -Wuse-no-only > +@opindex @code{Wuse-no-only} > +@cindex warnings, use statements > +@cindex intrinsic > +Warn if a use statement has no only qualifier and thus implicitly imports > +all public entities of the used module

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2014-05-30 Thread Tom de Vries
On 14-01-14 20:36, Vladimir Makarov wrote: Unfortunately I haven't been able to find time to work further on the >>LRA part. >>So if you're still willing to pick up that part, that would be great. > >Vladimir, > >I gave this a try. The attached patch works for the included test-case >for x86_64.

RE: [PATCH, Fortran] PR61234: -Wuse-no-only

2014-05-30 Thread VandeVondele Joost
> I think it is really weird if a coding style warning is included in -Wall. I have no strong opinion on this, I followed the -Wintrinsic-shadow example, and I'm happy to change things. Note however, that even the Fortran standard recommends the ONLY option for example for intrinsic modules, t

[PATCH, i386] Enable fuse-caller-save for i386

2014-05-30 Thread Tom de Vries
Uros, This patch enables the fuse-caller-save optimization for i386. It sets the hook TARGET_CALL_FUSAGE_CONTAINS_NON_CALLEE_CLOBBERS to true. The definition of the hook is: ... set to true if all the calls in the current function contain clobbers in CALL_INSN_FUNCTION_USAGE for the registers

Re: [PATCH, i386] Enable fuse-caller-save for i386

2014-05-30 Thread Uros Bizjak
On Fri, May 30, 2014 at 11:45 AM, Tom de Vries wrote: > This patch enables the fuse-caller-save optimization for i386. > > It sets the hook TARGET_CALL_FUSAGE_CONTAINS_NON_CALLEE_CLOBBERS to true. > > The definition of the hook is: > ... > set to true if all the calls in the current function cont

Re: [patch ping] libstdc++ testsuite cxxflags

2014-05-30 Thread Jonathan Wakely
On 30/05/14 08:53 +0100, Ramana Radhakrishnan wrote: With all the other build breakages in the past week, I've just started seeing the first set of testresults from an auto-tester. It looks like on a cross test using rhe5 / x86_64 with the version of tcl8.4 I'm using I see the same errors that

Script for generating libstdc++ web docs for releases

2014-05-30 Thread Jonathan Wakely
This script automates the process of creating the libstdc++ release docs in various formats. I didn't try to integrate it with the update_web_docs_svn script because there are a lot of dependencies which aren't installed on sourceware.org anyway, so it needs to be run on another machine (but at le

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Kirill Yukhin
Hello Ian, Uroš, On 30 May 09:19, Uros Bizjak wrote: > Hello! > > > This error is because _mm_pause is defined in the scope of #pragma GCC > > target("sse"). But _mm_pause, which simply generates the pause > > instruction, does not require SSE support. The pause instruction has > > nothing reall

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Jakub Jelinek
On Fri, May 30, 2014 at 03:41:22PM +0400, Kirill Yukhin wrote: > That is definetely a bug and I see no compatibility issues in the fix. > > The only nit I see: maybe it'd be better to put this cpuid-less intrinsic > into immintin.h? xmmintrin.h serves for SSE. Wouldn't that be an API compatibilit

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Kirill Yukhin
On 30 May 13:45, Jakub Jelinek wrote: > On Fri, May 30, 2014 at 03:41:22PM +0400, Kirill Yukhin wrote: > > That is definetely a bug and I see no compatibility issues in the fix. > > > > The only nit I see: maybe it'd be better to put this cpuid-less intrinsic > > into immintin.h? xmmintrin.h serve

[PATCH, Pointer Bounds Checker 15/x] Keep instrumented versions

2014-05-30 Thread Ilya Enkovich
Hi, Before any instrumentation happens, instrumentation clones do not actually have any uses and thus may be removed. This patch fixes it by forbiding removal of not instrumented instrumentation clones. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-05-30 Ilya Enkovich

[PATCH, Pointer Bounds Checker 16/x] Register statically initialized pointers

2014-05-30 Thread Ilya Enkovich
Hi, This patchs registers all statically initialized vars in Pointer Bounds Checker. It allows to build proper Bounds Tables for statically initialized pointers. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-05-30 Ilya Enkovich * cgraphunit.c: Include tree-chk

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-05-30 Thread Peter Bergner
On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: > On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge wrote: > > This is being discussed in the thread at > > . Until that > > has been resolved, I do agree to check in the following pat

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-05-30 Thread Jakub Jelinek
On Fri, May 30, 2014 at 08:09:22AM -0500, Peter Bergner wrote: > On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: > > On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge wrote: > > > This is being discussed in the thread at > > > . Unt

libgo patch committed: Use _mm_pause rather than __builtin_ia32_pause

2014-05-30 Thread Ian Lance Taylor
This patch based on one by Peter Collingbourne changes libgo to use the somewhat portable _mm_pause intrinsic rather than the GCC-specific __builtin_ia32_pause builtin function. This makes it easier to compile libgo with compilers other than GCC. Bootstrapped and ran Go testsuite on x86_64-unknow

Re: [C++ Patch] PR 57543

2014-05-30 Thread Jason Merrill
On 05/29/2014 03:17 PM, Paolo Carlini wrote: I put together the below which already passes testing. Thanks! + bool do_inject = this_type && !dependent_type_p (this_type); !dependent_type_p should be !dependent_scope_p, or perhaps even CLASS_TYPE_P. It should be OK to inject a this po

Re: [C++ Patch] PR 57543

2014-05-30 Thread Paolo Carlini
Hi, On 05/30/2014 04:13 PM, Jason Merrill wrote: On 05/29/2014 03:17 PM, Paolo Carlini wrote: I put together the below which already passes testing. Thanks! You are welcome. Let's finish this, then ;) + bool do_inject = this_type && !dependent_type_p (this_type); !dependent_type_p

Re: [C++ Patch] PR 57543

2014-05-30 Thread Jason Merrill
On 05/30/2014 10:21 AM, Paolo Carlini wrote: You also need to propagate the flag in a bunch of other places: everywhere we call build_method_type_directly ought to cover it. Agreed, I spotted a few places. What about build_function_type? I think it's the same issue, right? Right, I was just th

Re: [PATCH, libgfortran] Add overflow check to xmalloc

2014-05-30 Thread Janne Blomqvist
PING On Tue, May 20, 2014 at 12:42 AM, Janne Blomqvist wrote: > On Thu, May 15, 2014 at 1:00 AM, Janne Blomqvist > wrote: >> Hi, >> >> a common malloc() pattern is "malloc(num_foo * sizeof(foo_t)", that >> is, create space for an array of type foo_t with num_foo elements. >> There is a slight da

Re: C++ PATCH for c++/60992 (lambda and constant variable)

2014-05-30 Thread Jason Merrill
On 05/02/2014 03:46 PM, Jason Merrill wrote: My change to avoid building a dummy variable in a nested function turns out to have been too aggressive; in this case, we have a reference to a local const variable in the type of an array that we're capturing. It seems safe enough to make dummy copie

C++ PATCH for c++/56947

2014-05-30 Thread Jason Merrill
Here the change to look up static/const vars from the enclosing context of a lambda again at instantiation time was breaking on 4.7 because we weren't instantiating the lambda op() until EOF. Fixed this way in 4.7; in later versions we already instantiate it early as part of the TAG_DEFN. Add

[Patch ARM] PR 61154 - Define TARGET_SUPPORTS_WIDE_INT.

2014-05-30 Thread Ramana Radhakrishnan
Hi, This is the simplest patch to fix PR61154 that came after the wide-int merge. I've got a patch stack that tries to audit the use of GEN_INT vs gen_int_mode and the use of CONST_DOUBLE with VOIDmode in the backend but it's still not safe to go and TBH I'd like to deal with that separately

Re: ipa-visibility TLC 2/n

2014-05-30 Thread David Edelsohn
Honza, I finally was able to bootstrap GCC on AIX yesterday. The bootstrap works, but the testsuite results are in extremely bad shape: 250 failures in G++ testsuite and 470 failures in libstdc++ testsuite. G++ previously had about 65 failures, mainly TLS and init. libstdc++ previously hovered ar

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread Richard Henderson
On 05/30/2014 01:08 AM, Kai Tietz wrote: > (define_predicate "sibcall_memory_operand" > (match_operand 0 "memory_operand") > { > return CONSTANT_P (op); > }) Surely that always returns false? Surely XEXP (op, 0) so that you look at the address, not the memory. r~

Re: [PATCH, Pointer Bounds Checker 16/x] Register statically initialized pointers

2014-05-30 Thread Jeff Law
On 05/30/14 07:00, Ilya Enkovich wrote: Hi, This patchs registers all statically initialized vars in Pointer Bounds Checker. It allows to build proper Bounds Tables for statically initialized pointers. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-05-30 Ilya Enkovich

Re: [PATCH, Pointer Bounds Checker 15/x] Keep instrumented versions

2014-05-30 Thread Jeff Law
On 05/30/14 06:56, Ilya Enkovich wrote: Hi, Before any instrumentation happens, instrumentation clones do not actually have any uses and thus may be removed. This patch fixes it by forbiding removal of not instrumented instrumentation clones. Bootstrapped and tested on linux-x86_64. Thanks,

Re: ipa-visibility TLC 2/n

2014-05-30 Thread Ramana Radhakrishnan
On Thu, May 29, 2014 at 3:17 PM, Yufeng Zhang wrote: > Hi Honza, > > I can confirm that with your commit r211045 the arm-none-linux-gnueabi{hf} > builds are OK now. Thanks for the fix. Testsuite regressions like FAIL: g++.dg/ipa/devirt-21.C -std=gnu++1y (test for excess errors) Excess errors:

Re: Require '%' to be at the beginning of a constraint string

2014-05-30 Thread Jeff Law
On 05/28/14 13:50, Richard Sandiford wrote: Thanks for the review. Jeff Law writes: On 05/26/14 13:21, Richard Sandiford wrote: If we're going to change it, then clearly the docs need to change and ideally we'd statically check the port's constraints during the build process to ensure they me

Re: [PATCH 1/4] Make coverage_compute_cfg_checksum callable with an argument

2014-05-30 Thread Jeff Law
On 05/30/14 00:47, Martin Liška wrote: Hello, this is a small patchset that prepares API for new IPA Identical code folding pass. The patch adds an argument for coverage_compute_cfg_checksum. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-05-29 Martin Liska

[RFC ARM] Error if overriding --with-tune by --with-cpu

2014-05-30 Thread James Greenhalgh
Hi, We error in the case where both --with-tune and --with-cpu are specified at configure time. In this case, we cannot distinguish this situation from the situation where --with-tune was specified at configure time and -mcpu was passed on the command line, so we give -mcpu precedence. This migh

Re: [patch, avr] ata6289 device ISA is updated

2014-05-30 Thread Denis Chertykov
2014-05-29 22:27 GMT+04:00 S, Pitchumani : > Hi, > > Device ATA6289 has MUL instruction and it belongs to avr4 ISA. > Now it is incorrectly listed under avr25. Attached patch corrects it. > > Please commit if the patch is OK. I do not have commit access. > > Regards, > Pitchumani > > 2014-05-29 Pi

Re: [PATCH 3/4] New attribute lookup function addition

2014-05-30 Thread Jeff Law
On 05/30/14 00:49, Martin Liška wrote: Hi, this patch introduces a new function lookup_attribute_starting that can find all attributes starting with a specified string. Purpose of the function is to be able to identify e.g. if a function has any 'omp' attribute. Bootstrapped and tested on x8

Re: [PATCH 4/4] New callgraph wrapper function creation added

2014-05-30 Thread Jeff Law
On 05/30/14 00:49, Martin Liška wrote: Hello, cgraph_make_wrapper is a new function that creates a simple wrapper of a function. The function will be used further in identical code folding if a pass proves that two functions are semantically equivalent. Bootstrapped and tested on x86_64-linu

Re: [PATCH 2/4] Enhancement of call graph API

2014-05-30 Thread Jeff Law
On 05/30/14 00:47, Martin Liška wrote: Hello, this patch enhances callgraph API to enable more precise control of expand_thunk; another function becomes global. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-05-29 Martin Liska * cgraph.h (expand_thunk):

Re: [PATCH, i386, Pointer Bounds Checker 11/x] Keep bounds initial values

2014-05-30 Thread Jeff Law
On 05/29/14 04:53, Ilya Enkovich wrote: Hi, This patch tries to keep bounds initial values when it may be needed. Even if initial value is not fully known (e.g. we know only low bound) it still may help to remove some redundant checks. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -

Re: [PATCH, i386, Pointer Bounds Checker 12/x] Recognize instrumented special functions

2014-05-30 Thread Jeff Law
On 05/29/14 05:00, Ilya Enkovich wrote: Hi, This patch allows to recognize instrumented call to special function by using the original function name for recognition. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-05-29 Ilya Enkovich * calls.c (special_function

Re: libsanitizer merge from upstream r208536

2014-05-30 Thread Dodji Seketeli
Jakub Jelinek writes: [...] > Ok, tried to merge also g++.dg/asan from the same revision as you've merged > libsanitizer. [...] > > 2014-05-22 Jakub Jelinek > > * g++.dg/asan/asan_test.C: Add -std=c++11 and > -DSANITIZER_USE_DEJAGNU_GTEST=1 to dg-options, remove > -DASAN_U

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread Kai Tietz
- Original Message - > On 05/30/2014 01:08 AM, Kai Tietz wrote: > > (define_predicate "sibcall_memory_operand" > > (match_operand 0 "memory_operand") > > { > > return CONSTANT_P (op); > > }) > > Surely that always returns false? Surely XEXP (op, 0) so that you look at > the > address,

Re: libsanitizer merge from upstream r208536

2014-05-30 Thread Dodji Seketeli
Jakub Jelinek writes: > On Thu, May 22, 2014 at 04:07:38PM +0200, Jakub Jelinek wrote: >> 2014-05-22 Jakub Jelinek >> >> * sanitizer.def (BUILT_IN_ASAN_REPORT_LOAD_N, >> BUILT_IN_ASAN_REPORT_STORE_N): New. >> * asan.c (struct asan_mem_ref): Change access_size type to >> HO

Re: [PATCH, Pointer Bounds Checker 13/x] Early versioning

2014-05-30 Thread Jeff Law
On 05/29/14 05:05, Ilya Enkovich wrote: Hi, This patch allows to perform function versioning when some structures are not available yet. It is required to make clones for Pointer Bounds Checker right after SSA build. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-05-29

Re: libsanitizer merge from upstream r208536

2014-05-30 Thread Dodji Seketeli
Jakub Jelinek writes: [...] > Here is the GCC side of the thing, [...] > 2014-05-23 Jakub Jelinek > > * asan.c (report_error_func): Add SLOW_P argument, use > BUILT_IN_ASAN_*_N if set. > (build_check_stmt): Likewise. > (instrument_derefs): If T has insufficient ali

[patch] Update email address in docs

2014-05-30 Thread Jonathan Wakely
The docs still give Benjamin's old address for copyright assignment questions. Changed to my address, although I considered "volunteering" Paolo to get the mails ;-) Committed to trunk. commit 297bdcf296627c890b00db21a0333a7d0bb0a899 Author: Jonathan Wakely Date: Fri May 30 17:57:32 2014 +0100

Re: [PATCH, i386, Pointer Bounds Checker 10/x] Partitions

2014-05-30 Thread Jeff Law
On 05/28/14 10:06, Ilya Enkovich wrote: Hi, This patch keeps instrumented and original versions together and preserve tranparent alias chain during symbol name privatization. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2013-05-28 Ilya Enkovich * lto/lto-partitio

Re: [patch] libstdc++/61011 fix --disable-libstdcxx in top-level configure

2014-05-30 Thread Jonathan Wakely
PING This is a change to top-level configure, not libstdc++ itself, so I need approval. On 20/05/14 15:59 +0100, Jonathan Wakely wrote: On 20/05/14 15:53 +0100, Jonathan Wakely wrote: The first part of this patch fixes the PR, we should be adding target-libstdc++-v3 to noconfigdirs, not libst

Re: [patch] libstdc++/61011 fix --disable-libstdcxx in top-level configure

2014-05-30 Thread Jeff Law
On 05/30/14 11:09, Jonathan Wakely wrote: PING This is a change to top-level configure, not libstdc++ itself, so I need approval. On 20/05/14 15:59 +0100, Jonathan Wakely wrote: On 20/05/14 15:53 +0100, Jonathan Wakely wrote: The first part of this patch fixes the PR, we should be adding tar

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread Jeff Law
On 05/30/14 10:51, Kai Tietz wrote: - Original Message - On 05/30/2014 01:08 AM, Kai Tietz wrote: (define_predicate "sibcall_memory_operand" (match_operand 0 "memory_operand") { return CONSTANT_P (op); }) Surely that always returns false? Surely XEXP (op, 0) so that you look at

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-30 Thread H.J. Lu
On Thu, May 22, 2014 at 10:38 AM, H.J. Lu wrote: > On Thu, May 22, 2014 at 2:01 AM, Kirill Yukhin > wrote: >> Hello, >> On 20 May 08:24, H.J. Lu wrote: >>> ABI alignment should be sufficient for correctness. Bigger alignments >>> are supposed to give better performance. Can you try this patch o

Re: ipa-visibility TLC 2/n

2014-05-30 Thread David Edelsohn
Honza, For example g++.dg/abi/vcall1.C fails at a call in a "localalias" function, which jumps to a bad location: (gdb) up #1 0x14c0 in B::B() [clone .localalias.2] () (gdb) x/16i $pc-32 0x14a0 <_ZN1BC2Ev+156>: add r10,r10,r8 0x14a4 <_ZN1BC2Ev+160>: mr r3,r10 0x1

Re: [PATCH 2/3] PR other/61321 - demangler crash on casts in template parameters

2014-05-30 Thread Cary Coutant
> Fix this by adding a new DEMANGLE_COMPONENT_CONVERSION component type, > which does what DEMANGLE_COMPONENT_CAST does today, and making > DEMANGLE_COMPONENT_CAST just simply print its component subtree. > > I think we could instead reuse DEMANGLE_COMPONENT_CAST and in > d_print_comp_inner still d

Re: [C++ Patch] PR 57543

2014-05-30 Thread Paolo Carlini
Hi, On 05/30/2014 04:41 PM, Jason Merrill wrote: On 05/30/2014 10:21 AM, Paolo Carlini wrote: You also need to propagate the flag in a bunch of other places: everywhere we call build_method_type_directly ought to cover it. Agreed, I spotted a few places. What about build_function_type? I think

Re: [patch] Update email address in docs

2014-05-30 Thread Paolo Carlini
Hi, On 05/30/2014 07:04 PM, Jonathan Wakely wrote: The docs still give Benjamin's old address for copyright assignment questions. Changed to my address, although I considered "volunteering" Paolo to get the mails ;-) We may considering adding my email too, in the past I did that a lot anyway, b

Re: [PATCH, PR58942, Cilk+] Fix ICE when pointer is used in array notation

2014-05-30 Thread Jeff Law
On 05/25/14 03:31, Zamyatin, Igor wrote: Hi! Following patch handles the case of pointers in Cilk+ builtins. Regtested in x86_64. Ok for trunk and 4.9? Thanks, Igor gcc/c/ChangeLog: 2014-05-23 Igor Zamyatin PR c/58942 * c-array-notation.c (fix_builtin_array_notation_fn): Handle the case

Re: [PATCH] Fix up GCC_EXEC_PREFIX handling with ALT_*_UNDER_TEST

2014-05-30 Thread Mike Stump
On May 30, 2014, at 12:39 AM, Jakub Jelinek wrote: > Tested on x86_64-linux and i686-linux, ok for trunk/4.9? Ok.

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-05-30 Thread Konstantin Serebryany
Thanks Jakub! Looks like there is not rush with another merge now. --kcc On Fri, May 30, 2014 at 5:49 PM, Jakub Jelinek wrote: > On Fri, May 30, 2014 at 08:09:22AM -0500, Peter Bergner wrote: >> On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: >> > On Wed, 2014-05-28 at 09:36 +0200, Thoma

Re: [PATCH 2/3] PR other/61321 - demangler crash on casts in template parameters

2014-05-30 Thread Ian Lance Taylor
On Fri, May 30, 2014 at 10:37 AM, Cary Coutant wrote: >> Fix this by adding a new DEMANGLE_COMPONENT_CONVERSION component type, >> which does what DEMANGLE_COMPONENT_CAST does today, and making >> DEMANGLE_COMPONENT_CAST just simply print its component subtree. >> >> I think we could instead reuse

Re: [patch] Update email address in docs

2014-05-30 Thread Jonathan Wakely
On 30/05/14 19:38 +0200, Paolo Carlini wrote: Hi, On 05/30/2014 07:04 PM, Jonathan Wakely wrote: The docs still give Benjamin's old address for copyright assignment questions. Changed to my address, although I considered "volunteering" Paolo to get the mails ;-) We may considering adding my ema

[patch, arm] fix gcc.target/arm/pr45094.c options

2014-05-30 Thread Sandra Loosemore
This execution test specifies -mcpu=cortex-a8 but there is no corresponding check to make sure that the hardware/simulator being used to run the test can run cortex-a8 code. (The specific case we tripped over was in combination with a -mbig-endian multilib; the combination of the two options r

Re: [C++ Patch] PR 57543

2014-05-30 Thread Jason Merrill
On 05/30/2014 01:36 PM, Paolo Carlini wrote: 3- I understand Core/1227 as including the case of the late return type vs the parameters of generic lambdas, thus the rather heavy handed tweak to cp_parser_lambda_declarator_opt, which appears to work under the debugger (in the sense that for testcas

Re: [PATCH 2/3] PR other/61321 - demangler crash on casts in template parameters

2014-05-30 Thread Pedro Alves
On 05/30/2014 07:05 PM, Ian Lance Taylor wrote: >> > Looks good to me. Thanks! Thanks Cary! >> > Ian, does this look good to you? > I tend to defer to Jason on this sort of newfangled mangling > nuttiness, but I can take a look if he doesn't have time. Thanks! FWIW, it'd be great to have this a

[PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

2014-05-30 Thread VandeVondele Joost
Hi, the Fortran FE sets flag_errno_math and flag_associative_math https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=94447 https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=159620 Seemingly it (now?) needs to communicate that it is doing so, since otherwise this is overwritten later on

Re: [patch] Update email address in docs

2014-05-30 Thread Paolo Carlini
On 05/30/2014 08:23 PM, Jonathan Wakely wrote: On 30/05/14 19:38 +0200, Paolo Carlini wrote: Hi, On 05/30/2014 07:04 PM, Jonathan Wakely wrote: The docs still give Benjamin's old address for copyright assignment questions. Changed to my address, although I considered "volunteering" Paolo to g

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-05-30 Thread Christophe Lyon
Hi Alan This causes g++ to ICE on pr59378 test, for aarch64 targets: http://cbuild.validation.linaro.org/build/cross-validation/gcc/211058/report-build-info.html Can you check? Thanks, Christophe. On 19 May 2014 14:53, Marcus Shawcroft wrote: > On 23 April 2014 21:22, Alan Lawrence wrote: >

Re: ipa-visibility TLC 2/n

2014-05-30 Thread Jan Hubicka
> Honza, > > For example g++.dg/abi/vcall1.C fails at a call in a "localalias" > function, which jumps to a bad location: > > > (gdb) up > #1 0x14c0 in B::B() [clone .localalias.2] () > (gdb) x/16i $pc-32 >0x14a0 <_ZN1BC2Ev+156>: add r10,r10,r8 >0x14a4 <_ZN1BC2Ev+160>:

[PATCH] Updates merged bb count

2014-05-30 Thread Dehao Chen
This patch updates the merged bb count only when they are in the same loop. Bootstrapped and passed regression test. Ok for trunk? Thanks, Dehao gcc/ChangeLog: 2014-05-30 Dehao Chen * tree-cfg.c (gimple_merge_blocks): Only reset count when BBs are in the same loop. gcc/test

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-30 Thread Sandra Loosemore
On 05/28/2014 01:09 PM, Richard Sandiford wrote: Sandra Loosemore writes: On 05/19/2014 01:38 PM, Sandra Loosemore wrote: 2014-05-19 Iain Sandoe Catherine Moore Sandra Loosemore gcc/ * config/mips/mips.c (mips_set_current_function): Choose functi

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread H.J. Lu
On Fri, May 30, 2014 at 9:51 AM, Kai Tietz wrote: > - Original Message - >> On 05/30/2014 01:08 AM, Kai Tietz wrote: >> > (define_predicate "sibcall_memory_operand" >> > (match_operand 0 "memory_operand") >> > { >> > return CONSTANT_P (op); >> > }) >> >> Surely that always returns fals

Re: [GOOGLE] Emit linkage_name when built with -gmlt and for abstract decls

2014-05-30 Thread Dehao Chen
As we are pushing AutoFDO patch upstream, is this patch OK for trunk? Thanks, Dehao On Mon, Aug 19, 2013 at 1:32 PM, Dehao Chen wrote: > After rerunning test, this will fail one gcc regression test. So I > updated the patch to make sure all test will pass: > > Index: gcc/dwarf2out.c > ==

[PATCH, PR 61211] Fix a bug in clone_of_p verification

2014-05-30 Thread Martin Jambor
Hi, after a clone is materialized, its clone_of field is cleared which in PR 61211 leads to a failure in the skipped_thunk path in clone_of_p in cgraph.c, which then leads to a false positive verification failure. Fixed by the following patch. Bootstrapped and tested on x86_64-linux on both the

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread H.J. Lu
On Fri, May 30, 2014 at 3:05 PM, H.J. Lu wrote: > On Fri, May 30, 2014 at 9:51 AM, Kai Tietz wrote: >> - Original Message - >>> On 05/30/2014 01:08 AM, Kai Tietz wrote: >>> > (define_predicate "sibcall_memory_operand" >>> > (match_operand 0 "memory_operand") >>> > { >>> > return CONST

[PATCH, PR 61160] IPA-CP and edges leading to thunks of clones

2014-05-30 Thread Martin Jambor
Hi, PR 61160 is actually two problems, this patch deals with the one reported in comment one. The underlying cause is that an IPA-CP test whether an edge is already leading to a clone does not look through thunks, which caused it to double count and doubly-redirect them. Bootstrapped and tested

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread Bernd Edlinger
Hi Kai, this patch also mis-compiles binuitls-2.24 on x86_64. In the function walk_wild_consider_section (ld/ldlang.c) a tail-call gets miscompiled: The stack frame is cleaned up, but now the jump target is invalid.    0x0040c801 <+193>:    add    $0x28,%rsp    0x0040c805 <+197>

[PATCH, PR 61160] Artificial thunks need combined_args_to_skip

2014-05-30 Thread Martin Jambor
Hi, the second issue in PR 61160 is that because artificial thunks (produced by duplicate_thunk_for_node) do not have combined_args_to_skip, calls to them do not get actual arguments removed, while the actual functions do loose their formal parameters, leading to mismatches. Currently, the combin

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-05-30 Thread Tom de Vries
On 28-05-14 10:43, Kai Tietz wrote: Index: gcc/testsuite/gcc.target/i386/sibcall-4.c === --- gcc/testsuite/gcc.target/i386/sibcall-4.c (revision 0) +++ gcc/testsuite/gcc.target/i386/sibcall-4.c (working copy) @@ -0,0 +1,15 @@ +/*

Re: [GOOGLE] Emit linkage_name when built with -gmlt and for abstract decls

2014-05-30 Thread Dehao Chen
This will increase c++ g1/g2 binary size a little. For all spec cint2006 benchmarks, the binary size change is shown below. 400 0.00% 0.00% 0.00% 0.00% 401 0.00% 0.00% 0.00% 0.00% 403 0.00% 0.00% 0.00% 0.00% 429 0.00% 0.00% 0.00% 0.00% 445 0.00% 0.00% 0.00% 0.00% 456 0.00% 0.00% 0.00% 0.00% 458 0.

Re: [PATCH] Updates merged bb count

2014-05-30 Thread Steven Bosscher
On Fri, May 30, 2014 at 11:43 PM, Dehao Chen wrote: > Index: gcc/testsuite/gcc.dg/tree-prof/merge_block.c > === > --- gcc/testsuite/gcc.dg/tree-prof/merge_block.c (revision 0) > +++ gcc/testsuite/gcc.dg/tree-prof/merge_block.c (revisio

Re: [PATCH] Updates merged bb count

2014-05-30 Thread Dehao Chen
Thanks for the suggestion. I actually want this function to be inlined in ipa-inline phase, not einline phase. Dehao On Fri, May 30, 2014 at 4:50 PM, Steven Bosscher wrote: > On Fri, May 30, 2014 at 11:43 PM, Dehao Chen wrote: >> Index: gcc/testsuite/gcc.dg/tree-prof/merge_block.c >> ===

Re: ipa-visibility TLC 2/n

2014-05-30 Thread David Edelsohn
Honza, With the patch, I cannot bootstrap. I am concerned about the much greater frequency of AIX linker warnings about branch not followed by no-op after your patch. GCC may bootstrap only because it links libstdc++ statically. If your patch is too aggressive in its effort to remove PLT calls,

[C++11, C++14 PATCH 0/3] Support for SD-6: SG10 Feature Test Recommendations

2014-05-30 Thread Ed Smith-Rowland
A group within the C++ standards committee was charged with the responibility of coming up with a way for users to test a C++ compiler and runtime for the availability of new features. These features are intended to aid users in a time of intense C++ evolution. These features are not really p

[C++11, C++14 PATCH 2/3] Support for SD-6: SG10 Feature Test Recommendations - c-family and testsuite

2014-05-30 Thread Ed Smith-Rowland
This is the c-family part: Setting the language feature macos and defining the __has_include macro. c-family: 2014-05-31 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * c-cppbuiltin.c (c_cpp_builtins()): Define language feature

[C++11, C++14 PATCH 1/3] Support for SD-6: SG10 Feature Test Recommendations - libcpp

2014-05-30 Thread Ed Smith-Rowland
Here is the libcpp portion. 2014-05-31 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * directives.c: Support __has_include__ builtin. * expr.c (parse_has_include): New function to parse __has_include__ builtin; (eval_tok

[C++11, C++14 PATCH 3/3] Support for SD-6: SG10 Feature Test Recommendations - libstdc++

2014-05-30 Thread Ed Smith-Rowland
This is the libstdc++ and libstdc++ testsuite part. 2014-05-31 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * include/bits/basic_string.h: Add __cpp_lib feature test macro. * include/bits/stl_algobase.h: Ditto. * includ

Re: [C++11, C++14 PATCH 0/3] Support for SD-6: SG10 Feature Test Recommendations

2014-05-30 Thread Andrew Pinski
On Fri, May 30, 2014 at 8:41 PM, Ed Smith-Rowland <3dw...@verizon.net> wrote: > A group within the C++ standards committee was charged with the > responibility of coming up with a way for users to test a C++ compiler and > runtime for the availability of new features. These features are intended >

Re: [C++11, C++14 PATCH 2/3] Support for SD-6: SG10 Feature Test Recommendations - c-family and testsuite

2014-05-30 Thread Marc Glisse
On Fri, 30 May 2014, Ed Smith-Rowland wrote: + cpp_undef (pfile, "__cpp_constexpr"); + cpp_define (pfile, "__cpp_constexpr=201304"); Could you set the other value in an else branch to avoid a def undef redef game? Also, I am pretty sure that gcc doesn't support the latest co

Re: [C++11, C++14 PATCH 3/3] Support for SD-6: SG10 Feature Test Recommendations - libstdc++

2014-05-30 Thread Marc Glisse
On Fri, 30 May 2014, Ed Smith-Rowland wrote: +#define __cpp_lib_constexpr_functions 201210 appears quite a few times, I believe it will warn with -Wsystem-headers. I think you should check if it is already defined (or undefine it first). (you forgot to Cc: libstdc++) -- Marc Glisse