RE: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-07-30 Thread Thomas Preud'homme
Now that GCC 4.9 branch is opened again and GCC 4.8 branch still open, is the following backported patch ok for both branches? Best regards, Thomas > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme > Sent

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Roman Gareev
Could you please advise me how is it better to answer the following questions of Sven: > In what way is it "not optimal"? > That is, what are your optimality criteria? (I could answer them, but I don't want to miss anything) -- Cheers, Roman Gareev.

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Chen Gang
On 07/31/2014 12:10 PM, Jeff Law wrote: > On 07/30/14 09:01, Chen Gang wrote: >> Hello All: >> >> I shall stop making this kind of patch, next. The reason is that I worry >> about what I have done have negative effect to others. And next, I shall >> try to send another kinds of patches for gcc wh

Re: [Patch] PR 61692 - Fix for inline asm ICE

2014-07-30 Thread Jeff Law
On 07/28/14 16:39, David Wohlferd wrote: On 7/28/2014 12:42 PM, Jeff Law wrote: On 07/27/14 01:26, David Wohlferd wrote: I'm not sure which maintainer to cc for inline asm stuff? I have a release on file with the FSF, but don't have SVN write access. Problem: extract_insn() in recog.c will I

Re: Warn when returning the address of a temporary (middle-end) v2

2014-07-30 Thread Jeff Law
On 07/30/14 05:54, Marc Glisse wrote: On Tue, 29 Jul 2014, David Malcolm wrote: On Tue, 2014-07-29 at 19:36 +0200, Marc Glisse wrote: On Sun, 27 Jul 2014, Richard Sandiford wrote: Marc Glisse writes: Hello, I followed the advice in this discussion: https://gcc.gnu.org/ml/gcc-patches/2014-

Re: Warn when returning the address of a temporary (middle-end) v2

2014-07-30 Thread Jeff Law
On 07/22/14 03:03, Marc Glisse wrote: I note you don't catch return &localvar in the isolation code -- it looks like you just catch those which potentially flow from PHIs. I thought I was handling it in the find_explicit_erroneous_behaviour part of the patch (as opposed to the implicit part whi

Re: [PATCH][PING] Add support for KernelAddressSanitizer

2014-07-30 Thread Jeff Law
On 07/30/14 08:34, Yury Gribov wrote: On 07/18/2014 05:38 PM, Jakub Jelinek wrote: Do you error out on -fsanitize=thread -fsanitize=kernel-address ? Perhaps -fsanitize=kernel-address -fsanitize=address should be invalid too? Yes, all these combinations are invalid. But you don't error out on

Re: [PATCH 5/5] add libcc1

2014-07-30 Thread Jeff Law
On 06/19/14 14:52, Tom Tromey wrote: Tom> I've edited this one down by removing the auto-generated stuff , and Tom> then compressed it. Here's a new version of patch #5. I've removed the generated code; let's see if it gets through without compression. I think this addresses all the reviews: *

Re: [PATCH] Fix PR61893, constant folding breaking -ftrapv

2014-07-30 Thread Jeff Law
On 07/29/14 02:35, Richard Biener wrote: The following fixes the second bug you'll hit very fast when writing testcases for -ftrapv (maybe not so often in "real" scenarios). There are several places in the optimization pipeline where after constant folding we fail to generate trapping instructi

Re: [PATCH] gcc/gcc.c: XNEWVEC enough space for 'saved_suffix' using

2014-07-30 Thread Chen Gang
On 07/31/2014 11:09 AM, Jeff Law wrote: > On 07/30/14 16:29, Joseph S. Myers wrote: >> On Thu, 31 Jul 2014, Chen Gang wrote: >> >>> On 07/31/2014 06:12 AM, Joseph S. Myers wrote: On Thu, 24 Jul 2014, Chen Gang wrote: > strlen() will get string length excluding '\0', but strcpy() will

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Jeff Law
On 07/30/14 09:01, Chen Gang wrote: Hello All: I shall stop making this kind of patch, next. The reason is that I worry about what I have done have negative effect to others. And next, I shall try to send another kinds of patches for gcc when I have time. Many persons or companies use open sour

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Markus Trippelsdorf
On 2014.07.30 at 17:31 -0400, Jason Merrill wrote: > I think this should fix it. Indeed it does. Thanks. -- Markus

Re: [PATCH] PR61868

2014-07-30 Thread Jeff Law
On 07/30/14 09:20, Bingfeng Mei wrote: Yes, that fix is better. Here are updated patches. LTO-bootstrapped and tested. OK? Bingfeng Index: ChangeLog === --- ChangeLog (revision 213152) +++ ChangeLog (working copy) @@ -1,3 +1,1

Re: RFA: Remove insn_contains_asm from ira.c

2014-07-30 Thread Jeff Law
On 07/30/14 15:26, Richard Sandiford wrote: Just a small clean-up in preparation for the FOR_EACH_SUBRTX patches. insn_contains_asm can be tested more directly using extract_asm_operands, which doesn't involve any subcalls and should therefore be more efficient than calling for_each_rtx. Tested

Re: [PATCH 1/7] Change inchash to name space.

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen Change class inchash to move into a inchash namespace as requested. The class is now inchash::hash Rename iterative_hstate_expr to inchash::add_expr ... and convert existing users. It wasn't possible to use hash::, because that lead to name

Re: [PATCH 2/7] RTL & dwarf2out changes

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen Convert dwarf2out and rtl.c to the new inchash interface. I moved the rtl hash code to another file to avoid having to link all the hash code into the generator functions. v2: Removed ??? comment. gcc/: 2014-07-29 Andi Kleen

Re: [PATCH 3/7] Convert asan.c to inchash

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen gcc/: 2014-07-30 Andi Kleen * asan.c (asan_mem_ref_hasher::hash): Convert to inchash. OK once inchash namespace changes are approved. jeff

Re: [PATCH 6/7] Convert tree-ssa-sccvn to inchash

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen gcc/: 2014-07-29 Andi Kleen * tree-ssa-sccvn.c (vn_reference_op_compute_hash): Convert to inchash. (vn_reference_compute_hash): Dito. (vn_nary_op_compute_hash): Dito. (vn_phi_compute_hash): Dito.

Re: [PATCH 4/7] Convert ipa-devirt to inchash

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen gcc/: 2014-07-30 Andi Kleen * ipa-devirt.c (polymorphic_call_target_hasher::hash): Convert to inchash. OK once hashinc namespace is approved. jeff

Re: [PATCH] gcc/gcc.c: XNEWVEC enough space for 'saved_suffix' using

2014-07-30 Thread Jeff Law
On 07/30/14 16:29, Joseph S. Myers wrote: On Thu, 31 Jul 2014, Chen Gang wrote: On 07/31/2014 06:12 AM, Joseph S. Myers wrote: On Thu, 24 Jul 2014, Chen Gang wrote: strlen() will get string length excluding '\0', but strcpy() will append '\0' in the end, so need XNEWVEC additional byte, or c

Re: Move unwind info to read-only section on AIX

2014-07-30 Thread Andrew Dixie
Hi David, On Thu, Jul 31, 2014 at 2:22 PM, David Edelsohn wrote: > As the comment in the code states DWARF2 unwind info was placed in the > data section to prevent the AIX linker from garbage collecting it. > How are you avoiding that problem? That comment is very old. I'm not sure what the ori

Re: Move unwind info to read-only section on AIX

2014-07-30 Thread David Edelsohn
On Tue, Jul 29, 2014 at 5:33 PM, Andrew Dixie wrote: > Hi, > > The following patch moves dwarf unwind information from the data > section to the read-only/text section on AIX. This means the memory > for the unwind information can be shared across multiple processes. > > The frame tables are stil

Re: [PATCH, rs6000] Use new __builtin_pack_longdouble within libgcc's ibm-ldouble.c

2014-07-30 Thread David Edelsohn
On Tue, Jul 29, 2014 at 10:56 AM, Peter Bergner wrote: > ..after cleaning up the conflicting long double builtins and fixing a > few bugs in the test cases, I'd like to resubmit the following: > > Currently, the IBM long double routines in libgcc use a union to construct > a long double from two d

Re: [PATCH] gcc/gcc.c: XNEWVEC enough space for 'saved_suffix' using

2014-07-30 Thread Chen Gang
On 07/31/2014 06:29 AM, Joseph S. Myers wrote: > On Thu, 31 Jul 2014, Chen Gang wrote: > >> On 07/31/2014 06:12 AM, Joseph S. Myers wrote: >>> On Thu, 24 Jul 2014, Chen Gang wrote: >>> strlen() will get string length excluding '\0', but strcpy() will append '\0' in the end, so need XNE

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-07-30 Thread Joseph S. Myers
On Thu, 3 Jul 2014, Adhemerval Zanella wrote: > + /* Generates the equivalent of feclearexcept (FE_ALL_EXCEPT): > + > + double fenv_clear = __builtin_mffs (); > + *(uint64_t)&fenv_clear &= 0xLL; > + __builtin_mtfsf (0xff, fenv_clear); */ > + > + /* Mask to clear ever

Re: [PATCH] gcc/gcc.c: XNEWVEC enough space for 'saved_suffix' using

2014-07-30 Thread Joseph S. Myers
On Thu, 31 Jul 2014, Chen Gang wrote: > On 07/31/2014 06:12 AM, Joseph S. Myers wrote: > > On Thu, 24 Jul 2014, Chen Gang wrote: > > > >> strlen() will get string length excluding '\0', but strcpy() will append > >> '\0' in the end, so need XNEWVEC additional byte, or cause memory over > >> flow.

Re: [PATCH] gcc/gcc.c: XNEWVEC enough space for 'saved_suffix' using

2014-07-30 Thread Chen Gang
On 07/31/2014 06:12 AM, Joseph S. Myers wrote: > On Thu, 24 Jul 2014, Chen Gang wrote: > >> strlen() will get string length excluding '\0', but strcpy() will append >> '\0' in the end, so need XNEWVEC additional byte, or cause memory over >> flow. > > OK assuming it passed regression testing (wit

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Chen Gang
On 07/30/2014 11:32 PM, Andrew Haley wrote: > On 07/30/2014 04:01 PM, Chen Gang wrote: >> I shall stop making this kind of patch, next. The reason is that I worry >> about what I have done have negative effect to others. And next, I shall >> try to send another kinds of patches for gcc when I have

Re: [PATCH] gcc/gcc.c: XNEWVEC enough space for 'saved_suffix' using

2014-07-30 Thread Joseph S. Myers
On Thu, 24 Jul 2014, Chen Gang wrote: > strlen() will get string length excluding '\0', but strcpy() will append > '\0' in the end, so need XNEWVEC additional byte, or cause memory over > flow. OK assuming it passed regression testing (with ChangeLog entry as usual, and you need to say what plat

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Chen Gang
On 07/30/2014 11:24 PM, Tom Tromey wrote: >> "Chen" == Chen Gang writes: > > Chen> I shall stop making this kind of patch, next. The reason is that I worry > Chen> about what I have done have negative effect to others. And next, I shall > Chen> try to send another kinds of patches for gcc whe

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-07-30 Thread Joseph S. Myers
On Mon, 7 Jul 2014, Sylvestre Ledru wrote: > Hello, > > On 17/06/2014 19:41, Joseph S. Myers wrote: > > On Tue, 17 Jun 2014, Sylvestre Ledru wrote: > > > >> OK. I will do that. > >> We should test the following: > >> * default => run just -Wreturn-type > >> * -Wreturn-type => Run both > >> * -Wr

Re: [PATCH][Combine] missed one ASHIFTRT opt opportunity

2014-07-30 Thread Richard Sandiford
Jiong Wang writes: > + /* If we have > + > +(ior (lshiftrt A imm1) (and (ashiftrt (A imm2)) mask)) > + > + where imm1 = imm2 + 1 > +mask = ((1 << imm1) - 1) << (mode_size (A) - imm1) > + > + then we may simplify this into > + > +(ashiftrt A imm1). > + > +

Re: [patch] libstdc++/29988 Rb_Tree reuse allocated nodes

2014-07-30 Thread François Dumont
Hi Now that patch on testsuite allocator is in I would like to reactivate this one. Here it is again. See previous answer below regarding modification of _M_begin/_M_cbegin. 2014-07-30 François Dumont PR libstdc++/29988 * include/bits/stl_tree.h (_Rb_tree_reu

Re: [PATCH][AArch64][tests]Skip graphite tests that don't fit -mcmodel=tiny

2014-07-30 Thread Mike Stump
On Jul 22, 2014, at 12:14 PM, Mike Stump wrote: > On Jul 22, 2014, at 4:01 AM, Kyrill Tkachov wrote: >> These tests use very large arrays as part of their loop interchange testing >> so they don't fit into the 1MiB binary size limit imposed by -mcmodel=tiny. >> This causes errors at link-time.

Re: Patch for constexpr variable templates

2014-07-30 Thread Braden Obrzut
On 07/30/2014 04:44 PM, Jason Merrill wrote: Why not do this in cp_parser_id_expression? I did mention this in the original mail, is this definitely the way it should be done? Andrew pointed this out to me before sending in the patch, my initial investigation into doing so seemed to show it w

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Jason Merrill
I think this should fix it. Applying to trunk. commit 939c2c7101765c2ac83c85871fa38cc2278a2e18 Author: Jason Merrill Date: Wed Jul 30 17:19:23 2014 -0400 PR lto/53808 PR c++/61659 * pt.c (push_template_decl_real): Don't set DECL_COMDAT on friends. diff --git a/gcc/cp/pt.c b/g

RFA: Remove insn_contains_asm from ira.c

2014-07-30 Thread Richard Sandiford
Just a small clean-up in preparation for the FOR_EACH_SUBRTX patches. insn_contains_asm can be tested more directly using extract_asm_operands, which doesn't involve any subcalls and should therefore be more efficient than calling for_each_rtx. Tested on x86_64-linux-gnu. OK to install? Thanks,

Re: [PATH] Intel offload library

2014-07-30 Thread Joseph S. Myers
On Wed, 2 Jul 2014, Andrey Turetskiy wrote: > > * Don't duplicate the logic for what's a hosted POSIX system; refactor it > > to a common fragment in config/ (I guess it needs to be a shell script > > fragment there rather than an actual autoconf macro, since you're using > > that logic in configu

Re: Patch for constexpr variable templates

2014-07-30 Thread Jason Merrill
On 07/29/2014 07:56 AM, Braden Obrzut wrote: @@ -6289,6 +6289,14 @@ cp_parser_postfix_expression (cp_parser *parser, bool address_p, bool cast_p, break; default: + /* Convert variable template into VAR_DECL. */ + if (TREE_CODE (postfix_expression) == TEMPLATE_I

Re: [PATCH 7/7] Convert tree-ssa-tail-merge to inchash

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen gcc/: 2014-07-29 Andi Kleen * tree-ssa-tail-merge.c (same_succ_hash): Convert to inchash. This is fine once the basic inchash stuff is approved. jeff

Re: [PATCH 5/7] Convert tree-ssa-dom to inchash

2014-07-30 Thread Jeff Law
On 07/30/14 08:23, Andi Kleen wrote: From: Andi Kleen gcc/: 2014-07-29 Andi Kleen * tree-ssa-dom.c (iterative_hash_exprs_commutative): Rename to inchash:add_expr_commutative. Convert to inchash. (iterative_hash_hashable_expr): Rename to inchash:add_hashable_

Re: [C++ Patch] PR 57397

2014-07-30 Thread Jason Merrill
On 07/30/2014 03:00 PM, Paolo Carlini wrote: + /* Fail if parms are left and they don't have default values and + they aren't all deduced as empty packs, eg (c++/57397): + + template + void foo(T1, Tn..., Tm...); + + int main() + { + foo(1); + } */ Let's drop the

Re: [PATCH, DOC]: New value 'default' for --enable-languages

2014-07-30 Thread Martin Liška
On 07/30/2014 06:38 PM, Mike Stump wrote: > On Jul 30, 2014, at 6:20 AM, Richard Biener > wrote: >> On Wed, Jul 30, 2014 at 3:19 PM, Richard Biener >> wrote: >>> On Wed, Jul 30, 2014 at 1:37 PM, Martin Liška wrote: Hello, as discussed in previous thread (https://gcc.gnu.org/ml

Re: [C++ Patch] PR 57397

2014-07-30 Thread Paolo Carlini
... I'm finishing testing the below. Thanks! Paolo. // Index: cp/pt.c === --- cp/pt.c (revision 213287) +++ cp/pt.c (working copy) @@ -5517,13 +5517,21 @@ unify_method_type_error (bool explain_p, tree arg

Re: [PATCH] Further cleanup loop-distribution

2014-07-30 Thread Mike Stump
On Jul 30, 2014, at 12:59 AM, Richard Biener wrote: >> So I do compiler testing on my toaster oven by doing native builds of gcc >> running on a binutils simulator and it doesn’t have a working popen (it’s in >> my newlib, but it wants vfork, which I don’t have). I do have fork and >> system h

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Jason Merrill
On 07/30/2014 02:05 PM, Markus Trippelsdorf wrote: It breaks Firefox build: /sigh. I haven't looked deeper yet. Let me know what you find. Thanks, Jason

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Markus Trippelsdorf
On 2014.07.30 at 13:26 -0400, Jason Merrill wrote: > Since can_refer_decl_in_current_unit_p doesn't allow references to > DECL_COMDAT entities that aren't defined in the current unit, by setting > that flag we can avoid problems with devirtualization introducing > references to vague linkage fun

mark_virtual_overrides patch

2014-07-30 Thread Jason Merrill
Here it is again, without the DECL_COMDAT pieces; now that patch is in, this becomes just an optimization to improve devirtualization. As you said before, because of caching we might miss new overrides that are introduced as a result of instantiating/synthesizing one of the overrides on the fi

[GSoC][match-and-simplify] split match.pd

2014-07-30 Thread Prathamesh Kulkarni
I have split match.pd in this patch. Not sure if I have written the ChangeLog correctly though... * match-bitwise.pd: New file. * match-plusminus.pd: Likewise. * match-constant-folding.pd: Likewise. * match-builtin.pd: Likewise. * match-rotate.pd): New file. Adjust to u

Re: [PATCH, DOC]: New value 'default' for --enable-languages

2014-07-30 Thread Mike Stump
On Jul 30, 2014, at 6:20 AM, Richard Biener wrote: > On Wed, Jul 30, 2014 at 3:19 PM, Richard Biener > wrote: >> On Wed, Jul 30, 2014 at 1:37 PM, Martin Liška wrote: >>> Hello, >>> as discussed in previous thread >>> (https://gcc.gnu.org/ml/gcc-patches/2014-07/msg02010.html), I would like to >

Re: [C++ Patch] PR 57397

2014-07-30 Thread Paolo Carlini
Hi, On 07/30/2014 07:19 PM, Jason Merrill wrote: On 07/30/2014 11:09 AM, Paolo Carlini wrote: + /* Eg (c++/57397): + + template + void foo(T1, Tn..., Tm...); + + int main() + { +foo(1, 2); + } */ I think we should accept this: T1 is int, Tn is {}, Tm is

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Jason Merrill
On 07/30/2014 11:25 AM, Jonathan Wakely wrote: Jason, any objection to putting this on the 4.8 and 4.9 branches too? That should be OK. Jason

C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Jason Merrill
Since can_refer_decl_in_current_unit_p doesn't allow references to DECL_COMDAT entities that aren't defined in the current unit, by setting that flag we can avoid problems with devirtualization introducing references to vague linkage functions that haven't been synthesized/instantiated because

Re: [C++ Patch] PR 57397

2014-07-30 Thread Jason Merrill
On 07/30/2014 11:09 AM, Paolo Carlini wrote: + /* Eg (c++/57397): + + template + void foo(T1, Tn..., Tm...); + + int main() + { +foo(1, 2); + } */ I think we should accept this: T1 is int, Tn is {}, Tm is {int}. + template + void foo(T1, Tn..., T

[PATCH, trans-mem, PR 61393] Copy tm_clone field of cgraph_node when cloning the node

2014-07-30 Thread Martin Jambor
Hi, IPA-CP can wreck havoc to transactional memory support as described in the summary of the PR in bugzilla. It seems the cause is that IPA-CP clones of nodes created by trans-mem do not have their tm_clone flag set. For release branches we have decided to simply disable IPA-CP of trans-mem clo

[commit, s390] Fix TPF unwinder

2014-07-30 Thread Ulrich Weigand
Hello, I've checked in a fix provided by Jim Johnston on the TPF team to fix a case where the special TPF unwinder didn't work correctly. Tested on TPF by Jim, committed to mainline. Bye, Ulrich ChangeLog: gcc/ 2014-07-30 Ulrich Weigand * config/s390/s390.c (s390_emit_tpf_eh_retur

Re: [PATCH 0/5] let gdb reuse gcc'c C compiler

2014-07-30 Thread Tom Tromey
Tom> This patch series is half of a project to let gdb reuse gcc (which Tom> half depends on which list you are seeing this on), so that users can Tom> compile small snippets of code and evaluate them in the current Tom> context of the inferior. [ ... later ... ] Tom> I believe we've addressed all

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Zifei Tong
On Wed, Jul 30, 2014 at 11:25 PM, Jonathan Wakely wrote: > On 30/07/14 22:42 +0800, Zifei Tong wrote: >> >> Hi, >> >> I found an issue that the __cxa_thread_atexit_impl() function never called >> by >> __cxa_thread_atexit() even with newest glibc which have >> __cxa_thread_atexit_impl >> implement

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Andrew Haley
On 07/30/2014 04:01 PM, Chen Gang wrote: > I shall stop making this kind of patch, next. The reason is that I worry > about what I have done have negative effect to others. And next, I shall > try to send another kinds of patches for gcc when I have time. > > Many persons or companies use open sou

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Jonathan Wakely
On 30/07/14 22:42 +0800, Zifei Tong wrote: Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc which have __cxa_thread_atexit_impl implemented. It turns out that the code tried to use macro HAVE___CXA_THREAD_ATEXIT_IMPL,

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Tom Tromey
> "Chen" == Chen Gang writes: Chen> I shall stop making this kind of patch, next. The reason is that I worry Chen> about what I have done have negative effect to others. And next, I shall Chen> try to send another kinds of patches for gcc when I have time. It's customary to wait a while befo

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Tom Tromey
> "Chen" == Chen Gang writes: Chen> 'errbuf' assumes itself will be zero terminated, and it also assumes Chen> cpnative_getErrorString() may get larger length string than 'errbuf'. Chen> So after strncpy(), 'errbuf' may not be zero terminated. Chen> strncpy() is sure of zero pad, but not be

RE: [PATCH] PR61868

2014-07-30 Thread Bingfeng Mei
Yes, that fix is better. Here are updated patches. LTO-bootstrapped and tested. OK? Bingfeng Index: ChangeLog === --- ChangeLog (revision 213152) +++ ChangeLog (working copy) @@ -1,3 +1,10 @@ +2014-07-29 Bingfeng Mei + +

[Ada] Display correctly directory path names

2014-07-30 Thread Arnaud Charlet
When the Project Manager is indicating that a directory cannot be created and the full path name of the directory contains chacters that are teated specially to modify the error message, the full path name of the directory is not displayed correctly. This patch corrects the problem. Tested on x86_

Re: [C++ Patch] PR 57397

2014-07-30 Thread Paolo Carlini
Hi again, the below tries to also fix the second problem I presented in this thread. Passes testing on x86_64-linux. How does it look? Thanks, Paolo. /// Index: cp/pt.c === --- cp/pt.c (revision 213287) +++ cp

[Ada] Notes from subunits incorrectly recorded in ALI files

2014-07-30 Thread Arnaud Charlet
This change fixes the way annotations coming from subunits are recorded in ALI files, so that their original source location (including the source file name of the subunit) is correctly preserved. The following commands must produce the shown output: $ gcc -c annot_separate.adb $ sed -n -e '/^U/s

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-07-30 Thread Chen Gang
Hello All: I shall stop making this kind of patch, next. The reason is that I worry about what I have done have negative effect to others. And next, I shall try to send another kinds of patches for gcc when I have time. Many persons or companies use open source who never give thanks or contributi

Re: [PATCH] PR61868

2014-07-30 Thread Andi Kleen
On Wed, Jul 30, 2014 at 09:46:48AM +0200, Richard Biener wrote: > On Tue, Jul 29, 2014 at 3:01 PM, Bingfeng Mei wrote: > > Hi, > > Please find the patches for pr61868. The problem is that even with > > -frandom-seed gcc always uses 0 instead of specified number/string for > > places such as lto

[PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Zifei Tong
Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc which have __cxa_thread_atexit_impl implemented. It turns out that the code tried to use macro HAVE___CXA_THREAD_ATEXIT_IMPL, but not _GLIBCXX_HAVE___CXA_THREAD_ATEXIT_IM

[PATCH][PING] Add support for KernelAddressSanitizer

2014-07-30 Thread Yury Gribov
On 07/18/2014 05:38 PM, Jakub Jelinek wrote: Do you error out on -fsanitize=thread -fsanitize=kernel-address ? Perhaps -fsanitize=kernel-address -fsanitize=address should be invalid too? Yes, all these combinations are invalid. But you don't error out on that. Ok, fixed. Then in sanitize_

[Ada] Internal cleanups in handling of subtype bounds

2014-07-30 Thread Arnaud Charlet
This change causes subtype bounds to be captured in special constant variables xxxL and xxxH, avoiding troublesome cases where the call to Force_Evaluation generated serialized temporaries that got referenced publicly. It also means that First/Last can be expanded out in more cases. No functional

[Ada] Internal cleanups in Cstand

2014-07-30 Thread Arnaud Charlet
The name of raise type was "any type", it is now "raise type" We now the name before setting other fields of standard entities, which avoids debugger blowups printing the entity when setting one of these fields. These are minor internal imrpovements for front-end debugging, no external effect, no

[PATCH 7/7] Convert tree-ssa-tail-merge to inchash

2014-07-30 Thread Andi Kleen
From: Andi Kleen gcc/: 2014-07-29 Andi Kleen * tree-ssa-tail-merge.c (same_succ_hash): Convert to inchash. --- gcc/tree-ssa-tail-merge.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/gcc/tree-ssa-tail-merge.c b/gcc/tree-ssa-tail-merge.c

[PATCH 3/7] Convert asan.c to inchash

2014-07-30 Thread Andi Kleen
From: Andi Kleen gcc/: 2014-07-30 Andi Kleen * asan.c (asan_mem_ref_hasher::hash): Convert to inchash. --- gcc/asan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/asan.c b/gcc/asan.c index 475dd82..4f882b5 100644 --- a/gcc/asan.c +++ b/gcc/asan.c @@

[PATCH 6/7] Convert tree-ssa-sccvn to inchash

2014-07-30 Thread Andi Kleen
From: Andi Kleen gcc/: 2014-07-29 Andi Kleen * tree-ssa-sccvn.c (vn_reference_op_compute_hash): Convert to inchash. (vn_reference_compute_hash): Dito. (vn_nary_op_compute_hash): Dito. (vn_phi_compute_hash): Dito. * tree-ssa-sccvn.h (vn_hash_con

[PATCH 5/7] Convert tree-ssa-dom to inchash

2014-07-30 Thread Andi Kleen
From: Andi Kleen gcc/: 2014-07-29 Andi Kleen * tree-ssa-dom.c (iterative_hash_exprs_commutative): Rename to inchash:add_expr_commutative. Convert to inchash. (iterative_hash_hashable_expr): Rename to inchash:add_hashable_expr. Convert to inchash. (avai

[PATCH 1/7] Change inchash to name space.

2014-07-30 Thread Andi Kleen
From: Andi Kleen Change class inchash to move into a inchash namespace as requested. The class is now inchash::hash Rename iterative_hstate_expr to inchash::add_expr ... and convert existing users. It wasn't possible to use hash::, because that lead to name space conflicts with cp and objc. So

[PATCH 2/7] RTL & dwarf2out changes

2014-07-30 Thread Andi Kleen
From: Andi Kleen Convert dwarf2out and rtl.c to the new inchash interface. I moved the rtl hash code to another file to avoid having to link all the hash code into the generator functions. v2: Removed ??? comment. gcc/: 2014-07-29 Andi Kleen * Makefile.in (OBJS): Add rtlhash.o

[PATCH 4/7] Convert ipa-devirt to inchash

2014-07-30 Thread Andi Kleen
From: Andi Kleen gcc/: 2014-07-30 Andi Kleen * ipa-devirt.c (polymorphic_call_target_hasher::hash): Convert to inchash. --- gcc/ipa-devirt.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c

Updated inchash patchkit

2014-07-30 Thread Andi Kleen
This version adds the new namespace as requested by Ritchie. I couldn't use hash:: due to name space conflicts, but (nearly) everything is now inchash::... This needed some changes in the existing files. I did all the renamings atomically in one patch to avoid non buildable commits. Also I remov

RE: [PATCH, Fortran] PR61234: -Wuse-no-only

2014-07-30 Thread VandeVondele Joost
>> This explicitly tests that no bogus error message is issued >> for a use statement that has an only qualifier ? > >I don't see the need for '! { dg-bogus "has no ONLY qualifier" }'. >AFAICT there is no warning emitted for this line (unless you add -Wall) >and if some day it happens that an error

[Ada] Ability to compute range of floating-point expression for analyzers

2014-07-30 Thread Arnaud Charlet
Analyzers based on the frontend can benefit from knowing the range of possible values of a floating-point expression. For example, it might be useful to decide that a range check or an overflow check cannot fail. Implement such a procedure Determine_Range_R in checks.adb, similar to the existing De

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-30 Thread Tom Tromey
>> I don't think this comment is applicable. >> The libstdc++ pretty-printers use gdb.Value.lazy_string, not the >> built-in Python types. Samuel> Hmm, doesn't that just make it a timebomb -- a value that will Samuel> explode if, at some point in the future, someone tries to treat Samuel> it as a

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

2014-07-30 Thread VandeVondele Joost
Dominque, after Janne's OK, and FX judgement, I wonder if you have reached a conclusion. If so, the fsf assignment is now complete, and the patch could be applied. Joost > Ok for trunk. Thanks! Please don't rush! The behavior of -fno-signed-zeros -fno-trapping-math implying associative math h

[Ada] Reimplement Ada.Task_Attributes

2014-07-30 Thread Arnaud Charlet
This change reimplements from scratch the Ada.Task_Attributes package, taking advantage of RM permission C.7.2(28), and putting a maximum number of task attributes supported to simplify the implementation and make it more efficient. In addition, a special ("Fast_Path") case is made for task attribu

Re: [PATCH, DOC]: New value 'default' for --enable-languages

2014-07-30 Thread Richard Biener
On Wed, Jul 30, 2014 at 3:19 PM, Richard Biener wrote: > On Wed, Jul 30, 2014 at 1:37 PM, Martin Liška wrote: >> Hello, >>as discussed in previous thread >> (https://gcc.gnu.org/ml/gcc-patches/2014-07/msg02010.html), I would like to >> add more intuitive behavior for --enable-languages config

Re: [PATCH, DOC]: New value 'default' for --enable-languages

2014-07-30 Thread Richard Biener
On Wed, Jul 30, 2014 at 1:37 PM, Martin Liška wrote: > Hello, >as discussed in previous thread > (https://gcc.gnu.org/ml/gcc-patches/2014-07/msg02010.html), I would like to > add more intuitive behavior for --enable-languages configure option. It works for me, but as I'm currently always test

Re: [PATCH] PR61868

2014-07-30 Thread Richard Biener
On Wed, Jul 30, 2014 at 2:48 PM, Bingfeng Mei wrote: > On the second thought, maybe the change should be made in set_random_seed. > Otherwise, init_random_seed is invoked every time get_random_seed get called > (not sure how often). What do you think? > > const char * > set_random_seed (const ch

[PINGv2][PATCH] Fix for PR 61561

2014-07-30 Thread Marat Zakirov
On 07/23/2014 05:33 PM, Marat Zakirov wrote: Hi all! This is a friendly reminder message. On 07/17/2014 03:22 PM, Marat Zakirov wrote: On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: On 16/07/14 10:22, Marat Zakirov wrote: Christophe, Please look at a new patch. Draft tests are OK. I'll as

RE: [PATCH] PR61868

2014-07-30 Thread Bingfeng Mei
On the second thought, maybe the change should be made in set_random_seed. Otherwise, init_random_seed is invoked every time get_random_seed get called (not sure how often). What do you think? const char * set_random_seed (const char *val) { const char *old = flag_random_seed; flag_random_s

[Ada] Fix race conditions related to independent tasks

2014-07-30 Thread Arnaud Charlet
This patch fixes several race conditions involving independent tasks. The main thing is to make sure the activating task waits for them to become independent. Otherwise (for example) the environment task can race ahead to Finalize_Global_Tasks and find things in an inconsistent state, causing progr

[Ada] Use Is_Inlined flag to mark fully inlined subp in GNATprove mode

2014-07-30 Thread Arnaud Charlet
In GNATprove mode, some subprograms may be partially inlined, due to recursion, or because some calls are in a potentially unevaluated context, which would lead to code that GNATprove would not be able to handle. In those cases, the body-to-inline has been built, and potentially already be inlined.

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Tobias Grosser
On 30/07/2014 14:32, Roman Gareev wrote: OK. I proposed a slightly longer description. With the updated description, you can commit this patch. I've fixed the fixme. FIXME: We should replace blind conversation of id's type with derivation of the optimal type when we get the corresponding isl s

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Roman Gareev
> OK. I proposed a slightly longer description. With the updated description, > you can commit this patch. I've fixed the fixme. FIXME: We should replace blind conversation of id's type with derivation of the optimal type when we get the corresponding isl support. Blindly converting type sizes ma

Re: [PATCH] LTO streamer reorg - try to reduce WPA memory use

2014-07-30 Thread Martin Liška
On 07/30/2014 12:37 PM, Richard Biener wrote: On Wed, Jul 30, 2014 at 1:14 PM, Martin Liška wrote: On 07/30/2014 11:41 AM, Richard Biener wrote: On Wed, 30 Jul 2014, Richard Biener wrote: On Wed, Jul 30, 2014 at 7:51 AM, Markus Trippelsdorf wrote: On 2014.07.29 at 15:10 +0200, Richard Bie

Re: Warn when returning the address of a temporary (middle-end) v2

2014-07-30 Thread Marc Glisse
On Tue, 29 Jul 2014, David Malcolm wrote: On Tue, 2014-07-29 at 19:36 +0200, Marc Glisse wrote: On Sun, 27 Jul 2014, Richard Sandiford wrote: Marc Glisse writes: Hello, I followed the advice in this discussion: https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00269.html and here is a new pat

Re: [c++-concepts] Allow function parameters to be referenced in trailing requires clauses

2014-07-30 Thread Andrew Sutton
Applied an updated version of this patch. 2014-7-30 Braden Obrzut * gcc/cp/parser.c (cp_parser_trailing_requirements): Handle requires keyword manually so that we can push function parameters back into scope. * gcc/cp/decl.c (push_function_parms): New. Recovers a

Re: [PATCH] LTO streamer reorg - try to reduce WPA memory use

2014-07-30 Thread Richard Biener
On Wed, Jul 30, 2014 at 1:14 PM, Martin Liška wrote: > > On 07/30/2014 11:41 AM, Richard Biener wrote: >> >> On Wed, 30 Jul 2014, Richard Biener wrote: >> >>> On Wed, Jul 30, 2014 at 7:51 AM, Markus Trippelsdorf >>> wrote: On 2014.07.29 at 15:10 +0200, Richard Biener wrote: > >

[PATCH, DOC]: New value 'default' for --enable-languages

2014-07-30 Thread Martin Liška
Hello, as discussed in previous thread (https://gcc.gnu.org/ml/gcc-patches/2014-07/msg02010.html), I would like to add more intuitive behavior for --enable-languages configure option. Thank you, Martin 2014-07-30 Martin Liska * configure: New value for configure option --

Re: [PATCH] LTO streamer reorg - try to reduce WPA memory use

2014-07-30 Thread Martin Liška
On 07/30/2014 11:41 AM, Richard Biener wrote: On Wed, 30 Jul 2014, Richard Biener wrote: On Wed, Jul 30, 2014 at 7:51 AM, Markus Trippelsdorf wrote: On 2014.07.29 at 15:10 +0200, Richard Biener wrote: On Tue, 29 Jul 2014, Richard Biener wrote: This re-organizes the LTO streamer to do comp

  1   2   >