Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-03 Thread Mark Wielaard
On Fri, 2014-10-03 at 11:41 -0700, Cary Coutant wrote: O. Then I was indeed wrong and defaulted does not impact ABI at all. At least that is one worry less for the abi checkers :) As Siva mentioned, it does in fact impact the ABI. A class with a non-trivial destructor is not a POD, and

RE: [jit] Fix memory leak within diagnostic.c

2014-10-03 Thread Manuel López-Ibáñez
gcc/ChangeLog.jit: * diagnostic.c (diagnostic_finish): Free the memory for context-classify_diagnostic and context-printer, running the destructor for the latter. It would be easier to review and merge your branch if you directly propose these self-contained and generally useful

[PATCH] Fix build on darwin (was Re: [PATCH] gcc.c: Split up the driver's main into smaller functions)

2014-10-03 Thread David Malcolm
On Fri, 2014-10-03 at 11:02 -0400, David Malcolm wrote: The main function for the driver in gcc.c has grown from ~200 lines in its original form (way back in r262) to ~1000 lines today, with a dozen locals (if we include the params). The following patch splits it up into 15 smaller

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-03 Thread Jason Merrill
On 10/03/2014 02:41 PM, Cary Coutant wrote: O. Then I was indeed wrong and defaulted does not impact ABI at all. At least that is one worry less for the abi checkers :) As Siva mentioned, it does in fact impact the ABI. A class with a non-trivial destructor is not a POD, and affects the

Update construction tracking in ipa-prop for new code

2014-10-03 Thread Jan Hubicka
Hi, this patch adds basic tracking of what types may be in construction because the call appears in a polymorphic cdtor. Bootstrapped/regtested x86_64-linux, comitted. Honza * cgraph.h (struct indirect_call_info): Add IN_POLYMORPHIC_CDTOR * lto-cgraph.c (lto_output_edge,

Re: [PATCH, Pointer Bounds Checker 14/x] Pointer Bounds Checker passes

2014-10-03 Thread Jeff Law
On 10/03/14 02:50, Ilya Enkovich wrote: Attached is an updated version of the patch. It has disabled instrumenttation for builtin calls. Thanks, Ilya -- gcc/ 2014-10-02 Ilya Enkovichilya.enkov...@intel.com * tree-chkp.c: New. * tree-chkp.h: New. * rtl-chkp.c: New.

Re: [PATCH, Pointer Bounds Checker 19/x] Support bounds in expand

2014-10-03 Thread Jeff Law
On 10/02/14 08:03, Ilya Enkovich wrote: Here is an updated version. Thanks, Ilya -- 2014-10-02 Ilya Enkovich ilya.enkov...@intel.com * calls.c: Include tree-chkp.h, rtl-chkp.h, bitmap.h. (arg_data): Add fields special_slot, pointer_arg and pointer_offset.

Re: [C PATCH] Don't warn about gnu_inline functions without definitions (PR c/63453)

2014-10-03 Thread Joseph S. Myers
On Fri, 3 Oct 2014, Marek Polacek wrote: While looking into something else I noticed that we produce C99ish inline function declared but never defined warning even for functions marked as gnu_inline, if not in GNU89 or if -fgnu89-inline is not in effect, because the warning was guarded only

Re: [PATCH] Fix build on darwin (was Re: [PATCH] gcc.c: Split up the driver's main into smaller functions)

2014-10-03 Thread Iain Sandoe
Hi David, On 3 Oct 2014, at 20:15, David Malcolm wrote: On Fri, 2014-10-03 at 11:02 -0400, David Malcolm wrote: The main function for the driver in gcc.c has grown from ~200 lines in its original form (way back in r262) to ~1000 lines today, with a dozen locals (if we include the params).

Re: [PATCH] Fix build on darwin (was Re: [PATCH] gcc.c: Split up the driver's main into smaller functions)

2014-10-03 Thread Jeff Law
On 10/03/14 13:15, David Malcolm wrote: On Fri, 2014-10-03 at 11:02 -0400, David Malcolm wrote: The main function for the driver in gcc.c has grown from ~200 lines in its original form (way back in r262) to ~1000 lines today, with a dozen locals (if we include the params). The following patch

Re: [PATCH] middle-end: use dump_location instead of copy-pasted code

2014-10-03 Thread Jeff Law
On 10/03/14 12:39, Manuel López-Ibáñez wrote: There are some inconsistencies in the middle-end about how to dump a location. The following patch makes all places (that I found) use dump_location, and makes that function print also the column number. While searching for possible callers, I

Re: __intN patch 3/5: main __int128 - __intN conversion.

2014-10-03 Thread DJ Delorie
Note that there is a separate __int128_t type that isn't part of the standard extension. Maybe it's there for that type? Otherwise, I don't see what moving the test would accomplish. If long is never 128 bits, it doesn't matter if the int128 test is before or after it, and the other intN are

Re: [PATCH] Power/GCC: Fix e500 vs non-e500 register save slot issue

2014-10-03 Thread Maciej W. Rozycki
On Wed, 24 Sep 2014, Joseph S. Myers wrote: * config/rs6000/e500.h (HARD_REGNO_CALLER_SAVE_MODE): Remove macro. * config/rs6000/rs6000.h (HARD_REGNO_CALLER_SAVE_MODE): Handle TARGET_E500_DOUBLE case here. This patch is okay. The repeated testing

Re: [PATCH 1/2] Error out for Cilk_spawn or array expression in forbidden places

2014-10-03 Thread Bernhard Reutner-Fischer
On 3 October 2014 16:08:57 CEST, Andi Kleen a...@firstfloor.org wrote: From: Andi Kleen a...@linux.intel.com (check_no_cilk): Dito. I'm just curious, but isn't the english term ditto (im österreichischen ugs. detto, think latin idem) ?

[PATCH Fortran] move more diagnostics to the common machinery

2014-10-03 Thread Manuel López-Ibáñez
The following patch adds two new functions. One of them is an overload of gfc_warning_cmdline() that takes an option. Thus now we get: f951: Warning: Nonexistent include directory 'C:\msys\1.0.10\home\FX\ibin\i586-pc-mingw32\libgfortran/../../../trunk/libgfortran/generated'

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-03 Thread Siva Chandra
On Fri, Oct 3, 2014 at 12:00 PM, Mark Wielaard m...@redhat.com wrote: Thanks for that reference. I was just stepping through gdb's gdbarch_return_in_first_hidden_param_p to understand why Siva's example did indeed seem to go wrong under GDB. That code is a little hairy with all the arch

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-03 Thread Siva Chandra
On Fri, Oct 3, 2014 at 12:45 PM, Jason Merrill ja...@redhat.com wrote: On 10/03/2014 02:41 PM, Cary Coutant wrote: O. Then I was indeed wrong and defaulted does not impact ABI at all. At least that is one worry less for the abi checkers :) As Siva mentioned, it does in fact impact the ABI.

Add testcases for new devirtualization code paths; fix merging of speculative devirt

2014-10-03 Thread Jan Hubicka
Hi, this patch add basic testcaes for new devirtualization features (more to come) and also fixes bug I introduced while refactoring the speculative context merging code - that most likely explains why I observed number of speculative devirt to drop considerably after finishing the patch. Jason,

Re: [C++] Handle || ! for simd vectors

2014-10-03 Thread Marc Glisse
On Thu, 2 Oct 2014, Jason Merrill wrote: OK. Thanks. While committing, I noticed that I restricted ! to integer vectors, whereas it seems to work just fine with scalar floats, so it would make sense to extend it to float vectors. Tested on x86_64-linux-gnu. 2014-10-04 Marc Glisse

Re: [gofrontend-dev] [PATCH 4/9] Gccgo port to s390[x] -- part I

2014-10-03 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:53 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This patch fixes the compiler flags in libgo/mksysinfo.sh. In one place, some compiler flags were missing that are consistently used elswhere, resulting in an error message. ChangeLog 2014-09-05 Dominik Vogt

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-03 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:56 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This optional cleanup patch fixes some sloppy programming in the x86 libgo/go/debug/elf library that had given me a very hard time to debug and fix when porting the code to s390[x]. See commit comment for details.

Re: [RFC] costs and it's use in assign_reg_parm

2014-10-03 Thread Segher Boessenkool
On Fri, Oct 03, 2014 at 12:36:37PM -0600, Jeff Law wrote: rtx_cost and its friends have always been a problem and it's always felt like a design problem. The true cost of something is so context dependent I'm not really sure how to build an API to do this in a sane way. In many places it

<    1   2