[PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-19 Thread Maxim Kuvyrkov
Hi, This patch improves register pressure scheduling (both SCHED_PRESSURE_WEIGHTED and SCHED_PRESSURE_MODEL) to better estimate number of available registers. At the moment the scheduler does not account for spills in the prologues and restores in the epilogue, which occur from use of call-used

Re: ping x 7: [PATCH] [libgomp] make it possible to use OMP on both sides of a fork

2014-10-19 Thread Nathaniel Smith
Hi Jakub, Thanks for your feedback! See below. On Thu, Oct 16, 2014 at 4:52 PM, Jakub Jelinek wrote: > On Mon, Oct 13, 2014 at 10:16:19PM +0100, Nathaniel Smith wrote: >> Got total silence the last 4 times I posted this, and users have been >> bugging me about it offline, so trying again. >> >>

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-19 Thread Xinliang David Li
On Sat, Oct 18, 2014 at 4:19 PM, Xinliang David Li wrote: > On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: >>> The difference in instrumentation runtime is huge -- as topn profiler >>> is pretty expensive to run. >>> >>> With FDO, it is probably better to make early inlining more aggressive

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Xinliang David Li
No, Google branch is not yet synced to 4.9 head. David On Sun, Oct 19, 2014 at 1:11 PM, Jan Hubicka wrote: >> It was in upstream 4.9 branch, but got reverted in r215061 to fix >> PR/61214 and PR/62224. > > Was your tests done with this change or without? > > Honza

Re: [fortran,patch] Handle infinities and NaNs in intrinsics code generation

2014-10-19 Thread FX
> Looks good to me. Thanks for taking care of F2003's IEEE support. Committed as rev. 216443, thanks for the review. > PS: You might want to browse through the current (F2008 + corrigenda > + first F2015 additions) draft at > http://j3-fortran.org/doc/year/14/14-007r2.pdf > > See especially th

Re: [PATCH] Fix for PR63583

2014-10-19 Thread Jan Hubicka
> Hello. > > I added missing gimple_asm_string comparison for a function with an asm > statement. > Bootstrap and regression tests still running, ready for trunk after it > finishes? OK. (I remember pointing this out at review :)) Honza > > Thank you, > Martin > gcc/ChangeLog: > > 2014-10-1

[PATCH] Fix for PR63583

2014-10-19 Thread Martin Liška
Hello. I added missing gimple_asm_string comparison for a function with an asm statement. Bootstrap and regression tests still running, ready for trunk after it finishes? Thank you, Martin gcc/ChangeLog: 2014-10-19 Martin Liska * ipa-icf-gimple.c (func_checker::compare_gimple_asm):

Re: [AArch64] Add --enable-fix-cortex-a53-835769 configure-time option

2014-10-19 Thread Gerald Pfeifer
On Friday 2014-10-10 11:53, Kyrill Tkachov wrote: This adds a new configure-time option --enable-fix-cortex-a53-835769 that will enable the Cortex-A53 erratum fix by default so you don't have to specify -mfix-cortex-a53-835769 every time. Documentation in install.texi is added. Thank you. Can

Re: [wwwdocs] Add recent C++ changes to gcc-5/changes.html

2014-10-19 Thread Gerald Pfeifer
On Friday 2014-10-17 13:34, Jonathan Wakely wrote: Index: htdocs/gcc-5/changes.html === @@ -128,12 +164,13 @@ Class std::experimental::any; Function template std::experimental::apply; + Variable tem

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Jan Hubicka
> It was in upstream 4.9 branch, but got reverted in r215061 to fix > PR/61214 and PR/62224. Was your tests done with this change or without? Honza

[PATCH, committed] Set SECTION_EXCLUDE flag for LTO sections.

2014-10-19 Thread Ilya Verbin
Hello, This patch sets SECTION_EXCLUDE flag for LTO sections in lhd_begin_section and fixes the corresponding gcc_GAS_CHECK_FEATURE. Approved here: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01535.html Bootstrapped and regtested on i686-linux and x86_64-linux, committed to trunk. -- Ilya

[PATCH, rtl-optimization]: Remove const_alias_set

2014-10-19 Thread Uros Bizjak
Hello! The fix that fixed scheduler issues with AND addresses (the fix prevented early exit for MEM_READONLY_P addresses when AND alignment addresses were involved) caused some fall-out for libgo testsuite. These tests triggered an assert in mems_in_disjoint_alias_sets_p, which checks for zero ali

Re: [PATCH][3/n] Merge from match-and-simplify, first patterns and questions

2014-10-19 Thread Marc Glisse
Hello, looking though the patterns on the branch (not specifically the ones attached here), I am surprised to see so few calls to has_single_use. In RTL-land, we don't even valueize if there are several uses, so the question doesn't occur. In generic, we assume everything is single use (CSE c

Re: Is there an error in GCC Internals Manual, chapter 16.4?

2014-10-19 Thread Andreas Schwab
Panu-Kristian Poiksalo writes: > Chapter 16.4, "RTL Template" in GCC Internals Manual, found at > https://gcc.gnu.org/onlinedocs/gccint/RTL-Template.html#RTL-Template > has this to say about match_scratch: > > " > (match_scratch:m n constraint) > This expression is also a placeholder for oper

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Xinliang David Li
It was in upstream 4.9 branch, but got reverted in r215061 to fix PR/61214 and PR/62224. David On Sun, Oct 19, 2014 at 1:21 AM, Jan Hubicka wrote: >> Hi Honza, >> >> As David says, we will do some more experiments with the change you >> suggest and speculative devirtualization, but we needed to

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Jan Hubicka
> > In opts.c I have: > > case OPT_fprofile_use: > > if (!opts_set->x_flag_branch_probabilities) > > ... > > /* Indirect call profiling should do all useful transformations > > speculative devirtualization does. */ > > if (!opts_set->x_flag_devirtualize_speculatively

Re: [C PATCH] Another initialization fix (PR c/63567)

2014-10-19 Thread Joseph S. Myers
On Sun, 19 Oct 2014, Marek Polacek wrote: > It turned out that there is another spot where we need to allow > initializing objects with static storage duration with compound > literals even in C99 -- when the compound literal is inside the > initializer. Fixed in the same way as previously. > >

Re: [PATCH] Fix PR preprocessor/42014

2014-10-19 Thread Joseph S. Myers
On Sat, 18 Oct 2014, Krzesimir Nowak wrote: > + pp_verbatim (context->printer, > +"%s from %r%s:%d%R", prefix, "locus", > + diagnostic_report_from (context, map, "In file included"); We don't want to split up diagnostic text like that, because for translation it may be necess

Re: [PATCH doc] Explain options precedence and difference between -pedantic-errors and -Werror=pedantic

2014-10-19 Thread Joseph S. Myers
On Sat, 18 Oct 2014, Manuel López-Ibáñez wrote: > What about this version? > > Give an error whenever the @dfn{base standard} (see @option{-Wpedantic}) > requires a diagnostic, in cases where there is undefined behavior at > compile-time Only in *some* such cases of compile-time undefined behavi

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Xinliang David Li
On Sun, Oct 19, 2014 at 1:19 AM, Jan Hubicka wrote: >> > >> > I am surprised you hit the size limits with 4.9 only - for quite some time >> > we keep all virtual functions in callgarph until inlining. In fact 4.9 is >> > first >> > that works harder to drop them early (because I hit the problem w

[C PATCH] Another initialization fix (PR c/63567)

2014-10-19 Thread Marek Polacek
It turned out that there is another spot where we need to allow initializing objects with static storage duration with compound literals even in C99 -- when the compound literal is inside the initializer. Fixed in the same way as previously. Bootstrapped/regtested on x86_64-linux, ok for trunk?

Re: [committed] Remove hppa -mjump-in-delay option

2014-10-19 Thread John David Anglin
On 19-Oct-14, at 10:13 AM, Segher Boessenkool wrote: You can set it to "Ignored" in pa.opt now? And remove the mask? Yes, will update. Dave -- John David Anglin dave.ang...@bell.net

Re: [committed] Remove hppa -mjump-in-delay option

2014-10-19 Thread Segher Boessenkool
On Sat, Oct 18, 2014 at 12:04:36PM -0400, John David Anglin wrote: > The attached change removes support for the hppa -mjump-in-delay > option. You can set it to "Ignored" in pa.opt now? And remove the mask? Segher

Re: -fuse-caller-save - Collect register usage information

2014-10-19 Thread Tom de Vries
On 17-10-14 21:24, Eric Botcazou wrote: Let's look at the effect of the option (after the recent fix for PR61605) on gcc.target/i386/fuse-calller-save.c: ... foo: .LFB1: .cfi_startproc - pushq %rbx - .cfi_def_cfa_offset 16 - .cfi_offset 3, -16 - movl%ed

Re: [Patch] Fix PR61889 for the w64-mingw32 case

2014-10-19 Thread Jan Hubicka
> Honza, not sure if this patch is idea, but this will unblock mingw > build problems. Can this one get in? Hmm, the patch is somewhat ugly and I do not know why MingW32 defines mkdir macro and how. If Kai Tietz or other MingW32 maintainer is OK about it, the patch is OK. Honza > > thanks, > >

Re: [PATCH] AutoFDO patch for trunk

2014-10-19 Thread Jan Hubicka
> >> +/* Member functions for string_table. */ > >> + > >> +string_table * > >> +string_table::create () > > > > Why this is not a constructor? > > We use static initializer because it's not suggested to put too much > logic in constructor. Why not? :) > >> +} > > > > The two hunks probably

Re: [PATCH] PR36312

2014-10-19 Thread Manuel López-Ibáñez
On 18 October 2014 14:43, Anthony Brandon wrote: > Never mind about functions.texi. I figured out how to do it. > Here is the new diff and changelog. > > libiberty/ChangeLog: > > 2014-10-18 Anthony Brandon > > * filename_cmp.c (filename_eq): No change. Unfortunately mklog is not 100% p

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Jan Hubicka
> Hi Honza, > > As David says, we will do some more experiments with the change you > suggest and speculative devirtualization, but we needed to make this > change in part to get an internal release out. One of the issues was a > recent change to cp/decl2.c to make virtual function decls needed >

Re: [GOOGLE] Disable -fdevirtualize by default

2014-10-19 Thread Jan Hubicka
> > > > I am surprised you hit the size limits with 4.9 only - for quite some time > > we keep all virtual functions in callgarph until inlining. In fact 4.9 is > > first > > that works harder to drop them early (because I hit the problem with LTO > > where they artifically bloat the size of LTO o

Re: [PATCH 5/5] New tests introduction

2014-10-19 Thread Andreas Schwab
; "icf" } } */ > +/* { dg-final { cleanup-ipa-dump "icf" } } */ FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) Excess errors: /usr/local/gcc/gcc-20141019/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c:4:23: fatal e\ rror: xmmintrin.h: No such file or directory compilatio

Re: IPA ICF fallout: fix for two ipa-icf-*.C tests

2014-10-19 Thread Andreas Schwab
Martin Liška writes: > diff --git a/gcc/testsuite/g++.dg/ipa/ipa-icf-4.C > b/gcc/testsuite/g++.dg/ipa/ipa-icf-4.C > index 9d17889..9434289 100644 > --- a/gcc/testsuite/g++.dg/ipa/ipa-icf-4.C > +++ b/gcc/testsuite/g++.dg/ipa/ipa-icf-4.C > @@ -44,5 +44,5 @@ int main() > } > > /* { dg-final { s