Re: [RFC diagnostics/fortran] Move gfc_warning (buffered) to the common diagnostics machinery

2014-12-01 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > * Dodji: Do the common diagnostics part look reasonable? Yes they do. I just have one minor comment nit: [...] > Index: gcc/pretty-print.h [...] > + > + /* Nonzero means that text should be flushed when > + appropriate. Otherwise, text is buffered until ei

[PATCH] Fix PR63738 testcase

2014-12-01 Thread Richard Biener
Committed. Richard. 2014-12-01 Richard Biener PR tree-optimization/63738 * gcc.dg/torture/pr63738.c: Fix call to setjmp. Index: gcc/testsuite/gcc.dg/torture/pr63738.c === --- gcc/testsuite/gcc.dg/torture/pr63738

[PATCH] Fix PR target/64055

2014-12-01 Thread Ilya Enkovich
Hi, This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant values in array domain. Bootstrapped on x86_64-unknown-linux-gnu with Ada. gnat.dg/derived_aggregate.adb is a new pass. OK for trunk? Thanks, Ilya -- 2014-12-01 Ilya Enkovich PR target/64055

[PATCH][RFC] Fix PR64111

2014-12-01 Thread Richard Biener
The following patch unbreaks PCH of the int_cst_hash_table where we currently compute the hash mixing in the pointer value of a tree. That for sure breaks with PCH. An easy fix is to simply use TYPE_UID instead of htab_hash_pointer. But the hash is quite stupid at the moment. I guess using TYPE

Re: [PATCH PR63941]

2014-12-01 Thread Richard Biener
On Fri, Nov 28, 2014 at 4:30 PM, Yuri Rumyantsev wrote: > Hi All, > > Here is a simple fix for PR 63941 - wrong assertion for dominating bb > which may have true predicate. I deleted it and add setting of > non-true predicate for join bb. After this fix test-case is compiled > successfully. > > Bo

Re: [PATCH] Fix ubsan and C++14 constexpr ICEs (PR sanitizer/63956)

2014-12-01 Thread Marek Polacek
On Sun, Nov 30, 2014 at 11:00:12PM -0500, Jason Merrill wrote: > On 11/27/2014 08:57 AM, Marek Polacek wrote: > >-/* { dg-error "is not a constant expression" "" { target c++ } 12 } */ > >+/* { dg-error "" "" { xfail { *-*-* } } 11 } */ > > Please keep the expected message. Done in the below. 20

Re: [patch] Fix ICE on unaligned record field

2014-12-01 Thread Richard Biener
On Fri, Nov 28, 2014 at 5:20 PM, Eric Botcazou wrote: > Hi, > > the attached Ada testcase triggers an assertion in the RTL expander for the > address operator because the operator has been applied to a non-byte-aligned > record field. The problematic ADDR_EXPR is built by ipa_modify_call_argument

Re: PING for build part – Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-12-01 Thread Richard Biener
On Sun, Nov 30, 2014 at 2:19 PM, Tobias Burnus wrote: > PING for https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03281.html > > Only the build changes have still to be reviewed; the Graphite part is > already approved – as is the loosely related follow-up patch. Ok. Thanks, Richard. > Tobias Burn

Re: [testsuite] Fix multiple definitions of _init

2014-12-01 Thread Richard Biener
On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo wrote: > Hi, > > When running the testsuite on a sh-elf configuration, some test cases > fail due to multiple definitions of the function '_init'. This is > because on sh-elf every function is automatically prefixed with a '_' > char. When defining a C f

Re: [PATCH] Fix PR target/64055

2014-12-01 Thread Richard Biener
On Mon, Dec 1, 2014 at 10:33 AM, Ilya Enkovich wrote: > Hi, > > This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant > values in array domain. Bootstrapped on x86_64-unknown-linux-gnu with Ada. > gnat.dg/derived_aggregate.adb is a new pass. OK for trunk? Ok. But now

Re: [PATCH] Fix PR target/64055

2014-12-01 Thread Ilya Enkovich
2014-12-01 14:11 GMT+03:00 Richard Biener : > On Mon, Dec 1, 2014 at 10:33 AM, Ilya Enkovich wrote: >> Hi, >> >> This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant >> values in array domain. Bootstrapped on x86_64-unknown-linux-gnu with Ada. >> gnat.dg/derived_aggrega

Re: [PATCH][ARM] Fix names of some rounding intrinsics, impement vrndx_f32 and vrndxq_f32

2014-12-01 Thread Kyrill Tkachov
Ping. Kyrill On 21/11/14 11:30, Kyrill Tkachov wrote: Ping again. Thanks, Kyrill On 13/11/14 14:45, Kyrill Tkachov wrote: Ping. Kyrill On 04/11/14 10:56, Kyrill Tkachov wrote: Phew, This one slipped through the cracks. Ping? https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01981.html Thank

Re: C++ Patch for c++/60894

2014-12-01 Thread Fabien Chêne
2014-11-03 21:18 GMT+01:00 Fabien Chêne : > 2014-10-09 15:34 GMT+02:00 Jason Merrill : > [...] >>> If the USING_DECL is returned, the code below will be rejected as >>> expected, but the error message will not mention the line where the >>> USING_DECL appears as the previous definition, but at the

Re: [PATCH][RFC] Fix PR64111

2014-12-01 Thread Mike Stump
On Dec 1, 2014, at 2:23 AM, Richard Biener wrote: > The following patch unbreaks PCH > Any comments? Seems better to me.

RE: [PATCH] MIPS16/GCC: Optimise `__call_stub_fp_' call/return stubs

2014-12-01 Thread Maciej W. Rozycki
On Fri, 21 Nov 2014, Moore, Catherine wrote: > > gcc/ > > * config/mips/mips.c (mips16_build_call_stub): Move the save of > > the return address in $18 ahead of passing arguments to FPRs. > > > > Maciej > > This looks OK. Please commit. Applied, thanks for your review. Maciej

[PATCH] Fix PR64126

2014-12-01 Thread Richard Biener
The following fixes PR64126. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-12-01 Richard Biener PR middle-end/64126 * match.pd: Allow conversions in ~A + 1 -> -A, add -A - 1 -> ~A and -1 - A -> ~A. * fold-const.c (fold_binary_loc

[PATCH] Fix PR15346

2014-12-01 Thread Richard Biener
The following fixes the oldest bug in my list of assigned PRs, namely combining A / CST / CST' to A / (CST * CST'). extract_muldiv does this in fold-const.c (but it fails to optimize to zero when CST * CST' overflows). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richa

[patch] libstdc++/63840 fix exception-safety in std::function copy constructor

2014-12-01 Thread Jonathan Wakely
Because the fix is so simple I'm doing it for std::tr1::function as well. I intend to backport this to 4.8 and 4.9 too. Tested x86_64-linux + powerpc64-linux, committed to trunk. commit 96d883f68114f32aeb38fd4d456b61d34ddee48d Author: Jonathan Wakely Date: Fri Nov 14 17:09:21 2014 +

[PATCH] Rename gimple_build_assign_with_ops to gimple_build_assign and swap the first two arguments of it

2014-12-01 Thread Jakub Jelinek
On Fri, Nov 28, 2014 at 08:02:23PM +0100, Jakub Jelinek wrote: > As possible follow-up, I wonder if gimple_build_assign_with_ops > isn't too long and too verbose either, couldn't we just > use overloads of gimple_build_assign instead? > Either with the argument order of gimple_build_assign_with_ops

[PATCH] Fix PR64137

2014-12-01 Thread Richard Biener
The following fixes invalid GENERIC (and also wrong-code?) generated for various testcases involving min/maxloc intrinsics. It seems like the wrong expression is used to discriminate REAL vs. INTEGER types and thus REAL -Huge is offsetted by integer -1. To quote a little more context, here is th

Re: [PATCH] Rename gimple_build_assign_with_ops to gimple_build_assign and swap the first two arguments of it

2014-12-01 Thread Richard Biener
On Mon, 1 Dec 2014, Jakub Jelinek wrote: > On Fri, Nov 28, 2014 at 08:02:23PM +0100, Jakub Jelinek wrote: > > As possible follow-up, I wonder if gimple_build_assign_with_ops > > isn't too long and too verbose either, couldn't we just > > use overloads of gimple_build_assign instead? > > Either wit

[PATCH] Fix PR64121

2014-12-01 Thread Marek Polacek
This fixes PR64121, where we ran into a SSA corruption failure because we couldn't coalesce two SSA_NAME_OCCURS_IN_ABNORMAL_PHI SSA_NAMEs. So just skip such SSA names when looking for a base. Bootstrapped/regtested on ppc64-linux, ok for trunk? 2014-12-01 Marek Polacek Jakub Jelin

Re: [PATCH] Fix PR64121

2014-12-01 Thread Richard Biener
On Mon, Dec 1, 2014 at 3:12 PM, Marek Polacek wrote: > This fixes PR64121, where we ran into a SSA corruption failure > because we couldn't coalesce two SSA_NAME_OCCURS_IN_ABNORMAL_PHI > SSA_NAMEs. So just skip such SSA names when looking for a base. Not really "skip" but "stop at". > Bootstrap

Re: [C++ PATCH] Allow void type as a literal type in C++14

2014-12-01 Thread Jason Merrill
OK. Jason

Re: [PATCH x86] Update options for avx512 testsuite.

2014-12-01 Thread H.J. Lu
On Fri, Nov 28, 2014 at 7:15 AM, Uros Bizjak wrote: > Hello! > >> As discussed for AVX512F submission, using -D in dg-options, >> should be replaced with parts of the testcase itself. Patch below >> does that. >> Ok for trunk? >> >> P. S. >> As patch itself is hard to review, this was done by

[C++ Patch] PR 60845

2014-12-01 Thread Paolo Carlini
Hi, Manuel noticed that in this error message it would be nice to have an 'aka' for typedefs. It seems to me that simply using the standard for types %qT is most of it, but I propose also to add a '#' (otherwise we regress on g++.dg/inherit/error5.C). Tested x86_64-linux. Thanks, Paolo. ///

Re: [PATCH] Fix ubsan and C++14 constexpr ICEs (PR sanitizer/63956)

2014-12-01 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH] -fsanitize=vptr instrumentation (take 2)

2014-12-01 Thread Jason Merrill
On 11/28/2014 09:41 AM, Jakub Jelinek wrote: Why do you look through ARRAY_REF here? An element of an array is its own complete object. That had to do with only instrumenting dereferences surrounded by handled components, but not accesses to decls (so p->x gets instrumented but q.x for VAR_DEC

Re: [C++ Patch] PR 60845

2014-12-01 Thread Jason Merrill
OK. Jason

Re: [PATCH x86] Update options for avx512 testsuite.

2014-12-01 Thread H.J. Lu
On Mon, Dec 1, 2014 at 6:37 AM, H.J. Lu wrote: > On Fri, Nov 28, 2014 at 7:15 AM, Uros Bizjak wrote: >> Hello! >> >>> As discussed for AVX512F submission, using -D in dg-options, >>> should be replaced with parts of the testcase itself. Patch below >>> does that. >>> Ok for trunk? >>> >>> P.

Re: [PATCH] Fix PR15346

2014-12-01 Thread Ulrich Weigand
Richard Biener wrote: > * Makefile.in (gimple-match.o-warn): Remove -Wno-unused-parameter, > add -Wno-unused-but-set-variable. This seems to cause cc1plus: error: unrecognized command line option "-Wno-unused-but-set-variable"

Re: [match-and-simplify] operator-lists in expression

2014-12-01 Thread Richard Biener
On Tue, Nov 11, 2014 at 9:55 AM, Richard Biener wrote: > On Mon, Nov 10, 2014 at 2:39 PM, Prathamesh Kulkarni > wrote: >> Hi, >> This patch adds support for operator-lists to be used in expression. >> >> I reuse operator-list as the iterator. This is not really valid since >> user-defined opera

Re: [PATCH] Fix PR15346

2014-12-01 Thread Richard Biener
On Mon, 1 Dec 2014, Ulrich Weigand wrote: > Richard Biener wrote: > > > * Makefile.in (gimple-match.o-warn): Remove -Wno-unused-parameter, > > add -Wno-unused-but-set-variable. > > This seems to cause > > cc1plus: error: unrecognized command line option > "-Wno-unused-but-set-variable"

Re: Fix libgomp crash without TLS (PR42616)

2014-12-01 Thread Varvara Rainchik
Hi Jakub, Do you think this patch is ok for upstream: 2014-12-01 Varvara Rainchik * libgomp/libgomp.h: Eliminate case when HAVE_TLS is not defined: always use tls emulation. * libgomp/team.c: Likewise. -- diff --git a/libgomp/libgomp.h b/libgomp/libgomp.h index a1482c

Re: [PATCH] Enhance array types debug info. for Ada

2014-12-01 Thread Pierre-Marie de Rodat
On 11/26/2014 06:42 PM, Jakub Jelinek wrote: Replace implicitely with implicitly in the whole patch. Oops! Done. + If CONTEXT is NULL, the behavior is the same as if the context_type field + was NULL_TREE. */ as if both context_type and base_decl were NULL_TREE? Absolutely: done. +

Re: [PATCH][ARM] Optimize copysign/copysignf for soft-float using BFI

2014-12-01 Thread Christophe Lyon
On 27 November 2014 at 11:35, Ramana Radhakrishnan wrote: > On Wed, Oct 29, 2014 at 10:20 AM, Jiong Wang wrote: >> On 26/08/14 13:36, Richard Earnshaw wrote: >> >>> On 29/07/14 15:49, Jiong Wang wrote: test done === no regression on the full toolchain test on arm-none-eabi. >>

Re: [PATCH] Enhance array types debug info. for Ada

2014-12-01 Thread Jakub Jelinek
On Mon, Dec 01, 2014 at 04:29:05PM +0100, Pierre-Marie de Rodat wrote: > >>+ expansion_failed (loc, NULL_RTX, > >>+ "PLACEHOLDER_EXPR for a unexpected type"); > > > >for an unexpected type? > > Yes: placeholder expressions are supposed only to refer to the type allowed > by t

Re: [PATCH] Fix PR64137

2014-12-01 Thread FX
Your change is OK (we don’t want to use the type of the result, but the type of the argument indeed). > Index: gcc/fortran/trans-intrinsic.c > === > --- gcc/fortran/trans-intrinsic.c (revision 218211) > +++ gcc/fortran/trans-int

[PATCH] Avoid further const_binop regressions

2014-12-01 Thread Richard Biener
This moves more constant folding from fold_binary to the const_binop overload with type and handles POINTER_PLUS_EXPR in the main routine as well as fixing a minor glitch I introduced. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2014-12-01 Richard Biener

[PATCH] Fix compile with old host GCC

2014-12-01 Thread Richard Biener
Committed after entering stage3 in a bootstrap. Richard. 2014-12-01 Richard Biener * Makefile.in (gimple-match.o-warn): Use -Wno-unused instead of -Wno-unused-variable and -Wno-unused-but-set-variable to restore bootstrap with old GCC. (generic-match.o-warn):

Re: [PATCH] Fix PR64137

2014-12-01 Thread Richard Biener
On Mon, 1 Dec 2014, FX wrote: > Your change is OK (we don’t want to use the type of the result, but the type > of the argument indeed). > > > > Index: gcc/fortran/trans-intrinsic.c > > === > > --- gcc/fortran/trans-intrinsic.c (r

Re: [PATCH][ARM] Optimize copysign/copysignf for soft-float using BFI

2014-12-01 Thread Jiong Wang
On 01/12/14 15:33, Christophe Lyon wrote: On 27 November 2014 at 11:35, Ramana Radhakrishnan wrote: On Wed, Oct 29, 2014 at 10:20 AM, Jiong Wang wrote: On 26/08/14 13:36, Richard Earnshaw wrote: On 29/07/14 15:49, Jiong Wang wrote: test done === no regression on the full toolchain test on

Re: [PATCH] Fix PR15346

2014-12-01 Thread Jakub Jelinek
On Mon, Dec 01, 2014 at 04:10:35PM +0100, Richard Biener wrote: > On Mon, 1 Dec 2014, Ulrich Weigand wrote: > > > Richard Biener wrote: > > > > > * Makefile.in (gimple-match.o-warn): Remove -Wno-unused-parameter, > > > add -Wno-unused-but-set-variable. > > > > This seems to cause > > > > cc

Re: [PATCH 2/3] Extended if-conversion

2014-12-01 Thread Yuri Rumyantsev
Hi Richard, I resend you patch1 and patch2 with minor changes: 1. I renamed flag_force_vectorize to aggressive_if_conv. 2. Use static cast for the first argument of gimple_phi_arg_edge. I also very sorry that I sent you bad patch. Now let me answer on your questions related to second patch. 1. Wh

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"

2014-12-01 Thread H.J. Lu
On Thu, Nov 27, 2014 at 8:38 AM, Renlin Li wrote: > On 27/11/14 15:37, H.J. Lu wrote: >> >> On Thu, Nov 27, 2014 at 7:32 AM, Renlin Li wrote: >>> >>> On 26/11/14 18:12, H.J. Lu wrote: On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li wrote: > > On 26/11/14 12:16, H.J. Lu wrote: >

Re: [PATCH x86] Update options for avx512 testsuite.

2014-12-01 Thread Ilya Tocar
> > I saw > > > > FAIL: gcc.dg/vect/costmodel/i386/costmodel-fast-math-vect-pr29925.c > > scan-tree-dump-times vect "vectorized 1 loops" 1 > > FAIL: gcc.dg/vect/costmodel/x86_64/costmodel-fast-math-vect-pr29925.c > > scan-tree-dump-times vect "vectorized 1 loops" 1 > > FAIL: gcc.target/i386/avx256-

Re: [PATCH x86] Update options for avx512 testsuite.

2014-12-01 Thread H.J. Lu
On Mon, Dec 1, 2014 at 8:35 AM, Ilya Tocar wrote: >> > I saw >> > >> > FAIL: gcc.dg/vect/costmodel/i386/costmodel-fast-math-vect-pr29925.c >> > scan-tree-dump-times vect "vectorized 1 loops" 1 >> > FAIL: gcc.dg/vect/costmodel/x86_64/costmodel-fast-math-vect-pr29925.c >> > scan-tree-dump-times vect

[PATCH linemap] Make some asserts fail gracefully

2014-12-01 Thread Manuel López-Ibáñez
The following patch adds linemap_assert_fails(), which is an assert meant to be used in conditions such as: if (linemap_assert_fails(EXPR)) handle_error(); This is useful for ICEs that we would like to detect during the development phase but that could be handled gracefully. In the case of line

Re: [PATCH] Enhance array types debug info. for Ada

2014-12-01 Thread Pierre-Marie de Rodat
On 12/01/2014 04:37 PM, Jakub Jelinek wrote: for an unexpected type? Yes: placeholder expressions are supposed only to refer to the type allowed by the context. I updated the message to talk about the context and I added another one for the (invalid) case when want_address == 0. I meant that

PING Re: [PATCH 19/21] PR jit/63854: Fix leak of ipa hooks

2014-12-01 Thread David Malcolm
On Wed, 2014-11-19 at 12:58 -0700, Jeff Law wrote: > On 11/19/14 03:46, David Malcolm wrote: > > This fixes three leaks in IPA seen in jit testcases with valgrind: > > > > This one: > > 96 bytes in 4 blocks are definitely lost in loss record 102 of 205 > > at 0x4A0645D: malloc (in > > /usr/lib

Re: [PATCH] Set stores_off_frame_dead_at_return to false if sibling call

2014-12-01 Thread Jeff Law
On 11/28/14 18:05, John David Anglin wrote: The attached simple change fixes a long standing regression since 4.2. When we have stack arguments and a sibling call, the dse pass deletes stores to the parent's stack frame when we have a sibling call because they are are off frame for the current fu

[C++ Patch] PR 60859

2014-12-01 Thread Paolo Carlini
Hi, I'm pretty sure that we should accept this. Tested x86_64-linux. Thanks, Paolo. /cp 2014-12-01 Paolo Carlini PR c++/60859 * decl.c (reshape_init_r): Do not reject value-initialization of scalar array element. /testsuite 2014-12-01 Paolo Car

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"

2014-12-01 Thread Renlin Li
On 01/12/14 15:58, H.J. Lu wrote: On Thu, Nov 27, 2014 at 8:38 AM, Renlin Li wrote: On 27/11/14 15:37, H.J. Lu wrote: On Thu, Nov 27, 2014 at 7:32 AM, Renlin Li wrote: On 26/11/14 18:12, H.J. Lu wrote: On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li wrote: On 26/11/14 12:16, H.J. Lu wrote: O

Re: [PATCH 2/2, PR 63814] Do not re-create expanded artificial thunks

2014-12-01 Thread Martin Jambor
Ping. Thx, Martin On Fri, Nov 21, 2014 at 08:18:12PM +0100, Martin Jambor wrote: > Hi, > > when debugging PR 63814 I noticed that when cgraph_node::create_clone > was using redirect_edge_duplicating_thunks to redirect two edges to a > thunk of a clone, two thunks were created, one for each edg

Re: [PATCH 1/2, PR 63814] Strengthen cgraph_edge_brings_value_p

2014-12-01 Thread Martin Jambor
Ping. Thx, Martin On Fri, Nov 21, 2014 at 07:59:11PM +0100, Martin Jambor wrote: > Hi, > > PR 63814 is caused by cgraph_edge_brings_value_p misidentifying an > edge to an expanded artificial thunk as an edge to the original node, > which then leads to crazy double-cloning and doubling the thunk

[PATCH][AArch64][obvious] Gate fuse_adrp_add_1.c test on aarch64_small

2014-12-01 Thread Kyrill Tkachov
Hi all, I noticed that this test depends on adrp+add sequences being used for constants, which only happens when the memory model used is small. If tiny or large is used then the required adrp+add sequences are not generated, making the test pointless for them. This patch guards the test on t

Re: [PATCH] Improve spillcost of literal pool loads

2014-12-01 Thread Jeff Law
On 11/28/14 07:10, Wilco Dijkstra wrote: Jeff Law wrote: Do you have a testcase that shows the expected improvements from this change? It's OK if it's specific to a target. Have you bootstrapped and regression tested this change? With a test for the testsuite and assuming it passes bootstrap a

[tree-type] Remove variables name ttype in preparation for changing the type from tree_type_ptr to ttype

2014-12-01 Thread Andrew MacLeod
Changes a few files where ttype is used as a variable. The next patch changes the branch to use ttype as the name instead of tree_type_ptr. bootstraps, run tests, etc. checked into branch. Andrew * builtins.c (fold_builtin_atomic_always_lock_free): Don't use ttype as a variable name. * c

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

2014-12-01 Thread Martin Jambor
Ping (this is a new feature submitted in stage1 so I'd really appreciate a review before it is going to be deemed "too late"). Thanks, Martin On Wed, Nov 19, 2014 at 12:32:53AM +0100, Martin Jambor wrote: > Hi, > ... > > 2014-11-19 Martin Jambor > > * ipa-prop.h (ipa_alignment): N

Re: PING Re: [PATCH 19/21] PR jit/63854: Fix leak of ipa hooks

2014-12-01 Thread Jan Hubicka
> > > My patch hacks in a removal of them into ipa_reference_c_finalize, but > > > I suspect there's a cleaner place to put this. > > > > > > gcc/ChangeLog: > > > PR jit/63854 > > > * ipa-prop.c (ipa_register_cgraph_hooks): Guard insertion of > > > ipa_add_new_function on function_insertion_h

Re: [PATCH 5/6] combine: handle REG_UNUSED in reg_dead_at_p (PR59278)

2014-12-01 Thread Jeff Law
On 11/27/14 18:44, Segher Boessenkool wrote: Currently reg_dead_at_p returns 0 for registers that are set but never used. This patch repairs that oversight. This fixes PR59278. 2014-11-27 Segher Boessenkool gcc/ PR rtl-optimization/59278 combine (reg_dead_at_p): Consider R

Re: [PATCH 6/6] combine: allow combining two insns into two in some cases (PR52714)

2014-12-01 Thread Jeff Law
On 11/27/14 18:44, Segher Boessenkool wrote: If one of the resulting insns is a noop set it is safe to allow the combination, for it will never lead to a loop: any following combination using that noop will delete it. In fact, in most cases combine deletes the noop immediately; for cc0 targets i

Re: [PATCH 1/6] combine: add regno field to LOG_LINKS

2014-12-01 Thread Jeff Law
On 11/27/14 18:44, Segher Boessenkool wrote: With this new field in place, we can have LOG_LINKS for insns that set more than one register and distribute them properly in distribute_links. This then allows many more PARALLELs to be combined. Also split off new functions can_combine_{def,use}_p f

Re: [PATCH 2/6] combine: distribute_log_links for PARALLELs of SETs

2014-12-01 Thread Jeff Law
On 11/27/14 18:44, Segher Boessenkool wrote: Now that LOG_LINKS are per regno, we can distribute them on PARALLELs just fine. Do so. This makes PARALLELs not lose their LOG_LINKS early when e.g. a trivial reg-reg move is combined, so that they can be used in more useful combinations as well.

[tree-type] Use ttype instead of tree_type_ptr in the branch.

2014-12-01 Thread Andrew MacLeod
Changes 'tree_type_ptr' to 'ttype' everywhere. The second attachment is the updated patch which converts the branch to a segregated tree-type for compilation testing. (remembering that this patch is maintained as 'tree-type.patch' in the source directory). Andrew * fold-const.c (fold_con

Re: [PATCH 3/6] combine: handle I2 a parallel of two SETs

2014-12-01 Thread Jeff Law
On 11/27/14 18:44, Segher Boessenkool wrote: If I2 is a PARALLEL of two SETs, split it into two instructions, I1 and I2. If there already was an I1, rename it to I0. If there already was an I0, don't do anything. This surprisingly simple patch is enough to let combine handle such PARALLELs pro

Re: [PATCH 2/3] IPA-CP propagation of polymorphic contexts

2014-12-01 Thread H.J. Lu
On Thu, Nov 13, 2014 at 5:32 PM, Martin Jambor wrote: > Hi, > > this patch is that main part of the series, implementing propagation > of ipa_polymorphic_call_contexts. Although I tried to keep its size > checked, it is big because switching from binfos to contexts in ipa-cp > also requires chang

Re: [RFC PATCH, i386]: Prefer %ebx in set_got patterns

2014-12-01 Thread Jeff Law
On 11/27/14 04:19, Uros Bizjak wrote: Hello! Attached patch helps RA to choose the most appropriate PIC register by changing the register preference for set_got patterns. Using this patch, there should really be a reason for RA to avoid ABI mandated hard PIC reg. Agreed. This patch avoids ma

Re: [RFC PATCH, i386]: Prefer %ebx in set_got patterns

2014-12-01 Thread Jakub Jelinek
On Mon, Dec 01, 2014 at 10:47:40AM -0700, Jeff Law wrote: > > * config/i386/i386.md (set_got): Use "=b,?r" constraint for operand 0. > > (set_got_labelled): Ditto. > > (set_got_rex64): Ditto. > > (set_rip_rex64): Ditto. > > (set_got_offset_rex64): Ditto. > > > >Bootstrapped and

Re: [RFC PATCH, i386]: Prefer %ebx in set_got patterns

2014-12-01 Thread Uros Bizjak
On Mon, Dec 1, 2014 at 6:47 PM, Jeff Law wrote: > On 11/27/14 04:19, Uros Bizjak wrote: >> Attached patch helps RA to choose the most appropriate PIC register by >> changing the register preference for set_got patterns. Using this >> patch, there should really be a reason for RA to avoid ABI mand

Re: [C++ Patch] PR 60859

2014-12-01 Thread Jason Merrill
OK. Jason

Re: [PATCH 3/5] combine: add regno field to LOG_LINKS

2014-12-01 Thread Jeff Law
On 11/26/14 14:59, Segher Boessenkool wrote: On Wed, Nov 26, 2014 at 11:14:36AM -0700, Jeff Law wrote: Are you talking about create_log_links? There can be no duplicates there (anymore), that would be multiple defs of the same reg in the same insn, indeed. Yes, I was referring to the code in c

Re: [PATCH 4/6] combine: simplify the CC thing code

2014-12-01 Thread Jeff Law
On 11/27/14 18:44, Segher Boessenkool wrote: [What a great subject line]. This simplifies the code right before the new code of the previous patch to use one of the new helper functions that introduces. 2014-11-27 Segher Boessenkool gcc/ * combine.c (try_combine): Use is_parallel_o

Re: [PATCH] Fix middle-end/64061, ICE in gen_rtx_SUBREG

2014-12-01 Thread Jeff Law
On 11/26/14 15:00, Andrew Pinski wrote: Hi, The problem here is lra_substitute_pseudo calls gen_rtx_SUBREG with a VOIDmode (const_int) argument but really it should not be calling gen_rtx_SUBREG directly instead it should be using gen_lowpart_if_possible. This patch fixes that and adds a test

Re: [PATCH] Allow -fsanitize=thread without -pie

2014-12-01 Thread Jeff Law
On 11/26/14 12:43, Jakub Jelinek wrote: On Fri, Nov 21, 2014 at 04:20:44PM +0400, Dmitry Vyukov wrote: Yes, I think it's the way to go. I've just committed the following revision to clang that removes -pie when compiling with tsan: http://llvm.org/viewvc/llvm-project?view=revision&revision=22252

Re: [PATCH] Fix middle-end/64061, ICE in gen_rtx_SUBREG

2014-12-01 Thread H.J. Lu
On Wed, Nov 26, 2014 at 2:01 PM, Andrew Pinski wrote: > On Wed, Nov 26, 2014 at 2:00 PM, Andrew Pinski wrote: >> Hi, >> The problem here is lra_substitute_pseudo calls gen_rtx_SUBREG with >> a VOIDmode (const_int) argument but really it should not be calling >> gen_rtx_SUBREG directly instead i

Re: [PATCH] Fix middle-end/64061, ICE in gen_rtx_SUBREG

2014-12-01 Thread Andrew Pinski
On Mon, Dec 1, 2014 at 10:26 AM, Jeff Law wrote: > On 11/26/14 15:00, Andrew Pinski wrote: >> >> Hi, >>The problem here is lra_substitute_pseudo calls gen_rtx_SUBREG with >> a VOIDmode (const_int) argument but really it should not be calling >> gen_rtx_SUBREG directly instead it should be usin

Re: [PATCH] Set stores_off_frame_dead_at_return to false if sibling call

2014-12-01 Thread John David Anglin
On 12/1/2014 11:57 AM, Jeff Law wrote: Prior to reload (ie, in DSE1) there's a bit of magic in that we do not set frame_read on call insns. That may in fact be wrong and possibly the source of the problem. /* This field is only used for the processing of const functions. These functions

[wwwdocs] Buildstat update for 4.8

2014-12-01 Thread Tom G. Christensen
Latest results for gcc 4.8.x. -tgc Testresults for 4.8.3 hppa-unknown-linux-gnu x86_64-apple-darwin14.0.0 Index: buildstat.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/buildstat.html,v retrieving revision 1.12 diff -u -r1.

[wwwdocs] Buildstat update for 4.9

2014-12-01 Thread Tom G. Christensen
Latest results for 4.9.x -tgc Testresults for 4.9.2: hppa-unknown-linux-gnu i386-pc-solaris2.9 i386-sun-solaris2.11 i486-sun-solaris2.11 i686-unknown-linux-gnu mips-unknown-linux-gnu mipsel-unknown-linux-gnu sparc-sun-solaris2.9 sparc64-sun-solaris2.9 sparc-unknown-linux-gnu

Re: C++ Patch for c++/60894

2014-12-01 Thread Jason Merrill
On 12/01/2014 07:01 AM, Fabien Chêne wrote: 2014-11-03 21:18 GMT+01:00 Fabien Chêne : 2014-10-09 15:34 GMT+02:00 Jason Merrill : [...] If the USING_DECL is returned, the code below will be rejected as expected, but the error message will not mention the line where the USING_DECL appears as the

Re: [Patch] Improving jump-thread pass for PR 54742

2014-12-01 Thread Jeff Law
On 11/25/14 14:16, Sebastian Pop wrote: Sebastian Pop wrote: >I will bootstrap and regression test this patch on x86_64-linux and >powerpc64-linux. I will also run it on our internal benchmarks, coremark, and >the llvm test-suite. > >I will also include a longer testcase that makes sure we do n

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-12-01 Thread Jeff Law
On 11/24/14 07:06, Ilya Enkovich wrote: Normally GCC target libraries assigned to the FSF would use GPL+exception rather than LGPL (especially if the library might be linked in statically), to keep predictable what requirements are imposed by linking your program with GCC. libquadmath is an exce

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-12-01 Thread Jeff Law
On 11/24/14 07:09, Ilya Enkovich wrote: -- Here is a version with updated documentation. Added -static-libmpx and -static-libmpxwrappers options. Added description on runtime library dependencies. Thanks, Ilya -- 2014-11-24 Ilya Enkovich * c-family/c.opt (fchkp-use-wrappers):

Re: [PATCH, MPX wrappers 3/3] Tests

2014-12-01 Thread Jeff Law
On 11/14/14 10:31, Ilya Enkovich wrote: Hi, Here are few tests for MPX wrappers. Will add more in case patches #1,2 are OK. Thanks, Ilya -- 2014-11-14 Ilya Enkovich * lib/mpx-dg.exp (mpx_link_flags): Set path to wrappers library. * gcc.target/i386/mpx/calloc-1-lbv.c: New.

Re: [PATCH] Fix PR64126

2014-12-01 Thread Marc Glisse
On Mon, 1 Dec 2014, Richard Biener wrote: The following fixes PR64126. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-12-01 Richard Biener PR middle-end/64126 * match.pd: Allow conversions in ~A + 1 -> -A, add -A - 1 -> ~A and -1 - A ->

Re: [PATCH] Fix PR15346

2014-12-01 Thread Marc Glisse
On Mon, 1 Dec 2014, Richard Biener wrote: The following fixes the oldest bug in my list of assigned PRs, namely combining A / CST / CST' to A / (CST * CST'). extract_muldiv does this in fold-const.c (but it fails to optimize to zero when CST * CST' overflows). Bootstrapped and tested on x86_64

Re: [PATCH 06/08] Avoid overuse of name "buffer" in tree-pretty-print.c

2014-12-01 Thread Jeff Law
On 11/25/14 18:39, David Malcolm wrote: Various functions in tree-pretty-print.c take a param pretty_printer *buffer and there's also a static pretty_printer *buffer; Additionally, pretty_printer instances are not buffers; they *contain* buffers (inasmuch as they have a field "buffer"). This

Re: [PATCH 05/08] PR jit/63854: Fix double-initialization within tree-pretty-print.c

2014-12-01 Thread Jeff Law
On 11/25/14 18:39, David Malcolm wrote: Running various JIT testcases under valgrid showed this one-time leak: 8,464 (336 direct, 8,128 indirect) bytes in 1 blocks are definitely lost in loss record 144 of 147 at 0x4A081D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-01 Thread Jeff Law
On 11/25/14 15:57, Mark Wielaard wrote: This implements the DWARFv5 noreturn proposal: http://dwarfstd.org/ShowIssue.php?issue=140331.1 TREE_THIS_VOLATILE on a FUNCTION_DECL node means the function does not return normally. This catches the traditional noreturn GNU attribute, the C11 _Noreturn k

Re: [PATCH 1/2, PR 63814] Strengthen cgraph_edge_brings_value_p

2014-12-01 Thread Jan Hubicka
> > Hi, > > > > PR 63814 is caused by cgraph_edge_brings_value_p misidentifying an > > edge to an expanded artificial thunk as an edge to the original node, > > which then leads to crazy double-cloning and doubling the thunks along > > the call. > > > > This patch fixes the bug by strengthening t

Re: PR 13631 Problems in messages

2014-12-01 Thread François Dumont
Hi Here is another proposal that consider all your remarks except one. I finally prefer to go with std::vector of pointers. Dynamically allocating Catalog_info allow to avoid numerous copies of locale when we find this pointer from the catalog info. On 28/11/2014 11:49, Jonathan Wakely

Re: [PATCH 2/2, PR 63814] Do not re-create expanded artificial thunks

2014-12-01 Thread Jan Hubicka
> On Fri, Nov 21, 2014 at 08:18:12PM +0100, Martin Jambor wrote: > > Hi, > > > > when debugging PR 63814 I noticed that when cgraph_node::create_clone > > was using redirect_edge_duplicating_thunks to redirect two edges to a > > thunk of a clone, two thunks were created, one for each edge. The >

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-01 Thread Cary Coutant
> Presumably we don't have any sense when the values will be assigned, right? > Any chance we could speed that along a bit? As Jason said, the value in the current draft is unlikely to change, and I think he and I can probably lobby to keep it unchanged if there any danger that the numbering will

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-01 Thread Jeff Law
On 12/01/14 14:44, Cary Coutant wrote: Presumably we don't have any sense when the values will be assigned, right? Any chance we could speed that along a bit? As Jason said, the value in the current draft is unlikely to change, and I think he and I can probably lobby to keep it unchanged if the

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-01 Thread Jakub Jelinek
On Mon, Dec 01, 2014 at 02:50:57PM -0700, Jeff Law wrote: > On 12/01/14 14:44, Cary Coutant wrote: > >>Presumably we don't have any sense when the values will be assigned, right? > >>Any chance we could speed that along a bit? > > > >As Jason said, the value in the current draft is unlikely to chan

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-12-01 Thread Cary Coutant
[+cc Michael Eager] > Rather than having to lobby to keep it unchanged because we jumped the gun, > can we lobby to get the number assigned in the near future rather than in > the potentially far future? That feels more cooperative to me :-) > > Would that make Michael happier? I'm pretty confid

Re: [PATCH] Fix PR 61225

2014-12-01 Thread Jeff Law
On 08/04/14 02:24, Zhenqiang Chen wrote: ChangeLog: 2014-05-22 Zhenqiang Chen Part of PR rtl-optimization/61225 * config/i386/i386-protos.h (ix86_peephole2_rtx_equal_p): New proto. * config/i386/i386.c (ix86_peephole2_rtx_equal_p): New function. * reg

Re: [PATCH] Add top-level config support for gold mips target

2014-12-01 Thread Cary Coutant
Ping^2. -cary On Wed, Oct 29, 2014 at 12:04 PM, Cary Coutant wrote: > Ping? > > On Mon, Oct 20, 2014 at 10:31 AM, Cary Coutant wrote: >> This patch adds support for the mips target in gold. >> >> OK to commit? >> >> -cary >> >> >> 2014-10-20 Cary Coutant >> >> * configure (--enable-g

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

2014-12-01 Thread Jan Hubicka
> > 2014-11-19 Martin Jambor > > > > * ipa-prop.h (ipa_alignment): New type. > > (ipa_jump_func): New field alignment. > > (ipcp_transformation_summary) New type. > > (ipcp_grow_transformations_if_necessary): Declare. > > (ipa_node_agg_replacements): Removed. > > (ipcp_t

  1   2   >