Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Bin.Cheng
On Mon, Jan 5, 2015 at 3:44 PM, Kito Cheng kito.ch...@gmail.com wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore instruction generation, the current LRA implementation will miss caller-save store/restore

Re: [PATCH][PING] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-05 Thread Dimitris Papavasiliou
Ping! On 12/24/2014 07:28 PM, Dimitris Papavasiliou wrote: Hello, The attached patch fixes an issue reported a couple of years ago in Bug 51891 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51891). The problem is caused because classes without instance variables have no ivar list at all, so

[committed] Better location for -Wchar-subscripts (PR c/64423)

2015-01-05 Thread Marek Polacek
warn_array_subscript_with_type_char wasn't getting a location, so the caret location was off. Thus fixed. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2015-01-05 Marek Polacek pola...@redhat.com PR c/64423 c-family/ * c-common.c

RE: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-05 Thread Bernd Edlinger
Hi, On Sun, 4 Jan 2015 14:18:59, Mike Stump wrote: But tsan still gets at least 90% chance to spot that. As a matter of fact, the tsan runtime is just _incredibly_ fast, and catches errors, with a very high reliability. But it is racy by design. You say by design. I’m skeptical of that.

[PATCH] Fix up 2 Copyright years lines

2015-01-05 Thread Jakub Jelinek
Hi! I've committed following fix, update-copyright.py was complaining about these. 2015-01-05 Jakub Jelinek ja...@redhat.com * auto-profile.c, auto-profile.h: Fix up Copyright line. --- gcc/auto-profile.c (revision 219184) +++ gcc/auto-profile.c (working copy) @@ -1,5 +1,5 @@ /*

*ping* [patch, fortran] Fix for PR 47676

2015-01-05 Thread Thomas Koenig
Am 30.12.2014 um 01:25 schrieb Thomas Koenig: Hello world, this patch fixes the long-standing bug. A missing temporary causes an invalid read in realloc_on_assign_5.f03 which only becomes noticable when setting MALLOC_CHECK_ or when using valgrind. The bug has three duplicates in the

[committed] Update copyright years, part 1

2015-01-05 Thread Jakub Jelinek
Hi! I've committed following patch to update the user visible copyright years (and rolled new year of gcc/ada and libjava ChangeLogs). 2015-01-05 Jakub Jelinek ja...@redhat.com gcc/ * gcc.c (process_command): Update copyright notice dates. * gcov-dump.c: Ditto. *

Re: [PATCH] Fix PR c++/59366 A friend function template defined in a class is found without ADL

2015-01-05 Thread Jason Merrill
On 12/30/2014 11:24 AM, Momchil Velikov wrote: A function template enters the body of the if statement at line 1881, if (TREE_CODE (newdecl) == TEMPLATE_DECL) and exits the function at line 1951 with return olddecl; Ah, yes. The patch is OK, then, but still needs ChangeLog and

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-05 Thread Jeff Law
On 01/04/15 10:16, Richard Biener wrote: But either your new hook or the original fix makes no sense. All I want is to restore the old behavior on x86. If the original fix makes no sense, should it be reverted? I think the original fix is too conservative Perhaps. Neither John nor I felt

[committed] Fix typo in docs

2015-01-05 Thread Marek Polacek
This patch adds a missing comma in the documentation. Applying as obvious. 2015-01-05 Marek Polacek pola...@redhat.com * doc/extend.texi (Arrays of Length Zero): Add missing comma. diff --git gcc/doc/extend.texi gcc/doc/extend.texi index ffefb67..7cd6a56 100644 ---

Re: [hsa] HSA: support for direct function call is introduced.

2015-01-05 Thread Martin Liška
On 12/13/2014 12:33 PM, Eric Botcazou wrote: Martin, gcc/c-family/ChangeLog: 2014-12-05 Martin Liska mli...@suse.cz * c-common.c: New 'hsafunc' attribute is added. 2014-12-05 Martin Liska mli...@suse.cz * hsa-brig.c (struct function_linkage_pair): New data structure.

Re: [PATCH] IPA ICF: refactoring + fix for PR ipa/63569

2015-01-05 Thread Martin Liška
On 12/19/2014 12:04 PM, Richard Biener wrote: On Thu, Dec 18, 2014 at 6:38 PM, Martin Liška mli...@suse.cz wrote: On 12/17/2014 04:23 PM, Richard Biener wrote: On Wed, Dec 17, 2014 at 12:17 PM, Martin Liška mli...@suse.cz wrote: On 12/11/2014 01:37 PM, Richard Biener wrote: On Wed, Dec

Patch ping

2015-01-05 Thread Jakub Jelinek
Hi! I'd like to ping 3 patches: http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01519.html - PR64344 - -fsanitize=float-cast-overflow fix - the C FE part is approved, but not the sanitizer bits outside of the FE http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01271.html - PR64265 - tsan

RE: [PATCH] Disable -fuse-caller-save when -pg is active

2015-01-05 Thread Moore, Catherine
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Radovan Obradovic Sent: Thursday, December 18, 2014 11:01 AM To: Jeff Law; gcc-patches@gcc.gnu.org Cc: Petar Jovanovic Subject: RE: [PATCH] Disable -fuse-caller-save when

RE: [PATCH] Don't check for optab for 16bit bswap

2015-01-05 Thread Thomas Preud'homme
From: Oleg Endo [mailto:oleg.e...@t-online.de] Sent: Tuesday, December 30, 2014 4:25 PM I've just tried disabling the 'rotlhi3' pattern and __builtin_bswap16 expands into shift + and + or (as expected). Thus, I don't think the patch will make something worse (than it already .L42:

Re: [PATCH, libgo]: Double StackMin size for 64bit non-split-stack targets

2015-01-05 Thread Ian Lance Taylor
On Wed, Dec 24, 2014 at 3:44 AM, Uros Bizjak ubiz...@gmail.com wrote: The attached patch doubles StackMin size for 64bit non-split-stack targets. This patch fixes regexp libgo failure (tracked as gcc PR61871 [1]) on alpha-linux-gnu. --cut here-- Index: runtime/proc.c

Re: [PATCH] Fix loop optimization when ZOL is not available in xtensa configuration

2015-01-05 Thread augustine.sterl...@gmail.com
On Mon, Dec 29, 2014 at 3:12 PM, Max Filippov jcmvb...@gmail.com wrote: Currently building gcc for xtensa configuration with XCHAL_HAVE_LOOPS set to 0 fails with the following error: xtensa.c:3952: undefined reference to `reorg_loops(bool, hw_doloop_hooks*)' Only compile target-specific

[PATCH] Fix einline ICE with EH (PR tree-optimization/64465)

2015-01-05 Thread Jakub Jelinek
Hi! The early inliner ICEs on the following testcase, because redirect_all_calls replaces a call to a function that could throw with __builtin_unreachable (and, note, it still has the bug that it doesn't drop the function arguments), but nothing cleans up the EH stuff for that change. During

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Jeff Law
On 01/05/15 00:44, Kito Cheng wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore instruction generation, the current LRA implementation will miss caller-save store/restore instruction if need one more

Re: Fix streaming of target optimization/option nodes

2015-01-05 Thread H.J. Lu
On Mon, Dec 22, 2014 at 3:02 AM, Thomas Schwinge tho...@codesourcery.com wrote: Hi! On Mon, 15 Dec 2014 23:36:11 +0100, Jan Hubicka hubi...@ucw.cz wrote: this is final version I comitted. PR lto/64043 * tree-streamer.c (preload_common_nodes): Skip preloading of

[PATCH] Fix SSA_NAME range info ICE (PR tree-optimization/64494)

2015-01-05 Thread Jakub Jelinek
Hi! The SSA_NAME range info consists of two fields, SSA_NAME_RANGE_INFO pointer and SSA_NAME_ANTI_RANGE_P flag, but the recently added clearing of range info cleared just SSA_NAME_RANGE_INFO, leading to ICE on the following testcase where we asserted that SSA_NAME_ANTI_RANGE_P flag is cleared on

Re: [PATCH] Disable -fuse-caller-save when -pg is active

2015-01-05 Thread Jeff Law
On 01/05/15 07:48, Moore, Catherine wrote: -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Radovan Obradovic Sent: Thursday, December 18, 2014 11:01 AM To: Jeff Law; gcc-patches@gcc.gnu.org Cc: Petar Jovanovic Subject: RE:

Re: [BUILDROBOT, PATCH] config-list.mk: Extract target name correctly

2015-01-05 Thread Jeff Law
On 12/29/14 13:02, Jan-Benedict Glaw wrote: Hi! With my last change, `sed' is used to cut out the target name from a listed target. Since there may be additional OPTions encoded in the target, I tried to get only the first submatch before an `OPT'. However, `sed' uses longest match, so I'm

Re: [PATCH] Fix einline ICE with EH (PR tree-optimization/64465)

2015-01-05 Thread Jan Hubicka
Hi! The early inliner ICEs on the following testcase, because redirect_all_calls replaces a call to a function that could throw with __builtin_unreachable (and, note, it still has the bug that it doesn't drop the function arguments), but nothing cleans up the EH stuff for that change.

[PATCH] -f{no-sanitize,{,no-}sanitize-recover}=all support

2015-01-05 Thread Jakub Jelinek
On Tue, Dec 23, 2014 at 04:47:06PM -0800, Alexey Samsonov wrote: Right, -fsanitize=all produces an error, while -fsanitize-recover=all enables recovery for all sanitizers, -fno-sanitize-recover=all disables recovery for everything. Ok, here is a GCC patch for that. -fno-sanitize=all is

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 10:23:57PM +0100, Jakub Jelinek wrote: On Mon, Jan 05, 2015 at 03:16:46PM -0500, John David Anglin wrote: I think there may be one situation after reload that's not handled by the above. frame_read is only used for const calls. What about the situation where we

Re: Patch ping

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 02:27:41PM -0700, Jeff Law wrote: On 01/05/15 06:53, Jakub Jelinek wrote: Hi! I'd like to ping 3 patches: http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01519.html - PR64344 - -fsanitize=float-cast-overflow fix - the C FE part is approved, but not the

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-05 Thread Mike Stump
On Jan 5, 2015, at 12:58 PM, Mike Stump mikest...@comcast.net wrote: So, to help you out, I tried my hand at wiring up the extra library code: So, my tsan build finally finished, and I could try this with a real test case. I ran it 20 times, and got 11 fails with: $ i=20; while let i--; do

Re: [PATCH] -f{no-sanitize,{,no-}sanitize-recover}=all support

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 10:40:37PM +0100, Jakub Jelinek wrote: Are there any doc updates that need to happen as a result of this patch? Patch itself is fine for the trunk, just want to make sure the doc side is good too. You're right, I'll add documentation tomorrow and repost the patch.

Re: [PING] Add refers_to_regno_p overload to simplify callers

2015-01-05 Thread Oleg Endo
On Mon, 2015-01-05 at 12:48 -0700, Jeff Law wrote: On 01/03/15 05:18, Oleg Endo wrote: https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01730.html On Sun, 2014-12-21 at 23:02 +0100, Oleg Endo wrote: Hi, It seems that quite some callers of refers_to_regno_p are interested in testing a

[doc, committed] invoke.texi markup fixes

2015-01-05 Thread Sandra Loosemore
This is another one of my boring tech-writer-ish patches to the GCC user documentation. I noticed that there were numerous places in invoke.texi using @code markup instead of the more specific @option, @file, or @command markup, or in contexts where most other places in the manual use @samp.

Re: [doc, committed] invoke.texi markup fixes

2015-01-05 Thread Joseph Myers
On Mon, 5 Jan 2015, Sandra Loosemore wrote: @file is used for file names. For standard headers, the use of @code{header.h} (inttypes.h and limits.h, in this patch) is deliberate, reflecting that the C standard does not require headers to correspond to files and that the use of files to

[MIPS] Re-enable ABI-ISA inference

2015-01-05 Thread Matthew Fortune
The R6 patch introduced MIPS_ISA_LEVEL_SPEC into DRIVER_SELF_SPECS for all configurations. One part of MIPS_ISA_LEVEL_SPEC is however incompatible with those configurations which infer an ISA from an ABI without specifically setting the default ISAs using --with-arch-[32|64]. I.e. a generic

Re: [hsa] HSA: support for direct function call is introduced.

2015-01-05 Thread Eric Botcazou
Thank you for your notes, I'm just going to apply following patch with changed ChangeLog entries. Thanks! -- Eric Botcazou

Re: Patch ping

2015-01-05 Thread Jeff Law
On 01/05/15 06:53, Jakub Jelinek wrote: Hi! I'd like to ping 3 patches: http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01519.html - PR64344 - -fsanitize=float-cast-overflow fix - the C FE part is approved, but not the sanitizer bits outside of the FE OK.

Minor comment tweak in config/nds32/nds32-peephole2.md

2015-01-05 Thread Eric Botcazou
I think that we don't want new define_peephole's at this point. Applied on the mainline as obvious. 2015-01-05 Eric Botcazou ebotca...@adacore.com * config/nds32/nds32-peephole2.md: Do not mention define_peephole. -- Eric BotcazouIndex: config/nds32/nds32-peephole2.md

Re: [Patch][testsuite] Fix a few test cases

2015-01-05 Thread Jeff Law
On 12/12/14 12:38, Ryan Mansfield wrote: Hi, Here are a few test tweaks. In 921202-1.c, if STACK_SIZE is used then VLEN will blow the stack with 64bit longs. e.g. if STACK_SIZE == 512K then 3 arrays of 32767 longs means at a minimum 767K of stack will be used at -O0. In pr51447.c, the rbx

Re: [PATCH] -f{no-sanitize,{,no-}sanitize-recover}=all support

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 01:32:42PM -0700, Jeff Law wrote: On 01/05/15 09:58, Jakub Jelinek wrote: On Tue, Dec 23, 2014 at 04:47:06PM -0800, Alexey Samsonov wrote: Right, -fsanitize=all produces an error, while -fsanitize-recover=all enables recovery for all sanitizers,

Re: [PATCH] Fix loop optimization when ZOL is not available in xtensa configuration

2015-01-05 Thread Max Filippov
On Mon, Jan 5, 2015 at 7:21 PM, augustine.sterl...@gmail.com augustine.sterl...@gmail.com wrote: [Adding Felix] On Mon, Dec 29, 2014 at 3:12 PM, Max Filippov jcmvb...@gmail.com wrote: Currently building gcc for xtensa configuration with XCHAL_HAVE_LOOPS set to 0 fails with the following

Housekeeping work in backends.html

2015-01-05 Thread Eric Botcazou
Hi, the attached patch removes obsolete ports (c4x, m68hc11 and ms1), toggles the 'p' letter and adjust accordingly (only avr, fr30, m68k, mcore, rs6000 and sh still use define_peephole) and removes trailing spaces. OK to commit? Some ports are missing (lm32, moxie, nios2, nvptx, rl78, rx) so

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Vladimir Makarov
On 2015-01-05 12:31 PM, Jeff Law wrote: On 01/05/15 00:44, Kito Cheng wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore instruction generation, the current LRA implementation will miss caller-save

Re: [PATCH] Cleaning up incomplete type warning.

2015-01-05 Thread Manuel López-Ibáñez
On 5 January 2015 at 21:14, Jeff Law l...@redhat.com wrote: ps. I'm sure someone will complain that we've changed this warning message ever-so-slightly mucking up whatever code out there that parses warning/error messages. I honestly wonder what could be the purpose of parsing specific

[PATCH], rs6000, PR 64505 -- Fix issue with -m32 -mpowerpc64

2015-01-05 Thread Michael Meissner
This patch fixes PR 64505, which is an issue that one of the users of the Advance Toolchain found where -m32 -mpowerpc64 generated an insn not found message in some cases. I traced this down to rs6000_secondary_reload generating a reload helper that uses a DImode scratch register, when in this

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-05 Thread Bin.Cheng
On Tue, Jan 6, 2015 at 7:36 AM, Vladimir Makarov vmaka...@redhat.com wrote: On 2015-01-05 12:31 PM, Jeff Law wrote: On 01/05/15 00:44, Kito Cheng wrote: Hi Vladimir: This patch has a discusses with you in May 2014, this patch is about the caller-save register store and restore

RE: [PATCH] Disable -fuse-caller-save when -pg is active

2015-01-05 Thread Moore, Catherine
-Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Monday, January 05, 2015 12:07 PM To: Moore, Catherine; Radovan Obradovic; gcc-patches@gcc.gnu.org Cc: Petar Jovanovic Subject: Re: [PATCH] Disable -fuse-caller-save when -pg is active On 01/05/15 07:48, Moore,

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

2015-01-05 Thread Chen Gang S
On 1/6/15 04:07, Jeff Law wrote: On 12/28/14 21:04, Chen Gang S wrote: When failure occurs, random_seed may not be 0, so need reset it to 0 manually, or will let the next call init_random_seed() incorrect. The related warning: g++ -c -DTARGET_NAME=\parisc-gchen-linux\ -g -O2 -DIN_GCC

Patch ping and question about copyright assignment

2015-01-05 Thread Mikhail Maltsev
Hi, all! I'm pinging about this patch: https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01925.html (PR c/48956) I know that maybe it's too early for sending a ping (less than 2 weeks), but I also have a question regarding my patch: Is this patch considered small enough to be accepted without

RE: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-05 Thread Bernd Edlinger
Hi Mike, On Mon, 5 Jan 2015 14:01:42, Mike Stump wrote: On Jan 5, 2015, at 12:58 PM, Mike Stump mikest...@comcast.net wrote: So, to help you out, I tried my hand at wiring up the extra library code: So, my tsan build finally finished, and I could try this with a real test case. I ran it

Go patch committed: Use receiver type name in type descriptor name

2015-01-05 Thread Ian Lance Taylor
If different named types have methods with the same name, and the methods with the same name define nested types with the same name, the type descriptors for those nested types could collide at link time. This patch by Chris Manghane fixes the problem. This is issue 33 in the gofrontend issue

RE: [PATCH] Disable -fuse-caller-save when -pg is active

2015-01-05 Thread Hans-Peter Nilsson
On Fri, 14 Nov 2014, Radovan Obradovic wrote: index eb37bfe..ddaf8e0 100644 --- a/gcc/toplev.c +++ b/gcc/toplev.c @@ -1605,6 +1612,11 @@ process_options (void) /* Save the current optimization options. */ optimization_default_node = build_optimization_node (global_options);

Re: [doc, committed] invoke.texi markup fixes

2015-01-05 Thread Sandra Loosemore
On 01/05/2015 03:57 PM, Joseph Myers wrote: On Mon, 5 Jan 2015, Sandra Loosemore wrote: @file is used for file names. For standard headers, the use of @code{header.h} (inttypes.h and limits.h, in this patch) is deliberate, reflecting that the C standard does not require headers to correspond

Re: [PATCH], rs6000, PR 64505 -- Fix issue with -m32 -mpowerpc64

2015-01-05 Thread Segher Boessenkool
On Mon, Jan 05, 2015 at 07:50:33PM -0500, Michael Meissner wrote: This patch fixes PR 64505, which is an issue that one of the users of the Advance Toolchain found where -m32 -mpowerpc64 generated an insn not found message in some cases. I traced this down to rs6000_secondary_reload

Re: Minor comment tweak in config/nds32/nds32-peephole2.md

2015-01-05 Thread Chung-Ju Wu
2015-01-06 7:27 GMT+08:00 Eric Botcazou ebotca...@adacore.com: I think that we don't want new define_peephole's at this point. Applied on the mainline as obvious. 2015-01-05 Eric Botcazou ebotca...@adacore.com * config/nds32/nds32-peephole2.md: Do not mention define_peephole.

Re: *ping* [patch, fortran] Fix for PR 47676

2015-01-05 Thread Marek Polacek
On Mon, Jan 05, 2015 at 12:51:55PM +0100, Thomas Koenig wrote: Am 30.12.2014 um 01:25 schrieb Thomas Koenig: Hello world, this patch fixes the long-standing bug. A missing temporary causes an invalid read in realloc_on_assign_5.f03 which only becomes noticable when setting

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-05 Thread Jeff Law
On 01/03/15 06:49, Bernd Edlinger wrote: Hi, I was experimenting with enabling TSAN for Ada recently. I think this gives rather interesting results. The Instrumentation worked almost out of the box, we just have the problem that it is not gimple-OK to fold something like VIEW_CONVERT_EXPR(x),

Re: [PATCH] toplev.c: Process the failure when read fails for random_seed

2015-01-05 Thread Jeff Law
On 12/28/14 21:04, Chen Gang S wrote: When failure occurs, random_seed may not be 0, so need reset it to 0 manually, or will let the next call init_random_seed() incorrect. The related warning: g++ -c -DTARGET_NAME=\parisc-gchen-linux\ -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE

Re: [PATCH] Cleaning up incomplete type warning.

2015-01-05 Thread Jeff Law
On 12/24/14 11:07, Luis Felipe Strano Moraes wrote: This removes an unnecessary static variable from the code and also makes it a single warning instead of two. Patch originally proposed by Manuel López-Ibáñez. Luis Strano clean_incomplete_warning.log gcc/c/ChangeLog: 2014-12-24 Luis

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-05 Thread John David Anglin
On 1/5/2015 1:51 PM, Jakub Jelinek wrote: So isn't the right replacement for the target hook H.J. wanted to add the HARD_FRAME_POINTER_IS_ARG_POINTER macro? If argp is not hfp, then the stores through argp are not considered to be based on the frame pointer, if it is the same thing, such as on

Re: libsanitizer merge from upstream r221802

2015-01-05 Thread Christophe Lyon
On 31 December 2014 at 13:29, David Abdurachmanov david.abdurachma...@gmail.com wrote: On Dec 30, 2014, at 11:48 PM, Andrew Pinski wrote: If we have 64-bit kernel and 64-bit application is executed sys_getresuid is used for getresuid syscall, otherwise if 32-bit application is executed --

Re: [x86, PATCH] operand reordering for commutative operations

2015-01-05 Thread Jeff Law
On 12/29/14 06:30, Yuri Rumyantsev wrote: Hi All, Here is a patch which fixed several performance degradation after operand canonicalization (r216728). Very simple approach is used - if operation is commutative and its second operand required more operations (statements) for computation, swap

Re: [PATCH] simplify-rtx: Generalize (and X (ior (not X) Y) - (and X Y)

2015-01-05 Thread Jeff Law
On 12/24/14 10:05, Segher Boessenkool wrote: The existing transform (and X (ior (not X) Y) - (and X Y) has two shortcomings: it only handles identical RTX for X, i.e. registers, not e.g. subregs of registers; and it only handles the case where the NOT is the first arm of the IOR (it can be

Re: [PATCH] combine: Correct cost calculation and display for split I2

2015-01-05 Thread Jeff Law
On 12/24/14 10:04, Segher Boessenkool wrote: If we have split a parallel I2 to two insns, we will count its RTL cost twice. This currently does not matter since the cost is 0 always (it is not a single set insn), but let's fix it anyway. Also do not display the fake I1 in the cost calculation

Patch committed: Go backports to gcc 4.9 branch

2015-01-05 Thread Ian Lance Taylor
I've backported a few Go-specific patches to the GCC 4.9 branch. https://codereview.appspot.com/154800044 compiler: Recognize 64-bit symbol tables in archives. By Dominik Vogt. 2014-11-21 Lynn Boger labo...@linux.vnet.ibm.com * go.test/go-test.exp (go-set-goarch):

Re: [PATCH] Fix einline ICE with EH (PR tree-optimization/64465)

2015-01-05 Thread Jan Hubicka
On Mon, Jan 05, 2015 at 07:38:20PM +0100, Richard Biener wrote: During function versioning fixup_cfg pass is supposed to handle that, during IPA inlining there is explicit call to execute_fixup_cfg, but during early inlining there is not. I am still confused why early inliner does

Re: [PATCH] -f{no-sanitize,{,no-}sanitize-recover}=all support

2015-01-05 Thread Jeff Law
On 01/05/15 09:58, Jakub Jelinek wrote: On Tue, Dec 23, 2014 at 04:47:06PM -0800, Alexey Samsonov wrote: Right, -fsanitize=all produces an error, while -fsanitize-recover=all enables recovery for all sanitizers, -fno-sanitize-recover=all disables recovery for everything. Ok, here is a GCC

Re: [PATCH] Fix einline ICE with EH (PR tree-optimization/64465)

2015-01-05 Thread Richard Biener
On January 5, 2015 6:37:20 PM CET, Jan Hubicka hubi...@ucw.cz wrote: Hi! The early inliner ICEs on the following testcase, because redirect_all_calls replaces a call to a function that could throw with __builtin_unreachable (and, note, it still has the bug that it doesn't drop the function

Re: [PATCH] Fix SSA_NAME range info ICE (PR tree-optimization/64494)

2015-01-05 Thread Richard Biener
On January 5, 2015 6:01:41 PM CET, Jakub Jelinek ja...@redhat.com wrote: Hi! The SSA_NAME range info consists of two fields, SSA_NAME_RANGE_INFO pointer and SSA_NAME_ANTI_RANGE_P flag, but the recently added clearing of range info cleared just SSA_NAME_RANGE_INFO, leading to ICE on the following

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 07:19:33AM -0700, Jeff Law wrote: On 01/04/15 10:16, Richard Biener wrote: But either your new hook or the original fix makes no sense. All I want is to restore the old behavior on x86. If the original fix makes no sense, should it be reverted? I think the

Re: [patch, fortran] Fix for PR 47676

2015-01-05 Thread H.J. Lu
On Mon, Dec 29, 2014 at 4:25 PM, Thomas Koenig tkoe...@netcologne.de wrote: Hello world, this patch fixes the long-standing bug. A missing temporary causes an invalid read in realloc_on_assign_5.f03 which only becomes noticable when setting MALLOC_CHECK_ or when using valgrind. The bug has

Re: [PATCH] Fix einline ICE with EH (PR tree-optimization/64465)

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 07:38:20PM +0100, Richard Biener wrote: During function versioning fixup_cfg pass is supposed to handle that, during IPA inlining there is explicit call to execute_fixup_cfg, but during early inlining there is not. I am still confused why early inliner does any

[debug-early] remove unused argument from check_die

2015-01-05 Thread Aldy Hernandez
Committed to branch. commit d176e84cc283bb0505e487341128b6f48599199d Author: Aldy Hernandez al...@redhat.com Date: Mon Jan 5 11:06:44 2015 -0800 * dwarf2out.c (check_die): Remove level argument. (dwarf2out_decl): Remove level argument to check_die. diff --git a/gcc/dwarf2out.c

Re: [PATCH, libgo] Backport fix for compiler flags in mksysinfo.sh to gcc 4.9

2015-01-05 Thread Lynn A. Boger
This one should not be backported. It was submitted but not added upstream. Sorry for the confusion. On 12/30/2014 01:33 PM, Lynn A. Boger wrote: Hi, Please backport the change from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00713.html to gcc 4.9. 2014-12-30 Lynn Boger

Re: [patch, fortran] Fix for PR 47676

2015-01-05 Thread Thomas Koenig
Am 05.01.2015 um 19:55 schrieb H.J. Lu: On Linux/x86, I got ../../src-trunk/gcc/fortran/frontend-passes.c: In function ‘int realloc_string_callback(gfc_code**, int*, void*)’: ../../src-trunk/gcc/fortran/frontend-passes.c:152:38: error: ‘gfc_discard_nops’ was not declared in this scope

[C++ PATCH] PR c++/64489

2015-01-05 Thread Ville Voutilainen
Tested on Linux-x64. /cp 2015-01-05 Ville Voutilainen ville.voutilai...@gmail.com PR c++/64489 * class.c (check_field_decls): Make copy assignment operators complex only in c++98 mode. /testsuite 2015-01-05 Ville Voutilainen ville.voutilai...@gmail.com PR c++/64489 *

Re: [PATCH] Fix PR c++/59366 A friend function template defined in a class is found without ADL

2015-01-05 Thread Momchil Velikov
is OK, then, but still needs ChangeLog and testcase. Jason Bootstrapped/tested again with: Target: x86_64-unknown-linux-gnu Configured with: /home/chill/src/gcc-master/configure --prefix=/home/chill/opt/gcc-master --enable-languages=c,c++ Thread model: posix gcc version 5.0.0 20150105

Re: [PATCH 3/4] Add Visium support to gcc

2015-01-05 Thread Jeff Law
On 01/03/15 08:16, Eric Botcazou wrote: I'm a little concerned about the MODES_TIEABLE_P definition, but if it's working, I wouldn't mess with it. Could you elaborate? Do you find it too restrictive? I'm a little concerned it's too loose. Basically it says that if both modes are integer

Re: [PING] Add refers_to_regno_p overload to simplify callers

2015-01-05 Thread Jeff Law
On 01/03/15 05:18, Oleg Endo wrote: https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01730.html On Sun, 2014-12-21 at 23:02 +0100, Oleg Endo wrote: Hi, It seems that quite some callers of refers_to_regno_p are interested in testing a single register number only. The caller code can be

Re: [PATCH, i386] Remove EBX usage from asm code

2015-01-05 Thread Jeff Law
On 12/28/14 09:46, Evgeny Stupachenko wrote: Hi, The patch removes EBX usage from asm code used in libgcc/crtstuff.c It is safe now, but potentially buggy when glibc is rebuild with GCC 5.0 as EBX is not GOT register any more. x86 bootstrap, make check passed. Is it ok? Evgeny 2014-12-28

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-05 Thread Mike Stump
On Jan 5, 2015, at 12:49 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: On Sun, 4 Jan 2015 14:18:59, Mike Stump wrote: But tsan still gets at least 90% chance to spot that. As a matter of fact, the tsan runtime is just _incredibly_ fast, and catches errors, with a very high

RE: [PATCH] Don't check for optab for 16bit bswap

2015-01-05 Thread Oleg Endo
On Mon, 2015-01-05 at 14:54 +, Thomas Preud'homme wrote: From: Oleg Endo [mailto:oleg.e...@t-online.de] Sent: Tuesday, December 30, 2014 4:25 PM I've just tried disabling the 'rotlhi3' pattern and __builtin_bswap16 expands into shift + and + or (as expected). Thus, I don't think

Re: [PATCH 3/4] Add Visium support to gcc

2015-01-05 Thread Eric Botcazou
I'm a little concerned it's too loose. Basically it says that if both modes are integer modes, then they're tieable. However, HARD_REGNO_MODE_OK may return different values for MODE1 and MODE2, even if both are integer modes. My recollection is if MODES_TIEABLE_P returns true for mode1

RE: [PATCH] Don't check for optab for 16bit bswap

2015-01-05 Thread Richard Biener
On January 5, 2015 3:54:40 PM CET, Thomas Preud'homme thomas.preudho...@arm.com wrote: From: Oleg Endo [mailto:oleg.e...@t-online.de] Sent: Tuesday, December 30, 2014 4:25 PM I've just tried disabling the 'rotlhi3' pattern and __builtin_bswap16 expands into shift + and + or (as expected).

Re: [PATCH] gcc/testsuite/gcc.dg/typeof-2.c

2015-01-05 Thread Jeff Law
On 12/15/14 00:26, Sebastian Huber wrote: gcc/testsuite/ChangeLog 2014-12-15 Sebastian Huber sebastian.hu...@embedded-brains.de * gcc.dg/typeof-2.c: Add checks for non-atomic types. OK for the trunk. Please install. Thanks, Jeff

Re: [PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-05 Thread Mike Stump
On Dec 24, 2014, at 9:28 AM, Dimitris Papavasiliou dpapa...@gmail.com wrote: The attached patch fixes an issue reported a couple of years ago in Bug 51891 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51891). The problem is caused because classes without instance variables have no ivar list

Re: PATCH: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

2015-01-05 Thread Jakub Jelinek
On Mon, Jan 05, 2015 at 03:16:46PM -0500, John David Anglin wrote: I think there may be one situation after reload that's not handled by the above. frame_read is only used for const calls. What about the situation where we have a non const sibcall and the frame pointer isn't eliminated?