[PATCH, RFC] LRA subreg handling

2015-01-14 Thread Robert Suchanek
Hi Vladimir, An issue has been identified with LRA when running CPU2006 h264ref benchmark. I'll try to describe what the issue is and a fix applied as it is very difficult to reproduce it and it is next to impossible to create a narrowed testcase on top of the source code restrictions. The

[debug-early] fix C++ mangling issues with deferred_asm_name removal

2015-01-14 Thread Aldy Hernandez
There were some -fcompare-debug regressions when I removed the deferred_asm_name auxiliary data structure from dwarf2out. Jason was kind enough to tackle them (or at least the main one). Apparently there was some bug in the mangling code that necessitated the entire deferred_asm_name vector.

RE: [MIPS] Update the ZC constraint for MIPSR6 and use it

2015-01-14 Thread Moore, Catherine
-Original Message- From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] Sent: Wednesday, January 14, 2015 2:54 PM To: Moore, Catherine Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) Subject: RE: [MIPS] Update the ZC constraint for MIPSR6 and use it Moore, Catherine

Re: [PATCH] add option to emit more array bounds warnigs

2015-01-14 Thread Jeff Law
On 01/14/15 00:48, Martin Uecker wrote: If you plan to contribute regularly, you should go ahead and apply for write access to the repository so that you'll be able to commit your own patches once they're approved. I put a request in with you as sponsor (hope this is ok). Of course.

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-14 Thread Ian Lance Taylor
On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast patrick.wollg...@rub.de wrote: A short recap again: Latest patch, changelog and a test program (further information about the program in the mail): https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html In that patch, the change to varasm.c

RE: [MIPS] Update the ZC constraint for MIPSR6 and use it

2015-01-14 Thread Matthew Fortune
Moore, Catherine catherine_mo...@mentor.com writes Hi Matthew, -Original Message- From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] Sent: Tuesday, January 06, 2015 7:43 AM To: Moore, Catherine Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) Subject: [MIPS]

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-14 Thread Patrick Wollgast
On 14.01.2015 20:00, Ian Lance Taylor wrote: On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast patrick.wollg...@rub.de wrote: A short recap again: Latest patch, changelog and a test program (further information about the program in the mail):

Re: [RFC] Tighten memory type assumption in RTL combiner pass.

2015-01-14 Thread Jeff Law
On 01/14/15 04:27, Venkataramanan Kumar wrote: Hi all, When trying to debug GCC combiner pass with the test case in PR63949 ref https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63949 I came across this code. This code in make_compound_operation assumes that all PLUS and MINUS RTX are MEM type for

RE: [PATCH] Allow MIPS call-saved-{4-6}.c tests to correctly run for micromips

2015-01-14 Thread Matthew Fortune
Richard Sandiford rdsandif...@googlemail.com writes: Maciej W. Rozycki ma...@linux-mips.org writes: On Wed, 14 Jan 2015, Richard Sandiford wrote: I think we just have to accept that there are so many possible combinations that we can't test everything that's potentially relevant. I think

Re: [C++ Patch/RFC] PR 58671

2015-01-14 Thread Jason Merrill
On 01/14/2015 10:08 AM, Paolo Carlini wrote: I can look again, but as far as I remember nothing is clearing it, it just stay false because the ICE happens while we process the 'i' on the right hand side and the DECL_INITIALIZED_P becomes true only in cp_finish_decl. Ah, please say that in the

Re: [PATCH] PR59448 - Promote consume to acquire

2015-01-14 Thread Andrew MacLeod
On 01/14/2015 01:28 PM, Joseph Myers wrote: On Wed, 14 Jan 2015, Andrew MacLeod wrote: - There is a warning for invalid memory models already, so I just continued using that. - I remove the check for CONSUME in exchange since the current standard makes no mention of that being illegal. - I

Re: [PATCH] Correct target selector in -mfentry tests

2015-01-14 Thread Jeff Law
On 01/14/15 04:38, H.J. Lu wrote: On Tue, Jan 13, 2015 at 11:15 PM, Jeff Law l...@redhat.com wrote: On 01/13/15 14:27, H.J. Lu wrote: -fprofile -mfentry works with PIE if gcrt1.o is compiled with -fPIC. A glibc has been filed, PR 17836, and a glibc patch has been submitted. OK for trunk?

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-14 Thread Jeff Law
On 01/14/15 10:10, Robert Suchanek wrote: Here is the revised patch that would handle the other cases as per Richard's comments. I slightly modified Matthew's proposed patch and used split_const instead of get_related_value. AFAICS, the canonical form would always have the 'plus' expression.

Re: Patch ping...

2015-01-14 Thread Jason Merrill
On 01/14/2015 12:30 AM, Jan Hubicka wrote: I would like to ping the patch to fix divergence between a type and its main variant introduced by C++ FE. OK. Jason

Re: [PATCH][testsuite] Fix oversized bitfield warning.

2015-01-14 Thread Jeff Law
On 01/14/15 03:54, Matthew Wahab wrote: Hello, Test case g++.dg/torture/20141013.C (added https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01190.html) triggers the warning -- 20141013.C:45:23: warning: width of 'tree_base::code' exceeds its type -- on arm-none-eabi. The code specifies a

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-14 Thread Richard Sandiford
Robert Suchanek robert.sucha...@imgtec.com writes: Here is the revised patch that would handle the other cases as per Richard's comments. I slightly modified Matthew's proposed patch and used split_const instead of get_related_value. AFAICS, the canonical form would always have the 'plus'

Re: [PATCH] Allow MIPS call-saved-{4-6}.c tests to correctly run for micromips

2015-01-14 Thread Richard Sandiford
Maciej W. Rozycki ma...@linux-mips.org writes: On Wed, 14 Jan 2015, Richard Sandiford wrote: Taking care that the default compilation mode does not conflict (e.g. MIPS16, incompatible) and taking any exceptions into account (e.g. n64, unsupported) I presume, right? mips.exp sorts

RE: [MIPS] Update the ZC constraint for MIPSR6 and use it

2015-01-14 Thread Matthew Fortune
Moore, Catherine catherine_mo...@mentor.com writes: -Original Message- From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] Sent: Wednesday, January 14, 2015 2:54 PM To: Moore, Catherine Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) Subject: RE: [MIPS] Update the

[RFC] POWER8 default for PPC64LE

2015-01-14 Thread David Edelsohn
The PPC64LE ABI specifies POWER8 ISA as the minimum hardware requierment. Currently, Linux distributions are building the toolchain using --with-cpu=power7 or power8, as they wish. GCC defaults to essentially the POWER4 ISA. The appended patch changes the default for PPC64LE to POWER8 (ISA

Re: Patch RFA: Support for building Go tools

2015-01-14 Thread Uros Bizjak
Hello! This patch adds support to the GCC tree for building tools that are used with Go. There are two external used tools (go, gofmt) and one tool used internally by go (cgo). This patch is pure machinery, with no source code. The tools are not built by default, only when go is enabled

RE: [MIPS] Update the ZC constraint for MIPSR6 and use it

2015-01-14 Thread Moore, Catherine
Hi Matthew, -Original Message- From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] Sent: Tuesday, January 06, 2015 7:43 AM To: Moore, Catherine Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) Subject: [MIPS] Update the ZC constraint for MIPSR6 and use it Update the

Re: [RFC] POWER8 default for PPC64LE

2015-01-14 Thread Jeff Law
On 01/14/15 13:32, David Edelsohn wrote: The PPC64LE ABI specifies POWER8 ISA as the minimum hardware requierment. Currently, Linux distributions are building the toolchain using --with-cpu=power7 or power8, as they wish. GCC defaults to essentially the POWER4 ISA. The appended patch changes

Re: [PATCH] Fix PR c++/16160

2015-01-14 Thread Jason Merrill
On 01/14/2015 11:28 AM, Patrick Palka wrote: Second, since the user probably intended to have written an explicit template instantiation (as in the PR), the FE should suggest adding template before such a declaration, that is the declaration struct X5; // error + suggest adding template

libgo patch committed: Update to Go 1.4

2015-01-14 Thread Ian Lance Taylor
I've committed a patch to libgo to update it to the Go 1.4 release, except for the runtime package. Much of the runtime package was rewritten in Go, and it does not really affect users of the library, so I've postponed that complex merge. All the other packages are updated. A few minor compiler

Re: [PATCH] testsuite/lib/target-supports.exp: Fix check_effective_target_lto

2015-01-14 Thread Ilya Verbin
On 12 Jan 14:30, Jeff Law wrote: On 01/11/15 12:26, Ilya Verbin wrote: On 09 Jan 10:29, Thomas Schwinge wrote: As this was the only use of ENABLE_LTO in the testsuite, I suggest to also remove it from the gcc/Makefile.in:site.exp rule. Done. Here is an updated and retested patch. OK for

Re: [PATCH][AArch64] Improve bit-test-branch pattern to avoid unnecessary register clobber

2015-01-14 Thread Richard Henderson
On 12/15/2014 07:36 AM, Jiong Wang wrote: + char buf[64]; + uint64_t val = ((uint64_t) 1) UINTVAL (operands[1]); + sprintf (buf, tst\t%%w0, %PRId64, val); + output_asm_insn (buf, operands); + return bcond\t%l2; Better to simply modify the operand, as in operands[1] =

[doc, committed] reclassify -fuse-ld= as a linker option

2015-01-14 Thread Sandra Loosemore
I noticed that -fuse-ld= was incorrectly classified as an optimization option in the manual. It's a driver-only option so it seems better to list it with the linker options. I've checked in this patch to move it (there's no change to the actual content of the documentation, just its

Fix spelling error in top level configure.ac

2015-01-14 Thread Joel Sherrill
Hi Not a huge patch. Just changes developement to development in a comment and error message. The larger issue is that it is in the top level configure.ac. :) OK to comment and where? 2015-01-14 Joel Sherrill joel.sherr...@oarcorp.com * configure.ac: Fix spelling error. * configure:

[SH][committed] PR 53988 - Fix wrong code

2015-01-14 Thread Oleg Endo
Hi, The attached patch fixes a wrong-code issue which was the result of the initial fix for PR 53988. Tested with make -k check RUNTESTFLAGS=--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} and no new failures. Committed as 219623. Backports to 4.8 and 4.9

libgo patch committed: Bump version number

2015-01-14 Thread Ian Lance Taylor
This patch bumps the version number of libgo, giving it a new soname. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 530a9509c45c -r bdf59f9cfda8 libgo/configure.ac --- a/libgo/configure.acWed Jan 14 16:11:24 2015 -0800 +++ b/libgo/configure.acWed

RFA: patch to fix a bad code generation for PR64110 -- new constraints addition

2015-01-14 Thread Vladimir Makarov
The problem of unexpected code generation is discussed on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64110 The following patch introduces 2 new constraints '^' and '$' which are analogous to '?' and '!' but disfavor given alternative when *the operand with the new constraint* needs a

Re: [COMMITTED] Merge libffi with upstream

2015-01-14 Thread H.J. Lu
On Mon, Jan 12, 2015 at 8:34 AM, Richard Henderson r...@redhat.com wrote: Upstream libffi has added support for Go closures (using the static chain), and support for complex numbers. Perhaps less relevant is new support for arc, microblaze, moxie, nios, and or1k targets. Without additional

RE: [PATCH,MIPS] Remove all excess parallel constructs

2015-01-14 Thread Moore, Catherine
-Original Message- From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] Sent: Monday, January 12, 2015 11:12 AM To: Moore, Catherine Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) Subject: [PATCH,MIPS] Remove all excess parallel constructs *

libgo patch committed: Add missing files

2015-01-14 Thread Ian Lance Taylor
Somehow two files were omitted from the last commit upgrading to 1.4. This adds them. Committed to mainline. Ian Index: libgo/go/crypto/tls/testdata/Server-TLSv12-IssueTicketPreDisable === ---

RE: [PATCH,MIPS] Add support for the R6 LSA and DLSA instructions

2015-01-14 Thread Moore, Catherine
-Original Message- From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] Sent: Monday, January 12, 2015 10:35 AM To: Moore, Catherine Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) Subject: [PATCH,MIPS] Add support for the R6 LSA and DLSA instructions This patch

[PATCH 2/5] rs6000: Fix TARGET_PROMOTE_FUNCTION_MODE

2015-01-14 Thread Segher Boessenkool
As the existing comment explains, we should always promote function arguments and return values. However, notwithstanding its name, default_promote_function_mode_always_promote does not always promote. Importantly, it does not for libcalls. This makes ftrapv-[12].c fail with 64-bit ABIs. This

[PATCH 1/5] rs6000: Fix PROMOTE_MODE for -m32 -mpowerpc64

2015-01-14 Thread Segher Boessenkool
UNITS_PER_WORD is 8 with -m32 -mpowerpc64. Promoting items smaller than 8 bytes to 4 bytes doesn't make sense. I tried to fix it the other way around first, promoting everything smaller than UNITS_PER_WORD to word_mode; this fails all over the place, because word_mode is bigger than Pmode. So

[PATCH 4/5] rs6000: Introducing rs6000_abi_word_mode

2015-01-14 Thread Segher Boessenkool
Some hooks return word_mode by default, which is incorrect for -m32 -mpowerpc64. This patch creates a new function rs6000_abi_word_mode to implement these hooks, and does so. This fixes 163 testuite FAILs. [ David already OKed this fixed version, but sending it again is easier for me. Lazy,

[Patch] Missing plugin header files

2015-01-14 Thread Steve Ellcey
I tried compiling an empty plugin that just included gcc-plugin.h and plugin-version.h and found that these header files were included from gcc-plugin.h but not in the list of header files to be copied to the plugin include directory. OK to checkin? Steve Ellcey sell...@imgtec.com 2015-01-14

[wwwdocs] Add porting_to.html for GCC 5 (again)

2015-01-14 Thread Marek Polacek
A few months ago I posted the porting to document for GCC 5. But I never got around to commit it, so here it is again, this time with feewing. I fixed description of GNU89 extern inline, added some more snippets, and mentioned -Wc9?-c??-compat warnings. I plan to commit this tomorrow. ---

[PATCH 3/5] rs6000: Fix va_start handling for -m32 -mpowerpc64 ABI_V4

2015-01-14 Thread Segher Boessenkool
This fixes 88 testsuite FAILs. -mpowerpc64 does not change the ABI, but it does change the value of UNITS_PER_WORD. This code is for 32-bit only so we can use MIN_UNITS_PER_WORD instead. Bootstrapped and tested as usual. Okay for mainline? Segher 2015-01-14 Segher Boessenkool

Re: [PATCH] Fix PR 61225

2015-01-14 Thread Jeff Law
On 12/10/14 06:47, Segher Boessenkool wrote: On Tue, Dec 09, 2014 at 12:15:30PM -0700, Jeff Law wrote: @@ -3323,7 +3396,11 @@ try_combine (rtx_insn *i3, rtx_insn *i2, rtx_insn *i1, rtx_insn *i0, rtx old = newpat; total_sets = 1 + extra_sets; newpat =

[PATCH committed] Sync include/libiberty.h with Binutils

2015-01-14 Thread Jan-Benedict Glaw
Hi! This pulls libiberty.h's copyright update from Binutils, so that the file is synced again. 2015-12-14 Jan-Benedict Glaw jbg...@lug-owl.de * libiberty.h: Merge Copyright year update from Binutils. diff --git a/include/ChangeLog b/include/ChangeLog index dbf2554..c1011b9

Re: [PATCH] Fix PR c++/16160

2015-01-14 Thread Patrick Palka
On Wed, Jan 14, 2015 at 4:28 PM, Jason Merrill ja...@redhat.com wrote: On 01/14/2015 11:28 AM, Patrick Palka wrote: Second, since the user probably intended to have written an explicit template instantiation (as in the PR), the FE should suggest adding template before such a declaration, that

Re: Patch: Some potential warnings for C++ bootstrap

2015-01-14 Thread Jeff Law
On 11/14/14 13:41, Kai Tietz wrote: Hello, this patch fixes some potential warnings for C++ bootstrap. I noticed them while working on the delayed folding for C++-FE on boostrap. ChangeLog 2014-11-14 Kai Tietz kti...@redhat.com * dwarf2out.c(output_loc_operands): Make sure that

Re: [PATCH/expand] PR64011 Adjust bitsize when partial overflow happen for big-endian

2015-01-14 Thread Jiong Wang
On 13/01/15 21:45, Jeff Law wrote: On 01/09/15 06:39, Jiong Wang wrote: the bug testcase is === typedef short U __attribute__((may_alias, aligned (1))); struct S { _Complex float d __attribute__((aligned (8))); }; void bar(struct S); void f5 (int x) { struct S s;

Re: [RFC] Tighten memory type assumption in RTL combiner pass.

2015-01-14 Thread Richard Henderson
On 01/14/2015 03:27 AM, Venkataramanan Kumar wrote: next_code = (code == MEM ? MEM : ((code == PLUS || code == MINUS) - SCALAR_INT_MODE_P (mode)) ? MEM + SCALAR_INT_MODE_P (mode) + (in_code == MEM)) ? MEM :

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-14 Thread Ian Lance Taylor
On Wed, Jan 14, 2015 at 12:28 PM, Patrick Wollgast patrick.wollg...@rub.de wrote: On 14.01.2015 20:00, Ian Lance Taylor wrote: On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast patrick.wollg...@rub.de wrote: A short recap again: Latest patch, changelog and a test program (further information

Re: [PATCH] Fix PR c++/16160

2015-01-14 Thread Jason Merrill
On 01/14/2015 05:04 PM, Patrick Palka wrote: Did this define a specialization too: struct X5 { }; Yes. There's an example in the ARM that says A class can be defined as the definition of a template class. For example, templateclass T class stream { /* ... */ }; class streamchar {

Re: [PATCH/expand] PR64011 Adjust bitsize when partial overflow happen for big-endian

2015-01-14 Thread Jeff Law
On 01/14/15 15:31, Jiong Wang wrote: agree, and I think the truncation is needed otherwise there may have ICE on some target. and I found current gcc LOCATION info is very good ! have done an experimental hack on at expand_assignment: 4931 where the tree is expanded, gcc could give quite

Re: RFA: patch to fix a bad code generation for PR64110 -- new constraints addition

2015-01-14 Thread Jeff Law
On 01/14/15 16:52, Vladimir Makarov wrote: The problem of unexpected code generation is discussed on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64110 The following patch introduces 2 new constraints '^' and '$' which are analogous to '?' and '!' but disfavor given alternative when

[Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant

2015-01-14 Thread Tim Shen
It's irony that I spent non-trivial effort to make sure basic_regex still works after imbuing. :) But now with this specification, the implementation can be cleaner (e.g. _M_original_str is removed). Bootstrapped and tested. I'll make a 4.9 patch later. Thanks! -- Regards, Tim Shen commit

Re: [PATCH] Reenable CSE of non-volatile inline asm (PR rtl-optimization/63637)

2015-01-14 Thread Jeff Law
On 01/14/15 08:19, Segher Boessenkool wrote: @findex clobber @item (clobber @var{x}) Represents the storing or possible storing of an unpredictable, undescribed value into @var{x}, which must be a @code{reg}, @code{scratch}, @code{parallel} or @code{mem} expression. [...] If @var{x} is

Re: [patch] gcc fstack-protector-explicit

2015-01-14 Thread Jeff Law
On 07/01/14 15:34, Daniel Gutson wrote: On Tue, Jul 1, 2014 at 2:25 PM, Jeff Law l...@redhat.com wrote: On 03/19/14 08:06, Marcos Díaz wrote: Well, finally I have the assignment, could you please review this patch? Thanks. My first thought was that if we've marked the function with an

[PATCH 5/5] rs6000: Do not allow TImode with -m32 -mpowerpc64

2015-01-14 Thread Segher Boessenkool
This fixes 141 FAILs. -mpowerpc64 does not change the ABI, but default_scalar_mode_supported_p does not know that, and allows TImode for -m32 -mpowerpc64. This fixes it. Okay for mainline? 2015-01-14 Segher Boessenkool seg...@kernel.crashing.org gcc/ * config/rs6000/rs6000.c

Re: [PATCH, RFC] LRA subreg handling

2015-01-14 Thread Jeff Law
On 01/14/15 12:20, Robert Suchanek wrote: Hi Vladimir, An issue has been identified with LRA when running CPU2006 h264ref benchmark. I'll try to describe what the issue is and a fix applied as it is very difficult to reproduce it and it is next to impossible to create a narrowed testcase on

Re: [PATCH 4/5] rs6000: Introducing rs6000_abi_word_mode

2015-01-14 Thread David Edelsohn
On Wed, Jan 14, 2015 at 8:14 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: Some hooks return word_mode by default, which is incorrect for -m32 -mpowerpc64. This patch creates a new function rs6000_abi_word_mode to implement these hooks, and does so. This fixes 163 testuite FAILs.

Re: [PATCH 3/5] rs6000: Fix va_start handling for -m32 -mpowerpc64 ABI_V4

2015-01-14 Thread David Edelsohn
On Wed, Jan 14, 2015 at 8:14 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: This fixes 88 testsuite FAILs. -mpowerpc64 does not change the ABI, but it does change the value of UNITS_PER_WORD. This code is for 32-bit only so we can use MIN_UNITS_PER_WORD instead. Bootstrapped and

Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant

2015-01-14 Thread Tim Shen
On Wed, Jan 14, 2015 at 8:53 PM, Tim Shen tims...@google.com wrote: I'll make a 4.9 patch later. Here it is. :) Bootstrapped and tested. -- Regards, Tim Shen commit 978246f3fb976d466d5735b43e416b77b750cd0d Author: timshen tims...@google.com Date: Wed Jan 14 01:35:22 2015 -0800 PR

Re: [PATCH 2/5] rs6000: Fix TARGET_PROMOTE_FUNCTION_MODE

2015-01-14 Thread David Edelsohn
On Wed, Jan 14, 2015 at 8:14 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: As the existing comment explains, we should always promote function arguments and return values. However, notwithstanding its name, default_promote_function_mode_always_promote does not always promote.

Re: [PATCH 1/5] rs6000: Fix PROMOTE_MODE for -m32 -mpowerpc64

2015-01-14 Thread David Edelsohn
On Wed, Jan 14, 2015 at 8:14 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: UNITS_PER_WORD is 8 with -m32 -mpowerpc64. Promoting items smaller than 8 bytes to 4 bytes doesn't make sense. I tried to fix it the other way around first, promoting everything smaller than UNITS_PER_WORD

Re: [PATCH 2/3, ARM, libgcc, ping6] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2015-01-14 Thread Richard Earnshaw
On 14/01/15 11:56, Thomas Preud'homme wrote: Ping? Sorry, not ok. These symbols pollute the global namespace, yet do not use reserved names. Secondly, in a shared library environment you need to ensure that these names remain private to the instance linked into the library, so that you don't

Re: [C++ Patch/RFC] PR 58671

2015-01-14 Thread Jason Merrill
On 01/14/2015 08:13 AM, Paolo Carlini wrote: in order to avoid ICEing in var_defined_without_dynamic_init for self-initialized thread_local vars, shall we simply return false for those? What is clearing DECL_INITIALIZED_P for such variables? Jason

Re: [PATCH] Fix parameters of __tsan_vptr_update

2015-01-14 Thread Dmitry Vyukov
Hi, Sorry for the delay, I was on a vacation. Is here anything to do/review for me? On Sun, Jan 11, 2015 at 4:15 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, On Sun, 4 Jan 2015 14:54:56, Bernd Edlinger wrote: Hi Jakub, I think I have found a reasonable test case, see the

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2015-01-14 Thread Martin Liška
On 12/22/2014 03:50 PM, Martin Liška wrote: On 12/18/2014 08:40 PM, Jan Hubicka wrote: 2014-12-08 Martin Liska mli...@suse.cz * cgraph.h (symbol_table::allocate_cgraph_symbol): Summary UID is filled up. * symbol-summary.h: New file. * gengtype.c (open_base_files): Add

[AArch64/GCC] PR64304, miscompilation with -mgeneral-regs-only

2015-01-14 Thread Jiong Wang
as discussed here https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00563.html the problem is aarch64 hardware only support left shift truncation for SI/DI, while SHIFT_COUNT_TRUNCATED is enabled for all mode including QI/HI, which is inconsistent with hardware feature. there are two patterns

Re: [C++ Patch/RFC] PR 58671

2015-01-14 Thread Paolo Carlini
Hi, On 01/14/2015 04:00 PM, Jason Merrill wrote: On 01/14/2015 08:13 AM, Paolo Carlini wrote: in order to avoid ICEing in var_defined_without_dynamic_init for self-initialized thread_local vars, shall we simply return false for those? What is clearing DECL_INITIALIZED_P for such variables?

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

2015-01-14 Thread Andre Vehreschild
Hi Tobias, hi Paul, hi all, sorry, for the mess. I did not understand the meaning of build_fold_indirect_ref in the circumstances Paul pointed out. So if no objections exist, I like to propose the previous patch from: https://gcc.gnu.org/ml/fortran/2015-01/msg00056.html to address the issue in

Re: shift/extract SHIFT_COUNT_TRUNCATED combine bug

2015-01-14 Thread Segher Boessenkool
On Wed, Jan 14, 2015 at 10:10:24AM +0100, Richard Biener wrote: On Tue, Jan 13, 2015 at 6:38 PM, Segher Boessenkool seg...@kernel.crashing.org wrote: On Tue, Jan 13, 2015 at 10:51:27AM +0100, Richard Biener wrote: IMHO SHIFT_COUNT_TRUNCATED should be removed and instead backends should

Re: RFC: Two minor optimization patterns

2015-01-14 Thread Richard Biener
On Wed, Jan 14, 2015 at 3:26 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 14 Jan 2015, Richard Biener wrote: On Wed, Jan 14, 2015 at 1:45 PM, Marc Glisse marc.gli...@inria.fr wrote: On Tue, 13 Jan 2015, Rasmus Villemoes wrote: diff --git gcc/match.pd gcc/match.pd index

Re: [PATCH 2/3] Extended if-conversion

2015-01-14 Thread Richard Biener
On Wed, Jan 14, 2015 at 2:14 PM, Yuri Rumyantsev ysrum...@gmail.com wrote: Richard, I did all changes proposed by you and add couple tests. Bootstrap, including aggressive one proposed by you, and regression testing did not show any new failures. Is it OK for trunk? +++

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2015-01-14 Thread Andrew Stubbs
On 14/01/15 08:21, Ramana Radhakrishnan wrote: Ok, that should be enough. Please watch out for any testing fallout this week. Committed, thanks. Andrew

Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

2015-01-14 Thread Lynn A. Boger
Yes, I have other options, I just wanted to verify that this was still your answer. Thanks. On 01/14/2015 09:24 AM, Ian Lance Taylor wrote: On Wed, Jan 14, 2015 at 5:49 AM, Lynn A. Boger labo...@linux.vnet.ibm.com wrote: I have an updated patch for the reflection functions in gcc 4.9 for

Re: [Patch, Fortran, F03] PR 58023: ICE on invalid with bad PPC declaration

2015-01-14 Thread Mikael Morin
Hello Janus, Le 13/01/2015 22:18, Janus Weil a écrit : Hi all, the attached patch fixes an ICE-on-invalid problem with procedure-pointer components by making sure that we continue resolving all components of a derived type, even after an error is thrown. Does the fonction return false as

Re: RFC: Two minor optimization patterns

2015-01-14 Thread Marc Glisse
On Wed, 14 Jan 2015, Richard Biener wrote: On Wed, Jan 14, 2015 at 1:45 PM, Marc Glisse marc.gli...@inria.fr wrote: On Tue, 13 Jan 2015, Rasmus Villemoes wrote: diff --git gcc/match.pd gcc/match.pd index 81c4ee6..04a0bc4 100644 --- gcc/match.pd +++ gcc/match.pd @@ -262,6 +262,16 @@ along

[PATCH] Fix for PR64353

2015-01-14 Thread Ilya Enkovich
Hi, SRA gimple passes may add loads to functions with no SSA update. Later it causes ICE when function with not updated SSA is processed by gimple passes. This patch fixes it by calling update_ssa. Bootstrapped and checked on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/

Re: [PATCH 3/3, ARM, libgcc, ping6] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2015-01-14 Thread Richard Earnshaw
On 14/01/15 11:57, Thomas Preud'homme wrote: Ping? I'm OK with this, but I think you also need a generic testsuite maintainer to go over the target independent parts. R. -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of

Re: [PATCH] Fix for PR64353

2015-01-14 Thread Richard Biener
On Wed, Jan 14, 2015 at 3:28 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, SRA gimple passes may add loads to functions with no SSA update. Later it causes ICE when function with not updated SSA is processed by gimple passes. This patch fixes it by calling update_ssa. Bootstrapped

Re: [PATCH] Reenable CSE of non-volatile inline asm (PR rtl-optimization/63637)

2015-01-14 Thread Segher Boessenkool
On Tue, Jan 13, 2015 at 11:16:09PM -0700, Jeff Law wrote: On 01/13/15 17:03, Segher Boessenkool wrote: On Tue, Jan 13, 2015 at 03:17:08PM -0700, Jeff Law wrote: And finally there is the case of non-volatile asm with memory clobber with no memory stores in between the two - the posted (safer)

Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

2015-01-14 Thread Ian Lance Taylor
On Wed, Jan 14, 2015 at 5:49 AM, Lynn A. Boger labo...@linux.vnet.ibm.com wrote: I have an updated patch for the reflection functions in gcc 4.9 for ppc64 ppc64le which allows the recover.go test to pass and the updated version of libgo/go/reflect/all_tests.go to pass once all testcases are

Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c

2015-01-14 Thread Jeff Law
On 11/05/14 13:30, jb...@gmx.de wrote: Jeff Law l...@redhat.com: On 10/23/14 08:30, jb...@gmx.de wrote: Jeff Law l...@redhat.com: On 10/21/14 12:21, jb...@gmx.de wrote: Jeff Law l...@redhat.com: On 10/21/14 16:13, Haswell wrote: The additional source must have the same requirement

Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c

2015-01-14 Thread Jeff Law
On 11/05/14 13:30, jb...@gmx.de wrote: With LTO enabled it runs just fine (which is the reason for the patch I suggested): This is definitely a testing framework problem. The profopt framework isn't clearing the additional_whatever variables. Presumably failure to clear is specific to a

Re: [PATCH] Reenable CSE of non-volatile inline asm (PR rtl-optimization/63637)

2015-01-14 Thread Richard Biener
On January 15, 2015 6:06:33 AM CET, Jeff Law l...@redhat.com wrote: On 01/14/15 08:19, Segher Boessenkool wrote: @findex clobber @item (clobber @var{x}) Represents the storing or possible storing of an unpredictable, undescribed value into @var{x}, which must be a @code{reg},

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-14 Thread Patrick Wollgast
On 15.01.2015 00:52, Ian Lance Taylor wrote: On Wed, Jan 14, 2015 at 12:28 PM, Patrick Wollgast patrick.wollg...@rub.de wrote: On 14.01.2015 20:00, Ian Lance Taylor wrote: On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast patrick.wollg...@rub.de wrote: A short recap again: Latest patch,

Re: [PATCH] PR59448 - Promote consume to acquire

2015-01-14 Thread Torvald Riegel
On Wed, 2015-01-14 at 10:44 -0500, Andrew MacLeod wrote: I think this brings us to where we ought to be... at least almost :-) The latest version I have is n3337, which still specifies that atomic_clear can't be memory_order_acquire or memory_order_acq_rel. Has that been updated to

Re: [PATCH][AArch64] Improve bit-test-branch pattern to avoid unnecessary register clobber

2015-01-14 Thread Jiong Wang
On 15/12/14 15:36, Jiong Wang wrote: from the discussion here https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01949.html the other problem it exposed is the unnecessary clobber of register x19 which is a callee-saved register, then there are unnecessary push/pop in pro/epilogue. the reason

Re: [PATCH] PR59448 - Promote consume to acquire

2015-01-14 Thread Andrew MacLeod
On 01/13/2015 05:37 PM, Joseph Myers wrote: On Tue, 13 Jan 2015, Andrew MacLeod wrote: It seems that it should be safe to move back to the original patch, and remove that error test for using consume on an exchange... I don't think there should be any such errors, for any of the atomic

RE: [PATCH 3/3, ARM, libgcc, ping6] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2015-01-14 Thread Thomas Preud'homme
Ok, Adding the testsuite maintainers in the loop. Should I commit the tests once approved or would it be preferable to wait for PATCH 2/3 to be rewritten and approved? I would advocate for the former but I'm fine with the latter. Best regards, Thomas -Original Message- From: Richard

[PATCH] Fix PR c++/16160

2015-01-14 Thread Patrick Palka
Here is version 2 of the patch which only adjusts a couple of testcases in g++.old-deja/ that I missed earlier. I am unsure if the extra dg-error in overload.C is correct. No code changes yet in gcc/cp/ versus the original patch. Successfully bootstrapped and regtested on

Re: [PATCH 3/3, ARM, libgcc, ping6] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2015-01-14 Thread Ramana Radhakrishnan
On 14/01/15 16:04, Thomas Preud'homme wrote: Ok, Adding the testsuite maintainers in the loop. Should I commit the tests once approved or would it be preferable to wait for PATCH 2/3 to be rewritten and approved? I would advocate for the former but I'm fine with the latter. If the tests

Re: [PATCH] Instrument bit field and unaligned accesses for TSAN

2015-01-14 Thread Dmitry Vyukov
Cool! Thanks. Gcc is again ahead of clang :) On Sat, Jan 3, 2015 at 1:11 AM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jan 02, 2015 at 11:01:56PM +0100, Bernd Edlinger wrote: gcc/ChangeLog: 2015-01-02 Bernd Edlinger bernd.edlin...@hotmail.de Instrument bit field and unaligned

Re: [PATCH] Fix for PR64353

2015-01-14 Thread Ilya Enkovich
On 14 Jan 15:35, Richard Biener wrote: On Wed, Jan 14, 2015 at 3:28 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, SRA gimple passes may add loads to functions with no SSA update. Later it causes ICE when function with not updated SSA is processed by gimple passes. This patch

Re: [patch] update function comments for lto_symtab_encoder_encode_*

2015-01-14 Thread Aldy Hernandez
On 01/14/2015 01:06 AM, Richard Biener wrote: Whenever I get to the LTO part of this project, I promise to start documenting things better. This whole thing is a mystery. Well - mostly to me as well ;) I'll let Honza answer this... Ha, you're being too modest! I get the feeling that no

RE: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-14 Thread Robert Suchanek
Here is the revised patch that would handle the other cases as per Richard's comments. I slightly modified Matthew's proposed patch and used split_const instead of get_related_value. AFAICS, the canonical form would always have the 'plus' expression. The offset on the high part is most likely

Re: [PATCH] PR64377

2015-01-14 Thread Joseph Myers
On Wed, 14 Jan 2015, Martin Liška wrote: Hello. Following patch introduces target option support for array types. As discussed in [1], the patch is tested on a nios2 target machine. Ready for trunk? OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] PR59448 - Promote consume to acquire

2015-01-14 Thread Joseph Myers
On Wed, 14 Jan 2015, Andrew MacLeod wrote: - There is a warning for invalid memory models already, so I just continued using that. - I remove the check for CONSUME in exchange since the current standard makes no mention of that being illegal. - I also reversed the current check in

Re: [Patch, Fortran, F03] PR 58023: ICE on invalid with bad PPC declaration

2015-01-14 Thread Janus Weil
Hi Mikael, the attached patch fixes an ICE-on-invalid problem with procedure-pointer components by making sure that we continue resolving all components of a derived type, even after an error is thrown. Does the fonction return false as before, whenever an error has been issued? I have the

Re: [PATCH] Fix for PR64353

2015-01-14 Thread Richard Biener
On January 14, 2015 5:23:21 PM CET, Ilya Enkovich enkovich@gmail.com wrote: On 14 Jan 15:35, Richard Biener wrote: On Wed, Jan 14, 2015 at 3:28 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, SRA gimple passes may add loads to functions with no SSA update. Later it causes ICE when

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2015-01-14 Thread Ramana Radhakrishnan
On 13/01/15 21:01, Andrew Stubbs wrote: On 12/01/15 13:50, Ramana Radhakrishnan wrote: In principle ok, but I'd like a comment in there explaining why we've done this. Can you also post under what configurations these have been tested ? Is this better? I tested it by running the vect.exp

RE: [MIPS] Re-enable ABI-ISA inference

2015-01-14 Thread Matthew Fortune
Moore, Catherine catherine_mo...@mentor.com writes: gcc/ * config/mips/mips.h (MIPS_ISA_LEVEL_SPEC): Only infer an ISA level from an ARCH; do not inject the default. (MIPS_DEFAULT_ISA_LEVEL_SPEC): New macro split out from MIPS_ISA_LEVEL_SPEC.

  1   2   >