Re: [PATCH] Fix scheduling undeterminism from sorting with DEBUG_INSNs

2015-01-28 Thread Maxim Kuvyrkov
On Jan 29, 2015, at 10:36 AM, Alexandre Oliva wrote: > On Jan 19, 2015, Maxim Kuvyrkov wrote: > >> Presence or absence of DEBUG_INSNs in the ready list can change the >> comparison order, and cause slightly different instruction schedules. > >> The solution that I propose (and that the patch i

Re: [PATCH] Fix scheduling undeterminism from sorting with DEBUG_INSNs

2015-01-28 Thread Alexandre Oliva
On Jan 19, 2015, Maxim Kuvyrkov wrote: > Presence or absence of DEBUG_INSNs in the ready list can change the > comparison order, and cause slightly different instruction schedules. > The solution that I propose (and that the patch implements) is to sort > DEBUG_INSNs separately from normal insns

Re: [libobjc] Fix failures on AIX (PR libobjc/63765)

2015-01-28 Thread Alexandre Oliva
On Jan 28, 2015, Mike Stump wrote: > On Jan 28, 2015, at 2:27 AM, Rainer Orth > wrote: >> There are two ways to fix this: >> >> * Remove the definition of _XOPEN_SOURCE completely. This is slightly >> more risky, but more future-proof since defining features test macros >> has been an endless

ICF versus inlining

2015-01-28 Thread Jan Hubicka
Hi, the PR is about function not being inlined because it is called via a wrapper introduced by ICF merging code. cgraph_node::create_wrapper set call_stmt_cannot_inline_p that I suggested to Martin to try to figure out how much of merging is undone by inliner. It was not meant to get into mainlin

Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Thomas Schwinge
Hi! First, thanks for improving portability of the libgomp plugin interface! On Wed, 28 Jan 2015 16:43:19 -0500, Jack Howarth wrote: > There is one other issue that I have been > pondering about filing a PR. In fink and MacPorts, FSF gcc is built > and packaged using either... > > --prefix=/s

Re: Fix tls model dumping

2015-01-28 Thread Alan Modra
On Thu, Jan 29, 2015 at 06:07:16AM +0100, Jan Hubicka wrote: > > On Wed, Jan 28, 2015 at 08:56:22PM +0100, Jan Hubicka wrote: > > > -const char * const tls_model_names[]={"none", "tls-emulated", "tls-real", > > > - "tls-global-dynamic", "tls-local-dynamic", > > > -

Fix flag_fp_contract_mode with LTO

2015-01-28 Thread Jan Hubicka
Hi, Igor found an performance regression related to my patch enabling option streaming. It turns out that with LTO we disable FMA instruction generation because fp_contract_mode is not streamed and set to 0. This is because patch https://gcc.gnu.org/ml/gcc-patches/2010-11/msg01827.html that makes f

Re: Fix tls model dumping

2015-01-28 Thread Jan Hubicka
> On Wed, Jan 28, 2015 at 08:56:22PM +0100, Jan Hubicka wrote: > > -const char * const tls_model_names[]={"none", "tls-emulated", "tls-real", > > - "tls-global-dynamic", "tls-local-dynamic", > > - "tls-initial-exec", "tls-local-exec"};

RE: [Patch][wwwdocs]Deprecate the ARM TPCS related options in gcc 5.0

2015-01-28 Thread Terry Guo
> -Original Message- > From: Gerald Pfeifer [mailto:ger...@pfeifer.com] > Sent: Thursday, January 29, 2015 2:53 AM > To: Terry Guo > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw; Ramana Radhakrishnan > Subject: RE: [Patch][wwwdocs]Deprecate the ARM TPCS related options in > gcc 5.0 > >

Re: Fix tls model dumping

2015-01-28 Thread Alan Modra
On Wed, Jan 28, 2015 at 08:56:22PM +0100, Jan Hubicka wrote: > -const char * const tls_model_names[]={"none", "tls-emulated", "tls-real", > - "tls-global-dynamic", "tls-local-dynamic", > - "tls-initial-exec", "tls-local-exec"}; > +

RE: [PATCH] [gcc, combine] PR46164: Don't combine the insns if a volatile register is contained.

2015-01-28 Thread Hale Wang
Hi Segher, I have updated the patch as you suggested. Both the patch and the changelog are attached. By the way, the test case provided by Tim Pambor in PR46164 was a different bug with PR46164. So I resubmitted the bug in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64818. And this patch is just

Re: [wwwdocs] Mention ipa-ICF and auto-FDO

2015-01-28 Thread Gerald Pfeifer
On Monday 2015-01-26 07:10, Jan Hubicka wrote: > Index: changes.html > === > + An Identical Code Folding (ICF) pass (controled via controlled > + this pass unifies about 29000 functions that is 10% overall. "functions, that

Re: [google/gcc-4_9] Add -ftwo-level-line-tables and -gline-tables-only options

2015-01-28 Thread Dehao Chen
On Wed, Jan 28, 2015 at 4:34 PM, Cary Coutant wrote: >>> > Not quite clear why we need block_table. This table is not gonna be >>> > emitted. And we can easily get subprog_entry through block->block_num >>> >>> When final_scan_insn() calls dwarf2out_begin_block(), all it passes is >>> a block numb

Re: [google/gcc-4_9] Add -ftwo-level-line-tables and -gline-tables-only options

2015-01-28 Thread Cary Coutant
>> > Not quite clear why we need block_table. This table is not gonna be >> > emitted. And we can easily get subprog_entry through block->block_num >> >> When final_scan_insn() calls dwarf2out_begin_block(), all it passes is >> a block number. I don't know a way to get from block number to the >> b

Re: [google/gcc-4_9] Add -ftwo-level-line-tables and -gline-tables-only options

2015-01-28 Thread Dehao Chen
On Wed, Jan 28, 2015 at 3:04 PM, Cary Coutant wrote: > > >> +static subprog_entry * > >> +add_subprog_entry (tree decl, bool is_inlined) > >> +{ > >> + subprog_entry **slot; > >> + subprog_entry *entry; > >> + > >> + slot = subprog_table->find_slot_with_hash (decl, DECL_UID (decl), > >> INSERT

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-01-28 Thread H.J. Lu
On Wed, Jan 28, 2015 at 11:37 AM, H.J. Lu wrote: > On Wed, Jan 28, 2015 at 11:19 AM, Richard Biener > wrote: >> On January 28, 2015 7:12:43 PM CET, "H.J. Lu" wrote: >>>Hi, >>> >>>This patch makes claim_file_handler to call release_input_file after it >>>finishes processing input file. OK for tr

Re: [patch libstdc++] Optimize synchronization in std::future if futexes are available.

2015-01-28 Thread Doug Gilmore
On 01/18/2015 05:19 AM, Jonathan Wakely wrote: > On 17/01/15 19:51 -0700, Sandra Loosemore wrote: >> On 01/17/2015 03:58 PM, Jonathan Wakely wrote: >>> >>> My fault, this additional chunk is needed alongside the patch I sent >>> earlier: >>> >>> --- a/libstdc++-v3/include/bits/atomic_futex.h >>> ++

Re: [google/gcc-4_9] Add -ftwo-level-line-tables and -gline-tables-only options

2015-01-28 Thread Cary Coutant
>> +static subprog_entry * >> +add_subprog_entry (tree decl, bool is_inlined) >> +{ >> + subprog_entry **slot; >> + subprog_entry *entry; >> + >> + slot = subprog_table->find_slot_with_hash (decl, DECL_UID (decl), INSERT); >> + if (*slot == HTAB_EMPTY_ENTRY) >> +{ >> + entry = XCNEW (s

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-28 Thread Caroline Tice
Since all the pieces of this patch have been approved, I will commit it later today (since Patrick does not have commit privileges). -- Caroline Tice cmt...@google.com On Wed, Jan 28, 2015 at 3:31 AM, Patrick Wollgast wrote: > Ping. > > https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01270.html

Re: [PATCH] libiberty/argv.c: Use freeargv() instead of free() to avoid memory leak.

2015-01-28 Thread Chen Gang S
On 1/28/15 20:02, Andrew Burgess wrote: > * Chen Gang S [2015-01-28 19:34:38 +0800]: > >> libiberty/argv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libiberty/argv.c b/libiberty/argv.c >> index f2727e8..9fdd55b 100644 >> --- a/libiberty/argv.c >> +++ b/libiberty

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Rainer Orth
Jakub Jelinek writes: > On Wed, Jan 28, 2015 at 01:42:47PM -0700, Jeff Law wrote: >> >2015-01-28 Rainer Orth >> > >> >gcc/testsuite: >> >* gcc.dg/guality/guality.h (main): Add argv[0] to >> >guality_gdb_command. >> OK. >> >> As for what to do with guality, I haven't a clue. They'

Re: [PATCH, CHKP] Fix PR middle-end/64805

2015-01-28 Thread Jeff Law
On 01/27/15 05:48, Ilya Enkovich wrote: Hi, Some time ago removal of not instrumented version of funtion with 'always_inline' was delayed to enable their inlining. With this change we may have situations when we inline into a not instrumented version of a function which also has an instrumen

Re: [PATCH 3/3] Fix dbr_schedule for -freorder-blocks-and-partition

2015-01-28 Thread Jeff Law
On 01/26/15 16:52, Kaz Kojima wrote: This patch is to fix 2 issues found in dbr_schedule when trying to fix PR target/64761. The first is relax_delay_slots removes the jump insn in the insns like below: (jump_insn/j 74 58 59 (set (pc) (label_ref:SI 29)) ...) (barrier 59 74 105) (note 105 59 29

Re: [PATCH] PR jit/64780: configure: --enable-host-shared and the jit

2015-01-28 Thread Jeff Law
On 01/27/15 10:17, David Malcolm wrote: Currently the jit requires you to specify --enable-host-shared, or the build eventually fails with linker errors (this is something of a FAQ for people trying out the jit). We seem to have two choices here: (A) default to --enable-host-shared when jit is

Re: [PATCH] Fix libjava version number under cygwin

2015-01-28 Thread Jeff Law
On 01/28/15 04:51, Bernd Edlinger wrote: Hi, after the recent version bump of the libjava libraries, java under cygwin is broken. The reason is that libgcc/config/i386/cygming-crtbegin.c needs to know the exact version number to load the symbol _Jv_RegisterClasses from cyggcj-16.dll. This pa

Re: [PATCH] libiberty/argv.c: Use freeargv() instead of free() to avoid memory leak.

2015-01-28 Thread Chen Gang S
On 1/28/15 20:02, Andrew Burgess wrote: > * Chen Gang S [2015-01-28 19:34:38 +0800]: > >> libiberty/argv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libiberty/argv.c b/libiberty/argv.c >> index f2727e8..9fdd55b 100644 >> --- a/libiberty/argv.c >> +++ b/libibert

Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Jack Howarth
Mike, Thanks for the commit. There is one other issue that I have been pondering about filing a PR. In fink and MacPorts, FSF gcc is built and packaged using either... --prefix=/sw/lib/gcc5.0 or --libdir=/opt/local/lib/gcc5 such that the libraries for each gcc release are buried. While th

Re: [google/gcc-4_9] Add -ftwo-level-line-tables and -gline-tables-only options

2015-01-28 Thread Dehao Chen
On Sun, Jan 25, 2015 at 6:06 PM, Cary Coutant wrote: > Add -ftwo-level-line-tables and -gline-tables-only options. > > With -ftwo-level-line-tables, GCC will generate two-level line tables, > which adds inline call information to the line tables, obviating the > need to keep bulky debug info aroun

Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Mike Stump
On Jan 28, 2015, at 1:03 PM, Jakub Jelinek wrote: > Please add > PR libgomp/64635 > to the ChangeLog entry. > Ok with that change. Committed revision 220218.

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Rainer Orth
Jakub Jelinek writes: > On Wed, Jan 28, 2015 at 10:10:18PM +0100, Rainer Orth wrote: >> passing argv[0] seems the easiest course of action. As I said, >> gfortran.dg/guality/guality.exp already does it, and there were no >> issues even on Solaris. > > gfortran.dg/guality/guality.exp doesn't do t

[SH][committed] Fix PR 64659

2015-01-28 Thread Oleg Endo
Hi, Attached patch allows the atomic ops on SH to utilize some of the immediate value insns, which can save an insn and reg sometimes. The actual changes are in the predicates, constraints and some adjustments to some of the asm snippets. While at it, I've changed uses of register_operand into a

Re: [PATCH] libiberty/argv.c: Use freeargv() instead of free() to avoid memory leak.

2015-01-28 Thread DJ Delorie
> memcpy (*argvp + i, file_argv, file_argc * sizeof (char *)); This code copies all the pointers in file_argv[] into argv[], so if you freeargv them via file_argv, argv[] will point to free'd memory. Hence the comment: > /* Free up memory allocated to process the response file. We do

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 10:10:18PM +0100, Rainer Orth wrote: > passing argv[0] seems the easiest course of action. As I said, > gfortran.dg/guality/guality.exp already does it, and there were no > issues even on Solaris. gfortran.dg/guality/guality.exp doesn't do that. The thing is, there are 2 k

Re: [PATCH] Fix libbacktrace and libiberty tests fail on sanitized GCC due to wrong link options.

2015-01-28 Thread DJ Delorie
> Does the patch look sane? I don't think anything in the toplevel configury looks "sane" any more, but I think this patch is OK.

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Rainer Orth
Mike Stump writes: > On Jan 28, 2015, at 4:58 AM, Rainer Orth > wrote: >> >> Thoughts? > > So the timeout for slow things can be increased: > > # More time is needed > > set_boar

[Patch, fortran] PR 64757 - [5 Regression] ICE in fold_convert_loc, at fold-const.c:2353

2015-01-28 Thread Paul Richard Thomas
Dear All, This regression was caused by the patch for PR60357. The fix is straightforward. Please note however, that I have not checked for other fallout yet - I have merely addressed the reported failure. I will check around the reported testcase tomorrow night. Dominique, thanks for the rapid f

Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Mike Stump
On Jan 28, 2015, at 12:52 PM, Jack Howarth wrote: > The attached patch solves PR64635 for those targets which produce a > libgomp-plugin-host_nonshm shared library with a suffix other than > ".so.1”. Nice...

Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 03:52:25PM -0500, Jack Howarth wrote: >The attached patch solves PR64635 for those targets which produce a > libgomp-plugin-host_nonshm shared library with a suffix other than > ".so.1". A set of target specific plugin-suffix.h headers are > installed in libgomp/config/a

[PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Jack Howarth
The attached patch solves PR64635 for those targets which produce a libgomp-plugin-host_nonshm shared library with a suffix other than ".so.1". A set of target specific plugin-suffix.h headers are installed in libgomp/config/aix, libgomp/config/darwin and libgomp/config/hpux as well as a generic

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 01:42:47PM -0700, Jeff Law wrote: > >2015-01-28 Rainer Orth > > > > gcc/testsuite: > > * gcc.dg/guality/guality.h (main): Add argv[0] to > > guality_gdb_command. > OK. > > As for what to do with guality, I haven't a clue. They're dependent on the > debugger

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Jeff Law
On 01/28/15 05:58, Rainer Orth wrote: Since the testsuite parallelism has been massively increased some time ago, I'm seing lots of timeouts on slower SPARC hardware (1.2 Ghz UltraSPARC-T2). Closer investigation revealed that this happens on Solaris everywhere, though not so badly that the tests

Re: [RFC PATCH] Avoid most of the BUILT_IN_*_CHKP enum values

2015-01-28 Thread Jeff Law
On 01/28/15 12:24, Richard Biener wrote: It should be the STABS and/or affected target maintainers job to get this fixed for them. Richard, Even if the STABS continuations are fixed, it requires fixing it in previous releases of GCC, deploying the solution and achieving adoption. The curren

Re: Relat TLS model merging in lto-symtab

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 08:59:07PM +0100, Jan Hubicka wrote: > --- lto-symtab.c (revision 220212) > +++ lto-symtab.c (working copy) > @@ -158,11 +158,44 @@ lto_varpool_replace_node (varpool_node * > >if (vnode->tls_model != prevailing_node->tls_model) > { > - error_at (DEC

Re: [RFC PATCH] Avoid most of the BUILT_IN_*_CHKP enum values

2015-01-28 Thread Jeff Law
On 01/28/15 12:57, Jakub Jelinek wrote: On Wed, Jan 28, 2015 at 12:51:24PM -0700, Jeff Law wrote: On 01/28/15 12:24, Richard Biener wrote: It should be the STABS and/or affected target maintainers job to get this fixed for them. Richard, Even if the STABS continuations are fixed, it requir

[PATCH] Fix x86 #pragma GCC target and target attribute handling (PR target/61925)

2015-01-28 Thread Jakub Jelinek
Hi! This patch rewrites the target pragma and target attribute handling in the i386 backend, so that outside of functions global_options and target globals reflect the currently active #pragma GCC target (if none active, obviously the default options) and inside of functions (in between set_cfun t

Re: [PATCH] Fix dwarf2out wide-int issues (PR other/63504)

2015-01-28 Thread Jason Merrill
OK. Jason

Relat TLS model merging in lto-symtab

2015-01-28 Thread Jan Hubicka
Hi, newer Firefox trees fails to build because jsmalloc contain variable that is declared as tls-initial-exec in one unit but used as tls-global-dynamic in others. As discussed with Jakub on IRC, the linker supports some model transitions, so we should do the same in symtab.c too. Bootstrapped/re

Re: [RFC PATCH] Avoid most of the BUILT_IN_*_CHKP enum values

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 12:51:24PM -0700, Jeff Law wrote: > On 01/28/15 12:24, Richard Biener wrote: > >>>It should be the STABS and/or affected target maintainers job to get > >>this fixed > >>>for them. > >> > >>Richard, > >> > >>Even if the STABS continuations are fixed, it requires fixing it in

Fix tls model dumping

2015-01-28 Thread Jan Hubicka
Hi, this patch fixes dumping of tls models. tls-real is not really a model, just equivalent of tls-global-dynamic. Comitted as obvious. Honza Index: ChangeLog === --- ChangeLog (revision 220212) +++ ChangeLog (working copy) @@ -

[PATCH] Fix dwarf2out wide-int issues (PR other/63504)

2015-01-28 Thread Jakub Jelinek
Hi! Despite the cleared_ part, the attr.dw_attr_val.v.val_wide = ggc_cleared_alloc (); *attr.dw_attr_val.v.val_wide = w; etc. sequences put in there uninitialized bits (array elements beyond get_len (), and perhaps structure padding), as it constructs a temporary and then assigns it to *val_wide.

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-01-28 Thread H.J. Lu
On Wed, Jan 28, 2015 at 11:44 AM, Cary Coutant wrote: This patch makes claim_file_handler to call release_input_file after it finishes processing input file. OK for trunk? >>> >>> OK. How did you test this? >> >> I did normal bootstrap and "make check" on Linux/x86-64. >> I also run ld.b

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-01-28 Thread Cary Coutant
>>>This patch makes claim_file_handler to call release_input_file after it >>>finishes processing input file. OK for trunk? >> >> OK. How did you test this? > > I did normal bootstrap and "make check" on Linux/x86-64. > I also run ld.bfd and ld.gold by hand to verify that release_input_file > is

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-01-28 Thread H.J. Lu
On Wed, Jan 28, 2015 at 11:19 AM, Richard Biener wrote: > On January 28, 2015 7:12:43 PM CET, "H.J. Lu" wrote: >>Hi, >> >>This patch makes claim_file_handler to call release_input_file after it >>finishes processing input file. OK for trunk? > > OK. How did you test this? I did normal bootstra

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Bruce Korb
On 01/28/15 10:15, Bruce Korb wrote: On 01/28/15 10:13, Bruce Korb wrote: Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no differenc

Re: [RFC PATCH] Avoid most of the BUILT_IN_*_CHKP enum values

2015-01-28 Thread Richard Biener
On January 28, 2015 4:23:05 PM CET, David Edelsohn wrote: >On Wed, Jan 28, 2015 at 6:45 AM, Richard Biener > wrote: >> On Wed, Jan 28, 2015 at 12:24 PM, Jakub Jelinek >wrote: >>> On Wed, Jan 28, 2015 at 12:15:40PM +0100, Richard Biener wrote: > Note, patch successfully bootstrapped/regtested

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-01-28 Thread Richard Biener
On January 28, 2015 7:12:43 PM CET, "H.J. Lu" wrote: >Hi, > >This patch makes claim_file_handler to call release_input_file after it >finishes processing input file. OK for trunk? OK. How did you test this? Thanks, Richard. >Thanks. > > >H.J. >--- >diff --git a/lto-plugin/ChangeLog b/lto-plu

RE: [Patch][wwwdocs]Deprecate the ARM TPCS related options in gcc 5.0

2015-01-28 Thread Gerald Pfeifer
On Wednesday 2015-01-28 09:57, Terry Guo wrote: > Thanks Gerald. Patch is updated. Is this one OK? This good to me. (Perhaps say "which were only applicable", since there are gone now?) Gerald

Re: [PATCH][AArch64] Testcase fix for __ATOMIC_CONSUME

2015-01-28 Thread Mike Stump
On Jan 28, 2015, at 9:51 AM, Marcus Shawcroft wrote: > Going forward we can [ … ] xfail the test case pending a proper solution to > 59448 ? > Mike do you prefer one of the other two approaches ? I’d xfail the test case and mark with the fix consume PR. If we don’t have an unambiguous, fix co

Re: [debug-early] C++ clones and limbo DIEs

2015-01-28 Thread Jason Merrill
On 01/28/2015 01:29 PM, Aldy Hernandez wrote: + /* It is rather unfortunate that Cilk creates trees this late + (during gimplification). However, until this gets fixed, + specially handle emitting DWARF for this new function and + immediately clean up the limbo_die_list where the ne

Re: [debug-early] C++ clones and limbo DIEs

2015-01-28 Thread Aldy Hernandez
On 01/16/2015 02:55 AM, Richard Biener wrote: On Fri, Jan 16, 2015 at 4:11 AM, Jason Merrill wrote: On 01/15/2015 09:58 PM, Aldy Hernandez wrote: I hoped we wouldn't need the limbo list at all ... that is, parent DIEs are always present when we create children. I think that should work in p

Re: [libobjc] Fix failures on AIX (PR libobjc/63765)

2015-01-28 Thread Mike Stump
On Jan 28, 2015, at 2:27 AM, Rainer Orth wrote: > There are two ways to fix this: > > * Remove the definition of _XOPEN_SOURCE completely. This is slightly > more risky, but more future-proof since defining features test macros > has been an endless source of trouble in the past. I think I pr

Re: [debug-early] C++ clones and limbo DIEs

2015-01-28 Thread Aldy Hernandez
And now with the actual patch ;-). * c-family/cilk.c (create_cilk_wrapper_body): Emit debug information for wrappers. * cp/decl2.c (emit_debug_for_namespace): Add FIXME note for templates. * cp/optimize.c (maybe_clone_body): Emit early debug for clones.

Re: [debug-early] C++ clones and limbo DIEs

2015-01-28 Thread Aldy Hernandez
On 01/27/2015 12:51 PM, Jason Merrill wrote: On 01/23/2015 01:45 PM, Aldy Hernandez wrote: It would expect [the flush] to be before free_lang_data and LTO streaming. The reason this wouldn't make a difference is because, as it stands, dwarf for the clones are not generated until final.c: i

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Richard Henderson
On 01/28/2015 10:10 AM, Dominique d'Humières wrote: >> I can't think of any reason they shouldn't work. Were they not running >> before, >> or did something else change? > > AFAIU the commit, the tests were not run on x86_64-*-*, so the tests and the > corresponding failures are new. Well, the

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Bruce Korb
On 01/28/15 10:13, Bruce Korb wrote: Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no difference for the generated fixincl.x, but

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Bruce Korb
Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no difference for the generated fixincl.x, but only with the escaping does make check

PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-01-28 Thread H.J. Lu
Hi, This patch makes claim_file_handler to call release_input_file after it finishes processing input file. OK for trunk? Thanks. H.J. --- diff --git a/lto-plugin/ChangeLog b/lto-plugin/ChangeLog index e8ec05b..c0eae24 100644 --- a/lto-plugin/ChangeLog +++ b/lto-plugin/ChangeLog @@ -1,3 +1,10

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Dominique d'Humières
> Le 28 janv. 2015 à 19:03, Richard Henderson a écrit : > > On 01/28/2015 06:28 AM, Dominique Dhumieres wrote: >>> This patch worked for me. Ok for mainline now? (r220158) >> >> This causes 340 new tests on darwin with -m32, 255 of them failing when >> executes, >> see https://gcc.gnu.org/ml/

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Richard Henderson
On 01/28/2015 06:28 AM, Dominique Dhumieres wrote: >> This patch worked for me. Ok for mainline now? (r220158) > > This causes 340 new tests on darwin with -m32, 255 of them failing when > executes, > see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg03197.html. > > Are the tests with '-DAB

Re: [PATCH][AArch64] Testcase fix for __ATOMIC_CONSUME

2015-01-28 Thread James Greenhalgh
On Wed, Jan 28, 2015 at 05:51:27PM +, Marcus Shawcroft wrote: > On 28 January 2015 at 17:41, Mike Stump wrote: > > On Jan 27, 2015, at 8:24 AM, Alex Velenko wrote: > >> This patch fixes aarch64/atomic-op-consume.c test to expect safe "LDAXR" > >> instruction to be generated when __ATOMIC_CONS

Re: [PATCH][RFA][PR target/15184] Partial fix for direct byte access on x86

2015-01-28 Thread Mike Stump
On Jan 27, 2015, at 10:08 PM, Jeff Law wrote: > We're still going to need the changes to the heuristic to enable 4 insn > combinations Yeah, I’ve love for a masters student to come up with a sane way to do 16 or less and enhance gcc to do that. Things like, oh, this pattern is a dead end here

Re: nvptx offloading patches [4/n]

2015-01-28 Thread Ilya Verbin
On 28 Jan 18:05, Thomas Schwinge wrote: > + fprintf (out, "#define PTX_ID 1\n"); > + fprintf (out, "static __attribute__((constructor)) void init (void)\n{\n"); > + fprintf (out, " GOMP_offload_register (__OPENMP_TARGET__, PTX_ID,\n"); The file include/gomp-constants.h already contains: #defin

Re: [PATCH][AArch64] Testcase fix for __ATOMIC_CONSUME

2015-01-28 Thread Marcus Shawcroft
On 28 January 2015 at 17:41, Mike Stump wrote: > On Jan 27, 2015, at 8:24 AM, Alex Velenko wrote: >> This patch fixes aarch64/atomic-op-consume.c test to expect safe "LDAXR" >> instruction to be generated when __ATOMIC_CONSUME semantics is requested. > > Did you see: > > /* Workaround for Bugzi

Re: [PATCH][AArch64] Testcase fix for __ATOMIC_CONSUME

2015-01-28 Thread Mike Stump
On Jan 27, 2015, at 8:24 AM, Alex Velenko wrote: > This patch fixes aarch64/atomic-op-consume.c test to expect safe "LDAXR" > instruction to be generated when __ATOMIC_CONSUME semantics is requested. Did you see: /* Workaround for Bugzilla 59448. GCC doesn't track consume properly, so

Re: [testsuite] Run guality tests on Solaris

2015-01-28 Thread Mike Stump
On Jan 28, 2015, at 4:58 AM, Rainer Orth wrote: > > Thoughts? So the timeout for slow things can be increased: # More time is needed set_board_info gcc,timeout 800 set_board_info

Re: [PATCH PR64809]

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 09:23:55AM -0800, H.J. Lu wrote: > On Tue, Jan 27, 2015 at 6:52 AM, Yuri Rumyantsev wrote: > > Hi All, > > > > Here is a simple patch that cures ICE - skip debug gimples. > > Test is also included. > > > > Bootstrap and regression testing did not show any new failures. > >

Re: [PATCH PR64809]

2015-01-28 Thread H.J. Lu
On Tue, Jan 27, 2015 at 6:52 AM, Yuri Rumyantsev wrote: > Hi All, > > Here is a simple patch that cures ICE - skip debug gimples. > Test is also included. > > Bootstrap and regression testing did not show any new failures. > > Is it OK for trunk? > > ChangeLog: > > 2015-01-27 Yuri Rumyantsev >

Re: nvptx offloading patches [4/n]

2015-01-28 Thread Thomas Schwinge
Hi! On Sat, 1 Nov 2014 13:11:29 +0100, Bernd Schmidt wrote: > I'm sending this for reference more than anything else - this is the > patch that adds the target support for offloading to the nvptx port. It > depends on the other offloading patches Ilya is currently submitting. Committed to tru

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

2015-01-28 Thread Ilya Verbin
Hi Jakub! We have 3 pending patches with warnings/errors about omp pragmas: 1. https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00617.html 2. https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00621.html 3. This one. What should we do with them? [ ] Rebase and continue pinging. [ ] Postpone until Stage

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-28 Thread Ilya Verbin
On 28 Jan 17:15, Jakub Jelinek wrote: > On Wed, Jan 28, 2015 at 07:02:59PM +0300, Ilya Verbin wrote: > > + = XNEWVEC (char, len + sizeof ("-B" "../" DEFAULT_TARGET_MACHINE > > + "/libgomp/")); > > + sprintf (optional_target_path2, "-B%s/../../../" > > DEFAUL

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 07:02:59PM +0300, Ilya Verbin wrote: > + = XNEWVEC (char, len + sizeof ("-B" "../" DEFAULT_TARGET_MACHINE > +"/libgomp/")); > + sprintf (optional_target_path2, "-B%s/../../../" DEFAULT_TARGET_MACHINE > +

PING: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-01-28 Thread H.J. Lu
PING. On Tue, Jan 13, 2015 at 3:25 PM, H.J. Lu wrote: > On Tue, Jan 13, 2015 at 5:03 AM, H.J. Lu wrote: >> On Mon, Jan 12, 2015 at 11:50:41PM +, Joseph Myers wrote: >>> On Mon, 12 Jan 2015, H.J. Lu wrote: >>> >>> > +if test x$enable_default_pie = xyes; then >>> > + AC_MSG_CHECKING(if $targe

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-28 Thread Ilya Verbin
On 15 Jan 19:58, Jakub Jelinek wrote: > On Thu, Jan 15, 2015 at 09:55:40PM +0300, Ilya Verbin wrote: > > This patch enables 'make check-target-libgomp' with noninstalled offloading > > compilers. It creates gcc/accel// directory in the build tree of > > the > > offloading compiler, this allows lt

Re: [PATCH, i386] Never fix register for PIC when pseudo PIC reg is used

2015-01-28 Thread Uros Bizjak
Hello! > Currently ix86_conditional_register_usage code may mark EBX as a fixed > register if it is called > when pic_offset_table_rtx is NULL even if we are going to use pseudo PIC > register. It already > caused some problem in combination with another issue (PR jit/64722). This > patch wil

Re: [RFC PATCH] Avoid most of the BUILT_IN_*_CHKP enum values

2015-01-28 Thread David Edelsohn
On Wed, Jan 28, 2015 at 6:45 AM, Richard Biener wrote: > On Wed, Jan 28, 2015 at 12:24 PM, Jakub Jelinek wrote: >> On Wed, Jan 28, 2015 at 12:15:40PM +0100, Richard Biener wrote: >>> > Note, patch successfully bootstrapped/regtested on x86_64-linux and >>> > i686-linux, and David said that on AIX

Re: [PATCH][AArch32] Testcase fix for __ATOMIC_CONSUME

2015-01-28 Thread Alex Velenko
On 27/01/15 16:13, Ramana Radhakrishnan wrote: On Tue, Jan 27, 2015 at 4:06 PM, Alex Velenko wrote: Hi, This patch fixes arm/atomic-op-consume.c test to expect safe "LDAEX" instruction to be generated when __ATOMIC_CONSUME semantics is requested. This patch was tested by running the modified

Re: [PATCH] Fix PR64829

2015-01-28 Thread Kyrill Tkachov
Hi Richard, On 28/01/15 14:14, Richard Biener wrote: This fixes PR64829 where widening shift pattern detection fails to verify the widening operation is used only in the shift. Bootstrap and regtest running on x86_64-unknown-linux-gnu. This patch causes a testsuite fail on an arm-none-eabi cr

[PATCH, i386] Never fix register for PIC when pseudo PIC reg is used

2015-01-28 Thread Ilya Enkovich
Hi, Currently ix86_conditional_register_usage code may mark EBX as a fixed register if it is called when pic_offset_table_rtx is NULL even if we are going to use pseudo PIC register. It already caused some problem in combination with another issue (PR jit/64722). This patch will probably help

Re: [patch] Fix warning during libstdc++ build

2015-01-28 Thread Jonathan Wakely
On 07/01/15 22:49 +, Jonathan Wakely wrote: This fixes a -Wc++14-compat warning in the new libsupc++/del_ops.cc file that defines the C++14 sized deallocation function. Tested x86_64-linux, committed to trunk. And another instance of the same warning. Tested x86_64-linux, committed to tr

Re: [PATCH][x86] Update s{r,l}li intrinsics.

2015-01-28 Thread Uros Bizjak
On Wed, Jan 28, 2015 at 3:29 PM, Ilya Tocar wrote: > I'd like to backport this to 4.8/4.9 > Is this ok? OK, since it just adds new inline function/define names for compatibility. Uros. > On 15 Jan 17:17, Ilya Tocar wrote: >> Hi, >> Looks like new ISA doc [1] renamed srli,slli intrinsics to bsrl

Re: [PATCH][x86] Update s{r,l}li intrinsics.

2015-01-28 Thread Ilya Tocar
I'd like to backport this to 4.8/4.9 Is this ok? On 15 Jan 17:17, Ilya Tocar wrote: > Hi, > Looks like new ISA doc [1] renamed srli,slli intrinsics to bsrli,bslli. > This patch adds b* versions, while keeping old srli for backward > compatibility. > OK for trunk? > > 1:https://software.intel.com/

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Dominique Dhumieres
> This patch worked for me. Ok for mainline now? (r220158) This causes 340 new tests on darwin with -m32, 255 of them failing when executes, see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg03197.html. Are the tests with '-DABI_NUM=*' supposed to work on darwin? If yes, I'll open a PR; if

[PATCH] Fix PR64829

2015-01-28 Thread Richard Biener
This fixes PR64829 where widening shift pattern detection fails to verify the widening operation is used only in the shift. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2015-01-28 Richard Biener PR tree-optimization/64829 * tree-vect-patterns.c (vect_r

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Rainer Orth
Hi Bruce, this thread is more than half a year old now, but with the GCC 5 release approaching, we should reach some conclusion. > On Tue, Jul 1, 2014 at 4:22 AM, Rainer Orth > wrote: >>> It's not yet in autogen 5.9: I've diffed the fixincl.x generated with my >>> original patch and the amended

Re: [PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-01-28 Thread James Greenhalgh
On Wed, Jan 28, 2015 at 12:32:45PM +, Alan Lawrence wrote: > Ok for stage 4? This is a regression from 4.9, so once we iron out some nits, it should be. > gcc/ChangeLog: > > * config/aarch64/aarch64.md (*xor_one_cmpl3): Use FP_REGNUM_P > as split condition. And a testcase, pleas

[PATCH][libstdc++][testsuite][reverted] Remove check for truncation overflow

2015-01-28 Thread Kyrill Tkachov
Hi all, This patch reverts the libstdc++ hunk of https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00768.html, that is the check for relocation truncation and the marking of the test as UNSUPPORTED if it occurs. The problem with this approach is that when we call 'unsupported "message"' in the .ex

[testsuite] Run guality tests on Solaris

2015-01-28 Thread Rainer Orth
Since the testsuite parallelism has been massively increased some time ago, I'm seing lots of timeouts on slower SPARC hardware (1.2 Ghz UltraSPARC-T2). Closer investigation revealed that this happens on Solaris everywhere, though not so badly that the testsuite 300 second timeout hits. The check

[PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-01-28 Thread Alan Lawrence
Hi, The split rule introduced in r218961 uses as its split condition 'reload_completed && (which_alternative == 1)', but which_alternative does not seem to be set reliably during split phases, even after reload. This can lead to the split rule not being used even for insns using FP/SIMD regist

Re: [PATCH] libiberty/argv.c: Use freeargv() instead of free() to avoid memory leak.

2015-01-28 Thread Andrew Burgess
* Chen Gang S [2015-01-28 19:34:38 +0800]: > libiberty/argv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libiberty/argv.c b/libiberty/argv.c > index f2727e8..9fdd55b 100644 > --- a/libiberty/argv.c > +++ b/libiberty/argv.c > @@ -454,7 +454,7 @@ expandargv (int *arg

[PATCH] Fix libjava version number under cygwin

2015-01-28 Thread Bernd Edlinger
Hi, after the recent version bump of the libjava libraries, java under cygwin is broken. The reason is that libgcc/config/i386/cygming-crtbegin.c needs to know the exact version number to load the symbol _Jv_RegisterClasses from cyggcj-16.dll. This patch fixes the cyggcj-xx.dll version numbers

  1   2   >