Re: [RFC][PATCH 2/3] Propagate and save value ranges wrapped information

2015-04-30 Thread Kugan
On 30/04/15 21:35, Richard Biener wrote: > On Thu, Apr 23, 2015 at 12:11 AM, Kugan > wrote: >> >> On 19/01/15 22:28, Richard Biener wrote: >>> On Sat, 17 Jan 2015, Kugan wrote: >>> This patch propagate value range wrapps attribute and save this to SSA_NAME. >>> >>> diff --git a/gc

Re: [RFC] Elimination of zext/sext - type promotion pass

2015-04-30 Thread Kugan
>> Thanks for the comments. Here is a prototype patch that implements a >> type promotion pass. This pass records SSA variables that will have >> values in higher bits (than the original type precision) if promoted and >> uses this information in inserting appropriate truncations and >> extensions

[PATCH, rs6000, committed] gcc.target/powerpc/crypto-builtin-2.c only applies for power8-vector support

2015-04-30 Thread Bill Schmidt
Hi, As pointed out elsewhere, gcc.target/powerpc/crypto-builtin-2.c is being executed for all POWER processors with VSX support. The built-ins being tested here are only applicable to processors with power8-vector support. This patch fixes the test to reflect this. Tested on powerpc64le-unknown

Re: [RFC][PATCH][X86_64] Eliminate PLT stubs for specified external functions via -fno-plt=

2015-04-30 Thread Sriraman Tallam
On Thu, Apr 30, 2015 at 8:21 PM, Alan Modra wrote: > On Thu, Apr 30, 2015 at 05:31:30PM -0700, Sriraman Tallam wrote: >> This comes with caveats. This cannot be generally done for all >> functions marked extern as it is impossible for the compiler to say if >> a function is "truly extern" (defin

Re: [RFC][PATCH][X86_64] Eliminate PLT stubs for specified external functions via -fno-plt=

2015-04-30 Thread Alan Modra
On Thu, Apr 30, 2015 at 05:31:30PM -0700, Sriraman Tallam wrote: > This comes with caveats. This cannot be generally done for all > functions marked extern as it is impossible for the compiler to say if > a function is "truly extern" (defined in a shared library). If a > function is not truly ext

[RFC][PATCH][X86_64] Eliminate PLT stubs for specified external functions via -fno-plt=

2015-04-30 Thread Sriraman Tallam
Hi, We noticed that one of our benchmarks sped-up by ~1% when we eliminated PLT stubs for some of the hot external library functions like memcmp, pow. The win was from better icache and itlb performance. The main reason was that the PLT stubs had no spatial locality with the call-sites. I have st

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 05:41:57PM +, Joseph Myers wrote: > On Thu, 30 Apr 2015, Jakub Jelinek wrote: > > > > I guess the "best" thing to do is justadd a > > > __PCC_BITFIELD_TYPE_MATTERS__ that gcc defines and use that in libobjc? > > > > I think adding way too many predefines, especially ra

[debug-early] revert removal of deferred_asm_names

2015-04-30 Thread Aldy Hernandez
Hello gentlemen. Both of you suggested I revert my removal of deferred_asm_names from dwarf2out, since it may cause mangling of DECLs that may ultimately not be needed. A little background... This all started with a regression for pr44197.c in the branch. What is happening is that the C fr

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 11:58:09PM +0200, Bernhard Reutner-Fischer wrote: > On April 30, 2015 5:53:02 PM GMT+02:00, Jeff Law wrote: > >On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote: > >> Hi, > >> > >> On 30 April 2015 at 07:00, Jeff Law wrote: > >>> On 04/29/2015 02:01 AM, Bernhard Reutn

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

2015-04-30 Thread Bernhard Reutner-Fischer
On April 30, 2015 5:53:02 PM GMT+02:00, Jeff Law wrote: >On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote: >> Hi, >> >> On 30 April 2015 at 07:00, Jeff Law wrote: >>> On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote: 2012-09-21 H.J. Lu PR target/48904 >

Re: More type narrowing in match.pd

2015-04-30 Thread Marc Glisse
On Thu, 30 Apr 2015, Jeff Law wrote: On 04/30/2015 01:17 AM, Marc Glisse wrote: +/* This is another case of narrowing, specifically when there's an outer + BIT_AND_EXPR which masks off bits outside the type of the innermost + operands. Like the previous case we have to convert the operan

Re: [PATCH,rs6000] Change -mcrypto to only affect Category:Vector.Crypto instructions

2015-04-30 Thread Bill Schmidt
Hi David, I agree, and I'll fix the test as described and backport everywhere, assuming I don't encounter any problems. Thanks for catching this! Bill On Wed, 2015-04-29 at 09:21 -0400, David Edelsohn wrote: > On Wed, Mar 4, 2015 at 3:14 PM, Bill Schmidt > wrote: > > Hi, > > > > I recently obs

Re: [PATCH] Fix PR ipa/65557

2015-04-30 Thread Uros Bizjak
Hello! > 2015-03-29 Martin Liska > >PR ipa/65557 >* ipa-icf.c (sem_function::equals_wpa): Check if IPA CP >has already filled up function summary. >(sem_item_optimizer::update_hash_by_addr_refs): Likewise. > > gcc/testsuite/ChangeLog: > > 2015-03-29 Martin Liska > >* g++.d

Re: [C++ patch] PR 65858

2015-04-30 Thread Prathamesh Kulkarni
On 1 May 2015 at 01:12, Paolo Carlini wrote: > Hi again, > > On 04/30/2015 08:45 PM, Paolo Carlini wrote: >> >> .. also, your patch doesn't seem to fix the case of -w instead of That could be fixed as follows: if (!warn_narrowing || inhibit_warnings) ok = true; else // pedwarn >> -Wno-narrowin

Go patch committed: Use alloca for non-escaping new expressions

2015-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use allocate for non-escaping new expressions. Previously it was using a temporary variable, which failed when the new expression was in a loop. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 20

[PATCH, testsuite]: Some random fixes for 32bit x86 targets

2015-04-30 Thread Uros Bizjak
Hello! 2015-04-29 Uros Bizjak * g++.dg/ipa/devirt-28a.C: Require LTO effective target. * g++.dg/ext/sync-4.C (dg-additional-options): Use -march=pentium for 32bit x86 targets. * gcc.dg/pr36504.c (dg-additional-options): Use -march=i686 -msse for 32bit x86 targets. * gcc

Re: [C++ patch] PR 65858

2015-04-30 Thread Paolo Carlini
Hi again, On 04/30/2015 08:45 PM, Paolo Carlini wrote: .. also, your patch doesn't seem to fix the case of -w instead of -Wno-narrowing. I think we want to check the return value of the pedwarn instead. I'm testing something. I'm finishing testing the below: with hindsight, checking the return

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread H.J. Lu
On Thu, Apr 30, 2015 at 12:33 PM, Caroline Tice wrote: > What is the correct way to regenerate doc/tm.texi? > Verify that you have permission to grant a GFDL license for all new text in tm.texi, then copy it to ../../src-trunk/gcc/doc/tm.texi. -- H.J.

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread Uros Bizjak
On Thu, Apr 30, 2015 at 9:33 PM, Caroline Tice wrote: > What is the correct way to regenerate doc/tm.texi? I have just committed the fix. Uros.

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread Caroline Tice
What is the correct way to regenerate doc/tm.texi? -- Caroline On Thu, Apr 30, 2015 at 12:24 PM, H.J. Lu wrote: > On Thu, Apr 30, 2015 at 10:38 AM, Richard Henderson wrote: >> On 04/30/2015 09:26 AM, Caroline Tice wrote: >>> 2015-04-30 Caroline Tice >>> >>> PR 65929 >>> * config/elfos.h (AS

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread H.J. Lu
On Thu, Apr 30, 2015 at 10:38 AM, Richard Henderson wrote: > On 04/30/2015 09:26 AM, Caroline Tice wrote: >> 2015-04-30 Caroline Tice >> >> PR 65929 >> * config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro definition. >> (ASM_DECLARE_COLD_FUNCTION_SIZE): New macro definition. >> * doc/t

Re: [patch] Implement ISO/IEC TS 18822 C++ File system TS

2015-04-30 Thread Jonathan Wakely
On 30/04/15 18:32 +0100, Jonathan Wakely wrote: This is the complete implementation I intend to commit shortly. (It's also been pushed to the redi/filesystem-ts branch in the git mirror). Committed to trunk at r222654. Implement N4100 File System TS * acinclude.m4 (GLIBCXX_ENABLE_

Re: [PATCH] [libstdc++] Add operator-> xmethod to std::unique_ptr

2015-04-30 Thread Jonathan Wakely
On 30/04/15 11:19 -0700, Doug Evans wrote: Hi. This patch adds operator-> xmethod support for std::unique_ptr. Regression tested on amd64-linux. Ok to commit? OK, thanks.

Re: [PATCH, i386]: Switch x86 to TARGET_SUPPORTS_WIDE_INT

2015-04-30 Thread H.J. Lu
On Thu, Apr 30, 2015 at 12:01 PM, Uros Bizjak wrote: > Hello! > > Attached patch switches x86 to TARGET_SUPPORTS_WIDE_INT. > > The patch builds on the fact that build requires > HOST_BITS_PER_WIDE_INT = 64 capable host. Taking this in account, > noticeable blocks of code can be removed, and all bu

[PATCH, i386]: Switch x86 to TARGET_SUPPORTS_WIDE_INT

2015-04-30 Thread Uros Bizjak
Hello! Attached patch switches x86 to TARGET_SUPPORTS_WIDE_INT. The patch builds on the fact that build requires HOST_BITS_PER_WIDE_INT = 64 capable host. Taking this in account, noticeable blocks of code can be removed, and all but one immed_double_const can be removed. The only wide-int mode t

Re: [C++ patch] PR 65858

2015-04-30 Thread Paolo Carlini
.. also, your patch doesn't seem to fix the case of -w instead of -Wno-narrowing. I think we want to check the return value of the pedwarn instead. I'm testing something. Paolo.

Backport PR ipa/64153 and PR ipa/63551 fixes to the 4.8 branch

2015-04-30 Thread Marek Polacek
We'd like to have PR ipa/63551 fixed even on the 4.8 branch, so this patch backports the fix and its related follow-ups along with a new C++ testcase. Martin J. said he was fine with it and the patches applied cleanly. I've installed the new test onto 4.9/5/trunk a while ago to make sure we don't

Re: [Patch, Fortran] Simplify lbound

2015-04-30 Thread Mikael Morin
Le 27/04/2015 20:45, Thomas Koenig a écrit : > Am 25.04.2015 um 20:12 schrieb Mikael Morin: > >> I've double-checked in the standard, and it seems it is not possible to >> simplify after all: >> >> If ARRAY is a whole array and either ARRAY is an assumed-size >> array of rank DIM or dime

[PATCH] [libstdc++] Add operator-> xmethod to std::unique_ptr

2015-04-30 Thread Doug Evans
Hi. This patch adds operator-> xmethod support for std::unique_ptr. Regression tested on amd64-linux. Ok to commit? 2015-04-30 Doug Evans * python/libstdcxx/v6/xmethods.py (UniquePtrMethodsMatcher): Add operator-> support. * testsuite/libstdc++-xmethods/unique_ptr.cc

Re: [PATCH] [libstdc++] Add uniform container erasure.

2015-04-30 Thread Daniel Krügler
2015-04-30 16:44 GMT+02:00 Ed Smith-Rowland <3dw...@verizon.net>: > >> And make_array, which isn't in the working paper yet, so I'd prefer to >> leave that part out for now. > > D'oh! Sorry about that.. Removed. >> >> The Doxygen @headername command tells users which header they are >> supposed t

[PATCH] Add testcase for PR tree-optimization/63551 to 4.9/5/trunk

2015-04-30 Thread Marek Polacek
This patch adds a C++ testcase for the PR Martin J. fixed some time ago. Tested on x86_64-linux, applying to 4.9/5/trunk. 2015-04-30 Marek Polacek PR tree-optimization/63551 * g++.dg/ipa/pr63551.C: New test. diff --git gcc/testsuite/g++.dg/ipa/pr63551.C gcc/testsuite/g++.dg/i

Re: [C++ patch] PR 65858

2015-04-30 Thread Paolo Carlini
Hi, On 04/30/2015 06:36 PM, Prathamesh Kulkarni wrote: Hi, The attached patch fixes ICE in PR65858. For the test-case: int x { 0.5 }; Eventually, we have to add to the testsuite the testcase too (the code is simpler but equivalent to what we added for 65801, -flto makes all the difference). A

Re: [PATCH, ARM, PR64208] LRA ICE Fix

2015-04-30 Thread Yvan Roux
Hi, On 23 March 2015 at 18:47, Yvan Roux wrote: > Hi, > > On 23 March 2015 at 17:08, Ramana Radhakrishnan > wrote: >> On Wed, Mar 18, 2015 at 10:19 AM, Yvan Roux wrote: >>> Hi, >>> >>> This is a fix for PR64208 where LRA loops when dealing with >>> iwmmxt_arm_movdi insn. As explain in the PR,

Go patch committed: escape analysis of function values and conversions

2015-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane improves the analysis of function values and type conversions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 4e348e019b8f go/escape.cc --- a/go/escape.cc Thu Apr 30 10:21:02 2015 -0700 +++ b/go/escape.cc

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Joseph Myers
On Thu, 30 Apr 2015, Jakub Jelinek wrote: > > I guess the "best" thing to do is justadd a > > __PCC_BITFIELD_TYPE_MATTERS__ that gcc defines and use that in libobjc? > > I think adding way too many predefines, especially rarely used ones, is > harmful, certainly it isn't free, consider -g3 or -dD

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread Richard Henderson
On 04/30/2015 09:26 AM, Caroline Tice wrote: > 2015-04-30 Caroline Tice > > PR 65929 > * config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro definition. > (ASM_DECLARE_COLD_FUNCTION_SIZE): New macro definition. > * doc/tm.texi.in (ASM_DECLARE_COLD_FUNCTION_NAME): Document new macro. > (

[patch] Implement ISO/IEC TS 18822 C++ File system TS

2015-04-30 Thread Jonathan Wakely
This is the complete implementation I intend to commit shortly. (It's also been pushed to the redi/filesystem-ts branch in the git mirror). As before, only a static library (libstdc++fs.a) is built, so there are no symbols added to libstdc++.so and we can be a bit more risky with regards to main

[debug-early] document new world and fix non-dwarf debugging backends

2015-04-30 Thread Aldy Hernandez
This patch adjusts the non-dwarf debugging back-ends to work in the new world. Particularly interesting is dbxout, which was generating specific debug information for constants not written to memory. For example, the following in C++: const int invisible = 0xC0FFEE; The new infrast

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread Uros Bizjak
On Thu, Apr 30, 2015 at 6:26 PM, Caroline Tice wrote: > Done. Here is the updated patch (with ChangeLog entries). Only > change was to update tm.texi.in. > > The bootstrap passed. Is the patch ok to commit? FYI, the (previous) patch also looks good on alphaev68-linux-gnu native bootstrap [1].

Re: More type narrowing in match.pd

2015-04-30 Thread Jeff Law
On 04/30/2015 01:17 AM, Marc Glisse wrote: +/* This is another case of narrowing, specifically when there's an outer + BIT_AND_EXPR which masks off bits outside the type of the innermost + operands. Like the previous case we have to convert the operands + to unsigned types to avoid intro

Go patch committed: Mark non-escaping variables whose address is not taken

2015-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane marks variables whose address is not taken as not escaping. This is needed because for some types there are ways for the variable to escape even without taking its address. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian dif

Re: [PATCH] Fix up tm_clone_hasher

2015-04-30 Thread Jeff Law
On 04/30/2015 03:30 AM, Marek Polacek wrote: Ping. On Wed, Apr 22, 2015 at 05:24:43PM +0200, Marek Polacek wrote: handle_cache_entry in tm_clone_hasher looks wrong: the condition if (e != HTAB_EMPTY_ENTRY || e != HTAB_DELETED_ENTRY) is always true. While it could be fixed by just changing || i

[C++ patch] PR 65858

2015-04-30 Thread Prathamesh Kulkarni
Hi, The attached patch fixes ICE in PR65858. For the test-case: int x { 0.5 }; int main() { return 0; } Compiling with: g++ -flto -Wno-narrowing -std=gnu++11 results in following ICE: lto1: internal compiler error: in get_constructor, at varpool.c:331 0xd22f73 varpool_node::get_constructor() ../.

Re: [PATCH] Fix for PR26702: Emit .size for BSS variables on arm-eabi

2015-04-30 Thread Kwok Cheung Yeung
Hello The target of the pr26702.c testcase was changed while committing from: { target arm*-*-eabi* } in my original patch to: { target arm_eabi } The check_effective_target_arm_eabi test (in gcc/testsuite/lib/target-supports.exp) checks for the presence of the __ARM_EABI__ preprocessor def

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-30 Thread Caroline Tice
Done. Here is the updated patch (with ChangeLog entries). Only change was to update tm.texi.in. The bootstrap passed. Is the patch ok to commit? -- Caroline cmt...@google.com ChangeLog (gcc): 2015-04-30 Caroline Tice PR 65929 * config/elfos.h (ASM_DECLARE_COLD_FUNCTION_NAME): New macro

Re: Mostly rewrite genrecog

2015-04-30 Thread Richard Sandiford
Richard Biener writes: > On Thu, Apr 30, 2015 at 2:08 PM, Andreas Schwab wrote: >> Richard Sandiford writes: >> >>> Andreas Schwab writes: Richard Sandiford writes: > /* Represents a test and the action that should be taken on the result. >If a transition exists for the t

Re: C/C++ PATCH to fix latest -Wbool-compare extension

2015-04-30 Thread Marek Polacek
On Thu, Apr 30, 2015 at 09:55:02AM -0600, Jeff Law wrote: > OK. Thanks. > BTW, you may also want to consider warning for integer types with a > precision of 1 bit. Yup, this is being tracked in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49706#c2 I suppose I'll get back to that in this stage1.

Re: [PATCH][AArch64] Fix operand costing logic for MINUS

2015-04-30 Thread Marcus Shawcroft
On 27 April 2015 at 14:24, Kyrill Tkachov wrote: > 2015-04-27 Kyrylo Tkachov > > * config/aarch64/aarch64.c (aarch64_rtx_costs, MINUS): > Properly account for both operand costs in simple case. OK /Marcus

Re: More type narrowing in match.pd

2015-04-30 Thread Jeff Law
On 04/30/2015 03:00 AM, Richard Biener wrote: Without looking too close at this patch I'll note that we might want to improve the previous one first to also handle a constant 2nd operand for the operation (your new one also misses that). Yea, I think you mentioned in that in the 47477 BZ as well

Re: C/C++ PATCH to fix latest -Wbool-compare extension

2015-04-30 Thread Jeff Law
On 04/30/2015 07:17 AM, Marek Polacek wrote: The problem here was that the -Wbool-compare warning about always false/true comparisons with 0/1 was assuming that both operands are of a boolean type. That was wrong so check for that, but don't get confused about bools promoted to int. This bug is

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

2015-04-30 Thread Jeff Law
On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote: Hi, On 30 April 2015 at 07:00, Jeff Law wrote: On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote: 2012-09-21 H.J. Lu PR target/48904 * config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h. * c

Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-04-30 Thread Jeff Law
On 04/30/2015 09:34 AM, rohitarul...@freescale.com wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Thursday, April 30, 2015 8:32 PM To: Dharmakan Rohit-B30502; gcc-patches@gcc.gnu.org; rguent...@suse.de; Jakub Jelinek Cc: Alan Modra; David Edelsohn; Wienskoski E

Re: [PATCH][AArch64] Add alternative 'extr' pattern, calculate rtx cost properly

2015-04-30 Thread Marcus Shawcroft
On 27 April 2015 at 11:01, Kyrill Tkachov wrote: > 2015-04-27 Kyrylo Tkachov > > * config/aarch64/aarch64.md (*extr5_insn_alt): New pattern. > (*extrsi5_insn_uxtw_alt): Likewise. > * config/aarch64/aarch64.c (aarch64_extr_rtx_p): New function. > (aarch64_rtx_costs, IOR case): U

RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-04-30 Thread rohitarul...@freescale.com
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Thursday, April 30, 2015 8:32 PM > To: Dharmakan Rohit-B30502; gcc-patches@gcc.gnu.org; > rguent...@suse.de; Jakub Jelinek > Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797 > Subject: Re: [RFC: Patch, PR 60158]

Re: [PATCH][AArch64] Properly cost FABD pattern

2015-04-30 Thread Marcus Shawcroft
On 22 April 2015 at 17:01, Kyrill Tkachov wrote: > 2015-04-22 Kyrylo Tkachov > > * config/aarch64/aarch64.c (aarch64_rtx_costs): Handle pattern for > fabd in ABS case. OK /Marcus

Re: [PATCH][AArch64] Properly handle mvn-register and add EON+shift pattern and cost appropriately

2015-04-30 Thread Marcus Shawcroft
On 23 April 2015 at 17:57, Kyrill Tkachov wrote: > 2015-04-23 Kyrylo Tkachov > > * config/aarch64/aarch64.md > (*eor_one_cmpl_3_alt): > New pattern. > (*eor_one_cmpl_sidi3_alt_ze): Likewise. > * config/aarch64/aarch64.c (aarch64_rtx_costs): Handle MVN-shift >

Re: [PATCH][ARM] Do not lower cost of setting core reg to constant. It doesn't have any effect

2015-04-30 Thread Marcus Shawcroft
On 30 April 2015 at 16:22, Marcus Shawcroft wrote: > On 22 April 2015 at 17:18, Kyrill Tkachov wrote: > >> 2015-04-22 Kyrylo Tkachov >> >> * config/arm/arm.c (arm_new_rtx_costs): Do not lower cost >> immediate moves. > > OK > /Marcus Ignore that, I'm not allowed to make that call. Wai

Re: [PATCH][ARM] Do not lower cost of setting core reg to constant. It doesn't have any effect

2015-04-30 Thread Marcus Shawcroft
On 22 April 2015 at 17:18, Kyrill Tkachov wrote: > 2015-04-22 Kyrylo Tkachov > > * config/arm/arm.c (arm_new_rtx_costs): Do not lower cost > immediate moves. OK /Marcus

Re: [PATCH][AARCH64]Use shl for vec_shr_ rtx pattern.

2015-04-30 Thread Marcus Shawcroft
On 30 April 2015 at 12:55, Renlin Li wrote: > 2015-04-30 Renlin Li > > * config/aarch64/aarch64-simd.md (vec_shr): Defined as an unspec. > * config/aarch64/iterators.md (unspec): Add UNSPEC_VEC_SHR. > > gcc/testsuite/ChangeLog: > > 2015-04-30 Renlin Li > > * gcc.target/aarch64/v

Re: [PATCH, PR65915] Fix float conversion split.

2015-04-30 Thread H.J. Lu
On Thu, Apr 30, 2015 at 8:15 AM, Ilya Tocar wrote: >> Hi, >> >> Looks like I missed some splits, which caused PR65915. >> Patch below fixes it. >> Ok for trunk? >> >> 2015-04-28 Ilya Tocar >> >> * config/i386/i386.md (define_split): Check for xmm16+, >> when splitting scalar float c

Re: [PATCH, PR65915] Fix float conversion split.

2015-04-30 Thread Ilya Tocar
> Hi, > > Looks like I missed some splits, which caused PR65915. > Patch below fixes it. > Ok for trunk? > > 2015-04-28 Ilya Tocar > > * config/i386/i386.md (define_split): Check for xmm16+, > when splitting scalar float conversion. > > > --- > gcc/config/i386/i386.md | 8 +

Allow inlining across -fstrict-aliasing boundary

2015-04-30 Thread Jan Hubicka
Hi, this patch permits inlining across flag_strict_aliasing this is hopefully safe because te memory accesses in -fstrict-aliasing should have alias set 0. This should alllow to build packages that currently fail on always_inline because of use of explicit optimization attributes and hopefully als

Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-04-30 Thread Jeff Law
On 04/29/2015 04:30 AM, rohitarul...@freescale.com wrote: Jeff, I have made the changes as per your comments and attached the patch. If the patch is OK, I will proceed with the regression tests. This patch refers back to 60158 and based on what I see in 60158, it appears I should be looking f

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

2015-04-30 Thread Guillem Jover
Hi! On Thu, 2015-04-30 at 09:58:28 +0200, Bernhard Reutner-Fischer wrote: > On 30 April 2015 at 07:00, Jeff Law wrote: > > On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote: > >> > >> 2012-09-21 H.J. Lu > >> > >> PR target/48904 > >> * config.gcc (x86_64-*-knetbsd*-gnu): A

Re: [PATCH] [libstdc++] Add uniform container erasure.

2015-04-30 Thread Ed Smith-Rowland
And make_array, which isn't in the working paper yet, so I'd prefer to leave that part out for now. D'oh! Sorry about that.. Removed. The Doxygen @headername command tells users which header they are supposed to include, rather than this one. Since there is no header that's wrong. I'd just

RE: Refactor gcc/tree-vectorize.c:vectorize_loops

2015-04-30 Thread Aditya K
Thank you very much Jeff. -Aditya > Date: Wed, 29 Apr 2015 23:44:20 -0600 > From: l...@redhat.com > To: hiradi...@msn.com; ja...@redhat.com > CC: gcc-patches@gcc.gnu.org > Subject: Re: Refactor gcc/tree-vectorize.c:vectorize_loops > > On 04/29/2015 08:37 A

C++ PATCH for c++/65876 (ICE with constexpr and arrays)

2015-04-30 Thread Jason Merrill
In this testcase, we delay expanding the VEC_INIT_EXPR until gimplification time, at which point we've already thrown away some constexpr bodies. Since this location doesn't require a constant expression we can safely treat it as a non-constant expression. Tested x86_64-pc-linux-gnu, applying

Re: [Patch, fortran, PR44672, v5] [F08] ALLOCATE with SOURCE and no array-spec

2015-04-30 Thread Andre Vehreschild
Hi all, and also for this bug, I like to present an updated patch. It was brought to my attention, that the previous patch did not fix statements like: allocate(m, source=[(I, I=1, n)]) where n is a variable and type p class(*), allocatable :: m(:,:) end type real mat(2,3) type(P) :: o alloca

Re: c-family PATCH to improve -Wbool-compare (PR c/64610)

2015-04-30 Thread Andreas Schwab
Marek Polacek writes: > diff --git gcc/c-family/c-common.c gcc/c-family/c-common.c > index 7d314f8..ada8e8a 100644 > --- gcc/c-family/c-common.c > +++ gcc/c-family/c-common.c > @@ -11924,6 +11924,17 @@ maybe_warn_bool_compare (location_t loc, enum > tree_code code, tree op0, > } >else i

Re: C PATCH to reject va_arg (ap, void) (PR c/65901)

2015-04-30 Thread Marek Polacek
On Wed, Apr 29, 2015 at 06:41:22PM +0200, Marek Polacek wrote: > On Tue, Apr 28, 2015 at 09:07:09PM -0600, Martin Sebor wrote: > > The error message in the test cases below isn't quite right. > > The type of the aggregates isn't undefined, it's incomplete. > > Looking at the function, I wonder if t

Fix g++.dg/lto/20101010-4

2015-04-30 Thread Jan Hubicka
Hi, this patch fixes ICE when comparing NULLPTR_TYPEs. Comitted as obvious. Honza Index: ChangeLog === --- ChangeLog (revision 222620) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2015-04-30 Jan Hubicka + + PR lto/6594

C/C++ PATCH to fix latest -Wbool-compare extension

2015-04-30 Thread Marek Polacek
The problem here was that the -Wbool-compare warning about always false/true comparisons with 0/1 was assuming that both operands are of a boolean type. That was wrong so check for that, but don't get confused about bools promoted to int. This bug is blocking aarch64 bootstrap, so I'm taking the l

Re: [Patch, fortran, pr65548, 2nd take, v3] [5/6 Regression] gfc_conv_procedure_call

2015-04-30 Thread Andre Vehreschild
Hi all, this is just a service release. I encountered that the new testcase in the previous release included the testcase of the initial patch, that is already on trunk. I therefore replaced the testcase allocate_with_source_5.f90 by allocate_with_source_6.f90 (the extended testcase). Besides this

[PR testsuite/65205] Fix dg-shouldfail usage in OpenACC libgomp tests

2015-04-30 Thread Thomas Schwinge
Hi! Here is a patch, prepared by Jim Norris, to fix dg-shouldfail usage in OpenACC libgomp tests. It introduces two regressions (that is, makes the existing errors visible), which shall then be fixed later on: libgomp.oacc-c-c++-common/lib-3.c, and libgomp.oacc-c-c++-common/lib-42.c. As obvious,

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 02:33:44PM +0200, Jakub Jelinek wrote: > On Thu, Apr 30, 2015 at 08:25:14AM -0400, Trevor Saunders wrote: > > On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: > > > Trevor Saunders writes: > > > > > > > actually pointing out libojc/encoding.c was more useful

Re: [PATCH] [libstdc++] Add uniform container erasure.

2015-04-30 Thread Jonathan Wakely
On 30/04/15 07:33 -0400, Ed Smith-Rowland wrote: This has been in me tree for a good while. It is fairly simple and adds C++ experimental container erasure. And make_array, which isn't in the working paper yet, so I'd prefer to leave that part out for now. Index: include/experimental/erase_

Re: [PATCH, rs6000, testsuite, PR65456] Changes for unaligned vector load/store support on POWER8

2015-04-30 Thread Bill Schmidt
On Thu, 2015-04-30 at 18:26 +0800, Bin.Cheng wrote: > On Mon, Apr 27, 2015 at 9:26 PM, Bill Schmidt > wrote: > > On Mon, 2015-04-27 at 14:23 +0800, Bin.Cheng wrote: > >> On Mon, Mar 30, 2015 at 1:42 AM, Bill Schmidt > >> wrote: > > > >> > >> > Index: gcc/testsuite/gcc.dg/vect/vect-33.c > >> > ===

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Jakub Jelinek
On Thu, Apr 30, 2015 at 08:25:14AM -0400, Trevor Saunders wrote: > On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: > > Trevor Saunders writes: > > > > > actually pointing out libojc/encoding.c was more useful since that makes > > > it pretty clear the ifndef PCC_BITFIELD_TYPE_MATT

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: > Trevor Saunders writes: > > > actually pointing out libojc/encoding.c was more useful since that makes > > it pretty clear the ifndef PCC_BITFIELD_TYPE_MATTERS there just needs to > > be changed to #if ! > > That probably won't wo

Re: Mostly rewrite genrecog

2015-04-30 Thread Richard Biener
On Thu, Apr 30, 2015 at 2:08 PM, Andreas Schwab wrote: > Richard Sandiford writes: > >> Andreas Schwab writes: >>> Richard Sandiford writes: >>> /* Represents a test and the action that should be taken on the result. If a transition exists for the test outcome, the machine switches

Re: [PATCH 4/4] match.pd: Add x + ((-x) & m) -> (x + m) & ~m pattern

2015-04-30 Thread Richard Biener
On Thu, Apr 30, 2015 at 1:44 PM, Marc Glisse wrote: > On Thu, 30 Apr 2015, Richard Biener wrote: > >> On Wed, Jan 21, 2015 at 11:49 AM, Rasmus Villemoes >> wrote: >>> >>> Generalizing the x+(x&1) pattern, one can round up x to a multiple of >>> a 2^k by adding the negative of x modulo 2^k. But it

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Andreas Schwab
Trevor Saunders writes: > I think true is a defined identifier since this is compiled as c11. > > tbsaunde@iceball:/src/gcc1-opt$ cat test.c > #define FOO true > #if !FOO > hello > #endif > tbsaunde@iceball:/src/gcc1-opt$ gcc/xgcc -B gcc/ -E test.c > # 1 "test.c" > # 1 "" > # 1 "" > # 1 "/usr/inc

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Jakub Jelinek
On Thu, Apr 30, 2015 at 07:58:33AM -0400, Trevor Saunders wrote: > On Thu, Apr 30, 2015 at 08:54:05AM +0200, Andreas Schwab wrote: > > Trevor Saunders writes: > > > > >> diff --git a/libobjc/encoding.c b/libobjc/encoding.c > > >> index 7333908..20ace46 100644 > > >> --- a/libobjc/encoding.c > > >

Re: [PATCH][AArch64] Properly handle SHIFT ops and EXTEND in aarch64_rtx_mult_cost

2015-04-30 Thread Marcus Shawcroft
On 20 April 2015 at 17:35, Kyrill Tkachov wrote: > Hi all, > > The aarch64_rtx_mult_cost helper is supposed to handle multiplication costs > as well as > PLUS/MINUS operations combined with multiplication or shift operations. The > shift > operations may contain an extension. Currently we do not h

Re: [RFC][PATCH 2/3] Propagate and save value ranges wrapped information

2015-04-30 Thread Richard Biener
On Thu, 30 Apr 2015, Jakub Jelinek wrote: > On Thu, Apr 30, 2015 at 01:35:25PM +0200, Richard Biener wrote: > > I've long pondered with replacing the VRP overflow checking code > > (for -fstrict-overflow) with keeping two lattices - one honoring undefined > > overflow and one not and then comparin

Re: [PATCH] add self-tuning to x86 hardware fast path in libitm

2015-04-30 Thread Nuno Diegues
> Patch looks good to me now. It would be perhaps nice to have an > environment variable to turn the adaptive algorithm off for tests, > but that's not critical. Yes, that makes perfect sense. > It would be also nice to test it on something else, but I understand > it's difficult to find other s

Re: [PATCH][AArch64] Properly cost MNEG/[SU]MNEGL patterns

2015-04-30 Thread Marcus Shawcroft
On 20 April 2015 at 17:36, Kyrill Tkachov wrote: > Hi all, > > Currently we do not handle the MNEG patterns properly in rtx costs. > These instructions are similar to the MSUB ones. > This patch handles them by catching the NEG at the appropriate position, > extracting its operands and letting the

Re: [PATCH][AArch64] Use extend_arith rtx cost appropriately

2015-04-30 Thread Marcus Shawcroft
On 20 April 2015 at 17:48, Kyrill Tkachov wrote: > Hi all, > > When calculating the rtx costs of an arithmetic operation combined with > zero or sign extension of its operand we should use the extend_arith > cost rather than the arith_shift cost. > > Bootstrapped and tested on aarch64-linux. > Ok

Re: Mostly rewrite genrecog

2015-04-30 Thread Andreas Schwab
Richard Sandiford writes: > Andreas Schwab writes: >> Richard Sandiford writes: >> >>> /* Represents a test and the action that should be taken on the result. >>>If a transition exists for the test outcome, the machine switches >>>to the transition's target state. If no suitable transi

Re: [PATCH][expr.c] PR 65358 Avoid clobbering partial argument during sibcall

2015-04-30 Thread Kyrill Tkachov
On 28/04/15 10:54, Kyrill Tkachov wrote: On 27/04/15 21:13, Jeff Law wrote: On 04/21/2015 11:33 AM, Kyrill Tkachov wrote: On 21/04/15 15:09, Jeff Law wrote: On 04/21/2015 02:30 AM, Kyrill Tkachov wrote: From reading config/stormy16/stormy-abi it seems to me that we don't pass arguments p

[PING] AArch64 costs patches

2015-04-30 Thread Kyrill Tkachov
Hi all, I'd like to ping these 3 aarch64 costs patches. [AArch64] Use extend_arith rtx cost appropriately: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01051.html [AArch64] Properly cost MNEG/[SU]MNEGL patterns https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01050.html [AArch64] Properly handle

Re: [PATCH][ARM] Handle UNSPEC_VOLATILE in rtx costs and don't recurse inside the unspec

2015-04-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01047.html Thanks, Kyrill On 20/04/15 17:28, Kyrill Tkachov wrote: Hi all, A pet project of mine is to get to the point where backend rtx costs functions won't have to handle rtxes that don't match down to any patterns/expanders we have. Or

Re: [PATCH][ARM][stage-1] Initialise cost to COSTS_N_INSNS (1) and increment in arm rtx costs

2015-04-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01130.html Thanks, Kyrill On 21/04/15 10:11, Kyrill Tkachov wrote: Hi all, This is the first of a series to clean up and simplify the arm rtx costs function. This patch initialises the cost to COSTS_N_INSNS (1) at the top and increments it

Re: [PATCH][AArch64] Properly cost FABD pattern

2015-04-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01329.html Thanks, Kyrill On 22/04/15 17:01, Kyrill Tkachov wrote: Hi all, In rtx costs we do not handle the FP abs (minus (a b)) case which maps down to a FABD instruction. This patch fixes that. FABD behaves similarly to the FADD class of i

Re: [PATCH][ARM] Do not lower cost of setting core reg to constant. It doesn't have any effect

2015-04-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01330.html Thanks, Kyrill On 22/04/15 17:18, Kyrill Tkachov wrote: Hi all, This hunk that slightly reduces the cost of immediate moves doesn't actually have any effect. In the whole of SPEC2006 it didn't make a difference. In any case, I'd l

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 08:54:05AM +0200, Andreas Schwab wrote: > Trevor Saunders writes: > > >> diff --git a/libobjc/encoding.c b/libobjc/encoding.c > >> index 7333908..20ace46 100644 > >> --- a/libobjc/encoding.c > >> +++ b/libobjc/encoding.c > >> @@ -1167,7 +1167,7 @@ objc_layout_structure_nex

Re: [PATCH][AArch64] Properly handle mvn-register and add EON+shift pattern and cost appropriately

2015-04-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01434.html Thanks, Kyrill On 23/04/15 17:57, Kyrill Tkachov wrote: [resending due to mail client messing up.] Hi all, The EON instruction can be expressed either by (xor (not a) b) or (not (xor a b)), simplify-rtx canonicalizes to the second

Re: [PATCH][AARCH64]Use shl for vec_shr_ rtx pattern.

2015-04-30 Thread Renlin Li
Hi Marcus, On 29/04/15 13:06, Marcus Shawcroft wrote: I think there is another issue here, this change: if (BYTES_BIG_ENDIAN) - return "ushl %d0, %d1, %2"; + return "shl %d0, %d1, %2"; else return "ushr %d0, %d1, %2"; is in the context of: (define_insn "vec_shr_"

Re: Mostly rewrite genrecog

2015-04-30 Thread Richard Sandiford
Bin.Cheng writes: > Hi Richard, > I noticed that this patch caused ICE for gcc.target/arm/mmx-2.c on > arm-none-linux-gnueabi. Could you please have a look at it? > > The log message is as below, > /projects/.../src/gcc/gcc/testsuite/gcc.target/arm/mmx-2.c: In function 'foo': > /projects/.../src/

Re: [PATCH 4/4] match.pd: Add x + ((-x) & m) -> (x + m) & ~m pattern

2015-04-30 Thread Marc Glisse
On Thu, 30 Apr 2015, Richard Biener wrote: On Wed, Jan 21, 2015 at 11:49 AM, Rasmus Villemoes wrote: Generalizing the x+(x&1) pattern, one can round up x to a multiple of a 2^k by adding the negative of x modulo 2^k. But it is fewer instructions, and presumably requires fewer registers, to do

  1   2   >