Re: [PATCH][tree-ssa-math-opts] Expand pow (x, CONST) using square roots when possible

2015-05-08 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00071.html Thanks, Kyrill On 01/05/15 17:02, Kyrill Tkachov wrote: Hi all, GCC has some logic to expand calls to pow (x, 0.75), pow (0.25) and pow (x, (int)k + 0.5) using square roots. So, for the above examples it would generate sqrt (x) *

Re: [PATCH, ARM] attribute target (thumb,arm) [4/6] respin (4th)

2015-05-08 Thread Ramana Radhakrishnan
I'm still playing with the code, so this is a partial review. We should prevent inlining of ARM state functions into functions we know will be T16 if !TARGET_SOFT_FLOAT on the grounds that the architecture doesn't have floating point instruction encodings in the T16 ISA (Thumb1). We'll just

Re: [libgomp, testsuite] Support parallel testing in libgomp (PR libgomp/66005)

2015-05-08 Thread Thomas Schwinge
Hi! On Thu, 7 May 2015 13:39:40 +0200, Jakub Jelinek ja...@redhat.com wrote: On Thu, May 07, 2015 at 01:26:57PM +0200, Rainer Orth wrote: As reported in the PR, with the addition of all those OpenACC tests, libgomp make check times have skyrocketed since the testsuite is still run

Re: [PATCH, ARM] attribute target (thumb,arm) [5/6] respin (4th)

2015-05-08 Thread Ramana Radhakrishnan
On 06/05/15 15:27, Christian Bruel wrote: Implements the hooks for #pragma GCC target A test included to check that macros were correctly defined/undefined on pragma regions. Thanks Christian Missing the hooks - this only appears to have the test. Ramana

Re: Enhance std::hash for pointers

2015-05-08 Thread Richard Biener
On Wed, May 6, 2015 at 10:10 PM, François Dumont frs.dum...@gmail.com wrote: Hi Following Marc Glisse comment #4 on:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65641 I would like to propose this enhancement to the hash functor for pointers. It simply gets rid of the irrelevant bits on

Re: PR 64454: Improve VRP for %

2015-05-08 Thread Richard Biener
On Mon, May 4, 2015 at 3:57 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 4 May 2015, Richard Biener wrote: On Sat, May 2, 2015 at 12:46 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, this patch tries to tighten a bit the range estimate for x%y. slp-perm-7.c started failing by

Re: [PATCH] Simple optimization for MASK_STORE.

2015-05-08 Thread Richard Biener
On Wed, May 6, 2015 at 4:04 PM, Yuri Rumyantsev ysrum...@gmail.com wrote: Hi All, Here is a patch which gives us significant speed-up on HASWELL for test containing masked stores. The main goal of that patch is attempt to avoid HW hazard for maskmove instructions through inserting additional

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

2015-05-08 Thread Bernhard Reutner-Fischer
On 1 May 2015 at 01:23, Trevor Saunders tbsau...@tbsaunde.org wrote: On Thu, Apr 30, 2015 at 11:58:09PM +0200, Bernhard Reutner-Fischer wrote: On April 30, 2015 5:53:02 PM GMT+02:00, Jeff Law l...@redhat.com wrote: On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote: Hi, On 30 April

Re: [PATCH 0/13] Add musl support to GCC

2015-05-08 Thread Kyrill Tkachov
On 07/05/15 19:07, Jeff Law wrote: On 05/06/2015 05:36 AM, Szabolcs Nagy wrote: On 30/04/15 00:18, Joseph Myers wrote: On Wed, 29 Apr 2015, Szabolcs Nagy wrote: only affects [u]int_fastN_t types (on 64bit systems for N=16,32 musl uses int but glibc uses long) i can fix glibc-stdint.h, but

Re: [PATCH, doc] fix match-and-simplify API doc errors

2015-05-08 Thread Richard Biener
On Fri, May 8, 2015 at 1:37 AM, Jim Wilson jim.wil...@linaro.org wrote: I noticed this while reading the match-and-simplify docs. The gimple_simplify API list has two built-in function cases with three tree args. The last one is supposed to have four tree args for a ternary function (3

Re: PATCH: PR target/48904: x86_64-knetbsd-gnu fails to build

2015-05-08 Thread Bernhard Reutner-Fischer
On 21 September 2012 at 21:11, H.J. Lu hongjiu...@intel.com wrote: Hi, This patch adds i386/knetbsd-gnu64.h for x86_64-knetbsd-gnu. OK to install? I now installed this to trunk as r222903 after Jeff's approval. Thanks! Thanks. H.J. --- 2012-09-21 H.J. Lu hongjiu...@intel.com

Re: [PATCH 2/13] musl libc config

2015-05-08 Thread Kyrill Tkachov
On 07/05/15 19:02, Jeff Law wrote: On 05/06/2015 05:24 AM, Szabolcs Nagy wrote: On 29/04/15 00:30, Joseph Myers wrote: On Mon, 20 Apr 2015, Szabolcs Nagy wrote: * config/linux.opt (mmusl): New option. New -m options need documenting in invoke.texi. Patch v3. Now with

genrecog: Address -Wsign-compare diagnostics (was: Mostly rewrite genrecog)

2015-05-08 Thread Thomas Schwinge
Hi! On Mon, 27 Apr 2015 11:20:30 +0100, Richard Sandiford richard.sandif...@arm.com wrote: This patch [...] by replacing most of genrecog [...] OK to commit? Is it a bug that I'm seeing these warnings only in the stage 1 build with the bootstrap GCC 4.6 compiler, but not anymore later on? (I

[PATCH PR65447]Improve IV handling by grouping address type uses with same base and step

2015-05-08 Thread Bin Cheng
Hi, GCC's IVO currently handles every IV use independently, which is not right by learning from cases reported in PR65447. The rationale is: 1) Lots of address type IVs refer to the same memory object, share similar base and have same step. We should handle these IVs as a group in order to

Re: [Patch, Fortran, PR58586, v3] ICE with derived type with allocatable component passed by value

2015-05-08 Thread Andre Vehreschild
Hi Mikael, thanks for the review. I still have some questions/remarks before commiting: On Thu, 07 May 2015 12:14:59 +0200 Mikael Morin mikael.mo...@sfr.fr wrote: snip @@ -2158,6 +2158,8 @@ build_function_decl (gfc_symbol * sym, bool global) gfc_set_decl_assembler_name (fndecl,

RE: [patch 0/27] RFC: Use automake-1.11.6 across the tree

2015-05-08 Thread Bernd Edlinger
Hi Michael, On Thu, 7 May 2015 18:52:52, Michael Haubenwallner wrote: Hi Bernd, On 05/06/2015 03:01 PM, Bernd Edlinger wrote: On Tue, 5 May 2015 18:03:15, Michael Haubenwallner wrote: Now that gcc-5 is out, what about an automake-1.11.6 update for gcc-6? BTW, the actual commands I use to

Re: [patch 3/28] fixincludes: Use automake-1.11.6 (across the tree)

2015-05-08 Thread Michael Haubenwallner
On 05/08/2015 12:10 AM, Bruce Korb wrote: On 05/06/15 01:58, Michael Haubenwallner wrote: Trivial patch for fixincludes. A) sufficiently trivial that explicit permission ought not be required Agreed for the actual code change - more important is to notify the automake revbump. B) it is

Re: [PATCH][tree-ssa-math-opts] Expand pow (x, CONST) using square roots when possible

2015-05-08 Thread Richard Biener
On Fri, May 1, 2015 at 6:02 PM, Kyrill Tkachov kyrylo.tkac...@foss.arm.com wrote: Hi all, GCC has some logic to expand calls to pow (x, 0.75), pow (0.25) and pow (x, (int)k + 0.5) using square roots. So, for the above examples it would generate sqrt (x) * sqrt (sqrt (x)), sqrt (sqrt (x))

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Eric Botcazou
@@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for all global type declarations first. This - ensures that global types whose compilation hasn't been finalized yet, -

Re: Remove mode argument from gen_rtx_SET

2015-05-08 Thread Franz Sirl
Am 2015-05-07 um 13:37 schrieb Richard Sandiford: One problem with the automatically-generated gen_rtx_FOO () macros is that they always have a mode parameter, even for codes like SET where the mode should always be VOIDmode. This inevitably leads to cases where a caller accidentally passes

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Richard Biener
On Fri, May 8, 2015 at 12:26 PM, Eric Botcazou ebotca...@adacore.com wrote: @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for all global type declarations first. This -

Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations

2015-05-08 Thread Richard Biener
On Tue, Nov 4, 2014 at 11:44 AM, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 25 September 2014 04:45, Michael Collison michael.colli...@linaro.org wrote: On certain patterns in atomics.md the constraint 'n' is used in combination with the predicate atomic_op_operand. The constraint

Re: Fix logic error in Fortran OpenACC parsing

2015-05-08 Thread Ilmir Usmanov
Hi! On 06.05.2015 14:38, Thomas Schwinge wrote: Hi! On Tue, 5 May 2015 15:38:03 -0400, David Malcolm dmalc...@redhat.com wrote: On Wed, 2015-04-29 at 14:10 +0200, Mikael Morin wrote: Le 29/04/2015 02:02, David Malcolm a écrit : diff --git a/gcc/fortran/parse.c b/gcc/fortran/parse.c index

Re: Remove mode argument from gen_rtx_SET

2015-05-08 Thread Richard Sandiford
Franz Sirl franz.sirl-ker...@lauterbach.com writes: Am 2015-05-08 um 13:57 schrieb Segher Boessenkool: On Fri, May 08, 2015 at 12:32:30PM +0200, Franz Sirl wrote: this patch (r222882 is fine, r222883 fails) breaks bootstrap for me on x86_64-linux-gnu: i386.md has set:BND twice; replace that

Re: [PATCH] rs6000: Fix peephole

2015-05-08 Thread Segher Boessenkool
On Fri, May 08, 2015 at 10:18:46AM -0400, David Edelsohn wrote: 2015-05-08 Segher Boessenkool seg...@kernel.crashing.org * config/rs6000/rs6000.md: Require operand inequality in one of the peepholes. Okay. Is there an artificial testcase? I don't have one.

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 03:35 AM, Richard Biener wrote: On Fri, May 8, 2015 at 12:26 PM, Eric Botcazou ebotca...@adacore.com wrote: @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for

Re: [PATCH][PR66013] Update address_taken after ifn_va_arg expansion

2015-05-08 Thread Richard Biener
On Fri, May 8, 2015 at 5:13 PM, Tom de Vries tom_devr...@mentor.com wrote: Hi, this patch fixes PR66013. I. Consider this test-case, with a va_list passed from f2 to f2_1: ... #include stdarg.h inline int __attribute__((always_inline)) f2_1 (va_list ap) { return va_arg (ap, int);

[PATCH] rs6000: Fix peephole

2015-05-08 Thread Segher Boessenkool
This peephole transforms lis a,HI ; ori a,a,LO cmpw c,a,b ; beq c,... to xoris a,b,HI1 cmpwi c,a,LO1 ; beq c,... when a and c are dead after this. But it forgets to check that a and b are not the same reg, generating non-sensical code. This patch fixes that. Tested etc.; is this

RE: [PATCH 6/13] mips musl support

2015-05-08 Thread Matthew Fortune
H.J. Lu hjl.to...@gmail.com writes: On Mon, Apr 27, 2015 at 7:40 AM, Szabolcs Nagy szabolcs.n...@arm.com wrote: On 21/04/15 15:59, Matthew Fortune wrote: Rich Felker dal...@libc.org writes: On Tue, Apr 21, 2015 at 01:58:02PM +, Matthew Fortune wrote: There does however appear to

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Szabolcs Nagy
On 08/05/15 15:25, Matthew Fortune wrote: H.J. Lu hjl.to...@gmail.com writes: On Mon, Apr 27, 2015 at 7:40 AM, Szabolcs Nagy szabolcs.n...@arm.com wrote: On 21/04/15 15:59, Matthew Fortune wrote: Rich Felker dal...@libc.org writes: On Tue, Apr 21, 2015 at 01:58:02PM +, Matthew

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Kyrill Tkachov
On 08/05/15 16:13, Szabolcs Nagy wrote: On 08/05/15 15:46, Matthew Fortune wrote: Szabolcs Nagy szabolcs.n...@arm.com writes: if you think that's ok, i can now submit the patch with %{msoft-float:- sf} added to all abi variants. That's fine. Go ahead. the patch for the record. I've

Re: [Patch, fortran, pr65894, v1] [6 Regression] severe regression in gfortran 6.0.0

2015-05-08 Thread Steve Kargl
On Fri, May 08, 2015 at 01:54:17PM +0200, Andre Vehreschild wrote: I do not have the privileges to do a review so I can't help you there. Good luck finding a reviewer. You probably understand this area of code as well as anyone else, and your contributions to gfortran over the last few

Re: [RFC 0/6] Flags outputs for asms

2015-05-08 Thread Jay Foad
On 8 May 2015 at 16:23, Richard Henderson r...@redhat.com wrote: Yes, the i386 backend has not implemented conditional sibcalls. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60159 Jay.

Re: [Patch, fortran, pr65894, v1] [6 Regression] severe regression in gfortran 6.0.0

2015-05-08 Thread Mikael Morin
Le 08/05/2015 13:54, Andre Vehreschild a écrit : Hi Mikael, at first I tried to fix this issue with the scalarizer, too, but I could not grasp how the scalarizer was working. Do you have any documentation, how it is meant to be? I mean, I have read the comments in the code, but those are

[RFA] libiberty/mkstemps.c: Include time.h if sys/time.h not available.

2015-05-08 Thread Joel Brobecker
Hello, Attempting to build libiberty on LynxOS-178 fails trying to compile mkstemps.c with the following error: mkstemps.c:84:18: error: storage size of 'tv' isn't known struct timeval tv; ^ This file would normally include sys/time.h to get the type's

Re: [patch 0/10] debug-early merge

2015-05-08 Thread David Malcolm
On Thu, 2015-05-07 at 17:30 -0700, Aldy Hernandez wrote: Hi folks. I have divided the patches into 10 pieces. The patches are interdependent and cannot be applied independently. I am merely dividing them up to aid the relevant reviewers. As I've mentioned elsewhere, the patchset as

RE: [PATCH 6/13] mips musl support

2015-05-08 Thread Matthew Fortune
Szabolcs Nagy szabolcs.n...@arm.com writes: On 08/05/15 15:25, Matthew Fortune wrote: H.J. Lu hjl.to...@gmail.com writes: On Mon, Apr 27, 2015 at 7:40 AM, Szabolcs Nagy szabolcs.n...@arm.com wrote: On 21/04/15 15:59, Matthew Fortune wrote: Rich Felker dal...@libc.org writes: On

Re: [Patch, Fortran, PR58586, v3] ICE with derived type with allocatable component passed by value

2015-05-08 Thread Andre Vehreschild
Hi Mikael, ?? I don't get you there? What do you mean? Do you think the alloc_comp_class_3/4.* are not correctly testing the issue? Any idea of how to test this better? I mean the pr is about this artificial constructs. I merely struck it in search of a pr about allocatable components.

Re: [Patch, Fortran, PR58586, v3] ICE with derived type with allocatable component passed by value

2015-05-08 Thread Andre Vehreschild
Hi, so attached is a quick and dirty solution for the allocatable return value problem. I personally don't like it. It is making a special case from the assign a function result to a variable. May be you have a better idea how to do this in gfortran style. - Andre On Fri, 8 May 2015 15:31:46

Re: PR 64454: Improve VRP for %

2015-05-08 Thread Marc Glisse
Hello, here is a rewrite of the patch, using wide_int, and improving a bit the result. Same ChangeLog, tested again on x86_64-linux-gnu. -- Marc GlisseIndex: gcc/testsuite/gcc.dg/tree-ssa/vrp97.c === ---

Re: [PATCH][tree-ssa-math-opts] Expand pow (x, CONST) using square roots when possible

2015-05-08 Thread Kyrill Tkachov
On 08/05/15 14:56, Kyrill Tkachov wrote: On 08/05/15 11:18, Richard Biener wrote: On Fri, May 1, 2015 at 6:02 PM, Kyrill Tkachov kyrylo.tkac...@foss.arm.com wrote: Hi all, GCC has some logic to expand calls to pow (x, 0.75), pow (0.25) and pow (x, (int)k + 0.5) using square roots. So, for

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Szabolcs Nagy
On 08/05/15 14:56, H.J. Lu wrote: On Mon, Apr 27, 2015 at 7:40 AM, Szabolcs Nagy szabolcs.n...@arm.com wrote: On 21/04/15 15:59, Matthew Fortune wrote: Rich Felker dal...@libc.org writes: On Tue, Apr 21, 2015 at 01:58:02PM +, Matthew Fortune wrote: There does however appear to be both

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Rich Felker
On Fri, May 08, 2015 at 03:41:31PM +0100, Szabolcs Nagy wrote: I.e. as it stands this patch is not OK for backporting to GCC 5 without further discussion. There is also the perspective that we should be able to aim for an ABI variant agnostic dynamic linker at some point over the next

Re: [PATCH][tree-ssa-math-opts] Expand pow (x, CONST) using square roots when possible

2015-05-08 Thread Kyrill Tkachov
On 08/05/15 11:18, Richard Biener wrote: On Fri, May 1, 2015 at 6:02 PM, Kyrill Tkachov kyrylo.tkac...@foss.arm.com wrote: Hi all, GCC has some logic to expand calls to pow (x, 0.75), pow (0.25) and pow (x, (int)k + 0.5) using square roots. So, for the above examples it would generate sqrt

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread H.J. Lu
On Mon, Apr 27, 2015 at 7:40 AM, Szabolcs Nagy szabolcs.n...@arm.com wrote: On 21/04/15 15:59, Matthew Fortune wrote: Rich Felker dal...@libc.org writes: On Tue, Apr 21, 2015 at 01:58:02PM +, Matthew Fortune wrote: There does however appear to be both soft and hard float variants Patch

Re: genrecog: Address -Wsign-compare diagnostics

2015-05-08 Thread Richard Sandiford
Thomas Schwinge tho...@codesourcery.com writes: Hi! On Mon, 27 Apr 2015 11:20:30 +0100, Richard Sandiford richard.sandif...@arm.com wrote: This patch [...] by replacing most of genrecog [...] OK to commit? Looks good to me FWIW. Probably counts as obvious. Thanks, Richard

Re: [patch 0/10] debug-early merge

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 07:41 AM, David Malcolm wrote: On Thu, 2015-05-07 at 17:30 -0700, Aldy Hernandez wrote: Hi folks. I have divided the patches into 10 pieces. The patches are interdependent and cannot be applied independently. I am merely dividing them up to aid the relevant reviewers. As I've

[PATCH][PR66013] Update address_taken after ifn_va_arg expansion

2015-05-08 Thread Tom de Vries
Hi, this patch fixes PR66013. I. Consider this test-case, with a va_list passed from f2 to f2_1: ... #include stdarg.h inline int __attribute__((always_inline)) f2_1 (va_list ap) { return va_arg (ap, int); } int f2 (int i, ...) { int res; va_list ap; va_start (ap, i); res = f2_1

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Szabolcs Nagy
On 08/05/15 15:46, Matthew Fortune wrote: Szabolcs Nagy szabolcs.n...@arm.com writes: if you think that's ok, i can now submit the patch with %{msoft-float:- sf} added to all abi variants. That's fine. Go ahead. the patch for the record. Changelog: 2015-05-08 Gregor Richards

Re: PR 64454: Improve VRP for %

2015-05-08 Thread Richard Biener
On Fri, May 8, 2015 at 4:59 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, here is a rewrite of the patch, using wide_int, and improving a bit the result. Same ChangeLog, tested again on x86_64-linux-gnu. Please use /* */ for comments. Otherwise ok! Thanks, Richard. -- Marc Glisse

Re: [Patch, Fortran, PR58586, v3] ICE with derived type with allocatable component passed by value

2015-05-08 Thread Mikael Morin
Le 08/05/2015 12:54, Andre Vehreschild a écrit : Hi Mikael, thanks for the review. I still have some questions/remarks before commiting: @@ -5898,8 +5900,21 @@ gfc_generate_function_code (gfc_namespace * ns) if (TREE_TYPE (DECL_RESULT (fndecl)) != void_type_node) { + bool

[Patch, Fortran, 66035, v1] [5/6 Regression] gfortran ICE segfault

2015-05-08 Thread Andre Vehreschild
Hi all, please find attached a patch for 66035. An ICE occurred when in a structure constructor an allocatable component of type class was initialized with an existing class object. This was caused by - the size of the memory to allocate for the component was miscalculated, - the vptr was not

Re: [PATCH] rs6000: Fix peephole

2015-05-08 Thread David Edelsohn
On Fri, May 8, 2015 at 9:38 AM, Segher Boessenkool seg...@kernel.crashing.org wrote: This peephole transforms lis a,HI ; ori a,a,LO cmpw c,a,b ; beq c,... to xoris a,b,HI1 cmpwi c,a,LO1 ; beq c,... when a and c are dead after this. But it forgets to check that a and b are not

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Rich Felker
On Fri, May 08, 2015 at 02:25:11PM +, Matthew Fortune wrote: H.J. Lu hjl.to...@gmail.com writes: On Mon, Apr 27, 2015 at 7:40 AM, Szabolcs Nagy szabolcs.n...@arm.com wrote: On 21/04/15 15:59, Matthew Fortune wrote: Rich Felker dal...@libc.org writes: On Tue, Apr 21, 2015 at

[PATCH] Vectorize strided group loads

2015-05-08 Thread Richard Biener
Currently the vectorizer forces unrolling for grouped loads that have DR_STEP not constant, forcing the elements loaded with strided load support. The following patch enhances that machinery to deal with SLP used groups that have non-constant DR_STEP, avoiding the excessive unrolling (and

Re: [RFC 0/6] Flags outputs for asms

2015-05-08 Thread Richard Henderson
On 05/07/2015 06:20 PM, H. Peter Anvin wrote: This is a separate issue which really shouldn't have anything to do with this, but is there a specific reason why: void good1(int x, int y) { _Bool pf; asm(cmpl %2,%1 : =@ccp (pf) : r (x), g (y)); if (pf) beta();

Re: [RFC 0/6] Flags outputs for asms

2015-05-08 Thread Jeff Law
On 05/08/2015 09:23 AM, Richard Henderson wrote: On 05/07/2015 06:20 PM, H. Peter Anvin wrote: This is a separate issue which really shouldn't have anything to do with this, but is there a specific reason why: void good1(int x, int y) { _Bool pf; asm(cmpl %2,%1 : =@ccp (pf)

RE: [patch 1/28] top-level: Use automake-1.11.6

2015-05-08 Thread Joseph Myers
On Fri, 8 May 2015, Bernd Edlinger wrote: One example where there is an incompatibility is missing: Formerly it had code that emulated the missing flex by creating a dummy lex.yy.c from the hopefully installed pre-compiled flex output file.  But the version from the trunk does nothing,

[PATCH 3/5] Use FPIE_OR_FPIC_SPEC in CRIS_ASM_SUBTARGET_SPEC

2015-05-08 Thread H.J. Lu
OK for trunk? H.J. * config/cris/linux.h (CRIS_ASM_SUBTARGET_SPEC): Use FPIE_OR_FPIC_SPEC. --- gcc/config/cris/linux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/cris/linux.h b/gcc/config/cris/linux.h index bd57986..262aac5 100644 ---

[PATCH 2/5] Use NO_FPIE_AND_FPIC_SPEC in NO_SHARED_SPECS

2015-05-08 Thread H.J. Lu
OK for trunk? * config/mips/gnu-user.h (NO_SHARED_SPECS): Use NO_FPIE_AND_FPIC_SPEC. --- gcc/config/mips/gnu-user.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/mips/gnu-user.h b/gcc/config/mips/gnu-user.h index 28b00ed..dd4cf11 100644 ---

Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

2015-05-08 Thread Markus Trippelsdorf
On 2015.05.08 at 09:38 -0700, Steve Ellcey wrote: This patch has broken the glibc build. I am not sure if the problem is a bug in your patch or a bug in the code used by glibc. Here is a cutdown test case from glibc (timezone/scheck.c). This code compiled before your patch but now it

Re: [Patch, fortran] PR 37131, inline matmul

2015-05-08 Thread H.J. Lu
On Mon, May 4, 2015 at 11:25 PM, Thomas Koenig tkoe...@netcologne.de wrote: Hello world, this is an update of the matmul inline patch. The only difference to the last version is that it has the ubound simplification taken out. Any further comments? OK for trunk? Thomas

Re: [RFA] libiberty/mkstemps.c: Include time.h if sys/time.h not available.

2015-05-08 Thread Joel Brobecker
* mkstemps.c: #include time.h if HAVE_TIME_H is defined but not HAVE_SYS_TIME_H. Ok. Thank you, DJ. Pushed to both GCC and binutils-gdb. -- Joel

Re: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-08 Thread H.J. Lu
On Thu, May 7, 2015 at 2:17 PM, Joseph Myers jos...@codesourcery.com wrote: On Fri, 6 Mar 2015, H.J. Lu wrote: +# We don't want to compile the compiler with -fPIE, it make PCH fail. +COMPILER += @NO_PIE_CFLAGS@ + +# Link with -no-pie since we compile the compiler with -fno-PIE. +LINKER +=

Re: [RFC 0/6] Flags outputs for asms

2015-05-08 Thread H. Peter Anvin
On 05/08/2015 08:54 AM, Richard Henderson wrote: Anyway, I'll look into whether the branch around alpha can be optimized, but I'd be shocked if I'd be able to do anything about the branch around beta. True, there's nothing in between that will clobber the flags so it would be an excellent

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Joseph Myers
On Fri, 8 May 2015, Rich Felker wrote: On Fri, May 08, 2015 at 03:41:31PM +0100, Szabolcs Nagy wrote: I.e. as it stands this patch is not OK for backporting to GCC 5 without further discussion. There is also the perspective that we should be able to aim for an ABI variant

Re: [RFC 0/6] Flags outputs for asms

2015-05-08 Thread Richard Henderson
On 05/07/2015 06:15 PM, H. Peter Anvin wrote: /* This case really should produce good code in both cases */ void good1(int x, int y) { _Bool pf; asm(cmpl %2,%1 : =@ccp (pf) : r (x), g (y)); if (pf) beta(); } void bad1(int x, int y) { _Bool le, pf;

Re: [patch 1/10] debug-early merge: Ada front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 03:26 AM, Eric Botcazou wrote: @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void) types_used_by_var_decl_insert (t, dummy_global); } } - - /* Output debug information for all global type declarations first. This - ensures that global types

[PATCH 5/5] Use FPIE_OR_FPIC_SPEC in ASM_SPEC

2015-05-08 Thread H.J. Lu
OK for trunk? H.J. * config/sparc/linux.h (ASM_SPEC): Use FPIE_OR_FPIC_SPEC. * config/sparc/linux64.h (ASM_SPEC): Likewise. --- gcc/config/sparc/linux.h | 2 +- gcc/config/sparc/linux64.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 4/5] Use FPIE_OR_FPIC_SPEC in ASM_SPEC

2015-05-08 Thread H.J. Lu
OK for trunk? H.J. * config/rs6000/sysv4.h (ASM_SPEC): Use FPIE_OR_FPIC_SPEC. --- gcc/config/rs6000/sysv4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/rs6000/sysv4.h b/gcc/config/rs6000/sysv4.h index 9917c2f..1041648 100644 ---

Re: Remove mode argument from gen_rtx_SET

2015-05-08 Thread DJ Delorie
; This pattern is identical to the truncsipsi2 pattern except ; that it uses a SUBREG instead of a TRUNC. It is needed in ; order to prevent reload from converting (set:SI (SUBREG:PSI (SI))) ; into (SET:PSI (PSI)). I'm not sure what that's supposed to mean (what's an SI set of a PSI

[PATCH, alpha]: Remove dead (HOST_BITS_PER_WIDE_INT 64) code

2015-05-08 Thread Uros Bizjak
... to prepare alpha for TARGET_SUPPORTS_WIDE_INT switch. 2015-05-08 Uros Bizjak ubiz...@gmail.com * config/alpha/alpha.c (alpha_emit_set_const_1) (alpha_emit_set_long_const, alpha_extract_integer) (alpha_legitimate_constant_p, alpha_split_const_mov) (alpha_expand_block_clear,

Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

2015-05-08 Thread Steve Ellcey
On Thu, 2015-05-07 at 21:15 +0200, Marek Polacek wrote: On Thu, May 07, 2015 at 12:00:20PM -0600, Jeff Law wrote: OK. Please install if you haven't already. I have not, so will do momentarily. Thanks, Marek Marek, This patch has broken the glibc build. I am not sure if the

Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

2015-05-08 Thread Joseph Myers
On Fri, 8 May 2015, Steve Ellcey wrote: On Thu, 2015-05-07 at 21:15 +0200, Marek Polacek wrote: On Thu, May 07, 2015 at 12:00:20PM -0600, Jeff Law wrote: OK. Please install if you haven't already. I have not, so will do momentarily. Thanks, Marek Marek, This patch has

Re: [RFA] libiberty/mkstemps.c: Include time.h if sys/time.h not available.

2015-05-08 Thread DJ Delorie
* mkstemps.c: #include time.h if HAVE_TIME_H is defined but not HAVE_SYS_TIME_H. Ok.

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Rich Felker
On Fri, May 08, 2015 at 04:50:28PM +, Joseph Myers wrote: On Fri, 8 May 2015, Rich Felker wrote: On Fri, May 08, 2015 at 03:41:31PM +0100, Szabolcs Nagy wrote: I.e. as it stands this patch is not OK for backporting to GCC 5 without further discussion. There is also the

Re: [PATCH 6/6] i386: Implement asm flag outputs

2015-05-08 Thread Jeff Law
On 05/08/2015 12:40 PM, H. Peter Anvin wrote: On 05/07/2015 02:39 PM, Richard Henderson wrote: All jcc mnemonics implemented as =@ to make it easy for someone reading the manual to figure out what condition is desired. One request: would it be possible to get a cpp symbol for this (e.g.

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 04:57 AM, Richard Biener wrote: On Fri, May 8, 2015 at 2:34 AM, Aldy Hernandez al...@redhat.com wrote: Maybe you can split out the Java aliases stuff (that annoyed me multiple times when trying to refactor the FE - middle-end interface). It looks unrelated enough. Thanks,

Re: [PATCH] Add SPECIAL_FLOAT_MODE to enable adding IEEE 128-bit floating point to PowerPC

2015-05-08 Thread Jeff Law
On 05/06/2015 11:29 AM, Michael Meissner wrote: On Wed, May 06, 2015 at 04:03:00PM +0100, Richard Sandiford wrote: Jeff Law l...@redhat.com writes: So my worry here is that folks writing these loops to iterate over modes are going to easily miss the != VOIDmode terminator, or not know when to

Re: [PATCH] Simple optimization for MASK_STORE.

2015-05-08 Thread Richard Biener
On May 8, 2015 8:43:15 PM GMT+02:00, Jeff Law l...@redhat.com wrote: On 05/08/2015 03:27 AM, Richard Biener wrote: On Wed, May 6, 2015 at 4:04 PM, Yuri Rumyantsev ysrum...@gmail.com wrote: Hi All, Here is a patch which gives us significant speed-up on HASWELL for test containing masked

Re: [PATCH][PR66013] Update address_taken after ifn_va_arg expansion

2015-05-08 Thread Tom de Vries
On 08-05-15 17:31, Richard Biener wrote: OK for trunk? As noted in one of the PRs I think that it is the proper time to re-implement the stdarg optimization on the un-lowered form which should also fix this. AFAIU, the implementation of the stdarg optimization on the un-lowered form should

Re: [patch 9/10] debug-early merge: testsuite changes

2015-05-08 Thread Mike Stump
On May 7, 2015, at 5:39 PM, Aldy Hernandez al...@redhat.com wrote: So, I don’t feel there is anything in there for me to review, I’d like the front-end maintainer to review. dearly-testsuite.patch Description: Binary data

Re: [patch 5/10] debug-early merge: Go front-end

2015-05-08 Thread Ian Lance Taylor
This is fine if it works. Thanks. Ian On Thu, May 7, 2015 at 5:36 PM, Aldy Hernandez al...@redhat.com wrote:

Re: [PATCH 5/6] i386: Add CCPmode

2015-05-08 Thread Jeff Law
On 05/07/2015 03:38 PM, Richard Henderson wrote: For testing parity coming out of asm flags. --- gcc/config/i386/i386-modes.def | 2 ++ gcc/config/i386/i386.c | 19 +++ 2 files changed, 13 insertions(+), 8 deletions(-) Seems like it ought to move forward now. Oh

Re: [PATCH] Simple optimization for MASK_STORE.

2015-05-08 Thread Jeff Law
On 05/08/2015 03:27 AM, Richard Biener wrote: On Wed, May 6, 2015 at 4:04 PM, Yuri Rumyantsev ysrum...@gmail.com wrote: Hi All, Here is a patch which gives us significant speed-up on HASWELL for test containing masked stores. The main goal of that patch is attempt to avoid HW hazard for

Re: [patch 0/29] RFC: Use automake-1.11.6 across the tree

2015-05-08 Thread Jeff Law
On 05/07/2015 09:51 AM, Michael Haubenwallner wrote: Are there any cases where you had to do something other than just regenerate the various files? Nope - at least nothing that I would call doing something other. What I did: * touch each configure.ac to ensure automake is really used * do

Re: [patch 5/10] debug-early merge: Go front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 11:08 AM, Ian Lance Taylor wrote: This is fine if it works. Thanks. Ian On Thu, May 7, 2015 at 5:36 PM, Aldy Hernandez al...@redhat.com wrote: As mentioned, no regressions with --enable-languages=go. I will mark the Go changes as approved pending on the rest of the patches

RE: [PATCH 6/13] mips musl support

2015-05-08 Thread Matthew Fortune
Jeff Law l...@redhat.com writes: On 05/08/2015 10:50 AM, Joseph Myers wrote: Note that however the dynamic linker does properly need to save and restore call-clobbered registers used for argument passing (because of IFUNCs, user-provided malloc, audit hooks etc. that might affect them

Re: Question about patch for PR bootstrap/65150 (identical functions)

2015-05-08 Thread Jeff Law
On 05/08/2015 01:07 PM, David Edelsohn wrote: Steve Ellcey wrote: After your change GCC sees that the code for f1 and f2 are identical so it replaced the body of f2 with a call to f1. This optimization will save space but it is not going to be faster because any call to f2 will now include an

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-08 Thread Richard Biener
On May 8, 2015 8:48:26 PM GMT+02:00, Aldy Hernandez al...@redhat.com wrote: On 05/08/2015 04:57 AM, Richard Biener wrote: On Fri, May 8, 2015 at 2:34 AM, Aldy Hernandez al...@redhat.com wrote: Maybe you can split out the Java aliases stuff (that annoyed me multiple times when trying to

Re: [RFA] libiberty/mkstemps.c: Include time.h if sys/time.h not available.

2015-05-08 Thread Jeff Law
On 05/08/2015 08:38 AM, Joel Brobecker wrote: Hello, Attempting to build libiberty on LynxOS-178 fails trying to compile mkstemps.c with the following error: LynxOS? I haven't had to do anything with that since, umm, the early 90s. So sorry you've got that task... libiberty/ChangeLog:

Re: [PATCH 2/6] Merge expand_asm_operands into expand_asm_stmt

2015-05-08 Thread Jeff Law
On 05/07/2015 03:38 PM, Richard Henderson wrote: Prepatory to converting from tree chains to vectors. --- gcc/cfgexpand.c | 167 1 file changed, 72 insertions(+), 95 deletions(-) OK with a ChangeLog and the usual testing. jeff

Re: [debug-early] fix -fdump-go-spec

2015-05-08 Thread Aldy Hernandez
Thanks for working on this. Have you tried building with --enable-languages=go? On a GNU/Linux system it should build and pass all tests with no extra effort. Yes. No regressions. Thanks. Aldy

Re: [patch 8/10] debug-early merge: Objective-C front-end

2015-05-08 Thread Mike Stump
On May 7, 2015, at 5:38 PM, Aldy Hernandez al...@redhat.com wrote: Ok.

Re: [PATCH 6/13] mips musl support

2015-05-08 Thread Jeff Law
On 05/08/2015 08:25 AM, Matthew Fortune wrote: There is also the perspective that we should be able to aim for an ABI variant agnostic dynamic linker at some point over the next year by working towards a build that truly uses no float and is hence compatible with all the ABI variants. Having

Re: genrecog: Address -Wsign-compare diagnostics

2015-05-08 Thread Jeff Law
On 05/08/2015 03:09 AM, Thomas Schwinge wrote: Hi! On Mon, 27 Apr 2015 11:20:30 +0100, Richard Sandiford richard.sandif...@arm.com wrote: This patch [...] by replacing most of genrecog [...] OK to commit? Is it a bug that I'm seeing these warnings only in the stage 1 build with the

Re: [PATCH 6/6] i386: Implement asm flag outputs

2015-05-08 Thread H. Peter Anvin
On 05/07/2015 02:39 PM, Richard Henderson wrote: All jcc mnemonics implemented as =@ to make it easy for someone reading the manual to figure out what condition is desired. One request: would it be possible to get a cpp symbol for this (e.g. __GCC_X86_INLINE_ASM_CC__) so we don't have to

Re: Question about patch for PR bootstrap/65150 (identical functions)

2015-05-08 Thread David Edelsohn
Steve Ellcey wrote: After your change GCC sees that the code for f1 and f2 are identical so it replaced the body of f2 with a call to f1. This optimization will save space but it is not going to be faster because any call to f2 will now include an extra call/return. Do other platforms have

Re: Question about patch for PR bootstrap/65150 (identical functions)

2015-05-08 Thread Jakub Jelinek
On Fri, May 08, 2015 at 01:09:52PM -0600, Jeff Law wrote: On 05/08/2015 01:07 PM, David Edelsohn wrote: Steve Ellcey wrote: After your change GCC sees that the code for f1 and f2 are identical so it replaced the body of f2 with a call to f1. This optimization will save space but it is not

Re: [PATCH 4/6] Convert to md_asm_adjust

2015-05-08 Thread Jeff Law
On 05/07/2015 03:38 PM, Richard Henderson wrote: Using proper vectors instead of lists of trees. --- gcc/cfgexpand.c | 614 --- gcc/config/cris/cris.c | 88 +++ gcc/config/i386/i386.c | 24 +-

  1   2   >