Re: [PR64164] drop copyrename, integrate into expand

2015-08-21 Thread Alexandre Oliva
On Aug 19, 2015, Alexandre Oliva wrote: > On Aug 19, 2015, Alexandre Oliva wrote: >> I'm having some difficulty getting access to an ia64 box ATM, and for >> ada bootstraps, a cross won't do, so... if you still have that build >> tree around, any chance you could recompile par.o with both stage

Re: [PR64164] drop copyrename, integrate into expand

2015-08-21 Thread Alexandre Oliva
On Aug 19, 2015, Alexandre Oliva wrote: > I have verified in the expand dumps that both the gimple and the rtl > representation in the relevant parts of the code are identical, except > for the presence of debug stmts and insns. While comparing the dumps, I noticed -fdump-unnumbered-links no lon

[patch] Remove unsupported hosts/builds from gcc/config.*

2015-08-21 Thread FX
Attached patch removes special cases for the following unsupported targets as build and host environments: - uwin* - i370-*-opened* | i370-*-mvs* - i[34567]86-*-sco3.2v5* - i[34567]86-sequent-ptx4* | i[34567]86-sequent-sysv4* - i[34567]86-*-sysv4* - i[34567]86-*-udk* - i[34567]86-*-uwin* - i386-*

Re: [Scalar masks 2/x] Use bool masks in if-conversion

2015-08-21 Thread Richard Biener
On Thu, Aug 20, 2015 at 8:46 PM, Jeff Law wrote: > On 08/17/2015 10:25 AM, Ilya Enkovich wrote: >> >> Hi, >> >> This patch intoriduces a new vectorizer hook use_scalar_mask_p which >> affects code generated by if-conversion pass (and affects patterns in later >> patches). >> >> Thanks, >> Ilya >>

Re: [RFC]: Vectorization cost benefit changes.

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 7:18 AM, Ajit Kumar Agarwal wrote: > All: > > I have done the vectorization cost changes as given below. I have considered > only the cost associated with the inner instead of outside. > The consideration of inside scalar and vector cost is done as the inner cost > are th

Re: [PR64164] drop copyrename, integrate into expand

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 9:57 AM, Alexandre Oliva wrote: > On Aug 19, 2015, Alexandre Oliva wrote: > >> I have verified in the expand dumps that both the gimple and the rtl >> representation in the relevant parts of the code are identical, except >> for the presence of debug stmts and insns. > > W

Re: [PR64164] drop copyrename, integrate into expand

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 9:46 AM, Alexandre Oliva wrote: > On Aug 19, 2015, Alexandre Oliva wrote: > >> On Aug 19, 2015, Alexandre Oliva wrote: >>> I'm having some difficulty getting access to an ia64 box ATM, and for >>> ada bootstraps, a cross won't do, so... if you still have that build >>> t

Re: Move some flag_unsafe_math_optimizations using simplify and match

2015-08-21 Thread Richard Biener
On Thu, Aug 20, 2015 at 12:58 PM, Richard Biener wrote: > On Thu, Aug 20, 2015 at 11:18 AM, Hurugalawadi, Naveen > wrote: >> Hi, >> Works for me if you specify -fno-math-errno. I think that's a "regression" we can accept. >> >> Modified the pattern with "fno-math-errno" as a condition.

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Paolo Carlini
Hi, On 08/21/2015 08:30 AM, Markus Trippelsdorf wrote: On 2015.08.21 at 08:18 +0200, Markus Trippelsdorf wrote: On 2015.08.19 at 21:46 +0200, Paolo Carlini wrote: Hi, submitter noticed that, in violation of [basic.start.main], we don't reject as ill-formed the declaration of a 'main' variable

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Paolo Carlini
... I'm testing the below. So far appears to work well for me. Paolo. /// Index: cp/decl.c === --- cp/decl.c (revision 227054) +++ cp/decl.c (working copy) @@ -8357,7 +8357,8 @@ grokvardecl (tree type, if (D

RE: [RFC]: Vectorization cost benefit changes.

2015-08-21 Thread Ajit Kumar Agarwal
-Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Friday, August 21, 2015 2:03 PM To: Ajit Kumar Agarwal Cc: Jeff Law; GCC Patches; g...@gcc.gnu.org; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [RFC]: Vectorizatio

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Markus Trippelsdorf
On 2015.08.21 at 11:06 +0200, Paolo Carlini wrote: > ... I'm testing the below. So far appears to work well for me. Yes for me, too. Firefox now builds without any issues. So emitting an error (like clang) is fine after all. Thanks. -- Markus

Re: [PATCH] Fix PRs 66502 and 67167

2015-08-21 Thread Jiong Wang
Richard Biener writes: > Given there is now PR67167 I am going forward with the earlier posted > patch to switch SCCVN to PHI elimination in favor of another PHI > (to remove IVs) rather than in favor of its only executable edge value. > > I still see no way to capture both cases without detectin

Re: [PATCH] Fix PRs 66502 and 67167

2015-08-21 Thread Richard Biener
On Fri, 21 Aug 2015, Jiong Wang wrote: > > Richard Biener writes: > > > Given there is now PR67167 I am going forward with the earlier posted > > patch to switch SCCVN to PHI elimination in favor of another PHI > > (to remove IVs) rather than in favor of its only executable edge value. > > > > I

Re: [RFC][PATCH, ASan] ASan and TSan passes place change.

2015-08-21 Thread Maxim Ostapenko
On 07/08/15 11:42, Maxim Ostapenko wrote: Hi! This tiny patch moves ASan and TSan passes just before sanopt pass, that gives nice speedup on several SPEC2006 tests (-O2 optimization level was used) on x86: TESTCASE ORIGINAL PATCHED SPEEDUP 401.bzip2806798 0.99% 403.gcc

Re: [PATCH] Fix PRs 66502 and 67167

2015-08-21 Thread Jiong Wang
Richard Biener writes: > I see the following ICE: > > t.c:13:1: internal compiler error: in decompose_normal_address, at > rtlanal.c:6090 > } > ^ > 0xc94a37 decompose_normal_address > /space/rguenther/tramp3d/trunk/gcc/rtlanal.c:6090 > 0xc94d25 decompose_address(address_info*, rtx_def*

Re: [Patch] Add to the libgfortran/newlib bodge to "detect" ftruncate support in ARM/AArch64/SH

2015-08-21 Thread James Greenhalgh
On Thu, Aug 20, 2015 at 10:50:47AM +0100, Marcus Shawcroft wrote: > On 20 August 2015 at 09:31, James Greenhalgh wrote: > > > > Hi, > > > > Steve's patch in 2013 [1] to fix the MIPS newlib/libgfortran build > > causes subtle issues for an ARM/AArch64 newlib/libgfortran build. The > > problem is th

Re: [Scalar masks 2/x] Use bool masks in if-conversion

2015-08-21 Thread Ilya Enkovich
2015-08-21 11:15 GMT+03:00 Richard Biener : > On Thu, Aug 20, 2015 at 8:46 PM, Jeff Law wrote: >> On 08/17/2015 10:25 AM, Ilya Enkovich wrote: >>> >>> Hi, >>> >>> This patch intoriduces a new vectorizer hook use_scalar_mask_p which >>> affects code generated by if-conversion pass (and affects patt

[PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
This fixes the libgo breakage. Seems I really should have removed the edge after we split the block with null dereference after __builtin_trap statement so that it's unreachable. Bootstrapped/regtested on x86_64-linux + ppc64-linux + bootstrapped on aarch64-linux, ok for trunk? 2015-08-21 Mare

Re: [Scalar masks 2/x] Use bool masks in if-conversion

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 12:49 PM, Ilya Enkovich wrote: > 2015-08-21 11:15 GMT+03:00 Richard Biener : >> On Thu, Aug 20, 2015 at 8:46 PM, Jeff Law wrote: >>> On 08/17/2015 10:25 AM, Ilya Enkovich wrote: Hi, This patch intoriduces a new vectorizer hook use_scalar_mask_p which >>

RFA: Replace LAST_INSN_CODE with NUM_INSN_CODES

2015-08-21 Thread Richard Sandiford
Claudiu reported that I'd botched the definition of LAST_INSN_CODE in my recent patches to reduce the size of insn_data. I'd defined it as the last valid insn code, whereas it's supposed to be the last valid code +1. This patch replaces LAST_INSN_CODE with a separate NUM_INSN_CODES count, outside

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: > This fixes the libgo breakage. Seems I really should have removed the > edge after we split the block with null dereference after __builtin_trap > statement so that it's unreachable. > > Bootstrapped/regtested on x86_64-linux + ppc64-linux

Re: [PR64164] drop copyrename, integrate into expand

2015-08-21 Thread Andreas Schwab
Alexandre Oliva writes: > PR rtl-optimization/64164 > PR rtl-optimization/67227 > * alias.c (memrefs_conflict_p): Handle VALUEs in PLUS better. > (nonoverlapping_memrefs_p): Test offsets and sizes when given > identical gimple_reg exprs. I can confirm that this fixe

Re: [Scalar masks 2/x] Use bool masks in if-conversion

2015-08-21 Thread Ilya Enkovich
2015-08-21 14:00 GMT+03:00 Richard Biener : > On Fri, Aug 21, 2015 at 12:49 PM, Ilya Enkovich > wrote: >> 2015-08-21 11:15 GMT+03:00 Richard Biener : >>> On Thu, Aug 20, 2015 at 8:46 PM, Jeff Law wrote: On 08/17/2015 10:25 AM, Ilya Enkovich wrote: > > Hi, > > This patch into

Re: [PATCH] [AVX512F] Add scatter support for vectorizer

2015-08-21 Thread Petr Murzin
Hello, Please have a look at updated patch. On Tue, Aug 4, 2015 at 3:15 PM, Richard Biener wrote: > On Fri, 31 Jul 2015, Petr Murzin wrote: > @@ -5586,8 +5770,6 @@ vectorizable_store (gimple stmt, > gimple_stmt_iterator *gsi, gimple *vec_stmt, >prev_stmt_info = NULL; >for (j = 0; j < ncop

Re: [PATCH] [PING] [PR libitm/61164] Remove redefinition of glibc internal macro __always_inline

2015-08-21 Thread Torvald Riegel
On Mon, 2015-08-17 at 13:16 +0200, Gleb Fotengauer-Malinovskiy wrote: > On Sun, Aug 16, 2015 at 07:35:17PM +0200, Torvald Riegel wrote: > > On Thu, 2015-06-11 at 14:36 +0300, Gleb Fotengauer-Malinovskiy wrote: > > > On Fri, May 15, 2015 at 03:04:27PM +0200, Torvald Riegel wrote: > > > > On Wed, 201

Re: [RFC][Scalar masks 1/x] Introduce GEN_MASK_EXPR.

2015-08-21 Thread Ilya Enkovich
2015-08-20 21:41 GMT+03:00 Jeff Law : > On 08/17/2015 10:22 AM, Ilya Enkovich wrote: >> >> Hi, >> >> This patch starts a series introducing scalar masks support in the >> vectorizer. It was discussed on the recent Cauldron and changes overiew is >> available here: >> https://gcc.gnu.org/wiki/cauld

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: > On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: > > This fixes the libgo breakage. Seems I really should have removed the > > edge after we split the block with null dereference after __builtin_trap > > statement so that it'

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Paolo Carlini
Hi, On 08/21/2015 11:23 AM, Markus Trippelsdorf wrote: On 2015.08.21 at 11:06 +0200, Paolo Carlini wrote: ... I'm testing the below. So far appears to work well for me. Yes for me, too. Firefox now builds without any issues. So emitting an error (like clang) is fine after all. Excellent. Testi

Re: [v3 patch] Fix friend declaration so it is visible to name lookup

2015-08-21 Thread Jonathan Wakely
On 21/08/15 00:03 +0200, Paolo Carlini wrote: Hi, On 08/20/2015 10:21 PM, Jonathan Wakely wrote: Jason pointed out this isn't valid, and is going to fail to compile soon with a fix he's making. I seem to remember that at some point we had the exact same issue with some member operator<< and op

RE: Replace LAST_INSN_CODE with NUM_INSN_CODES

2015-08-21 Thread Claudiu Zissulescu
> -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Friday, August 21, 2015 1:15 PM > To: gcc-patches@gcc.gnu.org > Cc: Claudiu Zissulescu; Claudiu Zissulescu; Francois Bedard; Jeff Law > Subject: RFA: Replace LAST_INSN_CODE with NUM_INSN_CODES > > Cla

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: > On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: >> On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: >> > This fixes the libgo breakage. Seems I really should have removed the >> > edge after we split the block with nul

Re: [v3 patch] Fix friend declaration so it is visible to name lookup

2015-08-21 Thread Paolo Carlini
Hi, On 08/21/2015 02:57 PM, Jonathan Wakely wrote: On 21/08/15 00:03 +0200, Paolo Carlini wrote: Hi, On 08/20/2015 10:21 PM, Jonathan Wakely wrote: Jason pointed out this isn't valid, and is going to fail to compile soon with a fix he's making. I seem to remember that at some point we had the

[PATCH] Fix PR61657 (undefined behavior in loop-iv.c)

2015-08-21 Thread Markus Trippelsdorf
bootstrap-ubsan shows: loop-iv.c:2626:14: runtime error: signed integer overflow: 9223372036854775806 - -9223372036854775808 cannot be represented in type 'long int' Fixed by moving the variables in question from signed to unsigned. Bootstrapped and tested on ppc64le. OK for trunk and gcc-5 bra

Re: [PATCH][1/n] dwarf2out refactoring for early (LTO) debug

2015-08-21 Thread Richard Biener
On Thu, 20 Aug 2015, Richard Biener wrote: > On Thu, 20 Aug 2015, Richard Biener wrote: > > > On Wed, 19 Aug 2015, Richard Biener wrote: > > > > > On Tue, 18 Aug 2015, Aldy Hernandez wrote: > > > > > > > On 08/18/2015 07:20 AM, Richard Biener wrote: > > > > > > > > > > This starts a series of

Re: [RFC, PR target/65105] Use vector instructions for scalar 64bit computations on 32bit target

2015-08-21 Thread Ilya Enkovich
2015-08-03 23:52 GMT+03:00 Jeff Law : > On 06/19/2015 07:21 AM, Ilya Enkovich wrote: >> >> Hi, >> >> This patch tries to improve 64bit integer computations on 32bit >> target. This is achieved by an additional i386 target pass which >> searches for all conversion candidates and tries to transfor

Re: [PATCH][ARM]Tighten the conditions for arm_movw, arm_movt

2015-08-21 Thread Renlin Li
On 20/08/15 09:36, Kyrylo Tkachov wrote: On 19/08/15 12:49, Renlin Li wrote: Hi all, This simple patch will tighten the conditions when matching movw and arm_movt rtx pattern. Those two patterns will generate the following assembly: movw w1, #:lower16: dummy + addend movt w1, #:upper16: dumm

Fix PR debug/66728

2015-08-21 Thread Richard Sandiford
This is yet another bug caused by rtx having modeless scalar integer constants. We need to use context to find the actual mode of a CONST_INT or CONST_WIDE_INT. Getting a mode is especially awkward here. Decls have two modes associated with them: TYPE_MODE (TREE_TYPE (decl)) and DECL_MODE (decl)

[PING] Re: [PATCH 0/2] Embed driver within libgccjit

2015-08-21 Thread David Malcolm
On Thu, 2015-08-06 at 10:52 -0400, David Malcolm wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00355.html In particular, I'm hoping for review of patch 1, which provides a way to clean up state within the driver code (patch 2 uses this from libgccjit to embed it in-process, rather

Re: RFA: Replace LAST_INSN_CODE with NUM_INSN_CODES

2015-08-21 Thread Richard Sandiford
Richard Sandiford writes: > Claudiu reported that I'd botched the definition of LAST_INSN_CODE > in my recent patches to reduce the size of insn_data. I'd defined > it as the last valid insn code, whereas it's supposed to be the > last valid code +1. > > This patch replaces LAST_INSN_CODE with a

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: > On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: > > On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: > >> On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: > >> > This fixes the libgo breakage. Seems I re

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Jeff Law
On 08/21/2015 08:41 AM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: This fixe

[gomp4] partitioned mode reorg

2015-08-21 Thread Nathan Sidwell
I've committed this patch to: 1) Remove the partitioning field I recently added to call_insn patterns. It will not be needed. 2) Change the fork/join and associated instructions and machinery to have a partioning mask, rather than a mode. This allows them to specify multiple modes concurre

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Jeff Law
On 08/21/2015 08:41 AM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: This fixe

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Jason Merrill
On 08/21/2015 05:06 AM, Paolo Carlini wrote: if (DECL_NAME (decl) && MAIN_NAME_P (DECL_NAME (decl)) - && CP_DECL_CONTEXT (decl) == global_namespace) + && CP_DECL_CONTEXT (decl) == global_namespace + && !at_function_scope_p ()) How about looking at the "scope" local va

Re: [Scalar masks 2/x] Use bool masks in if-conversion

2015-08-21 Thread Jeff Law
On 08/21/2015 02:15 AM, Richard Biener wrote: Indeed. I don't remember my exact comments during the talk at the Cauldron but the scheme used there was sth like mask = GEN_MASK ; b = a + 1; x = VEC_COND to model conditional execution already at the if-conversion stage (for all scalar stmts ma

Re: [RFC][Scalar masks 1/x] Introduce GEN_MASK_EXPR.

2015-08-21 Thread Jeff Law
On 08/21/2015 06:30 AM, Ilya Enkovich wrote: 2015-08-20 21:41 GMT+03:00 Jeff Law : 2015-08-17 Ilya Enkovich * expr.c (expand_expr_real_2): Support GEN_MASK_EXPR. * gimple-pretty-print.c (dump_unary_rhs): Likewise. * gimple.c (get_gimple_rhs_num_ops): Likewise.

Re: [RFC, patch] New attribute to create target clones

2015-08-21 Thread Jeff Law
On 08/20/2015 05:38 PM, Evgeny Stupachenko wrote: On Mon, Aug 3, 2015 at 9:43 PM, Jeff Law wrote: On 07/30/2015 04:19 PM, Evgeny Stupachenko wrote: Hi All, The patch enables new attribute 'ctarget', The attribute force compiler to create clones of a function with the attribute. For example:

Re: [patch] Remove unsupported hosts/builds from gcc/config.*

2015-08-21 Thread Jeff Law
On 08/21/2015 02:10 AM, FX wrote: Attached patch removes special cases for the following unsupported targets as build and host environments: - uwin* - i370-*-opened* | i370-*-mvs* - i[34567]86-*-sco3.2v5* - i[34567]86-sequent-ptx4* | i[34567]86-sequent-sysv4* - i[34567]86-*-sysv4* - i[34567]86-

Re: Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time)

2015-08-21 Thread Nathan Sidwell
On 08/20/15 18:52, Joseph Myers wrote: On Tue, 18 Aug 2015, Thomas Schwinge wrote: This is what I've committed to gomp-4_0-branch, with the driver changes substantially cleaned up and smaller changes to the other bits of the patch. gcc: 2015-08-20 Thomas Schwinge Joseph Myers

Re: Fix PR debug/66728

2015-08-21 Thread Jeff Law
On 08/21/2015 07:58 AM, Richard Sandiford wrote: This is yet another bug caused by rtx having modeless scalar integer constants. We need to use context to find the actual mode of a CONST_INT or CONST_WIDE_INT. We've been bumping into these as long as I can remember. I suspect I still have a gr

Re: RFA: Replace LAST_INSN_CODE with NUM_INSN_CODES

2015-08-21 Thread Jeff Law
On 08/21/2015 08:36 AM, Richard Sandiford wrote: Richard Sandiford writes: Claudiu reported that I'd botched the definition of LAST_INSN_CODE in my recent patches to reduce the size of insn_data. I'd defined it as the last valid insn code, whereas it's supposed to be the last valid code +1. T

Re: Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time)

2015-08-21 Thread Joseph Myers
On Fri, 21 Aug 2015, Nathan Sidwell wrote: > this appears to cause an ICE in add_omp_infile_spec_func at; > gcc_assert (offload_targets != NULL); > > when you use something like -foffload='-save-temps -v -fdump-rtl-all > -fdump-tree-all -fno-verbose-asm' > > Is that use ill-formed? I'll need

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On August 21, 2015 5:09:46 PM GMT+02:00, Jeff Law wrote: >On 08/21/2015 08:41 AM, Marek Polacek wrote: >> On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: >>> On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek >wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote:

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On August 21, 2015 5:09:46 PM GMT+02:00, Jeff Law wrote: >On 08/21/2015 08:41 AM, Marek Polacek wrote: >> On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: >>> On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek >wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote:

Re: [RFC][Scalar masks 1/x] Introduce GEN_MASK_EXPR.

2015-08-21 Thread Ilya Enkovich
2015-08-21 18:57 GMT+03:00 Jeff Law : > On 08/21/2015 06:30 AM, Ilya Enkovich wrote: >> >> 2015-08-20 21:41 GMT+03:00 Jeff Law : > > 2015-08-17 Ilya Enkovich * expr.c (expand_expr_real_2): Support GEN_MASK_EXPR. * gimple-pretty-print.c (dump_unary_rh

Re: [RFC, PR target/65105] Use vector instructions for scalar 64bit computations on 32bit target

2015-08-21 Thread Jeff Law
On 08/21/2015 07:44 AM, Ilya Enkovich wrote: Our of curiosity, what does LLVM do here in terms of costing models? Unfortunately I have no idea where and how LLVM does this optimization. Will try to find out. For now I just try to follow a common sense and don't hurt any benchmark performance. S

Re: [PATCH] Fix PR61657 (undefined behavior in loop-iv.c)

2015-08-21 Thread Jeff Law
On 08/21/2015 07:40 AM, Markus Trippelsdorf wrote: bootstrap-ubsan shows: loop-iv.c:2626:14: runtime error: signed integer overflow: 9223372036854775806 - -9223372036854775808 cannot be represented in type 'long int' Fixed by moving the variables in question from signed to unsigned. Bootstr

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: > >> Yes, but gimple_call_noreturn_p is false on __builtin_trap. That's > >quite > >> confusing... but flags_from_decl_or_type really returns 0 for > >__builtin_trap. > >Well, if that's intentional (and offhand I have no idea if it is

[gomp4] nvptx reductions

2015-08-21 Thread Cesar Philippidis
This patch implements the the goacc.reduction hook introduced here for the nvptx target. Each new nvptx_goacc_reduction_* function is commented with a description of how each internal function gets implemented for each parallel dimension. N

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Paolo Carlini
Hi, On 08/21/2015 05:37 PM, Jason Merrill wrote: On 08/21/2015 05:06 AM, Paolo Carlini wrote: if (DECL_NAME (decl) && MAIN_NAME_P (DECL_NAME (decl)) - && CP_DECL_CONTEXT (decl) == global_namespace) + && CP_DECL_CONTEXT (decl) == global_namespace + && !at_function_scop

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On August 21, 2015 6:42:15 PM GMT+02:00, Marek Polacek wrote: >On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: >> >> Yes, but gimple_call_noreturn_p is false on __builtin_trap. >That's >> >quite >> >> confusing... but flags_from_decl_or_type really returns 0 for >> >__builtin_tra

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-21 Thread Jason Merrill
On 08/21/2015 01:11 PM, Paolo Carlini wrote: Ah nice. Simply checking: scope == global_namespace appears to work great. Shall I go with that if testing is fine? Please. Jason

Re: [gomp4] nvptx reductions

2015-08-21 Thread Nathan Sidwell
On 08/21/15 12:52, Cesar Philippidis wrote: Is this patch ok for gomp-4_0-branch after the infrastructure patch goes in? Ok by me, thanks. nathan

Re: [RFC PATCH] parse #pragma GCC diagnostic in libcpp

2015-08-21 Thread Manuel López-Ibáñez
Any comments on this? https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02414.html I don't see any other way to fix these PRs, but I don't know how to keep the pragmas from being deleted by the preprocessor. Cheers, Manuel. On 29 July 2015 at 00:46, Manuel López-Ibáñez wrote: > Currently, #pragma

Re: [patch] Remove unsupported hosts/builds from gcc/config.*

2015-08-21 Thread FX
> OK Thanks. Committed, along with the additional patch for m68k-hp-hpux*, which I had forgotten (but was deprecated in 2008 along with the others). FX Index: ChangeLog === --- ChangeLog (revision 227077) +++ ChangeLog (worki

[gomp4] GOMP_DIM_MASK tweak

2015-08-21 Thread Nathan Sidwell
I've installed this to make GOMP_DIM_MASK return an unsigned type -- I tripped over some signed/unsigned compare warnings. nathan 2015-08-21 Nathan Sidwell * gomp-constants.h (GOMP_DIM_MASK): Generate unsigned. Index: gomp-constants.h ===

Re: [patch] Remove unsupported hosts/builds from gcc/config.*

2015-08-21 Thread Jeff Law
On 08/21/2015 11:44 AM, FX wrote: OK Thanks. Committed, along with the additional patch for m68k-hp-hpux*, which I had forgotten (but was deprecated in 2008 along with the others). No problem. m68k-hp-hpux has been a dead platform for ~20 years. I used to run 2.0.1B on my 9836 and 9920 machi

C++ PATCH for c++/67240 (implicit conversion constraint)

2015-08-21 Thread Jason Merrill
perform_direct_initialization_if_possible returns NULL_TREE if no conversion is possible. Tested x86_64-pc-linux-gnu, applying to trunk. commit d25eb4518d272d25dbd63d0d4802102be0a2ca08 Author: Jason Merrill Date: Fri Aug 21 12:14:48 2015 -0400 PR c++/67240 * constraint.cc (satisfy_

[gomp4] fix breakage

2015-08-21 Thread Nathan Sidwell
Alas, I broke gomp4 nvptx build. Fixed thusly. nathan 2015-08-21 Nathan Sidwell * config/nvptx/nvptx.md (oacc_fork, oacc_join): Adjust expand calls. * config/nvptx/nvptx.c (nvptx_emit_forking, nvptx_emit_joining): New. Broken out of ... (nvptx_expand_oacc_fork, nvptx_expand_oacc_join): .

Re: Add irreflexive comparison debug check

2015-08-21 Thread François Dumont
On 01/08/2015 02:25, Jonathan Wakely wrote: > On 31 July 2015 at 20:49, François Dumont wrote: >> On 30/07/2015 12:30, Jonathan Wakely wrote: >>> On 29/07/15 22:08 +0200, François Dumont wrote: Standard algos signatures are such that there is no guaranty that the operator < or predicat

[nvptx] alloca & stack alignment

2015-08-21 Thread Nathan Sidwell
I've committed this to fix up 1) alloca. PTX defines but doesn't implement support. and if one passes types suitable for a 64-bit ABI ptxas emits errors. This patch gives a clear error at compilation time, rather than an obscure failure later. 2) In an effort to reduce when alloca is implic

[gomp4] don't use VLA's in the reduction tests

2015-08-21 Thread Cesar Philippidis
Nathan noticed that I was using VLA's in the a couple of compile-time reduction tests. That's bad because ptx doesn't have support alloca. I guess these tests used to pass because we were only running them on the host. I'll apply this patch shortly. Cesar 2015-08-21 Cesar Philippidis gcc/tes

RE: [PATCH, MIPS] Compact branch support for MIPS32R6/MIPS64R6

2015-08-21 Thread Moore, Catherine
Hi Matthew: > -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Monday, August 17, 2015 6:47 PM > To: Moore, Catherine; 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) > Subject: RE: [PATCH, MIPS] Compact branch support for MIPS32R6/MIPS64R6 > One

[gomp4] force vector size to 32

2015-08-21 Thread Nathan Sidwell
I've committed this patch to force the vector_length to constant 32. This helps in 2 places 1) Cesar's reduction patch set made this assumption, as we can't emit a loop for vector reductions, as he explained. 2) Routines can now optimize on this axis knowing it is 32. The only case lost is

[gomp4] lowering OpenACC reductions

2015-08-21 Thread Cesar Philippidis
This patch teaches omplower how to utilize the new OpenACC reduction framework described in Nathan's document, which was posted here . Here is the infrastructure patch , and here's th

Re: Elimitate duplication of get_catalogs in different abi

2015-08-21 Thread François Dumont
On 05/08/2015 22:57, Jonathan Wakely wrote: > On 30/07/15 21:57 +0200, François Dumont wrote: >> It seems that this patch results in unresolved symbols. >> >> I am quite sure that the code is right but build system should be >> adapted. >> >> I noticed that *_cow.cc files are built with -fimplicit-

Re: [PATCH 1/2] C++-ify dominance.c

2015-08-21 Thread Mikhail Maltsev
On 08/18/2015 10:00 PM, Jeff Law wrote: > On 08/14/2015 10:02 PM, Mikhail Maltsev wrote: >> >> gcc/ChangeLog: >> >> 2015-08-15 Mikhail Maltsev >> >> * dominance.c (new_zero_array): Define. >> (dom_info): Redefine as class with proper encapsulation. >> (dom_info::m_n_ba